Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] drm/i915: Acquire connector reference before prop_work
@ 2020-10-27 10:33 Kamati Srinivas
  2020-10-28  1:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Kamati Srinivas @ 2020-10-27 10:33 UTC (permalink / raw)
  To: intel-gfx; +Cc: seanpaul, hariom.pandey

From: Srinivas Kamati <srinivasx.k@intel.com>

"Content protection type change" igt test results in kernel
taint. Everytime after prop_work is done we are also
giving up connector reference, which is resulting in ref
count underrun.

Before scheduling prop_work acquire connector reference.

Cc: Sean Paul <seanpaul@chromium.org>
Cc: Ramalingam C <ramalingam.c@intel.com>
Signed-off-by: Srinivas Kamati <srinivasx.k@intel.com>
---
 drivers/gpu/drm/i915/display/intel_hdcp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
index b2a4bbcfdcd2..beedd672b21e 100644
--- a/drivers/gpu/drm/i915/display/intel_hdcp.c
+++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
@@ -2210,6 +2210,7 @@ void intel_hdcp_update_pipe(struct intel_atomic_state *state,
 	if (content_protection_type_changed) {
 		mutex_lock(&hdcp->mutex);
 		hdcp->value = DRM_MODE_CONTENT_PROTECTION_DESIRED;
+		drm_connector_get(&connector->base);
 		schedule_work(&hdcp->prop_work);
 		mutex_unlock(&hdcp->mutex);
 	}
-- 
2.25.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-10-28  9:22 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-27 10:33 [Intel-gfx] drm/i915: Acquire connector reference before prop_work Kamati Srinivas
2020-10-28  1:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-10-28  4:08 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-10-28  9:04 ` [Intel-gfx] " Anshuman Gupta
2020-10-28  9:22   ` K, SrinivasX

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox