Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Sang <oliver.sang@intel.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: feng.tang@intel.com, tiejun.li@intel.com,
	Chris Wilson <chris@chris-wilson.co.uk>,
	frank.du@intel.com, guobing.chen@intel.com, jiebin.sun@intel.com,
	Shuhua.Fan@intel.com, Matthew Auld <matthew.auld@intel.com>,
	fan.zhao@intel.com, ying.huang@intel.com, shan.kang@intel.com,
	zhengjun.xing@intel.com, zhengjun.xing@linux.intel.com,
	Wenhuan.Huang@intel.com, intel-gfx@lists.freedesktop.org,
	guangli.li@intel.com, gengxin.xie@intel.com,
	ming.a.chen@intel.com, yu.ma@intel.com, jessica.ji@intel.com,
	lkp@lists.01.org, wangyang.guo@intel.com, dapeng1.mi@intel.com,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Intel-gfx] [drm/i915/gem] 59dd13ad31: phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second -54.0% regression
Date: Thu, 19 Nov 2020 15:20:18 +0800	[thread overview]
Message-ID: <20201119072018.GA15197@xsang-OptiPlex-9020> (raw)
In-Reply-To: <160527763346.5566.3471508802857132043@jlahtine-mobl.ger.corp.intel.com>

On Fri, Nov 13, 2020 at 04:27:13PM +0200, Joonas Lahtinen wrote:
> Hi,
> 
> Could you add intel-gfx@lists.freedesktop.org into reports going
> forward.
> 
> Quoting kernel test robot (2020-11-11 17:58:11)
> > 
> > Greeting,
> > 
> > FYI, we noticed a -54.0% regression of phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second due to commit:
> 
> How many runs are there on the bad version to ensure the bisect is
> repeatable?

test 4 times.
zxing@inn:/result/phoronix-test-suite/performance-true-Radial_Gradient_Paint-1024x1024-jxrendermark-1.2.4-ucode=0xd6-monitor=da39a3ee/lkp-cfl-d1/debian-x86_64-phoronix/x86_64-rhel-8.3/gcc-9/59dd13ad310793757e34afa489dd6fc8544fc3da$ grep -r "operations_per_second" */stats.json
0/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4133.487932,
1/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4120.421503,
2/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4188.414835,
3/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4068.549514,

> 
> According to Chris test has various factors affecting why the result
> could fluctuate and has been known. Reverting the patch did not have
> an effect on the benchmark and was not expected to do so, either.
> 
> Is there some mechanism to queue a re-run?
> 
> Would it make sense to do further runs before sending out the e-mail
> to avoid false positives.
> 
> It could of course be also solved by sticking to tests that have less
> fluctuation in them.
> 
> Regards, Joonas
> 
> > 
> > 
> > commit: 59dd13ad310793757e34afa489dd6fc8544fc3da ("drm/i915/gem: Flush coherency domains on first set-domain-ioctl")
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> > 
> > 
> > in testcase: phoronix-test-suite
> > on test machine: 12 threads Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz with 8G memory
> > with following parameters:
> > 
> >         need_x: true
> >         test: jxrendermark-1.2.4
> >         option_a: Radial Gradient Paint
> >         option_b: 1024x1024
> >         cpufreq_governor: performance
> >         ucode: 0xd6
> > 
> > test-description: The Phoronix Test Suite is the most comprehensive testing and benchmarking platform available that provides an extensible framework for which new tests can be easily added.
> > test-url: http://www.phoronix-test-suite.com/
> > 
> > 
> > 
> > If you fix the issue, kindly add following tag
> > Reported-by: kernel test robot <oliver.sang@intel.com>
> > 
> > 
> > Details are as below:
> > -------------------------------------------------------------------------------------------------->
> > 
> > 
> > To reproduce:
> > 
> >         git clone https://github.com/intel/lkp-tests.git
> >         cd lkp-tests
> >         bin/lkp install job.yaml  # job file is attached in this email
> >         bin/lkp run     job.yaml
> > 
> > =========================================================================================
> > compiler/cpufreq_governor/kconfig/need_x/option_a/option_b/rootfs/tbox_group/test/testcase/ucode:
> >   gcc-9/performance/x86_64-rhel-8.3/true/Radial Gradient Paint/1024x1024/debian-x86_64-phoronix/lkp-cfl-d1/jxrendermark-1.2.4/phoronix-test-suite/0xd6
> > 
> > commit: 
> >   0dccdba51e ("Merge tag 'gvt-fixes-2020-10-30' of https://github.com/intel/gvt-linux into drm-intel-fixes")
> >   59dd13ad31 ("drm/i915/gem: Flush coherency domains on first set-domain-ioctl")
> > 
> > 0dccdba51e852271 59dd13ad310793757e34afa489d 
> > ---------------- --------------------------- 
> >          %stddev     %change         %stddev
> >              \          |                \  
> >       8980 ±  2%     -54.0%       4127        phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second
> >       9.00           +13.9%      10.25 ±  4%  phoronix-test-suite.time.percent_of_cpu_this_job_got
> > 
> > 
> >                                                                                 
> >                                                                                 
> >                                                                                 
> >   10000 +-------------------------------------------------------------------+   
> >         |                                                                   |   
> >    9000 |-+.+. .+.+.+.+.+.   .+. .+.   .+. .+.+.     .+. .+.   .+. .+.+.   .|   
> >         |.+   +           +.+   +   +.+   +     +.+.+   +   +.+   +     +.+ |   
> >         |                                                                   |   
> >    8000 |-+                                                                 |   
> >         |                                                                   |   
> >    7000 |-+                                                                 |   
> >         |                                                                   |   
> >    6000 |-+                                                                 |   
> >         |                                                                   |   
> >         |                                                                   |   
> >    5000 |-+                                                                 |   
> >         |                                 O                                 |   
> >    4000 +-------------------------------------------------------------------+   
> >                                                                                 
> >                                                                                 
> > [*] bisect-good sample
> > [O] bisect-bad  sample
> > 
> > 
> > 
> > Disclaimer:
> > Results have been estimated based on internal Intel analysis and are provided
> > for informational purposes only. Any difference in system hardware or software
> > design or configuration may affect actual performance.
> > 
> > 
> > Thanks,
> > Oliver Sang
> > 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

       reply	other threads:[~2020-11-19  7:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201111155811.GB24657@xsang-OptiPlex-9020>
     [not found] ` <160527763346.5566.3471508802857132043@jlahtine-mobl.ger.corp.intel.com>
2020-11-19  7:20   ` Oliver Sang [this message]
2020-11-24 20:47     ` [Intel-gfx] [drm/i915/gem] 59dd13ad31: phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second -54.0% regression Chris Wilson
2020-11-26  1:44       ` Xing Zhengjun
2020-11-26 21:34         ` Chris Wilson
2020-11-27  1:51           ` Xing Zhengjun
2020-11-27 13:07             ` Chris Wilson
     [not found]   ` <df7e1556-ee01-ad27-1abb-ffe5d74567b7@intel.com>
2020-12-10 13:07     ` Joonas Lahtinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201119072018.GA15197@xsang-OptiPlex-9020 \
    --to=oliver.sang@intel.com \
    --cc=Shuhua.Fan@intel.com \
    --cc=Wenhuan.Huang@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dapeng1.mi@intel.com \
    --cc=fan.zhao@intel.com \
    --cc=feng.tang@intel.com \
    --cc=frank.du@intel.com \
    --cc=gengxin.xie@intel.com \
    --cc=guangli.li@intel.com \
    --cc=guobing.chen@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jessica.ji@intel.com \
    --cc=jiebin.sun@intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@lists.01.org \
    --cc=matthew.auld@intel.com \
    --cc=ming.a.chen@intel.com \
    --cc=shan.kang@intel.com \
    --cc=tiejun.li@intel.com \
    --cc=wangyang.guo@intel.com \
    --cc=ying.huang@intel.com \
    --cc=yu.ma@intel.com \
    --cc=zhengjun.xing@intel.com \
    --cc=zhengjun.xing@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox