From: Xing Zhengjun <zhengjun.xing@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Oliver Sang <oliver.sang@intel.com>
Cc: feng.tang@intel.com, tiejun.li@intel.com, guangli.li@intel.com,
frank.du@intel.com, guobing.chen@intel.com, jiebin.sun@intel.com,
Shuhua.Fan@intel.com, Matthew Auld <matthew.auld@intel.com>,
fan.zhao@intel.com, ying.huang@intel.com, shan.kang@intel.com,
zhengjun.xing@intel.com, Wenhuan.Huang@intel.com,
intel-gfx@lists.freedesktop.org, lkp@lists.01.org,
ming.a.chen@intel.com, yu.ma@intel.com, jessica.ji@intel.com,
dapeng1.mi@intel.com, wangyang.guo@intel.com,
LKML <linux-kernel@vger.kernel.org>,
gengxin.xie@intel.com
Subject: Re: [Intel-gfx] [drm/i915/gem] 59dd13ad31: phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second -54.0% regression
Date: Fri, 27 Nov 2020 09:51:41 +0800 [thread overview]
Message-ID: <e14d546c-b1c6-448b-d8ac-50d072802c98@linux.intel.com> (raw)
In-Reply-To: <160642644736.15379.9850669928715684163@build.alporthouse.com>
On 11/27/2020 5:34 AM, Chris Wilson wrote:
> Quoting Xing Zhengjun (2020-11-26 01:44:55)
>>
>>
>> On 11/25/2020 4:47 AM, Chris Wilson wrote:
>>> Quoting Oliver Sang (2020-11-19 07:20:18)
>>>> On Fri, Nov 13, 2020 at 04:27:13PM +0200, Joonas Lahtinen wrote:
>>>>> Hi,
>>>>>
>>>>> Could you add intel-gfx@lists.freedesktop.org into reports going
>>>>> forward.
>>>>>
>>>>> Quoting kernel test robot (2020-11-11 17:58:11)
>>>>>>
>>>>>> Greeting,
>>>>>>
>>>>>> FYI, we noticed a -54.0% regression of phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second due to commit:
>>>>>
>>>>> How many runs are there on the bad version to ensure the bisect is
>>>>> repeatable?
>>>>
>>>> test 4 times.
>>>> zxing@inn:/result/phoronix-test-suite/performance-true-Radial_Gradient_Paint-1024x1024-jxrendermark-1.2.4-ucode=0xd6-monitor=da39a3ee/lkp-cfl-d1/debian-x86_64-phoronix/x86_64-rhel-8.3/gcc-9/59dd13ad310793757e34afa489dd6fc8544fc3da$ grep -r "operations_per_second" */stats.json
>>>> 0/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4133.487932,
>>>> 1/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4120.421503,
>>>> 2/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4188.414835,
>>>> 3/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4068.549514,
>>>
>>> a w/o revert (drm-tip)
>>> b w/ revert
>>> +mB----------------------------------------------------------------------------+
>>> | ..b |
>>> | ..b.aa |
>>> | ....a.a |
>>> | ....a.a |
>>> | b b ........a |
>>> | b b b b......... a |
>>> | b bb bbb........... |
>>> |b ab bbab.bb.b............ba b a a ab a|
>>> | |__A__| |
>>> | |MA_| |
>>> +------------------------------------------------------------------------------+
>>> N Min Max Median Avg Stddev
>>> a 120 3621.8761 7356.4442 4606.7895 4607.9132 156.17693
>>> b 120 2664.0563 6359.9686 4519.5036 4534.4463 95.471121
>>>
>>> The patch is not expected to have any impact on the machine you are testing on.
>>> -Chris
>>>
>>
>> What's your code base?
>> For my side:
>> 1) sync the code to the head of Linux mainline
>> 2) git reset --hard 59dd13ad31
>> 3) git revert 59dd13ad3107
>> We compare the test result of commit 59dd13ad3107 (step 2) and
>> 2052847b06f8 (step 3, revert 59dd13ad3107), the regression should
>> related with 59dd13ad3107. Each test case we run 5 times.
>
> a 59dd13ad31
> b revert
> +mB----------------------------------------------------------------------------+
> | a |
> | aa |
> | .b....ba |
> | .b....baa b |
> | .........b . b b |
> | a b.......... ..bb b b |
> | b a b.............b.a b b |
> |a a b. .aaa..b.............b..b....ab b a .|
> | |__A__| |
> | |___A_____| |
> +------------------------------------------------------------------------------+
> N Min Max Median Avg Stddev
> a 120 3658.3435 6363.7812 4527.4406 4536.612 86.095459
> b 120 3928.9643 6375.829 4576.0482 4585.4224 157.284
>
Could you share with me your test commands and the hardware info, then I
can reproduce it on my side? Thanks.
--
Zhengjun Xing
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-11-27 1:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201111155811.GB24657@xsang-OptiPlex-9020>
[not found] ` <160527763346.5566.3471508802857132043@jlahtine-mobl.ger.corp.intel.com>
2020-11-19 7:20 ` [Intel-gfx] [drm/i915/gem] 59dd13ad31: phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second -54.0% regression Oliver Sang
2020-11-24 20:47 ` Chris Wilson
2020-11-26 1:44 ` Xing Zhengjun
2020-11-26 21:34 ` Chris Wilson
2020-11-27 1:51 ` Xing Zhengjun [this message]
2020-11-27 13:07 ` Chris Wilson
[not found] ` <df7e1556-ee01-ad27-1abb-ffe5d74567b7@intel.com>
2020-12-10 13:07 ` Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e14d546c-b1c6-448b-d8ac-50d072802c98@linux.intel.com \
--to=zhengjun.xing@linux.intel.com \
--cc=Shuhua.Fan@intel.com \
--cc=Wenhuan.Huang@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=dapeng1.mi@intel.com \
--cc=fan.zhao@intel.com \
--cc=feng.tang@intel.com \
--cc=frank.du@intel.com \
--cc=gengxin.xie@intel.com \
--cc=guangli.li@intel.com \
--cc=guobing.chen@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jessica.ji@intel.com \
--cc=jiebin.sun@intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@lists.01.org \
--cc=matthew.auld@intel.com \
--cc=ming.a.chen@intel.com \
--cc=oliver.sang@intel.com \
--cc=shan.kang@intel.com \
--cc=tiejun.li@intel.com \
--cc=wangyang.guo@intel.com \
--cc=ying.huang@intel.com \
--cc=yu.ma@intel.com \
--cc=zhengjun.xing@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox