* [Intel-gfx] [PATCH 1/3] drm/i915: Sanitycheck device iomem on probe
2021-12-08 10:20 [Intel-gfx] [PATCH 0/3] drm/i915: Sanity Check for device memory region Ramalingam C
@ 2021-12-08 10:20 ` Ramalingam C
2021-12-08 11:12 ` Matthew Auld
2021-12-08 10:20 ` [Intel-gfx] [PATCH 2/3] drm/i915: Test all device memory on probing Ramalingam C
` (4 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Ramalingam C @ 2021-12-08 10:20 UTC (permalink / raw)
To: intel-gfx, dri-devel
Cc: Andi, Chris Wilson, CQ Tang, Hellstrom Thomas, Matthew Auld
From: Chris Wilson <chris@chris-wilson.co.uk>
As we setup the memory regions for the device, give each a quick test to
verify that we can read and write to the full iomem range. This ensures
that our physical addressing for the device's memory is correct, and
some reassurance that the memory is functional.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: CQ Tang <cq.tang@intel.com>
Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
---
drivers/gpu/drm/i915/intel_memory_region.c | 104 +++++++++++++++++++++
1 file changed, 104 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_memory_region.c b/drivers/gpu/drm/i915/intel_memory_region.c
index b43121609e25..c53e07f1d0c0 100644
--- a/drivers/gpu/drm/i915/intel_memory_region.c
+++ b/drivers/gpu/drm/i915/intel_memory_region.c
@@ -3,6 +3,8 @@
* Copyright © 2019 Intel Corporation
*/
+#include <linux/prandom.h>
+
#include "intel_memory_region.h"
#include "i915_drv.h"
#include "i915_ttm_buddy_manager.h"
@@ -29,6 +31,99 @@ static const struct {
},
};
+static int __iopagetest(struct intel_memory_region *mem,
+ u8 __iomem *va, int pagesize,
+ u8 value, resource_size_t offset,
+ const void *caller)
+{
+ int byte = prandom_u32_max(pagesize);
+ u8 result[3];
+
+ memset_io(va, value, pagesize); /* or GPF! */
+ wmb();
+
+ result[0] = ioread8(va);
+ result[1] = ioread8(va + byte);
+ result[2] = ioread8(va + pagesize - 1);
+ if (memchr_inv(result, value, sizeof(result))) {
+ dev_err(mem->i915->drm.dev,
+ "Failed to read back from memory region:%pR at [%pa + %pa] for %ps; wrote %x, read (%x, %x, %x)\n",
+ &mem->region, &mem->io_start, &offset, caller,
+ value, result[0], result[1], result[2]);
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
+static int iopagetest(struct intel_memory_region *mem,
+ resource_size_t offset,
+ const void *caller)
+{
+ const u8 val[] = { 0x0, 0xa5, 0xc3, 0xf0 };
+ void __iomem *va;
+ int err;
+ int i;
+
+ va = ioremap_wc(mem->io_start + offset, PAGE_SIZE);
+ if (!va) {
+ dev_err(mem->i915->drm.dev,
+ "Failed to ioremap memory region [%pa + %px] for %ps\n",
+ &mem->io_start, &offset, caller);
+ return -EFAULT;
+ }
+
+ for (i = 0; i < ARRAY_SIZE(val); i++) {
+ err = __iopagetest(mem, va, PAGE_SIZE, val[i], offset, caller);
+ if (err)
+ break;
+
+ err = __iopagetest(mem, va, PAGE_SIZE, ~val[i], offset, caller);
+ if (err)
+ break;
+ }
+
+ iounmap(va);
+ return err;
+}
+
+static resource_size_t random_page(resource_size_t last)
+{
+ /* Limited to low 44b (16TiB), but should suffice for a spot check */
+ return prandom_u32_max(last >> PAGE_SHIFT) << PAGE_SHIFT;
+}
+
+static int iomemtest(struct intel_memory_region *mem, const void *caller)
+{
+ resource_size_t last = resource_size(&mem->region) - PAGE_SIZE;
+ int err;
+
+ /*
+ * Quick test to check read/write access to the iomap (backing store).
+ *
+ * Write a byte, read it back. If the iomapping fails, we expect
+ * a GPF preventing further execution. If the backing store does not
+ * exist, the read back will return garbage. We check a couple of pages,
+ * the first and last of the specified region to confirm the backing
+ * store + iomap does cover the entire memory region; and we check
+ * a random offset within as a quick spot check for bad memory.
+ */
+
+ err = iopagetest(mem, 0, caller);
+ if (err)
+ return err;
+
+ err = iopagetest(mem, last, caller);
+ if (err)
+ return err;
+
+ err = iopagetest(mem, random_page(last), caller);
+ if (err)
+ return err;
+
+ return 0;
+}
+
struct intel_memory_region *
intel_memory_region_lookup(struct drm_i915_private *i915,
u16 class, u16 instance)
@@ -126,8 +221,17 @@ intel_memory_region_create(struct drm_i915_private *i915,
goto err_free;
}
+ if (io_start && IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)) {
+ err = iomemtest(mem, (void *)_RET_IP_);
+ if (err)
+ goto err_release;
+ }
+
return mem;
+err_release:
+ if (mem->ops->release)
+ mem->ops->release(mem);
err_free:
kfree(mem);
return ERR_PTR(err);
--
2.20.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [Intel-gfx] [PATCH 1/3] drm/i915: Sanitycheck device iomem on probe
2021-12-08 10:20 ` [Intel-gfx] [PATCH 1/3] drm/i915: Sanitycheck device iomem on probe Ramalingam C
@ 2021-12-08 11:12 ` Matthew Auld
2021-12-08 11:15 ` Ramalingam C
0 siblings, 1 reply; 12+ messages in thread
From: Matthew Auld @ 2021-12-08 11:12 UTC (permalink / raw)
To: Ramalingam C, intel-gfx, dri-devel
Cc: CQ Tang, Hellstrom Thomas, Andi, Chris Wilson
On 08/12/2021 10:20, Ramalingam C wrote:
> From: Chris Wilson <chris@chris-wilson.co.uk>
>
> As we setup the memory regions for the device, give each a quick test to
> verify that we can read and write to the full iomem range. This ensures
> that our physical addressing for the device's memory is correct, and
> some reassurance that the memory is functional.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: CQ Tang <cq.tang@intel.com>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
For the series, assuming CI is happy now,
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Also patch 3 should be moved to the start of the series.
> ---
> drivers/gpu/drm/i915/intel_memory_region.c | 104 +++++++++++++++++++++
> 1 file changed, 104 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_memory_region.c b/drivers/gpu/drm/i915/intel_memory_region.c
> index b43121609e25..c53e07f1d0c0 100644
> --- a/drivers/gpu/drm/i915/intel_memory_region.c
> +++ b/drivers/gpu/drm/i915/intel_memory_region.c
> @@ -3,6 +3,8 @@
> * Copyright © 2019 Intel Corporation
> */
>
> +#include <linux/prandom.h>
> +
> #include "intel_memory_region.h"
> #include "i915_drv.h"
> #include "i915_ttm_buddy_manager.h"
> @@ -29,6 +31,99 @@ static const struct {
> },
> };
>
> +static int __iopagetest(struct intel_memory_region *mem,
> + u8 __iomem *va, int pagesize,
> + u8 value, resource_size_t offset,
> + const void *caller)
> +{
> + int byte = prandom_u32_max(pagesize);
> + u8 result[3];
> +
> + memset_io(va, value, pagesize); /* or GPF! */
> + wmb();
> +
> + result[0] = ioread8(va);
> + result[1] = ioread8(va + byte);
> + result[2] = ioread8(va + pagesize - 1);
> + if (memchr_inv(result, value, sizeof(result))) {
> + dev_err(mem->i915->drm.dev,
> + "Failed to read back from memory region:%pR at [%pa + %pa] for %ps; wrote %x, read (%x, %x, %x)\n",
> + &mem->region, &mem->io_start, &offset, caller,
> + value, result[0], result[1], result[2]);
> + return -EINVAL;
> + }
> +
> + return 0;
> +}
> +
> +static int iopagetest(struct intel_memory_region *mem,
> + resource_size_t offset,
> + const void *caller)
> +{
> + const u8 val[] = { 0x0, 0xa5, 0xc3, 0xf0 };
> + void __iomem *va;
> + int err;
> + int i;
> +
> + va = ioremap_wc(mem->io_start + offset, PAGE_SIZE);
> + if (!va) {
> + dev_err(mem->i915->drm.dev,
> + "Failed to ioremap memory region [%pa + %px] for %ps\n",
> + &mem->io_start, &offset, caller);
> + return -EFAULT;
> + }
> +
> + for (i = 0; i < ARRAY_SIZE(val); i++) {
> + err = __iopagetest(mem, va, PAGE_SIZE, val[i], offset, caller);
> + if (err)
> + break;
> +
> + err = __iopagetest(mem, va, PAGE_SIZE, ~val[i], offset, caller);
> + if (err)
> + break;
> + }
> +
> + iounmap(va);
> + return err;
> +}
> +
> +static resource_size_t random_page(resource_size_t last)
> +{
> + /* Limited to low 44b (16TiB), but should suffice for a spot check */
> + return prandom_u32_max(last >> PAGE_SHIFT) << PAGE_SHIFT;
> +}
> +
> +static int iomemtest(struct intel_memory_region *mem, const void *caller)
> +{
> + resource_size_t last = resource_size(&mem->region) - PAGE_SIZE;
> + int err;
> +
> + /*
> + * Quick test to check read/write access to the iomap (backing store).
> + *
> + * Write a byte, read it back. If the iomapping fails, we expect
> + * a GPF preventing further execution. If the backing store does not
> + * exist, the read back will return garbage. We check a couple of pages,
> + * the first and last of the specified region to confirm the backing
> + * store + iomap does cover the entire memory region; and we check
> + * a random offset within as a quick spot check for bad memory.
> + */
> +
> + err = iopagetest(mem, 0, caller);
> + if (err)
> + return err;
> +
> + err = iopagetest(mem, last, caller);
> + if (err)
> + return err;
> +
> + err = iopagetest(mem, random_page(last), caller);
> + if (err)
> + return err;
> +
> + return 0;
> +}
> +
> struct intel_memory_region *
> intel_memory_region_lookup(struct drm_i915_private *i915,
> u16 class, u16 instance)
> @@ -126,8 +221,17 @@ intel_memory_region_create(struct drm_i915_private *i915,
> goto err_free;
> }
>
> + if (io_start && IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)) {
> + err = iomemtest(mem, (void *)_RET_IP_);
> + if (err)
> + goto err_release;
> + }
> +
> return mem;
>
> +err_release:
> + if (mem->ops->release)
> + mem->ops->release(mem);
> err_free:
> kfree(mem);
> return ERR_PTR(err);
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [Intel-gfx] [PATCH 1/3] drm/i915: Sanitycheck device iomem on probe
2021-12-08 11:12 ` Matthew Auld
@ 2021-12-08 11:15 ` Ramalingam C
0 siblings, 0 replies; 12+ messages in thread
From: Ramalingam C @ 2021-12-08 11:15 UTC (permalink / raw)
To: Matthew Auld
Cc: Andi, intel-gfx, dri-devel, Chris Wilson, CQ Tang,
Hellstrom Thomas
On 2021-12-08 at 11:12:07 +0000, Matthew Auld wrote:
> On 08/12/2021 10:20, Ramalingam C wrote:
> > From: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > As we setup the memory regions for the device, give each a quick test to
> > verify that we can read and write to the full iomem range. This ensures
> > that our physical addressing for the device's memory is correct, and
> > some reassurance that the memory is functional.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Matthew Auld <matthew.auld@intel.com>
> > Cc: CQ Tang <cq.tang@intel.com>
> > Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
>
> For the series, assuming CI is happy now,
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Thank you!
>
> Also patch 3 should be moved to the start of the series.
Sure I will do it.
Ram.
>
> > ---
> > drivers/gpu/drm/i915/intel_memory_region.c | 104 +++++++++++++++++++++
> > 1 file changed, 104 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_memory_region.c b/drivers/gpu/drm/i915/intel_memory_region.c
> > index b43121609e25..c53e07f1d0c0 100644
> > --- a/drivers/gpu/drm/i915/intel_memory_region.c
> > +++ b/drivers/gpu/drm/i915/intel_memory_region.c
> > @@ -3,6 +3,8 @@
> > * Copyright © 2019 Intel Corporation
> > */
> > +#include <linux/prandom.h>
> > +
> > #include "intel_memory_region.h"
> > #include "i915_drv.h"
> > #include "i915_ttm_buddy_manager.h"
> > @@ -29,6 +31,99 @@ static const struct {
> > },
> > };
> > +static int __iopagetest(struct intel_memory_region *mem,
> > + u8 __iomem *va, int pagesize,
> > + u8 value, resource_size_t offset,
> > + const void *caller)
> > +{
> > + int byte = prandom_u32_max(pagesize);
> > + u8 result[3];
> > +
> > + memset_io(va, value, pagesize); /* or GPF! */
> > + wmb();
> > +
> > + result[0] = ioread8(va);
> > + result[1] = ioread8(va + byte);
> > + result[2] = ioread8(va + pagesize - 1);
> > + if (memchr_inv(result, value, sizeof(result))) {
> > + dev_err(mem->i915->drm.dev,
> > + "Failed to read back from memory region:%pR at [%pa + %pa] for %ps; wrote %x, read (%x, %x, %x)\n",
> > + &mem->region, &mem->io_start, &offset, caller,
> > + value, result[0], result[1], result[2]);
> > + return -EINVAL;
> > + }
> > +
> > + return 0;
> > +}
> > +
> > +static int iopagetest(struct intel_memory_region *mem,
> > + resource_size_t offset,
> > + const void *caller)
> > +{
> > + const u8 val[] = { 0x0, 0xa5, 0xc3, 0xf0 };
> > + void __iomem *va;
> > + int err;
> > + int i;
> > +
> > + va = ioremap_wc(mem->io_start + offset, PAGE_SIZE);
> > + if (!va) {
> > + dev_err(mem->i915->drm.dev,
> > + "Failed to ioremap memory region [%pa + %px] for %ps\n",
> > + &mem->io_start, &offset, caller);
> > + return -EFAULT;
> > + }
> > +
> > + for (i = 0; i < ARRAY_SIZE(val); i++) {
> > + err = __iopagetest(mem, va, PAGE_SIZE, val[i], offset, caller);
> > + if (err)
> > + break;
> > +
> > + err = __iopagetest(mem, va, PAGE_SIZE, ~val[i], offset, caller);
> > + if (err)
> > + break;
> > + }
> > +
> > + iounmap(va);
> > + return err;
> > +}
> > +
> > +static resource_size_t random_page(resource_size_t last)
> > +{
> > + /* Limited to low 44b (16TiB), but should suffice for a spot check */
> > + return prandom_u32_max(last >> PAGE_SHIFT) << PAGE_SHIFT;
> > +}
> > +
> > +static int iomemtest(struct intel_memory_region *mem, const void *caller)
> > +{
> > + resource_size_t last = resource_size(&mem->region) - PAGE_SIZE;
> > + int err;
> > +
> > + /*
> > + * Quick test to check read/write access to the iomap (backing store).
> > + *
> > + * Write a byte, read it back. If the iomapping fails, we expect
> > + * a GPF preventing further execution. If the backing store does not
> > + * exist, the read back will return garbage. We check a couple of pages,
> > + * the first and last of the specified region to confirm the backing
> > + * store + iomap does cover the entire memory region; and we check
> > + * a random offset within as a quick spot check for bad memory.
> > + */
> > +
> > + err = iopagetest(mem, 0, caller);
> > + if (err)
> > + return err;
> > +
> > + err = iopagetest(mem, last, caller);
> > + if (err)
> > + return err;
> > +
> > + err = iopagetest(mem, random_page(last), caller);
> > + if (err)
> > + return err;
> > +
> > + return 0;
> > +}
> > +
> > struct intel_memory_region *
> > intel_memory_region_lookup(struct drm_i915_private *i915,
> > u16 class, u16 instance)
> > @@ -126,8 +221,17 @@ intel_memory_region_create(struct drm_i915_private *i915,
> > goto err_free;
> > }
> > + if (io_start && IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)) {
> > + err = iomemtest(mem, (void *)_RET_IP_);
> > + if (err)
> > + goto err_release;
> > + }
> > +
> > return mem;
> > +err_release:
> > + if (mem->ops->release)
> > + mem->ops->release(mem);
> > err_free:
> > kfree(mem);
> > return ERR_PTR(err);
> >
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH 2/3] drm/i915: Test all device memory on probing
2021-12-08 10:20 [Intel-gfx] [PATCH 0/3] drm/i915: Sanity Check for device memory region Ramalingam C
2021-12-08 10:20 ` [Intel-gfx] [PATCH 1/3] drm/i915: Sanitycheck device iomem on probe Ramalingam C
@ 2021-12-08 10:20 ` Ramalingam C
2021-12-08 10:20 ` [Intel-gfx] [PATCH 3/3] drm/i915: Exclude reserved stolen from driver use Ramalingam C
` (3 subsequent siblings)
5 siblings, 0 replies; 12+ messages in thread
From: Ramalingam C @ 2021-12-08 10:20 UTC (permalink / raw)
To: intel-gfx, dri-devel
Cc: Andi, Chris Wilson, CQ Tang, Hellstrom Thomas, Matthew Auld
From: Chris Wilson <chris@chris-wilson.co.uk>
This extends the previous sanitychecking of device memory to read/write
all the memory on the device during the device probe, ala memtest86,
as an optional module parameter: i915.memtest=1. This is not expected to
be fast, but a reasonably thorough verfification that the device memory
is accessible and doesn't return bit errors.
Suggested-by: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: CQ Tang <cq.tang@intel.com>
Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
---
drivers/gpu/drm/i915/i915_params.c | 3 ++
drivers/gpu/drm/i915/i915_params.h | 1 +
drivers/gpu/drm/i915/intel_memory_region.c | 36 ++++++++++++++--------
3 files changed, 28 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index e07f4cfea63a..525ae832aa9a 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -140,6 +140,9 @@ i915_param_named_unsafe(invert_brightness, int, 0400,
i915_param_named(disable_display, bool, 0400,
"Disable display (default: false)");
+i915_param_named(memtest, bool, 0400,
+ "Perform a read/write test of all device memory on module load (default: off)");
+
i915_param_named(mmio_debug, int, 0400,
"Enable the MMIO debug code for the first N failures (default: off). "
"This may negatively affect performance.");
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index 8d725b64592d..c9d53ff910a0 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -64,6 +64,7 @@ struct drm_printer;
param(char *, guc_firmware_path, NULL, 0400) \
param(char *, huc_firmware_path, NULL, 0400) \
param(char *, dmc_firmware_path, NULL, 0400) \
+ param(bool, memtest, false, 0400) \
param(int, mmio_debug, -IS_ENABLED(CONFIG_DRM_I915_DEBUG_MMIO), 0600) \
param(int, edp_vswing, 0, 0400) \
param(unsigned int, reset, 3, 0600) \
diff --git a/drivers/gpu/drm/i915/intel_memory_region.c b/drivers/gpu/drm/i915/intel_memory_region.c
index c53e07f1d0c0..95adc2cf5dde 100644
--- a/drivers/gpu/drm/i915/intel_memory_region.c
+++ b/drivers/gpu/drm/i915/intel_memory_region.c
@@ -93,9 +93,12 @@ static resource_size_t random_page(resource_size_t last)
return prandom_u32_max(last >> PAGE_SHIFT) << PAGE_SHIFT;
}
-static int iomemtest(struct intel_memory_region *mem, const void *caller)
+static int iomemtest(struct intel_memory_region *mem,
+ bool test_all,
+ const void *caller)
{
resource_size_t last = resource_size(&mem->region) - PAGE_SIZE;
+ resource_size_t page;
int err;
/*
@@ -109,17 +112,25 @@ static int iomemtest(struct intel_memory_region *mem, const void *caller)
* a random offset within as a quick spot check for bad memory.
*/
- err = iopagetest(mem, 0, caller);
- if (err)
- return err;
+ if (test_all) {
+ for (page = 0; page <= last; page += PAGE_SIZE) {
+ err = iopagetest(mem, page, caller);
+ if (err)
+ return err;
+ }
+ } else {
+ err = iopagetest(mem, 0, caller);
+ if (err)
+ return err;
- err = iopagetest(mem, last, caller);
- if (err)
- return err;
+ err = iopagetest(mem, last, caller);
+ if (err)
+ return err;
- err = iopagetest(mem, random_page(last), caller);
- if (err)
- return err;
+ err = iopagetest(mem, random_page(last), caller);
+ if (err)
+ return err;
+ }
return 0;
}
@@ -221,8 +232,9 @@ intel_memory_region_create(struct drm_i915_private *i915,
goto err_free;
}
- if (io_start && IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)) {
- err = iomemtest(mem, (void *)_RET_IP_);
+ if (io_start &&
+ (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM) || i915->params.memtest)) {
+ err = iomemtest(mem, i915->params.memtest, (void *)_RET_IP_);
if (err)
goto err_release;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [Intel-gfx] [PATCH 3/3] drm/i915: Exclude reserved stolen from driver use
2021-12-08 10:20 [Intel-gfx] [PATCH 0/3] drm/i915: Sanity Check for device memory region Ramalingam C
2021-12-08 10:20 ` [Intel-gfx] [PATCH 1/3] drm/i915: Sanitycheck device iomem on probe Ramalingam C
2021-12-08 10:20 ` [Intel-gfx] [PATCH 2/3] drm/i915: Test all device memory on probing Ramalingam C
@ 2021-12-08 10:20 ` Ramalingam C
2021-12-08 13:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Sanity Check for device memory region Patchwork
` (2 subsequent siblings)
5 siblings, 0 replies; 12+ messages in thread
From: Ramalingam C @ 2021-12-08 10:20 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Hellstrom Thomas, Andi, Matthew Auld, Chris Wilson
From: Chris Wilson <chris@chris-wilson.co.uk>
Remove the portion of stolen memory reserved for private use from driver
access.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
cc: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
index bce03d74a0b4..6ea3ca21cdf3 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
@@ -488,6 +488,9 @@ static int i915_gem_init_stolen(struct intel_memory_region *mem)
return 0;
}
+ /* Exclude the reserved region from driver use */
+ mem->region.end = reserved_base - 1;
+
/* It is possible for the reserved area to end before the end of stolen
* memory, so just consider the start. */
reserved_total = stolen_top - reserved_base;
--
2.20.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Sanity Check for device memory region
2021-12-08 10:20 [Intel-gfx] [PATCH 0/3] drm/i915: Sanity Check for device memory region Ramalingam C
` (2 preceding siblings ...)
2021-12-08 10:20 ` [Intel-gfx] [PATCH 3/3] drm/i915: Exclude reserved stolen from driver use Ramalingam C
@ 2021-12-08 13:13 ` Patchwork
2021-12-08 13:14 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-12-08 13:46 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2021-12-08 13:13 UTC (permalink / raw)
To: Ramalingam C; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Sanity Check for device memory region
URL : https://patchwork.freedesktop.org/series/97715/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
a4fb1d110926 drm/i915: Sanitycheck device iomem on probe
-:70: WARNING:VSPRINTF_SPECIFIER_PX: Using vsprintf specifier '%px' potentially exposes the kernel memory layout, if you don't really need the address please consider using '%p'.
#70: FILE: drivers/gpu/drm/i915/intel_memory_region.c:70:
+ dev_err(mem->i915->drm.dev,
+ "Failed to ioremap memory region [%pa + %px] for %ps\n",
+ &mem->io_start, &offset, caller);
total: 0 errors, 1 warnings, 0 checks, 124 lines checked
ec4f658f19ef drm/i915: Test all device memory on probing
-:27: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#27: FILE: drivers/gpu/drm/i915/i915_params.c:144:
+i915_param_named(memtest, bool, 0400,
+ "Perform a read/write test of all device memory on module load (default: off)");
total: 0 errors, 0 warnings, 1 checks, 74 lines checked
ab26e68a876d drm/i915: Exclude reserved stolen from driver use
^ permalink raw reply [flat|nested] 12+ messages in thread* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Sanity Check for device memory region
2021-12-08 10:20 [Intel-gfx] [PATCH 0/3] drm/i915: Sanity Check for device memory region Ramalingam C
` (3 preceding siblings ...)
2021-12-08 13:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Sanity Check for device memory region Patchwork
@ 2021-12-08 13:14 ` Patchwork
2021-12-08 13:46 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2021-12-08 13:14 UTC (permalink / raw)
To: Ramalingam C; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Sanity Check for device memory region
URL : https://patchwork.freedesktop.org/series/97715/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 12+ messages in thread* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Sanity Check for device memory region
2021-12-08 10:20 [Intel-gfx] [PATCH 0/3] drm/i915: Sanity Check for device memory region Ramalingam C
` (4 preceding siblings ...)
2021-12-08 13:14 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2021-12-08 13:46 ` Patchwork
5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2021-12-08 13:46 UTC (permalink / raw)
To: Ramalingam C; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 8099 bytes --]
== Series Details ==
Series: drm/i915: Sanity Check for device memory region
URL : https://patchwork.freedesktop.org/series/97715/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10973 -> Patchwork_21784
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21784 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21784, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/index.html
Participating hosts (45 -> 36)
------------------------------
Additional (2): fi-kbl-soraka fi-icl-u2
Missing (11): fi-ilk-m540 bat-dg1-6 fi-tgl-u2 bat-dg1-5 fi-hsw-4200u fi-bsw-cyan bat-adlp-6 bat-adlp-4 fi-ctg-p8600 fi-pnv-d510 bat-jsl-1
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21784:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@execlists:
- fi-icl-u2: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/fi-icl-u2/igt@i915_selftest@live@execlists.html
Known issues
------------
Here are the changes found in Patchwork_21784 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271]) +8 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/fi-kbl-soraka/igt@gem_exec_fence@basic-busy@bcs0.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
- fi-icl-u2: NOTRUN -> [SKIP][4] ([i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/fi-icl-u2/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/fi-icl-u2/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [PASS][7] -> [INCOMPLETE][8] ([i915#2940])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10973/fi-bsw-nick/igt@i915_selftest@live@execlists.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/fi-bsw-nick/igt@i915_selftest@live@execlists.html
- fi-bsw-kefka: [PASS][9] -> [INCOMPLETE][10] ([i915#2940])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10973/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][11] ([i915#1886] / [i915#2291])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-soraka: NOTRUN -> [SKIP][12] ([fdo#109271] / [fdo#111827]) +8 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/fi-kbl-soraka/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][13] ([fdo#111827]) +8 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: NOTRUN -> [SKIP][14] ([fdo#109278]) +2 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-u2: NOTRUN -> [SKIP][15] ([fdo#109285])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/fi-icl-u2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-soraka: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#533])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_psr@primary_page_flip:
- fi-skl-6600u: [PASS][17] -> [FAIL][18] ([i915#4547])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10973/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][19] ([i915#3301])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/fi-icl-u2/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-bsw-kefka: NOTRUN -> [FAIL][20] ([fdo#109271] / [i915#1436] / [i915#2722] / [i915#3428] / [i915#4312])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/fi-bsw-kefka/igt@runner@aborted.html
- fi-skl-6600u: NOTRUN -> [FAIL][21] ([i915#3363] / [i915#4312])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/fi-skl-6600u/igt@runner@aborted.html
- fi-icl-u2: NOTRUN -> [FAIL][22] ([i915#2722] / [i915#3363] / [i915#4006] / [i915#4312])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/fi-icl-u2/igt@runner@aborted.html
- fi-bsw-nick: NOTRUN -> [FAIL][23] ([fdo#109271] / [i915#1436] / [i915#3428] / [i915#4312])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/fi-bsw-nick/igt@runner@aborted.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#4006]: https://gitlab.freedesktop.org/drm/intel/issues/4006
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* Linux: CI_DRM_10973 -> Patchwork_21784
CI-20190529: 20190529
CI_DRM_10973: e540b0c4da51fd576e9b61489899acd074a0e4cd @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6303: 49deb6b505c293a60dd3b3976a63c467bf88442e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21784: ab26e68a876dd5f76ce117e04708bf8dda26a1a4 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
ab26e68a876d drm/i915: Exclude reserved stolen from driver use
ec4f658f19ef drm/i915: Test all device memory on probing
a4fb1d110926 drm/i915: Sanitycheck device iomem on probe
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21784/index.html
[-- Attachment #2: Type: text/html, Size: 10287 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread