From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: [PATCH v5 5/8] drm/i915/dp: Reuse intel_dp_detect_dsc_caps() for eDP
Date: Fri, 25 Oct 2024 19:02:56 +0300 [thread overview]
Message-ID: <20241025160259.3088727-6-imre.deak@intel.com> (raw)
In-Reply-To: <20241025160259.3088727-1-imre.deak@intel.com>
Reuse intel_dp_detect_dsc_caps() which already checks for the source's
DSC cap and retrieves the DPCD version from the DPRX caps.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 38 ++++++++++++-------------
1 file changed, 18 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index ca5912f8057b6..a3bc631d64095 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -4014,6 +4014,23 @@ static void intel_edp_get_dsc_sink_cap(u8 edp_dpcd_rev, struct intel_connector *
intel_dp_read_dsc_dpcd(connector->dp.dsc_decompression_aux, connector->dp.dsc_dpcd);
}
+static void
+intel_dp_detect_dsc_caps(struct intel_dp *intel_dp, struct intel_connector *connector)
+{
+ struct drm_i915_private *i915 = dp_to_i915(intel_dp);
+
+ /* Read DP Sink DSC Cap DPCD regs for DP v1.4 */
+ if (!HAS_DSC(i915))
+ return;
+
+ if (intel_dp_is_edp(intel_dp))
+ intel_edp_get_dsc_sink_cap(intel_dp->edp_dpcd[0],
+ connector);
+ else
+ intel_dp_get_dsc_sink_cap(intel_dp->dpcd[DP_DPCD_REV],
+ connector);
+}
+
static void intel_edp_mso_mode_fixup(struct intel_connector *connector,
struct drm_display_mode *mode)
{
@@ -4189,9 +4206,7 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp, struct intel_connector *connector
intel_dp_set_max_sink_lane_count(intel_dp);
/* Read the eDP DSC DPCD registers */
- if (HAS_DSC(dev_priv))
- intel_edp_get_dsc_sink_cap(intel_dp->edp_dpcd[0],
- connector);
+ intel_dp_detect_dsc_caps(intel_dp, connector);
/*
* If needed, program our source OUI so we can make various Intel-specific AUX services
@@ -5578,23 +5593,6 @@ intel_dp_unset_edid(struct intel_dp *intel_dp)
false);
}
-static void
-intel_dp_detect_dsc_caps(struct intel_dp *intel_dp, struct intel_connector *connector)
-{
- struct drm_i915_private *i915 = dp_to_i915(intel_dp);
-
- /* Read DP Sink DSC Cap DPCD regs for DP v1.4 */
- if (!HAS_DSC(i915))
- return;
-
- if (intel_dp_is_edp(intel_dp))
- intel_edp_get_dsc_sink_cap(intel_dp->edp_dpcd[0],
- connector);
- else
- intel_dp_get_dsc_sink_cap(intel_dp->dpcd[DP_DPCD_REV],
- connector);
-}
-
static void
intel_dp_detect_sdp_caps(struct intel_dp *intel_dp)
{
--
2.44.2
next prev parent reply other threads:[~2024-10-25 16:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 16:02 [PATCH v5 0/8] drm/i915: Write source OUI for non-eDP sinks Imre Deak
2024-10-25 16:02 ` [PATCH v5 1/8] drm/i915/dp: Flush modeset commits during connector detection Imre Deak
2024-10-25 16:02 ` [PATCH v5 2/8] drm/i915/dp: Ensure panel power remains enabled " Imre Deak
2024-10-25 16:02 ` [PATCH v5 3/8] drm/i915/dp: Initialize the source OUI write timestamp always Imre Deak
2024-10-25 16:02 ` [PATCH v5 4/8] drm/i915/dp: Track source OUI validity explicitly Imre Deak
2024-10-25 16:02 ` Imre Deak [this message]
2024-10-25 16:02 ` [PATCH v5 6/8] drm/i915/dp: Write the source OUI for eDP before detecting sink capabilities Imre Deak
2024-10-25 16:02 ` [PATCH v5 7/8] drm/i915/dp: Write the source OUI during connector detection Imre Deak
2024-10-25 16:02 ` [PATCH v5 8/8] drm/i915/dp: Write the source OUI for non-eDP sinks as well Imre Deak
2024-10-28 15:20 ` Ville Syrjälä
2024-10-25 16:52 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Write source OUI for non-eDP sinks (rev4) Patchwork
2024-10-25 17:09 ` ✓ Fi.CI.BAT: success " Patchwork
2024-10-25 22:12 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-10-31 17:00 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241025160259.3088727-6-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox