From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, Jani Nikula <jani.nikula@intel.com>
Subject: [PATCH v2 10/10] drm/i915/pmdemand: Use the default 2 usec fast polling timeout
Date: Thu, 6 Nov 2025 17:20:49 +0200 [thread overview]
Message-ID: <20251106152049.21115-11-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20251106152049.21115-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
For whatever unknown reason the pmdemand code is using a custom
50 usec fast polling timeout instead of the normal 2 usec
value. Switch to the standard value to get rid of the special
case.
The eventual aim is to get rid of the fast vs. slow timeout
entirely and switch over to poll_timeout_us().
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_pmdemand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_pmdemand.c b/drivers/gpu/drm/i915/display/intel_pmdemand.c
index f52abd4e2eb0..22d8f720ae7d 100644
--- a/drivers/gpu/drm/i915/display/intel_pmdemand.c
+++ b/drivers/gpu/drm/i915/display/intel_pmdemand.c
@@ -464,7 +464,7 @@ static void intel_pmdemand_poll(struct intel_display *display)
ret = intel_de_wait_custom(display, XELPDP_INITIATE_PMDEMAND_REQUEST(1),
XELPDP_PMDEMAND_REQ_ENABLE, 0,
- 50, timeout_ms, &status);
+ 2, timeout_ms, &status);
if (ret == -ETIMEDOUT)
drm_err(display->drm,
--
2.49.1
next prev parent reply other threads:[~2025-11-06 15:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 15:20 [PATCH v2 00/10] drm/i915: Stop the intel_de_wait_custom() abuse Ville Syrjala
2025-11-06 15:20 ` [PATCH v2 01/10] drm/i915/cx0: Print the correct timeout Ville Syrjala
2025-11-06 15:32 ` Jani Nikula
2025-11-06 15:54 ` Ville Syrjälä
2025-11-06 15:20 ` [PATCH v2 02/10] drm/i915/cx0: Nuke extraneous timeout debugs Ville Syrjala
2025-11-06 15:33 ` Jani Nikula
2025-11-06 15:20 ` [PATCH v2 03/10] drm/i915/ltphy: " Ville Syrjala
2025-11-06 15:34 ` Jani Nikula
2025-11-06 15:20 ` [PATCH v2 04/10] drm/i915/cx0: Replace XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_US with XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_MS Ville Syrjala
2025-11-06 15:37 ` Jani Nikula
2025-11-06 15:20 ` [PATCH v2 05/10] drm/i915/cx0: Get rid of XELPDP_MSGBUS_TIMEOUT_FAST_US Ville Syrjala
2025-11-06 15:20 ` [PATCH v2 06/10] drm/i915/cx0: s/XELPDP_MSGBUS_TIMEOUT_SLOW/XELPDP_MSGBUS_TIMEOUT_MS/ Ville Syrjala
2025-11-06 15:20 ` [PATCH v2 07/10] drm/i915/cx0: s/XELPDP_PORT_RESET_END_TIMEOUT/XELPDP_PORT_RESET_END_TIMEOUT_US/ Ville Syrjala
2025-11-06 15:38 ` Jani Nikula
2025-11-06 15:52 ` [PATCH v3 07/10] drm/i915/cx0: s/XELPDP_PORT_RESET_END_TIMEOUT/XELPDP_PORT_RESET_END_TIMEOUT_MS/ Ville Syrjala
2025-11-06 15:20 ` [PATCH v2 08/10] drm/i915/ltphy: Nuke bogus weird timeouts Ville Syrjala
2025-11-06 15:41 ` Jani Nikula
2025-11-06 15:20 ` [PATCH v2 09/10] drm/i915/hdcp: Use the default 2 usec fast polling timeout Ville Syrjala
2025-11-06 15:20 ` Ville Syrjala [this message]
2025-11-06 15:43 ` [PATCH v2 00/10] drm/i915: Stop the intel_de_wait_custom() abuse Jani Nikula
2025-11-06 16:10 ` Ville Syrjälä
2025-11-06 17:05 ` Jani Nikula
2025-11-06 18:16 ` ✓ i915.CI.BAT: success for drm/i915: Stop the intel_de_wait_custom() abuse (rev2) Patchwork
2025-11-06 18:22 ` ✓ i915.CI.BAT: success for drm/i915: Stop the intel_de_wait_custom() abuse (rev3) Patchwork
2025-11-07 12:16 ` ✓ i915.CI.Full: " Patchwork
2025-11-07 18:44 ` [PATCH v2 00/10] drm/i915: Stop the intel_de_wait_custom() abuse Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251106152049.21115-11-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox