Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH v2 03/10] drm/i915/ltphy: Nuke extraneous timeout debugs
Date: Thu,  6 Nov 2025 17:20:42 +0200	[thread overview]
Message-ID: <20251106152049.21115-4-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20251106152049.21115-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The actual timeout used isn't particularly interesting, so
don't print it. Makes the code simpler.

The debugs are also using some random capitalizaton rule.
Clean that up a bit while at it.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_lt_phy.c | 34 ++++++++++-----------
 1 file changed, 16 insertions(+), 18 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_lt_phy.c b/drivers/gpu/drm/i915/display/intel_lt_phy.c
index af48d6cde226..8ab632965033 100644
--- a/drivers/gpu/drm/i915/display/intel_lt_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_lt_phy.c
@@ -1180,8 +1180,8 @@ intel_lt_phy_lane_reset(struct intel_encoder *encoder,
 				 XELPDP_LANE_PCLK_PLL_ACK(0),
 				 XE3PLPD_MACCLK_TURNON_LATENCY_US,
 				 XE3PLPD_MACCLK_TURNON_LATENCY_MS, NULL))
-		drm_warn(display->drm, "PHY %c PLL MacCLK assertion Ack not done after %dus.\n",
-			 phy_name(phy), XE3PLPD_MACCLK_TURNON_LATENCY_MS * 1000);
+		drm_warn(display->drm, "PHY %c PLL MacCLK assertion ack not done\n",
+			 phy_name(phy));
 
 	intel_de_rmw(display, XELPDP_PORT_CLOCK_CTL(display, port),
 		     XELPDP_FORWARD_CLOCK_UNGATE,
@@ -1193,15 +1193,14 @@ intel_lt_phy_lane_reset(struct intel_encoder *encoder,
 	if (intel_de_wait_custom(display, XELPDP_PORT_BUF_CTL2(display, port),
 				 lane_phy_current_status, 0,
 				 XE3PLPD_RESET_END_LATENCY_US, 2, NULL))
-		drm_warn(display->drm,
-			 "PHY %c failed to bring out of Lane reset after %dus.\n",
-			 phy_name(phy), XE3PLPD_RESET_END_LATENCY_US);
+		drm_warn(display->drm, "PHY %c failed to bring out of lane reset\n",
+			 phy_name(phy));
 
 	if (intel_de_wait_custom(display, XELPDP_PORT_BUF_CTL2(display, port),
 				 lane_phy_pulse_status, lane_phy_pulse_status,
 				 XE3PLPD_RATE_CALIB_DONE_LATENCY_US, 0, NULL))
-		drm_warn(display->drm, "PHY %c PLL rate not changed after %dus.\n",
-			 phy_name(phy), XE3PLPD_RATE_CALIB_DONE_LATENCY_US);
+		drm_warn(display->drm, "PHY %c PLL rate not changed\n",
+			 phy_name(phy));
 
 	intel_de_rmw(display, XELPDP_PORT_BUF_CTL2(display, port), lane_phy_pulse_status, 0);
 }
@@ -1654,8 +1653,8 @@ void intel_lt_phy_pll_enable(struct intel_encoder *encoder,
 		if (intel_de_wait_custom(display, XELPDP_PORT_CLOCK_CTL(display, port),
 					 XELPDP_LANE_PCLK_PLL_ACK(0), 0,
 					 XE3PLPD_MACCLK_TURNOFF_LATENCY_US, 0, NULL))
-			drm_warn(display->drm, "PHY %c PLL MacCLK Ack deassertion Timeout after %dus.\n",
-				 phy_name(phy), XE3PLPD_MACCLK_TURNOFF_LATENCY_US);
+			drm_warn(display->drm, "PHY %c PLL MacCLK ack deassertion timeout\n",
+				 phy_name(phy));
 
 		/*
 		 * 9. Follow the Display Voltage Frequency Switching - Sequence Before Frequency
@@ -1675,8 +1674,8 @@ void intel_lt_phy_pll_enable(struct intel_encoder *encoder,
 					 XELPDP_LANE_PCLK_PLL_ACK(0),
 					 XELPDP_LANE_PCLK_PLL_ACK(0),
 					 XE3PLPD_MACCLK_TURNON_LATENCY_US, 2, NULL))
-			drm_warn(display->drm, "PHY %c PLL MacCLK Ack assertion Timeout after %dus.\n",
-				 phy_name(phy), XE3PLPD_MACCLK_TURNON_LATENCY_US);
+			drm_warn(display->drm, "PHY %c PLL MacCLK ack assertion timeout\n",
+				 phy_name(phy));
 
 		/*
 		 * 13. Ungate the forward clock by setting
@@ -1703,8 +1702,8 @@ void intel_lt_phy_pll_enable(struct intel_encoder *encoder,
 		if (intel_de_wait_custom(display, XELPDP_PORT_BUF_CTL2(display, port),
 					 lane_phy_pulse_status, lane_phy_pulse_status,
 					 XE3PLPD_RATE_CALIB_DONE_LATENCY_US, 2, NULL))
-			drm_warn(display->drm, "PHY %c PLL rate not changed after %dus.\n",
-				 phy_name(phy), XE3PLPD_RATE_CALIB_DONE_LATENCY_US);
+			drm_warn(display->drm, "PHY %c PLL rate not changed\n",
+				 phy_name(phy));
 
 		/* 17. SW clears PORT_BUF_CTL2 [PHY Pulse Status]. */
 		intel_de_rmw(display, XELPDP_PORT_BUF_CTL2(display, port),
@@ -1762,9 +1761,8 @@ void intel_lt_phy_pll_disable(struct intel_encoder *encoder)
 				 lane_phy_current_status,
 				 lane_phy_current_status,
 				 XE3PLPD_RESET_START_LATENCY_US, 0, NULL))
-		drm_warn(display->drm,
-			 "PHY %c failed to reset Lane after %dms.\n",
-			 phy_name(phy), XE3PLPD_RESET_START_LATENCY_US);
+		drm_warn(display->drm, "PHY %c failed to reset lane\n",
+			 phy_name(phy));
 
 	/* 4. Clear for PHY pulse status on owned PHY lanes. */
 	intel_de_rmw(display, XELPDP_PORT_BUF_CTL2(display, port),
@@ -1786,8 +1784,8 @@ void intel_lt_phy_pll_disable(struct intel_encoder *encoder)
 	if (intel_de_wait_custom(display, XELPDP_PORT_CLOCK_CTL(display, port),
 				 XELPDP_LANE_PCLK_PLL_ACK(0), 0,
 				 XE3PLPD_MACCLK_TURNOFF_LATENCY_US, 0, NULL))
-		drm_warn(display->drm, "PHY %c PLL MacCLK Ack deassertion Timeout after %dus.\n",
-			 phy_name(phy), XE3PLPD_MACCLK_TURNOFF_LATENCY_US);
+		drm_warn(display->drm, "PHY %c PLL MacCLK ack deassertion timeout\n",
+			 phy_name(phy));
 
 	/*
 	 *  9. Follow the Display Voltage Frequency Switching -
-- 
2.49.1


  parent reply	other threads:[~2025-11-06 15:21 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-06 15:20 [PATCH v2 00/10] drm/i915: Stop the intel_de_wait_custom() abuse Ville Syrjala
2025-11-06 15:20 ` [PATCH v2 01/10] drm/i915/cx0: Print the correct timeout Ville Syrjala
2025-11-06 15:32   ` Jani Nikula
2025-11-06 15:54     ` Ville Syrjälä
2025-11-06 15:20 ` [PATCH v2 02/10] drm/i915/cx0: Nuke extraneous timeout debugs Ville Syrjala
2025-11-06 15:33   ` Jani Nikula
2025-11-06 15:20 ` Ville Syrjala [this message]
2025-11-06 15:34   ` [PATCH v2 03/10] drm/i915/ltphy: " Jani Nikula
2025-11-06 15:20 ` [PATCH v2 04/10] drm/i915/cx0: Replace XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_US with XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_MS Ville Syrjala
2025-11-06 15:37   ` Jani Nikula
2025-11-06 15:20 ` [PATCH v2 05/10] drm/i915/cx0: Get rid of XELPDP_MSGBUS_TIMEOUT_FAST_US Ville Syrjala
2025-11-06 15:20 ` [PATCH v2 06/10] drm/i915/cx0: s/XELPDP_MSGBUS_TIMEOUT_SLOW/XELPDP_MSGBUS_TIMEOUT_MS/ Ville Syrjala
2025-11-06 15:20 ` [PATCH v2 07/10] drm/i915/cx0: s/XELPDP_PORT_RESET_END_TIMEOUT/XELPDP_PORT_RESET_END_TIMEOUT_US/ Ville Syrjala
2025-11-06 15:38   ` Jani Nikula
2025-11-06 15:52   ` [PATCH v3 07/10] drm/i915/cx0: s/XELPDP_PORT_RESET_END_TIMEOUT/XELPDP_PORT_RESET_END_TIMEOUT_MS/ Ville Syrjala
2025-11-06 15:20 ` [PATCH v2 08/10] drm/i915/ltphy: Nuke bogus weird timeouts Ville Syrjala
2025-11-06 15:41   ` Jani Nikula
2025-11-06 15:20 ` [PATCH v2 09/10] drm/i915/hdcp: Use the default 2 usec fast polling timeout Ville Syrjala
2025-11-06 15:20 ` [PATCH v2 10/10] drm/i915/pmdemand: " Ville Syrjala
2025-11-06 15:43 ` [PATCH v2 00/10] drm/i915: Stop the intel_de_wait_custom() abuse Jani Nikula
2025-11-06 16:10   ` Ville Syrjälä
2025-11-06 17:05     ` Jani Nikula
2025-11-06 18:16 ` ✓ i915.CI.BAT: success for drm/i915: Stop the intel_de_wait_custom() abuse (rev2) Patchwork
2025-11-06 18:22 ` ✓ i915.CI.BAT: success for drm/i915: Stop the intel_de_wait_custom() abuse (rev3) Patchwork
2025-11-07 12:16 ` ✓ i915.CI.Full: " Patchwork
2025-11-07 18:44 ` [PATCH v2 00/10] drm/i915: Stop the intel_de_wait_custom() abuse Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251106152049.21115-4-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox