Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH v2 04/10] drm/i915/cx0: Replace XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_US with XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_MS
Date: Thu,  6 Nov 2025 17:20:43 +0200	[thread overview]
Message-ID: <20251106152049.21115-5-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20251106152049.21115-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

There was a completely unjustified change to the cx0 powerdown
timeout, and the way it was done now prevents future conversion
to poll_timeout_us().

Assuming there was some reason the bigger timeout let's nuke
the old short timeout (XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_US)
nd replace it with the bigger timeout
(XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_MS).

v2: Go for the longer (ms) timeout in case it actually matters

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_cx0_phy.c      | 2 +-
 drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
index ddc26e383714..e8a96a60fdd6 100644
--- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
@@ -2830,7 +2830,7 @@ void intel_cx0_powerdown_change_sequence(struct intel_encoder *encoder,
 	/* Update Timeout Value */
 	if (intel_de_wait_custom(display, buf_ctl2_reg,
 				 intel_cx0_get_powerdown_update(lane_mask), 0,
-				 XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_US, 2, NULL))
+				 2, XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_MS, NULL))
 		drm_warn(display->drm,
 			 "PHY %c failed to bring out of lane reset\n",
 			 phy_name(phy));
diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h b/drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h
index 635b35669348..62db0fd99f4a 100644
--- a/drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h
+++ b/drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h
@@ -80,7 +80,7 @@
 #define XELPDP_PCLK_PLL_DISABLE_TIMEOUT_US		20
 #define XELPDP_PORT_BUF_SOC_READY_TIMEOUT_US		100
 #define XELPDP_PORT_RESET_START_TIMEOUT_US		5
-#define XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_US		100
+#define XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_MS		2
 #define XELPDP_PORT_RESET_END_TIMEOUT			15
 #define XELPDP_REFCLK_ENABLE_TIMEOUT_US			1
 
-- 
2.49.1


  parent reply	other threads:[~2025-11-06 15:21 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-06 15:20 [PATCH v2 00/10] drm/i915: Stop the intel_de_wait_custom() abuse Ville Syrjala
2025-11-06 15:20 ` [PATCH v2 01/10] drm/i915/cx0: Print the correct timeout Ville Syrjala
2025-11-06 15:32   ` Jani Nikula
2025-11-06 15:54     ` Ville Syrjälä
2025-11-06 15:20 ` [PATCH v2 02/10] drm/i915/cx0: Nuke extraneous timeout debugs Ville Syrjala
2025-11-06 15:33   ` Jani Nikula
2025-11-06 15:20 ` [PATCH v2 03/10] drm/i915/ltphy: " Ville Syrjala
2025-11-06 15:34   ` Jani Nikula
2025-11-06 15:20 ` Ville Syrjala [this message]
2025-11-06 15:37   ` [PATCH v2 04/10] drm/i915/cx0: Replace XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_US with XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_MS Jani Nikula
2025-11-06 15:20 ` [PATCH v2 05/10] drm/i915/cx0: Get rid of XELPDP_MSGBUS_TIMEOUT_FAST_US Ville Syrjala
2025-11-06 15:20 ` [PATCH v2 06/10] drm/i915/cx0: s/XELPDP_MSGBUS_TIMEOUT_SLOW/XELPDP_MSGBUS_TIMEOUT_MS/ Ville Syrjala
2025-11-06 15:20 ` [PATCH v2 07/10] drm/i915/cx0: s/XELPDP_PORT_RESET_END_TIMEOUT/XELPDP_PORT_RESET_END_TIMEOUT_US/ Ville Syrjala
2025-11-06 15:38   ` Jani Nikula
2025-11-06 15:52   ` [PATCH v3 07/10] drm/i915/cx0: s/XELPDP_PORT_RESET_END_TIMEOUT/XELPDP_PORT_RESET_END_TIMEOUT_MS/ Ville Syrjala
2025-11-06 15:20 ` [PATCH v2 08/10] drm/i915/ltphy: Nuke bogus weird timeouts Ville Syrjala
2025-11-06 15:41   ` Jani Nikula
2025-11-06 15:20 ` [PATCH v2 09/10] drm/i915/hdcp: Use the default 2 usec fast polling timeout Ville Syrjala
2025-11-06 15:20 ` [PATCH v2 10/10] drm/i915/pmdemand: " Ville Syrjala
2025-11-06 15:43 ` [PATCH v2 00/10] drm/i915: Stop the intel_de_wait_custom() abuse Jani Nikula
2025-11-06 16:10   ` Ville Syrjälä
2025-11-06 17:05     ` Jani Nikula
2025-11-06 18:16 ` ✓ i915.CI.BAT: success for drm/i915: Stop the intel_de_wait_custom() abuse (rev2) Patchwork
2025-11-06 18:22 ` ✓ i915.CI.BAT: success for drm/i915: Stop the intel_de_wait_custom() abuse (rev3) Patchwork
2025-11-07 12:16 ` ✓ i915.CI.Full: " Patchwork
2025-11-07 18:44 ` [PATCH v2 00/10] drm/i915: Stop the intel_de_wait_custom() abuse Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251106152049.21115-5-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox