From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, Jani Nikula <jani.nikula@intel.com>
Subject: [PATCH v2 05/10] drm/i915/cx0: Get rid of XELPDP_MSGBUS_TIMEOUT_FAST_US
Date: Thu, 6 Nov 2025 17:20:44 +0200 [thread overview]
Message-ID: <20251106152049.21115-6-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20251106152049.21115-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
XELPDP_MSGBUS_TIMEOUT_FAST_US looks to be just an obfuscated version
of the default 2 microsecond fast timeout used by
intel_wait_for_register(). Get rid of it to make it clear what's going
on here.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_cx0_phy.c | 3 +--
drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
index e8a96a60fdd6..ddcfdf45bd38 100644
--- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
@@ -168,8 +168,7 @@ int intel_cx0_wait_for_ack(struct intel_encoder *encoder,
XELPDP_PORT_P2M_MSGBUS_STATUS(display, port, lane),
XELPDP_PORT_P2M_RESPONSE_READY,
XELPDP_PORT_P2M_RESPONSE_READY,
- XELPDP_MSGBUS_TIMEOUT_FAST_US,
- XELPDP_MSGBUS_TIMEOUT_SLOW, val)) {
+ 2, XELPDP_MSGBUS_TIMEOUT_SLOW, val)) {
drm_dbg_kms(display->drm,
"PHY %c Timeout waiting for message ACK. Status: 0x%x\n",
phy_name(phy), *val);
diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h b/drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h
index 62db0fd99f4a..f031de40f6c6 100644
--- a/drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h
+++ b/drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h
@@ -75,7 +75,6 @@
#define XELPDP_PORT_P2M_ERROR_SET REG_BIT(15)
#define XELPDP_MSGBUS_TIMEOUT_SLOW 1
-#define XELPDP_MSGBUS_TIMEOUT_FAST_US 2
#define XELPDP_PCLK_PLL_ENABLE_TIMEOUT_US 3200
#define XELPDP_PCLK_PLL_DISABLE_TIMEOUT_US 20
#define XELPDP_PORT_BUF_SOC_READY_TIMEOUT_US 100
--
2.49.1
next prev parent reply other threads:[~2025-11-06 15:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 15:20 [PATCH v2 00/10] drm/i915: Stop the intel_de_wait_custom() abuse Ville Syrjala
2025-11-06 15:20 ` [PATCH v2 01/10] drm/i915/cx0: Print the correct timeout Ville Syrjala
2025-11-06 15:32 ` Jani Nikula
2025-11-06 15:54 ` Ville Syrjälä
2025-11-06 15:20 ` [PATCH v2 02/10] drm/i915/cx0: Nuke extraneous timeout debugs Ville Syrjala
2025-11-06 15:33 ` Jani Nikula
2025-11-06 15:20 ` [PATCH v2 03/10] drm/i915/ltphy: " Ville Syrjala
2025-11-06 15:34 ` Jani Nikula
2025-11-06 15:20 ` [PATCH v2 04/10] drm/i915/cx0: Replace XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_US with XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_MS Ville Syrjala
2025-11-06 15:37 ` Jani Nikula
2025-11-06 15:20 ` Ville Syrjala [this message]
2025-11-06 15:20 ` [PATCH v2 06/10] drm/i915/cx0: s/XELPDP_MSGBUS_TIMEOUT_SLOW/XELPDP_MSGBUS_TIMEOUT_MS/ Ville Syrjala
2025-11-06 15:20 ` [PATCH v2 07/10] drm/i915/cx0: s/XELPDP_PORT_RESET_END_TIMEOUT/XELPDP_PORT_RESET_END_TIMEOUT_US/ Ville Syrjala
2025-11-06 15:38 ` Jani Nikula
2025-11-06 15:52 ` [PATCH v3 07/10] drm/i915/cx0: s/XELPDP_PORT_RESET_END_TIMEOUT/XELPDP_PORT_RESET_END_TIMEOUT_MS/ Ville Syrjala
2025-11-06 15:20 ` [PATCH v2 08/10] drm/i915/ltphy: Nuke bogus weird timeouts Ville Syrjala
2025-11-06 15:41 ` Jani Nikula
2025-11-06 15:20 ` [PATCH v2 09/10] drm/i915/hdcp: Use the default 2 usec fast polling timeout Ville Syrjala
2025-11-06 15:20 ` [PATCH v2 10/10] drm/i915/pmdemand: " Ville Syrjala
2025-11-06 15:43 ` [PATCH v2 00/10] drm/i915: Stop the intel_de_wait_custom() abuse Jani Nikula
2025-11-06 16:10 ` Ville Syrjälä
2025-11-06 17:05 ` Jani Nikula
2025-11-06 18:16 ` ✓ i915.CI.BAT: success for drm/i915: Stop the intel_de_wait_custom() abuse (rev2) Patchwork
2025-11-06 18:22 ` ✓ i915.CI.BAT: success for drm/i915: Stop the intel_de_wait_custom() abuse (rev3) Patchwork
2025-11-07 12:16 ` ✓ i915.CI.Full: " Patchwork
2025-11-07 18:44 ` [PATCH v2 00/10] drm/i915: Stop the intel_de_wait_custom() abuse Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251106152049.21115-6-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox