From: "Michał Grzelak" <michal.grzelak@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Nemesa Garg" <nemesa.garg@intel.com>,
"Michał Grzelak" <michal.grzelak@intel.com>
Subject: [PATCH v2 03/10] drm/i915: rename t into tap
Date: Sat, 11 Apr 2026 19:45:19 +0200 [thread overview]
Message-ID: <20260411174526.2850179-4-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260411174526.2850179-1-michal.grzelak@intel.com>
Add more description to the casf_coeff()'s argument and
casf_coeff_tap()'s returned value.
Do the same for glk_nearest_filter_coef().
v1->v2
- apply the rename to nearest neighbor filter (Ville)
Cc: Nemesa Garg <nemesa.garg@intel.com>
Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
drivers/gpu/drm/i915/display/intel_casf.c | 14 +++++++-------
drivers/gpu/drm/i915/display/skl_scaler.c | 14 +++++++-------
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_casf.c b/drivers/gpu/drm/i915/display/intel_casf.c
index c4fabffa369e3..b9643548d1822 100644
--- a/drivers/gpu/drm/i915/display/intel_casf.c
+++ b/drivers/gpu/drm/i915/display/intel_casf.c
@@ -148,12 +148,12 @@ static int casf_coeff_tap(int i)
return i % SCALER_FILTER_NUM_TAPS;
}
-static u32 casf_coeff(const struct intel_crtc_state *crtc_state, int t)
+static u32 casf_coeff(const struct intel_crtc_state *crtc_state, int tap)
{
struct scaler_filter_coeff value;
u32 coeff;
- value = crtc_state->pch_pfit.casf.coeff[t];
+ value = crtc_state->pch_pfit.casf.coeff[tap];
value.sign = 0;
coeff = value.sign << 15 | value.exp << 12 | value.mantissa << 3;
@@ -183,13 +183,13 @@ static void intel_casf_write_coeff(const struct intel_crtc_state *crtc_state)
for (i = 0; i < 17 * SCALER_FILTER_NUM_TAPS; i += 2) {
u32 tmp;
- int t;
+ int tap;
- t = casf_coeff_tap(i);
- tmp = casf_coeff(crtc_state, t);
+ tap = casf_coeff_tap(i);
+ tmp = casf_coeff(crtc_state, tap);
- t = casf_coeff_tap(i + 1);
- tmp |= casf_coeff(crtc_state, t) << 16;
+ tap = casf_coeff_tap(i + 1);
+ tmp |= casf_coeff(crtc_state, tap) << 16;
intel_de_write_fw(display, GLK_PS_COEF_DATA_SET(crtc->pipe, id, 0),
tmp);
diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c
index 308b8d363bba0..eceda1a909ccd 100644
--- a/drivers/gpu/drm/i915/display/skl_scaler.c
+++ b/drivers/gpu/drm/i915/display/skl_scaler.c
@@ -661,9 +661,9 @@ static int glk_coef_tap(int i)
return i % 7;
}
-static u16 glk_nearest_filter_coef(int t)
+static u16 glk_nearest_filter_coef(int tap)
{
- return t == 3 ? 0x0800 : 0x3000;
+ return tap == 3 ? 0x0800 : 0x3000;
}
/*
@@ -715,13 +715,13 @@ static void glk_program_nearest_filter_coefs(struct intel_display *display,
for (i = 0; i < 17 * 7; i += 2) {
u32 tmp;
- int t;
+ int tap;
- t = glk_coef_tap(i);
- tmp = glk_nearest_filter_coef(t);
+ tap = glk_coef_tap(i);
+ tmp = glk_nearest_filter_coef(tap);
- t = glk_coef_tap(i + 1);
- tmp |= glk_nearest_filter_coef(t) << 16;
+ tap = glk_coef_tap(i + 1);
+ tmp |= glk_nearest_filter_coef(tap) << 16;
intel_de_write_dsb(display, dsb,
GLK_PS_COEF_DATA_SET(pipe, id, set), tmp);
--
2.45.2
next prev parent reply other threads:[~2026-04-11 17:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 17:45 [PATCH v2 00/10] drm/i915: casf & scaler refactoring Michał Grzelak
2026-04-11 17:45 ` [PATCH v2 01/10] drm/i915/casf: fix comment typos Michał Grzelak
2026-04-11 17:45 ` [PATCH v2 02/10] drm/i915/casf: rename *_coeff*() into *_coef*() Michał Grzelak
2026-04-12 21:49 ` Michał Grzelak
2026-04-11 17:45 ` Michał Grzelak [this message]
2026-04-11 17:45 ` [PATCH v2 04/10] drm/i915/casf: rename sumcoeff into sum_coeff Michał Grzelak
2026-04-11 17:45 ` [PATCH v2 05/10] drm/i915/scaler: s/i/scaler_id where appropriate Michał Grzelak
2026-04-11 17:45 ` [PATCH v2 06/10] drm/i915/scaler: remove id in favor of scaler_id Michał Grzelak
2026-04-11 17:45 ` [PATCH v2 07/10] drm/i915/scaler: unloop scaler readout that is run once Michał Grzelak
2026-04-14 8:01 ` Garg, Nemesa
2026-04-20 8:22 ` Grzelak, Michal
2026-04-11 17:45 ` [PATCH v2 08/10] drm/i915/scaler: invert loop's breaking logic Michał Grzelak
2026-04-11 17:45 ` [PATCH v2 09/10] drm/i915/scaler: abstract scaler searching loop Michał Grzelak
2026-04-13 12:45 ` Ville Syrjälä
2026-04-20 8:19 ` Grzelak, Michal
2026-04-11 17:45 ` [PATCH v2 10/10] drm/i915/scaler: eliminate dead code Michał Grzelak
2026-04-11 18:41 ` ✓ i915.CI.BAT: success for drm/i915: casf & scaler refactoring (rev2) Patchwork
2026-04-11 23:56 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260411174526.2850179-4-michal.grzelak@intel.com \
--to=michal.grzelak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nemesa.garg@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox