From: "Michał Grzelak" <michal.grzelak@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Nemesa Garg" <nemesa.garg@intel.com>,
"Michał Grzelak" <michal.grzelak@intel.com>
Subject: [PATCH v2 05/10] drm/i915/scaler: s/i/scaler_id where appropriate
Date: Sat, 11 Apr 2026 19:45:21 +0200 [thread overview]
Message-ID: <20260411174526.2850179-6-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260411174526.2850179-1-michal.grzelak@intel.com>
Switch from generic iterator naming into more specific scaler_id where
it is possible.
Cc: Nemesa Garg <nemesa.garg@intel.com>
Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
drivers/gpu/drm/i915/display/skl_scaler.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c
index eceda1a909ccd..d15e0194ca107 100644
--- a/drivers/gpu/drm/i915/display/skl_scaler.c
+++ b/drivers/gpu/drm/i915/display/skl_scaler.c
@@ -950,26 +950,26 @@ void skl_scaler_get_config(struct intel_crtc_state *crtc_state)
struct intel_display *display = to_intel_display(crtc_state);
struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
struct intel_crtc_scaler_state *scaler_state = &crtc_state->scaler_state;
+ int scaler_id;
int id = -1;
- int i;
/* find scaler attached to this pipe */
- for (i = 0; i < crtc->num_scalers; i++) {
+ for (scaler_id = 0; scaler_id < crtc->num_scalers; scaler_id++) {
u32 ctl, pos, size;
- ctl = intel_de_read(display, SKL_PS_CTRL(crtc->pipe, i));
+ ctl = intel_de_read(display, SKL_PS_CTRL(crtc->pipe, scaler_id));
if ((ctl & (PS_SCALER_EN | PS_BINDING_MASK)) != (PS_SCALER_EN | PS_BINDING_PIPE))
continue;
- id = i;
+ id = scaler_id;
- if (scaler_has_casf(display, i))
+ if (scaler_has_casf(display, scaler_id))
intel_casf_sharpness_get_config(crtc_state);
crtc_state->pch_pfit.enabled = true;
- pos = intel_de_read(display, SKL_PS_WIN_POS(crtc->pipe, i));
- size = intel_de_read(display, SKL_PS_WIN_SZ(crtc->pipe, i));
+ pos = intel_de_read(display, SKL_PS_WIN_POS(crtc->pipe, scaler_id));
+ size = intel_de_read(display, SKL_PS_WIN_SZ(crtc->pipe, scaler_id));
drm_rect_init(&crtc_state->pch_pfit.dst,
REG_FIELD_GET(PS_WIN_XPOS_MASK, pos),
@@ -977,7 +977,7 @@ void skl_scaler_get_config(struct intel_crtc_state *crtc_state)
REG_FIELD_GET(PS_WIN_XSIZE_MASK, size),
REG_FIELD_GET(PS_WIN_YSIZE_MASK, size));
- scaler_state->scalers[i].in_use = true;
+ scaler_state->scalers[scaler_id].in_use = true;
break;
}
--
2.45.2
next prev parent reply other threads:[~2026-04-11 17:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 17:45 [PATCH v2 00/10] drm/i915: casf & scaler refactoring Michał Grzelak
2026-04-11 17:45 ` [PATCH v2 01/10] drm/i915/casf: fix comment typos Michał Grzelak
2026-04-11 17:45 ` [PATCH v2 02/10] drm/i915/casf: rename *_coeff*() into *_coef*() Michał Grzelak
2026-04-12 21:49 ` Michał Grzelak
2026-04-11 17:45 ` [PATCH v2 03/10] drm/i915: rename t into tap Michał Grzelak
2026-04-11 17:45 ` [PATCH v2 04/10] drm/i915/casf: rename sumcoeff into sum_coeff Michał Grzelak
2026-04-11 17:45 ` Michał Grzelak [this message]
2026-04-11 17:45 ` [PATCH v2 06/10] drm/i915/scaler: remove id in favor of scaler_id Michał Grzelak
2026-04-11 17:45 ` [PATCH v2 07/10] drm/i915/scaler: unloop scaler readout that is run once Michał Grzelak
2026-04-14 8:01 ` Garg, Nemesa
2026-04-20 8:22 ` Grzelak, Michal
2026-04-11 17:45 ` [PATCH v2 08/10] drm/i915/scaler: invert loop's breaking logic Michał Grzelak
2026-04-11 17:45 ` [PATCH v2 09/10] drm/i915/scaler: abstract scaler searching loop Michał Grzelak
2026-04-13 12:45 ` Ville Syrjälä
2026-04-20 8:19 ` Grzelak, Michal
2026-04-11 17:45 ` [PATCH v2 10/10] drm/i915/scaler: eliminate dead code Michał Grzelak
2026-04-11 18:41 ` ✓ i915.CI.BAT: success for drm/i915: casf & scaler refactoring (rev2) Patchwork
2026-04-11 23:56 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260411174526.2850179-6-michal.grzelak@intel.com \
--to=michal.grzelak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nemesa.garg@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox