public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Michał Grzelak" <michal.grzelak@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Nemesa Garg" <nemesa.garg@intel.com>,
	"Michał Grzelak" <michal.grzelak@intel.com>
Subject: [PATCH v2 08/10] drm/i915/scaler: invert loop's breaking logic
Date: Sat, 11 Apr 2026 19:45:24 +0200	[thread overview]
Message-ID: <20260411174526.2850179-9-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260411174526.2850179-1-michal.grzelak@intel.com>

skl_scaler_get_config()'s loop is skipped when specified condition is
met and broken when the condition is not met. Equivalently, invert the
condition and break the loop.

Cc: Nemesa Garg <nemesa.garg@intel.com>
Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
 drivers/gpu/drm/i915/display/skl_scaler.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c
index e71d9c036a1e7..4e2f4c4ffc45a 100644
--- a/drivers/gpu/drm/i915/display/skl_scaler.c
+++ b/drivers/gpu/drm/i915/display/skl_scaler.c
@@ -958,10 +958,8 @@ void skl_scaler_get_config(struct intel_crtc_state *crtc_state)
 		u32 ctl;
 
 		ctl = intel_de_read(display, SKL_PS_CTRL(crtc->pipe, scaler_id));
-		if ((ctl & (PS_SCALER_EN | PS_BINDING_MASK)) != (PS_SCALER_EN | PS_BINDING_PIPE))
-			continue;
-
-		break;
+		if ((ctl & (PS_SCALER_EN | PS_BINDING_MASK)) == (PS_SCALER_EN | PS_BINDING_PIPE))
+			break;
 	}
 
 	if (scaler_id == crtc->num_scalers)
-- 
2.45.2


  parent reply	other threads:[~2026-04-11 17:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-11 17:45 [PATCH v2 00/10] drm/i915: casf & scaler refactoring Michał Grzelak
2026-04-11 17:45 ` [PATCH v2 01/10] drm/i915/casf: fix comment typos Michał Grzelak
2026-04-11 17:45 ` [PATCH v2 02/10] drm/i915/casf: rename *_coeff*() into *_coef*() Michał Grzelak
2026-04-12 21:49   ` Michał Grzelak
2026-04-11 17:45 ` [PATCH v2 03/10] drm/i915: rename t into tap Michał Grzelak
2026-04-11 17:45 ` [PATCH v2 04/10] drm/i915/casf: rename sumcoeff into sum_coeff Michał Grzelak
2026-04-11 17:45 ` [PATCH v2 05/10] drm/i915/scaler: s/i/scaler_id where appropriate Michał Grzelak
2026-04-11 17:45 ` [PATCH v2 06/10] drm/i915/scaler: remove id in favor of scaler_id Michał Grzelak
2026-04-11 17:45 ` [PATCH v2 07/10] drm/i915/scaler: unloop scaler readout that is run once Michał Grzelak
2026-04-14  8:01   ` Garg, Nemesa
2026-04-20  8:22     ` Grzelak, Michal
2026-04-11 17:45 ` Michał Grzelak [this message]
2026-04-11 17:45 ` [PATCH v2 09/10] drm/i915/scaler: abstract scaler searching loop Michał Grzelak
2026-04-13 12:45   ` Ville Syrjälä
2026-04-20  8:19     ` Grzelak, Michal
2026-04-11 17:45 ` [PATCH v2 10/10] drm/i915/scaler: eliminate dead code Michał Grzelak
2026-04-11 18:41 ` ✓ i915.CI.BAT: success for drm/i915: casf & scaler refactoring (rev2) Patchwork
2026-04-11 23:56 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260411174526.2850179-9-michal.grzelak@intel.com \
    --to=michal.grzelak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=nemesa.garg@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox