public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH v2 0/3] drm/i915: Apply waitboosting before fence wait
@ 2022-07-08 14:20 Karolina Drobnik
  2022-07-08 14:20 ` [Intel-gfx] [PATCH v2 1/3] drm/i915/gem: Look for waitboosting across the whole object prior to individual waits Karolina Drobnik
                   ` (5 more replies)
  0 siblings, 6 replies; 15+ messages in thread
From: Karolina Drobnik @ 2022-07-08 14:20 UTC (permalink / raw)
  To: intel-gfx; +Cc: Chris Wilson

Waitboost is a heuristic that detects latency sensitive workloads waiting for
the results from previous execution. The wait can be seen as GPU
under-utilisation by RPS, Render Power State management, which might lower the
GPU frequency to save power. Limiting the frequency means more waiting for
results, which is undesirable for submissions with tight time constraints.
To circumvent this, with waitboost we iteratively check the list of fences
during gem_wait to see if any of them is stalled waiting for GPU. If such is
found, and the request hasn't yet started its execution, we temporarily bump up
the GPU frequency, so we get the required results as soon as possible.

Commit 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround") changes
the fences order and how they are iterated. Under this new scheme, we would wait
on each fence that starts executing, rendering them not suitable for waitboost.

To avoid situation like this, inspect the entire list of fences dma-resv
earlier, before gem_wait, instead of sequentially waiting for each of them,
applying the boost when needed.

v2:
  - Fixed a style issue in i915_gem_object_boost

Chris Wilson (3):
  drm/i915/gem: Look for waitboosting across the whole object prior to
    individual waits
  drm/i915: Bump GT idling delay to 2 jiffies
  drm/i915/gt: Only kick the signal worker if there's been an update

 drivers/gpu/drm/i915/gem/i915_gem_wait.c    | 34 +++++++++++++++++++++
 drivers/gpu/drm/i915/gt/intel_breadcrumbs.c |  3 +-
 drivers/gpu/drm/i915/i915_active.c          |  2 +-
 3 files changed, 37 insertions(+), 2 deletions(-)

--
2.25.1

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2022-07-12 21:55 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-08 14:20 [Intel-gfx] [PATCH v2 0/3] drm/i915: Apply waitboosting before fence wait Karolina Drobnik
2022-07-08 14:20 ` [Intel-gfx] [PATCH v2 1/3] drm/i915/gem: Look for waitboosting across the whole object prior to individual waits Karolina Drobnik
2022-07-08 14:41   ` Rodrigo Vivi
2022-07-08 14:20 ` [Intel-gfx] [PATCH v2 2/3] drm/i915: Bump GT idling delay to 2 jiffies Karolina Drobnik
2022-07-08 14:20 ` [Intel-gfx] [PATCH v2 3/3] drm/i915/gt: Only kick the signal worker if there's been an update Karolina Drobnik
2022-07-08 14:40   ` Rodrigo Vivi
2022-07-11 14:10     ` Rodrigo Vivi
2022-07-12  6:29     ` Karolina Drobnik
2022-07-12 21:55       ` Rodrigo Vivi
2022-07-12  9:46   ` Andi Shyti
2022-07-08 14:55 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Apply waitboosting before fence wait (rev2) Patchwork
2022-07-11  5:19   ` Karolina Drobnik
2022-07-08 15:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-07-09  2:00 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-07-11  5:20   ` Karolina Drobnik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox