Re: [PATCH 7/8] drm/i915/dram: Don't call skl_get_dram_info()/skl_get_dram_type() on icl

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 02 Sep 2025, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Currently the icl codepaths first determine the memory type from the
> memory controller registers (via skl_get_dram_info()->skl_get_dram_type())
> and then overwrite the results with icl_pcode_read_mem_global_info().
> Get rid of the pointless (and potentially incorrecgt) skl_get_dram_type()
> stuff.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/soc/intel_dram.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/soc/intel_dram.c b/drivers/gpu/drm/i915/soc/intel_dram.c
> index bf3ba874f8c5..38b7dd20b18d 100644
> --- a/drivers/gpu/drm/i915/soc/intel_dram.c
> +++ b/drivers/gpu/drm/i915/soc/intel_dram.c
> @@ -669,8 +669,9 @@ static int icl_pcode_read_mem_global_info(struct drm_i915_private *dev_priv,
>  
>  static int gen11_get_dram_info(struct drm_i915_private *i915, struct dram_info *dram_info)
>  {
> -	int ret = skl_get_dram_info(i915, dram_info);
> +	int ret;
>  
> +	ret = skl_dram_get_channels_info(i915, dram_info);
>  	if (ret)
>  		return ret;

-- 
Jani Nikula, Intel