Re: [PATCH 8/8] drm/i915/dram: Print memory details even if something went wrong

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 02 Sep 2025, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Print the memory details even if the detection failed in some way
> but we continued the driver initialization anyway. It'll be easier
> to debug issues if we at least know what the final results were.
>
> And while at it also print the number of PSF GV points. Previously
> we only printed the QGV points.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/soc/intel_dram.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/soc/intel_dram.c b/drivers/gpu/drm/i915/soc/intel_dram.c
> index 38b7dd20b18d..149527827624 100644
> --- a/drivers/gpu/drm/i915/soc/intel_dram.c
> +++ b/drivers/gpu/drm/i915/soc/intel_dram.c
> @@ -757,14 +757,15 @@ int intel_dram_detect(struct drm_i915_private *i915)
>  	drm_dbg_kms(&i915->drm, "DRAM type: %s\n",
>  		    intel_dram_type_str(dram_info->type));
>  
> -	/* TODO: Do we want to abort probe on dram detection failures? */
> -	if (ret)
> -		return 0;
> -
> -	drm_dbg_kms(&i915->drm, "Num qgv points %u\n", dram_info->num_qgv_points);
> -
>  	drm_dbg_kms(&i915->drm, "DRAM channels: %u\n", dram_info->num_channels);
>  
> +	drm_dbg_kms(&i915->drm, "Num QGV points %u\n", dram_info->num_qgv_points);
> +	drm_dbg_kms(&i915->drm, "Num PSF GV points %u\n", dram_info->num_psf_gv_points);
> +
> +	/* TODO: Do we want to abort probe on dram detection failures? */
> +	if (ret)
> +		return 0;
> +
>  	return 0;
>  }

-- 
Jani Nikula, Intel