Re: [PATCH 3/8] drm/i915/dram: Pack dram_info better

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 02 Sep 2025, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> struct dram_info has two holes in the middle. Shuffle things
> around to plug them.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/soc/intel_dram.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/soc/intel_dram.h b/drivers/gpu/drm/i915/soc/intel_dram.h
> index 846a77b1aa90..6212944d44aa 100644
> --- a/drivers/gpu/drm/i915/soc/intel_dram.h
> +++ b/drivers/gpu/drm/i915/soc/intel_dram.h
> @@ -12,9 +12,6 @@ struct drm_i915_private;
>  struct drm_device;
>  
>  struct dram_info {
> -	bool wm_lv_0_adjust_needed;
> -	u8 num_channels;
> -	bool symmetric_memory;
>  	enum intel_dram_type {
>  		INTEL_DRAM_UNKNOWN,
>  		INTEL_DRAM_DDR2,
> @@ -28,10 +25,13 @@ struct dram_info {
>  		INTEL_DRAM_GDDR_ECC,
>  		__INTEL_DRAM_TYPE_MAX,
>  	} type;
> -	u8 num_qgv_points;
> -	u8 num_psf_gv_points;
>  	unsigned int fsb_freq;
>  	unsigned int mem_freq;
> +	u8 num_channels;
> +	u8 num_qgv_points;
> +	u8 num_psf_gv_points;
> +	bool symmetric_memory;
> +	bool wm_lv_0_adjust_needed;
>  };
>  
>  void intel_dram_edram_detect(struct drm_i915_private *i915);

-- 
Jani Nikula, Intel