public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org,
	"\"kyungmin.park@samsung.com >> 박경민\""
	<kyungmin.park@samsung.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 01/11] drm: add plane support
Date: Wed, 26 Oct 2011 09:19:30 +0900	[thread overview]
Message-ID: <4EA75212.6050602@samsung.com> (raw)
In-Reply-To: <20111025131832.7e05c392@jbarnes-x220>

10/25/2011 08:18 PM, Jesse Barnes 쓴 글:
> On Tue, 25 Oct 2011 19:53:02 +0900
> Joonyoung Shim<jy0922.shim@samsung.com>  wrote:
>>> +/**
>>> + * drm_plane - central DRM plane control structure
>>> + * @dev: DRM device this plane belongs to
>>> + * @kdev: kernel device
>>> + * @attr: kdev attributes
>>> + * @head: for list management
>>> + * @base: base mode object
>>> + * @crtc_x: x position of plane (relative to pipe base)
>>> + * @crtc_y: y position of plane
>>> + * @x: x offset into fb
>>> + * @y: y offset into fb
>> Above 4 members don't be used.
> Oops yeah, I'll fix up the comments.
>
>>> +
>>> +struct drm_mode_get_plane {
>>> +	__u64 format_type_ptr;
>>> +	__u32 plane_id;
>>> +
>>> +	__u32 crtc_id;
>>> +	__u32 fb_id;
>>> +
>>> +	__u32 possible_crtcs;
>>> +	__u32 gamma_size;
>>> +
>>> +	__u32 count_format_types;
>>> +};
>> I wonder why doesn't give to user crtc_x, crtc_y, crtc_w, crtc_h
>> information?
> It could, but the caller should already know was my thinking.  Would
> you like those bits returned?

I saw such codes in initial your RFC patch version so i just have
wondered why it is removed. It can be added later if needs.

Thanks.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2011-10-26  0:19 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-25  9:46 DRM planes and new fb creation ioctl Jesse Barnes
2011-10-25  9:46 ` [PATCH 01/11] drm: add plane support Jesse Barnes
2011-10-25 10:53   ` Joonyoung Shim
2011-10-25 11:18     ` Jesse Barnes
2011-10-26  0:19       ` Joonyoung Shim [this message]
2011-10-25 11:58   ` Daniel Vetter
2011-10-25 12:26     ` Jesse Barnes
2011-10-25 13:26     ` Alan Cox
2011-10-25 13:32       ` Jesse Barnes
2011-10-25 13:42       ` Daniel Vetter
2011-10-25 14:09   ` Jesse Barnes
2011-10-25 16:43     ` Rob Clark
2011-10-25 19:41       ` Daniel Vetter
2011-10-25 20:14         ` Rob Clark
2011-10-27 14:05         ` SW Kim
2011-10-31 11:40           ` Inki Dae
2011-10-31 16:52             ` Jesse Barnes
2011-11-02  2:20               ` Inki Dae
2011-11-02 15:57                 ` Jesse Barnes
2011-10-26  5:40   ` Joonyoung Shim
2011-10-27 15:31     ` Jesse Barnes
2011-10-25  9:46 ` [PATCH 02/11] drm: add an fb creation ioctl that takes a pixel format Jesse Barnes
2011-10-25  9:46 ` [PATCH 03/11] drm/i915: rename existing overlay support to "legacy" Jesse Barnes
2011-10-25  9:46 ` [PATCH 04/11] drm/i915: add SNB video sprite support Jesse Barnes
2011-11-02  5:56   ` Inki Dae
2011-11-02 15:58     ` Jesse Barnes
2011-10-25  9:47 ` [PATCH 05/11] drm/i915: move pin & fence for plane past potential error paths Jesse Barnes
2011-10-25  9:47 ` [PATCH 06/11] drm/i915: plane teardown fixes Jesse Barnes
2011-10-25  9:47 ` [PATCH 07/11] drm/i915: enable new overlay code on IVB too Jesse Barnes
2011-10-25  9:47 ` [PATCH 08/11] drm/i915: overlay watermark hack Jesse Barnes
2011-10-25  9:47 ` [PATCH 09/11] drm/i915: fix overlay fb object handling Jesse Barnes
2011-10-25  9:47 ` [PATCH 10/11] drm/i915: clamp sprite to viewable area Jesse Barnes
2011-10-25  9:47 ` [PATCH 11/11] drm/i915: add sprite scaling support Jesse Barnes
2011-10-25 10:47 ` DRM planes and new fb creation ioctl Joonyoung Shim
2011-10-25 11:13   ` Jesse Barnes
2011-10-26  1:04     ` Joonyoung Shim
2011-10-25 11:20 ` Jesse Barnes
2011-10-25 11:22 ` [PATCH] drm/i915: add SNB video sprite support Jesse Barnes
2011-10-25 11:30   ` Jesse Barnes
2011-11-01 14:11   ` Lan, Hai
2011-11-03 18:44     ` [Intel-gfx] " Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EA75212.6050602@samsung.com \
    --to=jy0922.shim@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=kyungmin.park@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox