Re: [PATCH 01/11] drm: add plane support

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Tue, 25 Oct 2011 19:53:02 +0900
Joonyoung Shim <jy0922.shim@samsung.com> wrote:
> > +/**
> > + * drm_plane - central DRM plane control structure
> > + * @dev: DRM device this plane belongs to
> > + * @kdev: kernel device
> > + * @attr: kdev attributes
> > + * @head: for list management
> > + * @base: base mode object
> > + * @crtc_x: x position of plane (relative to pipe base)
> > + * @crtc_y: y position of plane
> > + * @x: x offset into fb
> > + * @y: y offset into fb
> Above 4 members don't be used.

Oops yeah, I'll fix up the comments.

> > +
> > +struct drm_mode_get_plane {
> > +	__u64 format_type_ptr;
> > +	__u32 plane_id;
> > +
> > +	__u32 crtc_id;
> > +	__u32 fb_id;
> > +
> > +	__u32 possible_crtcs;
> > +	__u32 gamma_size;
> > +
> > +	__u32 count_format_types;
> > +};
> 
> I wonder why doesn't give to user crtc_x, crtc_y, crtc_w, crtc_h
> information?

It could, but the caller should already know was my thinking.  Would
you like those bits returned?

Jesse