Re: [Intel-gfx] [Intel-xe] [PATCH v2 03/27] drm/i915/xe2lpd: FBC is now supported on all pipes

["Govindapillai, Vinod" <vinod.govindapillai@intel.com>]

On Thu, 2023-09-07 at 08:37 -0700, Lucas De Marchi wrote:
> From: Matt Roper <matthew.d.roper@intel.com>
> 
> FBC is no longer limited by pipe: add the defines for pipes B and C that
> will be used by platforms supporting FBC on such pipes.
> 
> Bspec: 68881, 68904
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display_device.c | 3 +++
>  drivers/gpu/drm/i915/display/intel_fbc.h            | 2 ++
>  2 files changed, 5 insertions(+)

Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>

> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c
> b/drivers/gpu/drm/i915/display/intel_display_device.c
> index feafb0f94b06..652e35ed7789 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.c
> @@ -772,6 +772,9 @@ static const struct intel_display_device_info xe2_lpd_display = {
>         XE_LPDP_FEATURES,
>  
>         .__runtime_defaults.ip.ver = 20,
> +       .__runtime_defaults.fbc_mask =
> +               BIT(INTEL_FBC_A) | BIT(INTEL_FBC_B) |
> +               BIT(INTEL_FBC_C) | BIT(INTEL_FBC_D),
>  };
>  
>  /*
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.h b/drivers/gpu/drm/i915/display/intel_fbc.h
> index 4adb98afe6ff..6720ec8ee8a2 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbc.h
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.h
> @@ -20,6 +20,8 @@ struct intel_plane_state;
>  enum intel_fbc_id {
>         INTEL_FBC_A,
>         INTEL_FBC_B,
> +       INTEL_FBC_C,
> +       INTEL_FBC_D,
>  
>         I915_MAX_FBCS,
>  };