From: "Souza, Jose" <jose.souza@intel.com>
To: "ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/display: Drop FIXME about turn off infoframes
Date: Thu, 10 Jun 2021 17:44:12 +0000 [thread overview]
Message-ID: <57a75282acd88b3613c2f737dde1c0ba529d34c8.camel@intel.com> (raw)
In-Reply-To: <YMIDF+fA5GTJ8Bqs@intel.com>
On Thu, 2021-06-10 at 15:18 +0300, Ville Syrjälä wrote:
> On Wed, Jun 09, 2021 at 07:25:36PM +0000, Souza, Jose wrote:
> > On Tue, 2021-06-08 at 10:26 +0300, Ville Syrjälä wrote:
> > > On Fri, May 14, 2021 at 04:22:47PM -0700, José Roberto de Souza wrote:
> > > > intel_dp_set_infoframes() call in intel_ddi_post_disable_dp() will
> > > > take care to disable all enabled infoframes.
> > > >
> > > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > > ---
> > > > drivers/gpu/drm/i915/display/intel_ddi.c | 1 -
> > > > 1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> > > > index 5bc5528f3091..d3bc5a1a936a 100644
> > > > --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> > > > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> > > > @@ -2762,7 +2762,6 @@ static void intel_ddi_pre_enable(struct intel_atomic_state *state,
> > > > conn_state);
> > > >
> > > > /* FIXME precompute everything properly */
> > > > - /* FIXME how do we turn infoframes off again? */
> > >
> > > The FIXME was there for LSPCON and shouldn't have been removed.
> > > No one has yet figured out how to do this.
> >
> > intel_ddi_post_disable_dp()->intel_dp_set_infoframes() will be executed for LSPCON, or am I missing something?
>
> LSPCON generates its own infoframes, so turning off the video DIP does
> diddly squat.
>
It would not be the lspcon job to do so when DP -> lspcon video is off?
Anyways will be sending the revert in a few minutes, please review that if we really need this fixme back.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-06-10 17:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 23:22 [Intel-gfx] [PATCH v2 1/4] drm/i915/display: Fix fastsets involving PSR José Roberto de Souza
2021-05-14 23:22 ` [Intel-gfx] [PATCH v2 2/4] drm/i915/display: Allow fastsets when DP_SDP_VSC infoframe do not match with PSR enabled José Roberto de Souza
2021-06-07 11:44 ` Gwan-gyeong Mun
2021-05-14 23:22 ` [Intel-gfx] [PATCH v2 3/4] drm/i915/display: Nuke has_infoframe José Roberto de Souza
2021-05-21 15:27 ` Mun, Gwan-gyeong
2021-05-21 19:58 ` Souza, Jose
2021-06-07 12:49 ` Gwan-gyeong Mun
2021-06-07 23:16 ` Souza, Jose
2021-05-14 23:22 ` [Intel-gfx] [PATCH v2 4/4] drm/i915/display: Drop FIXME about turn off infoframes José Roberto de Souza
2021-06-01 22:41 ` Sripada, Radhakrishna
2021-06-08 7:26 ` Ville Syrjälä
2021-06-09 19:25 ` Souza, Jose
2021-06-10 12:18 ` Ville Syrjälä
2021-06-10 17:44 ` Souza, Jose [this message]
2021-06-11 18:15 ` Ville Syrjälä
2021-05-14 23:41 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/4] drm/i915/display: Fix fastsets involving PSR Patchwork
2021-05-14 23:42 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-05-15 0:11 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-05-15 0:38 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/4] drm/i915/display: Fix fastsets involving PSR (rev2) Patchwork
2021-05-15 0:39 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-05-15 1:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-05-15 13:15 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-06-07 17:51 ` Souza, Jose
2021-06-07 11:19 ` [Intel-gfx] [PATCH v2 1/4] drm/i915/display: Fix fastsets involving PSR Gwan-gyeong Mun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57a75282acd88b3613c2f737dde1c0ba529d34c8.camel@intel.com \
--to=jose.souza@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox