Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/display: Nuke has_infoframe

["Souza, Jose" <jose.souza@intel.com>]

On Mon, 2021-06-07 at 15:49 +0300, Gwan-gyeong Mun wrote:
> 
> On 5/21/21 10:58 PM, Souza, Jose wrote:
> > On Fri, 2021-05-21 at 16:27 +0100, Mun, Gwan-gyeong wrote:
> > > On Fri, 2021-05-14 at 16:22 -0700, José Roberto de Souza wrote:
> > > > This was only reduntant information has_hdmi_sink can do the same job.
> > > > set_infoframes() hooks will call intel_write_infoframe() for the
> > > > supported infoframes types and it will only be enabled if given type
> > > > is set in crtc_state->infoframes.enable.
> > > > 
> > > > While at it also fixing the style of dig_port->set_infoframes() calls.
> > > > 
> > > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > > ---
> > > >   drivers/gpu/drm/i915/display/g4x_hdmi.c       | 22 ++++++-------------
> > > >   drivers/gpu/drm/i915/display/intel_ddi.c      | 17 +++++---------
> > > >   drivers/gpu/drm/i915/display/intel_display.c  |  6 ++---
> > > >   .../drm/i915/display/intel_display_types.h    |  3 ---
> > > >   drivers/gpu/drm/i915/display/intel_dp_mst.c   |  4 ++--
> > > >   drivers/gpu/drm/i915/display/intel_hdmi.c     | 13 +++++------
> > > >   6 files changed, 22 insertions(+), 43 deletions(-)
> > > > 
> > > > diff --git a/drivers/gpu/drm/i915/display/g4x_hdmi.c
> > > > b/drivers/gpu/drm/i915/display/g4x_hdmi.c
> > > > index be352e9f0afc..f35db96e6239 100644
> > > > --- a/drivers/gpu/drm/i915/display/g4x_hdmi.c
> > > > +++ b/drivers/gpu/drm/i915/display/g4x_hdmi.c
> > > > @@ -105,9 +105,6 @@ static void intel_hdmi_get_config(struct
> > > > intel_encoder *encoder,
> > > >          pipe_config->infoframes.enable |=
> > > >                  intel_hdmi_infoframes_enabled(encoder, pipe_config);
> > > >   
> > > > -       if (pipe_config->infoframes.enable)
> > > > -               pipe_config->has_infoframe = true;
> > > > -
> > > "pipe_config->infoframes.enable" is set with information about the
> > > infoframes currently active in the hardware through "pipe_config-
> > > > infoframes.enable |= intel_hdmi_infoframes_enabled(encoder,
> > > pipe_config);".
> > > 
> > > Therefore, when calling set_infoframes() semantically, the
> > > has_infoframe information set by "if (pipe_config->infoframes.enable)
> > > pipe_config->has_infoframe = true;" is more clear.
> > 
> > That don't work because the functions that will check if a infoframe is needed and set pipe_config->infoframes.enable depends on pipe_config-
> > > has_infoframe/crtc_state->has_hdmi_sink.
> > That is probably because DVI ports don't support infoframes but in i915 are handle very similar to HDMI.
> > 
> > > 
> DP and HDMI can have infoframes that fit each specification in the 
> specification.
> And (although not used in this sense here) when dp has hdmi sink, it can 
> be thought of using dp to hdmi protocol converter. I think it might be a 
> little unclear, but what do you think?

Not sure if I understood what you mean but on intel_hdmi_compute_config(), has_infoframe is set right now after check if there is a HDMI sink(handling
DP and HDMI, intel_has_hdmi_sink()).

FYI I have applied all the other patches.


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx