* [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs
@ 2023-10-06 14:15 Stanislav Lisovskiy
0 siblings, 0 replies; 18+ messages in thread
From: Stanislav Lisovskiy @ 2023-10-06 14:15 UTC (permalink / raw)
To: intel-gfx
For validation purposes, it might be useful to be able to
force Bigjoiner mode, even if current dotclock/resolution
do not require that.
Lets add such to option to debugfs.
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
.../drm/i915/display/intel_display_debugfs.c | 71 +++++++++++++++++++
.../drm/i915/display/intel_display_types.h | 2 +
drivers/gpu/drm/i915/display/intel_dp.c | 3 +-
3 files changed, 75 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index f6d7c4d45fae..5855c6de91a7 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -1399,6 +1399,35 @@ out: drm_modeset_unlock(&dev->mode_config.connection_mutex);
return ret;
}
+static int i915_bigjoiner_enable_show(struct seq_file *m, void *data)
+{
+ struct drm_connector *connector = m->private;
+ struct drm_device *dev = connector->dev;
+ struct drm_crtc *crtc;
+ struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
+ struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
+ int ret;
+
+ if (!encoder)
+ return -ENODEV;
+
+ ret = drm_modeset_lock_single_interruptible(&dev->mode_config.connection_mutex);
+ if (ret)
+ return ret;
+
+ crtc = connector->state->crtc;
+ if (connector->status != connector_status_connected || !crtc) {
+ ret = -ENODEV;
+ goto out;
+ }
+
+ seq_printf(m, "Bigjoiner enable: %d\n", intel_dp->force_bigjoiner_en);
+
+out: drm_modeset_unlock(&dev->mode_config.connection_mutex);
+
+ return ret;
+}
+
static ssize_t i915_dsc_output_format_write(struct file *file,
const char __user *ubuf,
size_t len, loff_t *offp)
@@ -1420,12 +1449,39 @@ static ssize_t i915_dsc_output_format_write(struct file *file,
return len;
}
+static ssize_t i915_bigjoiner_enable_fops_write(struct file *file,
+ const char __user *ubuf,
+ size_t len, loff_t *offp)
+{
+ struct drm_connector *connector =
+ ((struct seq_file *)file->private_data)->private;
+ struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
+ struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
+ int bigjoiner_en = 0;
+ int ret;
+
+ ret = kstrtoint_from_user(ubuf, len, 0, &bigjoiner_en);
+ if (ret < 0)
+ return ret;
+
+ intel_dp->force_bigjoiner_en = bigjoiner_en;
+ *offp += len;
+
+ return len;
+}
+
static int i915_dsc_output_format_open(struct inode *inode,
struct file *file)
{
return single_open(file, i915_dsc_output_format_show, inode->i_private);
}
+static int i915_bigjoiner_enable_open(struct inode *inode,
+ struct file *file)
+{
+ return single_open(file, i915_bigjoiner_enable_show, inode->i_private);
+}
+
static const struct file_operations i915_dsc_output_format_fops = {
.owner = THIS_MODULE,
.open = i915_dsc_output_format_open,
@@ -1435,6 +1491,15 @@ static const struct file_operations i915_dsc_output_format_fops = {
.write = i915_dsc_output_format_write
};
+static const struct file_operations i915_bigjoiner_enable_fops = {
+ .owner = THIS_MODULE,
+ .open = i915_bigjoiner_enable_open,
+ .read = seq_read,
+ .llseek = seq_lseek,
+ .release = single_release,
+ .write = i915_bigjoiner_enable_fops_write
+};
+
/*
* Returns the Current CRTC's bpc.
* Example usage: cat /sys/kernel/debug/dri/0/crtc-0/i915_current_bpc
@@ -1514,6 +1579,12 @@ void intel_connector_debugfs_add(struct intel_connector *intel_connector)
connector, &i915_dsc_output_format_fops);
}
+ if (intel_dp_can_bigjoiner(enc_to_intel_dp(intel_connector->encoder)) &&
+ connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
+ debugfs_create_file("i915_bigjoiner_force_enable", 0644, root,
+ connector, &i915_bigjoiner_enable_fops);
+ }
+
if (connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 8d8b2f8d37a9..ecec8a25838e 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1753,6 +1753,8 @@ struct intel_dp {
bool is_mst;
int active_mst_links;
+ bool force_bigjoiner_en;
+
/* connector directly attached - won't be use for modeset in mst world */
struct intel_connector *attached_connector;
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index f0f43aeabd21..6665214bd332 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1153,7 +1153,8 @@ bool intel_dp_need_bigjoiner(struct intel_dp *intel_dp,
if (!intel_dp_can_bigjoiner(intel_dp))
return false;
- return clock > i915->max_dotclk_freq || hdisplay > 5120;
+ return clock > i915->max_dotclk_freq || hdisplay > 5120 ||
+ intel_dp->force_bigjoiner_en;
}
static enum drm_mode_status
--
2.37.3
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs
@ 2023-10-09 13:30 Stanislav Lisovskiy
2023-10-11 8:49 ` Jani Nikula
0 siblings, 1 reply; 18+ messages in thread
From: Stanislav Lisovskiy @ 2023-10-09 13:30 UTC (permalink / raw)
To: intel-gfx
For validation purposes, it might be useful to be able to
force Bigjoiner mode, even if current dotclock/resolution
do not require that.
Lets add such to option to debugfs.
v2: - Apparently intel_dp_need_bigjoiner can't be used, when
debugfs entry is created so lets just check manually
the DISPLAY_VER.
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
.../drm/i915/display/intel_display_debugfs.c | 71 +++++++++++++++++++
.../drm/i915/display/intel_display_types.h | 2 +
drivers/gpu/drm/i915/display/intel_dp.c | 6 +-
3 files changed, 78 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index f6d7c4d45fae..c806957cb902 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -1399,6 +1399,35 @@ out: drm_modeset_unlock(&dev->mode_config.connection_mutex);
return ret;
}
+static int i915_bigjoiner_enable_show(struct seq_file *m, void *data)
+{
+ struct drm_connector *connector = m->private;
+ struct drm_device *dev = connector->dev;
+ struct drm_crtc *crtc;
+ struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
+ struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
+ int ret;
+
+ if (!encoder)
+ return -ENODEV;
+
+ ret = drm_modeset_lock_single_interruptible(&dev->mode_config.connection_mutex);
+ if (ret)
+ return ret;
+
+ crtc = connector->state->crtc;
+ if (connector->status != connector_status_connected || !crtc) {
+ ret = -ENODEV;
+ goto out;
+ }
+
+ seq_printf(m, "Bigjoiner enable: %d\n", intel_dp->force_bigjoiner_en);
+
+out: drm_modeset_unlock(&dev->mode_config.connection_mutex);
+
+ return ret;
+}
+
static ssize_t i915_dsc_output_format_write(struct file *file,
const char __user *ubuf,
size_t len, loff_t *offp)
@@ -1420,12 +1449,39 @@ static ssize_t i915_dsc_output_format_write(struct file *file,
return len;
}
+static ssize_t i915_bigjoiner_enable_fops_write(struct file *file,
+ const char __user *ubuf,
+ size_t len, loff_t *offp)
+{
+ struct drm_connector *connector =
+ ((struct seq_file *)file->private_data)->private;
+ struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
+ struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
+ int bigjoiner_en = 0;
+ int ret;
+
+ ret = kstrtoint_from_user(ubuf, len, 0, &bigjoiner_en);
+ if (ret < 0)
+ return ret;
+
+ intel_dp->force_bigjoiner_en = bigjoiner_en;
+ *offp += len;
+
+ return len;
+}
+
static int i915_dsc_output_format_open(struct inode *inode,
struct file *file)
{
return single_open(file, i915_dsc_output_format_show, inode->i_private);
}
+static int i915_bigjoiner_enable_open(struct inode *inode,
+ struct file *file)
+{
+ return single_open(file, i915_bigjoiner_enable_show, inode->i_private);
+}
+
static const struct file_operations i915_dsc_output_format_fops = {
.owner = THIS_MODULE,
.open = i915_dsc_output_format_open,
@@ -1435,6 +1491,15 @@ static const struct file_operations i915_dsc_output_format_fops = {
.write = i915_dsc_output_format_write
};
+static const struct file_operations i915_bigjoiner_enable_fops = {
+ .owner = THIS_MODULE,
+ .open = i915_bigjoiner_enable_open,
+ .read = seq_read,
+ .llseek = seq_lseek,
+ .release = single_release,
+ .write = i915_bigjoiner_enable_fops_write
+};
+
/*
* Returns the Current CRTC's bpc.
* Example usage: cat /sys/kernel/debug/dri/0/crtc-0/i915_current_bpc
@@ -1514,6 +1579,12 @@ void intel_connector_debugfs_add(struct intel_connector *intel_connector)
connector, &i915_dsc_output_format_fops);
}
+ if (DISPLAY_VER(dev_priv) >= 11 &&
+ connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
+ debugfs_create_file("i915_bigjoiner_force_enable", 0644, root,
+ connector, &i915_bigjoiner_enable_fops);
+ }
+
if (connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 8d8b2f8d37a9..ecec8a25838e 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1753,6 +1753,8 @@ struct intel_dp {
bool is_mst;
int active_mst_links;
+ bool force_bigjoiner_en;
+
/* connector directly attached - won't be use for modeset in mst world */
struct intel_connector *attached_connector;
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index f0f43aeabd21..7e553cb7ecbb 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1153,7 +1153,11 @@ bool intel_dp_need_bigjoiner(struct intel_dp *intel_dp,
if (!intel_dp_can_bigjoiner(intel_dp))
return false;
- return clock > i915->max_dotclk_freq || hdisplay > 5120;
+ if (intel_dp->force_bigjoiner_en)
+ drm_dbg_kms(&i915->drm, "Forcing bigjoiner mode");
+
+ return clock > i915->max_dotclk_freq || hdisplay > 5120 ||
+ intel_dp->force_bigjoiner_en;
}
static enum drm_mode_status
--
2.37.3
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs
2023-10-09 13:30 Stanislav Lisovskiy
@ 2023-10-11 8:49 ` Jani Nikula
2023-10-11 8:59 ` Lisovskiy, Stanislav
0 siblings, 1 reply; 18+ messages in thread
From: Jani Nikula @ 2023-10-11 8:49 UTC (permalink / raw)
To: Stanislav Lisovskiy, intel-gfx
On Mon, 09 Oct 2023, Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> wrote:
> For validation purposes, it might be useful to be able to
> force Bigjoiner mode, even if current dotclock/resolution
> do not require that.
> Lets add such to option to debugfs.
>
> v2: - Apparently intel_dp_need_bigjoiner can't be used, when
> debugfs entry is created so lets just check manually
> the DISPLAY_VER.
>
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> ---
> .../drm/i915/display/intel_display_debugfs.c | 71 +++++++++++++++++++
> .../drm/i915/display/intel_display_types.h | 2 +
> drivers/gpu/drm/i915/display/intel_dp.c | 6 +-
> 3 files changed, 78 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index f6d7c4d45fae..c806957cb902 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -1399,6 +1399,35 @@ out: drm_modeset_unlock(&dev->mode_config.connection_mutex);
> return ret;
> }
>
> +static int i915_bigjoiner_enable_show(struct seq_file *m, void *data)
> +{
> + struct drm_connector *connector = m->private;
struct intel_connector *connector, please. Yeah, this is copy-paste from
other files, but they should be changed too.
> + struct drm_device *dev = connector->dev;
struct drm_i915_private *i915, please.
> + struct drm_crtc *crtc;
> + struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
> + struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> + int ret;
> +
> + if (!encoder)
> + return -ENODEV;
> +
> + ret = drm_modeset_lock_single_interruptible(&dev->mode_config.connection_mutex);
> + if (ret)
> + return ret;
Why does show need locking but write doesn't?
> +
> + crtc = connector->state->crtc;
> + if (connector->status != connector_status_connected || !crtc) {
> + ret = -ENODEV;
> + goto out;
> + }
I guess because of the above, but... do we need it? Or is this just
copy-pasted from some other debugfs files, which copy-pasted from other
debugfs files, which... ;)
> +
> + seq_printf(m, "Bigjoiner enable: %d\n", intel_dp->force_bigjoiner_en);
> +
> +out: drm_modeset_unlock(&dev->mode_config.connection_mutex);
> +
> + return ret;
> +}
> +
> static ssize_t i915_dsc_output_format_write(struct file *file,
> const char __user *ubuf,
> size_t len, loff_t *offp)
> @@ -1420,12 +1449,39 @@ static ssize_t i915_dsc_output_format_write(struct file *file,
> return len;
> }
>
> +static ssize_t i915_bigjoiner_enable_fops_write(struct file *file,
> + const char __user *ubuf,
> + size_t len, loff_t *offp)
> +{
> + struct drm_connector *connector =
> + ((struct seq_file *)file->private_data)->private;
I think this reads better with
struct seq_file *m = file->private_data;
struct intel_connector *connector = m->private;
> + struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
> + struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> + int bigjoiner_en = 0;
> + int ret;
> +
> + ret = kstrtoint_from_user(ubuf, len, 0, &bigjoiner_en);
> + if (ret < 0)
> + return ret;
If it's a bool, why kstrtoint? Yeah, because copy-paste, but why keep
percolating the same mistakes?
> +
> + intel_dp->force_bigjoiner_en = bigjoiner_en;
> + *offp += len;
> +
> + return len;
> +}
> +
> static int i915_dsc_output_format_open(struct inode *inode,
> struct file *file)
> {
> return single_open(file, i915_dsc_output_format_show, inode->i_private);
> }
>
> +static int i915_bigjoiner_enable_open(struct inode *inode,
> + struct file *file)
> +{
> + return single_open(file, i915_bigjoiner_enable_show, inode->i_private);
> +}
> +
> static const struct file_operations i915_dsc_output_format_fops = {
> .owner = THIS_MODULE,
> .open = i915_dsc_output_format_open,
> @@ -1435,6 +1491,15 @@ static const struct file_operations i915_dsc_output_format_fops = {
> .write = i915_dsc_output_format_write
> };
>
> +static const struct file_operations i915_bigjoiner_enable_fops = {
> + .owner = THIS_MODULE,
> + .open = i915_bigjoiner_enable_open,
> + .read = seq_read,
> + .llseek = seq_lseek,
> + .release = single_release,
> + .write = i915_bigjoiner_enable_fops_write
> +};
> +
> /*
> * Returns the Current CRTC's bpc.
> * Example usage: cat /sys/kernel/debug/dri/0/crtc-0/i915_current_bpc
> @@ -1514,6 +1579,12 @@ void intel_connector_debugfs_add(struct intel_connector *intel_connector)
> connector, &i915_dsc_output_format_fops);
> }
>
> + if (DISPLAY_VER(dev_priv) >= 11 &&
> + connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
> + debugfs_create_file("i915_bigjoiner_force_enable", 0644, root,
> + connector, &i915_bigjoiner_enable_fops);
All of these should just pass struct intel_connector.
> + }
> +
> if (connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
> connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
> connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index 8d8b2f8d37a9..ecec8a25838e 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -1753,6 +1753,8 @@ struct intel_dp {
> bool is_mst;
> int active_mst_links;
>
> + bool force_bigjoiner_en;
No need to try to shorten this, just spell out force_bigjoiner_enable.
> +
> /* connector directly attached - won't be use for modeset in mst world */
> struct intel_connector *attached_connector;
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index f0f43aeabd21..7e553cb7ecbb 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -1153,7 +1153,11 @@ bool intel_dp_need_bigjoiner(struct intel_dp *intel_dp,
> if (!intel_dp_can_bigjoiner(intel_dp))
> return false;
>
> - return clock > i915->max_dotclk_freq || hdisplay > 5120;
> + if (intel_dp->force_bigjoiner_en)
> + drm_dbg_kms(&i915->drm, "Forcing bigjoiner mode");
Missing \n.
> +
> + return clock > i915->max_dotclk_freq || hdisplay > 5120 ||
> + intel_dp->force_bigjoiner_en;
> }
>
> static enum drm_mode_status
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs
2023-10-11 8:49 ` Jani Nikula
@ 2023-10-11 8:59 ` Lisovskiy, Stanislav
0 siblings, 0 replies; 18+ messages in thread
From: Lisovskiy, Stanislav @ 2023-10-11 8:59 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Wed, Oct 11, 2023 at 11:49:38AM +0300, Jani Nikula wrote:
> On Mon, 09 Oct 2023, Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> wrote:
> > For validation purposes, it might be useful to be able to
> > force Bigjoiner mode, even if current dotclock/resolution
> > do not require that.
> > Lets add such to option to debugfs.
> >
> > v2: - Apparently intel_dp_need_bigjoiner can't be used, when
> > debugfs entry is created so lets just check manually
> > the DISPLAY_VER.
> >
> > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> > ---
> > .../drm/i915/display/intel_display_debugfs.c | 71 +++++++++++++++++++
> > .../drm/i915/display/intel_display_types.h | 2 +
> > drivers/gpu/drm/i915/display/intel_dp.c | 6 +-
> > 3 files changed, 78 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > index f6d7c4d45fae..c806957cb902 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > @@ -1399,6 +1399,35 @@ out: drm_modeset_unlock(&dev->mode_config.connection_mutex);
> > return ret;
> > }
> >
> > +static int i915_bigjoiner_enable_show(struct seq_file *m, void *data)
> > +{
> > + struct drm_connector *connector = m->private;
>
> struct intel_connector *connector, please. Yeah, this is copy-paste from
> other files, but they should be changed too.
>
> > + struct drm_device *dev = connector->dev;
>
> struct drm_i915_private *i915, please.
>
> > + struct drm_crtc *crtc;
> > + struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
> > + struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> > + int ret;
> > +
> > + if (!encoder)
> > + return -ENODEV;
> > +
> > + ret = drm_modeset_lock_single_interruptible(&dev->mode_config.connection_mutex);
> > + if (ret)
> > + return ret;
>
> Why does show need locking but write doesn't?
>
> > +
> > + crtc = connector->state->crtc;
> > + if (connector->status != connector_status_connected || !crtc) {
> > + ret = -ENODEV;
> > + goto out;
> > + }
>
> I guess because of the above, but... do we need it? Or is this just
> copy-pasted from some other debugfs files, which copy-pasted from other
> debugfs files, which... ;)
Yeah, I would be honest here, had same question both for bool/int and crtc locking
however decided just to copy same approach, from other debugfs entries, assuming
that was done with some purpose :)
>
> > +
> > + seq_printf(m, "Bigjoiner enable: %d\n", intel_dp->force_bigjoiner_en);
> > +
> > +out: drm_modeset_unlock(&dev->mode_config.connection_mutex);
> > +
> > + return ret;
> > +}
> > +
> > static ssize_t i915_dsc_output_format_write(struct file *file,
> > const char __user *ubuf,
> > size_t len, loff_t *offp)
> > @@ -1420,12 +1449,39 @@ static ssize_t i915_dsc_output_format_write(struct file *file,
> > return len;
> > }
> >
> > +static ssize_t i915_bigjoiner_enable_fops_write(struct file *file,
> > + const char __user *ubuf,
> > + size_t len, loff_t *offp)
> > +{
> > + struct drm_connector *connector =
> > + ((struct seq_file *)file->private_data)->private;
>
> I think this reads better with
>
> struct seq_file *m = file->private_data;
> struct intel_connector *connector = m->private;
>
> > + struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
> > + struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> > + int bigjoiner_en = 0;
> > + int ret;
> > +
> > + ret = kstrtoint_from_user(ubuf, len, 0, &bigjoiner_en);
> > + if (ret < 0)
> > + return ret;
>
> If it's a bool, why kstrtoint? Yeah, because copy-paste, but why keep
> percolating the same mistakes?
Yeah, as I said above..
>
> > +
> > + intel_dp->force_bigjoiner_en = bigjoiner_en;
> > + *offp += len;
> > +
> > + return len;
> > +}
> > +
> > static int i915_dsc_output_format_open(struct inode *inode,
> > struct file *file)
> > {
> > return single_open(file, i915_dsc_output_format_show, inode->i_private);
> > }
> >
> > +static int i915_bigjoiner_enable_open(struct inode *inode,
> > + struct file *file)
> > +{
> > + return single_open(file, i915_bigjoiner_enable_show, inode->i_private);
> > +}
> > +
> > static const struct file_operations i915_dsc_output_format_fops = {
> > .owner = THIS_MODULE,
> > .open = i915_dsc_output_format_open,
> > @@ -1435,6 +1491,15 @@ static const struct file_operations i915_dsc_output_format_fops = {
> > .write = i915_dsc_output_format_write
> > };
> >
> > +static const struct file_operations i915_bigjoiner_enable_fops = {
> > + .owner = THIS_MODULE,
> > + .open = i915_bigjoiner_enable_open,
> > + .read = seq_read,
> > + .llseek = seq_lseek,
> > + .release = single_release,
> > + .write = i915_bigjoiner_enable_fops_write
> > +};
> > +
> > /*
> > * Returns the Current CRTC's bpc.
> > * Example usage: cat /sys/kernel/debug/dri/0/crtc-0/i915_current_bpc
> > @@ -1514,6 +1579,12 @@ void intel_connector_debugfs_add(struct intel_connector *intel_connector)
> > connector, &i915_dsc_output_format_fops);
> > }
> >
> > + if (DISPLAY_VER(dev_priv) >= 11 &&
> > + connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
> > + debugfs_create_file("i915_bigjoiner_force_enable", 0644, root,
> > + connector, &i915_bigjoiner_enable_fops);
>
> All of these should just pass struct intel_connector.
Do you mean intel_connector_debugfs_add? I think it does that already, will check.
>
> > + }
> > +
> > if (connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
> > connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
> > connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> > index 8d8b2f8d37a9..ecec8a25838e 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> > @@ -1753,6 +1753,8 @@ struct intel_dp {
> > bool is_mst;
> > int active_mst_links;
> >
> > + bool force_bigjoiner_en;
>
> No need to try to shorten this, just spell out force_bigjoiner_enable.
Again just tried to match same things done before, but for me personally
doesn't really matter at all.
>
> > +
> > /* connector directly attached - won't be use for modeset in mst world */
> > struct intel_connector *attached_connector;
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> > index f0f43aeabd21..7e553cb7ecbb 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -1153,7 +1153,11 @@ bool intel_dp_need_bigjoiner(struct intel_dp *intel_dp,
> > if (!intel_dp_can_bigjoiner(intel_dp))
> > return false;
> >
> > - return clock > i915->max_dotclk_freq || hdisplay > 5120;
> > + if (intel_dp->force_bigjoiner_en)
> > + drm_dbg_kms(&i915->drm, "Forcing bigjoiner mode");
>
> Missing \n.
Yes, will fix, thank you for comments!
Stan
>
> > +
> > + return clock > i915->max_dotclk_freq || hdisplay > 5120 ||
> > + intel_dp->force_bigjoiner_en;
> > }
> >
> > static enum drm_mode_status
>
> --
> Jani Nikula, Intel
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs
@ 2023-10-12 12:34 Stanislav Lisovskiy
2023-10-12 14:59 ` Jani Nikula
` (4 more replies)
0 siblings, 5 replies; 18+ messages in thread
From: Stanislav Lisovskiy @ 2023-10-12 12:34 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
For validation purposes, it might be useful to be able to
force Bigjoiner mode, even if current dotclock/resolution
do not require that.
Lets add such to option to debugfs.
v2: - Apparently intel_dp_need_bigjoiner can't be used, when
debugfs entry is created so lets just check manually
the DISPLAY_VER.
v3: - Switch to intel_connector from drm_connector(Jani Nikula)
- Remove redundant modeset lock(Jani Nikula)
- Use kstrtobool_from_user for boolean value(Jani Nikula)
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
.../drm/i915/display/intel_display_debugfs.c | 72 ++++++++++++++++++-
.../drm/i915/display/intel_display_types.h | 2 +
drivers/gpu/drm/i915/display/intel_dp.c | 6 +-
3 files changed, 76 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index fbe75d47a165..dea7bbea83ba 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -1398,13 +1398,37 @@ out: drm_modeset_unlock(&dev->mode_config.connection_mutex);
return ret;
}
+static int i915_bigjoiner_enable_show(struct seq_file *m, void *data)
+{
+ struct intel_connector *connector = to_intel_connector(m->private);
+ struct drm_crtc *crtc;
+ struct intel_encoder *encoder = intel_attached_encoder(connector);
+ struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
+ int ret;
+
+ if (!encoder)
+ return -ENODEV;
+
+ crtc = connector->base.state->crtc;
+ if (connector->base.status != connector_status_connected || !crtc) {
+ ret = -ENODEV;
+ goto out;
+ }
+
+ seq_printf(m, "Bigjoiner enable: %d\n", intel_dp->force_bigjoiner_enable);
+
+out:
+
+ return ret;
+}
+
static ssize_t i915_dsc_output_format_write(struct file *file,
const char __user *ubuf,
size_t len, loff_t *offp)
{
- struct drm_connector *connector =
- ((struct seq_file *)file->private_data)->private;
- struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
+ struct seq_file *m = file->private_data;
+ struct intel_connector *connector = m->private;
+ struct intel_encoder *encoder = intel_attached_encoder(connector);
struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
int dsc_output_format = 0;
int ret;
@@ -1419,12 +1443,39 @@ static ssize_t i915_dsc_output_format_write(struct file *file,
return len;
}
+static ssize_t i915_bigjoiner_enable_fops_write(struct file *file,
+ const char __user *ubuf,
+ size_t len, loff_t *offp)
+{
+ struct drm_connector *connector =
+ ((struct seq_file *)file->private_data)->private;
+ struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
+ struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
+ bool bigjoiner_en = 0;
+ int ret;
+
+ ret = kstrtobool_from_user(ubuf, len, &bigjoiner_en);
+ if (ret < 0)
+ return ret;
+
+ intel_dp->force_bigjoiner_enable = bigjoiner_en;
+ *offp += len;
+
+ return len;
+}
+
static int i915_dsc_output_format_open(struct inode *inode,
struct file *file)
{
return single_open(file, i915_dsc_output_format_show, inode->i_private);
}
+static int i915_bigjoiner_enable_open(struct inode *inode,
+ struct file *file)
+{
+ return single_open(file, i915_bigjoiner_enable_show, inode->i_private);
+}
+
static const struct file_operations i915_dsc_output_format_fops = {
.owner = THIS_MODULE,
.open = i915_dsc_output_format_open,
@@ -1434,6 +1485,15 @@ static const struct file_operations i915_dsc_output_format_fops = {
.write = i915_dsc_output_format_write
};
+static const struct file_operations i915_bigjoiner_enable_fops = {
+ .owner = THIS_MODULE,
+ .open = i915_bigjoiner_enable_open,
+ .read = seq_read,
+ .llseek = seq_lseek,
+ .release = single_release,
+ .write = i915_bigjoiner_enable_fops_write
+};
+
/*
* Returns the Current CRTC's bpc.
* Example usage: cat /sys/kernel/debug/dri/0/crtc-0/i915_current_bpc
@@ -1513,6 +1573,12 @@ void intel_connector_debugfs_add(struct intel_connector *intel_connector)
connector, &i915_dsc_output_format_fops);
}
+ if (DISPLAY_VER(dev_priv) >= 11 &&
+ intel_connector->base.connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
+ debugfs_create_file("i915_bigjoiner_force_enable", 0644, root,
+ &intel_connector->base, &i915_bigjoiner_enable_fops);
+ }
+
if (connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 8d8b2f8d37a9..e0de6eeaf59e 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1753,6 +1753,8 @@ struct intel_dp {
bool is_mst;
int active_mst_links;
+ bool force_bigjoiner_enable;
+
/* connector directly attached - won't be use for modeset in mst world */
struct intel_connector *attached_connector;
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 0ef7cb8134b6..daf9bc0d6838 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1153,7 +1153,11 @@ bool intel_dp_need_bigjoiner(struct intel_dp *intel_dp,
if (!intel_dp_can_bigjoiner(intel_dp))
return false;
- return clock > i915->max_dotclk_freq || hdisplay > 5120;
+ if (intel_dp->force_bigjoiner_enable)
+ drm_dbg_kms(&i915->drm, "Forcing bigjoiner mode\n");
+
+ return clock > i915->max_dotclk_freq || hdisplay > 5120 ||
+ intel_dp->force_bigjoiner_enable;
}
static enum drm_mode_status
--
2.37.3
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs
2023-10-12 12:34 [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs Stanislav Lisovskiy
@ 2023-10-12 14:59 ` Jani Nikula
2023-10-13 9:54 ` Lisovskiy, Stanislav
2023-10-12 17:42 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add bigjoiner force enable option to debugfs (rev3) Patchwork
` (3 subsequent siblings)
4 siblings, 1 reply; 18+ messages in thread
From: Jani Nikula @ 2023-10-12 14:59 UTC (permalink / raw)
To: Stanislav Lisovskiy, intel-gfx
On Thu, 12 Oct 2023, Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> wrote:
> For validation purposes, it might be useful to be able to
> force Bigjoiner mode, even if current dotclock/resolution
> do not require that.
> Lets add such to option to debugfs.
>
> v2: - Apparently intel_dp_need_bigjoiner can't be used, when
> debugfs entry is created so lets just check manually
> the DISPLAY_VER.
>
> v3: - Switch to intel_connector from drm_connector(Jani Nikula)
> - Remove redundant modeset lock(Jani Nikula)
> - Use kstrtobool_from_user for boolean value(Jani Nikula)
>
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> ---
> .../drm/i915/display/intel_display_debugfs.c | 72 ++++++++++++++++++-
> .../drm/i915/display/intel_display_types.h | 2 +
> drivers/gpu/drm/i915/display/intel_dp.c | 6 +-
> 3 files changed, 76 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index fbe75d47a165..dea7bbea83ba 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -1398,13 +1398,37 @@ out: drm_modeset_unlock(&dev->mode_config.connection_mutex);
> return ret;
> }
>
> +static int i915_bigjoiner_enable_show(struct seq_file *m, void *data)
> +{
> + struct intel_connector *connector = to_intel_connector(m->private);
> + struct drm_crtc *crtc;
> + struct intel_encoder *encoder = intel_attached_encoder(connector);
> + struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> + int ret;
> +
> + if (!encoder)
> + return -ENODEV;
> +
> + crtc = connector->base.state->crtc;
> + if (connector->base.status != connector_status_connected || !crtc) {
> + ret = -ENODEV;
> + goto out;
> + }
> +
> + seq_printf(m, "Bigjoiner enable: %d\n", intel_dp->force_bigjoiner_enable);
> +
> +out:
> +
> + return ret;
> +}
> +
> static ssize_t i915_dsc_output_format_write(struct file *file,
> const char __user *ubuf,
> size_t len, loff_t *offp)
> {
> - struct drm_connector *connector =
> - ((struct seq_file *)file->private_data)->private;
> - struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
> + struct seq_file *m = file->private_data;
> + struct intel_connector *connector = m->private;
> + struct intel_encoder *encoder = intel_attached_encoder(connector);
Ooops, I think you made those changes to the wrong function there. ;)
> struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> int dsc_output_format = 0;
> int ret;
> @@ -1419,12 +1443,39 @@ static ssize_t i915_dsc_output_format_write(struct file *file,
> return len;
> }
>
> +static ssize_t i915_bigjoiner_enable_fops_write(struct file *file,
> + const char __user *ubuf,
> + size_t len, loff_t *offp)
> +{
> + struct drm_connector *connector =
> + ((struct seq_file *)file->private_data)->private;
> + struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
Should be here.
> + struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> + bool bigjoiner_en = 0;
> + int ret;
> +
> + ret = kstrtobool_from_user(ubuf, len, &bigjoiner_en);
> + if (ret < 0)
> + return ret;
> +
> + intel_dp->force_bigjoiner_enable = bigjoiner_en;
> + *offp += len;
> +
> + return len;
> +}
> +
> static int i915_dsc_output_format_open(struct inode *inode,
> struct file *file)
> {
> return single_open(file, i915_dsc_output_format_show, inode->i_private);
> }
>
> +static int i915_bigjoiner_enable_open(struct inode *inode,
> + struct file *file)
> +{
> + return single_open(file, i915_bigjoiner_enable_show, inode->i_private);
> +}
> +
> static const struct file_operations i915_dsc_output_format_fops = {
> .owner = THIS_MODULE,
> .open = i915_dsc_output_format_open,
> @@ -1434,6 +1485,15 @@ static const struct file_operations i915_dsc_output_format_fops = {
> .write = i915_dsc_output_format_write
> };
>
> +static const struct file_operations i915_bigjoiner_enable_fops = {
> + .owner = THIS_MODULE,
> + .open = i915_bigjoiner_enable_open,
> + .read = seq_read,
> + .llseek = seq_lseek,
> + .release = single_release,
> + .write = i915_bigjoiner_enable_fops_write
> +};
> +
> /*
> * Returns the Current CRTC's bpc.
> * Example usage: cat /sys/kernel/debug/dri/0/crtc-0/i915_current_bpc
> @@ -1513,6 +1573,12 @@ void intel_connector_debugfs_add(struct intel_connector *intel_connector)
> connector, &i915_dsc_output_format_fops);
> }
>
> + if (DISPLAY_VER(dev_priv) >= 11 &&
> + intel_connector->base.connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
> + debugfs_create_file("i915_bigjoiner_force_enable", 0644, root,
> + &intel_connector->base, &i915_bigjoiner_enable_fops);
> + }
> +
> if (connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
> connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
> connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index 8d8b2f8d37a9..e0de6eeaf59e 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -1753,6 +1753,8 @@ struct intel_dp {
> bool is_mst;
> int active_mst_links;
>
> + bool force_bigjoiner_enable;
> +
> /* connector directly attached - won't be use for modeset in mst world */
> struct intel_connector *attached_connector;
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 0ef7cb8134b6..daf9bc0d6838 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -1153,7 +1153,11 @@ bool intel_dp_need_bigjoiner(struct intel_dp *intel_dp,
> if (!intel_dp_can_bigjoiner(intel_dp))
> return false;
>
> - return clock > i915->max_dotclk_freq || hdisplay > 5120;
> + if (intel_dp->force_bigjoiner_enable)
> + drm_dbg_kms(&i915->drm, "Forcing bigjoiner mode\n");
> +
> + return clock > i915->max_dotclk_freq || hdisplay > 5120 ||
> + intel_dp->force_bigjoiner_enable;
> }
>
> static enum drm_mode_status
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add bigjoiner force enable option to debugfs (rev3)
2023-10-12 12:34 [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs Stanislav Lisovskiy
2023-10-12 14:59 ` Jani Nikula
@ 2023-10-12 17:42 ` Patchwork
2023-10-12 17:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2023-10-12 17:42 UTC (permalink / raw)
To: Stanislav Lisovskiy; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Add bigjoiner force enable option to debugfs (rev3)
URL : https://patchwork.freedesktop.org/series/124730/
State : warning
== Summary ==
Error: dim checkpatch failed
e206f80af151 drm/i915: Add bigjoiner force enable option to debugfs
-:61: ERROR:CODE_INDENT: code indent should use tabs where possible
#61: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:1430:
+ struct intel_connector *connector = m->private;$
-:61: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#61: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:1430:
+ struct intel_connector *connector = m->private;$
total: 1 errors, 1 warnings, 0 checks, 126 lines checked
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add bigjoiner force enable option to debugfs (rev3)
2023-10-12 12:34 [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs Stanislav Lisovskiy
2023-10-12 14:59 ` Jani Nikula
2023-10-12 17:42 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add bigjoiner force enable option to debugfs (rev3) Patchwork
@ 2023-10-12 17:53 ` Patchwork
2023-10-13 16:58 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-10-17 9:49 ` [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs kernel test robot
4 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2023-10-12 17:53 UTC (permalink / raw)
To: Stanislav Lisovskiy; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5819 bytes --]
== Series Details ==
Series: drm/i915: Add bigjoiner force enable option to debugfs (rev3)
URL : https://patchwork.freedesktop.org/series/124730/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13747 -> Patchwork_124730v3
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/index.html
Participating hosts (38 -> 36)
------------------------------
Missing (2): fi-kbl-soraka fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_124730v3 that come from known issues:
### CI changes ###
#### Possible fixes ####
* boot:
- fi-hsw-4770: [FAIL][1] ([i915#8293]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/fi-hsw-4770/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/fi-hsw-4770/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@busy@all-engines:
- bat-mtlp-8: [PASS][3] -> [ABORT][4] ([i915#9414])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/bat-mtlp-8/igt@gem_busy@busy@all-engines.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/bat-mtlp-8/igt@gem_busy@busy@all-engines.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- fi-hsw-4770: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#5190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/fi-hsw-4770/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-vga-1:
- fi-hsw-4770: NOTRUN -> [SKIP][6] ([fdo#109271]) +12 other tests skip
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/fi-hsw-4770/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-vga-1.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-vga-1:
- fi-hsw-4770: NOTRUN -> [DMESG-WARN][7] ([i915#8841]) +6 other tests dmesg-warn
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/fi-hsw-4770/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-vga-1.html
* igt@kms_psr@sprite_plane_onoff:
- fi-hsw-4770: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#1072]) +3 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/fi-hsw-4770/igt@kms_psr@sprite_plane_onoff.html
#### Possible fixes ####
* igt@kms_chamelium_edid@hdmi-edid-read:
- {bat-dg2-13}: [DMESG-WARN][9] ([i915#7952]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/bat-dg2-13/igt@kms_chamelium_edid@hdmi-edid-read.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/bat-dg2-13/igt@kms_chamelium_edid@hdmi-edid-read.html
* igt@kms_chamelium_frames@dp-crc-fast:
- {bat-dg2-13}: [DMESG-WARN][11] ([Intel XE#485]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/bat-dg2-13/igt@kms_chamelium_frames@dp-crc-fast.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/bat-dg2-13/igt@kms_chamelium_frames@dp-crc-fast.html
* igt@kms_frontbuffer_tracking@basic:
- fi-bsw-nick: [FAIL][13] ([i915#9276]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/fi-bsw-nick/igt@kms_frontbuffer_tracking@basic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/fi-bsw-nick/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_hdmi_inject@inject-audio:
- fi-kbl-guc: [FAIL][15] ([IGT#3]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
- bat-rplp-1: [ABORT][17] ([i915#8668]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#3]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3
[Intel XE#485]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/485
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
[i915#7952]: https://gitlab.freedesktop.org/drm/intel/issues/7952
[i915#8293]: https://gitlab.freedesktop.org/drm/intel/issues/8293
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841
[i915#8981]: https://gitlab.freedesktop.org/drm/intel/issues/8981
[i915#9276]: https://gitlab.freedesktop.org/drm/intel/issues/9276
[i915#9414]: https://gitlab.freedesktop.org/drm/intel/issues/9414
Build changes
-------------
* Linux: CI_DRM_13747 -> Patchwork_124730v3
CI-20190529: 20190529
CI_DRM_13747: f2a4e63a6eed6e327d5c7ca4c343059625855349 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7533: 7533
Patchwork_124730v3: f2a4e63a6eed6e327d5c7ca4c343059625855349 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
4a86a29dfa97 drm/i915: Add bigjoiner force enable option to debugfs
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/index.html
[-- Attachment #2: Type: text/html, Size: 6695 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs
2023-10-12 14:59 ` Jani Nikula
@ 2023-10-13 9:54 ` Lisovskiy, Stanislav
0 siblings, 0 replies; 18+ messages in thread
From: Lisovskiy, Stanislav @ 2023-10-13 9:54 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Thu, Oct 12, 2023 at 05:59:18PM +0300, Jani Nikula wrote:
> On Thu, 12 Oct 2023, Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> wrote:
> > For validation purposes, it might be useful to be able to
> > force Bigjoiner mode, even if current dotclock/resolution
> > do not require that.
> > Lets add such to option to debugfs.
> >
> > v2: - Apparently intel_dp_need_bigjoiner can't be used, when
> > debugfs entry is created so lets just check manually
> > the DISPLAY_VER.
> >
> > v3: - Switch to intel_connector from drm_connector(Jani Nikula)
> > - Remove redundant modeset lock(Jani Nikula)
> > - Use kstrtobool_from_user for boolean value(Jani Nikula)
> >
> > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> > ---
> > .../drm/i915/display/intel_display_debugfs.c | 72 ++++++++++++++++++-
> > .../drm/i915/display/intel_display_types.h | 2 +
> > drivers/gpu/drm/i915/display/intel_dp.c | 6 +-
> > 3 files changed, 76 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > index fbe75d47a165..dea7bbea83ba 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > @@ -1398,13 +1398,37 @@ out: drm_modeset_unlock(&dev->mode_config.connection_mutex);
> > return ret;
> > }
> >
> > +static int i915_bigjoiner_enable_show(struct seq_file *m, void *data)
> > +{
> > + struct intel_connector *connector = to_intel_connector(m->private);
> > + struct drm_crtc *crtc;
> > + struct intel_encoder *encoder = intel_attached_encoder(connector);
> > + struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> > + int ret;
> > +
> > + if (!encoder)
> > + return -ENODEV;
> > +
> > + crtc = connector->base.state->crtc;
> > + if (connector->base.status != connector_status_connected || !crtc) {
> > + ret = -ENODEV;
> > + goto out;
> > + }
> > +
> > + seq_printf(m, "Bigjoiner enable: %d\n", intel_dp->force_bigjoiner_enable);
> > +
> > +out:
> > +
> > + return ret;
> > +}
> > +
> > static ssize_t i915_dsc_output_format_write(struct file *file,
> > const char __user *ubuf,
> > size_t len, loff_t *offp)
> > {
> > - struct drm_connector *connector =
> > - ((struct seq_file *)file->private_data)->private;
> > - struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
> > + struct seq_file *m = file->private_data;
> > + struct intel_connector *connector = m->private;
> > + struct intel_encoder *encoder = intel_attached_encoder(connector);
>
> Ooops, I think you made those changes to the wrong function there. ;)
Ouch, they looked exactly identical! I would say this could have been changed too,
but not in that patch indeed :)))
Thanks for spotting..probably really time to think about starting using glasses.
>
> > struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> > int dsc_output_format = 0;
> > int ret;
> > @@ -1419,12 +1443,39 @@ static ssize_t i915_dsc_output_format_write(struct file *file,
> > return len;
> > }
> >
> > +static ssize_t i915_bigjoiner_enable_fops_write(struct file *file,
> > + const char __user *ubuf,
> > + size_t len, loff_t *offp)
> > +{
> > + struct drm_connector *connector =
> > + ((struct seq_file *)file->private_data)->private;
> > + struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
>
> Should be here.
>
> > + struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> > + bool bigjoiner_en = 0;
> > + int ret;
> > +
> > + ret = kstrtobool_from_user(ubuf, len, &bigjoiner_en);
> > + if (ret < 0)
> > + return ret;
> > +
> > + intel_dp->force_bigjoiner_enable = bigjoiner_en;
> > + *offp += len;
> > +
> > + return len;
> > +}
> > +
> > static int i915_dsc_output_format_open(struct inode *inode,
> > struct file *file)
> > {
> > return single_open(file, i915_dsc_output_format_show, inode->i_private);
> > }
> >
> > +static int i915_bigjoiner_enable_open(struct inode *inode,
> > + struct file *file)
> > +{
> > + return single_open(file, i915_bigjoiner_enable_show, inode->i_private);
> > +}
> > +
> > static const struct file_operations i915_dsc_output_format_fops = {
> > .owner = THIS_MODULE,
> > .open = i915_dsc_output_format_open,
> > @@ -1434,6 +1485,15 @@ static const struct file_operations i915_dsc_output_format_fops = {
> > .write = i915_dsc_output_format_write
> > };
> >
> > +static const struct file_operations i915_bigjoiner_enable_fops = {
> > + .owner = THIS_MODULE,
> > + .open = i915_bigjoiner_enable_open,
> > + .read = seq_read,
> > + .llseek = seq_lseek,
> > + .release = single_release,
> > + .write = i915_bigjoiner_enable_fops_write
> > +};
> > +
> > /*
> > * Returns the Current CRTC's bpc.
> > * Example usage: cat /sys/kernel/debug/dri/0/crtc-0/i915_current_bpc
> > @@ -1513,6 +1573,12 @@ void intel_connector_debugfs_add(struct intel_connector *intel_connector)
> > connector, &i915_dsc_output_format_fops);
> > }
> >
> > + if (DISPLAY_VER(dev_priv) >= 11 &&
> > + intel_connector->base.connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
> > + debugfs_create_file("i915_bigjoiner_force_enable", 0644, root,
> > + &intel_connector->base, &i915_bigjoiner_enable_fops);
> > + }
> > +
> > if (connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
> > connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
> > connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> > index 8d8b2f8d37a9..e0de6eeaf59e 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> > @@ -1753,6 +1753,8 @@ struct intel_dp {
> > bool is_mst;
> > int active_mst_links;
> >
> > + bool force_bigjoiner_enable;
> > +
> > /* connector directly attached - won't be use for modeset in mst world */
> > struct intel_connector *attached_connector;
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> > index 0ef7cb8134b6..daf9bc0d6838 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -1153,7 +1153,11 @@ bool intel_dp_need_bigjoiner(struct intel_dp *intel_dp,
> > if (!intel_dp_can_bigjoiner(intel_dp))
> > return false;
> >
> > - return clock > i915->max_dotclk_freq || hdisplay > 5120;
> > + if (intel_dp->force_bigjoiner_enable)
> > + drm_dbg_kms(&i915->drm, "Forcing bigjoiner mode\n");
> > +
> > + return clock > i915->max_dotclk_freq || hdisplay > 5120 ||
> > + intel_dp->force_bigjoiner_enable;
> > }
> >
> > static enum drm_mode_status
>
> --
> Jani Nikula, Intel
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add bigjoiner force enable option to debugfs (rev3)
2023-10-12 12:34 [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs Stanislav Lisovskiy
` (2 preceding siblings ...)
2023-10-12 17:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2023-10-13 16:58 ` Patchwork
2023-10-17 9:49 ` [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs kernel test robot
4 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2023-10-13 16:58 UTC (permalink / raw)
To: Lisovskiy, Stanislav; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 62116 bytes --]
== Series Details ==
Series: drm/i915: Add bigjoiner force enable option to debugfs (rev3)
URL : https://patchwork.freedesktop.org/series/124730/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13747_full -> Patchwork_124730v3_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_124730v3_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_124730v3_full, please notify your bug team (lgci.bug.filing@intel.com) to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (9 -> 9)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_124730v3_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_module_load@reload-with-fault-injection:
- shard-snb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-snb7/igt@i915_module_load@reload-with-fault-injection.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-snb6/igt@i915_module_load@reload-with-fault-injection.html
* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-apl: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-apl7/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html
* igt@kms_rotation_crc@primary-y-tiled-reflect-x-90:
- shard-rkl: NOTRUN -> [INCOMPLETE][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-rkl-1/igt@kms_rotation_crc@primary-y-tiled-reflect-x-90.html
Known issues
------------
Here are the changes found in Patchwork_124730v3_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-glk: ([PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29]) -> ([PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [FAIL][41], [PASS][42], [FAIL][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53]) ([i915#8293])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk9/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk9/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk9/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk8/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk8/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk8/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk7/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk7/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk6/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk6/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk5/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk5/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk5/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk4/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk4/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk4/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk3/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk3/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk3/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk2/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk2/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk2/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk1/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk1/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk1/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk2/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk2/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk3/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk3/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk3/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk4/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk4/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk4/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk5/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk5/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk6/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk6/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk7/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk7/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk8/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk8/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk8/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk9/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk9/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk9/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk1/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk1/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk1/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk2/boot.html
### IGT changes ###
#### Issues hit ####
* igt@api_intel_bb@render-ccs:
- shard-dg2: NOTRUN -> [FAIL][54] ([i915#6122])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-10/igt@api_intel_bb@render-ccs.html
* igt@drm_fdinfo@busy-idle@bcs0:
- shard-dg2: NOTRUN -> [SKIP][55] ([i915#8414]) +10 other tests skip
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@drm_fdinfo@busy-idle@bcs0.html
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-rkl: [PASS][56] -> [FAIL][57] ([i915#6268])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-rkl-6/igt@gem_ctx_exec@basic-nohangcheck.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-rkl-1/igt@gem_ctx_exec@basic-nohangcheck.html
- shard-tglu: [PASS][58] -> [FAIL][59] ([i915#6268])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-tglu-4/igt@gem_ctx_exec@basic-nohangcheck.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-tglu-5/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-dg2: [PASS][60] -> [FAIL][61] ([fdo#103375])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-dg2-7/igt@gem_ctx_isolation@preservation-s3@vcs0.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-11/igt@gem_ctx_isolation@preservation-s3@vcs0.html
* igt@gem_ctx_persistence@hang:
- shard-mtlp: NOTRUN -> [SKIP][62] ([i915#8555]) +1 other test skip
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-8/igt@gem_ctx_persistence@hang.html
* igt@gem_ctx_persistence@heartbeat-stop:
- shard-dg2: NOTRUN -> [SKIP][63] ([i915#8555]) +1 other test skip
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@gem_ctx_persistence@heartbeat-stop.html
* igt@gem_ctx_persistence@processes:
- shard-snb: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#1099]) +1 other test skip
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-snb4/igt@gem_ctx_persistence@processes.html
* igt@gem_ctx_sseu@invalid-sseu:
- shard-dg2: NOTRUN -> [SKIP][65] ([i915#280])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@gem_ctx_sseu@invalid-sseu.html
* igt@gem_eio@hibernate:
- shard-dg1: [PASS][66] -> [ABORT][67] ([i915#7975] / [i915#8213])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-dg1-12/igt@gem_eio@hibernate.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg1-14/igt@gem_eio@hibernate.html
* igt@gem_eio@reset-stress:
- shard-dg1: [PASS][68] -> [FAIL][69] ([i915#5784])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-dg1-12/igt@gem_eio@reset-stress.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg1-13/igt@gem_eio@reset-stress.html
* igt@gem_exec_fair@basic-pace-share:
- shard-mtlp: NOTRUN -> [SKIP][70] ([i915#4473] / [i915#4771])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-8/igt@gem_exec_fair@basic-pace-share.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [PASS][71] -> [FAIL][72] ([i915#2842])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-apl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-apl6/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-rkl: [PASS][73] -> [FAIL][74] ([i915#2842]) +1 other test fail
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-rkl-7/igt@gem_exec_fair@basic-pace@rcs0.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-rkl-7/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-sync:
- shard-dg2: NOTRUN -> [SKIP][75] ([i915#3539])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-11/igt@gem_exec_fair@basic-sync.html
* igt@gem_exec_flush@basic-uc-ro-default:
- shard-dg2: NOTRUN -> [SKIP][76] ([i915#3539] / [i915#4852]) +4 other tests skip
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-11/igt@gem_exec_flush@basic-uc-ro-default.html
* igt@gem_exec_reloc@basic-gtt-cpu-active:
- shard-dg2: NOTRUN -> [SKIP][77] ([i915#3281]) +6 other tests skip
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@gem_exec_reloc@basic-gtt-cpu-active.html
* igt@gem_exec_reloc@basic-write-read:
- shard-mtlp: NOTRUN -> [SKIP][78] ([i915#3281]) +4 other tests skip
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-6/igt@gem_exec_reloc@basic-write-read.html
* igt@gem_exec_schedule@noreorder-priority@rcs0:
- shard-mtlp: [PASS][79] -> [DMESG-WARN][80] ([i915#8962]) +1 other test dmesg-warn
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-mtlp-5/igt@gem_exec_schedule@noreorder-priority@rcs0.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-4/igt@gem_exec_schedule@noreorder-priority@rcs0.html
* igt@gem_exec_schedule@preempt-queue-chain:
- shard-mtlp: NOTRUN -> [SKIP][81] ([i915#4537] / [i915#4812])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-6/igt@gem_exec_schedule@preempt-queue-chain.html
* igt@gem_exec_suspend@basic-s4-devices@smem:
- shard-tglu: [PASS][82] -> [ABORT][83] ([i915#7975] / [i915#8213])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-tglu-6/igt@gem_exec_suspend@basic-s4-devices@smem.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-tglu-10/igt@gem_exec_suspend@basic-s4-devices@smem.html
* igt@gem_fenced_exec_thrash@no-spare-fences:
- shard-dg2: NOTRUN -> [SKIP][84] ([i915#4860])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@gem_fenced_exec_thrash@no-spare-fences.html
* igt@gem_lmem_swapping@verify-random:
- shard-mtlp: NOTRUN -> [SKIP][85] ([i915#4613])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-1/igt@gem_lmem_swapping@verify-random.html
* igt@gem_mmap_gtt@cpuset-big-copy-odd:
- shard-dg2: NOTRUN -> [SKIP][86] ([i915#4077]) +7 other tests skip
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-10/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
* igt@gem_mmap_gtt@hang-busy:
- shard-mtlp: NOTRUN -> [SKIP][87] ([i915#4077]) +2 other tests skip
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-6/igt@gem_mmap_gtt@hang-busy.html
* igt@gem_mmap_wc@copy:
- shard-dg2: NOTRUN -> [SKIP][88] ([i915#4083]) +6 other tests skip
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@gem_mmap_wc@copy.html
* igt@gem_mmap_wc@write-cpu-read-wc-unflushed:
- shard-mtlp: NOTRUN -> [SKIP][89] ([i915#4083]) +1 other test skip
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-6/igt@gem_mmap_wc@write-cpu-read-wc-unflushed.html
* igt@gem_partial_pwrite_pread@reads-uncached:
- shard-dg2: NOTRUN -> [SKIP][90] ([i915#3282]) +5 other tests skip
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@gem_partial_pwrite_pread@reads-uncached.html
* igt@gem_pxp@create-regular-context-2:
- shard-dg2: NOTRUN -> [SKIP][91] ([i915#4270]) +2 other tests skip
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-10/igt@gem_pxp@create-regular-context-2.html
* igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
- shard-snb: NOTRUN -> [SKIP][92] ([fdo#109271]) +104 other tests skip
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-snb4/igt@gem_render_copy@x-tiled-to-vebox-yf-tiled.html
* igt@gem_render_copy@y-tiled-to-vebox-linear:
- shard-mtlp: NOTRUN -> [SKIP][93] ([i915#8428])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-6/igt@gem_render_copy@y-tiled-to-vebox-linear.html
* igt@gem_set_tiling_vs_blt@untiled-to-tiled:
- shard-dg2: NOTRUN -> [SKIP][94] ([i915#4079]) +1 other test skip
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@gem_set_tiling_vs_blt@untiled-to-tiled.html
* igt@gem_spin_batch@user-each:
- shard-mtlp: [PASS][95] -> [DMESG-FAIL][96] ([i915#8962])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-mtlp-5/igt@gem_spin_batch@user-each.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-4/igt@gem_spin_batch@user-each.html
* igt@gem_userptr_blits@forbidden-operations:
- shard-mtlp: NOTRUN -> [SKIP][97] ([i915#3282])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-1/igt@gem_userptr_blits@forbidden-operations.html
* igt@gem_userptr_blits@readonly-unsync:
- shard-rkl: NOTRUN -> [SKIP][98] ([i915#3297])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-rkl-1/igt@gem_userptr_blits@readonly-unsync.html
* igt@gen9_exec_parse@allowed-single:
- shard-dg2: NOTRUN -> [SKIP][99] ([i915#2856]) +3 other tests skip
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@gen9_exec_parse@allowed-single.html
* igt@i915_fb_tiling:
- shard-mtlp: NOTRUN -> [SKIP][100] ([i915#4881])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-8/igt@i915_fb_tiling.html
- shard-dg2: NOTRUN -> [SKIP][101] ([i915#4881])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-10/igt@i915_fb_tiling.html
* igt@i915_pm_rps@thresholds-park@gt0:
- shard-dg2: NOTRUN -> [SKIP][102] ([i915#8925])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-11/igt@i915_pm_rps@thresholds-park@gt0.html
* igt@i915_pm_rps@thresholds@gt0:
- shard-mtlp: NOTRUN -> [SKIP][103] ([i915#8925])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-6/igt@i915_pm_rps@thresholds@gt0.html
* igt@i915_pm_rps@thresholds@gt1:
- shard-mtlp: NOTRUN -> [SKIP][104] ([i915#3555] / [i915#8925])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-6/igt@i915_pm_rps@thresholds@gt1.html
* igt@i915_selftest@mock@memory_region:
- shard-dg2: NOTRUN -> [DMESG-WARN][105] ([i915#9311])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@i915_selftest@mock@memory_region.html
* igt@kms_addfb_basic@framebuffer-vs-set-tiling:
- shard-dg2: NOTRUN -> [SKIP][106] ([i915#4212])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-11/igt@kms_addfb_basic@framebuffer-vs-set-tiling.html
* igt@kms_addfb_basic@tile-pitch-mismatch:
- shard-dg2: NOTRUN -> [SKIP][107] ([i915#4212] / [i915#5608])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-11/igt@kms_addfb_basic@tile-pitch-mismatch.html
* igt@kms_async_flips@test-cursor:
- shard-mtlp: NOTRUN -> [SKIP][108] ([i915#6229])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-5/igt@kms_async_flips@test-cursor.html
* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
- shard-dg2: NOTRUN -> [SKIP][109] ([i915#1769] / [i915#3555])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html
* igt@kms_big_fb@4-tiled-32bpp-rotate-270:
- shard-dg2: NOTRUN -> [SKIP][110] ([fdo#111614]) +4 other tests skip
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-10/igt@kms_big_fb@4-tiled-32bpp-rotate-270.html
* igt@kms_big_fb@linear-64bpp-rotate-90:
- shard-mtlp: NOTRUN -> [SKIP][111] ([fdo#111614]) +1 other test skip
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-6/igt@kms_big_fb@linear-64bpp-rotate-90.html
* igt@kms_big_fb@y-tiled-8bpp-rotate-180:
- shard-dg2: NOTRUN -> [SKIP][112] ([i915#5190]) +12 other tests skip
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-11/igt@kms_big_fb@y-tiled-8bpp-rotate-180.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-mtlp: NOTRUN -> [SKIP][113] ([fdo#111615]) +4 other tests skip
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-8/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_big_fb@yf-tiled-16bpp-rotate-0:
- shard-tglu: NOTRUN -> [SKIP][114] ([fdo#111615])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-tglu-7/igt@kms_big_fb@yf-tiled-16bpp-rotate-0.html
* igt@kms_big_fb@yf-tiled-16bpp-rotate-90:
- shard-dg2: NOTRUN -> [SKIP][115] ([i915#4538] / [i915#5190]) +4 other tests skip
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@kms_big_fb@yf-tiled-16bpp-rotate-90.html
* igt@kms_cdclk@mode-transition@pipe-d-dp-4:
- shard-dg2: NOTRUN -> [SKIP][116] ([i915#4087] / [i915#7213]) +3 other tests skip
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-11/igt@kms_cdclk@mode-transition@pipe-d-dp-4.html
* igt@kms_cdclk@plane-scaling@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][117] ([i915#4087]) +3 other tests skip
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-10/igt@kms_cdclk@plane-scaling@pipe-d-hdmi-a-1.html
* igt@kms_chamelium_audio@hdmi-audio-edid:
- shard-mtlp: NOTRUN -> [SKIP][118] ([i915#7828]) +2 other tests skip
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-6/igt@kms_chamelium_audio@hdmi-audio-edid.html
* igt@kms_chamelium_color@ctm-max:
- shard-dg2: NOTRUN -> [SKIP][119] ([fdo#111827]) +1 other test skip
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@kms_chamelium_color@ctm-max.html
* igt@kms_chamelium_edid@hdmi-edid-change-during-suspend:
- shard-rkl: NOTRUN -> [SKIP][120] ([i915#7828])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-rkl-1/igt@kms_chamelium_edid@hdmi-edid-change-during-suspend.html
* igt@kms_chamelium_hpd@hdmi-hpd-fast:
- shard-tglu: NOTRUN -> [SKIP][121] ([i915#7828])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-tglu-7/igt@kms_chamelium_hpd@hdmi-hpd-fast.html
* igt@kms_chamelium_hpd@hdmi-hpd-storm:
- shard-dg2: NOTRUN -> [SKIP][122] ([i915#7828]) +7 other tests skip
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@kms_chamelium_hpd@hdmi-hpd-storm.html
* igt@kms_content_protection@dp-mst-lic-type-0:
- shard-dg2: NOTRUN -> [SKIP][123] ([i915#3299])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-11/igt@kms_content_protection@dp-mst-lic-type-0.html
* igt@kms_content_protection@legacy@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [TIMEOUT][124] ([i915#7173]) +1 other test timeout
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-11/igt@kms_content_protection@legacy@pipe-a-dp-4.html
* igt@kms_cursor_crc@cursor-offscreen-512x170:
- shard-mtlp: NOTRUN -> [SKIP][125] ([i915#3359]) +1 other test skip
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-6/igt@kms_cursor_crc@cursor-offscreen-512x170.html
* igt@kms_cursor_crc@cursor-offscreen-max-size:
- shard-mtlp: NOTRUN -> [SKIP][126] ([i915#3555] / [i915#8814])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-5/igt@kms_cursor_crc@cursor-offscreen-max-size.html
* igt@kms_cursor_crc@cursor-rapid-movement-32x32:
- shard-dg2: NOTRUN -> [SKIP][127] ([i915#3555]) +5 other tests skip
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-10/igt@kms_cursor_crc@cursor-rapid-movement-32x32.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-atomic:
- shard-mtlp: NOTRUN -> [SKIP][128] ([i915#3546])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-6/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic.html
* igt@kms_cursor_legacy@cursorb-vs-flipb-legacy:
- shard-dg2: NOTRUN -> [SKIP][129] ([fdo#109274] / [i915#5354]) +3 other tests skip
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@kms_cursor_legacy@cursorb-vs-flipb-legacy.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [PASS][130] -> [FAIL][131] ([i915#2346])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size:
- shard-rkl: NOTRUN -> [SKIP][132] ([i915#4103])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-rkl-1/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle:
- shard-dg2: NOTRUN -> [SKIP][133] ([i915#4103] / [i915#4213])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle.html
* igt@kms_cursor_legacy@single-bo@all-pipes:
- shard-mtlp: [PASS][134] -> [DMESG-WARN][135] ([i915#2017]) +1 other test dmesg-warn
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-mtlp-5/igt@kms_cursor_legacy@single-bo@all-pipes.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-4/igt@kms_cursor_legacy@single-bo@all-pipes.html
* igt@kms_dsc@dsc-with-bpc-formats:
- shard-mtlp: NOTRUN -> [SKIP][136] ([i915#3555] / [i915#3840])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-6/igt@kms_dsc@dsc-with-bpc-formats.html
* igt@kms_dsc@dsc-with-output-formats:
- shard-rkl: NOTRUN -> [SKIP][137] ([i915#3555] / [i915#3840])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-rkl-1/igt@kms_dsc@dsc-with-output-formats.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-dg2: [PASS][138] -> [INCOMPLETE][139] ([i915#8912])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-dg2-2/igt@kms_fbcon_fbt@fbc-suspend.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-flip-vs-fences:
- shard-dg2: NOTRUN -> [SKIP][140] ([i915#8381]) +1 other test skip
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-10/igt@kms_flip@2x-flip-vs-fences.html
- shard-mtlp: NOTRUN -> [SKIP][141] ([i915#8381])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-8/igt@kms_flip@2x-flip-vs-fences.html
* igt@kms_flip@2x-nonexisting-fb-interruptible:
- shard-dg2: NOTRUN -> [SKIP][142] ([fdo#109274]) +4 other tests skip
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@kms_flip@2x-nonexisting-fb-interruptible.html
* igt@kms_flip@2x-plain-flip-ts-check-interruptible:
- shard-tglu: NOTRUN -> [SKIP][143] ([fdo#109274] / [i915#3637])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-tglu-7/igt@kms_flip@2x-plain-flip-ts-check-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-hdmi-a1:
- shard-snb: NOTRUN -> [DMESG-WARN][144] ([i915#8841]) +1 other test dmesg-warn
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-snb1/igt@kms_flip@flip-vs-suspend-interruptible@b-hdmi-a1.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling@pipe-a-valid-mode:
- shard-dg2: NOTRUN -> [SKIP][145] ([i915#2672]) +3 other tests skip
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][146] ([i915#2672])
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling@pipe-a-valid-mode:
- shard-tglu: NOTRUN -> [SKIP][147] ([i915#2587] / [i915#2672])
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-tglu-7/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][148] ([i915#3555] / [i915#8810])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-8/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode.html
* igt@kms_force_connector_basic@force-load-detect:
- shard-dg2: NOTRUN -> [SKIP][149] ([fdo#109285])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-10/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_force_connector_basic@prune-stale-modes:
- shard-dg2: NOTRUN -> [SKIP][150] ([i915#5274])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-gtt:
- shard-mtlp: NOTRUN -> [SKIP][151] ([i915#8708]) +4 other tests skip
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
- shard-dg2: NOTRUN -> [FAIL][152] ([i915#6880])
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-11/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html
* igt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw:
- shard-dg2: NOTRUN -> [SKIP][153] ([i915#5354]) +24 other tests skip
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-10/igt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-cpu:
- shard-tglu: NOTRUN -> [SKIP][154] ([fdo#110189]) +3 other tests skip
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-tglu-7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-dg2: NOTRUN -> [SKIP][155] ([i915#8708]) +17 other tests skip
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-10/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-shrfb-pgflip-blt:
- shard-tglu: NOTRUN -> [SKIP][156] ([fdo#109280]) +2 other tests skip
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-tglu-7/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-shrfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-pwrite:
- shard-mtlp: NOTRUN -> [SKIP][157] ([i915#1825]) +6 other tests skip
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-8/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt:
- shard-dg2: NOTRUN -> [SKIP][158] ([i915#3458]) +12 other tests skip
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-10/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-blt:
- shard-rkl: NOTRUN -> [SKIP][159] ([fdo#111825] / [i915#1825]) +2 other tests skip
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-rkl-1/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-blt.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-dg2: NOTRUN -> [SKIP][160] ([i915#3555] / [i915#8228]) +1 other test skip
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_panel_fitting@atomic-fastset:
- shard-dg2: NOTRUN -> [SKIP][161] ([i915#6301])
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@kms_panel_fitting@atomic-fastset.html
* igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes:
- shard-dg2: NOTRUN -> [SKIP][162] ([fdo#109289]) +3 other tests skip
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-11/igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes.html
* igt@kms_pipe_b_c_ivb@pipe-b-dpms-off-modeset-pipe-c:
- shard-mtlp: NOTRUN -> [SKIP][163] ([fdo#109289])
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-8/igt@kms_pipe_b_c_ivb@pipe-b-dpms-off-modeset-pipe-c.html
* igt@kms_plane_lowres@tiling-none@pipe-b-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][164] ([i915#3582]) +3 other tests skip
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-5/igt@kms_plane_lowres@tiling-none@pipe-b-edp-1.html
* igt@kms_plane_multiple@tiling-yf:
- shard-dg2: NOTRUN -> [SKIP][165] ([i915#3555] / [i915#8806])
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@kms_plane_multiple@tiling-yf.html
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [FAIL][166] ([i915#8292])
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-rkl-7/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-1.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][167] ([i915#5176] / [i915#9423]) +1 other test skip
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-rkl-2/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-b-hdmi-a-2.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][168] ([i915#5235]) +1 other test skip
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-rkl-7/igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-d-dp-4:
- shard-dg2: NOTRUN -> [SKIP][169] ([i915#5235]) +7 other tests skip
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-11/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-d-dp-4.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-d-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][170] ([i915#5235]) +7 other tests skip
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg1-14/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-d-hdmi-a-4.html
* igt@kms_prime@basic-crc-hybrid:
- shard-dg2: NOTRUN -> [SKIP][171] ([i915#6524] / [i915#6805]) +1 other test skip
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-10/igt@kms_prime@basic-crc-hybrid.html
- shard-mtlp: NOTRUN -> [SKIP][172] ([i915#6524])
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-8/igt@kms_prime@basic-crc-hybrid.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-dg2: NOTRUN -> [SKIP][173] ([i915#658]) +1 other test skip
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
- shard-tglu: NOTRUN -> [SKIP][174] ([i915#658])
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-tglu-7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html
* igt@kms_psr2_su@page_flip-p010:
- shard-apl: NOTRUN -> [SKIP][175] ([fdo#109271] / [i915#658])
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-apl7/igt@kms_psr2_su@page_flip-p010.html
* igt@kms_psr@primary_page_flip:
- shard-apl: NOTRUN -> [SKIP][176] ([fdo#109271]) +42 other tests skip
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-apl7/igt@kms_psr@primary_page_flip.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-dg2: NOTRUN -> [SKIP][177] ([i915#1072]) +4 other tests skip
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-dg2: NOTRUN -> [SKIP][178] ([i915#5461] / [i915#658])
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-11/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180:
- shard-mtlp: NOTRUN -> [SKIP][179] ([i915#5289]) +1 other test skip
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-6/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180.html
* igt@kms_setmode@invalid-clone-single-crtc:
- shard-dg2: NOTRUN -> [SKIP][180] ([i915#3555] / [i915#4098]) +1 other test skip
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@kms_setmode@invalid-clone-single-crtc.html
* igt@kms_tiled_display@basic-test-pattern:
- shard-dg2: NOTRUN -> [SKIP][181] ([i915#8623])
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-10/igt@kms_tiled_display@basic-test-pattern.html
* igt@kms_tv_load_detect@load-detect:
- shard-dg2: NOTRUN -> [SKIP][182] ([fdo#109309])
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@kms_tv_load_detect@load-detect.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [FAIL][183] ([i915#9196]) +1 other test fail
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-rkl-7/igt@kms_universal_plane@cursor-fb-leak@pipe-a-hdmi-a-1.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-c-hdmi-a-1:
- shard-tglu: [PASS][184] -> [FAIL][185] ([i915#9196]) +1 other test fail
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-tglu-3/igt@kms_universal_plane@cursor-fb-leak@pipe-c-hdmi-a-1.html
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-tglu-9/igt@kms_universal_plane@cursor-fb-leak@pipe-c-hdmi-a-1.html
* igt@kms_writeback@writeback-fb-id:
- shard-dg2: NOTRUN -> [SKIP][186] ([i915#2437]) +1 other test skip
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-11/igt@kms_writeback@writeback-fb-id.html
* igt@perf@global-sseu-config:
- shard-dg2: NOTRUN -> [SKIP][187] ([i915#7387])
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-10/igt@perf@global-sseu-config.html
* igt@perf@global-sseu-config-invalid:
- shard-mtlp: NOTRUN -> [SKIP][188] ([i915#7387]) +1 other test skip
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-1/igt@perf@global-sseu-config-invalid.html
* igt@perf_pmu@busy-double-start@ccs0:
- shard-mtlp: [PASS][189] -> [FAIL][190] ([i915#4349])
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-mtlp-6/igt@perf_pmu@busy-double-start@ccs0.html
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-7/igt@perf_pmu@busy-double-start@ccs0.html
* igt@perf_pmu@cpu-hotplug:
- shard-dg2: NOTRUN -> [SKIP][191] ([i915#8850])
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@perf_pmu@cpu-hotplug.html
* igt@perf_pmu@event-wait@rcs0:
- shard-dg2: NOTRUN -> [SKIP][192] ([fdo#112283])
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@perf_pmu@event-wait@rcs0.html
* igt@perf_pmu@frequency@gt0:
- shard-dg2: NOTRUN -> [FAIL][193] ([i915#6806])
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@perf_pmu@frequency@gt0.html
* igt@syncobj_timeline@wait-for-submit-delayed-submit:
- shard-dg1: [PASS][194] -> [DMESG-WARN][195] ([i915#1982]) +1 other test dmesg-warn
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-dg1-15/igt@syncobj_timeline@wait-for-submit-delayed-submit.html
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg1-16/igt@syncobj_timeline@wait-for-submit-delayed-submit.html
* igt@tools_test@sysfs_l3_parity:
- shard-mtlp: NOTRUN -> [SKIP][196] ([i915#4818])
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-6/igt@tools_test@sysfs_l3_parity.html
* igt@v3d/v3d_get_param@get-bad-flags:
- shard-tglu: NOTRUN -> [SKIP][197] ([fdo#109315] / [i915#2575]) +1 other test skip
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-tglu-7/igt@v3d/v3d_get_param@get-bad-flags.html
* igt@v3d/v3d_perfmon@destroy-valid-perfmon:
- shard-mtlp: NOTRUN -> [SKIP][198] ([i915#2575]) +3 other tests skip
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-5/igt@v3d/v3d_perfmon@destroy-valid-perfmon.html
* igt@v3d/v3d_submit_cl@single-in-sync:
- shard-rkl: NOTRUN -> [SKIP][199] ([fdo#109315])
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-rkl-1/igt@v3d/v3d_submit_cl@single-in-sync.html
* igt@v3d/v3d_submit_csd@single-out-sync:
- shard-dg2: NOTRUN -> [SKIP][200] ([i915#2575]) +10 other tests skip
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-11/igt@v3d/v3d_submit_csd@single-out-sync.html
* igt@vc4/vc4_label_bo@set-bad-name:
- shard-tglu: NOTRUN -> [SKIP][201] ([i915#2575])
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-tglu-7/igt@vc4/vc4_label_bo@set-bad-name.html
* igt@vc4/vc4_purgeable_bo@access-purged-bo-mem:
- shard-mtlp: NOTRUN -> [SKIP][202] ([i915#7711]) +2 other tests skip
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-6/igt@vc4/vc4_purgeable_bo@access-purged-bo-mem.html
* igt@vc4/vc4_tiling@get-bad-handle:
- shard-dg2: NOTRUN -> [SKIP][203] ([i915#7711]) +7 other tests skip
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-11/igt@vc4/vc4_tiling@get-bad-handle.html
#### Possible fixes ####
* igt@gem_eio@hibernate:
- shard-tglu: [ABORT][204] ([i915#7975] / [i915#8213] / [i915#8398]) -> [PASS][205]
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-tglu-10/igt@gem_eio@hibernate.html
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-tglu-7/igt@gem_eio@hibernate.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][206] ([i915#2842]) -> [PASS][207]
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-rkl: [FAIL][208] ([i915#2842]) -> [PASS][209]
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-rkl-4/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-rkl-1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fence@parallel@vcs0:
- shard-mtlp: [DMESG-FAIL][210] ([i915#8962]) -> [PASS][211] +2 other tests pass
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-mtlp-4/igt@gem_exec_fence@parallel@vcs0.html
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-2/igt@gem_exec_fence@parallel@vcs0.html
* igt@gem_exec_fence@parallel@vecs0:
- shard-mtlp: [FAIL][212] ([i915#8957]) -> [PASS][213] +2 other tests pass
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-mtlp-4/igt@gem_exec_fence@parallel@vecs0.html
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-2/igt@gem_exec_fence@parallel@vecs0.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- shard-dg2: [TIMEOUT][214] ([i915#5493]) -> [PASS][215]
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-dg2-7/igt@gem_lmem_swapping@smem-oom@lmem0.html
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-11/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-mtlp: [ABORT][216] ([i915#8489] / [i915#8668]) -> [PASS][217]
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-mtlp-1/igt@i915_module_load@reload-with-fault-injection.html
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-6/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rps@reset:
- shard-snb: [INCOMPLETE][218] ([i915#7790]) -> [PASS][219]
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-snb1/igt@i915_pm_rps@reset.html
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-snb4/igt@i915_pm_rps@reset.html
* igt@kms_big_fb@4-tiled-64bpp-rotate-180:
- shard-mtlp: [FAIL][220] ([i915#5138]) -> [PASS][221]
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-mtlp-3/igt@kms_big_fb@4-tiled-64bpp-rotate-180.html
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-8/igt@kms_big_fb@4-tiled-64bpp-rotate-180.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-tglu: [FAIL][222] ([i915#3743]) -> [PASS][223] +1 other test pass
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-tglu-2/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-tglu-10/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic:
- shard-snb: [ABORT][224] -> [PASS][225]
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-snb6/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html
[225]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-snb4/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][226] ([i915#2346]) -> [PASS][227]
[226]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[227]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-glk4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-move:
- shard-mtlp: [FAIL][228] -> [PASS][229]
[228]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-mtlp-2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-move.html
[229]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-move.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-dp-1:
- shard-apl: [INCOMPLETE][230] ([i915#9392]) -> [PASS][231]
[230]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-apl1/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-dp-1.html
[231]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-apl7/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-dp-1.html
* {igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait}:
- shard-dg2: [SKIP][232] ([i915#9519]) -> [PASS][233] +1 other test pass
[232]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-dg2-10/igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait.html
[233]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-7/igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait.html
- shard-rkl: [SKIP][234] ([i915#9519]) -> [PASS][235]
[234]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-rkl-7/igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait.html
[235]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-rkl-2/igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* {igt@kms_pm_rpm@system-suspend-modeset}:
- shard-dg2: [INCOMPLETE][236] -> [PASS][237]
[236]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-dg2-5/igt@kms_pm_rpm@system-suspend-modeset.html
[237]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-1/igt@kms_pm_rpm@system-suspend-modeset.html
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-rkl: [INCOMPLETE][238] -> [PASS][239]
[238]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-rkl-6/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html
[239]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-rkl-1/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-a-hdmi-a-1:
- shard-tglu: [FAIL][240] ([i915#9196]) -> [PASS][241]
[240]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-tglu-3/igt@kms_universal_plane@cursor-fb-leak@pipe-a-hdmi-a-1.html
[241]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-tglu-9/igt@kms_universal_plane@cursor-fb-leak@pipe-a-hdmi-a-1.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-c-edp-1:
- shard-mtlp: [FAIL][242] ([i915#9196]) -> [PASS][243]
[242]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-mtlp-8/igt@kms_universal_plane@cursor-fb-leak@pipe-c-edp-1.html
[243]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-1/igt@kms_universal_plane@cursor-fb-leak@pipe-c-edp-1.html
#### Warnings ####
* igt@gem_create@create-ext-cpu-access-big:
- shard-dg2: [INCOMPLETE][244] ([i915#9364]) -> [ABORT][245] ([i915#7461])
[244]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-dg2-10/igt@gem_create@create-ext-cpu-access-big.html
[245]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-dg2-7/igt@gem_create@create-ext-cpu-access-big.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-tglu: [FAIL][246] ([i915#2842]) -> [FAIL][247] ([i915#2876])
[246]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-tglu-6/igt@gem_exec_fair@basic-pace@rcs0.html
[247]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-tglu-2/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-rkl: [SKIP][248] ([fdo#110189] / [i915#3955]) -> [SKIP][249] ([i915#3955])
[248]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-rkl-1/igt@kms_fbcon_fbt@psr-suspend.html
[249]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-rkl-7/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-rkl: [SKIP][250] ([i915#4070] / [i915#4816]) -> [SKIP][251] ([i915#4816])
[250]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-rkl-1/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
[251]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-rkl-7/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-a-edp-1:
- shard-mtlp: [DMESG-WARN][252] ([i915#9157]) -> [DMESG-WARN][253] ([i915#2017])
[252]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13747/shard-mtlp-2/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-a-edp-1.html
[253]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/shard-mtlp-2/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-a-edp-1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2017]: https://gitlab.freedesktop.org/drm/intel/issues/2017
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2876]: https://gitlab.freedesktop.org/drm/intel/issues/2876
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3582]: https://gitlab.freedesktop.org/drm/intel/issues/3582
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4473]: https://gitlab.freedesktop.org/drm/intel/issues/4473
[i915#4537]: https://gitlab.freedesktop.org/drm/intel/issues/4537
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6122]: https://gitlab.freedesktop.org/drm/intel/issues/6122
[i915#6229]: https://gitlab.freedesktop.org/drm/intel/issues/6229
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6805]: https://gitlab.freedesktop.org/drm/intel/issues/6805
[i915#6806]: https://gitlab.freedesktop.org/drm/intel/issues/6806
[i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7213]: https://gitlab.freedesktop.org/drm/intel/issues/7213
[i915#7387]: https://gitlab.freedesktop.org/drm/intel/issues/7387
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7790]: https://gitlab.freedesktop.org/drm/intel/issues/7790
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8293]: https://gitlab.freedesktop.org/drm/intel/issues/8293
[i915#8381]: https://gitlab.freedesktop.org/drm/intel/issues/8381
[i915#8398]: https://gitlab.freedesktop.org/drm/intel/issues/8398
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8428]: https://gitlab.freedesktop.org/drm/intel/issues/8428
[i915#8489]: https://gitlab.freedesktop.org/drm/intel/issues/8489
[i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555
[i915#8623]: https://gitlab.freedesktop.org/drm/intel/issues/8623
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708
[i915#8709]: https://gitlab.freedesktop.org/drm/intel/issues/8709
[i915#8806]: https://gitlab.freedesktop.org/drm/intel/issues/8806
[i915#8810]: https://gitlab.freedesktop.org/drm/intel/issues/8810
[i915#8814]: https://gitlab.freedesktop.org/drm/intel/issues/8814
[i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841
[i915#8850]: https://gitlab.freedesktop.org/drm/intel/issues/8850
[i915#8912]: https://gitlab.freedesktop.org/drm/intel/issues/8912
[i915#8925]: https://gitlab.freedesktop.org/drm/intel/issues/8925
[i915#8957]: https://gitlab.freedesktop.org/drm/intel/issues/8957
[i915#8962]: https://gitlab.freedesktop.org/drm/intel/issues/8962
[i915#9157]: https://gitlab.freedesktop.org/drm/intel/issues/9157
[i915#9196]: https://gitlab.freedesktop.org/drm/intel/issues/9196
[i915#9310]: https://gitlab.freedesktop.org/drm/intel/issues/9310
[i915#9311]: https://gitlab.freedesktop.org/drm/intel/issues/9311
[i915#9364]: https://gitlab.freedesktop.org/drm/intel/issues/9364
[i915#9392]: https://gitlab.freedesktop.org/drm/intel/issues/9392
[i915#9423]: https://gitlab.freedesktop.org/drm/intel/issues/9423
[i915#9519]: https://gitlab.freedesktop.org/drm/intel/issues/9519
Build changes
-------------
* Linux: CI_DRM_13747 -> Patchwork_124730v3
* Piglit: None -> piglit_4509
CI-20190529: 20190529
CI_DRM_13747: f2a4e63a6eed6e327d5c7ca4c343059625855349 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7533: 7533
Patchwork_124730v3: f2a4e63a6eed6e327d5c7ca4c343059625855349 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124730v3/index.html
[-- Attachment #2: Type: text/html, Size: 72100 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs
2023-10-12 12:34 [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs Stanislav Lisovskiy
` (3 preceding siblings ...)
2023-10-13 16:58 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2023-10-17 9:49 ` kernel test robot
4 siblings, 0 replies; 18+ messages in thread
From: kernel test robot @ 2023-10-17 9:49 UTC (permalink / raw)
To: Stanislav Lisovskiy, intel-gfx; +Cc: jani.nikula, llvm, oe-kbuild-all
Hi Stanislav,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-tip/drm-tip]
url: https://github.com/intel-lab-lkp/linux/commits/Stanislav-Lisovskiy/drm-i915-Add-bigjoiner-force-enable-option-to-debugfs/20231017-105841
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
patch link: https://lore.kernel.org/r/20231012123411.17241-1-stanislav.lisovskiy%40intel.com
patch subject: [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20231017/202310171756.yzfTKqav-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231017/202310171756.yzfTKqav-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310171756.yzfTKqav-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/i915/display/intel_display_debugfs.c:1413:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (connector->base.status != connector_status_connected || !crtc) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_display_debugfs.c:1422:9: note: uninitialized use occurs here
return ret;
^~~
drivers/gpu/drm/i915/display/intel_display_debugfs.c:1413:2: note: remove the 'if' if its condition is always true
if (connector->base.status != connector_status_connected || !crtc) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_display_debugfs.c:1407:9: note: initialize the variable 'ret' to silence this warning
int ret;
^
= 0
1 warning generated.
vim +1413 drivers/gpu/drm/i915/display/intel_display_debugfs.c
1400
1401 static int i915_bigjoiner_enable_show(struct seq_file *m, void *data)
1402 {
1403 struct intel_connector *connector = to_intel_connector(m->private);
1404 struct drm_crtc *crtc;
1405 struct intel_encoder *encoder = intel_attached_encoder(connector);
1406 struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
1407 int ret;
1408
1409 if (!encoder)
1410 return -ENODEV;
1411
1412 crtc = connector->base.state->crtc;
> 1413 if (connector->base.status != connector_status_connected || !crtc) {
1414 ret = -ENODEV;
1415 goto out;
1416 }
1417
1418 seq_printf(m, "Bigjoiner enable: %d\n", intel_dp->force_bigjoiner_enable);
1419
1420 out:
1421
1422 return ret;
1423 }
1424
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs
@ 2023-10-18 13:24 Stanislav Lisovskiy
2023-10-25 12:59 ` Ville Syrjälä
0 siblings, 1 reply; 18+ messages in thread
From: Stanislav Lisovskiy @ 2023-10-18 13:24 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
For validation purposes, it might be useful to be able to
force Bigjoiner mode, even if current dotclock/resolution
do not require that.
Lets add such to option to debugfs.
v2: - Apparently intel_dp_need_bigjoiner can't be used, when
debugfs entry is created so lets just check manually
the DISPLAY_VER.
v3: - Switch to intel_connector from drm_connector(Jani Nikula)
- Remove redundant modeset lock(Jani Nikula)
- Use kstrtobool_from_user for boolean value(Jani Nikula)
v4: - Apply the changes to proper function(Jani Nikula)
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
.../drm/i915/display/intel_display_debugfs.c | 66 +++++++++++++++++++
.../drm/i915/display/intel_display_types.h | 2 +
drivers/gpu/drm/i915/display/intel_dp.c | 6 +-
3 files changed, 73 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index fbe75d47a165..9b810c6f96ea 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -1398,6 +1398,30 @@ out: drm_modeset_unlock(&dev->mode_config.connection_mutex);
return ret;
}
+static int i915_bigjoiner_enable_show(struct seq_file *m, void *data)
+{
+ struct intel_connector *connector = to_intel_connector(m->private);
+ struct drm_crtc *crtc;
+ struct intel_encoder *encoder = intel_attached_encoder(connector);
+ struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
+ int ret = 0;
+
+ if (!encoder)
+ return -ENODEV;
+
+ crtc = connector->base.state->crtc;
+ if (connector->base.status != connector_status_connected || !crtc) {
+ ret = -ENODEV;
+ goto out;
+ }
+
+ seq_printf(m, "Bigjoiner enable: %d\n", intel_dp->force_bigjoiner_enable);
+
+out:
+
+ return ret;
+}
+
static ssize_t i915_dsc_output_format_write(struct file *file,
const char __user *ubuf,
size_t len, loff_t *offp)
@@ -1419,12 +1443,39 @@ static ssize_t i915_dsc_output_format_write(struct file *file,
return len;
}
+static ssize_t i915_bigjoiner_enable_fops_write(struct file *file,
+ const char __user *ubuf,
+ size_t len, loff_t *offp)
+{
+ struct seq_file *m = file->private_data;
+ struct intel_connector *connector = m->private;
+ struct intel_encoder *encoder = intel_attached_encoder(connector);
+ struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
+ bool bigjoiner_en = 0;
+ int ret;
+
+ ret = kstrtobool_from_user(ubuf, len, &bigjoiner_en);
+ if (ret < 0)
+ return ret;
+
+ intel_dp->force_bigjoiner_enable = bigjoiner_en;
+ *offp += len;
+
+ return len;
+}
+
static int i915_dsc_output_format_open(struct inode *inode,
struct file *file)
{
return single_open(file, i915_dsc_output_format_show, inode->i_private);
}
+static int i915_bigjoiner_enable_open(struct inode *inode,
+ struct file *file)
+{
+ return single_open(file, i915_bigjoiner_enable_show, inode->i_private);
+}
+
static const struct file_operations i915_dsc_output_format_fops = {
.owner = THIS_MODULE,
.open = i915_dsc_output_format_open,
@@ -1434,6 +1485,15 @@ static const struct file_operations i915_dsc_output_format_fops = {
.write = i915_dsc_output_format_write
};
+static const struct file_operations i915_bigjoiner_enable_fops = {
+ .owner = THIS_MODULE,
+ .open = i915_bigjoiner_enable_open,
+ .read = seq_read,
+ .llseek = seq_lseek,
+ .release = single_release,
+ .write = i915_bigjoiner_enable_fops_write
+};
+
/*
* Returns the Current CRTC's bpc.
* Example usage: cat /sys/kernel/debug/dri/0/crtc-0/i915_current_bpc
@@ -1513,6 +1573,12 @@ void intel_connector_debugfs_add(struct intel_connector *intel_connector)
connector, &i915_dsc_output_format_fops);
}
+ if (DISPLAY_VER(dev_priv) >= 11 &&
+ intel_connector->base.connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
+ debugfs_create_file("i915_bigjoiner_force_enable", 0644, root,
+ &intel_connector->base, &i915_bigjoiner_enable_fops);
+ }
+
if (connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 8d8b2f8d37a9..e0de6eeaf59e 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1753,6 +1753,8 @@ struct intel_dp {
bool is_mst;
int active_mst_links;
+ bool force_bigjoiner_enable;
+
/* connector directly attached - won't be use for modeset in mst world */
struct intel_connector *attached_connector;
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 4f6835a7578e..6a9148232a9c 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1153,7 +1153,11 @@ bool intel_dp_need_bigjoiner(struct intel_dp *intel_dp,
if (!intel_dp_can_bigjoiner(intel_dp))
return false;
- return clock > i915->max_dotclk_freq || hdisplay > 5120;
+ if (intel_dp->force_bigjoiner_enable)
+ drm_dbg_kms(&i915->drm, "Forcing bigjoiner mode\n");
+
+ return clock > i915->max_dotclk_freq || hdisplay > 5120 ||
+ intel_dp->force_bigjoiner_enable;
}
static enum drm_mode_status
--
2.37.3
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs
2023-10-18 13:24 Stanislav Lisovskiy
@ 2023-10-25 12:59 ` Ville Syrjälä
2024-01-17 16:46 ` Sharma, Swati2
0 siblings, 1 reply; 18+ messages in thread
From: Ville Syrjälä @ 2023-10-25 12:59 UTC (permalink / raw)
To: Stanislav Lisovskiy; +Cc: jani.nikula, intel-gfx
On Wed, Oct 18, 2023 at 04:24:00PM +0300, Stanislav Lisovskiy wrote:
> For validation purposes, it might be useful to be able to
> force Bigjoiner mode, even if current dotclock/resolution
> do not require that.
> Lets add such to option to debugfs.
>
> v2: - Apparently intel_dp_need_bigjoiner can't be used, when
> debugfs entry is created so lets just check manually
> the DISPLAY_VER.
>
> v3: - Switch to intel_connector from drm_connector(Jani Nikula)
> - Remove redundant modeset lock(Jani Nikula)
> - Use kstrtobool_from_user for boolean value(Jani Nikula)
>
> v4: - Apply the changes to proper function(Jani Nikula)
>
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> ---
> .../drm/i915/display/intel_display_debugfs.c | 66 +++++++++++++++++++
> .../drm/i915/display/intel_display_types.h | 2 +
> drivers/gpu/drm/i915/display/intel_dp.c | 6 +-
> 3 files changed, 73 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index fbe75d47a165..9b810c6f96ea 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -1398,6 +1398,30 @@ out: drm_modeset_unlock(&dev->mode_config.connection_mutex);
> return ret;
> }
>
> +static int i915_bigjoiner_enable_show(struct seq_file *m, void *data)
> +{
> + struct intel_connector *connector = to_intel_connector(m->private);
> + struct drm_crtc *crtc;
> + struct intel_encoder *encoder = intel_attached_encoder(connector);
> + struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> + int ret = 0;
> +
> + if (!encoder)
> + return -ENODEV;
> +
> + crtc = connector->base.state->crtc;
> + if (connector->base.status != connector_status_connected || !crtc) {
> + ret = -ENODEV;
Why do we need this extra complication?
> + goto out;
> + }
> +
> + seq_printf(m, "Bigjoiner enable: %d\n", intel_dp->force_bigjoiner_enable);
> +
> +out:
> +
> + return ret;
> +}
> +
> static ssize_t i915_dsc_output_format_write(struct file *file,
> const char __user *ubuf,
> size_t len, loff_t *offp)
> @@ -1419,12 +1443,39 @@ static ssize_t i915_dsc_output_format_write(struct file *file,
> return len;
> }
>
> +static ssize_t i915_bigjoiner_enable_fops_write(struct file *file,
> + const char __user *ubuf,
> + size_t len, loff_t *offp)
> +{
> + struct seq_file *m = file->private_data;
> + struct intel_connector *connector = m->private;
> + struct intel_encoder *encoder = intel_attached_encoder(connector);
> + struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> + bool bigjoiner_en = 0;
> + int ret;
> +
> + ret = kstrtobool_from_user(ubuf, len, &bigjoiner_en);
> + if (ret < 0)
> + return ret;
> +
> + intel_dp->force_bigjoiner_enable = bigjoiner_en;
> + *offp += len;
> +
> + return len;
> +}
> +
> static int i915_dsc_output_format_open(struct inode *inode,
> struct file *file)
> {
> return single_open(file, i915_dsc_output_format_show, inode->i_private);
> }
>
> +static int i915_bigjoiner_enable_open(struct inode *inode,
> + struct file *file)
> +{
> + return single_open(file, i915_bigjoiner_enable_show, inode->i_private);
> +}
> +
> static const struct file_operations i915_dsc_output_format_fops = {
> .owner = THIS_MODULE,
> .open = i915_dsc_output_format_open,
> @@ -1434,6 +1485,15 @@ static const struct file_operations i915_dsc_output_format_fops = {
> .write = i915_dsc_output_format_write
> };
>
> +static const struct file_operations i915_bigjoiner_enable_fops = {
> + .owner = THIS_MODULE,
> + .open = i915_bigjoiner_enable_open,
> + .read = seq_read,
> + .llseek = seq_lseek,
> + .release = single_release,
> + .write = i915_bigjoiner_enable_fops_write
> +};
> +
> /*
> * Returns the Current CRTC's bpc.
> * Example usage: cat /sys/kernel/debug/dri/0/crtc-0/i915_current_bpc
> @@ -1513,6 +1573,12 @@ void intel_connector_debugfs_add(struct intel_connector *intel_connector)
> connector, &i915_dsc_output_format_fops);
> }
>
> + if (DISPLAY_VER(dev_priv) >= 11 &&
> + intel_connector->base.connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
eDP missing
> + debugfs_create_file("i915_bigjoiner_force_enable", 0644, root,
> + &intel_connector->base, &i915_bigjoiner_enable_fops);
> + }
> +
> if (connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
> connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
> connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index 8d8b2f8d37a9..e0de6eeaf59e 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -1753,6 +1753,8 @@ struct intel_dp {
> bool is_mst;
> int active_mst_links;
>
> + bool force_bigjoiner_enable;
> +
> /* connector directly attached - won't be use for modeset in mst world */
> struct intel_connector *attached_connector;
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 4f6835a7578e..6a9148232a9c 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -1153,7 +1153,11 @@ bool intel_dp_need_bigjoiner(struct intel_dp *intel_dp,
> if (!intel_dp_can_bigjoiner(intel_dp))
> return false;
>
> - return clock > i915->max_dotclk_freq || hdisplay > 5120;
> + if (intel_dp->force_bigjoiner_enable)
> + drm_dbg_kms(&i915->drm, "Forcing bigjoiner mode\n");
That's going to cause excessive dmesg spam.
> +
> + return clock > i915->max_dotclk_freq || hdisplay > 5120 ||
> + intel_dp->force_bigjoiner_enable;
> }
>
> static enum drm_mode_status
> --
> 2.37.3
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs
@ 2023-11-16 10:37 Stanislav Lisovskiy
2023-11-16 13:48 ` Modem, Bhanuprakash
0 siblings, 1 reply; 18+ messages in thread
From: Stanislav Lisovskiy @ 2023-11-16 10:37 UTC (permalink / raw)
To: intel-gfx
For validation purposes, it might be useful to be able to
force Bigjoiner mode, even if current dotclock/resolution
do not require that.
Lets add such to option to debugfs.
v2: - Apparently intel_dp_need_bigjoiner can't be used, when
debugfs entry is created so lets just check manually
the DISPLAY_VER.
v3: - Switch to intel_connector from drm_connector(Jani Nikula)
- Remove redundant modeset lock(Jani Nikula)
- Use kstrtobool_from_user for boolean value(Jani Nikula)
v4: - Apply the changes to proper function(Jani Nikula)
v5: - Removed unnecessary check from i915_bigjoiner_enable_show
(Ville Syrjälä)
- Added eDP connector check to intel_connector_debugfs_add
(Ville Syrjälä)
- Removed debug message in order to prevent dmesg flooding
(Ville Syrjälä)
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
.../drm/i915/display/intel_display_debugfs.c | 59 +++++++++++++++++++
.../drm/i915/display/intel_display_types.h | 2 +
drivers/gpu/drm/i915/display/intel_dp.c | 3 +-
3 files changed, 63 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index 915420d0cef8f..aa95ecf2458ee 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -1414,6 +1414,22 @@ out: drm_modeset_unlock(&dev->mode_config.connection_mutex);
return ret;
}
+static int i915_bigjoiner_enable_show(struct seq_file *m, void *data)
+{
+ struct intel_connector *connector = to_intel_connector(m->private);
+ struct intel_encoder *encoder = intel_attached_encoder(connector);
+ struct intel_dp *intel_dp;
+
+ if (!encoder)
+ return -ENODEV;
+
+ intel_dp = enc_to_intel_dp(encoder);
+
+ seq_printf(m, "Bigjoiner enable: %d\n", intel_dp->force_bigjoiner_enable);
+
+ return 0;
+}
+
static ssize_t i915_dsc_output_format_write(struct file *file,
const char __user *ubuf,
size_t len, loff_t *offp)
@@ -1435,12 +1451,39 @@ static ssize_t i915_dsc_output_format_write(struct file *file,
return len;
}
+static ssize_t i915_bigjoiner_enable_fops_write(struct file *file,
+ const char __user *ubuf,
+ size_t len, loff_t *offp)
+{
+ struct seq_file *m = file->private_data;
+ struct intel_connector *connector = m->private;
+ struct intel_encoder *encoder = intel_attached_encoder(connector);
+ struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
+ bool bigjoiner_en = 0;
+ int ret;
+
+ ret = kstrtobool_from_user(ubuf, len, &bigjoiner_en);
+ if (ret < 0)
+ return ret;
+
+ intel_dp->force_bigjoiner_enable = bigjoiner_en;
+ *offp += len;
+
+ return len;
+}
+
static int i915_dsc_output_format_open(struct inode *inode,
struct file *file)
{
return single_open(file, i915_dsc_output_format_show, inode->i_private);
}
+static int i915_bigjoiner_enable_open(struct inode *inode,
+ struct file *file)
+{
+ return single_open(file, i915_bigjoiner_enable_show, inode->i_private);
+}
+
static const struct file_operations i915_dsc_output_format_fops = {
.owner = THIS_MODULE,
.open = i915_dsc_output_format_open,
@@ -1529,6 +1572,15 @@ static const struct file_operations i915_dsc_fractional_bpp_fops = {
.write = i915_dsc_fractional_bpp_write
};
+static const struct file_operations i915_bigjoiner_enable_fops = {
+ .owner = THIS_MODULE,
+ .open = i915_bigjoiner_enable_open,
+ .read = seq_read,
+ .llseek = seq_lseek,
+ .release = single_release,
+ .write = i915_bigjoiner_enable_fops_write
+};
+
/*
* Returns the Current CRTC's bpc.
* Example usage: cat /sys/kernel/debug/dri/0/crtc-0/i915_current_bpc
@@ -1611,6 +1663,13 @@ void intel_connector_debugfs_add(struct intel_connector *intel_connector)
connector, &i915_dsc_fractional_bpp_fops);
}
+ if (DISPLAY_VER(dev_priv) >= 11 &&
+ (intel_connector->base.connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
+ intel_connector->base.connector_type == DRM_MODE_CONNECTOR_eDP)) {
+ debugfs_create_file("i915_bigjoiner_force_enable", 0644, root,
+ &intel_connector->base, &i915_bigjoiner_enable_fops);
+ }
+
if (connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 9a44350ba05dd..559302ff79c1a 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1764,6 +1764,8 @@ struct intel_dp {
bool is_mst;
int active_mst_links;
+ bool force_bigjoiner_enable;
+
/* connector directly attached - won't be use for modeset in mst world */
struct intel_connector *attached_connector;
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 54bd0bffa9f08..5b8411b9fc30b 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1172,7 +1172,8 @@ bool intel_dp_need_bigjoiner(struct intel_dp *intel_dp,
if (!intel_dp_can_bigjoiner(intel_dp))
return false;
- return clock > i915->max_dotclk_freq || hdisplay > 5120;
+ return clock > i915->max_dotclk_freq || hdisplay > 5120 ||
+ intel_dp->force_bigjoiner_enable;
}
static enum drm_mode_status
--
2.37.3
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs
2023-11-16 10:37 Stanislav Lisovskiy
@ 2023-11-16 13:48 ` Modem, Bhanuprakash
0 siblings, 0 replies; 18+ messages in thread
From: Modem, Bhanuprakash @ 2023-11-16 13:48 UTC (permalink / raw)
To: Stanislav Lisovskiy, intel-gfx
On Thu-16-11-2023 04:07 pm, Stanislav Lisovskiy wrote:
> For validation purposes, it might be useful to be able to
> force Bigjoiner mode, even if current dotclock/resolution
> do not require that.
> Lets add such to option to debugfs.
Do we have any IGT to validate this?
- Bhanu
>
> v2: - Apparently intel_dp_need_bigjoiner can't be used, when
> debugfs entry is created so lets just check manually
> the DISPLAY_VER.
>
> v3: - Switch to intel_connector from drm_connector(Jani Nikula)
> - Remove redundant modeset lock(Jani Nikula)
> - Use kstrtobool_from_user for boolean value(Jani Nikula)
>
> v4: - Apply the changes to proper function(Jani Nikula)
>
> v5: - Removed unnecessary check from i915_bigjoiner_enable_show
> (Ville Syrjälä)
> - Added eDP connector check to intel_connector_debugfs_add
> (Ville Syrjälä)
> - Removed debug message in order to prevent dmesg flooding
> (Ville Syrjälä)
>
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> ---
> .../drm/i915/display/intel_display_debugfs.c | 59 +++++++++++++++++++
> .../drm/i915/display/intel_display_types.h | 2 +
> drivers/gpu/drm/i915/display/intel_dp.c | 3 +-
> 3 files changed, 63 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index 915420d0cef8f..aa95ecf2458ee 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -1414,6 +1414,22 @@ out: drm_modeset_unlock(&dev->mode_config.connection_mutex);
> return ret;
> }
>
> +static int i915_bigjoiner_enable_show(struct seq_file *m, void *data)
> +{
> + struct intel_connector *connector = to_intel_connector(m->private);
> + struct intel_encoder *encoder = intel_attached_encoder(connector);
> + struct intel_dp *intel_dp;
> +
> + if (!encoder)
> + return -ENODEV;
> +
> + intel_dp = enc_to_intel_dp(encoder);
> +
> + seq_printf(m, "Bigjoiner enable: %d\n", intel_dp->force_bigjoiner_enable);
> +
> + return 0;
> +}
> +
> static ssize_t i915_dsc_output_format_write(struct file *file,
> const char __user *ubuf,
> size_t len, loff_t *offp)
> @@ -1435,12 +1451,39 @@ static ssize_t i915_dsc_output_format_write(struct file *file,
> return len;
> }
>
> +static ssize_t i915_bigjoiner_enable_fops_write(struct file *file,
> + const char __user *ubuf,
> + size_t len, loff_t *offp)
> +{
> + struct seq_file *m = file->private_data;
> + struct intel_connector *connector = m->private;
> + struct intel_encoder *encoder = intel_attached_encoder(connector);
> + struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> + bool bigjoiner_en = 0;
> + int ret;
> +
> + ret = kstrtobool_from_user(ubuf, len, &bigjoiner_en);
> + if (ret < 0)
> + return ret;
> +
> + intel_dp->force_bigjoiner_enable = bigjoiner_en;
> + *offp += len;
> +
> + return len;
> +}
> +
> static int i915_dsc_output_format_open(struct inode *inode,
> struct file *file)
> {
> return single_open(file, i915_dsc_output_format_show, inode->i_private);
> }
>
> +static int i915_bigjoiner_enable_open(struct inode *inode,
> + struct file *file)
> +{
> + return single_open(file, i915_bigjoiner_enable_show, inode->i_private);
> +}
> +
> static const struct file_operations i915_dsc_output_format_fops = {
> .owner = THIS_MODULE,
> .open = i915_dsc_output_format_open,
> @@ -1529,6 +1572,15 @@ static const struct file_operations i915_dsc_fractional_bpp_fops = {
> .write = i915_dsc_fractional_bpp_write
> };
>
> +static const struct file_operations i915_bigjoiner_enable_fops = {
> + .owner = THIS_MODULE,
> + .open = i915_bigjoiner_enable_open,
> + .read = seq_read,
> + .llseek = seq_lseek,
> + .release = single_release,
> + .write = i915_bigjoiner_enable_fops_write
> +};
> +
> /*
> * Returns the Current CRTC's bpc.
> * Example usage: cat /sys/kernel/debug/dri/0/crtc-0/i915_current_bpc
> @@ -1611,6 +1663,13 @@ void intel_connector_debugfs_add(struct intel_connector *intel_connector)
> connector, &i915_dsc_fractional_bpp_fops);
> }
>
> + if (DISPLAY_VER(dev_priv) >= 11 &&
> + (intel_connector->base.connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
> + intel_connector->base.connector_type == DRM_MODE_CONNECTOR_eDP)) {
> + debugfs_create_file("i915_bigjoiner_force_enable", 0644, root,
> + &intel_connector->base, &i915_bigjoiner_enable_fops);
> + }
> +
> if (connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
> connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
> connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index 9a44350ba05dd..559302ff79c1a 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -1764,6 +1764,8 @@ struct intel_dp {
> bool is_mst;
> int active_mst_links;
>
> + bool force_bigjoiner_enable;
> +
> /* connector directly attached - won't be use for modeset in mst world */
> struct intel_connector *attached_connector;
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 54bd0bffa9f08..5b8411b9fc30b 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -1172,7 +1172,8 @@ bool intel_dp_need_bigjoiner(struct intel_dp *intel_dp,
> if (!intel_dp_can_bigjoiner(intel_dp))
> return false;
>
> - return clock > i915->max_dotclk_freq || hdisplay > 5120;
> + return clock > i915->max_dotclk_freq || hdisplay > 5120 ||
> + intel_dp->force_bigjoiner_enable;
> }
>
> static enum drm_mode_status
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs
2023-10-25 12:59 ` Ville Syrjälä
@ 2024-01-17 16:46 ` Sharma, Swati2
2024-01-17 18:01 ` Jani Nikula
0 siblings, 1 reply; 18+ messages in thread
From: Sharma, Swati2 @ 2024-01-17 16:46 UTC (permalink / raw)
To: Ville Syrjälä, Stanislav Lisovskiy; +Cc: jani.nikula, intel-gfx
Hi Ville,
On 25-Oct-23 6:29 PM, Ville Syrjälä wrote:
> On Wed, Oct 18, 2023 at 04:24:00PM +0300, Stanislav Lisovskiy wrote:
>> For validation purposes, it might be useful to be able to
>> force Bigjoiner mode, even if current dotclock/resolution
>> do not require that.
>> Lets add such to option to debugfs.
>>
>> v2: - Apparently intel_dp_need_bigjoiner can't be used, when
>> debugfs entry is created so lets just check manually
>> the DISPLAY_VER.
>>
>> v3: - Switch to intel_connector from drm_connector(Jani Nikula)
>> - Remove redundant modeset lock(Jani Nikula)
>> - Use kstrtobool_from_user for boolean value(Jani Nikula)
>>
>> v4: - Apply the changes to proper function(Jani Nikula)
>>
>> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
>> ---
>> .../drm/i915/display/intel_display_debugfs.c | 66 +++++++++++++++++++
>> .../drm/i915/display/intel_display_types.h | 2 +
>> drivers/gpu/drm/i915/display/intel_dp.c | 6 +-
>> 3 files changed, 73 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
>> index fbe75d47a165..9b810c6f96ea 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
>> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
>> @@ -1398,6 +1398,30 @@ out: drm_modeset_unlock(&dev->mode_config.connection_mutex);
>> return ret;
>> }
>>
>> +static int i915_bigjoiner_enable_show(struct seq_file *m, void *data)
>> +{
>> + struct intel_connector *connector = to_intel_connector(m->private);
>> + struct drm_crtc *crtc;
>> + struct intel_encoder *encoder = intel_attached_encoder(connector);
>> + struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
>> + int ret = 0;
>> +
>> + if (!encoder)
>> + return -ENODEV;
>> +
>> + crtc = connector->base.state->crtc;
>> + if (connector->base.status != connector_status_connected || !crtc) {
>> + ret = -ENODEV;
>
> Why do we need this extra complication?
>
>> + goto out;
>> + }
>> +
>> + seq_printf(m, "Bigjoiner enable: %d\n", intel_dp->force_bigjoiner_enable);
>> +
>> +out:
>> +
>> + return ret;
>> +}
>> +
>> static ssize_t i915_dsc_output_format_write(struct file *file,
>> const char __user *ubuf,
>> size_t len, loff_t *offp)
>> @@ -1419,12 +1443,39 @@ static ssize_t i915_dsc_output_format_write(struct file *file,
>> return len;
>> }
>>
>> +static ssize_t i915_bigjoiner_enable_fops_write(struct file *file,
>> + const char __user *ubuf,
>> + size_t len, loff_t *offp)
>> +{
>> + struct seq_file *m = file->private_data;
>> + struct intel_connector *connector = m->private;
>> + struct intel_encoder *encoder = intel_attached_encoder(connector);
>> + struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
>> + bool bigjoiner_en = 0;
>> + int ret;
>> +
>> + ret = kstrtobool_from_user(ubuf, len, &bigjoiner_en);
>> + if (ret < 0)
>> + return ret;
>> +
>> + intel_dp->force_bigjoiner_enable = bigjoiner_en;
>> + *offp += len;
>> +
>> + return len;
>> +}
>> +
>> static int i915_dsc_output_format_open(struct inode *inode,
>> struct file *file)
>> {
>> return single_open(file, i915_dsc_output_format_show, inode->i_private);
>> }
>>
>> +static int i915_bigjoiner_enable_open(struct inode *inode,
>> + struct file *file)
>> +{
>> + return single_open(file, i915_bigjoiner_enable_show, inode->i_private);
>> +}
>> +
>> static const struct file_operations i915_dsc_output_format_fops = {
>> .owner = THIS_MODULE,
>> .open = i915_dsc_output_format_open,
>> @@ -1434,6 +1485,15 @@ static const struct file_operations i915_dsc_output_format_fops = {
>> .write = i915_dsc_output_format_write
>> };
>>
>> +static const struct file_operations i915_bigjoiner_enable_fops = {
>> + .owner = THIS_MODULE,
>> + .open = i915_bigjoiner_enable_open,
>> + .read = seq_read,
>> + .llseek = seq_lseek,
>> + .release = single_release,
>> + .write = i915_bigjoiner_enable_fops_write
>> +};
>> +
>> /*
>> * Returns the Current CRTC's bpc.
>> * Example usage: cat /sys/kernel/debug/dri/0/crtc-0/i915_current_bpc
>> @@ -1513,6 +1573,12 @@ void intel_connector_debugfs_add(struct intel_connector *intel_connector)
>> connector, &i915_dsc_output_format_fops);
>> }
>>
>> + if (DISPLAY_VER(dev_priv) >= 11 &&
>> + intel_connector->base.connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
>
> eDP missing
>
>> + debugfs_create_file("i915_bigjoiner_force_enable", 0644, root,
>> + &intel_connector->base, &i915_bigjoiner_enable_fops);
>> + }
>> +
>> if (connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
>> connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
>> connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
>> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
>> index 8d8b2f8d37a9..e0de6eeaf59e 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
>> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
>> @@ -1753,6 +1753,8 @@ struct intel_dp {
>> bool is_mst;
>> int active_mst_links;
>>
>> + bool force_bigjoiner_enable;
>> +
>> /* connector directly attached - won't be use for modeset in mst world */
>> struct intel_connector *attached_connector;
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>> index 4f6835a7578e..6a9148232a9c 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>> @@ -1153,7 +1153,11 @@ bool intel_dp_need_bigjoiner(struct intel_dp *intel_dp,
>> if (!intel_dp_can_bigjoiner(intel_dp))
>> return false;
>>
>> - return clock > i915->max_dotclk_freq || hdisplay > 5120;
>> + if (intel_dp->force_bigjoiner_enable)
>> + drm_dbg_kms(&i915->drm, "Forcing bigjoiner mode\n");
>
> That's going to cause excessive dmesg spam.
Then how from dmesg we will get to know, big joiner was forced?
Shouldn't we have atleast one debug print to know this?
>
>> +
>> + return clock > i915->max_dotclk_freq || hdisplay > 5120 ||
>> + intel_dp->force_bigjoiner_enable;
>> }
>>
>> static enum drm_mode_status
>> --
>> 2.37.3
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs
2024-01-17 16:46 ` Sharma, Swati2
@ 2024-01-17 18:01 ` Jani Nikula
2024-01-18 6:01 ` Sharma, Swati2
0 siblings, 1 reply; 18+ messages in thread
From: Jani Nikula @ 2024-01-17 18:01 UTC (permalink / raw)
To: Sharma, Swati2, Ville Syrjälä, Stanislav Lisovskiy; +Cc: intel-gfx
On Wed, 17 Jan 2024, "Sharma, Swati2" <swati2.sharma@intel.com> wrote:
> Hi Ville,
>
> On 25-Oct-23 6:29 PM, Ville Syrjälä wrote:
>> On Wed, Oct 18, 2023 at 04:24:00PM +0300, Stanislav Lisovskiy wrote:
>>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>>> index 4f6835a7578e..6a9148232a9c 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>>> @@ -1153,7 +1153,11 @@ bool intel_dp_need_bigjoiner(struct intel_dp *intel_dp,
>>> if (!intel_dp_can_bigjoiner(intel_dp))
>>> return false;
>>>
>>> - return clock > i915->max_dotclk_freq || hdisplay > 5120;
>>> + if (intel_dp->force_bigjoiner_enable)
>>> + drm_dbg_kms(&i915->drm, "Forcing bigjoiner mode\n");
>>
>> That's going to cause excessive dmesg spam.
>
> Then how from dmesg we will get to know, big joiner was forced?
> Shouldn't we have atleast one debug print to know this?
Yeah. But this gets called for every single display mode via
intel_dp_mode_valid().
BR,
Jani.
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs
2024-01-17 18:01 ` Jani Nikula
@ 2024-01-18 6:01 ` Sharma, Swati2
0 siblings, 0 replies; 18+ messages in thread
From: Sharma, Swati2 @ 2024-01-18 6:01 UTC (permalink / raw)
To: Jani Nikula, Ville Syrjälä, Stanislav Lisovskiy; +Cc: intel-gfx
On 17-Jan-24 11:31 PM, Jani Nikula wrote:
> On Wed, 17 Jan 2024, "Sharma, Swati2" <swati2.sharma@intel.com> wrote:
>> Hi Ville,
>>
>> On 25-Oct-23 6:29 PM, Ville Syrjälä wrote:
>>> On Wed, Oct 18, 2023 at 04:24:00PM +0300, Stanislav Lisovskiy wrote:
>>>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>>>> index 4f6835a7578e..6a9148232a9c 100644
>>>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>>>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>>>> @@ -1153,7 +1153,11 @@ bool intel_dp_need_bigjoiner(struct intel_dp *intel_dp,
>>>> if (!intel_dp_can_bigjoiner(intel_dp))
>>>> return false;
>>>>
>>>> - return clock > i915->max_dotclk_freq || hdisplay > 5120;
>>>> + if (intel_dp->force_bigjoiner_enable)
>>>> + drm_dbg_kms(&i915->drm, "Forcing bigjoiner mode\n");
>>>
>>> That's going to cause excessive dmesg spam.
>>
>> Then how from dmesg we will get to know, big joiner was forced?
>> Shouldn't we have atleast one debug print to know this?
>
> Yeah. But this gets called for every single display mode via
> intel_dp_mode_valid().
ohh okay, can we add dbg print in intel_dp_compute_link_config()
from where intel_dp_need_bigjoiner() is called?
>
> BR,
> Jani.
>
>
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2024-01-18 6:01 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-12 12:34 [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs Stanislav Lisovskiy
2023-10-12 14:59 ` Jani Nikula
2023-10-13 9:54 ` Lisovskiy, Stanislav
2023-10-12 17:42 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add bigjoiner force enable option to debugfs (rev3) Patchwork
2023-10-12 17:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-10-13 16:58 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-10-17 9:49 ` [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-11-16 10:37 Stanislav Lisovskiy
2023-11-16 13:48 ` Modem, Bhanuprakash
2023-10-18 13:24 Stanislav Lisovskiy
2023-10-25 12:59 ` Ville Syrjälä
2024-01-17 16:46 ` Sharma, Swati2
2024-01-17 18:01 ` Jani Nikula
2024-01-18 6:01 ` Sharma, Swati2
2023-10-09 13:30 Stanislav Lisovskiy
2023-10-11 8:49 ` Jani Nikula
2023-10-11 8:59 ` Lisovskiy, Stanislav
2023-10-06 14:15 Stanislav Lisovskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox