[PATCH] intel: Fix missing ETIME on BSD operating systems

[PATCH] intel: Fix missing ETIME on BSD operating systems

[Richard Yao]

From: David Shao <davshao@gmail.com>

Originally posted to Free Desktop bug #52549 by David Shao.
Resolves Gentoo Bug #433403.
Commit message by Richard Yao.

Reviewed-by: Richard Yao <ryao@gentoo.org>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
---
 intel/intel_bufmgr_gem.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c
index 8d45839..512bc6f 100644
--- a/intel/intel_bufmgr_gem.c
+++ b/intel/intel_bufmgr_gem.c
@@ -54,6 +54,9 @@
 #include <stdbool.h>
 
 #include "errno.h"
+#ifndef ETIME
+#define ETIME ETIMEDOUT
+#endif
 #include "libdrm_lists.h"
 #include "intel_bufmgr.h"
 #include "intel_bufmgr_priv.h"
-- 
1.7.8.6

Re: [PATCH] intel: Fix missing ETIME on BSD operating systems

[Ben Widawsky]

On Sat, 10 Nov 2012 00:24:56 -0500
Richard Yao <ryao@cs.stonybrook.edu> wrote:

> From: David Shao <davshao@gmail.com>
> 
> Originally posted to Free Desktop bug #52549 by David Shao.
> Resolves Gentoo Bug #433403.
> Commit message by Richard Yao.
> 
> Reviewed-by: Richard Yao <ryao@gentoo.org>
> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

I've pushed this. Please add bug links as "References:" in the future.

Also, I suspect you will want a release as the result of this?

Thanks.

> ---
>  intel/intel_bufmgr_gem.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c
> index 8d45839..512bc6f 100644
> --- a/intel/intel_bufmgr_gem.c
> +++ b/intel/intel_bufmgr_gem.c
> @@ -54,6 +54,9 @@
>  #include <stdbool.h>
>  
>  #include "errno.h"
> +#ifndef ETIME
> +#define ETIME ETIMEDOUT
> +#endif
>  #include "libdrm_lists.h"
>  #include "intel_bufmgr.h"
>  #include "intel_bufmgr_priv.h"



-- 
Ben Widawsky, Intel Open Source Technology Center

Re: [PATCH] intel: Fix missing ETIME on BSD operating systems

[Eric Anholt]

[-- Attachment #1.1: Type: text/plain, Size: 556 bytes --]

Richard Yao <ryao@cs.stonybrook.edu> writes:

> From: David Shao <davshao@gmail.com>
>
> Originally posted to Free Desktop bug #52549 by David Shao.
> Resolves Gentoo Bug #433403.
> Commit message by Richard Yao.

Are you really unable to get the same errnos in your port of the kernel
modules?  Having mismatched errno returns from upstream is a great way
to have obscure bugs on your port, given that our kernel guys like to
look for alternative errnos to be able to distinguish failure modes from
userland.

I don't like the idea of this patch landing.

[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] intel: Fix missing ETIME on BSD operating systems

[Richard Yao]

[-- Attachment #1.1: Type: text/plain, Size: 1116 bytes --]

On 11/10/2012 03:12 PM, Eric Anholt wrote:
> Richard Yao <ryao@cs.stonybrook.edu> writes:
> 
>> From: David Shao <davshao@gmail.com>
>>
>> Originally posted to Free Desktop bug #52549 by David Shao.
>> Resolves Gentoo Bug #433403.
>> Commit message by Richard Yao.
> 
> Are you really unable to get the same errnos in your port of the kernel
> modules?  Having mismatched errno returns from upstream is a great way
> to have obscure bugs on your port, given that our kernel guys like to
> look for alternative errnos to be able to distinguish failure modes from
> userland.
> 
> I don't like the idea of this patch landing.

I have added the FreeBSD x11 team alias to CC, which I probably should
have done in my original email. They are in a better position to answer
this than I am.

At present, MySQL also does this. Changing that would require changes to
the userland of FreeBSD (and other BSDs). The FreeBSD x11 team is in a
position to do that. I am in the process of getting Gentoo's X11 stack
working on Gentoo FreeBSD, so I am interested in their answer to your
question as well.


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 900 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] intel: Fix missing ETIME on BSD operating systems

[Ben Widawsky]

On Sat, 10 Nov 2012 16:36:26 -0500
Richard Yao <ryao@gentoo.org> wrote:

> On 11/10/2012 03:12 PM, Eric Anholt wrote:
> > Richard Yao <ryao@cs.stonybrook.edu> writes:
> > 
> >> From: David Shao <davshao@gmail.com>
> >>
> >> Originally posted to Free Desktop bug #52549 by David Shao.
> >> Resolves Gentoo Bug #433403.
> >> Commit message by Richard Yao.
> > 
> > Are you really unable to get the same errnos in your port of the
> > kernel modules?  Having mismatched errno returns from upstream is a
> > great way to have obscure bugs on your port, given that our kernel
> > guys like to look for alternative errnos to be able to distinguish
> > failure modes from userland.
> > 
> > I don't like the idea of this patch landing.
> 
> I have added the FreeBSD x11 team alias to CC, which I probably should
> have done in my original email. They are in a better position to
> answer this than I am.
> 
> At present, MySQL also does this. Changing that would require changes
> to the userland of FreeBSD (and other BSDs). The FreeBSD x11 team is
> in a position to do that. I am in the process of getting Gentoo's X11
> stack working on Gentoo FreeBSD, so I am interested in their answer
> to your question as well.
> 
> 

Before pushing the patch, I did a bit of googling and I too found that
MySQL and LibreOffice does this, so it seemed okay to me. It's not
terribly prolific because I think many cross-platform products do not
use interfaces which return ETIME.

It sounds like BSD though is the only remaining holdout, as Windows and
OSX both seem to support ETIME.

[PATCH] intel: Fix missing ETIME on BSD operating systems

[Richard Yao]

From: David Shao <davshao@gmail.com>

Originally posted to Free Desktop bug #52549 by David Shao.
Resolves Gentoo Bug #433403.
Commit message by Richard Yao.

Reviewed-by: Richard Yao <ryao@gentoo.org>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
---
 intel/intel_bufmgr_gem.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c
index 8d45839..512bc6f 100644
--- a/intel/intel_bufmgr_gem.c
+++ b/intel/intel_bufmgr_gem.c
@@ -54,6 +54,9 @@
 #include <stdbool.h>
 
 #include "errno.h"
+#ifndef ETIME
+#define ETIME ETIMEDOUT
+#endif
 #include "libdrm_lists.h"
 #include "intel_bufmgr.h"
 #include "intel_bufmgr_priv.h"
-- 
1.7.8.6

[PATCH] intel: Fix missing ETIME on BSD operating systems

[Richard Yao]

From: David Shao <davshao@gmail.com>

Originally posted to Free Desktop bug #52549 by David Shao.
Resolves Gentoo Bug #433403.
Commit message by Richard Yao.

Reviewed-by: Richard Yao <ryao@gentoo.org>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
---
 intel/intel_bufmgr_gem.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c
index 8d45839..512bc6f 100644
--- a/intel/intel_bufmgr_gem.c
+++ b/intel/intel_bufmgr_gem.c
@@ -54,6 +54,9 @@
 #include <stdbool.h>
 
 #include "errno.h"
+#ifndef ETIME
+#define ETIME ETIMEDOUT
+#endif
 #include "libdrm_lists.h"
 #include "intel_bufmgr.h"
 #include "intel_bufmgr_priv.h"
-- 
1.7.8.6

[PATCH] intel: Fix missing ETIME on BSD operating systems

[Richard Yao]

From: David Shao <davshao@gmail.com>

Originally posted to Free Desktop bug #52549 by David Shao.
Resolves Gentoo Bug #433403.
Commit message by Richard Yao.

Reviewed-by: Richard Yao <ryao@gentoo.org>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
---
 intel/intel_bufmgr_gem.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c
index 8d45839..512bc6f 100644
--- a/intel/intel_bufmgr_gem.c
+++ b/intel/intel_bufmgr_gem.c
@@ -54,6 +54,9 @@
 #include <stdbool.h>
 
 #include "errno.h"
+#ifndef ETIME
+#define ETIME ETIMEDOUT
+#endif
 #include "libdrm_lists.h"
 #include "intel_bufmgr.h"
 #include "intel_bufmgr_priv.h"
-- 
1.7.8.6