Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH 1/2] drm/i915: Make intel_mpllb_state_verify() safer
@ 2023-04-13 20:06 Ville Syrjala
  2023-04-13 20:06 ` [Intel-gfx] [PATCH 2/2] drm/i915: Make intel_get_crtc_new_encoder() less oopsy Ville Syrjala
                   ` (8 more replies)
  0 siblings, 9 replies; 12+ messages in thread
From: Ville Syrjala @ 2023-04-13 20:06 UTC (permalink / raw)
  To: intel-gfx

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

intel_mpllb_state_verify() blows up if you call it for a
non-modeset/fastset commit on account of the relevant
connector not being part of the overall atomic state.
Currently the state checker only runs for modeset/fastset
commits, but for testing purposes it is sometimes desirable
to run it for other commits too. Check for modeset/fastset
in intel_mpllb_state_verify() itself to make this safe.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_snps_phy.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_snps_phy.c b/drivers/gpu/drm/i915/display/intel_snps_phy.c
index 1cfb94b5cedb..4efc79d47e43 100644
--- a/drivers/gpu/drm/i915/display/intel_snps_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_snps_phy.c
@@ -2007,6 +2007,10 @@ void intel_mpllb_state_verify(struct intel_atomic_state *state,
 	if (!new_crtc_state->hw.active)
 		return;
 
+	if (!intel_crtc_needs_modeset(new_crtc_state) &&
+	    !intel_crtc_needs_fastset(new_crtc_state))
+		return;
+
 	encoder = intel_get_crtc_new_encoder(state, new_crtc_state);
 	intel_mpllb_readout_hw_state(encoder, &mpllb_hw_state);
 
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2023-04-15  3:01 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-13 20:06 [Intel-gfx] [PATCH 1/2] drm/i915: Make intel_mpllb_state_verify() safer Ville Syrjala
2023-04-13 20:06 ` [Intel-gfx] [PATCH 2/2] drm/i915: Make intel_get_crtc_new_encoder() less oopsy Ville Syrjala
2023-04-14  9:31   ` Jani Nikula
2023-04-14  9:39     ` Jani Nikula
2023-04-14  0:02 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Make intel_mpllb_state_verify() safer Patchwork
2023-04-14  0:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-04-14  6:48 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-04-14  9:38 ` [Intel-gfx] [PATCH 1/2] " Jani Nikula
2023-04-14 19:01 ` [Intel-gfx] [PATCH v2 1/2] drm/i915: Make intel_{mpllb, c10pll}_state_verify() safer Ville Syrjala
2023-04-14 19:38 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/2] drm/i915: Make intel_{mpllb, c10pll}_state_verify() safer (rev2) Patchwork
2023-04-14 19:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-04-15  3:01 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox