* [Intel-gfx] [PATCH 0/3] Simplify intel_setup_outputs()
@ 2021-02-13 19:05 Lucas De Marchi
2021-02-13 19:05 ` [Intel-gfx] [PATCH 1/3] drm/i915/display: move vbt check to intel_ddi_init() Lucas De Marchi
` (4 more replies)
0 siblings, 5 replies; 12+ messages in thread
From: Lucas De Marchi @ 2021-02-13 19:05 UTC (permalink / raw)
To: intel-gfx
First and second patches should be straightforward. Third patch is a
tentative simplification that may break things in the presence of broken
VBTs, but I'm feeling confident.
Lucas De Marchi (3):
drm/i915/display: move vbt check to intel_ddi_init()
drm/i915/display: remove FIXME comment for intended feature
drm/i915/display: remove strap checks from gen 9
drivers/gpu/drm/i915/display/intel_ddi.c | 7 +++
drivers/gpu/drm/i915/display/intel_display.c | 54 ++++++--------------
2 files changed, 23 insertions(+), 38 deletions(-)
--
2.29.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread* [Intel-gfx] [PATCH 1/3] drm/i915/display: move vbt check to intel_ddi_init() 2021-02-13 19:05 [Intel-gfx] [PATCH 0/3] Simplify intel_setup_outputs() Lucas De Marchi @ 2021-02-13 19:05 ` Lucas De Marchi 2021-02-15 10:35 ` Jani Nikula 2021-03-19 11:38 ` Jani Nikula 2021-02-13 19:05 ` [Intel-gfx] [PATCH 2/3] drm/i915/display: remove FIXME comment for intended feature Lucas De Marchi ` (3 subsequent siblings) 4 siblings, 2 replies; 12+ messages in thread From: Lucas De Marchi @ 2021-02-13 19:05 UTC (permalink / raw) To: intel-gfx On intel_ddi_init() we already check VBT if the port supports HDMI/DP and bail out otherwise. Instad of checking if a single port is present using VBT in intel_display.c, move the stronger check to intel_ddi_init() and return early in case it's not supported. There would be no way intel_bios_* would report support for hdmi/dp if the port isn't present so this should cause no regressions for other platforms. Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> --- drivers/gpu/drm/i915/display/intel_ddi.c | 7 +++++++ drivers/gpu/drm/i915/display/intel_display.c | 14 ++++++-------- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index 3b97c0091812..1235be0ba5d1 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi.c +++ b/drivers/gpu/drm/i915/display/intel_ddi.c @@ -3972,6 +3972,13 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port) bool init_hdmi, init_dp; enum phy phy = intel_port_to_phy(dev_priv, port); + if (!intel_bios_is_port_present(dev_priv, port)) { + drm_dbg_kms(&dev_priv->drm, + "VBT says port %c is not present, respect it\n", + port_name(port)); + return; + } + /* * On platforms with HTI (aka HDPORT), if it's enabled at boot it may * have taken over some of the PHYs and made them unavailable to the diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 23ec68498800..7aaf7a29d493 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -11904,13 +11904,13 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) intel_ddi_init(dev_priv, PORT_C); intel_ddi_init(dev_priv, PORT_D); intel_ddi_init(dev_priv, PORT_E); + /* - * On some ICL SKUs port F is not present. No strap bits for - * this, so rely on VBT. - * Work around broken VBTs on SKUs known to have no port F. + * On some ICL SKUs port F is not present, but broken VBTs mark + * the port as present. Only try to initialize port F for the + * SKUs that may actually have it. */ - if (IS_ICL_WITH_PORT_F(dev_priv) && - intel_bios_is_port_present(dev_priv, PORT_F)) + if (IS_ICL_WITH_PORT_F(dev_priv)) intel_ddi_init(dev_priv, PORT_F); icl_dsi_init(dev_priv); @@ -11964,10 +11964,8 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) /* * On SKL we don't have a way to detect DDI-E so we rely on VBT. */ - if (IS_GEN9_BC(dev_priv) && - intel_bios_is_port_present(dev_priv, PORT_E)) + if (IS_GEN9_BC(dev_priv)) intel_ddi_init(dev_priv, PORT_E); - } else if (HAS_PCH_SPLIT(dev_priv)) { int found; -- 2.29.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915/display: move vbt check to intel_ddi_init() 2021-02-13 19:05 ` [Intel-gfx] [PATCH 1/3] drm/i915/display: move vbt check to intel_ddi_init() Lucas De Marchi @ 2021-02-15 10:35 ` Jani Nikula 2021-02-15 16:26 ` Lucas De Marchi 2021-03-19 11:38 ` Jani Nikula 1 sibling, 1 reply; 12+ messages in thread From: Jani Nikula @ 2021-02-15 10:35 UTC (permalink / raw) To: Lucas De Marchi, intel-gfx On Sat, 13 Feb 2021, Lucas De Marchi <lucas.demarchi@intel.com> wrote: > On intel_ddi_init() we already check VBT if the port supports HDMI/DP > and bail out otherwise. Instad of checking if a single port is present > using VBT in intel_display.c, move the stronger check to > intel_ddi_init() and return early in case it's not supported. There > would be no way intel_bios_* would report support for hdmi/dp if the > port isn't present so this should cause no regressions for other > platforms. Sorry, but this will regress machines that have no VBT. I've been thinking about creating fake child devices for that case to reduce the exceptions. BR, Jani. > > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 7 +++++++ > drivers/gpu/drm/i915/display/intel_display.c | 14 ++++++-------- > 2 files changed, 13 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c > index 3b97c0091812..1235be0ba5d1 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -3972,6 +3972,13 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port) > bool init_hdmi, init_dp; > enum phy phy = intel_port_to_phy(dev_priv, port); > > + if (!intel_bios_is_port_present(dev_priv, port)) { > + drm_dbg_kms(&dev_priv->drm, > + "VBT says port %c is not present, respect it\n", > + port_name(port)); > + return; > + } > + > /* > * On platforms with HTI (aka HDPORT), if it's enabled at boot it may > * have taken over some of the PHYs and made them unavailable to the > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index 23ec68498800..7aaf7a29d493 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -11904,13 +11904,13 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) > intel_ddi_init(dev_priv, PORT_C); > intel_ddi_init(dev_priv, PORT_D); > intel_ddi_init(dev_priv, PORT_E); > + > /* > - * On some ICL SKUs port F is not present. No strap bits for > - * this, so rely on VBT. > - * Work around broken VBTs on SKUs known to have no port F. > + * On some ICL SKUs port F is not present, but broken VBTs mark > + * the port as present. Only try to initialize port F for the > + * SKUs that may actually have it. > */ > - if (IS_ICL_WITH_PORT_F(dev_priv) && > - intel_bios_is_port_present(dev_priv, PORT_F)) > + if (IS_ICL_WITH_PORT_F(dev_priv)) > intel_ddi_init(dev_priv, PORT_F); > > icl_dsi_init(dev_priv); > @@ -11964,10 +11964,8 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) > /* > * On SKL we don't have a way to detect DDI-E so we rely on VBT. > */ > - if (IS_GEN9_BC(dev_priv) && > - intel_bios_is_port_present(dev_priv, PORT_E)) > + if (IS_GEN9_BC(dev_priv)) > intel_ddi_init(dev_priv, PORT_E); > - > } else if (HAS_PCH_SPLIT(dev_priv)) { > int found; -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915/display: move vbt check to intel_ddi_init() 2021-02-15 10:35 ` Jani Nikula @ 2021-02-15 16:26 ` Lucas De Marchi 2021-02-16 19:50 ` Jani Nikula 0 siblings, 1 reply; 12+ messages in thread From: Lucas De Marchi @ 2021-02-15 16:26 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx On Mon, Feb 15, 2021 at 12:35:50PM +0200, Jani Nikula wrote: >On Sat, 13 Feb 2021, Lucas De Marchi <lucas.demarchi@intel.com> wrote: >> On intel_ddi_init() we already check VBT if the port supports HDMI/DP >> and bail out otherwise. Instad of checking if a single port is present >> using VBT in intel_display.c, move the stronger check to >> intel_ddi_init() and return early in case it's not supported. There >> would be no way intel_bios_* would report support for hdmi/dp if the >> port isn't present so this should cause no regressions for other >> platforms. > >Sorry, but this will regress machines that have no VBT. I missed that init_vbt_missing_defaults() also sets the supports_*. > >I've been thinking about creating fake child devices for that case to >reduce the exceptions. Adding a fake child would indeed be a good option. Are you going to implement that soon or should I? thanks Lucas De Marchi > >BR, >Jani. > > > >> >> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> >> --- >> drivers/gpu/drm/i915/display/intel_ddi.c | 7 +++++++ >> drivers/gpu/drm/i915/display/intel_display.c | 14 ++++++-------- >> 2 files changed, 13 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c >> index 3b97c0091812..1235be0ba5d1 100644 >> --- a/drivers/gpu/drm/i915/display/intel_ddi.c >> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c >> @@ -3972,6 +3972,13 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port) >> bool init_hdmi, init_dp; >> enum phy phy = intel_port_to_phy(dev_priv, port); >> >> + if (!intel_bios_is_port_present(dev_priv, port)) { >> + drm_dbg_kms(&dev_priv->drm, >> + "VBT says port %c is not present, respect it\n", >> + port_name(port)); >> + return; >> + } >> + >> /* >> * On platforms with HTI (aka HDPORT), if it's enabled at boot it may >> * have taken over some of the PHYs and made them unavailable to the >> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c >> index 23ec68498800..7aaf7a29d493 100644 >> --- a/drivers/gpu/drm/i915/display/intel_display.c >> +++ b/drivers/gpu/drm/i915/display/intel_display.c >> @@ -11904,13 +11904,13 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) >> intel_ddi_init(dev_priv, PORT_C); >> intel_ddi_init(dev_priv, PORT_D); >> intel_ddi_init(dev_priv, PORT_E); >> + >> /* >> - * On some ICL SKUs port F is not present. No strap bits for >> - * this, so rely on VBT. >> - * Work around broken VBTs on SKUs known to have no port F. >> + * On some ICL SKUs port F is not present, but broken VBTs mark >> + * the port as present. Only try to initialize port F for the >> + * SKUs that may actually have it. >> */ >> - if (IS_ICL_WITH_PORT_F(dev_priv) && >> - intel_bios_is_port_present(dev_priv, PORT_F)) >> + if (IS_ICL_WITH_PORT_F(dev_priv)) >> intel_ddi_init(dev_priv, PORT_F); >> >> icl_dsi_init(dev_priv); >> @@ -11964,10 +11964,8 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) >> /* >> * On SKL we don't have a way to detect DDI-E so we rely on VBT. >> */ >> - if (IS_GEN9_BC(dev_priv) && >> - intel_bios_is_port_present(dev_priv, PORT_E)) >> + if (IS_GEN9_BC(dev_priv)) >> intel_ddi_init(dev_priv, PORT_E); >> - >> } else if (HAS_PCH_SPLIT(dev_priv)) { >> int found; > >-- >Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915/display: move vbt check to intel_ddi_init() 2021-02-15 16:26 ` Lucas De Marchi @ 2021-02-16 19:50 ` Jani Nikula 2021-03-18 19:41 ` Lucas De Marchi 0 siblings, 1 reply; 12+ messages in thread From: Jani Nikula @ 2021-02-16 19:50 UTC (permalink / raw) To: Lucas De Marchi; +Cc: intel-gfx On Mon, 15 Feb 2021, Lucas De Marchi <lucas.demarchi@intel.com> wrote: > On Mon, Feb 15, 2021 at 12:35:50PM +0200, Jani Nikula wrote: >>On Sat, 13 Feb 2021, Lucas De Marchi <lucas.demarchi@intel.com> wrote: >>> On intel_ddi_init() we already check VBT if the port supports HDMI/DP >>> and bail out otherwise. Instad of checking if a single port is present >>> using VBT in intel_display.c, move the stronger check to >>> intel_ddi_init() and return early in case it's not supported. There >>> would be no way intel_bios_* would report support for hdmi/dp if the >>> port isn't present so this should cause no regressions for other >>> platforms. >> >>Sorry, but this will regress machines that have no VBT. > > I missed that init_vbt_missing_defaults() also sets > the supports_*. > >> >>I've been thinking about creating fake child devices for that case to >>reduce the exceptions. > > Adding a fake child would indeed be a good option. Are you going to > implement that soon or should I? I'm working on it. Got a bit carried away with what I've had in mind for ages regarding some other refactoring (e.g. getting rid of i915->vbt.ddi_port_info[] altogether in order to bring pre- and post-ddi platforms closer together). I'll try to get a smaller set ready first. BR, Jani. > > thanks > Lucas De Marchi > >> >>BR, >>Jani. >> >> >> >>> >>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> >>> --- >>> drivers/gpu/drm/i915/display/intel_ddi.c | 7 +++++++ >>> drivers/gpu/drm/i915/display/intel_display.c | 14 ++++++-------- >>> 2 files changed, 13 insertions(+), 8 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c >>> index 3b97c0091812..1235be0ba5d1 100644 >>> --- a/drivers/gpu/drm/i915/display/intel_ddi.c >>> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c >>> @@ -3972,6 +3972,13 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port) >>> bool init_hdmi, init_dp; >>> enum phy phy = intel_port_to_phy(dev_priv, port); >>> >>> + if (!intel_bios_is_port_present(dev_priv, port)) { >>> + drm_dbg_kms(&dev_priv->drm, >>> + "VBT says port %c is not present, respect it\n", >>> + port_name(port)); >>> + return; >>> + } >>> + >>> /* >>> * On platforms with HTI (aka HDPORT), if it's enabled at boot it may >>> * have taken over some of the PHYs and made them unavailable to the >>> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c >>> index 23ec68498800..7aaf7a29d493 100644 >>> --- a/drivers/gpu/drm/i915/display/intel_display.c >>> +++ b/drivers/gpu/drm/i915/display/intel_display.c >>> @@ -11904,13 +11904,13 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) >>> intel_ddi_init(dev_priv, PORT_C); >>> intel_ddi_init(dev_priv, PORT_D); >>> intel_ddi_init(dev_priv, PORT_E); >>> + >>> /* >>> - * On some ICL SKUs port F is not present. No strap bits for >>> - * this, so rely on VBT. >>> - * Work around broken VBTs on SKUs known to have no port F. >>> + * On some ICL SKUs port F is not present, but broken VBTs mark >>> + * the port as present. Only try to initialize port F for the >>> + * SKUs that may actually have it. >>> */ >>> - if (IS_ICL_WITH_PORT_F(dev_priv) && >>> - intel_bios_is_port_present(dev_priv, PORT_F)) >>> + if (IS_ICL_WITH_PORT_F(dev_priv)) >>> intel_ddi_init(dev_priv, PORT_F); >>> >>> icl_dsi_init(dev_priv); >>> @@ -11964,10 +11964,8 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) >>> /* >>> * On SKL we don't have a way to detect DDI-E so we rely on VBT. >>> */ >>> - if (IS_GEN9_BC(dev_priv) && >>> - intel_bios_is_port_present(dev_priv, PORT_E)) >>> + if (IS_GEN9_BC(dev_priv)) >>> intel_ddi_init(dev_priv, PORT_E); >>> - >>> } else if (HAS_PCH_SPLIT(dev_priv)) { >>> int found; >> >>-- >>Jani Nikula, Intel Open Source Graphics Center -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915/display: move vbt check to intel_ddi_init() 2021-02-16 19:50 ` Jani Nikula @ 2021-03-18 19:41 ` Lucas De Marchi 0 siblings, 0 replies; 12+ messages in thread From: Lucas De Marchi @ 2021-03-18 19:41 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx On Tue, Feb 16, 2021 at 09:50:03PM +0200, Jani Nikula wrote: >On Mon, 15 Feb 2021, Lucas De Marchi <lucas.demarchi@intel.com> wrote: >> On Mon, Feb 15, 2021 at 12:35:50PM +0200, Jani Nikula wrote: >>>On Sat, 13 Feb 2021, Lucas De Marchi <lucas.demarchi@intel.com> wrote: >>>> On intel_ddi_init() we already check VBT if the port supports HDMI/DP >>>> and bail out otherwise. Instad of checking if a single port is present >>>> using VBT in intel_display.c, move the stronger check to >>>> intel_ddi_init() and return early in case it's not supported. There >>>> would be no way intel_bios_* would report support for hdmi/dp if the >>>> port isn't present so this should cause no regressions for other >>>> platforms. >>> >>>Sorry, but this will regress machines that have no VBT. >> >> I missed that init_vbt_missing_defaults() also sets >> the supports_*. >> >>> >>>I've been thinking about creating fake child devices for that case to >>>reduce the exceptions. >> >> Adding a fake child would indeed be a good option. Are you going to >> implement that soon or should I? > >I'm working on it. Got a bit carried away with what I've had in mind for >ages regarding some other refactoring (e.g. getting rid of >i915->vbt.ddi_port_info[] altogether in order to bring pre- and post-ddi >platforms closer together). I'll try to get a smaller set ready first. now that those patches are applied, can you take a look in these? thanks Lucas De Marchi > >BR, >Jani. > > >> >> thanks >> Lucas De Marchi >> >>> >>>BR, >>>Jani. >>> >>> >>> >>>> >>>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> >>>> --- >>>> drivers/gpu/drm/i915/display/intel_ddi.c | 7 +++++++ >>>> drivers/gpu/drm/i915/display/intel_display.c | 14 ++++++-------- >>>> 2 files changed, 13 insertions(+), 8 deletions(-) >>>> >>>> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c >>>> index 3b97c0091812..1235be0ba5d1 100644 >>>> --- a/drivers/gpu/drm/i915/display/intel_ddi.c >>>> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c >>>> @@ -3972,6 +3972,13 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port) >>>> bool init_hdmi, init_dp; >>>> enum phy phy = intel_port_to_phy(dev_priv, port); >>>> >>>> + if (!intel_bios_is_port_present(dev_priv, port)) { >>>> + drm_dbg_kms(&dev_priv->drm, >>>> + "VBT says port %c is not present, respect it\n", >>>> + port_name(port)); >>>> + return; >>>> + } >>>> + >>>> /* >>>> * On platforms with HTI (aka HDPORT), if it's enabled at boot it may >>>> * have taken over some of the PHYs and made them unavailable to the >>>> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c >>>> index 23ec68498800..7aaf7a29d493 100644 >>>> --- a/drivers/gpu/drm/i915/display/intel_display.c >>>> +++ b/drivers/gpu/drm/i915/display/intel_display.c >>>> @@ -11904,13 +11904,13 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) >>>> intel_ddi_init(dev_priv, PORT_C); >>>> intel_ddi_init(dev_priv, PORT_D); >>>> intel_ddi_init(dev_priv, PORT_E); >>>> + >>>> /* >>>> - * On some ICL SKUs port F is not present. No strap bits for >>>> - * this, so rely on VBT. >>>> - * Work around broken VBTs on SKUs known to have no port F. >>>> + * On some ICL SKUs port F is not present, but broken VBTs mark >>>> + * the port as present. Only try to initialize port F for the >>>> + * SKUs that may actually have it. >>>> */ >>>> - if (IS_ICL_WITH_PORT_F(dev_priv) && >>>> - intel_bios_is_port_present(dev_priv, PORT_F)) >>>> + if (IS_ICL_WITH_PORT_F(dev_priv)) >>>> intel_ddi_init(dev_priv, PORT_F); >>>> >>>> icl_dsi_init(dev_priv); >>>> @@ -11964,10 +11964,8 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) >>>> /* >>>> * On SKL we don't have a way to detect DDI-E so we rely on VBT. >>>> */ >>>> - if (IS_GEN9_BC(dev_priv) && >>>> - intel_bios_is_port_present(dev_priv, PORT_E)) >>>> + if (IS_GEN9_BC(dev_priv)) >>>> intel_ddi_init(dev_priv, PORT_E); >>>> - >>>> } else if (HAS_PCH_SPLIT(dev_priv)) { >>>> int found; >>> >>>-- >>>Jani Nikula, Intel Open Source Graphics Center > >-- >Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915/display: move vbt check to intel_ddi_init() 2021-02-13 19:05 ` [Intel-gfx] [PATCH 1/3] drm/i915/display: move vbt check to intel_ddi_init() Lucas De Marchi 2021-02-15 10:35 ` Jani Nikula @ 2021-03-19 11:38 ` Jani Nikula 1 sibling, 0 replies; 12+ messages in thread From: Jani Nikula @ 2021-03-19 11:38 UTC (permalink / raw) To: Lucas De Marchi, intel-gfx On Sat, 13 Feb 2021, Lucas De Marchi <lucas.demarchi@intel.com> wrote: > On intel_ddi_init() we already check VBT if the port supports HDMI/DP > and bail out otherwise. Instad of checking if a single port is present > using VBT in intel_display.c, move the stronger check to > intel_ddi_init() and return early in case it's not supported. There > would be no way intel_bios_* would report support for hdmi/dp if the > port isn't present so this should cause no regressions for other > platforms. > > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 7 +++++++ > drivers/gpu/drm/i915/display/intel_display.c | 14 ++++++-------- > 2 files changed, 13 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c > index 3b97c0091812..1235be0ba5d1 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -3972,6 +3972,13 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port) > bool init_hdmi, init_dp; > enum phy phy = intel_port_to_phy(dev_priv, port); > > + if (!intel_bios_is_port_present(dev_priv, port)) { > + drm_dbg_kms(&dev_priv->drm, > + "VBT says port %c is not present, respect it\n", > + port_name(port)); > + return; > + } > + We now have this: devdata = intel_bios_encoder_data_lookup(dev_priv, port); if (!devdata) { drm_dbg_kms(&dev_priv->drm, "VBT says port %c is not present\n", port_name(port)); return; } added in 45c0673aac97 ("drm/i915/bios: start using the intel_bios_encoder_data directly"). With that, the below hunks are Reviewed-by: Jani Nikula <jani.nikula@intel.com> > /* > * On platforms with HTI (aka HDPORT), if it's enabled at boot it may > * have taken over some of the PHYs and made them unavailable to the > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index 23ec68498800..7aaf7a29d493 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -11904,13 +11904,13 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) > intel_ddi_init(dev_priv, PORT_C); > intel_ddi_init(dev_priv, PORT_D); > intel_ddi_init(dev_priv, PORT_E); > + > /* > - * On some ICL SKUs port F is not present. No strap bits for > - * this, so rely on VBT. > - * Work around broken VBTs on SKUs known to have no port F. > + * On some ICL SKUs port F is not present, but broken VBTs mark > + * the port as present. Only try to initialize port F for the > + * SKUs that may actually have it. > */ > - if (IS_ICL_WITH_PORT_F(dev_priv) && > - intel_bios_is_port_present(dev_priv, PORT_F)) > + if (IS_ICL_WITH_PORT_F(dev_priv)) > intel_ddi_init(dev_priv, PORT_F); > > icl_dsi_init(dev_priv); > @@ -11964,10 +11964,8 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) > /* > * On SKL we don't have a way to detect DDI-E so we rely on VBT. > */ > - if (IS_GEN9_BC(dev_priv) && > - intel_bios_is_port_present(dev_priv, PORT_E)) > + if (IS_GEN9_BC(dev_priv)) > intel_ddi_init(dev_priv, PORT_E); > - > } else if (HAS_PCH_SPLIT(dev_priv)) { > int found; -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH 2/3] drm/i915/display: remove FIXME comment for intended feature 2021-02-13 19:05 [Intel-gfx] [PATCH 0/3] Simplify intel_setup_outputs() Lucas De Marchi 2021-02-13 19:05 ` [Intel-gfx] [PATCH 1/3] drm/i915/display: move vbt check to intel_ddi_init() Lucas De Marchi @ 2021-02-13 19:05 ` Lucas De Marchi 2021-02-13 19:05 ` [Intel-gfx] [PATCH 3/3] drm/i915/display: remove strap checks from gen 9 Lucas De Marchi ` (2 subsequent siblings) 4 siblings, 0 replies; 12+ messages in thread From: Lucas De Marchi @ 2021-02-13 19:05 UTC (permalink / raw) To: intel-gfx Direction on gen >= 9 was to stop using straps and rely on VBT indicating if the port is present or not. Remove FIXME comment since this will never be "fixed". Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> --- drivers/gpu/drm/i915/display/intel_display.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 7aaf7a29d493..c1ec03c726c9 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -11915,15 +11915,9 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) icl_dsi_init(dev_priv); } else if (IS_GEN9_LP(dev_priv)) { - /* - * FIXME: Broxton doesn't support port detection via the - * DDI_BUF_CTL_A or SFUSE_STRAP registers, find another way to - * detect the ports. - */ intel_ddi_init(dev_priv, PORT_A); intel_ddi_init(dev_priv, PORT_B); intel_ddi_init(dev_priv, PORT_C); - vlv_dsi_init(dev_priv); } else if (HAS_DDI(dev_priv)) { int found; -- 2.29.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH 3/3] drm/i915/display: remove strap checks from gen 9 2021-02-13 19:05 [Intel-gfx] [PATCH 0/3] Simplify intel_setup_outputs() Lucas De Marchi 2021-02-13 19:05 ` [Intel-gfx] [PATCH 1/3] drm/i915/display: move vbt check to intel_ddi_init() Lucas De Marchi 2021-02-13 19:05 ` [Intel-gfx] [PATCH 2/3] drm/i915/display: remove FIXME comment for intended feature Lucas De Marchi @ 2021-02-13 19:05 ` Lucas De Marchi 2021-02-13 19:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Simplify intel_setup_outputs() Patchwork 2021-02-13 21:02 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 4 siblings, 0 replies; 12+ messages in thread From: Lucas De Marchi @ 2021-02-13 19:05 UTC (permalink / raw) To: intel-gfx Direction on gen9+ was to stop reading the straps and only rely on the VBT for marking the port presence. This happened while dealing with WaIgnoreDDIAStrap and instead of using it as a WA, it should now be the normal flow. See commit 885d3e5b6f08 ("drm/i915/display: fix comment on skl straps"). For gen 10 it's hard to say if this will work or not since I can't test it, so leave it with the same behavior as before. For PCH_TGP we should still rely on the VBT to make ports E and F not available. Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> --- drivers/gpu/drm/i915/display/intel_display.c | 36 ++++++-------------- 1 file changed, 11 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index c1ec03c726c9..21087169f63a 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -11919,34 +11919,25 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) intel_ddi_init(dev_priv, PORT_B); intel_ddi_init(dev_priv, PORT_C); vlv_dsi_init(dev_priv); + } else if (IS_GEN(dev_priv, 9)) { + intel_ddi_init(dev_priv, PORT_A); + intel_ddi_init(dev_priv, PORT_B); + intel_ddi_init(dev_priv, PORT_C); + intel_ddi_init(dev_priv, PORT_D); + intel_ddi_init(dev_priv, PORT_E); + intel_ddi_init(dev_priv, PORT_F); } else if (HAS_DDI(dev_priv)) { - int found; + u32 found; if (intel_ddi_crt_present(dev_priv)) intel_crt_init(dev_priv); - /* - * Haswell uses DDI functions to detect digital outputs. - * On SKL pre-D0 the strap isn't connected. Later SKUs may or - * may not have it - it was supposed to be fixed by the same - * time we stopped using straps. Assume it's there. - */ + /* Haswell uses DDI functions to detect digital outputs. */ found = intel_de_read(dev_priv, DDI_BUF_CTL(PORT_A)) & DDI_INIT_DISPLAY_DETECTED; - /* WaIgnoreDDIAStrap: skl */ - if (found || IS_GEN9_BC(dev_priv)) + if (found) intel_ddi_init(dev_priv, PORT_A); - /* DDI B, C, D, and F detection is indicated by the SFUSE_STRAP - * register */ - if (HAS_PCH_TGP(dev_priv)) { - /* W/A due to lack of STRAP config on TGP PCH*/ - found = (SFUSE_STRAP_DDIB_DETECTED | - SFUSE_STRAP_DDIC_DETECTED | - SFUSE_STRAP_DDID_DETECTED); - } else { - found = intel_de_read(dev_priv, SFUSE_STRAP); - } - + found = intel_de_read(dev_priv, SFUSE_STRAP); if (found & SFUSE_STRAP_DDIB_DETECTED) intel_ddi_init(dev_priv, PORT_B); if (found & SFUSE_STRAP_DDIC_DETECTED) @@ -11955,11 +11946,6 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) intel_ddi_init(dev_priv, PORT_D); if (found & SFUSE_STRAP_DDIF_DETECTED) intel_ddi_init(dev_priv, PORT_F); - /* - * On SKL we don't have a way to detect DDI-E so we rely on VBT. - */ - if (IS_GEN9_BC(dev_priv)) - intel_ddi_init(dev_priv, PORT_E); } else if (HAS_PCH_SPLIT(dev_priv)) { int found; -- 2.29.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Simplify intel_setup_outputs() 2021-02-13 19:05 [Intel-gfx] [PATCH 0/3] Simplify intel_setup_outputs() Lucas De Marchi ` (2 preceding siblings ...) 2021-02-13 19:05 ` [Intel-gfx] [PATCH 3/3] drm/i915/display: remove strap checks from gen 9 Lucas De Marchi @ 2021-02-13 19:53 ` Patchwork 2021-02-13 21:02 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 4 siblings, 0 replies; 12+ messages in thread From: Patchwork @ 2021-02-13 19:53 UTC (permalink / raw) To: Lucas De Marchi; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 5550 bytes --] == Series Details == Series: Simplify intel_setup_outputs() URL : https://patchwork.freedesktop.org/series/87068/ State : success == Summary == CI Bug Log - changes from CI_DRM_9773 -> Patchwork_19678 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/index.html Known issues ------------ Here are the changes found in Patchwork_19678 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_cs_nop@sync-compute0: - fi-kbl-r: NOTRUN -> [SKIP][1] ([fdo#109271]) +20 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/fi-kbl-r/igt@amdgpu/amd_cs_nop@sync-compute0.html * igt@gem_exec_fence@basic-busy@bcs0: - fi-apl-guc: NOTRUN -> [SKIP][2] ([fdo#109271]) +1 similar issue [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/fi-apl-guc/igt@gem_exec_fence@basic-busy@bcs0.html * igt@gem_huc_copy@huc-copy: - fi-kbl-r: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/fi-kbl-r/igt@gem_huc_copy@huc-copy.html * igt@i915_hangman@error-state-basic: - fi-apl-guc: NOTRUN -> [DMESG-WARN][4] ([i915#1610]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/fi-apl-guc/igt@i915_hangman@error-state-basic.html * igt@i915_pm_rpm@module-reload: - fi-byt-j1900: [PASS][5] -> [INCOMPLETE][6] ([i915#142] / [i915#2405]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html * igt@kms_chamelium@hdmi-edid-read: - fi-kbl-r: NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827]) +8 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/fi-kbl-r/igt@kms_chamelium@hdmi-edid-read.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - fi-kbl-r: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#533]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/fi-kbl-r/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html * igt@prime_self_import@basic-with_one_bo_two_files: - fi-tgl-y: [PASS][9] -> [DMESG-WARN][10] ([i915#402]) +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html * igt@runner@aborted: - fi-icl-u2: NOTRUN -> [FAIL][11] ([i915#1814] / [i915#2724]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/fi-icl-u2/igt@runner@aborted.html - fi-apl-guc: NOTRUN -> [FAIL][12] ([i915#2426]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/fi-apl-guc/igt@runner@aborted.html - fi-byt-j1900: NOTRUN -> [FAIL][13] ([i915#1814] / [i915#2505]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/fi-byt-j1900/igt@runner@aborted.html #### Possible fixes #### * igt@prime_self_import@basic-with_two_bos: - fi-tgl-y: [DMESG-WARN][14] ([i915#402]) -> [PASS][15] +1 similar issue [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#142]: https://gitlab.freedesktop.org/drm/intel/issues/142 [i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610 [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405 [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426 [i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505 [i915#2724]: https://gitlab.freedesktop.org/drm/intel/issues/2724 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 Participating hosts (44 -> 38) ------------------------------ Additional (1): fi-apl-guc Missing (7): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-kbl-7500u fi-ctg-p8600 fi-ehl-2 fi-bdw-samus Build changes ------------- * Linux: CI_DRM_9773 -> Patchwork_19678 CI-20190529: 20190529 CI_DRM_9773: 8db63ad78d8b09aeae480bef5b942690e26ffa39 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6003: 627cc5353535d61fa33c5f7ff7e64f154c84f10a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_19678: 30873c275bddebdad62e290732a9bc91cd834ed3 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 30873c275bdd drm/i915/display: remove strap checks from gen 9 963ac3f1f37b drm/i915/display: remove FIXME comment for intended feature 34d78b85f3d4 drm/i915/display: move vbt check to intel_ddi_init() == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/index.html [-- Attachment #1.2: Type: text/html, Size: 6839 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for Simplify intel_setup_outputs() 2021-02-13 19:05 [Intel-gfx] [PATCH 0/3] Simplify intel_setup_outputs() Lucas De Marchi ` (3 preceding siblings ...) 2021-02-13 19:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Simplify intel_setup_outputs() Patchwork @ 2021-02-13 21:02 ` Patchwork 4 siblings, 0 replies; 12+ messages in thread From: Patchwork @ 2021-02-13 21:02 UTC (permalink / raw) To: Lucas De Marchi; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 30253 bytes --] == Series Details == Series: Simplify intel_setup_outputs() URL : https://patchwork.freedesktop.org/series/87068/ State : success == Summary == CI Bug Log - changes from CI_DRM_9773_full -> Patchwork_19678_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_19678_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_isolation@preservation-s3@bcs0: - shard-apl: NOTRUN -> [DMESG-WARN][1] ([i915#180]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-apl1/igt@gem_ctx_isolation@preservation-s3@bcs0.html * igt@gem_exec_fair@basic-deadline: - shard-skl: NOTRUN -> [FAIL][2] ([i915#2846]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl7/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-iclb: [PASS][3] -> [FAIL][4] ([i915#2842]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-iclb2/igt@gem_exec_fair@basic-none-share@rcs0.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb2/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-none@vcs0: - shard-kbl: [PASS][5] -> [FAIL][6] ([i915#2842]) +2 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-kbl6/igt@gem_exec_fair@basic-none@vcs0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-kbl2/igt@gem_exec_fair@basic-none@vcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-iclb: [PASS][7] -> [FAIL][8] ([i915#2849]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_exec_params@secure-non-master: - shard-tglb: NOTRUN -> [SKIP][9] ([fdo#112283]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-tglb2/igt@gem_exec_params@secure-non-master.html - shard-iclb: NOTRUN -> [SKIP][10] ([fdo#112283]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb3/igt@gem_exec_params@secure-non-master.html * igt@gem_exec_suspend@basic-s3: - shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) +2 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-kbl3/igt@gem_exec_suspend@basic-s3.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-kbl1/igt@gem_exec_suspend@basic-s3.html * igt@gem_pwrite@basic-exhaustion: - shard-kbl: NOTRUN -> [WARN][13] ([i915#2658]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-kbl2/igt@gem_pwrite@basic-exhaustion.html * igt@gen7_exec_parse@bitmasks: - shard-iclb: NOTRUN -> [SKIP][14] ([fdo#109289]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb3/igt@gen7_exec_parse@bitmasks.html * igt@gen9_exec_parse@secure-batches: - shard-iclb: NOTRUN -> [SKIP][15] ([fdo#112306]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb3/igt@gen9_exec_parse@secure-batches.html - shard-tglb: NOTRUN -> [SKIP][16] ([fdo#112306]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-tglb2/igt@gen9_exec_parse@secure-batches.html * igt@i915_pm_rc6_residency@rc6-idle: - shard-iclb: NOTRUN -> [WARN][17] ([i915#1804] / [i915#2684]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb3/igt@i915_pm_rc6_residency@rc6-idle.html * igt@i915_selftest@mock@requests: - shard-skl: [PASS][18] -> [INCOMPLETE][19] ([i915#198]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-skl3/igt@i915_selftest@mock@requests.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl5/igt@i915_selftest@mock@requests.html * igt@kms_big_fb@x-tiled-16bpp-rotate-90: - shard-iclb: NOTRUN -> [SKIP][20] ([fdo#110725] / [fdo#111614]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb3/igt@kms_big_fb@x-tiled-16bpp-rotate-90.html * igt@kms_big_fb@yf-tiled-8bpp-rotate-0: - shard-iclb: NOTRUN -> [SKIP][21] ([fdo#110723]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb3/igt@kms_big_fb@yf-tiled-8bpp-rotate-0.html - shard-tglb: NOTRUN -> [SKIP][22] ([fdo#111615]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-tglb2/igt@kms_big_fb@yf-tiled-8bpp-rotate-0.html * igt@kms_chamelium@dp-mode-timings: - shard-apl: NOTRUN -> [SKIP][23] ([fdo#109271] / [fdo#111827]) +4 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-apl6/igt@kms_chamelium@dp-mode-timings.html * igt@kms_chamelium@vga-hpd-fast: - shard-skl: NOTRUN -> [SKIP][24] ([fdo#109271] / [fdo#111827]) +3 similar issues [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl7/igt@kms_chamelium@vga-hpd-fast.html * igt@kms_color_chamelium@pipe-a-ctm-green-to-red: - shard-tglb: NOTRUN -> [SKIP][25] ([fdo#109284] / [fdo#111827]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-tglb2/igt@kms_color_chamelium@pipe-a-ctm-green-to-red.html * igt@kms_color_chamelium@pipe-b-ctm-red-to-blue: - shard-iclb: NOTRUN -> [SKIP][26] ([fdo#109284] / [fdo#111827]) +2 similar issues [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb3/igt@kms_color_chamelium@pipe-b-ctm-red-to-blue.html * igt@kms_color_chamelium@pipe-d-ctm-green-to-red: - shard-kbl: NOTRUN -> [SKIP][27] ([fdo#109271] / [fdo#111827]) +6 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-kbl6/igt@kms_color_chamelium@pipe-d-ctm-green-to-red.html * igt@kms_color_chamelium@pipe-d-ctm-negative: - shard-iclb: NOTRUN -> [SKIP][28] ([fdo#109278] / [fdo#109284] / [fdo#111827]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb3/igt@kms_color_chamelium@pipe-d-ctm-negative.html * igt@kms_content_protection@legacy: - shard-iclb: NOTRUN -> [SKIP][29] ([fdo#109300] / [fdo#111066]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb3/igt@kms_content_protection@legacy.html - shard-tglb: NOTRUN -> [SKIP][30] ([fdo#111828]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-tglb2/igt@kms_content_protection@legacy.html * igt@kms_content_protection@uevent: - shard-apl: NOTRUN -> [FAIL][31] ([i915#2105]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-apl6/igt@kms_content_protection@uevent.html * igt@kms_cursor_crc@pipe-b-cursor-128x42-onscreen: - shard-skl: [PASS][32] -> [FAIL][33] ([i915#54]) +6 similar issues [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-skl1/igt@kms_cursor_crc@pipe-b-cursor-128x42-onscreen.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-128x42-onscreen.html * igt@kms_cursor_crc@pipe-c-cursor-512x512-random: - shard-tglb: NOTRUN -> [SKIP][34] ([fdo#109279]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-tglb2/igt@kms_cursor_crc@pipe-c-cursor-512x512-random.html - shard-iclb: NOTRUN -> [SKIP][35] ([fdo#109278] / [fdo#109279]) +2 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb3/igt@kms_cursor_crc@pipe-c-cursor-512x512-random.html * igt@kms_cursor_legacy@cursora-vs-flipb-toggle: - shard-iclb: NOTRUN -> [SKIP][36] ([fdo#109274] / [fdo#109278]) +3 similar issues [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb3/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic: - shard-skl: [PASS][37] -> [FAIL][38] ([i915#2346]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html * igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic: - shard-skl: NOTRUN -> [FAIL][39] ([i915#2346]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html * igt@kms_flip@2x-flip-vs-panning: - shard-iclb: NOTRUN -> [SKIP][40] ([fdo#109274]) +1 similar issue [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb3/igt@kms_flip@2x-flip-vs-panning.html * igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset-interruptible: - shard-tglb: NOTRUN -> [SKIP][41] ([fdo#111825]) +2 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-tglb2/igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset-interruptible.html * igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1: - shard-skl: [PASS][42] -> [FAIL][43] ([i915#2122]) +2 similar issues [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-skl9/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl1/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs: - shard-kbl: NOTRUN -> [FAIL][44] ([i915#2641]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-kbl6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile: - shard-kbl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#2642]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-kbl2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile: - shard-apl: NOTRUN -> [FAIL][46] ([i915#2641]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-apl8/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs: - shard-apl: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#2672]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-apl6/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html * igt@kms_force_connector_basic@force-load-detect: - shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109285]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb3/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt: - shard-skl: NOTRUN -> [SKIP][49] ([fdo#109271]) +32 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-blt: - shard-iclb: NOTRUN -> [SKIP][50] ([fdo#109280]) +6 similar issues [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-blt.html * igt@kms_hdr@bpc-switch: - shard-skl: NOTRUN -> [FAIL][51] ([i915#1188]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl6/igt@kms_hdr@bpc-switch.html * igt@kms_hdr@static-swap: - shard-iclb: NOTRUN -> [SKIP][52] ([i915#1187]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb3/igt@kms_hdr@static-swap.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d: - shard-skl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#533]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html * igt@kms_plane_alpha_blend@pipe-b-alpha-7efc: - shard-kbl: NOTRUN -> [FAIL][54] ([fdo#108145] / [i915#265]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-kbl2/igt@kms_plane_alpha_blend@pipe-b-alpha-7efc.html * igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb: - shard-apl: NOTRUN -> [FAIL][55] ([i915#265]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-apl1/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-d-constant-alpha-min: - shard-iclb: NOTRUN -> [SKIP][56] ([fdo#109278]) +7 similar issues [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb3/igt@kms_plane_alpha_blend@pipe-d-constant-alpha-min.html * igt@kms_plane_cursor@pipe-d-viewport-size-128: - shard-apl: NOTRUN -> [SKIP][57] ([fdo#109271]) +35 similar issues [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-apl6/igt@kms_plane_cursor@pipe-d-viewport-size-128.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4: - shard-apl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#658]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-apl6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1: - shard-skl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#658]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html - shard-kbl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#658]) +1 similar issue [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-kbl6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4: - shard-tglb: NOTRUN -> [SKIP][61] ([i915#2920]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-tglb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5: - shard-iclb: NOTRUN -> [SKIP][62] ([i915#658]) +1 similar issue [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html * igt@kms_psr@psr2_dpms: - shard-iclb: [PASS][63] -> [SKIP][64] ([fdo#109441]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-iclb2/igt@kms_psr@psr2_dpms.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb7/igt@kms_psr@psr2_dpms.html * igt@nouveau_crc@pipe-d-source-rg: - shard-iclb: NOTRUN -> [SKIP][65] ([fdo#109278] / [i915#2530]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb3/igt@nouveau_crc@pipe-d-source-rg.html * igt@prime_nv_pcopy@test1_macro: - shard-iclb: NOTRUN -> [SKIP][66] ([fdo#109291]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb3/igt@prime_nv_pcopy@test1_macro.html * igt@sysfs_clients@recycle: - shard-tglb: [PASS][67] -> [FAIL][68] ([i915#3028]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-tglb7/igt@sysfs_clients@recycle.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-tglb7/igt@sysfs_clients@recycle.html * igt@tools_test@sysfs_l3_parity: - shard-kbl: NOTRUN -> [SKIP][69] ([fdo#109271]) +62 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-kbl6/igt@tools_test@sysfs_l3_parity.html #### Possible fixes #### * igt@gem_ctx_persistence@close-replace-race: - shard-glk: [TIMEOUT][70] ([i915#2918]) -> [PASS][71] [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-glk1/igt@gem_ctx_persistence@close-replace-race.html [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-glk4/igt@gem_ctx_persistence@close-replace-race.html * igt@gem_eio@unwedge-stress: - shard-iclb: [TIMEOUT][72] ([i915#1037] / [i915#2481]) -> [PASS][73] [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-iclb1/igt@gem_eio@unwedge-stress.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb1/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-tglb: [FAIL][74] ([i915#2842]) -> [PASS][75] +1 similar issue [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-tglb5/igt@gem_exec_fair@basic-pace-solo@rcs0.html [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-tglb5/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-iclb: [FAIL][76] ([i915#2842]) -> [PASS][77] +2 similar issues [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-iclb8/igt@gem_exec_fair@basic-pace@vcs0.html [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb7/igt@gem_exec_fair@basic-pace@vcs0.html - shard-glk: [FAIL][78] ([i915#2842]) -> [PASS][79] +1 similar issue [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-glk2/igt@gem_exec_fair@basic-pace@vcs0.html [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-glk7/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_exec_reloc@basic-many-active@rcs0: - shard-glk: [FAIL][80] ([i915#2389]) -> [PASS][81] [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-glk5/igt@gem_exec_reloc@basic-many-active@rcs0.html [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-glk5/igt@gem_exec_reloc@basic-many-active@rcs0.html * igt@gem_exec_schedule@u-fairslice@vcs1: - shard-tglb: [DMESG-WARN][82] ([i915#2803]) -> [PASS][83] [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-tglb6/igt@gem_exec_schedule@u-fairslice@vcs1.html [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-tglb2/igt@gem_exec_schedule@u-fairslice@vcs1.html * igt@gem_exec_schedule@u-fairslice@vecs0: - shard-skl: [DMESG-WARN][84] ([i915#1610] / [i915#2803]) -> [PASS][85] +1 similar issue [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-skl6/igt@gem_exec_schedule@u-fairslice@vecs0.html [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl3/igt@gem_exec_schedule@u-fairslice@vecs0.html * igt@gen9_exec_parse@allowed-single: - shard-skl: [DMESG-WARN][86] ([i915#1436] / [i915#716]) -> [PASS][87] [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-skl2/igt@gen9_exec_parse@allowed-single.html [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl7/igt@gen9_exec_parse@allowed-single.html * igt@i915_suspend@debugfs-reader: - shard-kbl: [DMESG-WARN][88] ([i915#180]) -> [PASS][89] +1 similar issue [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-kbl7/igt@i915_suspend@debugfs-reader.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-kbl2/igt@i915_suspend@debugfs-reader.html * igt@i915_suspend@sysfs-reader: - shard-apl: [DMESG-WARN][90] ([i915#180]) -> [PASS][91] +4 similar issues [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-apl6/igt@i915_suspend@sysfs-reader.html [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-apl8/igt@i915_suspend@sysfs-reader.html * igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen: - shard-skl: [FAIL][92] ([i915#54]) -> [PASS][93] +4 similar issues [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-skl9/igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen.html [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl1/igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen.html * igt@kms_cursor_legacy@flip-vs-cursor-toggle: - shard-skl: [FAIL][94] ([i915#2346]) -> [PASS][95] [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html * igt@kms_flip@flip-vs-dpms-off-vs-modeset-interruptible@a-edp1: - shard-skl: [DMESG-WARN][96] ([i915#1982]) -> [PASS][97] +1 similar issue [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-skl5/igt@kms_flip@flip-vs-dpms-off-vs-modeset-interruptible@a-edp1.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl4/igt@kms_flip@flip-vs-dpms-off-vs-modeset-interruptible@a-edp1.html * igt@kms_flip@plain-flip-ts-check@a-edp1: - shard-skl: [FAIL][98] ([i915#2122]) -> [PASS][99] [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-skl2/igt@kms_flip@plain-flip-ts-check@a-edp1.html [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl9/igt@kms_flip@plain-flip-ts-check@a-edp1.html * igt@kms_psr@psr2_cursor_render: - shard-iclb: [SKIP][100] ([fdo#109441]) -> [PASS][101] [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-iclb7/igt@kms_psr@psr2_cursor_render.html [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb2/igt@kms_psr@psr2_cursor_render.html * igt@sysfs_clients@split-10@bcs0: - shard-apl: [SKIP][102] ([fdo#109271] / [i915#3026]) -> [PASS][103] [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-apl3/igt@sysfs_clients@split-10@bcs0.html [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-apl8/igt@sysfs_clients@split-10@bcs0.html #### Warnings #### * igt@i915_pm_rc6_residency@rc6-fence: - shard-iclb: [WARN][104] ([i915#2681] / [i915#2684]) -> [WARN][105] ([i915#1804] / [i915#2684]) [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-iclb8/igt@i915_pm_rc6_residency@rc6-fence.html [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb7/igt@i915_pm_rc6_residency@rc6-fence.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [DMESG-WARN][106] ([i915#1226]) -> [SKIP][107] ([fdo#109349]) [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb7/igt@kms_dp_dsc@basic-dsc-enable-edp.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3: - shard-iclb: [SKIP][108] ([i915#2920]) -> [SKIP][109] ([i915#658]) [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3: - shard-iclb: [SKIP][110] ([i915#658]) -> [SKIP][111] ([i915#2920]) [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-iclb7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html * igt@runner@aborted: - shard-kbl: ([FAIL][112], [FAIL][113], [FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117]) ([i915#1814] / [i915#2295] / [i915#3002]) -> ([FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122], [FAIL][123]) ([i915#1814] / [i915#2295] / [i915#2505] / [i915#3002]) [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-kbl7/igt@runner@aborted.html [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-kbl2/igt@runner@aborted.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-kbl1/igt@runner@aborted.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-kbl1/igt@runner@aborted.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-kbl1/igt@runner@aborted.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-kbl3/igt@runner@aborted.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-kbl1/igt@runner@aborted.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-kbl6/igt@runner@aborted.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-kbl7/igt@runner@aborted.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-kbl1/igt@runner@aborted.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-kbl1/igt@runner@aborted.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-kbl1/igt@runner@aborted.html - shard-apl: ([FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130]) ([fdo#109271] / [i915#1814] / [i915#2295] / [i915#3002]) -> ([FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135]) ([i915#2295] / [i915#3002]) [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-apl7/igt@runner@aborted.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-apl1/igt@runner@aborted.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-apl7/igt@runner@aborted.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-apl2/igt@runner@aborted.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-apl6/igt@runner@aborted.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-apl2/igt@runner@aborted.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-apl4/igt@runner@aborted.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-apl6/igt@runner@aborted.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-apl1/igt@runner@aborted.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-apl1/igt@runner@aborted.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-apl3/igt@runner@aborted.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-apl2/igt@runner@aborted.html - shard-tglb: ([FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139]) ([i915#2295] / [i915#2426] / [i915#2667] / [i915#2803] / [i915#3002]) -> ([FAIL][140], [FAIL][141], [FAIL][142]) ([i915#2295] / [i915#2667] / [i915#3002]) [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-tglb6/igt@runner@aborted.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-tglb1/igt@runner@aborted.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-tglb2/igt@runner@aborted.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-tglb2/igt@runner@aborted.html [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-tglb3/igt@runner@aborted.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-tglb2/igt@runner@aborted.html [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-tglb3/igt@runner@aborted.html - shard-skl: ([FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148]) ([i915#1436] / [i915#2295] / [i915#2426] / [i915#3002]) -> ([FAIL][149], [FAIL][150], [FAIL][151], [FAIL][152]) ([i915#2029] / [i915#2295] / [i915#3002]) [143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-skl5/igt@runner@aborted.html [144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-skl1/igt@runner@aborted.html [145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-skl6/igt@runner@aborted.html [146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-skl2/igt@runner@aborted.html [147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-skl2/igt@runner@aborted.html [148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9773/shard-skl9/igt@runner@aborted.html [149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl3/igt@runner@aborted.html [150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl7/igt@runner@aborted.html [151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl2/igt@runner@aborted.html [152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/shard-skl7/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300 [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725 [fdo#111066]: https://bugs.freedesktop.org/show_bug.cgi?id=111066 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop. == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19678/index.html [-- Attachment #1.2: Type: text/html, Size: 34885 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH 0/3] Simplify intel_setup_outputs @ 2021-04-13 6:09 Lucas De Marchi 2021-04-13 6:09 ` [Intel-gfx] [PATCH 1/3] drm/i915/display: move vbt check to intel_ddi_init() Lucas De Marchi 0 siblings, 1 reply; 12+ messages in thread From: Lucas De Marchi @ 2021-04-13 6:09 UTC (permalink / raw) To: intel-gfx First and second patches should be straightforward. Third patch is a tentative simplification that may break things in the presence of broken VBTs, but I'm feeling confident. Lucas De Marchi (3): drm/i915/display: move vbt check to intel_ddi_init() drm/i915/display: remove FIXME comment for intended feature drm/i915/display: remove strap checks from gen 9 drivers/gpu/drm/i915/display/intel_display.c | 54 ++++++-------------- 1 file changed, 16 insertions(+), 38 deletions(-) -- 2.31.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH 1/3] drm/i915/display: move vbt check to intel_ddi_init() 2021-04-13 6:09 [Intel-gfx] [PATCH 0/3] Simplify intel_setup_outputs Lucas De Marchi @ 2021-04-13 6:09 ` Lucas De Marchi 0 siblings, 0 replies; 12+ messages in thread From: Lucas De Marchi @ 2021-04-13 6:09 UTC (permalink / raw) To: intel-gfx; +Cc: Jani Nikula Since commit 45c0673aac97 ("drm/i915/bios: start using the intel_bios_encoder_data directly") we lookup the devdata for each port in intel_ddi_init() and just return if the port is not present in VBT (or if we didn't create a fake devdata for it if VBT is not available). So in intel_display.c we don't have to check intel_bios_is_port_present(), just rely on the check in intel_ddi_init(). v2: Rebase 45c0673aac97 re-using that check in intel_ddi_init() instead of adding a new one. Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> Reviewed-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/display/intel_display.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 411b46c012f8..e9444e3aebc3 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -10868,13 +10868,13 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) intel_ddi_init(dev_priv, PORT_C); intel_ddi_init(dev_priv, PORT_D); intel_ddi_init(dev_priv, PORT_E); + /* - * On some ICL SKUs port F is not present. No strap bits for - * this, so rely on VBT. - * Work around broken VBTs on SKUs known to have no port F. + * On some ICL SKUs port F is not present, but broken VBTs mark + * the port as present. Only try to initialize port F for the + * SKUs that may actually have it. */ - if (IS_ICL_WITH_PORT_F(dev_priv) && - intel_bios_is_port_present(dev_priv, PORT_F)) + if (IS_ICL_WITH_PORT_F(dev_priv)) intel_ddi_init(dev_priv, PORT_F); icl_dsi_init(dev_priv); @@ -10928,10 +10928,8 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) /* * On SKL we don't have a way to detect DDI-E so we rely on VBT. */ - if (IS_DISPLAY_VER(dev_priv, 9) && - intel_bios_is_port_present(dev_priv, PORT_E)) + if (IS_DISPLAY_VER(dev_priv, 9) intel_ddi_init(dev_priv, PORT_E); - } else if (HAS_PCH_SPLIT(dev_priv)) { int found; -- 2.31.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-04-13 6:09 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-02-13 19:05 [Intel-gfx] [PATCH 0/3] Simplify intel_setup_outputs() Lucas De Marchi 2021-02-13 19:05 ` [Intel-gfx] [PATCH 1/3] drm/i915/display: move vbt check to intel_ddi_init() Lucas De Marchi 2021-02-15 10:35 ` Jani Nikula 2021-02-15 16:26 ` Lucas De Marchi 2021-02-16 19:50 ` Jani Nikula 2021-03-18 19:41 ` Lucas De Marchi 2021-03-19 11:38 ` Jani Nikula 2021-02-13 19:05 ` [Intel-gfx] [PATCH 2/3] drm/i915/display: remove FIXME comment for intended feature Lucas De Marchi 2021-02-13 19:05 ` [Intel-gfx] [PATCH 3/3] drm/i915/display: remove strap checks from gen 9 Lucas De Marchi 2021-02-13 19:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Simplify intel_setup_outputs() Patchwork 2021-02-13 21:02 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork -- strict thread matches above, loose matches on Subject: below -- 2021-04-13 6:09 [Intel-gfx] [PATCH 0/3] Simplify intel_setup_outputs Lucas De Marchi 2021-04-13 6:09 ` [Intel-gfx] [PATCH 1/3] drm/i915/display: move vbt check to intel_ddi_init() Lucas De Marchi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox