Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v6 0/3] drm/i915/selftests: fix stolen reset test races
@ 2026-11-18 13:02 Sebastian Brzezinka
  2026-11-18 13:02 ` [PATCH v6 1/3] drm/i915/selftests: Fix unlocked mm.stolen in reset selftest Sebastian Brzezinka
                   ` (5 more replies)
  0 siblings, 6 replies; 22+ messages in thread
From: Sebastian Brzezinka @ 2026-11-18 13:02 UTC (permalink / raw)
  To: intel-gfx
  Cc: andi.shyti, chris.p.wilson, krzysztof.karas, krzysztof.niemiec,
	Sebastian Brzezinka

The stolen reset selftests (igt_reset_device_stolen and
igt_reset_engines_stolen) poison the unused stolen pages, reset the GPU
and check that those pages did not change. This series fixes two races
in the test itself. Neither one is a GPU reset problem.

v5 -> v6:
- Split the series into 3 patches (Krzysztof)
- Drop the poisoned bitmap, it was redundant (Sashiko)
- Use raw_insert_page when available, like
  i915_vma_coredump_create() (Sashiko)
- Take error_mutex only around the sampling loops, not across the
  reset, to avoid a deadlock with the GuC CT worker (Sashiko)

v4 -> v5:
- Hold stolen_lock across the reset too
- Add a patch that takes ggtt->error_mutex in the test

Sebastian Brzezinka (3):
  drm/i915/selftests: Fix unlocked mm.stolen in reset selftest
  drm/i915/selftests: Limit stolen reset test to usable stolen
  drm/i915/selftests: take error_mutex in stolen reset test

 drivers/gpu/drm/i915/gt/selftest_reset.c | 52 ++++++++++++++++--------
 1 file changed, 34 insertions(+), 18 deletions(-)

-- 
2.56.1


^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2026-11-19 18:53 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 13:02 [PATCH v6 0/3] drm/i915/selftests: fix stolen reset test races Sebastian Brzezinka
2026-11-18 13:02 ` [PATCH v6 1/3] drm/i915/selftests: Fix unlocked mm.stolen in reset selftest Sebastian Brzezinka
2026-11-18 13:31   ` sashiko-bot
2026-11-18 15:23   ` Krzysztof Karas
2026-11-19 10:32     ` Sebastian Brzezinka
2026-11-19 14:48       ` Krzysztof Karas
2026-11-19 15:07   ` Krzysztof Niemiec
2026-11-18 13:02 ` [PATCH v6 2/3] drm/i915/selftests: Limit stolen reset test to usable stolen Sebastian Brzezinka
2026-11-18 13:09   ` sashiko-bot
2026-11-18 15:24   ` Krzysztof Karas
2026-11-19 15:12   ` Krzysztof Niemiec
2026-11-18 13:02 ` [PATCH v6 3/3] drm/i915/selftests: take error_mutex in stolen reset test Sebastian Brzezinka
2026-11-18 13:13   ` sashiko-bot
2026-11-18 15:34   ` Krzysztof Karas
2026-11-19 10:45     ` Sebastian Brzezinka
2026-11-19 10:58       ` Andi Shyti
2026-11-19 11:06         ` Sebastian Brzezinka
2026-11-19 14:46           ` Krzysztof Karas
2026-11-19 15:11           ` Krzysztof Niemiec
2026-11-18 17:29 ` ✗ i915.CI.BAT: failure for drm/i915/selftests: fix stolen reset test races Patchwork
2026-11-19  8:26 ` ✓ i915.CI.BAT: success for drm/i915/selftests: fix stolen reset test races (rev2) Patchwork
2026-11-19 18:53 ` ✗ i915.CI.Full: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox