[PATCH v2] drm/i915/selftests: Add delay to stabilize frequency in live_rps_power

[PATCH v2] drm/i915/selftests: Add delay to stabilize frequency in live_rps_power

[Sk Anirban]

Add delays to allow frequency stabilization before power measurement
to fix sporadic power conservation issues in live_rps_power test.

v2:
  - Move delay to respective function (Badal)

Signed-off-by: Sk Anirban <sk.anirban@intel.com>
---
 drivers/gpu/drm/i915/gt/selftest_rps.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
index dcef8d498919..c207a4fb03bf 100644
--- a/drivers/gpu/drm/i915/gt/selftest_rps.c
+++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
@@ -1125,6 +1125,7 @@ static u64 measure_power(struct intel_rps *rps, int *freq)
 static u64 measure_power_at(struct intel_rps *rps, int *freq)
 {
 	*freq = rps_set_check(rps, *freq);
+	msleep(100);
 	return measure_power(rps, freq);
 }
 
-- 
2.34.1

✓ i915.CI.BAT: success for drm/i915/selftests: Add delay to stabilize frequency in live_rps_power (rev2)

[Patchwork]

== Series Details ==

Series: drm/i915/selftests: Add delay to stabilize frequency in live_rps_power (rev2)
URL   : https://patchwork.freedesktop.org/series/141995/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_15775 -> Patchwork_141995v2
====================================================

Summary
-------

  **WARNING**

  Minor unknown changes coming with Patchwork_141995v2 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_141995v2, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/index.html

Participating hosts (42 -> 41)
------------------------------

  Missing    (1): fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_141995v2:

### IGT changes ###

#### Warnings ####

  * igt@i915_selftest@live:
    - bat-mtlp-8:         [ABORT][1] ([i915#12061]) -> [ABORT][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15775/bat-mtlp-8/igt@i915_selftest@live.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/bat-mtlp-8/igt@i915_selftest@live.html

  
Known issues
------------

  Here are the changes found in Patchwork_141995v2 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rpm@module-reload:
    - bat-rpls-4:         [PASS][3] -> [FAIL][4] ([i915#12903])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15775/bat-rpls-4/igt@i915_pm_rpm@module-reload.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/bat-rpls-4/igt@i915_pm_rpm@module-reload.html

  
#### Possible fixes ####

  * igt@i915_selftest@live:
    - bat-adlp-6:         [ABORT][5] ([i915#9413]) -> [PASS][6] +1 other test pass
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15775/bat-adlp-6/igt@i915_selftest@live.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/bat-adlp-6/igt@i915_selftest@live.html

  * igt@i915_selftest@live@workarounds:
    - bat-arlh-3:         [ABORT][7] ([i915#12061]) -> [PASS][8] +1 other test pass
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15775/bat-arlh-3/igt@i915_selftest@live@workarounds.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/bat-arlh-3/igt@i915_selftest@live@workarounds.html

  
  [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
  [i915#12903]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12903
  [i915#9413]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9413


Build changes
-------------

  * Linux: CI_DRM_15775 -> Patchwork_141995v2

  CI-20190529: 20190529
  CI_DRM_15775: 4de82d50b8de6a278c1483a7f76ae830c89d1824 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_8134: 027fbf68a00630d7bb8ae200c620296e2bad971d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_141995v2: 4de82d50b8de6a278c1483a7f76ae830c89d1824 @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/index.html

✗ i915.CI.Full: failure for drm/i915/selftests: Add delay to stabilize frequency in live_rps_power (rev2)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 29124 bytes --]

== Series Details ==

Series: drm/i915/selftests: Add delay to stabilize frequency in live_rps_power (rev2)
URL   : https://patchwork.freedesktop.org/series/141995/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_15775_full -> Patchwork_141995v2_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_141995v2_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_141995v2_full, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Participating hosts (9 -> 9)
------------------------------

  No changes in participating hosts

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_141995v2_full:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_exec_balancer@bonded-chain:
    - shard-tglu-1:       NOTRUN -> [ABORT][1] +4 other tests abort
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-1/igt@gem_exec_balancer@bonded-chain.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-rkl:          [PASS][2] -> [FAIL][3]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15775/shard-rkl-7/igt@gem_tiled_swapping@non-threaded.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-rkl-7/igt@gem_tiled_swapping@non-threaded.html

  * igt@perf@invalid-remove-userspace-config:
    - shard-tglu:         NOTRUN -> [ABORT][4] +1 other test abort
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-6/igt@perf@invalid-remove-userspace-config.html

  * igt@perf@sysctl-defaults:
    - shard-dg2:          NOTRUN -> [ABORT][5] +2 other tests abort
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-3/igt@perf@sysctl-defaults.html
    - shard-dg1:          NOTRUN -> [ABORT][6]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg1-17/igt@perf@sysctl-defaults.html

  * igt@perf_pmu@most-busy-check-all@rcs0:
    - shard-mtlp:         NOTRUN -> [ABORT][7] +3 other tests abort
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-mtlp-4/igt@perf_pmu@most-busy-check-all@rcs0.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@perf@gen8-unprivileged-single-ctx-counters:
    - {shard-dg2-9}:      NOTRUN -> [ABORT][8] +1 other test abort
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-9/igt@perf@gen8-unprivileged-single-ctx-counters.html

  
Known issues
------------

  Here are the changes found in Patchwork_141995v2_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@drm_fdinfo@virtual-busy-hang:
    - shard-dg2:          NOTRUN -> [SKIP][9] ([i915#8414])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-3/igt@drm_fdinfo@virtual-busy-hang.html
    - shard-dg1:          NOTRUN -> [SKIP][10] ([i915#8414])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg1-17/igt@drm_fdinfo@virtual-busy-hang.html

  * igt@gem_basic@multigpu-create-close:
    - shard-tglu:         NOTRUN -> [SKIP][11] ([i915#7697])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-6/igt@gem_basic@multigpu-create-close.html

  * igt@gem_exec_big@single:
    - shard-tglu:         NOTRUN -> [ABORT][12] ([i915#11713])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-6/igt@gem_exec_big@single.html

  * igt@gem_exec_fence@submit:
    - shard-dg2:          NOTRUN -> [SKIP][13] ([i915#4812])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-10/igt@gem_exec_fence@submit.html

  * igt@gem_exec_reloc@basic-cpu-wc:
    - shard-dg2:          NOTRUN -> [SKIP][14] ([i915#3281])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-10/igt@gem_exec_reloc@basic-cpu-wc.html

  * igt@gem_lmem_swapping@massive:
    - shard-tglu:         NOTRUN -> [SKIP][15] ([i915#4613])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-6/igt@gem_lmem_swapping@massive.html

  * igt@gem_lmem_swapping@verify-ccs:
    - shard-dg1:          NOTRUN -> [SKIP][16] ([i915#12193])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg1-17/igt@gem_lmem_swapping@verify-ccs.html

  * igt@gem_lmem_swapping@verify-ccs@lmem0:
    - shard-dg1:          NOTRUN -> [SKIP][17] ([i915#4565])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg1-17/igt@gem_lmem_swapping@verify-ccs@lmem0.html

  * igt@gem_mmap_gtt@basic-small-bo-tiledy:
    - shard-mtlp:         NOTRUN -> [SKIP][18] ([i915#4077])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-mtlp-4/igt@gem_mmap_gtt@basic-small-bo-tiledy.html

  * igt@gem_mmap_wc@bad-object:
    - shard-dg2:          NOTRUN -> [SKIP][19] ([i915#4083]) +2 other tests skip
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-3/igt@gem_mmap_wc@bad-object.html

  * igt@gem_mmap_wc@write-cpu-read-wc-unflushed:
    - shard-dg1:          NOTRUN -> [SKIP][20] ([i915#4083]) +1 other test skip
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg1-17/igt@gem_mmap_wc@write-cpu-read-wc-unflushed.html

  * igt@gem_partial_pwrite_pread@write-snoop:
    - shard-mtlp:         NOTRUN -> [SKIP][21] ([i915#3282])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-mtlp-4/igt@gem_partial_pwrite_pread@write-snoop.html

  * igt@gem_render_copy@yf-tiled-to-vebox-yf-tiled:
    - shard-dg2:          NOTRUN -> [SKIP][22] ([i915#5190] / [i915#8428])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-3/igt@gem_render_copy@yf-tiled-to-vebox-yf-tiled.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-dg2:          NOTRUN -> [SKIP][23] ([i915#4077])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-10/igt@gem_tiled_swapping@non-threaded.html

  * igt@gen3_render_tiledx_blits:
    - shard-dg2:          NOTRUN -> [SKIP][24]
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-3/igt@gen3_render_tiledx_blits.html

  * igt@gen9_exec_parse@shadow-peek:
    - shard-dg2:          NOTRUN -> [SKIP][25] ([i915#2856])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-3/igt@gen9_exec_parse@shadow-peek.html
    - shard-dg1:          NOTRUN -> [SKIP][26] ([i915#2527])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg1-17/igt@gen9_exec_parse@shadow-peek.html

  * igt@gen9_exec_parse@unaligned-access:
    - shard-mtlp:         NOTRUN -> [SKIP][27] ([i915#2856])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-mtlp-4/igt@gen9_exec_parse@unaligned-access.html

  * igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
    - shard-dg1:          NOTRUN -> [SKIP][28] ([i915#4538] / [i915#5286])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg1-17/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html

  * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
    - shard-tglu-1:       NOTRUN -> [SKIP][29] ([i915#5286])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-1/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html

  * igt@kms_big_fb@x-tiled-32bpp-rotate-90:
    - shard-tglu:         NOTRUN -> [SKIP][30] +6 other tests skip
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-3/igt@kms_big_fb@x-tiled-32bpp-rotate-90.html
    - shard-mtlp:         NOTRUN -> [SKIP][31]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-mtlp-4/igt@kms_big_fb@x-tiled-32bpp-rotate-90.html

  * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip:
    - shard-dg2:          NOTRUN -> [SKIP][32] ([i915#4538] / [i915#5190]) +1 other test skip
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-10/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip.html

  * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
    - shard-dg1:          NOTRUN -> [SKIP][33] ([i915#4538])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg1-17/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html

  * igt@kms_ccs@crc-primary-rotation-180-4-tiled-bmg-ccs:
    - shard-tglu:         NOTRUN -> [SKIP][34] ([i915#12313])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-6/igt@kms_ccs@crc-primary-rotation-180-4-tiled-bmg-ccs.html

  * igt@kms_ccs@crc-primary-suspend-4-tiled-dg2-rc-ccs@pipe-b-hdmi-a-1:
    - shard-rkl:          NOTRUN -> [SKIP][35] ([i915#6095]) +19 other tests skip
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-rkl-2/igt@kms_ccs@crc-primary-suspend-4-tiled-dg2-rc-ccs@pipe-b-hdmi-a-1.html

  * igt@kms_ccs@crc-primary-suspend-4-tiled-mtl-mc-ccs@pipe-b-dp-4:
    - shard-dg2:          NOTRUN -> [SKIP][36] ([i915#6095]) +7 other tests skip
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-10/igt@kms_ccs@crc-primary-suspend-4-tiled-mtl-mc-ccs@pipe-b-dp-4.html

  * igt@kms_ccs@crc-sprite-planes-basic-4-tiled-lnl-ccs:
    - shard-dg1:          NOTRUN -> [SKIP][37] ([i915#12313])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg1-17/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-lnl-ccs.html
    - shard-dg2:          NOTRUN -> [SKIP][38] ([i915#12313])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-3/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-lnl-ccs.html

  * igt@kms_ccs@crc-sprite-planes-basic-y-tiled-gen12-mc-ccs@pipe-d-hdmi-a-1:
    - shard-dg2:          NOTRUN -> [SKIP][39] ([i915#10307] / [i915#6095]) +15 other tests skip
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-4/igt@kms_ccs@crc-sprite-planes-basic-y-tiled-gen12-mc-ccs@pipe-d-hdmi-a-1.html

  * igt@kms_ccs@random-ccs-data-yf-tiled-ccs@pipe-a-hdmi-a-3:
    - shard-dg1:          NOTRUN -> [SKIP][40] ([i915#6095]) +40 other tests skip
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg1-12/igt@kms_ccs@random-ccs-data-yf-tiled-ccs@pipe-a-hdmi-a-3.html

  * igt@kms_chamelium_hpd@hdmi-hpd-storm-disable:
    - shard-tglu-1:       NOTRUN -> [SKIP][41] ([i915#7828]) +1 other test skip
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-1/igt@kms_chamelium_hpd@hdmi-hpd-storm-disable.html

  * igt@kms_content_protection@dp-mst-lic-type-0:
    - shard-tglu:         NOTRUN -> [SKIP][42] ([i915#3116] / [i915#3299])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-3/igt@kms_content_protection@dp-mst-lic-type-0.html
    - shard-mtlp:         NOTRUN -> [SKIP][43] ([i915#3299])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-mtlp-4/igt@kms_content_protection@dp-mst-lic-type-0.html

  * igt@kms_content_protection@mei-interface:
    - shard-tglu-1:       NOTRUN -> [SKIP][44] ([i915#6944] / [i915#9424])
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-1/igt@kms_content_protection@mei-interface.html

  * igt@kms_cursor_crc@cursor-random-64x21:
    - shard-mtlp:         NOTRUN -> [SKIP][45] ([i915#8814])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-mtlp-4/igt@kms_cursor_crc@cursor-random-64x21.html

  * igt@kms_dirtyfb@fbc-dirtyfb-ioctl:
    - shard-rkl:          [PASS][46] -> [DMESG-WARN][47] ([i915#12964]) +1 other test dmesg-warn
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15775/shard-rkl-5/igt@kms_dirtyfb@fbc-dirtyfb-ioctl.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-rkl-2/igt@kms_dirtyfb@fbc-dirtyfb-ioctl.html

  * igt@kms_dirtyfb@fbc-dirtyfb-ioctl@a-hdmi-a-1:
    - shard-rkl:          NOTRUN -> [DMESG-WARN][48] ([i915#12964]) +2 other tests dmesg-warn
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-rkl-2/igt@kms_dirtyfb@fbc-dirtyfb-ioctl@a-hdmi-a-1.html

  * igt@kms_dither@fb-8bpc-vs-panel-6bpc:
    - shard-dg1:          NOTRUN -> [SKIP][49] ([i915#3555])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg1-17/igt@kms_dither@fb-8bpc-vs-panel-6bpc.html
    - shard-dg2:          NOTRUN -> [SKIP][50] ([i915#3555])
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-3/igt@kms_dither@fb-8bpc-vs-panel-6bpc.html

  * igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1:
    - shard-rkl:          NOTRUN -> [SKIP][51] ([i915#3804])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-rkl-4/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1.html

  * igt@kms_feature_discovery@chamelium:
    - shard-tglu-1:       NOTRUN -> [SKIP][52] ([i915#2065] / [i915#4854])
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-1/igt@kms_feature_discovery@chamelium.html

  * igt@kms_flip@2x-plain-flip-ts-check:
    - shard-tglu-1:       NOTRUN -> [SKIP][53] ([i915#3637]) +2 other tests skip
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-1/igt@kms_flip@2x-plain-flip-ts-check.html

  * igt@kms_flip@plain-flip-ts-check-interruptible:
    - shard-rkl:          [PASS][54] -> [FAIL][55] ([i915#11989])
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15775/shard-rkl-3/igt@kms_flip@plain-flip-ts-check-interruptible.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-rkl-4/igt@kms_flip@plain-flip-ts-check-interruptible.html

  * igt@kms_flip@plain-flip-ts-check-interruptible@a-hdmi-a1:
    - shard-rkl:          NOTRUN -> [FAIL][56] ([i915#13071])
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-rkl-4/igt@kms_flip@plain-flip-ts-check-interruptible@a-hdmi-a1.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling:
    - shard-dg2:          NOTRUN -> [SKIP][57] ([i915#2672] / [i915#3555] / [i915#5190])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-10/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-valid-mode:
    - shard-dg2:          NOTRUN -> [SKIP][58] ([i915#2672])
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-10/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-valid-mode.html

  * igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-downscaling:
    - shard-tglu-1:       NOTRUN -> [SKIP][59] ([i915#2672] / [i915#3555])
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-1/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-downscaling.html

  * igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-downscaling@pipe-a-valid-mode:
    - shard-tglu-1:       NOTRUN -> [SKIP][60] ([i915#2587] / [i915#2672])
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-1/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-downscaling@pipe-a-valid-mode.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-msflip-blt:
    - shard-mtlp:         NOTRUN -> [SKIP][61] ([i915#1825])
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-mtlp-4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-msflip-blt.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-pwrite:
    - shard-dg1:          NOTRUN -> [SKIP][62] +4 other tests skip
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg1-17/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-pwrite:
    - shard-tglu-1:       NOTRUN -> [SKIP][63] +15 other tests skip
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-shrfb-pgflip-blt:
    - shard-dg2:          NOTRUN -> [SKIP][64] ([i915#5354]) +5 other tests skip
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-3/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-shrfb-pgflip-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-gtt:
    - shard-dg2:          NOTRUN -> [SKIP][65] ([i915#8708])
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-10/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-gtt.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-onoff:
    - shard-dg2:          NOTRUN -> [SKIP][66] ([i915#3458]) +3 other tests skip
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-onoff.html
    - shard-dg1:          NOTRUN -> [SKIP][67] ([i915#3458]) +2 other tests skip
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg1-17/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-onoff.html

  * igt@kms_panel_fitting@legacy:
    - shard-dg2:          NOTRUN -> [SKIP][68] ([i915#6301])
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-10/igt@kms_panel_fitting@legacy.html

  * igt@kms_psr2_sf@pr-primary-plane-update-sf-dmg-area:
    - shard-tglu-1:       NOTRUN -> [SKIP][69] ([i915#11520]) +1 other test skip
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-1/igt@kms_psr2_sf@pr-primary-plane-update-sf-dmg-area.html

  * igt@kms_psr2_su@page_flip-p010:
    - shard-tglu-1:       NOTRUN -> [SKIP][70] ([i915#9683])
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-1/igt@kms_psr2_su@page_flip-p010.html

  * igt@kms_psr@fbc-psr-sprite-plane-onoff:
    - shard-mtlp:         NOTRUN -> [SKIP][71] ([i915#9688]) +2 other tests skip
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-mtlp-4/igt@kms_psr@fbc-psr-sprite-plane-onoff.html

  * igt@kms_psr@pr-sprite-render:
    - shard-tglu-1:       NOTRUN -> [SKIP][72] ([i915#9732]) +2 other tests skip
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-1/igt@kms_psr@pr-sprite-render.html

  * igt@kms_psr@psr2-primary-blt:
    - shard-tglu:         NOTRUN -> [SKIP][73] ([i915#9732]) +1 other test skip
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-6/igt@kms_psr@psr2-primary-blt.html

  * igt@kms_psr@psr2-primary-mmap-gtt:
    - shard-dg2:          NOTRUN -> [SKIP][74] ([i915#1072] / [i915#9732]) +2 other tests skip
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-3/igt@kms_psr@psr2-primary-mmap-gtt.html
    - shard-dg1:          NOTRUN -> [SKIP][75] ([i915#1072] / [i915#9732]) +2 other tests skip
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg1-17/igt@kms_psr@psr2-primary-mmap-gtt.html

  * igt@kms_scaling_modes@scaling-mode-full:
    - shard-tglu:         NOTRUN -> [SKIP][76] ([i915#3555])
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-6/igt@kms_scaling_modes@scaling-mode-full.html

  * igt@kms_setmode@invalid-clone-exclusive-crtc:
    - shard-tglu-1:       NOTRUN -> [SKIP][77] ([i915#3555])
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-1/igt@kms_setmode@invalid-clone-exclusive-crtc.html

  * igt@kms_writeback@writeback-check-output-xrgb2101010:
    - shard-dg2:          NOTRUN -> [SKIP][78] ([i915#2437] / [i915#9412])
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-3/igt@kms_writeback@writeback-check-output-xrgb2101010.html
    - shard-dg1:          NOTRUN -> [SKIP][79] ([i915#2437] / [i915#9412])
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg1-17/igt@kms_writeback@writeback-check-output-xrgb2101010.html

  * igt@prime_vgem@basic-gtt:
    - shard-dg2:          NOTRUN -> [SKIP][80] ([i915#3708] / [i915#4077])
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-10/igt@prime_vgem@basic-gtt.html

  
#### Possible fixes ####

  * igt@gem_tiled_swapping@non-threaded:
    - shard-tglu:         [FAIL][81] -> [PASS][82]
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15775/shard-tglu-10/igt@gem_tiled_swapping@non-threaded.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-tglu-2/igt@gem_tiled_swapping@non-threaded.html

  * igt@kms_cursor_legacy@flip-vs-cursor-toggle:
    - shard-snb:          [FAIL][83] ([i915#2346]) -> [PASS][84]
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15775/shard-snb1/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-snb2/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html

  * igt@kms_flip@absolute-wf_vblank@b-hdmi-a2:
    - shard-rkl:          [DMESG-WARN][85] ([i915#12964]) -> [PASS][86] +5 other tests pass
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15775/shard-rkl-1/igt@kms_flip@absolute-wf_vblank@b-hdmi-a2.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-rkl-5/igt@kms_flip@absolute-wf_vblank@b-hdmi-a2.html

  * igt@kms_hdr@static-toggle:
    - shard-dg2:          [SKIP][87] ([i915#3555] / [i915#8228]) -> [PASS][88]
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15775/shard-dg2-11/igt@kms_hdr@static-toggle.html
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-10/igt@kms_hdr@static-toggle.html

  * igt@kms_plane_scaling@plane-downscale-factor-0-5-with-pixel-format:
    - shard-dg1:          [DMESG-WARN][89] ([i915#4423]) -> [PASS][90]
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15775/shard-dg1-14/igt@kms_plane_scaling@plane-downscale-factor-0-5-with-pixel-format.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg1-18/igt@kms_plane_scaling@plane-downscale-factor-0-5-with-pixel-format.html

  * igt@kms_pm_rpm@modeset-lpsp-stress:
    - shard-dg2:          [SKIP][91] ([i915#9519]) -> [PASS][92]
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15775/shard-dg2-2/igt@kms_pm_rpm@modeset-lpsp-stress.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg2-4/igt@kms_pm_rpm@modeset-lpsp-stress.html

  
#### Warnings ####

  * igt@kms_content_protection@dp-mst-lic-type-1:
    - shard-dg1:          [SKIP][93] ([i915#3299] / [i915#4423]) -> [SKIP][94] ([i915#3299])
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15775/shard-dg1-14/igt@kms_content_protection@dp-mst-lic-type-1.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg1-18/igt@kms_content_protection@dp-mst-lic-type-1.html

  * igt@kms_content_protection@mei-interface:
    - shard-dg1:          [SKIP][95] ([i915#9424]) -> [SKIP][96] ([i915#9433])
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15775/shard-dg1-17/igt@kms_content_protection@mei-interface.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/shard-dg1-13/igt@kms_content_protection@mei-interface.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#10307]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10307
  [i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
  [i915#11520]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11520
  [i915#11713]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11713
  [i915#11989]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11989
  [i915#12193]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12193
  [i915#12313]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12313
  [i915#12964]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12964
  [i915#13049]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13049
  [i915#13071]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13071
  [i915#1825]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1825
  [i915#2065]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2065
  [i915#2346]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2346
  [i915#2437]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2437
  [i915#2527]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2527
  [i915#2587]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2587
  [i915#2672]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2672
  [i915#2856]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2856
  [i915#3116]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3116
  [i915#3281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3282
  [i915#3299]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3299
  [i915#3458]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3458
  [i915#3539]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3539
  [i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
  [i915#3637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3637
  [i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
  [i915#3804]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3804
  [i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
  [i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
  [i915#4270]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4270
  [i915#4423]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4423
  [i915#4538]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4538
  [i915#4565]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4565
  [i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
  [i915#4812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4812
  [i915#4852]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4852
  [i915#4854]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4854
  [i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
  [i915#5286]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5286
  [i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
  [i915#6095]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6095
  [i915#6301]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6301
  [i915#6944]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6944
  [i915#7697]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7697
  [i915#7828]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7828
  [i915#8228]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8228
  [i915#8414]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8414
  [i915#8428]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8428
  [i915#8708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8708
  [i915#8812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8812
  [i915#8814]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8814
  [i915#9412]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9412
  [i915#9424]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9424
  [i915#9433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9433
  [i915#9519]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9519
  [i915#9683]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9683
  [i915#9688]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9688
  [i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
  [i915#9917]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9917


Build changes
-------------

  * Linux: CI_DRM_15775 -> Patchwork_141995v2

  CI-20190529: 20190529
  CI_DRM_15775: 4de82d50b8de6a278c1483a7f76ae830c89d1824 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_8134: 027fbf68a00630d7bb8ae200c620296e2bad971d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_141995v2: 4de82d50b8de6a278c1483a7f76ae830c89d1824 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141995v2/index.html

[-- Attachment #2: Type: text/html, Size: 34117 bytes --]

Re: [PATCH v2] drm/i915/selftests: Add delay to stabilize frequency in live_rps_power

[Nilawar, Badal]

On 03-12-2024 11:41, Sk Anirban wrote:
> Add delays to allow frequency stabilization before power measurement
> to fix sporadic power conservation issues in live_rps_power test.
> 
> v2:
>    - Move delay to respective function (Badal)
> 
> Signed-off-by: Sk Anirban <sk.anirban@intel.com>
> ---
>   drivers/gpu/drm/i915/gt/selftest_rps.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
> index dcef8d498919..c207a4fb03bf 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_rps.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
> @@ -1125,6 +1125,7 @@ static u64 measure_power(struct intel_rps *rps, int *freq)
>   static u64 measure_power_at(struct intel_rps *rps, int *freq)
>   {
>   	*freq = rps_set_check(rps, *freq);
> +	msleep(100);

Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>

Regards,
Badal
>   	return measure_power(rps, freq);
>   }
>   

Re: [PATCH v2] drm/i915/selftests: Add delay to stabilize frequency in live_rps_power

[Jani Nikula]

On Tue, 03 Dec 2024, Sk Anirban <sk.anirban@intel.com> wrote:
> Add delays to allow frequency stabilization before power measurement
> to fix sporadic power conservation issues in live_rps_power test.

Looks like band-aid. What's the root cause?

BR,
Jani.

>
> v2:
>   - Move delay to respective function (Badal)
>
> Signed-off-by: Sk Anirban <sk.anirban@intel.com>
> ---
>  drivers/gpu/drm/i915/gt/selftest_rps.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
> index dcef8d498919..c207a4fb03bf 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_rps.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
> @@ -1125,6 +1125,7 @@ static u64 measure_power(struct intel_rps *rps, int *freq)
>  static u64 measure_power_at(struct intel_rps *rps, int *freq)
>  {
>  	*freq = rps_set_check(rps, *freq);
> +	msleep(100);
>  	return measure_power(rps, freq);
>  }

-- 
Jani Nikula, Intel

Re: [PATCH v2] drm/i915/selftests: Add delay to stabilize frequency in live_rps_power

[Anirban, Sk]

On 03-12-2024 16:16, Jani Nikula wrote:
> On Tue, 03 Dec 2024, Sk Anirban <sk.anirban@intel.com> wrote:
>> Add delays to allow frequency stabilization before power measurement
>> to fix sporadic power conservation issues in live_rps_power test.
> Looks like band-aid. What's the root cause?
>
> BR,
> Jani.

In some cases, we have observed that the power consumption at the 
minimum frequency is greater than at the maximum frequency. This is 
likely due to the actual frequency not settling. The issue is sporadic, 
and to address this, we are adding a delay after setting the freq and 
before measuring the power.

Thanks,
Anirban

>> v2:
>>    - Move delay to respective function (Badal)
>>
>> Signed-off-by: Sk Anirban <sk.anirban@intel.com>
>> ---
>>   drivers/gpu/drm/i915/gt/selftest_rps.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
>> index dcef8d498919..c207a4fb03bf 100644
>> --- a/drivers/gpu/drm/i915/gt/selftest_rps.c
>> +++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
>> @@ -1125,6 +1125,7 @@ static u64 measure_power(struct intel_rps *rps, int *freq)
>>   static u64 measure_power_at(struct intel_rps *rps, int *freq)
>>   {
>>   	*freq = rps_set_check(rps, *freq);
>> +	msleep(100);
>>   	return measure_power(rps, freq);
>>   }

Re: [PATCH v2] drm/i915/selftests: Add delay to stabilize frequency in live_rps_power

[Raag Jadav]

On Thu, Dec 05, 2024 at 12:07:53PM +0530, Anirban, Sk wrote:
> On 03-12-2024 16:16, Jani Nikula wrote:
> > On Tue, 03 Dec 2024, Sk Anirban <sk.anirban@intel.com> wrote:
> > > Add delays to allow frequency stabilization before power measurement
> > > to fix sporadic power conservation issues in live_rps_power test.
> > Looks like band-aid. What's the root cause?
> 
> In some cases, we have observed that the power consumption at the minimum
> frequency is greater than at the maximum frequency. This is likely due to
> the actual frequency not settling. The issue is sporadic, and to address
> this, we are adding a delay after setting the freq and before measuring the
> power.

Why not use wait_for_freq()?

Raag

> > > v2:
> > >    - Move delay to respective function (Badal)
> > > 
> > > Signed-off-by: Sk Anirban <sk.anirban@intel.com>
> > > ---
> > >   drivers/gpu/drm/i915/gt/selftest_rps.c | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
> > > index dcef8d498919..c207a4fb03bf 100644
> > > --- a/drivers/gpu/drm/i915/gt/selftest_rps.c
> > > +++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
> > > @@ -1125,6 +1125,7 @@ static u64 measure_power(struct intel_rps *rps, int *freq)
> > >   static u64 measure_power_at(struct intel_rps *rps, int *freq)
> > >   {
> > >   	*freq = rps_set_check(rps, *freq);
> > > +	msleep(100);
> > >   	return measure_power(rps, freq);
> > >   }