Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] drm/i915: i915_reg.h display split
@ 2025-02-07 13:35 Jani Nikula
  2025-02-07 13:35 ` [PATCH 1/3] drm/i915/reg: use REG_BIT and friends to define DP registers Jani Nikula
                   ` (4 more replies)
  0 siblings, 5 replies; 15+ messages in thread
From: Jani Nikula @ 2025-02-07 13:35 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: jani.nikula, ville.syrjala, imre.deak


Jani Nikula (3):
  drm/i915/reg: use REG_BIT and friends to define DP registers
  drm/i915/reg: Remove some extra blank lines
  drm/i915: split out display register macros to a separate file

 drivers/gpu/drm/i915/display/g4x_dp.c         |   24 +-
 drivers/gpu/drm/i915/display/g4x_hdmi.c       |    1 +
 drivers/gpu/drm/i915/display/hsw_ips.c        |    1 +
 .../gpu/drm/i915/display/i9xx_display_sr.c    |    1 +
 drivers/gpu/drm/i915/display/i9xx_plane.c     |    2 +
 drivers/gpu/drm/i915/display/i9xx_wm.c        |    1 +
 drivers/gpu/drm/i915/display/icl_dsi.c        |    1 +
 .../gpu/drm/i915/display/intel_backlight.c    |    2 +-
 drivers/gpu/drm/i915/display/intel_bw.c       |    3 +-
 drivers/gpu/drm/i915/display/intel_cdclk.c    |    1 +
 drivers/gpu/drm/i915/display/intel_cmtg.c     |    3 +-
 .../gpu/drm/i915/display/intel_combo_phy.c    |    1 +
 drivers/gpu/drm/i915/display/intel_crt.c      |    1 +
 drivers/gpu/drm/i915/display/intel_ddi.c      |    1 +
 drivers/gpu/drm/i915/display/intel_display.c  |    3 +-
 .../drm/i915/display/intel_display_debugfs.c  |    1 +
 .../drm/i915/display/intel_display_device.c   |    6 +-
 .../gpu/drm/i915/display/intel_display_irq.c  |    2 +
 .../drm/i915/display/intel_display_power.c    |    1 +
 .../i915/display/intel_display_power_map.c    |    1 +
 .../i915/display/intel_display_power_well.c   |    1 +
 .../gpu/drm/i915/display/intel_display_regs.h | 2768 ++++++++++++++++
 .../gpu/drm/i915/display/intel_display_wa.c   |    1 +
 drivers/gpu/drm/i915/display/intel_dmc.c      |    1 +
 drivers/gpu/drm/i915/display/intel_dmc_wl.c   |    1 +
 drivers/gpu/drm/i915/display/intel_dp.c       |    6 +-
 drivers/gpu/drm/i915/display/intel_dp_hdcp.c  |    1 +
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |    1 +
 drivers/gpu/drm/i915/display/intel_dp_test.c  |    1 +
 drivers/gpu/drm/i915/display/intel_dpio_phy.c |    1 +
 drivers/gpu/drm/i915/display/intel_dpll.c     |    1 +
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c |    1 +
 .../gpu/drm/i915/display/intel_dpt_common.c   |    1 +
 drivers/gpu/drm/i915/display/intel_drrs.c     |    1 +
 drivers/gpu/drm/i915/display/intel_dsb.c      |    1 +
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c  |    3 +-
 drivers/gpu/drm/i915/display/intel_dvo.c      |    1 +
 drivers/gpu/drm/i915/display/intel_fbc.c      |    3 +
 drivers/gpu/drm/i915/display/intel_fdi.c      |    3 +-
 .../drm/i915/display/intel_fifo_underrun.c    |    1 +
 drivers/gpu/drm/i915/display/intel_gmbus.c    |    1 +
 drivers/gpu/drm/i915/display/intel_hdcp.c     |    1 +
 drivers/gpu/drm/i915/display/intel_hdmi.c     |    2 +-
 .../gpu/drm/i915/display/intel_hotplug_irq.c  |    1 +
 drivers/gpu/drm/i915/display/intel_lspcon.c   |    1 +
 drivers/gpu/drm/i915/display/intel_lvds.c     |    3 +-
 .../drm/i915/display/intel_modeset_setup.c    |    3 +-
 drivers/gpu/drm/i915/display/intel_overlay.c  |    2 +
 .../gpu/drm/i915/display/intel_pch_display.c  |    1 +
 .../gpu/drm/i915/display/intel_pch_refclk.c   |    1 +
 drivers/gpu/drm/i915/display/intel_pfit.c     |    1 +
 drivers/gpu/drm/i915/display/intel_pipe_crc.c |    1 +
 drivers/gpu/drm/i915/display/intel_pmdemand.c |    1 +
 drivers/gpu/drm/i915/display/intel_pps.c      |    1 +
 drivers/gpu/drm/i915/display/intel_psr.c      |    1 +
 drivers/gpu/drm/i915/display/intel_sdvo.c     |    1 +
 drivers/gpu/drm/i915/display/intel_snps_phy.c |    1 +
 drivers/gpu/drm/i915/display/intel_tc.c       |    1 +
 drivers/gpu/drm/i915/display/intel_vblank.c   |    1 +
 drivers/gpu/drm/i915/display/intel_vga.c      |    2 +
 drivers/gpu/drm/i915/display/intel_vrr.c      |    1 +
 drivers/gpu/drm/i915/display/skl_scaler.c     |    1 +
 .../drm/i915/display/skl_universal_plane.c    |    4 +-
 drivers/gpu/drm/i915/display/skl_watermark.c  |    1 +
 drivers/gpu/drm/i915/display/vlv_dsi.c        |    1 +
 drivers/gpu/drm/i915/gvt/display.c            |    1 +
 drivers/gpu/drm/i915/gvt/fb_decoder.c         |    1 +
 drivers/gpu/drm/i915/gvt/handlers.c           |    1 +
 drivers/gpu/drm/i915/gvt/interrupt.c          |    1 +
 drivers/gpu/drm/i915/gvt/mmio.c               |    1 +
 drivers/gpu/drm/i915/i915_reg.h               | 2800 -----------------
 drivers/gpu/drm/i915/intel_gvt_mmio_table.c   |    1 +
 drivers/gpu/drm/xe/display/xe_plane_initial.c |    2 +-
 73 files changed, 2869 insertions(+), 2829 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_display_regs.h

-- 
2.39.5


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 1/3] drm/i915/reg: use REG_BIT and friends to define DP registers
  2025-02-07 13:35 [PATCH 0/3] drm/i915: i915_reg.h display split Jani Nikula
@ 2025-02-07 13:35 ` Jani Nikula
  2025-02-12  8:07   ` Kandpal, Suraj
  2025-02-07 13:35 ` [PATCH 2/3] drm/i915/reg: Remove some extra blank lines Jani Nikula
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 15+ messages in thread
From: Jani Nikula @ 2025-02-07 13:35 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: jani.nikula, ville.syrjala, imre.deak

Define the DP register contents using the REG_BIT, REG_GENMASK,
etc. macros. Ditch the unhelpful comments. Rename eDP related register
content macros to have EDP_ prefix.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/g4x_dp.c |  23 +++--
 drivers/gpu/drm/i915/i915_reg.h       | 124 +++++++++-----------------
 2 files changed, 54 insertions(+), 93 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/g4x_dp.c b/drivers/gpu/drm/i915/display/g4x_dp.c
index 56353377466c..a82102d3a167 100644
--- a/drivers/gpu/drm/i915/display/g4x_dp.c
+++ b/drivers/gpu/drm/i915/display/g4x_dp.c
@@ -183,7 +183,7 @@ static void assert_dp_port(struct intel_dp *intel_dp, bool state)
 static void assert_edp_pll(struct drm_i915_private *dev_priv, bool state)
 {
 	struct intel_display *display = &dev_priv->display;
-	bool cur_state = intel_de_read(display, DP_A) & DP_PLL_ENABLE;
+	bool cur_state = intel_de_read(display, DP_A) & EDP_PLL_ENABLE;
 
 	INTEL_DISPLAY_STATE_WARN(display, cur_state != state,
 				 "eDP PLL state assertion failure (expected %s, current %s)\n",
@@ -206,12 +206,12 @@ static void ilk_edp_pll_on(struct intel_dp *intel_dp,
 	drm_dbg_kms(display->drm, "enabling eDP PLL for clock %d\n",
 		    pipe_config->port_clock);
 
-	intel_dp->DP &= ~DP_PLL_FREQ_MASK;
+	intel_dp->DP &= ~EDP_PLL_FREQ_MASK;
 
 	if (pipe_config->port_clock == 162000)
-		intel_dp->DP |= DP_PLL_FREQ_162MHZ;
+		intel_dp->DP |= EDP_PLL_FREQ_162MHZ;
 	else
-		intel_dp->DP |= DP_PLL_FREQ_270MHZ;
+		intel_dp->DP |= EDP_PLL_FREQ_270MHZ;
 
 	intel_de_write(display, DP_A, intel_dp->DP);
 	intel_de_posting_read(display, DP_A);
@@ -226,7 +226,7 @@ static void ilk_edp_pll_on(struct intel_dp *intel_dp,
 	if (IS_IRONLAKE(dev_priv))
 		intel_wait_for_vblank_if_active(dev_priv, !crtc->pipe);
 
-	intel_dp->DP |= DP_PLL_ENABLE;
+	intel_dp->DP |= EDP_PLL_ENABLE;
 
 	intel_de_write(display, DP_A, intel_dp->DP);
 	intel_de_posting_read(display, DP_A);
@@ -246,7 +246,7 @@ static void ilk_edp_pll_off(struct intel_dp *intel_dp,
 
 	drm_dbg_kms(display->drm, "disabling eDP PLL\n");
 
-	intel_dp->DP &= ~DP_PLL_ENABLE;
+	intel_dp->DP &= ~EDP_PLL_ENABLE;
 
 	intel_de_write(display, DP_A, intel_dp->DP);
 	intel_de_posting_read(display, DP_A);
@@ -291,13 +291,13 @@ bool g4x_dp_port_enabled(struct drm_i915_private *dev_priv,
 
 	/* asserts want to know the pipe even if the port is disabled */
 	if (IS_IVYBRIDGE(dev_priv) && port == PORT_A)
-		*pipe = (val & DP_PIPE_SEL_MASK_IVB) >> DP_PIPE_SEL_SHIFT_IVB;
+		*pipe = REG_FIELD_GET(DP_PIPE_SEL_MASK_IVB, val);
 	else if (HAS_PCH_CPT(dev_priv) && port != PORT_A)
 		ret &= cpt_dp_port_selected(dev_priv, port, pipe);
 	else if (IS_CHERRYVIEW(dev_priv))
-		*pipe = (val & DP_PIPE_SEL_MASK_CHV) >> DP_PIPE_SEL_SHIFT_CHV;
+		*pipe = REG_FIELD_GET(DP_PIPE_SEL_MASK_CHV, val);
 	else
-		*pipe = (val & DP_PIPE_SEL_MASK) >> DP_PIPE_SEL_SHIFT;
+		*pipe = REG_FIELD_GET(DP_PIPE_SEL_MASK, val);
 
 	return ret;
 }
@@ -393,13 +393,12 @@ static void intel_dp_get_config(struct intel_encoder *encoder,
 	if (IS_G4X(dev_priv) && tmp & DP_COLOR_RANGE_16_235)
 		pipe_config->limited_color_range = true;
 
-	pipe_config->lane_count =
-		((tmp & DP_PORT_WIDTH_MASK) >> DP_PORT_WIDTH_SHIFT) + 1;
+	pipe_config->lane_count = REG_FIELD_GET(DP_PORT_WIDTH_MASK, tmp) + 1;
 
 	g4x_dp_get_m_n(pipe_config);
 
 	if (port == PORT_A) {
-		if ((intel_de_read(display, DP_A) & DP_PLL_FREQ_MASK) == DP_PLL_FREQ_162MHZ)
+		if ((intel_de_read(display, DP_A) & EDP_PLL_FREQ_MASK) == EDP_PLL_FREQ_162MHZ)
 			pipe_config->port_clock = 162000;
 		else
 			pipe_config->port_clock = 270000;
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 670cd2371f94..da658c3591f0 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -1394,88 +1394,50 @@
 #define VLV_DP_B		_MMIO(VLV_DISPLAY_BASE + 0x64100)
 #define VLV_DP_C		_MMIO(VLV_DISPLAY_BASE + 0x64200)
 #define CHV_DP_D		_MMIO(VLV_DISPLAY_BASE + 0x64300)
-#define   DP_PORT_EN			(1 << 31)
-#define   DP_PIPE_SEL_SHIFT		30
-#define   DP_PIPE_SEL_MASK		(1 << 30)
-#define   DP_PIPE_SEL(pipe)		((pipe) << 30)
-#define   DP_PIPE_SEL_SHIFT_IVB		29
-#define   DP_PIPE_SEL_MASK_IVB		(3 << 29)
-#define   DP_PIPE_SEL_IVB(pipe)		((pipe) << 29)
+#define   DP_PORT_EN			REG_BIT(31)
+#define   DP_PIPE_SEL_MASK		REG_GENMASK(30, 30)
+#define   DP_PIPE_SEL(pipe)		REG_FIELD_PREP(DP_PIPE_SEL_MASK, (pipe))
+#define   DP_PIPE_SEL_MASK_IVB		REG_GENMASK(30, 29)
+#define   DP_PIPE_SEL_IVB(pipe)		REG_FIELD_PREP(DP_PIPE_SEL_MASK_IVB, (pipe))
 #define   DP_PIPE_SEL_SHIFT_CHV		16
-#define   DP_PIPE_SEL_MASK_CHV		(3 << 16)
-#define   DP_PIPE_SEL_CHV(pipe)		((pipe) << 16)
-
-/* Link training mode - select a suitable mode for each stage */
-#define   DP_LINK_TRAIN_PAT_1		(0 << 28)
-#define   DP_LINK_TRAIN_PAT_2		(1 << 28)
-#define   DP_LINK_TRAIN_PAT_IDLE	(2 << 28)
-#define   DP_LINK_TRAIN_OFF		(3 << 28)
-#define   DP_LINK_TRAIN_MASK		(3 << 28)
-#define   DP_LINK_TRAIN_SHIFT		28
-
-/* CPT Link training mode */
-#define   DP_LINK_TRAIN_PAT_1_CPT	(0 << 8)
-#define   DP_LINK_TRAIN_PAT_2_CPT	(1 << 8)
-#define   DP_LINK_TRAIN_PAT_IDLE_CPT	(2 << 8)
-#define   DP_LINK_TRAIN_OFF_CPT		(3 << 8)
-#define   DP_LINK_TRAIN_MASK_CPT	(7 << 8)
-#define   DP_LINK_TRAIN_SHIFT_CPT	8
-
-/* Signal voltages. These are mostly controlled by the other end */
-#define   DP_VOLTAGE_0_4		(0 << 25)
-#define   DP_VOLTAGE_0_6		(1 << 25)
-#define   DP_VOLTAGE_0_8		(2 << 25)
-#define   DP_VOLTAGE_1_2		(3 << 25)
-#define   DP_VOLTAGE_MASK		(7 << 25)
-#define   DP_VOLTAGE_SHIFT		25
-
-/* Signal pre-emphasis levels, like voltages, the other end tells us what
- * they want
- */
-#define   DP_PRE_EMPHASIS_0		(0 << 22)
-#define   DP_PRE_EMPHASIS_3_5		(1 << 22)
-#define   DP_PRE_EMPHASIS_6		(2 << 22)
-#define   DP_PRE_EMPHASIS_9_5		(3 << 22)
-#define   DP_PRE_EMPHASIS_MASK		(7 << 22)
-#define   DP_PRE_EMPHASIS_SHIFT		22
-
-/* How many wires to use. I guess 3 was too hard */
-#define   DP_PORT_WIDTH(width)		(((width) - 1) << 19)
-#define   DP_PORT_WIDTH_MASK		(7 << 19)
-#define   DP_PORT_WIDTH_SHIFT		19
-
-/* Mystic DPCD version 1.1 special mode */
-#define   DP_ENHANCED_FRAMING		(1 << 18)
-
-/* eDP */
-#define   DP_PLL_FREQ_270MHZ		(0 << 16)
-#define   DP_PLL_FREQ_162MHZ		(1 << 16)
-#define   DP_PLL_FREQ_MASK		(3 << 16)
-
-/* locked once port is enabled */
-#define   DP_PORT_REVERSAL		(1 << 15)
-
-/* eDP */
-#define   DP_PLL_ENABLE			(1 << 14)
-
-/* sends the clock on lane 15 of the PEG for debug */
-#define   DP_CLOCK_OUTPUT_ENABLE	(1 << 13)
-
-#define   DP_SCRAMBLING_DISABLE		(1 << 12)
-#define   DP_SCRAMBLING_DISABLE_IRONLAKE	(1 << 7)
-
-/* limit RGB values to avoid confusing TVs */
-#define   DP_COLOR_RANGE_16_235		(1 << 8)
-
-/* Turn on the audio link */
-#define   DP_AUDIO_OUTPUT_ENABLE	(1 << 6)
-
-/* vs and hs sync polarity */
-#define   DP_SYNC_VS_HIGH		(1 << 4)
-#define   DP_SYNC_HS_HIGH		(1 << 3)
-
-/* A fantasy */
-#define   DP_DETECTED			(1 << 2)
+#define   DP_PIPE_SEL_MASK_CHV		REG_GENMASK(17, 16)
+#define   DP_PIPE_SEL_CHV(pipe)		REG_FIELD_PREP(DP_PIPE_SEL_MASK_CHV, (pipe))
+#define   DP_LINK_TRAIN_MASK		REG_GENMASK(29, 28)
+#define   DP_LINK_TRAIN_PAT_1		REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 0)
+#define   DP_LINK_TRAIN_PAT_2		REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 1)
+#define   DP_LINK_TRAIN_PAT_IDLE	REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 2)
+#define   DP_LINK_TRAIN_OFF		REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 3)
+#define   DP_LINK_TRAIN_MASK_CPT	REG_GENMASK(10, 8)
+#define   DP_LINK_TRAIN_PAT_1_CPT	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 0)
+#define   DP_LINK_TRAIN_PAT_2_CPT	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 1)
+#define   DP_LINK_TRAIN_PAT_IDLE_CPT	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 2)
+#define   DP_LINK_TRAIN_OFF_CPT		REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 3)
+#define   DP_VOLTAGE_MASK		REG_GENMASK(27, 25)
+#define   DP_VOLTAGE_0_4		REG_FIELD_PREP(DP_VOLTAGE_MASK, 0)
+#define   DP_VOLTAGE_0_6		REG_FIELD_PREP(DP_VOLTAGE_MASK, 1)
+#define   DP_VOLTAGE_0_8		REG_FIELD_PREP(DP_VOLTAGE_MASK, 2)
+#define   DP_VOLTAGE_1_2		REG_FIELD_PREP(DP_VOLTAGE_MASK, 3)
+#define   DP_PRE_EMPHASIS_MASK		REG_GENMASK(24, 22)
+#define   DP_PRE_EMPHASIS_0		REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 0)
+#define   DP_PRE_EMPHASIS_3_5		REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 1)
+#define   DP_PRE_EMPHASIS_6		REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 2)
+#define   DP_PRE_EMPHASIS_9_5		REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 3)
+#define   DP_PORT_WIDTH_MASK		REG_GENMASK(21, 19)
+#define   DP_PORT_WIDTH(width)		REG_FIELD_PREP(DP_PORT_WIDTH_MASK, (width) - 1)
+#define   DP_ENHANCED_FRAMING		REG_BIT(18)
+#define   EDP_PLL_FREQ_MASK		REG_GENMASK(17, 16)
+#define   EDP_PLL_FREQ_270MHZ		REG_FIELD_PREP(EDP_PLL_FREQ_MASK, 0)
+#define   EDP_PLL_FREQ_162MHZ		REG_FIELD_PREP(EDP_PLL_FREQ_MASK, 1)
+#define   DP_PORT_REVERSAL		REG_BIT(15)
+#define   EDP_PLL_ENABLE		REG_BIT(14)
+#define   DP_CLOCK_OUTPUT_ENABLE	REG_BIT(13)
+#define   DP_SCRAMBLING_DISABLE		REG_BIT(12)
+#define   DP_SCRAMBLING_DISABLE_ILK	REG_BIT(7)
+#define   DP_COLOR_RANGE_16_235		REG_BIT(8)
+#define   DP_AUDIO_OUTPUT_ENABLE	REG_BIT(6)
+#define   DP_SYNC_VS_HIGH		REG_BIT(4)
+#define   DP_SYNC_HS_HIGH		REG_BIT(3)
+#define   DP_DETECTED			REG_BIT(2)
 
 /*
  * Computing GMCH M and N values for the Display Port link
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 2/3] drm/i915/reg: Remove some extra blank lines
  2025-02-07 13:35 [PATCH 0/3] drm/i915: i915_reg.h display split Jani Nikula
  2025-02-07 13:35 ` [PATCH 1/3] drm/i915/reg: use REG_BIT and friends to define DP registers Jani Nikula
@ 2025-02-07 13:35 ` Jani Nikula
  2025-02-12  8:07   ` Kandpal, Suraj
  2025-02-07 13:35 ` [PATCH 3/3] drm/i915: split out display register macros to a separate file Jani Nikula
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 15+ messages in thread
From: Jani Nikula @ 2025-02-07 13:35 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: jani.nikula, ville.syrjala, imre.deak

Remove some blank lines from i915_reg.h primarily to help the scripted
refactoring coming up, keeping the comments together.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/i915_reg.h | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index da658c3591f0..6e80508b544c 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -1016,7 +1016,6 @@
 /*
  * Overlay regs
  */
-
 #define OVADD			_MMIO(0x30000)
 #define DOVSTA			_MMIO(0x30008)
 #define OC_BUF			(0x3 << 20)
@@ -1071,7 +1070,6 @@
 /*
  * Display engine regs
  */
-
 /* Pipe/transcoder A timing regs */
 #define _TRANS_HTOTAL_A		0x60000
 #define _TRANS_HTOTAL_B		0x61000
@@ -2781,7 +2779,6 @@
  * functionality covered in PCH_PORT_HOTPLUG is split into
  * SHOTPLUG_CTL_DDI and SHOTPLUG_CTL_TC.
  */
-
 #define SHOTPLUG_CTL_DDI				_MMIO(0xc4030)
 #define   SHOTPLUG_CTL_DDI_HPD_ENABLE(hpd_pin)			(0x8 << (_HPD_PIN_DDI(hpd_pin) * 4))
 #define   SHOTPLUG_CTL_DDI_HPD_OUTPUT_DATA(hpd_pin)		(0x4 << (_HPD_PIN_DDI(hpd_pin) * 4))
@@ -2861,7 +2858,6 @@
 #define  TRANS_DPLL_ENABLE(pipe)	(1 << ((pipe) * 4 + 3))
 
 /* transcoder */
-
 #define _PCH_TRANS_HTOTAL_A		0xe0000
 #define _PCH_TRANS_HTOTAL_B		0xe1000
 #define PCH_TRANS_HTOTAL(pipe)		_MMIO_PIPE(pipe, _PCH_TRANS_HTOTAL_A, _PCH_TRANS_HTOTAL_B)
@@ -3787,7 +3783,6 @@ enum skl_power_gate {
 /*
  * SKL Clocks
  */
-
 /* CDCLK_CTL */
 #define CDCLK_CTL			_MMIO(0x46000)
 #define  CDCLK_FREQ_SEL_MASK		REG_GENMASK(27, 26)
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 3/3] drm/i915: split out display register macros to a separate file
  2025-02-07 13:35 [PATCH 0/3] drm/i915: i915_reg.h display split Jani Nikula
  2025-02-07 13:35 ` [PATCH 1/3] drm/i915/reg: use REG_BIT and friends to define DP registers Jani Nikula
  2025-02-07 13:35 ` [PATCH 2/3] drm/i915/reg: Remove some extra blank lines Jani Nikula
@ 2025-02-07 13:35 ` Jani Nikula
  2025-02-12  8:48   ` Kandpal, Suraj
  2025-02-12 14:45   ` Ville Syrjälä
  2025-02-07 16:12 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: i915_reg.h display split Patchwork
  2025-02-07 19:54 ` ✗ i915.CI.BAT: failure " Patchwork
  4 siblings, 2 replies; 15+ messages in thread
From: Jani Nikula @ 2025-02-07 13:35 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: jani.nikula, ville.syrjala, imre.deak

This is a scripted split of the display related register macros from
i915_reg.h to display/intel_display_regs.h. Basically move all the
macros that are only used in display code (or GVT). If there are users
in core i915 code or soc/, or no users anywhere, keep the macros in
i915_reg.h. This is done in groups of macros separated by blank lines,
moving the comments along with the groups.

This is obviously a very crude approach. It's not perfect. But there are
4.2k lines in i915_reg.h, and its refactoring has ground to a halt. This
is the big hammer that splits the file to two, and enables further
cleanup.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/g4x_dp.c         |    1 +
 drivers/gpu/drm/i915/display/g4x_hdmi.c       |    1 +
 drivers/gpu/drm/i915/display/hsw_ips.c        |    1 +
 .../gpu/drm/i915/display/i9xx_display_sr.c    |    1 +
 drivers/gpu/drm/i915/display/i9xx_plane.c     |    2 +
 drivers/gpu/drm/i915/display/i9xx_wm.c        |    1 +
 drivers/gpu/drm/i915/display/icl_dsi.c        |    1 +
 .../gpu/drm/i915/display/intel_backlight.c    |    2 +-
 drivers/gpu/drm/i915/display/intel_bw.c       |    3 +-
 drivers/gpu/drm/i915/display/intel_cdclk.c    |    1 +
 drivers/gpu/drm/i915/display/intel_cmtg.c     |    3 +-
 .../gpu/drm/i915/display/intel_combo_phy.c    |    1 +
 drivers/gpu/drm/i915/display/intel_crt.c      |    1 +
 drivers/gpu/drm/i915/display/intel_ddi.c      |    1 +
 drivers/gpu/drm/i915/display/intel_display.c  |    3 +-
 .../drm/i915/display/intel_display_debugfs.c  |    1 +
 .../drm/i915/display/intel_display_device.c   |    6 +-
 .../gpu/drm/i915/display/intel_display_irq.c  |    2 +
 .../drm/i915/display/intel_display_power.c    |    1 +
 .../i915/display/intel_display_power_map.c    |    1 +
 .../i915/display/intel_display_power_well.c   |    1 +
 .../gpu/drm/i915/display/intel_display_regs.h | 2768 +++++++++++++++++
 .../gpu/drm/i915/display/intel_display_wa.c   |    1 +
 drivers/gpu/drm/i915/display/intel_dmc.c      |    1 +
 drivers/gpu/drm/i915/display/intel_dmc_wl.c   |    1 +
 drivers/gpu/drm/i915/display/intel_dp.c       |    6 +-
 drivers/gpu/drm/i915/display/intel_dp_hdcp.c  |    1 +
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |    1 +
 drivers/gpu/drm/i915/display/intel_dp_test.c  |    1 +
 drivers/gpu/drm/i915/display/intel_dpio_phy.c |    1 +
 drivers/gpu/drm/i915/display/intel_dpll.c     |    1 +
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c |    1 +
 .../gpu/drm/i915/display/intel_dpt_common.c   |    1 +
 drivers/gpu/drm/i915/display/intel_drrs.c     |    1 +
 drivers/gpu/drm/i915/display/intel_dsb.c      |    1 +
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c  |    3 +-
 drivers/gpu/drm/i915/display/intel_dvo.c      |    1 +
 drivers/gpu/drm/i915/display/intel_fbc.c      |    3 +
 drivers/gpu/drm/i915/display/intel_fdi.c      |    3 +-
 .../drm/i915/display/intel_fifo_underrun.c    |    1 +
 drivers/gpu/drm/i915/display/intel_gmbus.c    |    1 +
 drivers/gpu/drm/i915/display/intel_hdcp.c     |    1 +
 drivers/gpu/drm/i915/display/intel_hdmi.c     |    2 +-
 .../gpu/drm/i915/display/intel_hotplug_irq.c  |    1 +
 drivers/gpu/drm/i915/display/intel_lspcon.c   |    1 +
 drivers/gpu/drm/i915/display/intel_lvds.c     |    3 +-
 .../drm/i915/display/intel_modeset_setup.c    |    3 +-
 drivers/gpu/drm/i915/display/intel_overlay.c  |    2 +
 .../gpu/drm/i915/display/intel_pch_display.c  |    1 +
 .../gpu/drm/i915/display/intel_pch_refclk.c   |    1 +
 drivers/gpu/drm/i915/display/intel_pfit.c     |    1 +
 drivers/gpu/drm/i915/display/intel_pipe_crc.c |    1 +
 drivers/gpu/drm/i915/display/intel_pmdemand.c |    1 +
 drivers/gpu/drm/i915/display/intel_pps.c      |    1 +
 drivers/gpu/drm/i915/display/intel_psr.c      |    1 +
 drivers/gpu/drm/i915/display/intel_sdvo.c     |    1 +
 drivers/gpu/drm/i915/display/intel_snps_phy.c |    1 +
 drivers/gpu/drm/i915/display/intel_tc.c       |    1 +
 drivers/gpu/drm/i915/display/intel_vblank.c   |    1 +
 drivers/gpu/drm/i915/display/intel_vga.c      |    2 +
 drivers/gpu/drm/i915/display/intel_vrr.c      |    1 +
 drivers/gpu/drm/i915/display/skl_scaler.c     |    1 +
 .../drm/i915/display/skl_universal_plane.c    |    4 +-
 drivers/gpu/drm/i915/display/skl_watermark.c  |    1 +
 drivers/gpu/drm/i915/display/vlv_dsi.c        |    1 +
 drivers/gpu/drm/i915/gvt/display.c            |    1 +
 drivers/gpu/drm/i915/gvt/fb_decoder.c         |    1 +
 drivers/gpu/drm/i915/gvt/handlers.c           |    1 +
 drivers/gpu/drm/i915/gvt/interrupt.c          |    1 +
 drivers/gpu/drm/i915/gvt/mmio.c               |    1 +
 drivers/gpu/drm/i915/i915_reg.h               | 2757 ----------------
 drivers/gpu/drm/i915/intel_gvt_mmio_table.c   |    1 +
 drivers/gpu/drm/xe/display/xe_plane_initial.c |    2 +-
 73 files changed, 2858 insertions(+), 2774 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_display_regs.h

diff --git a/drivers/gpu/drm/i915/display/g4x_dp.c b/drivers/gpu/drm/i915/display/g4x_dp.c
index a82102d3a167..4e37312f6139 100644
--- a/drivers/gpu/drm/i915/display/g4x_dp.c
+++ b/drivers/gpu/drm/i915/display/g4x_dp.c
@@ -16,6 +16,7 @@
 #include "intel_crtc.h"
 #include "intel_de.h"
 #include "intel_display_power.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dp_aux.h"
diff --git a/drivers/gpu/drm/i915/display/g4x_hdmi.c b/drivers/gpu/drm/i915/display/g4x_hdmi.c
index 98e6a931042f..2448d510dbc2 100644
--- a/drivers/gpu/drm/i915/display/g4x_hdmi.c
+++ b/drivers/gpu/drm/i915/display/g4x_hdmi.c
@@ -14,6 +14,7 @@
 #include "intel_crtc.h"
 #include "intel_de.h"
 #include "intel_display_power.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dp_aux.h"
 #include "intel_dpio_phy.h"
diff --git a/drivers/gpu/drm/i915/display/hsw_ips.c b/drivers/gpu/drm/i915/display/hsw_ips.c
index d02c328bf902..53ff21be6a4b 100644
--- a/drivers/gpu/drm/i915/display/hsw_ips.c
+++ b/drivers/gpu/drm/i915/display/hsw_ips.c
@@ -10,6 +10,7 @@
 #include "i915_reg.h"
 #include "intel_color_regs.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_pcode.h"
 
diff --git a/drivers/gpu/drm/i915/display/i9xx_display_sr.c b/drivers/gpu/drm/i915/display/i9xx_display_sr.c
index 32abe9743014..357212f09a0f 100644
--- a/drivers/gpu/drm/i915/display/i9xx_display_sr.c
+++ b/drivers/gpu/drm/i915/display/i9xx_display_sr.c
@@ -9,6 +9,7 @@
 #include "i9xx_display_sr.h"
 #include "i9xx_wm_regs.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_gmbus.h"
 #include "intel_pci_config.h"
 
diff --git a/drivers/gpu/drm/i915/display/i9xx_plane.c b/drivers/gpu/drm/i915/display/i9xx_plane.c
index bd3f8db13700..a5362ee1ce90 100644
--- a/drivers/gpu/drm/i915/display/i9xx_plane.c
+++ b/drivers/gpu/drm/i915/display/i9xx_plane.c
@@ -2,6 +2,7 @@
 /*
  * Copyright © 2020 Intel Corporation
  */
+
 #include <linux/kernel.h>
 
 #include <drm/drm_atomic_helper.h>
@@ -16,6 +17,7 @@
 #include "intel_atomic_plane.h"
 #include "intel_de.h"
 #include "intel_display_irq.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_fb.h"
 #include "intel_fbc.h"
diff --git a/drivers/gpu/drm/i915/display/i9xx_wm.c b/drivers/gpu/drm/i915/display/i9xx_wm.c
index 497850a6ac81..53a427829fe3 100644
--- a/drivers/gpu/drm/i915/display/i9xx_wm.c
+++ b/drivers/gpu/drm/i915/display/i9xx_wm.c
@@ -10,6 +10,7 @@
 #include "intel_atomic.h"
 #include "intel_bo.h"
 #include "intel_display.h"
+#include "intel_display_regs.h"
 #include "intel_display_trace.h"
 #include "intel_fb.h"
 #include "intel_mchbar_regs.h"
diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
index ee1c3fb500a7..26c595cafdd3 100644
--- a/drivers/gpu/drm/i915/display/icl_dsi.c
+++ b/drivers/gpu/drm/i915/display/icl_dsi.c
@@ -44,6 +44,7 @@
 #include "intel_crtc.h"
 #include "intel_ddi.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_dsi.h"
 #include "intel_dsi_vbt.h"
 #include "intel_panel.h"
diff --git a/drivers/gpu/drm/i915/display/intel_backlight.c b/drivers/gpu/drm/i915/display/intel_backlight.c
index 477b21af71a4..d4e6d4926141 100644
--- a/drivers/gpu/drm/i915/display/intel_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_backlight.c
@@ -7,7 +7,6 @@
 #include <linux/kernel.h>
 #include <linux/pwm.h>
 #include <linux/string_helpers.h>
-
 #include <acpi/video.h>
 
 #include "i915_drv.h"
@@ -16,6 +15,7 @@
 #include "intel_backlight_regs.h"
 #include "intel_connector.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dp_aux_backlight.h"
 #include "intel_dsi_dcs_backlight.h"
diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
index 23edc81741de..e4646d467300 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.c
+++ b/drivers/gpu/drm/i915/display/intel_bw.c
@@ -12,10 +12,11 @@
 #include "intel_bw.h"
 #include "intel_cdclk.h"
 #include "intel_display_core.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
-#include "skl_watermark.h"
 #include "intel_mchbar_regs.h"
 #include "intel_pcode.h"
+#include "skl_watermark.h"
 
 /* Parameters for Qclk Geyserville (QGV) */
 struct intel_qgv_point {
diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
index 753ba3e3a0b7..ac9f1c47580d 100644
--- a/drivers/gpu/drm/i915/display/intel_cdclk.c
+++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
@@ -38,6 +38,7 @@
 #include "intel_cdclk.h"
 #include "intel_crtc.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_mchbar_regs.h"
 #include "intel_pci_config.h"
diff --git a/drivers/gpu/drm/i915/display/intel_cmtg.c b/drivers/gpu/drm/i915/display/intel_cmtg.c
index 6b6fb82009f5..342b4407b391 100644
--- a/drivers/gpu/drm/i915/display/intel_cmtg.c
+++ b/drivers/gpu/drm/i915/display/intel_cmtg.c
@@ -11,12 +11,13 @@
 
 #include "i915_drv.h"
 #include "i915_reg.h"
-#include "intel_crtc.h"
 #include "intel_cmtg.h"
 #include "intel_cmtg_regs.h"
+#include "intel_crtc.h"
 #include "intel_de.h"
 #include "intel_display_device.h"
 #include "intel_display_power.h"
+#include "intel_display_regs.h"
 
 /**
  * DOC: Common Primary Timing Generator (CMTG)
diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c b/drivers/gpu/drm/i915/display/intel_combo_phy.c
index 4fbe2e3542ca..6bd47caae08a 100644
--- a/drivers/gpu/drm/i915/display/intel_combo_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_combo_phy.c
@@ -8,6 +8,7 @@
 #include "intel_combo_phy.h"
 #include "intel_combo_phy_regs.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 
 #define for_each_combo_phy(__dev_priv, __phy) \
diff --git a/drivers/gpu/drm/i915/display/intel_crt.c b/drivers/gpu/drm/i915/display/intel_crt.c
index b5367e059ee3..8f58681c7a5b 100644
--- a/drivers/gpu/drm/i915/display/intel_crt.c
+++ b/drivers/gpu/drm/i915/display/intel_crt.c
@@ -44,6 +44,7 @@
 #include "intel_ddi_buf_trans.h"
 #include "intel_de.h"
 #include "intel_display_driver.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_fdi.h"
 #include "intel_fdi_regs.h"
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index db3c2d85c57b..6dfe3fc45ece 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -48,6 +48,7 @@
 #include "intel_ddi_buf_trans.h"
 #include "intel_de.h"
 #include "intel_display_power.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dkl_phy.h"
 #include "intel_dkl_phy_regs.h"
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index a50b0a008231..5ad084c3d31c 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -66,13 +66,14 @@
 #include "intel_crt.h"
 #include "intel_crtc.h"
 #include "intel_crtc_state_dump.h"
+#include "intel_cursor.h"
 #include "intel_cursor_regs.h"
 #include "intel_cx0_phy.h"
-#include "intel_cursor.h"
 #include "intel_ddi.h"
 #include "intel_de.h"
 #include "intel_display_driver.h"
 #include "intel_display_power.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dmc.h"
 #include "intel_dp.h"
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index 926f09c35084..c9fb2eca84f8 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -24,6 +24,7 @@
 #include "intel_display_debugfs_params.h"
 #include "intel_display_power.h"
 #include "intel_display_power_well.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dmc.h"
 #include "intel_dp.h"
diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
index 738ae522c8f4..cf4ab425984b 100644
--- a/drivers/gpu/drm/i915/display/intel_display_device.c
+++ b/drivers/gpu/drm/i915/display/intel_display_device.c
@@ -3,10 +3,11 @@
  * Copyright © 2023 Intel Corporation
  */
 
-#include <drm/intel/pciids.h>
-#include <drm/drm_color_mgmt.h>
 #include <linux/pci.h>
 
+#include <drm/drm_color_mgmt.h>
+#include <drm/intel/pciids.h>
+
 #include "i915_drv.h"
 #include "i915_reg.h"
 #include "intel_cx0_phy_regs.h"
@@ -16,6 +17,7 @@
 #include "intel_display_params.h"
 #include "intel_display_power.h"
 #include "intel_display_reg_defs.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_fbc.h"
 #include "intel_step.h"
diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c b/drivers/gpu/drm/i915/display/intel_display_irq.c
index d9734fcd0d45..e08589fc79e4 100644
--- a/drivers/gpu/drm/i915/display/intel_display_irq.c
+++ b/drivers/gpu/drm/i915/display/intel_display_irq.c
@@ -6,6 +6,7 @@
 #include <drm/drm_vblank.h>
 
 #include "gt/intel_rps.h"
+
 #include "i915_drv.h"
 #include "i915_irq.h"
 #include "i915_reg.h"
@@ -13,6 +14,7 @@
 #include "intel_crtc.h"
 #include "intel_de.h"
 #include "intel_display_irq.h"
+#include "intel_display_regs.h"
 #include "intel_display_trace.h"
 #include "intel_display_types.h"
 #include "intel_dmc_wl.h"
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index 14ae60749f02..4fa19507a7fa 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -16,6 +16,7 @@
 #include "intel_display_power.h"
 #include "intel_display_power_map.h"
 #include "intel_display_power_well.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dmc.h"
 #include "intel_mchbar_regs.h"
diff --git a/drivers/gpu/drm/i915/display/intel_display_power_map.c b/drivers/gpu/drm/i915/display/intel_display_power_map.c
index 0c8ac1af6db7..dfbcd2521e04 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power_map.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power_map.c
@@ -7,6 +7,7 @@
 #include "intel_display_core.h"
 #include "intel_display_power_map.h"
 #include "intel_display_power_well.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "vlv_sideband_reg.h"
 
diff --git a/drivers/gpu/drm/i915/display/intel_display_power_well.c b/drivers/gpu/drm/i915/display/intel_display_power_well.c
index f45a4f9ba23c..930e7f9ad502 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power_well.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power_well.c
@@ -13,6 +13,7 @@
 #include "intel_de.h"
 #include "intel_display_irq.h"
 #include "intel_display_power_well.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dkl_phy.h"
 #include "intel_dkl_phy_regs.h"
diff --git a/drivers/gpu/drm/i915/display/intel_display_regs.h b/drivers/gpu/drm/i915/display/intel_display_regs.h
new file mode 100644
index 000000000000..1c070bd5c694
--- /dev/null
+++ b/drivers/gpu/drm/i915/display/intel_display_regs.h
@@ -0,0 +1,2768 @@
+/* SPDX-License-Identifier: MIT */
+/* Copyright © 2024 Intel Corporation */
+
+#ifndef __INTEL_DISPLAY_REGS_H__
+#define __INTEL_DISPLAY_REGS_H__
+
+#include "intel_display_reg_defs.h"
+
+#define GU_CNTL_PROTECTED		_MMIO(0x10100C)
+#define   DEPRESENT			REG_BIT(9)
+
+#define DPIO_CTL			_MMIO(VLV_DISPLAY_BASE + 0x2110)
+#define  DPIO_MODSEL1			(1 << 3) /* if ref clk b == 27 */
+#define  DPIO_MODSEL0			(1 << 2) /* if ref clk a == 27 */
+#define  DPIO_SFR_BYPASS		(1 << 1)
+#define  DPIO_CMNRST			(1 << 0)
+
+#define BXT_P_CR_GT_DISP_PWRON		_MMIO(0x138090)
+#define  MIPIO_RST_CTRL				(1 << 2)
+
+#define _BXT_PHY_CTL_DDI_A		0x64C00
+#define _BXT_PHY_CTL_DDI_B		0x64C10
+#define _BXT_PHY_CTL_DDI_C		0x64C20
+#define   BXT_PHY_CMNLANE_POWERDOWN_ACK	(1 << 10)
+#define   BXT_PHY_LANE_POWERDOWN_ACK	(1 << 9)
+#define   BXT_PHY_LANE_ENABLED		(1 << 8)
+#define BXT_PHY_CTL(port)		_MMIO_PORT(port, _BXT_PHY_CTL_DDI_A, \
+							 _BXT_PHY_CTL_DDI_B)
+
+#define _PHY_CTL_FAMILY_DDI		0x64C90
+#define _PHY_CTL_FAMILY_EDP		0x64C80
+#define _PHY_CTL_FAMILY_DDI_C		0x64CA0
+#define   COMMON_RESET_DIS		(1 << 31)
+#define BXT_PHY_CTL_FAMILY(phy)							\
+	 _MMIO(_PICK_EVEN_2RANGES(phy, 1,					\
+				  _PHY_CTL_FAMILY_DDI, _PHY_CTL_FAMILY_DDI,	\
+				  _PHY_CTL_FAMILY_EDP, _PHY_CTL_FAMILY_DDI_C))
+
+/* UAIMI scratch pad register 1 */
+#define UAIMI_SPR1			_MMIO(0x4F074)
+/* SKL VccIO mask */
+#define SKL_VCCIO_MASK			0x1
+/* SKL balance leg register */
+#define DISPIO_CR_TX_BMU_CR0		_MMIO(0x6C00C)
+/* I_boost values */
+#define BALANCE_LEG_SHIFT(port)		(8 + 3 * (port))
+#define BALANCE_LEG_MASK(port)		(7 << (8 + 3 * (port)))
+/* Balance leg disable bits */
+#define BALANCE_LEG_DISABLE_SHIFT	23
+#define BALANCE_LEG_DISABLE(port)	(1 << (23 + (port)))
+
+#define VLV_IRQ_REGS		I915_IRQ_REGS(VLV_IMR, \
+					      VLV_IER, \
+					      VLV_IIR)
+
+#define _MBUS_ABOX0_CTL			0x45038
+#define _MBUS_ABOX1_CTL			0x45048
+#define _MBUS_ABOX2_CTL			0x4504C
+#define MBUS_ABOX_CTL(x)							\
+	_MMIO(_PICK_EVEN_2RANGES(x, 2,						\
+				 _MBUS_ABOX0_CTL, _MBUS_ABOX1_CTL,		\
+				 _MBUS_ABOX2_CTL, _MBUS_ABOX2_CTL))
+
+#define MBUS_ABOX_BW_CREDIT_MASK	(3 << 20)
+#define MBUS_ABOX_BW_CREDIT(x)		((x) << 20)
+#define MBUS_ABOX_B_CREDIT_MASK		(0xF << 16)
+#define MBUS_ABOX_B_CREDIT(x)		((x) << 16)
+#define MBUS_ABOX_BT_CREDIT_POOL2_MASK	(0x1F << 8)
+#define MBUS_ABOX_BT_CREDIT_POOL2(x)	((x) << 8)
+#define MBUS_ABOX_BT_CREDIT_POOL1_MASK	(0x1F << 0)
+#define MBUS_ABOX_BT_CREDIT_POOL1(x)	((x) << 0)
+
+#define IPS_CTL		_MMIO(0x43408)
+#define   IPS_ENABLE		REG_BIT(31)
+#define   IPS_FALSE_COLOR	REG_BIT(4)
+
+/*
+ * Clock control & power management
+ */
+#define _DPLL_A			0x6014
+#define _DPLL_B			0x6018
+#define _CHV_DPLL_C		0x6030
+#define DPLL(dev_priv, pipe)		_MMIO_BASE_PIPE3(DISPLAY_MMIO_BASE(dev_priv), \
+						 (pipe), _DPLL_A, _DPLL_B, _CHV_DPLL_C)
+
+#define VGA0	_MMIO(0x6000)
+#define VGA1	_MMIO(0x6004)
+#define VGA_PD	_MMIO(0x6010)
+#define   VGA0_PD_P2_DIV_4	(1 << 7)
+#define   VGA0_PD_P1_DIV_2	(1 << 5)
+#define   VGA0_PD_P1_SHIFT	0
+#define   VGA0_PD_P1_MASK	(0x1f << 0)
+#define   VGA1_PD_P2_DIV_4	(1 << 15)
+#define   VGA1_PD_P1_DIV_2	(1 << 13)
+#define   VGA1_PD_P1_SHIFT	8
+#define   VGA1_PD_P1_MASK	(0x1f << 8)
+#define   DPLL_VCO_ENABLE		(1 << 31)
+#define   DPLL_SDVO_HIGH_SPEED		(1 << 30)
+#define   DPLL_DVO_2X_MODE		(1 << 30)
+#define   DPLL_EXT_BUFFER_ENABLE_VLV	(1 << 30)
+#define   DPLL_SYNCLOCK_ENABLE		(1 << 29)
+#define   DPLL_REF_CLK_ENABLE_VLV	(1 << 29)
+#define   DPLL_VGA_MODE_DIS		(1 << 28)
+#define   DPLLB_MODE_DAC_SERIAL		(1 << 26) /* i915 */
+#define   DPLLB_MODE_LVDS		(2 << 26) /* i915 */
+#define   DPLL_MODE_MASK		(3 << 26)
+#define   DPLL_DAC_SERIAL_P2_CLOCK_DIV_10 (0 << 24) /* i915 */
+#define   DPLL_DAC_SERIAL_P2_CLOCK_DIV_5 (1 << 24) /* i915 */
+#define   DPLLB_LVDS_P2_CLOCK_DIV_14	(0 << 24) /* i915 */
+#define   DPLLB_LVDS_P2_CLOCK_DIV_7	(1 << 24) /* i915 */
+#define   DPLL_P2_CLOCK_DIV_MASK	0x03000000 /* i915 */
+#define   DPLL_FPA01_P1_POST_DIV_MASK	0x00ff0000 /* i915 */
+#define   DPLL_FPA01_P1_POST_DIV_MASK_PINEVIEW	0x00ff8000 /* Pineview */
+#define   DPLL_LOCK_VLV			(1 << 15)
+#define   DPLL_INTEGRATED_CRI_CLK_VLV	(1 << 14)
+#define   DPLL_INTEGRATED_REF_CLK_VLV	(1 << 13)
+#define   DPLL_SSC_REF_CLK_CHV		(1 << 13)
+#define   DPLL_PORTC_READY_MASK		(0xf << 4)
+#define   DPLL_PORTB_READY_MASK		(0xf)
+
+#define   DPLL_FPA01_P1_POST_DIV_MASK_I830	0x001f0000
+
+/* Additional CHV pll/phy registers */
+#define DPIO_PHY_STATUS			_MMIO(VLV_DISPLAY_BASE + 0x6240)
+#define   DPLL_PORTD_READY_MASK		(0xf)
+#define DISPLAY_PHY_CONTROL _MMIO(VLV_DISPLAY_BASE + 0x60100)
+#define   PHY_CH_POWER_DOWN_OVRD_EN(phy, ch)	(1 << (2 * (phy) + (ch) + 27))
+#define   PHY_LDO_DELAY_0NS			0x0
+#define   PHY_LDO_DELAY_200NS			0x1
+#define   PHY_LDO_DELAY_600NS			0x2
+#define   PHY_LDO_SEQ_DELAY(delay, phy)		((delay) << (2 * (phy) + 23))
+#define   PHY_CH_POWER_DOWN_OVRD(mask, phy, ch)	((mask) << (8 * (phy) + 4 * (ch) + 11))
+#define   PHY_CH_SU_PSR				0x1
+#define   PHY_CH_DEEP_PSR			0x7
+#define   PHY_CH_POWER_MODE(mode, phy, ch)	((mode) << (6 * (phy) + 3 * (ch) + 2))
+#define   PHY_COM_LANE_RESET_DEASSERT(phy)	(1 << (phy))
+#define DISPLAY_PHY_STATUS _MMIO(VLV_DISPLAY_BASE + 0x60104)
+#define   PHY_POWERGOOD(phy)	(((phy) == DPIO_PHY0) ? (1 << 31) : (1 << 30))
+#define   PHY_STATUS_CMN_LDO(phy, ch)                   (1 << (6 - (6 * (phy) + 3 * (ch))))
+#define   PHY_STATUS_SPLINE_LDO(phy, ch, spline)        (1 << (8 - (6 * (phy) + 3 * (ch) + (spline))))
+
+/*
+ * The i830 generation, in LVDS mode, defines P1 as the bit number set within
+ * this field (only one bit may be set).
+ */
+#define   DPLL_FPA01_P1_POST_DIV_MASK_I830_LVDS	0x003f0000
+#define   DPLL_FPA01_P1_POST_DIV_SHIFT	16
+#define   DPLL_FPA01_P1_POST_DIV_SHIFT_PINEVIEW 15
+/* i830, required in DVO non-gang */
+#define   PLL_P2_DIVIDE_BY_4		(1 << 23)
+#define   PLL_P1_DIVIDE_BY_TWO		(1 << 21) /* i830 */
+#define   PLL_REF_INPUT_DREFCLK		(0 << 13)
+#define   PLL_REF_INPUT_TVCLKINA	(1 << 13) /* i830 */
+#define   PLL_REF_INPUT_TVCLKINBC	(2 << 13) /* SDVO TVCLKIN */
+#define   PLLB_REF_INPUT_SPREADSPECTRUMIN (3 << 13)
+#define   PLL_REF_INPUT_MASK		(3 << 13)
+#define   PLL_LOAD_PULSE_PHASE_SHIFT		9
+/* Ironlake */
+# define PLL_REF_SDVO_HDMI_MULTIPLIER_SHIFT     9
+# define PLL_REF_SDVO_HDMI_MULTIPLIER_MASK      (7 << 9)
+# define PLL_REF_SDVO_HDMI_MULTIPLIER(x)	(((x) - 1) << 9)
+# define DPLL_FPA1_P1_POST_DIV_SHIFT            0
+# define DPLL_FPA1_P1_POST_DIV_MASK             0xff
+
+/*
+ * Parallel to Serial Load Pulse phase selection.
+ * Selects the phase for the 10X DPLL clock for the PCIe
+ * digital display port. The range is 4 to 13; 10 or more
+ * is just a flip delay. The default is 6
+ */
+#define   PLL_LOAD_PULSE_PHASE_MASK		(0xf << PLL_LOAD_PULSE_PHASE_SHIFT)
+#define   DISPLAY_RATE_SELECT_FPA1		(1 << 8)
+/*
+ * SDVO multiplier for 945G/GM. Not used on 965.
+ */
+#define   SDVO_MULTIPLIER_MASK			0x000000ff
+#define   SDVO_MULTIPLIER_SHIFT_HIRES		4
+#define   SDVO_MULTIPLIER_SHIFT_VGA		0
+
+#define _DPLL_A_MD		0x601c
+#define _DPLL_B_MD		0x6020
+#define _CHV_DPLL_C_MD		0x603c
+#define DPLL_MD(dev_priv, pipe)		_MMIO_BASE_PIPE3(DISPLAY_MMIO_BASE(dev_priv), \
+						 (pipe), _DPLL_A_MD, _DPLL_B_MD, _CHV_DPLL_C_MD)
+
+/*
+ * UDI pixel divider, controlling how many pixels are stuffed into a packet.
+ *
+ * Value is pixels minus 1.  Must be set to 1 pixel for SDVO.
+ */
+#define   DPLL_MD_UDI_DIVIDER_MASK		0x3f000000
+#define   DPLL_MD_UDI_DIVIDER_SHIFT		24
+/* UDI pixel divider for VGA, same as DPLL_MD_UDI_DIVIDER_MASK. */
+#define   DPLL_MD_VGA_UDI_DIVIDER_MASK		0x003f0000
+#define   DPLL_MD_VGA_UDI_DIVIDER_SHIFT		16
+/*
+ * SDVO/UDI pixel multiplier.
+ *
+ * SDVO requires that the bus clock rate be between 1 and 2 Ghz, and the bus
+ * clock rate is 10 times the DPLL clock.  At low resolution/refresh rate
+ * modes, the bus rate would be below the limits, so SDVO allows for stuffing
+ * dummy bytes in the datastream at an increased clock rate, with both sides of
+ * the link knowing how many bytes are fill.
+ *
+ * So, for a mode with a dotclock of 65Mhz, we would want to double the clock
+ * rate to 130Mhz to get a bus rate of 1.30Ghz.  The DPLL clock rate would be
+ * set to 130Mhz, and the SDVO multiplier set to 2x in this register and
+ * through an SDVO command.
+ *
+ * This register field has values of multiplication factor minus 1, with
+ * a maximum multiplier of 5 for SDVO.
+ */
+#define   DPLL_MD_UDI_MULTIPLIER_MASK		0x00003f00
+#define   DPLL_MD_UDI_MULTIPLIER_SHIFT		8
+/*
+ * SDVO/UDI pixel multiplier for VGA, same as DPLL_MD_UDI_MULTIPLIER_MASK.
+ * This best be set to the default value (3) or the CRT won't work. No,
+ * I don't entirely understand what this does...
+ */
+#define   DPLL_MD_VGA_UDI_MULTIPLIER_MASK	0x0000003f
+#define   DPLL_MD_VGA_UDI_MULTIPLIER_SHIFT	0
+
+#define RAWCLK_FREQ_VLV		_MMIO(VLV_DISPLAY_BASE + 0x6024)
+
+#define FW_BLC_SELF_VLV		_MMIO(VLV_DISPLAY_BASE + 0x6500)
+#define  FW_CSPWRDWNEN		(1 << 15)
+
+#define MI_ARB_VLV		_MMIO(VLV_DISPLAY_BASE + 0x6504)
+
+#define GCI_CONTROL		_MMIO(VLV_DISPLAY_BASE + 0x650C)
+#define   PFI_CREDIT_63		(9 << 28)		/* chv only */
+#define   PFI_CREDIT_31		(8 << 28)		/* chv only */
+#define   PFI_CREDIT(x)		(((x) - 8) << 28)	/* 8-15 */
+#define   PFI_CREDIT_RESEND	(1 << 27)
+#define   VGA_FAST_MODE_DISABLE	(1 << 14)
+
+#define GMBUSFREQ_VLV		_MMIO(VLV_DISPLAY_BASE + 0x6510)
+
+#define PEG_BAND_GAP_DATA	_MMIO(0x14d68)
+
+/*
+ * Overlay regs
+ */
+#define OVADD			_MMIO(0x30000)
+#define DOVSTA			_MMIO(0x30008)
+#define OC_BUF			(0x3 << 20)
+#define OGAMC5			_MMIO(0x30010)
+#define OGAMC4			_MMIO(0x30014)
+#define OGAMC3			_MMIO(0x30018)
+#define OGAMC2			_MMIO(0x3001c)
+#define OGAMC1			_MMIO(0x30020)
+#define OGAMC0			_MMIO(0x30024)
+
+#define GEN9_CLKGATE_DIS_4		_MMIO(0x4653C)
+#define   BXT_GMBUS_GATING_DIS		(1 << 14)
+
+#define GEN9_CLKGATE_DIS_5		_MMIO(0x46540)
+#define   DPCE_GATING_DIS		REG_BIT(17)
+
+#define _CLKGATE_DIS_PSL_A		0x46520
+#define _CLKGATE_DIS_PSL_B		0x46524
+#define _CLKGATE_DIS_PSL_C		0x46528
+#define   DUPS1_GATING_DIS		(1 << 15)
+#define   DUPS2_GATING_DIS		(1 << 19)
+#define   DUPS3_GATING_DIS		(1 << 23)
+#define   CURSOR_GATING_DIS		REG_BIT(28)
+#define   DPF_GATING_DIS		(1 << 10)
+#define   DPF_RAM_GATING_DIS		(1 << 9)
+#define   DPFR_GATING_DIS		(1 << 8)
+
+#define CLKGATE_DIS_PSL(pipe) \
+	_MMIO_PIPE(pipe, _CLKGATE_DIS_PSL_A, _CLKGATE_DIS_PSL_B)
+
+#define _CLKGATE_DIS_PSL_EXT_A		0x4654C
+#define _CLKGATE_DIS_PSL_EXT_B		0x46550
+#define   PIPEDMC_GATING_DIS		REG_BIT(12)
+
+#define CLKGATE_DIS_PSL_EXT(pipe) \
+	_MMIO_PIPE(pipe, _CLKGATE_DIS_PSL_EXT_A, _CLKGATE_DIS_PSL_EXT_B)
+
+/*
+ * Display engine regs
+ */
+/* Pipe/transcoder A timing regs */
+#define _TRANS_HTOTAL_A		0x60000
+#define _TRANS_HTOTAL_B		0x61000
+#define TRANS_HTOTAL(dev_priv, trans)	_MMIO_TRANS2(dev_priv, (trans), _TRANS_HTOTAL_A)
+#define   HTOTAL_MASK			REG_GENMASK(31, 16)
+#define   HTOTAL(htotal)		REG_FIELD_PREP(HTOTAL_MASK, (htotal))
+#define   HACTIVE_MASK			REG_GENMASK(15, 0)
+#define   HACTIVE(hdisplay)		REG_FIELD_PREP(HACTIVE_MASK, (hdisplay))
+
+#define _TRANS_HBLANK_A		0x60004
+#define _TRANS_HBLANK_B		0x61004
+#define TRANS_HBLANK(dev_priv, trans)	_MMIO_TRANS2(dev_priv, (trans), _TRANS_HBLANK_A)
+#define   HBLANK_END_MASK		REG_GENMASK(31, 16)
+#define   HBLANK_END(hblank_end)	REG_FIELD_PREP(HBLANK_END_MASK, (hblank_end))
+#define   HBLANK_START_MASK		REG_GENMASK(15, 0)
+#define   HBLANK_START(hblank_start)	REG_FIELD_PREP(HBLANK_START_MASK, (hblank_start))
+
+#define _TRANS_HSYNC_A		0x60008
+#define _TRANS_HSYNC_B		0x61008
+#define TRANS_HSYNC(dev_priv, trans)	_MMIO_TRANS2(dev_priv, (trans), _TRANS_HSYNC_A)
+#define   HSYNC_END_MASK		REG_GENMASK(31, 16)
+#define   HSYNC_END(hsync_end)		REG_FIELD_PREP(HSYNC_END_MASK, (hsync_end))
+#define   HSYNC_START_MASK		REG_GENMASK(15, 0)
+#define   HSYNC_START(hsync_start)	REG_FIELD_PREP(HSYNC_START_MASK, (hsync_start))
+
+#define _TRANS_VTOTAL_A		0x6000c
+#define _TRANS_VTOTAL_B		0x6100c
+#define TRANS_VTOTAL(dev_priv, trans)	_MMIO_TRANS2(dev_priv, (trans), _TRANS_VTOTAL_A)
+#define   VTOTAL_MASK			REG_GENMASK(31, 16)
+#define   VTOTAL(vtotal)		REG_FIELD_PREP(VTOTAL_MASK, (vtotal))
+#define   VACTIVE_MASK			REG_GENMASK(15, 0)
+#define   VACTIVE(vdisplay)		REG_FIELD_PREP(VACTIVE_MASK, (vdisplay))
+
+#define _TRANS_VBLANK_A		0x60010
+#define _TRANS_VBLANK_B		0x61010
+#define TRANS_VBLANK(dev_priv, trans)	_MMIO_TRANS2(dev_priv, (trans), _TRANS_VBLANK_A)
+#define   VBLANK_END_MASK		REG_GENMASK(31, 16)
+#define   VBLANK_END(vblank_end)	REG_FIELD_PREP(VBLANK_END_MASK, (vblank_end))
+#define   VBLANK_START_MASK		REG_GENMASK(15, 0)
+#define   VBLANK_START(vblank_start)	REG_FIELD_PREP(VBLANK_START_MASK, (vblank_start))
+
+#define _TRANS_VSYNC_A		0x60014
+#define _TRANS_VSYNC_B		0x61014
+#define TRANS_VSYNC(dev_priv, trans)	_MMIO_TRANS2(dev_priv, (trans), _TRANS_VSYNC_A)
+#define   VSYNC_END_MASK		REG_GENMASK(31, 16)
+#define   VSYNC_END(vsync_end)		REG_FIELD_PREP(VSYNC_END_MASK, (vsync_end))
+#define   VSYNC_START_MASK		REG_GENMASK(15, 0)
+#define   VSYNC_START(vsync_start)	REG_FIELD_PREP(VSYNC_START_MASK, (vsync_start))
+
+#define _PIPEASRC		0x6001c
+#define _PIPEBSRC		0x6101c
+#define PIPESRC(dev_priv, pipe)		_MMIO_TRANS2(dev_priv, (pipe), _PIPEASRC)
+#define   PIPESRC_WIDTH_MASK	REG_GENMASK(31, 16)
+#define   PIPESRC_WIDTH(w)	REG_FIELD_PREP(PIPESRC_WIDTH_MASK, (w))
+#define   PIPESRC_HEIGHT_MASK	REG_GENMASK(15, 0)
+#define   PIPESRC_HEIGHT(h)	REG_FIELD_PREP(PIPESRC_HEIGHT_MASK, (h))
+
+#define _BCLRPAT_A		0x60020
+#define _BCLRPAT_B		0x61020
+#define BCLRPAT(dev_priv, trans)		_MMIO_TRANS2(dev_priv, (trans), _BCLRPAT_A)
+
+#define _TRANS_VSYNCSHIFT_A	0x60028
+#define _TRANS_VSYNCSHIFT_B	0x61028
+#define TRANS_VSYNCSHIFT(dev_priv, trans)	_MMIO_TRANS2(dev_priv, (trans), _TRANS_VSYNCSHIFT_A)
+
+#define _TRANS_MULT_A		0x6002c
+#define _TRANS_MULT_B		0x6102c
+#define TRANS_MULT(dev_priv, trans)	_MMIO_TRANS2(dev_priv, (trans), _TRANS_MULT_A)
+
+/* Hotplug control (945+ only) */
+#define PORT_HOTPLUG_EN(dev_priv)		_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61110)
+#define   PORTB_HOTPLUG_INT_EN			(1 << 29)
+#define   PORTC_HOTPLUG_INT_EN			(1 << 28)
+#define   PORTD_HOTPLUG_INT_EN			(1 << 27)
+#define   SDVOB_HOTPLUG_INT_EN			(1 << 26)
+#define   SDVOC_HOTPLUG_INT_EN			(1 << 25)
+#define   TV_HOTPLUG_INT_EN			(1 << 18)
+#define   CRT_HOTPLUG_INT_EN			(1 << 9)
+#define HOTPLUG_INT_EN_MASK			(PORTB_HOTPLUG_INT_EN | \
+						 PORTC_HOTPLUG_INT_EN | \
+						 PORTD_HOTPLUG_INT_EN | \
+						 SDVOC_HOTPLUG_INT_EN | \
+						 SDVOB_HOTPLUG_INT_EN | \
+						 CRT_HOTPLUG_INT_EN)
+#define   CRT_HOTPLUG_FORCE_DETECT		(1 << 3)
+#define CRT_HOTPLUG_ACTIVATION_PERIOD_32	(0 << 8)
+/* must use period 64 on GM45 according to docs */
+#define CRT_HOTPLUG_ACTIVATION_PERIOD_64	(1 << 8)
+#define CRT_HOTPLUG_DAC_ON_TIME_2M		(0 << 7)
+#define CRT_HOTPLUG_DAC_ON_TIME_4M		(1 << 7)
+#define CRT_HOTPLUG_VOLTAGE_COMPARE_40		(0 << 5)
+#define CRT_HOTPLUG_VOLTAGE_COMPARE_50		(1 << 5)
+#define CRT_HOTPLUG_VOLTAGE_COMPARE_60		(2 << 5)
+#define CRT_HOTPLUG_VOLTAGE_COMPARE_70		(3 << 5)
+#define CRT_HOTPLUG_VOLTAGE_COMPARE_MASK	(3 << 5)
+#define CRT_HOTPLUG_DETECT_DELAY_1G		(0 << 4)
+#define CRT_HOTPLUG_DETECT_DELAY_2G		(1 << 4)
+#define CRT_HOTPLUG_DETECT_VOLTAGE_325MV	(0 << 2)
+#define CRT_HOTPLUG_DETECT_VOLTAGE_475MV	(1 << 2)
+
+#define PORT_HOTPLUG_STAT(dev_priv)	_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61114)
+/* HDMI/DP bits are g4x+ */
+#define   PORTD_HOTPLUG_LIVE_STATUS_G4X		(1 << 27)
+#define   PORTC_HOTPLUG_LIVE_STATUS_G4X		(1 << 28)
+#define   PORTB_HOTPLUG_LIVE_STATUS_G4X		(1 << 29)
+#define   PORTD_HOTPLUG_INT_STATUS		(3 << 21)
+#define   PORTD_HOTPLUG_INT_LONG_PULSE		(2 << 21)
+#define   PORTD_HOTPLUG_INT_SHORT_PULSE		(1 << 21)
+#define   PORTC_HOTPLUG_INT_STATUS		(3 << 19)
+#define   PORTC_HOTPLUG_INT_LONG_PULSE		(2 << 19)
+#define   PORTC_HOTPLUG_INT_SHORT_PULSE		(1 << 19)
+#define   PORTB_HOTPLUG_INT_STATUS		(3 << 17)
+#define   PORTB_HOTPLUG_INT_LONG_PULSE		(2 << 17)
+#define   PORTB_HOTPLUG_INT_SHORT_PLUSE		(1 << 17)
+/* CRT/TV common between gen3+ */
+#define   CRT_HOTPLUG_INT_STATUS		(1 << 11)
+#define   TV_HOTPLUG_INT_STATUS			(1 << 10)
+#define   CRT_HOTPLUG_MONITOR_MASK		(3 << 8)
+#define   CRT_HOTPLUG_MONITOR_COLOR		(3 << 8)
+#define   CRT_HOTPLUG_MONITOR_MONO		(2 << 8)
+#define   CRT_HOTPLUG_MONITOR_NONE		(0 << 8)
+#define   DP_AUX_CHANNEL_D_INT_STATUS_G4X	(1 << 6)
+#define   DP_AUX_CHANNEL_C_INT_STATUS_G4X	(1 << 5)
+#define   DP_AUX_CHANNEL_B_INT_STATUS_G4X	(1 << 4)
+#define   DP_AUX_CHANNEL_MASK_INT_STATUS_G4X	(7 << 4)
+
+/* SDVO is different across gen3/4 */
+#define   SDVOC_HOTPLUG_INT_STATUS_G4X		(1 << 3)
+#define   SDVOB_HOTPLUG_INT_STATUS_G4X		(1 << 2)
+/*
+ * Bspec seems to be seriously misleaded about the SDVO hpd bits on i965g/gm,
+ * since reality corrobates that they're the same as on gen3. But keep these
+ * bits here (and the comment!) to help any other lost wanderers back onto the
+ * right tracks.
+ */
+#define   SDVOC_HOTPLUG_INT_STATUS_I965		(3 << 4)
+#define   SDVOB_HOTPLUG_INT_STATUS_I965		(3 << 2)
+#define   SDVOC_HOTPLUG_INT_STATUS_I915		(1 << 7)
+#define   SDVOB_HOTPLUG_INT_STATUS_I915		(1 << 6)
+#define   HOTPLUG_INT_STATUS_G4X		(CRT_HOTPLUG_INT_STATUS | \
+						 SDVOB_HOTPLUG_INT_STATUS_G4X | \
+						 SDVOC_HOTPLUG_INT_STATUS_G4X | \
+						 PORTB_HOTPLUG_INT_STATUS | \
+						 PORTC_HOTPLUG_INT_STATUS | \
+						 PORTD_HOTPLUG_INT_STATUS)
+
+#define HOTPLUG_INT_STATUS_I915			(CRT_HOTPLUG_INT_STATUS | \
+						 SDVOB_HOTPLUG_INT_STATUS_I915 | \
+						 SDVOC_HOTPLUG_INT_STATUS_I915 | \
+						 PORTB_HOTPLUG_INT_STATUS | \
+						 PORTC_HOTPLUG_INT_STATUS | \
+						 PORTD_HOTPLUG_INT_STATUS)
+
+/* SDVO and HDMI port control.
+ * The same register may be used for SDVO or HDMI */
+#define _GEN3_SDVOB	0x61140
+#define _GEN3_SDVOC	0x61160
+#define GEN3_SDVOB	_MMIO(_GEN3_SDVOB)
+#define GEN3_SDVOC	_MMIO(_GEN3_SDVOC)
+#define GEN4_HDMIB	GEN3_SDVOB
+#define GEN4_HDMIC	GEN3_SDVOC
+#define VLV_HDMIB	_MMIO(VLV_DISPLAY_BASE + 0x61140)
+#define VLV_HDMIC	_MMIO(VLV_DISPLAY_BASE + 0x61160)
+#define CHV_HDMID	_MMIO(VLV_DISPLAY_BASE + 0x6116C)
+#define PCH_SDVOB	_MMIO(0xe1140)
+#define PCH_HDMIB	PCH_SDVOB
+#define PCH_HDMIC	_MMIO(0xe1150)
+#define PCH_HDMID	_MMIO(0xe1160)
+
+#define PORT_DFT_I9XX				_MMIO(0x61150)
+#define   DC_BALANCE_RESET			(1 << 25)
+#define PORT_DFT2_G4X(dev_priv)		_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61154)
+#define   DC_BALANCE_RESET_VLV			(1 << 31)
+#define   PIPE_SCRAMBLE_RESET_MASK		((1 << 14) | (0x3 << 0))
+#define   PIPE_C_SCRAMBLE_RESET			REG_BIT(14) /* chv */
+#define   PIPE_B_SCRAMBLE_RESET			REG_BIT(1)
+#define   PIPE_A_SCRAMBLE_RESET			REG_BIT(0)
+
+/* Gen 3 SDVO bits: */
+#define   SDVO_ENABLE				(1 << 31)
+#define   SDVO_PIPE_SEL_SHIFT			30
+#define   SDVO_PIPE_SEL_MASK			(1 << 30)
+#define   SDVO_PIPE_SEL(pipe)			((pipe) << 30)
+#define   SDVO_STALL_SELECT			(1 << 29)
+#define   SDVO_INTERRUPT_ENABLE			(1 << 26)
+/*
+ * 915G/GM SDVO pixel multiplier.
+ * Programmed value is multiplier - 1, up to 5x.
+ * \sa DPLL_MD_UDI_MULTIPLIER_MASK
+ */
+#define   SDVO_PORT_MULTIPLY_MASK		(7 << 23)
+#define   SDVO_PORT_MULTIPLY_SHIFT		23
+#define   SDVO_PHASE_SELECT_MASK		(15 << 19)
+#define   SDVO_PHASE_SELECT_DEFAULT		(6 << 19)
+#define   SDVO_CLOCK_OUTPUT_INVERT		(1 << 18)
+#define   SDVOC_GANG_MODE			(1 << 16) /* Port C only */
+#define   SDVO_BORDER_ENABLE			(1 << 7) /* SDVO only */
+#define   SDVOB_PCIE_CONCURRENCY		(1 << 3) /* Port B only */
+#define   SDVO_DETECTED				(1 << 2)
+/* Bits to be preserved when writing */
+#define   SDVOB_PRESERVE_MASK ((1 << 17) | (1 << 16) | (1 << 14) | \
+			       SDVO_INTERRUPT_ENABLE)
+#define   SDVOC_PRESERVE_MASK ((1 << 17) | SDVO_INTERRUPT_ENABLE)
+
+/* Gen 4 SDVO/HDMI bits: */
+#define   SDVO_COLOR_FORMAT_8bpc		(0 << 26)
+#define   SDVO_COLOR_FORMAT_MASK		(7 << 26)
+#define   SDVO_ENCODING_SDVO			(0 << 10)
+#define   SDVO_ENCODING_HDMI			(2 << 10)
+#define   HDMI_MODE_SELECT_HDMI			(1 << 9) /* HDMI only */
+#define   HDMI_MODE_SELECT_DVI			(0 << 9) /* HDMI only */
+#define   HDMI_COLOR_RANGE_16_235		(1 << 8) /* HDMI only */
+#define   HDMI_AUDIO_ENABLE			(1 << 6) /* HDMI only */
+/* VSYNC/HSYNC bits new with 965, default is to be set */
+#define   SDVO_VSYNC_ACTIVE_HIGH		(1 << 4)
+#define   SDVO_HSYNC_ACTIVE_HIGH		(1 << 3)
+
+/* Gen 5 (IBX) SDVO/HDMI bits: */
+#define   HDMI_COLOR_FORMAT_12bpc		(3 << 26) /* HDMI only */
+#define   SDVOB_HOTPLUG_ENABLE			(1 << 23) /* SDVO only */
+
+/* Gen 6 (CPT) SDVO/HDMI bits: */
+#define   SDVO_PIPE_SEL_SHIFT_CPT		29
+#define   SDVO_PIPE_SEL_MASK_CPT		(3 << 29)
+#define   SDVO_PIPE_SEL_CPT(pipe)		((pipe) << 29)
+
+/* CHV SDVO/HDMI bits: */
+#define   SDVO_PIPE_SEL_SHIFT_CHV		24
+#define   SDVO_PIPE_SEL_MASK_CHV		(3 << 24)
+#define   SDVO_PIPE_SEL_CHV(pipe)		((pipe) << 24)
+
+/* Video Data Island Packet control */
+#define VIDEO_DIP_DATA		_MMIO(0x61178)
+/* Read the description of VIDEO_DIP_DATA (before Haswell) or VIDEO_DIP_ECC
+ * (Haswell and newer) to see which VIDEO_DIP_DATA byte corresponds to each byte
+ * of the infoframe structure specified by CEA-861. */
+#define   VIDEO_DIP_DATA_SIZE	32
+#define   VIDEO_DIP_ASYNC_DATA_SIZE	36
+#define   VIDEO_DIP_GMP_DATA_SIZE	36
+#define   VIDEO_DIP_VSC_DATA_SIZE	36
+#define   VIDEO_DIP_PPS_DATA_SIZE	132
+#define VIDEO_DIP_CTL		_MMIO(0x61170)
+/* Pre HSW: */
+#define   VIDEO_DIP_ENABLE		(1 << 31)
+#define   VIDEO_DIP_PORT(port)		((port) << 29)
+#define   VIDEO_DIP_PORT_MASK		(3 << 29)
+#define   VIDEO_DIP_ENABLE_GCP		(1 << 25) /* ilk+ */
+#define   VIDEO_DIP_ENABLE_AVI		(1 << 21)
+#define   VIDEO_DIP_ENABLE_VENDOR	(2 << 21)
+#define   VIDEO_DIP_ENABLE_GAMUT	(4 << 21) /* ilk+ */
+#define   VIDEO_DIP_ENABLE_SPD		(8 << 21)
+#define   VIDEO_DIP_SELECT_AVI		(0 << 19)
+#define   VIDEO_DIP_SELECT_VENDOR	(1 << 19)
+#define   VIDEO_DIP_SELECT_GAMUT	(2 << 19)
+#define   VIDEO_DIP_SELECT_SPD		(3 << 19)
+#define   VIDEO_DIP_SELECT_MASK		(3 << 19)
+#define   VIDEO_DIP_FREQ_ONCE		(0 << 16)
+#define   VIDEO_DIP_FREQ_VSYNC		(1 << 16)
+#define   VIDEO_DIP_FREQ_2VSYNC		(2 << 16)
+#define   VIDEO_DIP_FREQ_MASK		(3 << 16)
+/* HSW and later: */
+#define   VIDEO_DIP_ENABLE_DRM_GLK	(1 << 28)
+#define   PSR_VSC_BIT_7_SET		(1 << 27)
+#define   VSC_SELECT_MASK		(0x3 << 25)
+#define   VSC_SELECT_SHIFT		25
+#define   VSC_DIP_HW_HEA_DATA		(0 << 25)
+#define   VSC_DIP_HW_HEA_SW_DATA	(1 << 25)
+#define   VSC_DIP_HW_DATA_SW_HEA	(2 << 25)
+#define   VSC_DIP_SW_HEA_DATA		(3 << 25)
+#define   VDIP_ENABLE_PPS		(1 << 24)
+#define   VIDEO_DIP_ENABLE_VSC_HSW	(1 << 20)
+#define   VIDEO_DIP_ENABLE_GCP_HSW	(1 << 16)
+#define   VIDEO_DIP_ENABLE_AVI_HSW	(1 << 12)
+#define   VIDEO_DIP_ENABLE_VS_HSW	(1 << 8)
+#define   VIDEO_DIP_ENABLE_GMP_HSW	(1 << 4)
+#define   VIDEO_DIP_ENABLE_SPD_HSW	(1 << 0)
+/* ADL and later: */
+#define   VIDEO_DIP_ENABLE_AS_ADL	REG_BIT(23)
+
+/* Panel fitting */
+#define PFIT_CONTROL(dev_priv)	_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61230)
+#define   PFIT_ENABLE			REG_BIT(31)
+#define   PFIT_PIPE_MASK		REG_GENMASK(30, 29) /* 965+ */
+#define   PFIT_PIPE(pipe)		REG_FIELD_PREP(PFIT_PIPE_MASK, (pipe))
+#define   PFIT_SCALING_MASK		REG_GENMASK(28, 26) /* 965+ */
+#define   PFIT_SCALING_AUTO		REG_FIELD_PREP(PFIT_SCALING_MASK, 0)
+#define   PFIT_SCALING_PROGRAMMED	REG_FIELD_PREP(PFIT_SCALING_MASK, 1)
+#define   PFIT_SCALING_PILLAR		REG_FIELD_PREP(PFIT_SCALING_MASK, 2)
+#define   PFIT_SCALING_LETTER		REG_FIELD_PREP(PFIT_SCALING_MASK, 3)
+#define   PFIT_FILTER_MASK		REG_GENMASK(25, 24) /* 965+ */
+#define   PFIT_FILTER_FUZZY		REG_FIELD_PREP(PFIT_FILTER_MASK, 0)
+#define   PFIT_FILTER_CRISP		REG_FIELD_PREP(PFIT_FILTER_MASK, 1)
+#define   PFIT_FILTER_MEDIAN		REG_FIELD_PREP(PFIT_FILTER_MASK, 2)
+#define   PFIT_VERT_INTERP_MASK		REG_GENMASK(11, 10) /* pre-965 */
+#define   PFIT_VERT_INTERP_BILINEAR	REG_FIELD_PREP(PFIT_VERT_INTERP_MASK, 1)
+#define   PFIT_VERT_AUTO_SCALE		REG_BIT(9) /* pre-965 */
+#define   PFIT_HORIZ_INTERP_MASK	REG_GENMASK(7, 6) /* pre-965 */
+#define   PFIT_HORIZ_INTERP_BILINEAR	REG_FIELD_PREP(PFIT_HORIZ_INTERP_MASK, 1)
+#define   PFIT_HORIZ_AUTO_SCALE		REG_BIT(5) /* pre-965 */
+#define   PFIT_PANEL_8TO6_DITHER_ENABLE	REG_BIT(3) /* pre-965 */
+
+#define PFIT_PGM_RATIOS(dev_priv) _MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61234)
+#define   PFIT_VERT_SCALE_MASK		REG_GENMASK(31, 20) /* pre-965 */
+#define   PFIT_VERT_SCALE(x)		REG_FIELD_PREP(PFIT_VERT_SCALE_MASK, (x))
+#define   PFIT_HORIZ_SCALE_MASK		REG_GENMASK(15, 4) /* pre-965 */
+#define   PFIT_HORIZ_SCALE(x)		REG_FIELD_PREP(PFIT_HORIZ_SCALE_MASK, (x))
+#define   PFIT_VERT_SCALE_MASK_965	REG_GENMASK(28, 16) /* 965+ */
+#define   PFIT_HORIZ_SCALE_MASK_965	REG_GENMASK(12, 0) /* 965+ */
+
+#define PFIT_AUTO_RATIOS(dev_priv) _MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61238)
+
+#define PCH_GTC_CTL		_MMIO(0xe7000)
+#define   PCH_GTC_ENABLE	(1 << 31)
+
+/* Display Port */
+#define DP_A			_MMIO(0x64000) /* eDP */
+#define DP_B			_MMIO(0x64100)
+#define DP_C			_MMIO(0x64200)
+#define DP_D			_MMIO(0x64300)
+#define VLV_DP_B		_MMIO(VLV_DISPLAY_BASE + 0x64100)
+#define VLV_DP_C		_MMIO(VLV_DISPLAY_BASE + 0x64200)
+#define CHV_DP_D		_MMIO(VLV_DISPLAY_BASE + 0x64300)
+#define   DP_PORT_EN			REG_BIT(31)
+#define   DP_PIPE_SEL_MASK		REG_GENMASK(30, 30)
+#define   DP_PIPE_SEL(pipe)		REG_FIELD_PREP(DP_PIPE_SEL_MASK, (pipe))
+#define   DP_PIPE_SEL_MASK_IVB		REG_GENMASK(30, 29)
+#define   DP_PIPE_SEL_IVB(pipe)		REG_FIELD_PREP(DP_PIPE_SEL_MASK_IVB, (pipe))
+#define   DP_PIPE_SEL_SHIFT_CHV		16
+#define   DP_PIPE_SEL_MASK_CHV		REG_GENMASK(17, 16)
+#define   DP_PIPE_SEL_CHV(pipe)		REG_FIELD_PREP(DP_PIPE_SEL_MASK_CHV, (pipe))
+#define   DP_LINK_TRAIN_MASK		REG_GENMASK(29, 28)
+#define   DP_LINK_TRAIN_PAT_1		REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 0)
+#define   DP_LINK_TRAIN_PAT_2		REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 1)
+#define   DP_LINK_TRAIN_PAT_IDLE	REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 2)
+#define   DP_LINK_TRAIN_OFF		REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 3)
+#define   DP_LINK_TRAIN_MASK_CPT	REG_GENMASK(10, 8)
+#define   DP_LINK_TRAIN_PAT_1_CPT	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 0)
+#define   DP_LINK_TRAIN_PAT_2_CPT	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 1)
+#define   DP_LINK_TRAIN_PAT_IDLE_CPT	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 2)
+#define   DP_LINK_TRAIN_OFF_CPT		REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 3)
+#define   DP_VOLTAGE_MASK		REG_GENMASK(27, 25)
+#define   DP_VOLTAGE_0_4		REG_FIELD_PREP(DP_VOLTAGE_MASK, 0)
+#define   DP_VOLTAGE_0_6		REG_FIELD_PREP(DP_VOLTAGE_MASK, 1)
+#define   DP_VOLTAGE_0_8		REG_FIELD_PREP(DP_VOLTAGE_MASK, 2)
+#define   DP_VOLTAGE_1_2		REG_FIELD_PREP(DP_VOLTAGE_MASK, 3)
+#define   DP_PRE_EMPHASIS_MASK		REG_GENMASK(24, 22)
+#define   DP_PRE_EMPHASIS_0		REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 0)
+#define   DP_PRE_EMPHASIS_3_5		REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 1)
+#define   DP_PRE_EMPHASIS_6		REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 2)
+#define   DP_PRE_EMPHASIS_9_5		REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 3)
+#define   DP_PORT_WIDTH_MASK		REG_GENMASK(21, 19)
+#define   DP_PORT_WIDTH(width)		REG_FIELD_PREP(DP_PORT_WIDTH_MASK, (width) - 1)
+#define   DP_ENHANCED_FRAMING		REG_BIT(18)
+#define   EDP_PLL_FREQ_MASK		REG_GENMASK(17, 16)
+#define   EDP_PLL_FREQ_270MHZ		REG_FIELD_PREP(EDP_PLL_FREQ_MASK, 0)
+#define   EDP_PLL_FREQ_162MHZ		REG_FIELD_PREP(EDP_PLL_FREQ_MASK, 1)
+#define   DP_PORT_REVERSAL		REG_BIT(15)
+#define   EDP_PLL_ENABLE		REG_BIT(14)
+#define   DP_CLOCK_OUTPUT_ENABLE	REG_BIT(13)
+#define   DP_SCRAMBLING_DISABLE		REG_BIT(12)
+#define   DP_SCRAMBLING_DISABLE_ILK	REG_BIT(7)
+#define   DP_COLOR_RANGE_16_235		REG_BIT(8)
+#define   DP_AUDIO_OUTPUT_ENABLE	REG_BIT(6)
+#define   DP_SYNC_VS_HIGH		REG_BIT(4)
+#define   DP_SYNC_HS_HIGH		REG_BIT(3)
+#define   DP_DETECTED			REG_BIT(2)
+
+/*
+ * Computing GMCH M and N values for the Display Port link
+ *
+ * GMCH M/N = dot clock * bytes per pixel / ls_clk * # of lanes
+ *
+ * ls_clk (we assume) is the DP link clock (1.62 or 2.7 GHz)
+ *
+ * The GMCH value is used internally
+ *
+ * bytes_per_pixel is the number of bytes coming out of the plane,
+ * which is after the LUTs, so we want the bytes for our color format.
+ * For our current usage, this is always 3, one byte for R, G and B.
+ */
+#define _PIPEA_DATA_M_G4X	0x70050
+#define _PIPEB_DATA_M_G4X	0x71050
+#define PIPE_DATA_M_G4X(pipe) _MMIO_PIPE(pipe, _PIPEA_DATA_M_G4X, _PIPEB_DATA_M_G4X)
+/* Transfer unit size for display port - 1, default is 0x3f (for TU size 64) */
+#define  TU_SIZE_MASK		REG_GENMASK(30, 25)
+#define  TU_SIZE(x)		REG_FIELD_PREP(TU_SIZE_MASK, (x) - 1) /* default size 64 */
+#define  DATA_LINK_M_N_MASK	REG_GENMASK(23, 0)
+#define  DATA_LINK_N_MAX	(0x800000)
+
+#define _PIPEA_DATA_N_G4X	0x70054
+#define _PIPEB_DATA_N_G4X	0x71054
+#define PIPE_DATA_N_G4X(pipe) _MMIO_PIPE(pipe, _PIPEA_DATA_N_G4X, _PIPEB_DATA_N_G4X)
+
+/*
+ * Computing Link M and N values for the Display Port link
+ *
+ * Link M / N = pixel_clock / ls_clk
+ *
+ * (the DP spec calls pixel_clock the 'strm_clk')
+ *
+ * The Link value is transmitted in the Main Stream
+ * Attributes and VB-ID.
+ */
+#define _PIPEA_LINK_M_G4X	0x70060
+#define _PIPEB_LINK_M_G4X	0x71060
+#define PIPE_LINK_M_G4X(pipe) _MMIO_PIPE(pipe, _PIPEA_LINK_M_G4X, _PIPEB_LINK_M_G4X)
+
+#define _PIPEA_LINK_N_G4X	0x70064
+#define _PIPEB_LINK_N_G4X	0x71064
+#define PIPE_LINK_N_G4X(pipe) _MMIO_PIPE(pipe, _PIPEA_LINK_N_G4X, _PIPEB_LINK_N_G4X)
+
+/* Pipe A */
+#define _PIPEADSL		0x70000
+#define PIPEDSL(dev_priv, pipe)		_MMIO_PIPE2(dev_priv, pipe, _PIPEADSL)
+#define   PIPEDSL_CURR_FIELD	REG_BIT(31) /* ctg+ */
+#define   PIPEDSL_LINE_MASK	REG_GENMASK(19, 0)
+
+#define _TRANSACONF		0x70008
+#define TRANSCONF(dev_priv, trans)	_MMIO_PIPE2(dev_priv, (trans), _TRANSACONF)
+#define   TRANSCONF_ENABLE			REG_BIT(31)
+#define   TRANSCONF_DOUBLE_WIDE			REG_BIT(30) /* pre-i965 */
+#define   TRANSCONF_STATE_ENABLE			REG_BIT(30) /* i965+ */
+#define   TRANSCONF_DSI_PLL_LOCKED		REG_BIT(29) /* vlv & pipe A only */
+#define   TRANSCONF_FRAME_START_DELAY_MASK	REG_GENMASK(28, 27) /* pre-hsw */
+#define   TRANSCONF_FRAME_START_DELAY(x)		REG_FIELD_PREP(TRANSCONF_FRAME_START_DELAY_MASK, (x)) /* pre-hsw: 0-3 */
+#define   TRANSCONF_PIPE_LOCKED			REG_BIT(25)
+#define   TRANSCONF_FORCE_BORDER			REG_BIT(25)
+#define   TRANSCONF_GAMMA_MODE_MASK_I9XX		REG_BIT(24) /* gmch */
+#define   TRANSCONF_GAMMA_MODE_MASK_ILK		REG_GENMASK(25, 24) /* ilk-ivb */
+#define   TRANSCONF_GAMMA_MODE_8BIT		REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK, 0)
+#define   TRANSCONF_GAMMA_MODE_10BIT		REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK, 1)
+#define   TRANSCONF_GAMMA_MODE_12BIT		REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK_ILK, 2) /* ilk-ivb */
+#define   TRANSCONF_GAMMA_MODE_SPLIT		REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK_ILK, 3) /* ivb */
+#define   TRANSCONF_GAMMA_MODE(x)		REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK_ILK, (x)) /* pass in GAMMA_MODE_MODE_* */
+#define   TRANSCONF_INTERLACE_MASK		REG_GENMASK(23, 21) /* gen3+ */
+#define   TRANSCONF_INTERLACE_PROGRESSIVE	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 0)
+#define   TRANSCONF_INTERLACE_W_SYNC_SHIFT_PANEL	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 4) /* gen4 only */
+#define   TRANSCONF_INTERLACE_W_SYNC_SHIFT	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 5) /* gen4 only */
+#define   TRANSCONF_INTERLACE_W_FIELD_INDICATION	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 6)
+#define   TRANSCONF_INTERLACE_FIELD_0_ONLY	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 7) /* gen3 only */
+/*
+ * ilk+: PF/D=progressive fetch/display, IF/D=interlaced fetch/display,
+ * DBL=power saving pixel doubling, PF-ID* requires panel fitter
+ */
+#define   TRANSCONF_INTERLACE_MASK_ILK		REG_GENMASK(23, 21) /* ilk+ */
+#define   TRANSCONF_INTERLACE_MASK_HSW		REG_GENMASK(22, 21) /* hsw+ */
+#define   TRANSCONF_INTERLACE_PF_PD_ILK		REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 0)
+#define   TRANSCONF_INTERLACE_PF_ID_ILK		REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 1)
+#define   TRANSCONF_INTERLACE_IF_ID_ILK		REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 3)
+#define   TRANSCONF_INTERLACE_IF_ID_DBL_ILK	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 4) /* ilk/snb only */
+#define   TRANSCONF_INTERLACE_PF_ID_DBL_ILK	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 5) /* ilk/snb only */
+#define   TRANSCONF_REFRESH_RATE_ALT_ILK		REG_BIT(20)
+#define   TRANSCONF_MSA_TIMING_DELAY_MASK	REG_GENMASK(19, 18) /* ilk/snb/ivb */
+#define   TRANSCONF_MSA_TIMING_DELAY(x)		REG_FIELD_PREP(TRANSCONF_MSA_TIMING_DELAY_MASK, (x))
+#define   TRANSCONF_CXSR_DOWNCLOCK		REG_BIT(16)
+#define   TRANSCONF_WGC_ENABLE			REG_BIT(15) /* vlv/chv only */
+#define   TRANSCONF_REFRESH_RATE_ALT_VLV		REG_BIT(14)
+#define   TRANSCONF_COLOR_RANGE_SELECT		REG_BIT(13)
+#define   TRANSCONF_OUTPUT_COLORSPACE_MASK	REG_GENMASK(12, 11) /* ilk-ivb */
+#define   TRANSCONF_OUTPUT_COLORSPACE_RGB	REG_FIELD_PREP(TRANSCONF_OUTPUT_COLORSPACE_MASK, 0) /* ilk-ivb */
+#define   TRANSCONF_OUTPUT_COLORSPACE_YUV601	REG_FIELD_PREP(TRANSCONF_OUTPUT_COLORSPACE_MASK, 1) /* ilk-ivb */
+#define   TRANSCONF_OUTPUT_COLORSPACE_YUV709	REG_FIELD_PREP(TRANSCONF_OUTPUT_COLORSPACE_MASK, 2) /* ilk-ivb */
+#define   TRANSCONF_OUTPUT_COLORSPACE_YUV_HSW	REG_BIT(11) /* hsw only */
+#define   TRANSCONF_BPC_MASK			REG_GENMASK(7, 5) /* ctg-ivb */
+#define   TRANSCONF_BPC_8			REG_FIELD_PREP(TRANSCONF_BPC_MASK, 0)
+#define   TRANSCONF_BPC_10			REG_FIELD_PREP(TRANSCONF_BPC_MASK, 1)
+#define   TRANSCONF_BPC_6			REG_FIELD_PREP(TRANSCONF_BPC_MASK, 2)
+#define   TRANSCONF_BPC_12			REG_FIELD_PREP(TRANSCONF_BPC_MASK, 3)
+#define   TRANSCONF_DITHER_EN			REG_BIT(4)
+#define   TRANSCONF_DITHER_TYPE_MASK		REG_GENMASK(3, 2)
+#define   TRANSCONF_DITHER_TYPE_SP		REG_FIELD_PREP(TRANSCONF_DITHER_TYPE_MASK, 0)
+#define   TRANSCONF_DITHER_TYPE_ST1		REG_FIELD_PREP(TRANSCONF_DITHER_TYPE_MASK, 1)
+#define   TRANSCONF_DITHER_TYPE_ST2		REG_FIELD_PREP(TRANSCONF_DITHER_TYPE_MASK, 2)
+#define   TRANSCONF_DITHER_TYPE_TEMP		REG_FIELD_PREP(TRANSCONF_DITHER_TYPE_MASK, 3)
+#define   TRANSCONF_PIXEL_COUNT_SCALING_MASK	REG_GENMASK(1, 0)
+#define   TRANSCONF_PIXEL_COUNT_SCALING_X4	1
+
+#define _PIPE_ARB_CTL_A			0x70028 /* icl+ */
+#define PIPE_ARB_CTL(dev_priv, pipe)		_MMIO_PIPE2(dev_priv, pipe, _PIPE_ARB_CTL_A)
+#define   PIPE_ARB_USE_PROG_SLOTS	REG_BIT(13)
+
+#define _PIPE_MISC_A			0x70030
+#define _PIPE_MISC_B			0x71030
+#define PIPE_MISC(pipe)			_MMIO_PIPE(pipe, _PIPE_MISC_A, _PIPE_MISC_B)
+#define   PIPE_MISC_YUV420_ENABLE		REG_BIT(27) /* glk+ */
+#define   PIPE_MISC_YUV420_MODE_FULL_BLEND	REG_BIT(26) /* glk+ */
+#define   PIPE_MISC_HDR_MODE_PRECISION		REG_BIT(23) /* icl+ */
+#define   PIPE_MISC_PSR_MASK_PRIMARY_FLIP	REG_BIT(23) /* bdw */
+#define   PIPE_MISC_PSR_MASK_SPRITE_ENABLE	REG_BIT(22) /* bdw */
+#define   PIPE_MISC_PSR_MASK_PIPE_REG_WRITE	REG_BIT(21) /* skl+ */
+#define   PIPE_MISC_PSR_MASK_CURSOR_MOVE	REG_BIT(21) /* bdw */
+#define   PIPE_MISC_PSR_MASK_VBLANK_VSYNC_INT	REG_BIT(20)
+#define   PIPE_MISC_OUTPUT_COLORSPACE_YUV	REG_BIT(11)
+#define   PIPE_MISC_PIXEL_ROUNDING_TRUNC	REG_BIT(8) /* tgl+ */
+/*
+ * For Display < 13, Bits 5-7 of PIPE MISC represent DITHER BPC with
+ * valid values of: 6, 8, 10 BPC.
+ * ADLP+, the bits 5-7 represent PORT OUTPUT BPC with valid values of:
+ * 6, 8, 10, 12 BPC.
+ */
+#define   PIPE_MISC_BPC_MASK			REG_GENMASK(7, 5)
+#define   PIPE_MISC_BPC_8			REG_FIELD_PREP(PIPE_MISC_BPC_MASK, 0)
+#define   PIPE_MISC_BPC_10			REG_FIELD_PREP(PIPE_MISC_BPC_MASK, 1)
+#define   PIPE_MISC_BPC_6			REG_FIELD_PREP(PIPE_MISC_BPC_MASK, 2)
+#define   PIPE_MISC_BPC_12_ADLP			REG_FIELD_PREP(PIPE_MISC_BPC_MASK, 4) /* adlp+ */
+#define   PIPE_MISC_DITHER_ENABLE		REG_BIT(4)
+#define   PIPE_MISC_DITHER_TYPE_MASK		REG_GENMASK(3, 2)
+#define   PIPE_MISC_DITHER_TYPE_SP		REG_FIELD_PREP(PIPE_MISC_DITHER_TYPE_MASK, 0)
+#define   PIPE_MISC_DITHER_TYPE_ST1		REG_FIELD_PREP(PIPE_MISC_DITHER_TYPE_MASK, 1)
+#define   PIPE_MISC_DITHER_TYPE_ST2		REG_FIELD_PREP(PIPE_MISC_DITHER_TYPE_MASK, 2)
+#define   PIPE_MISC_DITHER_TYPE_TEMP		REG_FIELD_PREP(PIPE_MISC_DITHER_TYPE_MASK, 3)
+
+#define DPINVGTT				_MMIO(VLV_DISPLAY_BASE + 0x7002c) /* VLV/CHV only */
+#define   DPINVGTT_EN_MASK_CHV				REG_GENMASK(27, 16)
+#define   DPINVGTT_EN_MASK_VLV				REG_GENMASK(23, 16)
+#define   SPRITEF_INVALID_GTT_INT_EN			REG_BIT(27)
+#define   SPRITEE_INVALID_GTT_INT_EN			REG_BIT(26)
+#define   PLANEC_INVALID_GTT_INT_EN			REG_BIT(25)
+#define   CURSORC_INVALID_GTT_INT_EN			REG_BIT(24)
+#define   CURSORB_INVALID_GTT_INT_EN			REG_BIT(23)
+#define   CURSORA_INVALID_GTT_INT_EN			REG_BIT(22)
+#define   SPRITED_INVALID_GTT_INT_EN			REG_BIT(21)
+#define   SPRITEC_INVALID_GTT_INT_EN			REG_BIT(20)
+#define   PLANEB_INVALID_GTT_INT_EN			REG_BIT(19)
+#define   SPRITEB_INVALID_GTT_INT_EN			REG_BIT(18)
+#define   SPRITEA_INVALID_GTT_INT_EN			REG_BIT(17)
+#define   PLANEA_INVALID_GTT_INT_EN			REG_BIT(16)
+#define   DPINVGTT_STATUS_MASK_CHV			REG_GENMASK(11, 0)
+#define   DPINVGTT_STATUS_MASK_VLV			REG_GENMASK(7, 0)
+#define   SPRITEF_INVALID_GTT_STATUS			REG_BIT(11)
+#define   SPRITEE_INVALID_GTT_STATUS			REG_BIT(10)
+#define   PLANEC_INVALID_GTT_STATUS			REG_BIT(9)
+#define   CURSORC_INVALID_GTT_STATUS			REG_BIT(8)
+#define   CURSORB_INVALID_GTT_STATUS			REG_BIT(7)
+#define   CURSORA_INVALID_GTT_STATUS			REG_BIT(6)
+#define   SPRITED_INVALID_GTT_STATUS			REG_BIT(5)
+#define   SPRITEC_INVALID_GTT_STATUS			REG_BIT(4)
+#define   PLANEB_INVALID_GTT_STATUS			REG_BIT(3)
+#define   SPRITEB_INVALID_GTT_STATUS			REG_BIT(2)
+#define   SPRITEA_INVALID_GTT_STATUS			REG_BIT(1)
+#define   PLANEA_INVALID_GTT_STATUS			REG_BIT(0)
+
+#define CBR1_VLV			_MMIO(VLV_DISPLAY_BASE + 0x70400)
+#define  CBR_PND_DEADLINE_DISABLE	(1 << 31)
+#define  CBR_PWM_CLOCK_MUX_SELECT	(1 << 30)
+
+#define CBR4_VLV			_MMIO(VLV_DISPLAY_BASE + 0x70450)
+#define  CBR_DPLLBMD_PIPE(pipe)		(1 << (7 + (pipe) * 11)) /* pipes B and C */
+
+/*
+ * The two pipe frame counter registers are not synchronized, so
+ * reading a stable value is somewhat tricky. The following code
+ * should work:
+ *
+ *  do {
+ *    high1 = ((INREG(PIPEAFRAMEHIGH) & PIPE_FRAME_HIGH_MASK) >>
+ *             PIPE_FRAME_HIGH_SHIFT;
+ *    low1 =  ((INREG(PIPEAFRAMEPIXEL) & PIPE_FRAME_LOW_MASK) >>
+ *             PIPE_FRAME_LOW_SHIFT);
+ *    high2 = ((INREG(PIPEAFRAMEHIGH) & PIPE_FRAME_HIGH_MASK) >>
+ *             PIPE_FRAME_HIGH_SHIFT);
+ *  } while (high1 != high2);
+ *  frame = (high1 << 8) | low1;
+ */
+#define _PIPEAFRAMEHIGH          0x70040
+#define PIPEFRAME(dev_priv, pipe)		_MMIO_PIPE2(dev_priv, pipe, _PIPEAFRAMEHIGH)
+#define   PIPE_FRAME_HIGH_MASK    0x0000ffff
+#define   PIPE_FRAME_HIGH_SHIFT   0
+
+#define _PIPEAFRAMEPIXEL         0x70044
+#define PIPEFRAMEPIXEL(dev_priv, pipe)	_MMIO_PIPE2(dev_priv, pipe, _PIPEAFRAMEPIXEL)
+#define   PIPE_FRAME_LOW_MASK     0xff000000
+#define   PIPE_FRAME_LOW_SHIFT    24
+#define   PIPE_PIXEL_MASK         0x00ffffff
+#define   PIPE_PIXEL_SHIFT        0
+
+/* GM45+ just has to be different */
+#define _PIPEA_FRMCOUNT_G4X	0x70040
+#define PIPE_FRMCOUNT_G4X(dev_priv, pipe) _MMIO_PIPE2(dev_priv, pipe, _PIPEA_FRMCOUNT_G4X)
+
+/* CHV pipe B blender */
+#define _CHV_BLEND_A		0x60a00
+#define CHV_BLEND(dev_priv, pipe)		_MMIO_TRANS2(dev_priv, pipe, _CHV_BLEND_A)
+#define   CHV_BLEND_MASK	REG_GENMASK(31, 30)
+#define   CHV_BLEND_LEGACY	REG_FIELD_PREP(CHV_BLEND_MASK, 0)
+#define   CHV_BLEND_ANDROID	REG_FIELD_PREP(CHV_BLEND_MASK, 1)
+#define   CHV_BLEND_MPO		REG_FIELD_PREP(CHV_BLEND_MASK, 2)
+
+#define _CHV_CANVAS_A		0x60a04
+#define CHV_CANVAS(dev_priv, pipe)	_MMIO_TRANS2(dev_priv, pipe, _CHV_CANVAS_A)
+#define   CHV_CANVAS_RED_MASK	REG_GENMASK(29, 20)
+#define   CHV_CANVAS_GREEN_MASK	REG_GENMASK(19, 10)
+#define   CHV_CANVAS_BLUE_MASK	REG_GENMASK(9, 0)
+
+/*
+ * VBIOS flags
+ * gen2:
+ * [00:06] alm,mgm
+ * [10:16] all
+ * [30:32] alm,mgm
+ * gen3+:
+ * [00:0f] all
+ * [10:1f] all
+ * [30:32] all
+ */
+#define SWF0(dev_priv, i)	_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x70410 + (i) * 4)
+#define SWF1(dev_priv, i)	_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x71410 + (i) * 4)
+#define SWF3(dev_priv, i)	_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x72414 + (i) * 4)
+#define SWF_ILK(i)	_MMIO(0x4F000 + (i) * 4)
+
+/* VBIOS regs */
+#define VGACNTRL		_MMIO(0x71400)
+# define VGA_DISP_DISABLE			(1 << 31)
+# define VGA_2X_MODE				(1 << 30)
+# define VGA_PIPE_B_SELECT			(1 << 29)
+
+#define VLV_VGACNTRL		_MMIO(VLV_DISPLAY_BASE + 0x71400)
+
+#define CPU_VGACNTRL	_MMIO(0x41000)
+
+#define DIGITAL_PORT_HOTPLUG_CNTRL	_MMIO(0x44030)
+#define  DIGITAL_PORTA_HOTPLUG_ENABLE		(1 << 4)
+#define  DIGITAL_PORTA_PULSE_DURATION_2ms	(0 << 2) /* pre-HSW */
+#define  DIGITAL_PORTA_PULSE_DURATION_4_5ms	(1 << 2) /* pre-HSW */
+#define  DIGITAL_PORTA_PULSE_DURATION_6ms	(2 << 2) /* pre-HSW */
+#define  DIGITAL_PORTA_PULSE_DURATION_100ms	(3 << 2) /* pre-HSW */
+#define  DIGITAL_PORTA_PULSE_DURATION_MASK	(3 << 2) /* pre-HSW */
+#define  DIGITAL_PORTA_HOTPLUG_STATUS_MASK	(3 << 0)
+#define  DIGITAL_PORTA_HOTPLUG_NO_DETECT	(0 << 0)
+#define  DIGITAL_PORTA_HOTPLUG_SHORT_DETECT	(1 << 0)
+#define  DIGITAL_PORTA_HOTPLUG_LONG_DETECT	(2 << 0)
+
+#define _PIPEA_DATA_M1		0x60030
+#define _PIPEB_DATA_M1		0x61030
+#define PIPE_DATA_M1(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, _PIPEA_DATA_M1)
+
+#define _PIPEA_DATA_N1		0x60034
+#define _PIPEB_DATA_N1		0x61034
+#define PIPE_DATA_N1(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, _PIPEA_DATA_N1)
+
+#define _PIPEA_DATA_M2		0x60038
+#define _PIPEB_DATA_M2		0x61038
+#define PIPE_DATA_M2(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, _PIPEA_DATA_M2)
+
+#define _PIPEA_DATA_N2		0x6003c
+#define _PIPEB_DATA_N2		0x6103c
+#define PIPE_DATA_N2(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, _PIPEA_DATA_N2)
+
+#define _PIPEA_LINK_M1		0x60040
+#define _PIPEB_LINK_M1		0x61040
+#define PIPE_LINK_M1(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, _PIPEA_LINK_M1)
+
+#define _PIPEA_LINK_N1		0x60044
+#define _PIPEB_LINK_N1		0x61044
+#define PIPE_LINK_N1(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, _PIPEA_LINK_N1)
+
+#define _PIPEA_LINK_M2		0x60048
+#define _PIPEB_LINK_M2		0x61048
+#define PIPE_LINK_M2(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, _PIPEA_LINK_M2)
+
+#define _PIPEA_LINK_N2		0x6004c
+#define _PIPEB_LINK_N2		0x6104c
+#define PIPE_LINK_N2(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, _PIPEA_LINK_N2)
+
+/* CPU panel fitter */
+/* IVB+ has 3 fitters, 0 is 7x5 capable, the other two only 3x3 */
+#define _PFA_CTL_1		0x68080
+#define _PFB_CTL_1		0x68880
+#define PF_CTL(pipe)		_MMIO_PIPE(pipe, _PFA_CTL_1, _PFB_CTL_1)
+#define   PF_ENABLE			REG_BIT(31)
+#define   PF_PIPE_SEL_MASK_IVB		REG_GENMASK(30, 29) /* ivb/hsw */
+#define   PF_PIPE_SEL_IVB(pipe)		REG_FIELD_PREP(PF_PIPE_SEL_MASK_IVB, (pipe))
+#define   PF_FILTER_MASK		REG_GENMASK(24, 23)
+#define   PF_FILTER_PROGRAMMED		REG_FIELD_PREP(PF_FILTER_MASK, 0)
+#define   PF_FILTER_MED_3x3		REG_FIELD_PREP(PF_FILTER_MASK, 1)
+#define   PF_FILTER_EDGE_ENHANCE	REG_FIELD_PREP(PF_FILTER_EDGE_MASK, 2)
+#define   PF_FILTER_EDGE_SOFTEN		REG_FIELD_PREP(PF_FILTER_EDGE_MASK, 3)
+
+#define _PFA_WIN_SZ		0x68074
+#define _PFB_WIN_SZ		0x68874
+#define PF_WIN_SZ(pipe)		_MMIO_PIPE(pipe, _PFA_WIN_SZ, _PFB_WIN_SZ)
+#define   PF_WIN_XSIZE_MASK	REG_GENMASK(31, 16)
+#define   PF_WIN_XSIZE(w)	REG_FIELD_PREP(PF_WIN_XSIZE_MASK, (w))
+#define   PF_WIN_YSIZE_MASK	REG_GENMASK(15, 0)
+#define   PF_WIN_YSIZE(h)	REG_FIELD_PREP(PF_WIN_YSIZE_MASK, (h))
+
+#define _PFA_WIN_POS		0x68070
+#define _PFB_WIN_POS		0x68870
+#define PF_WIN_POS(pipe)	_MMIO_PIPE(pipe, _PFA_WIN_POS, _PFB_WIN_POS)
+#define   PF_WIN_XPOS_MASK	REG_GENMASK(31, 16)
+#define   PF_WIN_XPOS(x)	REG_FIELD_PREP(PF_WIN_XPOS_MASK, (x))
+#define   PF_WIN_YPOS_MASK	REG_GENMASK(15, 0)
+#define   PF_WIN_YPOS(y)	REG_FIELD_PREP(PF_WIN_YPOS_MASK, (y))
+
+/*
+ * Skylake scalers
+ */
+#define _ID(id, a, b) _PICK_EVEN(id, a, b)
+#define _PS_1A_CTRL      0x68180
+#define _PS_2A_CTRL      0x68280
+#define _PS_1B_CTRL      0x68980
+#define _PS_2B_CTRL      0x68A80
+#define _PS_1C_CTRL      0x69180
+#define SKL_PS_CTRL(pipe, id) _MMIO_PIPE(pipe,        \
+			_ID(id, _PS_1A_CTRL, _PS_2A_CTRL),       \
+			_ID(id, _PS_1B_CTRL, _PS_2B_CTRL))
+#define   PS_SCALER_EN				REG_BIT(31)
+#define   PS_SCALER_TYPE_MASK			REG_BIT(30) /* icl+ */
+#define   PS_SCALER_TYPE_NON_LINEAR		REG_FIELD_PREP(PS_SCALER_TYPE_MASK, 0)
+#define   PS_SCALER_TYPE_LINEAR			REG_FIELD_PREP(PS_SCALER_TYPE_MASK, 1)
+#define   SKL_PS_SCALER_MODE_MASK		REG_GENMASK(29, 28) /* skl/bxt */
+#define   SKL_PS_SCALER_MODE_DYN		REG_FIELD_PREP(SKL_PS_SCALER_MODE_MASK, 0)
+#define   SKL_PS_SCALER_MODE_HQ			REG_FIELD_PREP(SKL_PS_SCALER_MODE_MASK, 1)
+#define   SKL_PS_SCALER_MODE_NV12		REG_FIELD_PREP(SKL_PS_SCALER_MODE_MASK, 2)
+#define   PS_SCALER_MODE_MASK			REG_BIT(29) /* glk-tgl */
+#define   PS_SCALER_MODE_NORMAL			REG_FIELD_PREP(PS_SCALER_MODE_MASK, 0)
+#define   PS_SCALER_MODE_PLANAR			REG_FIELD_PREP(PS_SCALER_MODE_MASK, 1)
+#define   PS_ADAPTIVE_FILTERING_EN		REG_BIT(28) /* icl+ */
+#define   PS_BINDING_MASK			REG_GENMASK(27, 25)
+#define   PS_BINDING_PIPE			REG_FIELD_PREP(PS_BINDING_MASK, 0)
+#define   PS_BINDING_PLANE(plane_id)		REG_FIELD_PREP(PS_BINDING_MASK, (plane_id) + 1)
+#define   PS_FILTER_MASK			REG_GENMASK(24, 23)
+#define   PS_FILTER_MEDIUM			REG_FIELD_PREP(PS_FILTER_MASK, 0)
+#define   PS_FILTER_PROGRAMMED			REG_FIELD_PREP(PS_FILTER_MASK, 1)
+#define   PS_FILTER_EDGE_ENHANCE		REG_FIELD_PREP(PS_FILTER_MASK, 2)
+#define   PS_FILTER_BILINEAR			REG_FIELD_PREP(PS_FILTER_MASK, 3)
+#define   PS_ADAPTIVE_FILTER_MASK		REG_BIT(22) /* icl+ */
+#define   PS_ADAPTIVE_FILTER_MEDIUM		REG_FIELD_PREP(PS_ADAPTIVE_FILTER_MASK, 0)
+#define   PS_ADAPTIVE_FILTER_EDGE_ENHANCE	REG_FIELD_PREP(PS_ADAPTIVE_FILTER_MASK, 1)
+#define   PS_PIPE_SCALER_LOC_MASK		REG_BIT(21) /* icl+ */
+#define   PS_PIPE_SCALER_LOC_AFTER_OUTPUT_CSC	REG_FIELD_PREP(PS_SCALER_LOCATION_MASK, 0) /* non-linear */
+#define   PS_PIPE_SCALER_LOC_AFTER_CSC		REG_FIELD_PREP(PS_SCALER_LOCATION_MASK, 1) /* linear */
+#define   PS_VERT3TAP				REG_BIT(21) /* skl/bxt */
+#define   PS_VERT_INT_INVERT_FIELD		REG_BIT(20)
+#define   PS_PROG_SCALE_FACTOR			REG_BIT(19) /* tgl+ */
+#define   PS_PWRUP_PROGRESS			REG_BIT(17)
+#define   PS_V_FILTER_BYPASS			REG_BIT(8)
+#define   PS_VADAPT_EN				REG_BIT(7) /* skl/bxt */
+#define   PS_VADAPT_MODE_MASK			REG_GENMASK(6, 5) /* skl/bxt */
+#define   PS_VADAPT_MODE_LEAST_ADAPT		REG_FIELD_PREP(PS_VADAPT_MODE_MASK, 0)
+#define   PS_VADAPT_MODE_MOD_ADAPT		REG_FIELD_PREP(PS_VADAPT_MODE_MASK, 1)
+#define   PS_VADAPT_MODE_MOST_ADAPT		REG_FIELD_PREP(PS_VADAPT_MODE_MASK, 3)
+#define   PS_BINDING_Y_MASK			REG_GENMASK(7, 5) /* icl-tgl */
+#define   PS_BINDING_Y_PLANE(plane_id)		REG_FIELD_PREP(PS_BINDING_Y_MASK, (plane_id) + 1)
+#define   PS_Y_VERT_FILTER_SELECT_MASK		REG_BIT(4) /* glk+ */
+#define   PS_Y_VERT_FILTER_SELECT(set)		REG_FIELD_PREP(PS_Y_VERT_FILTER_SELECT_MASK, (set))
+#define   PS_Y_HORZ_FILTER_SELECT_MASK		REG_BIT(3) /* glk+ */
+#define   PS_Y_HORZ_FILTER_SELECT(set)		REG_FIELD_PREP(PS_Y_HORZ_FILTER_SELECT_MASK, (set))
+#define   PS_UV_VERT_FILTER_SELECT_MASK		REG_BIT(2) /* glk+ */
+#define   PS_UV_VERT_FILTER_SELECT(set)		REG_FIELD_PREP(PS_UV_VERT_FILTER_SELECT_MASK, (set))
+#define   PS_UV_HORZ_FILTER_SELECT_MASK		REG_BIT(1) /* glk+ */
+#define   PS_UV_HORZ_FILTER_SELECT(set)		REG_FIELD_PREP(PS_UV_HORZ_FILTER_SELECT_MASK, (set))
+
+#define _PS_WIN_POS_1A      0x68170
+#define _PS_WIN_POS_2A      0x68270
+#define _PS_WIN_POS_1B      0x68970
+#define _PS_WIN_POS_2B      0x68A70
+#define _PS_WIN_POS_1C      0x69170
+#define SKL_PS_WIN_POS(pipe, id) _MMIO_PIPE(pipe,     \
+			_ID(id, _PS_WIN_POS_1A, _PS_WIN_POS_2A), \
+			_ID(id, _PS_WIN_POS_1B, _PS_WIN_POS_2B))
+#define   PS_WIN_XPOS_MASK			REG_GENMASK(31, 16)
+#define   PS_WIN_XPOS(x)			REG_FIELD_PREP(PS_WIN_XPOS_MASK, (x))
+#define   PS_WIN_YPOS_MASK			REG_GENMASK(15, 0)
+#define   PS_WIN_YPOS(y)			REG_FIELD_PREP(PS_WIN_YPOS_MASK, (y))
+
+#define _PS_WIN_SZ_1A       0x68174
+#define _PS_WIN_SZ_2A       0x68274
+#define _PS_WIN_SZ_1B       0x68974
+#define _PS_WIN_SZ_2B       0x68A74
+#define _PS_WIN_SZ_1C       0x69174
+#define SKL_PS_WIN_SZ(pipe, id)  _MMIO_PIPE(pipe,     \
+			_ID(id, _PS_WIN_SZ_1A, _PS_WIN_SZ_2A),   \
+			_ID(id, _PS_WIN_SZ_1B, _PS_WIN_SZ_2B))
+#define   PS_WIN_XSIZE_MASK			REG_GENMASK(31, 16)
+#define   PS_WIN_XSIZE(w)			REG_FIELD_PREP(PS_WIN_XSIZE_MASK, (w))
+#define   PS_WIN_YSIZE_MASK			REG_GENMASK(15, 0)
+#define   PS_WIN_YSIZE(h)			REG_FIELD_PREP(PS_WIN_YSIZE_MASK, (h))
+
+#define _PS_VPHASE_1A       0x68188
+#define _PS_VPHASE_2A       0x68288
+#define _PS_VPHASE_1B       0x68988
+#define _PS_VPHASE_2B       0x68A88
+#define _PS_VPHASE_1C       0x69188
+#define SKL_PS_VPHASE(pipe, id)  _MMIO_PIPE(pipe,     \
+			_ID(id, _PS_VPHASE_1A, _PS_VPHASE_2A),   \
+			_ID(id, _PS_VPHASE_1B, _PS_VPHASE_2B))
+#define   PS_Y_PHASE_MASK			REG_GENMASK(31, 16)
+#define   PS_Y_PHASE(x)				REG_FIELD_PREP(PS_Y_PHASE_MASK, (x))
+#define   PS_UV_RGB_PHASE_MASK			REG_GENMASK(15, 0)
+#define   PS_UV_RGB_PHASE(x)			REG_FIELD_PREP(PS_UV_RGB_PHASE_MASK, (x))
+#define   PS_PHASE_MASK				(0x7fff << 1) /* u2.13 */
+#define   PS_PHASE_TRIP				(1 << 0)
+
+#define _PS_HPHASE_1A       0x68194
+#define _PS_HPHASE_2A       0x68294
+#define _PS_HPHASE_1B       0x68994
+#define _PS_HPHASE_2B       0x68A94
+#define _PS_HPHASE_1C       0x69194
+#define SKL_PS_HPHASE(pipe, id)  _MMIO_PIPE(pipe,     \
+			_ID(id, _PS_HPHASE_1A, _PS_HPHASE_2A),   \
+			_ID(id, _PS_HPHASE_1B, _PS_HPHASE_2B))
+
+#define _PS_COEF_SET0_INDEX_1A	   0x68198
+#define _PS_COEF_SET0_INDEX_2A	   0x68298
+#define _PS_COEF_SET0_INDEX_1B	   0x68998
+#define _PS_COEF_SET0_INDEX_2B	   0x68A98
+#define GLK_PS_COEF_INDEX_SET(pipe, id, set)  _MMIO_PIPE(pipe,    \
+			_ID(id, _PS_COEF_SET0_INDEX_1A, _PS_COEF_SET0_INDEX_2A) + (set) * 8, \
+			_ID(id, _PS_COEF_SET0_INDEX_1B, _PS_COEF_SET0_INDEX_2B) + (set) * 8)
+#define   PS_COEF_INDEX_AUTO_INC		REG_BIT(10)
+
+#define _PS_COEF_SET0_DATA_1A	   0x6819C
+#define _PS_COEF_SET0_DATA_2A	   0x6829C
+#define _PS_COEF_SET0_DATA_1B	   0x6899C
+#define _PS_COEF_SET0_DATA_2B	   0x68A9C
+#define GLK_PS_COEF_DATA_SET(pipe, id, set)  _MMIO_PIPE(pipe,     \
+			_ID(id, _PS_COEF_SET0_DATA_1A, _PS_COEF_SET0_DATA_2A) + (set) * 8, \
+			_ID(id, _PS_COEF_SET0_DATA_1B, _PS_COEF_SET0_DATA_2B) + (set) * 8)
+
+/* More Ivybridge lolz */
+#define DE_ERR_INT_IVB			(1 << 30)
+#define DE_GSE_IVB			(1 << 29)
+#define DE_PCH_EVENT_IVB		(1 << 28)
+#define DE_DP_A_HOTPLUG_IVB		(1 << 27)
+#define DE_AUX_CHANNEL_A_IVB		(1 << 26)
+#define DE_EDP_PSR_INT_HSW		(1 << 19)
+#define DE_SPRITEC_FLIP_DONE_IVB	(1 << 14)
+#define DE_PLANEC_FLIP_DONE_IVB		(1 << 13)
+#define DE_PIPEC_VBLANK_IVB		(1 << 10)
+#define DE_SPRITEB_FLIP_DONE_IVB	(1 << 9)
+#define DE_PLANEB_FLIP_DONE_IVB		(1 << 8)
+#define DE_PIPEB_VBLANK_IVB		(1 << 5)
+#define DE_SPRITEA_FLIP_DONE_IVB	(1 << 4)
+#define DE_PLANEA_FLIP_DONE_IVB		(1 << 3)
+#define DE_PLANE_FLIP_DONE_IVB(plane)	(1 << (3 + 5 * (plane)))
+#define DE_PIPEA_VBLANK_IVB		(1 << 0)
+#define DE_PIPE_VBLANK_IVB(pipe)	(1 << ((pipe) * 5))
+
+#define XELPD_DISPLAY_ERR_FATAL_MASK	_MMIO(0x4421c)
+
+#define GEN8_DE_PIPE_ISR(pipe) _MMIO(0x44400 + (0x10 * (pipe)))
+#define GEN8_DE_PIPE_IMR(pipe) _MMIO(0x44404 + (0x10 * (pipe)))
+#define GEN8_DE_PIPE_IIR(pipe) _MMIO(0x44408 + (0x10 * (pipe)))
+#define GEN8_DE_PIPE_IER(pipe) _MMIO(0x4440c + (0x10 * (pipe)))
+#define  GEN8_PIPE_FIFO_UNDERRUN	REG_BIT(31)
+#define  GEN8_PIPE_CDCLK_CRC_ERROR	REG_BIT(29)
+#define  GEN8_PIPE_CDCLK_CRC_DONE	REG_BIT(28)
+#define  GEN12_PIPEDMC_INTERRUPT	REG_BIT(26) /* tgl+ */
+#define  GEN12_PIPEDMC_FAULT		REG_BIT(25) /* tgl+ */
+#define  MTL_PIPEDMC_ATS_FAULT		REG_BIT(24) /* mtl+ */
+#define  GEN11_PIPE_PLANE7_FAULT	REG_BIT(22) /* icl/tgl */
+#define  GEN11_PIPE_PLANE6_FAULT	REG_BIT(21) /* icl/tgl */
+#define  GEN11_PIPE_PLANE5_FAULT	REG_BIT(20) /* icl+ */
+#define  GEN12_PIPE_VBLANK_UNMOD	REG_BIT(19) /* tgl+ */
+#define  MTL_PLANE_ATS_FAULT		REG_BIT(18) /* mtl+ */
+#define  GEN11_PIPE_PLANE7_FLIP_DONE	REG_BIT(18) /* icl/tgl */
+#define  GEN11_PIPE_PLANE6_FLIP_DONE	REG_BIT(17) /* icl/tgl */
+#define  GEN11_PIPE_PLANE5_FLIP_DONE	REG_BIT(16) /* icl+ */
+#define  GEN12_DSB_2_INT		REG_BIT(15) /* tgl+ */
+#define  GEN12_DSB_1_INT		REG_BIT(14) /* tgl+ */
+#define  GEN12_DSB_0_INT		REG_BIT(13) /* tgl+ */
+#define  GEN12_DSB_INT(dsb_id)		REG_BIT(13 + (dsb_id))
+#define  GEN9_PIPE_CURSOR_FAULT		REG_BIT(11) /* skl+ */
+#define  GEN9_PIPE_PLANE4_FAULT		REG_BIT(10) /* skl+ */
+#define  GEN8_PIPE_CURSOR_FAULT		REG_BIT(10) /* bdw */
+#define  GEN9_PIPE_PLANE3_FAULT		REG_BIT(9) /* skl+ */
+#define  GEN8_PIPE_SPRITE_FAULT		REG_BIT(9) /* bdw */
+#define  GEN9_PIPE_PLANE2_FAULT		REG_BIT(8) /* skl+ */
+#define  GEN8_PIPE_PRIMARY_FAULT	REG_BIT(8) /* bdw */
+#define  GEN9_PIPE_PLANE1_FAULT		REG_BIT(7) /* skl+ */
+#define  GEN9_PIPE_PLANE4_FLIP_DONE	REG_BIT(6) /* skl+ */
+#define  GEN9_PIPE_PLANE3_FLIP_DONE	REG_BIT(5) /* skl+ */
+#define  GEN8_PIPE_SPRITE_FLIP_DONE	REG_BIT(5) /* bdw */
+#define  GEN9_PIPE_PLANE2_FLIP_DONE	REG_BIT(4) /* skl+ */
+#define  GEN8_PIPE_PRIMARY_FLIP_DONE	REG_BIT(4) /* bdw */
+#define  GEN9_PIPE_PLANE1_FLIP_DONE	REG_BIT(3) /* skl+ */
+#define  GEN9_PIPE_PLANE_FLIP_DONE(plane_id) \
+	REG_BIT(((plane_id) >= PLANE_5 ? 16 - PLANE_5 : 3 - PLANE_1) + (plane_id)) /* skl+ */
+#define  GEN8_PIPE_SCAN_LINE_EVENT	REG_BIT(2)
+#define  GEN8_PIPE_VSYNC		REG_BIT(1)
+#define  GEN8_PIPE_VBLANK		REG_BIT(0)
+
+#define GEN8_DE_PIPE_IRQ_REGS(pipe)	I915_IRQ_REGS(GEN8_DE_PIPE_IMR(pipe), \
+						      GEN8_DE_PIPE_IER(pipe), \
+						      GEN8_DE_PIPE_IIR(pipe))
+
+#define GEN8_DE_PORT_ISR _MMIO(0x44440)
+#define GEN8_DE_PORT_IMR _MMIO(0x44444)
+#define GEN8_DE_PORT_IIR _MMIO(0x44448)
+#define GEN8_DE_PORT_IER _MMIO(0x4444c)
+#define  DSI1_NON_TE			(1 << 31)
+#define  DSI0_NON_TE			(1 << 30)
+#define  ICL_AUX_CHANNEL_E		(1 << 29)
+#define  ICL_AUX_CHANNEL_F		(1 << 28)
+#define  GEN9_AUX_CHANNEL_D		(1 << 27)
+#define  GEN9_AUX_CHANNEL_C		(1 << 26)
+#define  GEN9_AUX_CHANNEL_B		(1 << 25)
+#define  DSI1_TE			(1 << 24)
+#define  DSI0_TE			(1 << 23)
+#define  GEN8_DE_PORT_HOTPLUG(hpd_pin)	REG_BIT(3 + _HPD_PIN_DDI(hpd_pin))
+#define  BXT_DE_PORT_HOTPLUG_MASK	(GEN8_DE_PORT_HOTPLUG(HPD_PORT_A) | \
+					 GEN8_DE_PORT_HOTPLUG(HPD_PORT_B) | \
+					 GEN8_DE_PORT_HOTPLUG(HPD_PORT_C))
+#define  BDW_DE_PORT_HOTPLUG_MASK	GEN8_DE_PORT_HOTPLUG(HPD_PORT_A)
+#define  BXT_DE_PORT_GMBUS		(1 << 1)
+#define  GEN8_AUX_CHANNEL_A		(1 << 0)
+#define  TGL_DE_PORT_AUX_USBC6		REG_BIT(13)
+#define  XELPD_DE_PORT_AUX_DDIE		REG_BIT(13)
+#define  TGL_DE_PORT_AUX_USBC5		REG_BIT(12)
+#define  XELPD_DE_PORT_AUX_DDID		REG_BIT(12)
+#define  TGL_DE_PORT_AUX_USBC4		REG_BIT(11)
+#define  TGL_DE_PORT_AUX_USBC3		REG_BIT(10)
+#define  TGL_DE_PORT_AUX_USBC2		REG_BIT(9)
+#define  TGL_DE_PORT_AUX_USBC1		REG_BIT(8)
+#define  TGL_DE_PORT_AUX_DDIC		REG_BIT(2)
+#define  TGL_DE_PORT_AUX_DDIB		REG_BIT(1)
+#define  TGL_DE_PORT_AUX_DDIA		REG_BIT(0)
+
+#define GEN8_DE_PORT_IRQ_REGS		I915_IRQ_REGS(GEN8_DE_PORT_IMR, \
+						      GEN8_DE_PORT_IER, \
+						      GEN8_DE_PORT_IIR)
+
+#define GEN8_DE_MISC_IRQ_REGS		I915_IRQ_REGS(GEN8_DE_MISC_IMR, \
+						      GEN8_DE_MISC_IER, \
+						      GEN8_DE_MISC_IIR)
+
+#define GEN11_DISPLAY_INT_CTL		_MMIO(0x44200)
+#define  GEN11_DISPLAY_IRQ_ENABLE	(1 << 31)
+#define  GEN11_AUDIO_CODEC_IRQ		(1 << 24)
+#define  GEN11_DE_PCH_IRQ		(1 << 23)
+#define  GEN11_DE_MISC_IRQ		(1 << 22)
+#define  GEN11_DE_HPD_IRQ		(1 << 21)
+#define  GEN11_DE_PORT_IRQ		(1 << 20)
+#define  GEN11_DE_PIPE_C		(1 << 18)
+#define  GEN11_DE_PIPE_B		(1 << 17)
+#define  GEN11_DE_PIPE_A		(1 << 16)
+
+#define GEN11_DE_HPD_ISR		_MMIO(0x44470)
+#define GEN11_DE_HPD_IMR		_MMIO(0x44474)
+#define GEN11_DE_HPD_IIR		_MMIO(0x44478)
+#define GEN11_DE_HPD_IER		_MMIO(0x4447c)
+#define  GEN11_TC_HOTPLUG(hpd_pin)		REG_BIT(16 + _HPD_PIN_TC(hpd_pin))
+#define  GEN11_DE_TC_HOTPLUG_MASK		(GEN11_TC_HOTPLUG(HPD_PORT_TC6) | \
+						 GEN11_TC_HOTPLUG(HPD_PORT_TC5) | \
+						 GEN11_TC_HOTPLUG(HPD_PORT_TC4) | \
+						 GEN11_TC_HOTPLUG(HPD_PORT_TC3) | \
+						 GEN11_TC_HOTPLUG(HPD_PORT_TC2) | \
+						 GEN11_TC_HOTPLUG(HPD_PORT_TC1))
+#define  GEN11_TBT_HOTPLUG(hpd_pin)		REG_BIT(_HPD_PIN_TC(hpd_pin))
+#define  GEN11_DE_TBT_HOTPLUG_MASK		(GEN11_TBT_HOTPLUG(HPD_PORT_TC6) | \
+						 GEN11_TBT_HOTPLUG(HPD_PORT_TC5) | \
+						 GEN11_TBT_HOTPLUG(HPD_PORT_TC4) | \
+						 GEN11_TBT_HOTPLUG(HPD_PORT_TC3) | \
+						 GEN11_TBT_HOTPLUG(HPD_PORT_TC2) | \
+						 GEN11_TBT_HOTPLUG(HPD_PORT_TC1))
+
+#define GEN11_DE_HPD_IRQ_REGS		I915_IRQ_REGS(GEN11_DE_HPD_IMR, \
+						      GEN11_DE_HPD_IER, \
+						      GEN11_DE_HPD_IIR)
+
+#define GEN11_TBT_HOTPLUG_CTL				_MMIO(0x44030)
+#define GEN11_TC_HOTPLUG_CTL				_MMIO(0x44038)
+#define  GEN11_HOTPLUG_CTL_ENABLE(hpd_pin)		(8 << (_HPD_PIN_TC(hpd_pin) * 4))
+#define  GEN11_HOTPLUG_CTL_LONG_DETECT(hpd_pin)		(2 << (_HPD_PIN_TC(hpd_pin) * 4))
+#define  GEN11_HOTPLUG_CTL_SHORT_DETECT(hpd_pin)	(1 << (_HPD_PIN_TC(hpd_pin) * 4))
+#define  GEN11_HOTPLUG_CTL_NO_DETECT(hpd_pin)		(0 << (_HPD_PIN_TC(hpd_pin) * 4))
+
+#define PICAINTERRUPT_ISR			_MMIO(0x16FE50)
+#define PICAINTERRUPT_IMR			_MMIO(0x16FE54)
+#define PICAINTERRUPT_IIR			_MMIO(0x16FE58)
+#define PICAINTERRUPT_IER			_MMIO(0x16FE5C)
+#define  XELPDP_DP_ALT_HOTPLUG(hpd_pin)		REG_BIT(16 + _HPD_PIN_TC(hpd_pin))
+#define  XELPDP_DP_ALT_HOTPLUG_MASK		REG_GENMASK(19, 16)
+#define  XELPDP_AUX_TC(hpd_pin)			REG_BIT(8 + _HPD_PIN_TC(hpd_pin))
+#define  XELPDP_AUX_TC_MASK			REG_GENMASK(11, 8)
+#define  XE2LPD_AUX_DDI(hpd_pin)		REG_BIT(6 + _HPD_PIN_DDI(hpd_pin))
+#define  XE2LPD_AUX_DDI_MASK			REG_GENMASK(7, 6)
+#define  XELPDP_TBT_HOTPLUG(hpd_pin)		REG_BIT(_HPD_PIN_TC(hpd_pin))
+#define  XELPDP_TBT_HOTPLUG_MASK		REG_GENMASK(3, 0)
+
+#define PICAINTERRUPT_IRQ_REGS			I915_IRQ_REGS(PICAINTERRUPT_IMR, \
+							      PICAINTERRUPT_IER, \
+							      PICAINTERRUPT_IIR)
+
+#define XELPDP_PORT_HOTPLUG_CTL(hpd_pin)	_MMIO(0x16F270 + (_HPD_PIN_TC(hpd_pin) * 0x200))
+#define  XELPDP_TBT_HOTPLUG_ENABLE		REG_BIT(6)
+#define  XELPDP_TBT_HPD_LONG_DETECT		REG_BIT(5)
+#define  XELPDP_TBT_HPD_SHORT_DETECT		REG_BIT(4)
+#define  XELPDP_DP_ALT_HOTPLUG_ENABLE		REG_BIT(2)
+#define  XELPDP_DP_ALT_HPD_LONG_DETECT		REG_BIT(1)
+#define  XELPDP_DP_ALT_HPD_SHORT_DETECT		REG_BIT(0)
+
+#define XELPDP_INITIATE_PMDEMAND_REQUEST(dword)		_MMIO(0x45230 + 4 * (dword))
+#define  XELPDP_PMDEMAND_QCLK_GV_BW_MASK		REG_GENMASK(31, 16)
+#define  XELPDP_PMDEMAND_VOLTAGE_INDEX_MASK		REG_GENMASK(14, 12)
+#define  XELPDP_PMDEMAND_QCLK_GV_INDEX_MASK		REG_GENMASK(11, 8)
+#define  XE3_PMDEMAND_PIPES_MASK			REG_GENMASK(7, 4)
+#define  XELPDP_PMDEMAND_PIPES_MASK			REG_GENMASK(7, 6)
+#define  XELPDP_PMDEMAND_DBUFS_MASK			REG_GENMASK(5, 4)
+#define  XELPDP_PMDEMAND_PHYS_MASK			REG_GENMASK(2, 0)
+
+#define  XELPDP_PMDEMAND_REQ_ENABLE			REG_BIT(31)
+#define  XELPDP_PMDEMAND_CDCLK_FREQ_MASK		REG_GENMASK(30, 20)
+#define  XELPDP_PMDEMAND_DDICLK_FREQ_MASK		REG_GENMASK(18, 8)
+#define  XELPDP_PMDEMAND_SCALERS_MASK			REG_GENMASK(6, 4)
+#define  XELPDP_PMDEMAND_PLLS_MASK			REG_GENMASK(2, 0)
+
+#define GEN12_DCPR_STATUS_1				_MMIO(0x46440)
+#define  XELPDP_PMDEMAND_INFLIGHT_STATUS		REG_BIT(26)
+
+#define FUSE_STRAP		_MMIO(0x42014)
+#define   ILK_INTERNAL_GRAPHICS_DISABLE	REG_BIT(31)
+#define   ILK_INTERNAL_DISPLAY_DISABLE	REG_BIT(30)
+#define   ILK_DISPLAY_DEBUG_DISABLE	REG_BIT(29)
+#define   IVB_PIPE_C_DISABLE		REG_BIT(28)
+#define   ILK_HDCP_DISABLE		REG_BIT(25)
+#define   ILK_eDP_A_DISABLE		REG_BIT(24)
+#define   HSW_CDCLK_LIMIT		REG_BIT(24)
+#define   ILK_DESKTOP			REG_BIT(23)
+#define   HSW_CPU_SSC_ENABLE		REG_BIT(21)
+
+#define FUSE_STRAP3		_MMIO(0x42020)
+#define   HSW_REF_CLK_SELECT		REG_BIT(1)
+
+#define CHICKEN_MISC_2		_MMIO(0x42084)
+#define   CHICKEN_MISC_DISABLE_DPT	REG_BIT(30) /* adl,dg2 */
+#define   BMG_DARB_HALF_BLK_END_BURST	REG_BIT(27)
+#define   KBL_ARB_FILL_SPARE_14		REG_BIT(14)
+#define   KBL_ARB_FILL_SPARE_13		REG_BIT(13)
+#define   GLK_CL2_PWR_DOWN		REG_BIT(12)
+#define   GLK_CL1_PWR_DOWN		REG_BIT(11)
+#define   GLK_CL0_PWR_DOWN		REG_BIT(10)
+
+#define CHICKEN_MISC_3		_MMIO(0x42088)
+#define   DP_MST_DPT_DPTP_ALIGN_WA(trans)	REG_BIT(9 + (trans) - TRANSCODER_A)
+#define   DP_MST_SHORT_HBLANK_WA(trans)		REG_BIT(5 + (trans) - TRANSCODER_A)
+#define   DP_MST_FEC_BS_JITTER_WA(trans)	REG_BIT(0 + (trans) - TRANSCODER_A)
+
+#define CHICKEN_MISC_4		_MMIO(0x4208c)
+#define   CHICKEN_FBC_STRIDE_OVERRIDE	REG_BIT(13)
+#define   CHICKEN_FBC_STRIDE_MASK	REG_GENMASK(12, 0)
+#define   CHICKEN_FBC_STRIDE(x)		REG_FIELD_PREP(CHICKEN_FBC_STRIDE_MASK, (x))
+
+#define _CHICKEN_TRANS_A	0x420c0
+#define _CHICKEN_TRANS_B	0x420c4
+#define _CHICKEN_TRANS_C	0x420c8
+#define _CHICKEN_TRANS_EDP	0x420cc
+#define _CHICKEN_TRANS_D	0x420d8
+#define _CHICKEN_TRANS(trans)	_MMIO(_PICK((trans), \
+					    [TRANSCODER_EDP] = _CHICKEN_TRANS_EDP, \
+					    [TRANSCODER_A] = _CHICKEN_TRANS_A, \
+					    [TRANSCODER_B] = _CHICKEN_TRANS_B, \
+					    [TRANSCODER_C] = _CHICKEN_TRANS_C, \
+					    [TRANSCODER_D] = _CHICKEN_TRANS_D))
+#define _MTL_CHICKEN_TRANS_A	0x604e0
+#define _MTL_CHICKEN_TRANS_B	0x614e0
+#define _MTL_CHICKEN_TRANS(trans)	_MMIO_TRANS((trans), \
+						    _MTL_CHICKEN_TRANS_A, \
+						    _MTL_CHICKEN_TRANS_B)
+#define CHICKEN_TRANS(display, trans)	(DISPLAY_VER(display) >= 14 ? _MTL_CHICKEN_TRANS(trans) : _CHICKEN_TRANS(trans))
+#define   PIPE_VBLANK_WITH_DELAY	REG_BIT(31) /* tgl+ */
+#define   SKL_UNMASK_VBL_TO_PIPE_IN_SRD	REG_BIT(30) /* skl+ */
+#define   HSW_FRAME_START_DELAY_MASK	REG_GENMASK(28, 27)
+#define   HSW_FRAME_START_DELAY(x)	REG_FIELD_PREP(HSW_FRAME_START_DELAY_MASK, x)
+#define   VSC_DATA_SEL_SOFTWARE_CONTROL	REG_BIT(25) /* GLK */
+#define   FECSTALL_DIS_DPTSTREAM_DPTTG	REG_BIT(23)
+#define   DDI_TRAINING_OVERRIDE_ENABLE	REG_BIT(19)
+#define   ADLP_1_BASED_X_GRANULARITY	REG_BIT(18)
+#define   DDI_TRAINING_OVERRIDE_VALUE	REG_BIT(18)
+#define   DDIE_TRAINING_OVERRIDE_ENABLE	REG_BIT(17) /* CHICKEN_TRANS_A only */
+#define   DDIE_TRAINING_OVERRIDE_VALUE	REG_BIT(16) /* CHICKEN_TRANS_A only */
+#define   PSR2_ADD_VERTICAL_LINE_COUNT	REG_BIT(15)
+#define   DP_FEC_BS_JITTER_WA		REG_BIT(15)
+#define   PSR2_VSC_ENABLE_PROG_HEADER	REG_BIT(12)
+#define   DP_DSC_INSERT_SF_AT_EOL_WA	REG_BIT(4)
+#define   HDCP_LINE_REKEY_DISABLE	REG_BIT(0)
+
+#define DISP_ARB_CTL2	_MMIO(0x45004)
+#define   DISP_DATA_PARTITION_5_6	REG_BIT(6)
+#define   DISP_IPC_ENABLE		REG_BIT(3)
+
+#define GEN7_MSG_CTL	_MMIO(0x45010)
+#define  WAIT_FOR_PCH_RESET_ACK		(1 << 1)
+#define  WAIT_FOR_PCH_FLR_ACK		(1 << 0)
+
+#define _BW_BUDDY0_CTL			0x45130
+#define _BW_BUDDY1_CTL			0x45140
+#define BW_BUDDY_CTL(x)			_MMIO(_PICK_EVEN(x, \
+							 _BW_BUDDY0_CTL, \
+							 _BW_BUDDY1_CTL))
+#define   BW_BUDDY_DISABLE		REG_BIT(31)
+#define   BW_BUDDY_TLB_REQ_TIMER_MASK	REG_GENMASK(21, 16)
+#define   BW_BUDDY_TLB_REQ_TIMER(x)	REG_FIELD_PREP(BW_BUDDY_TLB_REQ_TIMER_MASK, x)
+
+#define _BW_BUDDY0_PAGE_MASK		0x45134
+#define _BW_BUDDY1_PAGE_MASK		0x45144
+#define BW_BUDDY_PAGE_MASK(x)		_MMIO(_PICK_EVEN(x, \
+							 _BW_BUDDY0_PAGE_MASK, \
+							 _BW_BUDDY1_PAGE_MASK))
+
+#define HSW_NDE_RSTWRN_OPT	_MMIO(0x46408)
+#define  MTL_RESET_PICA_HANDSHAKE_EN	REG_BIT(6)
+#define  RESET_PCH_HANDSHAKE_ENABLE	REG_BIT(4)
+
+#define GEN11_CHICKEN_DCPR_2			_MMIO(0x46434)
+#define   DCPR_MASK_MAXLATENCY_MEMUP_CLR	REG_BIT(27)
+#define   DCPR_MASK_LPMODE			REG_BIT(26)
+#define   DCPR_SEND_RESP_IMM			REG_BIT(25)
+#define   DCPR_CLEAR_MEMSTAT_DIS		REG_BIT(24)
+
+#define XELPD_CHICKEN_DCPR_3			_MMIO(0x46438)
+#define   DMD_RSP_TIMEOUT_DISABLE		REG_BIT(19)
+
+#define SKL_DFSM			_MMIO(0x51000)
+#define   SKL_DFSM_DISPLAY_PM_DISABLE	(1 << 27)
+#define   SKL_DFSM_DISPLAY_HDCP_DISABLE	(1 << 25)
+#define   SKL_DFSM_CDCLK_LIMIT_MASK	(3 << 23)
+#define   SKL_DFSM_CDCLK_LIMIT_675	(0 << 23)
+#define   SKL_DFSM_CDCLK_LIMIT_540	(1 << 23)
+#define   SKL_DFSM_CDCLK_LIMIT_450	(2 << 23)
+#define   SKL_DFSM_CDCLK_LIMIT_337_5	(3 << 23)
+#define   ICL_DFSM_DMC_DISABLE		(1 << 23)
+#define   SKL_DFSM_PIPE_A_DISABLE	(1 << 30)
+#define   SKL_DFSM_PIPE_B_DISABLE	(1 << 21)
+#define   SKL_DFSM_PIPE_C_DISABLE	(1 << 28)
+#define   TGL_DFSM_PIPE_D_DISABLE	(1 << 22)
+#define   GLK_DFSM_DISPLAY_DSC_DISABLE	(1 << 7)
+#define   XE2LPD_DFSM_DBUF_OVERLAP_DISABLE	(1 << 3)
+
+#define XE2LPD_DE_CAP			_MMIO(0x41100)
+#define   XE2LPD_DE_CAP_3DLUT_MASK	REG_GENMASK(31, 30)
+#define   XE2LPD_DE_CAP_DSC_MASK	REG_GENMASK(29, 28)
+#define   XE2LPD_DE_CAP_DSC_REMOVED	1
+#define   XE2LPD_DE_CAP_SCALER_MASK	REG_GENMASK(27, 26)
+#define   XE2LPD_DE_CAP_SCALER_SINGLE	1
+
+#define SKL_DSSM				_MMIO(0x51004)
+#define ICL_DSSM_CDCLK_PLL_REFCLK_MASK		(7 << 29)
+#define ICL_DSSM_CDCLK_PLL_REFCLK_24MHz		(0 << 29)
+#define ICL_DSSM_CDCLK_PLL_REFCLK_19_2MHz	(1 << 29)
+#define ICL_DSSM_CDCLK_PLL_REFCLK_38_4MHz	(2 << 29)
+
+/*GEN11 chicken */
+#define _PIPEA_CHICKEN				0x70038
+#define _PIPEB_CHICKEN				0x71038
+#define _PIPEC_CHICKEN				0x72038
+#define PIPE_CHICKEN(pipe)			_MMIO_PIPE(pipe, _PIPEA_CHICKEN,\
+							   _PIPEB_CHICKEN)
+#define   UNDERRUN_RECOVERY_DISABLE_ADLP	REG_BIT(30)
+#define   UNDERRUN_RECOVERY_ENABLE_DG2		REG_BIT(30)
+#define   PIXEL_ROUNDING_TRUNC_FB_PASSTHRU	REG_BIT(15)
+#define   DG2_RENDER_CCSTAG_4_3_EN		REG_BIT(12)
+#define   PER_PIXEL_ALPHA_BYPASS_EN		REG_BIT(7)
+
+#define PCH_DISPLAY_BASE	0xc0000u
+
+/* south display engine interrupt: IBX */
+#define SDE_AUDIO_POWER_D	(1 << 27)
+#define SDE_AUDIO_POWER_C	(1 << 26)
+#define SDE_AUDIO_POWER_B	(1 << 25)
+#define SDE_AUDIO_POWER_SHIFT	(25)
+#define SDE_AUDIO_POWER_MASK	(7 << SDE_AUDIO_POWER_SHIFT)
+#define SDE_GMBUS		(1 << 24)
+#define SDE_AUDIO_HDCP_TRANSB	(1 << 23)
+#define SDE_AUDIO_HDCP_TRANSA	(1 << 22)
+#define SDE_AUDIO_HDCP_MASK	(3 << 22)
+#define SDE_AUDIO_TRANSB	(1 << 21)
+#define SDE_AUDIO_TRANSA	(1 << 20)
+#define SDE_AUDIO_TRANS_MASK	(3 << 20)
+#define SDE_POISON		(1 << 19)
+/* 18 reserved */
+#define SDE_FDI_RXB		(1 << 17)
+#define SDE_FDI_RXA		(1 << 16)
+#define SDE_FDI_MASK		(3 << 16)
+#define SDE_AUXD		(1 << 15)
+#define SDE_AUXC		(1 << 14)
+#define SDE_AUXB		(1 << 13)
+#define SDE_AUX_MASK		(7 << 13)
+/* 12 reserved */
+#define SDE_CRT_HOTPLUG         (1 << 11)
+#define SDE_PORTD_HOTPLUG       (1 << 10)
+#define SDE_PORTC_HOTPLUG       (1 << 9)
+#define SDE_PORTB_HOTPLUG       (1 << 8)
+#define SDE_SDVOB_HOTPLUG       (1 << 6)
+#define SDE_HOTPLUG_MASK        (SDE_CRT_HOTPLUG | \
+				 SDE_SDVOB_HOTPLUG |	\
+				 SDE_PORTB_HOTPLUG |	\
+				 SDE_PORTC_HOTPLUG |	\
+				 SDE_PORTD_HOTPLUG)
+#define SDE_TRANSB_CRC_DONE	(1 << 5)
+#define SDE_TRANSB_CRC_ERR	(1 << 4)
+#define SDE_TRANSB_FIFO_UNDER	(1 << 3)
+#define SDE_TRANSA_CRC_DONE	(1 << 2)
+#define SDE_TRANSA_CRC_ERR	(1 << 1)
+#define SDE_TRANSA_FIFO_UNDER	(1 << 0)
+#define SDE_TRANS_MASK		(0x3f)
+
+/* south display engine interrupt: CPT - CNP */
+#define SDE_AUDIO_POWER_D_CPT	(1 << 31)
+#define SDE_AUDIO_POWER_C_CPT	(1 << 30)
+#define SDE_AUDIO_POWER_B_CPT	(1 << 29)
+#define SDE_AUDIO_POWER_SHIFT_CPT   29
+#define SDE_AUDIO_POWER_MASK_CPT    (7 << 29)
+#define SDE_AUXD_CPT		(1 << 27)
+#define SDE_AUXC_CPT		(1 << 26)
+#define SDE_AUXB_CPT		(1 << 25)
+#define SDE_AUX_MASK_CPT	(7 << 25)
+#define SDE_PORTE_HOTPLUG_SPT	(1 << 25)
+#define SDE_PORTA_HOTPLUG_SPT	(1 << 24)
+#define SDE_PORTD_HOTPLUG_CPT	(1 << 23)
+#define SDE_PORTC_HOTPLUG_CPT	(1 << 22)
+#define SDE_PORTB_HOTPLUG_CPT	(1 << 21)
+#define SDE_CRT_HOTPLUG_CPT	(1 << 19)
+#define SDE_SDVOB_HOTPLUG_CPT	(1 << 18)
+#define SDE_HOTPLUG_MASK_CPT	(SDE_CRT_HOTPLUG_CPT |		\
+				 SDE_SDVOB_HOTPLUG_CPT |	\
+				 SDE_PORTD_HOTPLUG_CPT |	\
+				 SDE_PORTC_HOTPLUG_CPT |	\
+				 SDE_PORTB_HOTPLUG_CPT)
+#define SDE_HOTPLUG_MASK_SPT	(SDE_PORTE_HOTPLUG_SPT |	\
+				 SDE_PORTD_HOTPLUG_CPT |	\
+				 SDE_PORTC_HOTPLUG_CPT |	\
+				 SDE_PORTB_HOTPLUG_CPT |	\
+				 SDE_PORTA_HOTPLUG_SPT)
+#define SDE_GMBUS_CPT		(1 << 17)
+#define SDE_ERROR_CPT		(1 << 16)
+#define SDE_AUDIO_CP_REQ_C_CPT	(1 << 10)
+#define SDE_AUDIO_CP_CHG_C_CPT	(1 << 9)
+#define SDE_FDI_RXC_CPT		(1 << 8)
+#define SDE_AUDIO_CP_REQ_B_CPT	(1 << 6)
+#define SDE_AUDIO_CP_CHG_B_CPT	(1 << 5)
+#define SDE_FDI_RXB_CPT		(1 << 4)
+#define SDE_AUDIO_CP_REQ_A_CPT	(1 << 2)
+#define SDE_AUDIO_CP_CHG_A_CPT	(1 << 1)
+#define SDE_FDI_RXA_CPT		(1 << 0)
+#define SDE_AUDIO_CP_REQ_CPT	(SDE_AUDIO_CP_REQ_C_CPT | \
+				 SDE_AUDIO_CP_REQ_B_CPT | \
+				 SDE_AUDIO_CP_REQ_A_CPT)
+#define SDE_AUDIO_CP_CHG_CPT	(SDE_AUDIO_CP_CHG_C_CPT | \
+				 SDE_AUDIO_CP_CHG_B_CPT | \
+				 SDE_AUDIO_CP_CHG_A_CPT)
+#define SDE_FDI_MASK_CPT	(SDE_FDI_RXC_CPT | \
+				 SDE_FDI_RXB_CPT | \
+				 SDE_FDI_RXA_CPT)
+
+/* south display engine interrupt: ICP/TGP/MTP */
+#define SDE_PICAINTERRUPT		REG_BIT(31)
+#define SDE_GMBUS_ICP			(1 << 23)
+#define SDE_TC_HOTPLUG_ICP(hpd_pin)	REG_BIT(24 + _HPD_PIN_TC(hpd_pin))
+#define SDE_TC_HOTPLUG_DG2(hpd_pin)	REG_BIT(25 + _HPD_PIN_TC(hpd_pin)) /* sigh */
+#define SDE_DDI_HOTPLUG_ICP(hpd_pin)	REG_BIT(16 + _HPD_PIN_DDI(hpd_pin))
+#define SDE_DDI_HOTPLUG_MASK_ICP	(SDE_DDI_HOTPLUG_ICP(HPD_PORT_D) | \
+					 SDE_DDI_HOTPLUG_ICP(HPD_PORT_C) | \
+					 SDE_DDI_HOTPLUG_ICP(HPD_PORT_B) | \
+					 SDE_DDI_HOTPLUG_ICP(HPD_PORT_A))
+#define SDE_TC_HOTPLUG_MASK_ICP		(SDE_TC_HOTPLUG_ICP(HPD_PORT_TC6) | \
+					 SDE_TC_HOTPLUG_ICP(HPD_PORT_TC5) | \
+					 SDE_TC_HOTPLUG_ICP(HPD_PORT_TC4) | \
+					 SDE_TC_HOTPLUG_ICP(HPD_PORT_TC3) | \
+					 SDE_TC_HOTPLUG_ICP(HPD_PORT_TC2) | \
+					 SDE_TC_HOTPLUG_ICP(HPD_PORT_TC1))
+
+/* digital port hotplug */
+#define PCH_PORT_HOTPLUG		_MMIO(0xc4030)	/* SHOTPLUG_CTL */
+#define  PORTA_HOTPLUG_ENABLE		(1 << 28) /* LPT:LP+ & BXT */
+#define  BXT_DDIA_HPD_INVERT            (1 << 27)
+#define  PORTA_HOTPLUG_STATUS_MASK	(3 << 24) /* SPT+ & BXT */
+#define  PORTA_HOTPLUG_NO_DETECT	(0 << 24) /* SPT+ & BXT */
+#define  PORTA_HOTPLUG_SHORT_DETECT	(1 << 24) /* SPT+ & BXT */
+#define  PORTA_HOTPLUG_LONG_DETECT	(2 << 24) /* SPT+ & BXT */
+#define  PORTD_HOTPLUG_ENABLE		(1 << 20)
+#define  PORTD_PULSE_DURATION_2ms	(0 << 18) /* pre-LPT */
+#define  PORTD_PULSE_DURATION_4_5ms	(1 << 18) /* pre-LPT */
+#define  PORTD_PULSE_DURATION_6ms	(2 << 18) /* pre-LPT */
+#define  PORTD_PULSE_DURATION_100ms	(3 << 18) /* pre-LPT */
+#define  PORTD_PULSE_DURATION_MASK	(3 << 18) /* pre-LPT */
+#define  PORTD_HOTPLUG_STATUS_MASK	(3 << 16)
+#define  PORTD_HOTPLUG_NO_DETECT	(0 << 16)
+#define  PORTD_HOTPLUG_SHORT_DETECT	(1 << 16)
+#define  PORTD_HOTPLUG_LONG_DETECT	(2 << 16)
+#define  PORTC_HOTPLUG_ENABLE		(1 << 12)
+#define  BXT_DDIC_HPD_INVERT            (1 << 11)
+#define  PORTC_PULSE_DURATION_2ms	(0 << 10) /* pre-LPT */
+#define  PORTC_PULSE_DURATION_4_5ms	(1 << 10) /* pre-LPT */
+#define  PORTC_PULSE_DURATION_6ms	(2 << 10) /* pre-LPT */
+#define  PORTC_PULSE_DURATION_100ms	(3 << 10) /* pre-LPT */
+#define  PORTC_PULSE_DURATION_MASK	(3 << 10) /* pre-LPT */
+#define  PORTC_HOTPLUG_STATUS_MASK	(3 << 8)
+#define  PORTC_HOTPLUG_NO_DETECT	(0 << 8)
+#define  PORTC_HOTPLUG_SHORT_DETECT	(1 << 8)
+#define  PORTC_HOTPLUG_LONG_DETECT	(2 << 8)
+#define  PORTB_HOTPLUG_ENABLE		(1 << 4)
+#define  BXT_DDIB_HPD_INVERT            (1 << 3)
+#define  PORTB_PULSE_DURATION_2ms	(0 << 2) /* pre-LPT */
+#define  PORTB_PULSE_DURATION_4_5ms	(1 << 2) /* pre-LPT */
+#define  PORTB_PULSE_DURATION_6ms	(2 << 2) /* pre-LPT */
+#define  PORTB_PULSE_DURATION_100ms	(3 << 2) /* pre-LPT */
+#define  PORTB_PULSE_DURATION_MASK	(3 << 2) /* pre-LPT */
+#define  PORTB_HOTPLUG_STATUS_MASK	(3 << 0)
+#define  PORTB_HOTPLUG_NO_DETECT	(0 << 0)
+#define  PORTB_HOTPLUG_SHORT_DETECT	(1 << 0)
+#define  PORTB_HOTPLUG_LONG_DETECT	(2 << 0)
+#define  BXT_DDI_HPD_INVERT_MASK	(BXT_DDIA_HPD_INVERT | \
+					BXT_DDIB_HPD_INVERT | \
+					BXT_DDIC_HPD_INVERT)
+
+#define PCH_PORT_HOTPLUG2		_MMIO(0xc403C)	/* SHOTPLUG_CTL2 SPT+ */
+#define  PORTE_HOTPLUG_ENABLE		(1 << 4)
+#define  PORTE_HOTPLUG_STATUS_MASK	(3 << 0)
+#define  PORTE_HOTPLUG_NO_DETECT	(0 << 0)
+#define  PORTE_HOTPLUG_SHORT_DETECT	(1 << 0)
+#define  PORTE_HOTPLUG_LONG_DETECT	(2 << 0)
+
+/* This register is a reuse of PCH_PORT_HOTPLUG register. The
+ * functionality covered in PCH_PORT_HOTPLUG is split into
+ * SHOTPLUG_CTL_DDI and SHOTPLUG_CTL_TC.
+ */
+#define SHOTPLUG_CTL_DDI				_MMIO(0xc4030)
+#define   SHOTPLUG_CTL_DDI_HPD_ENABLE(hpd_pin)			(0x8 << (_HPD_PIN_DDI(hpd_pin) * 4))
+#define   SHOTPLUG_CTL_DDI_HPD_OUTPUT_DATA(hpd_pin)		(0x4 << (_HPD_PIN_DDI(hpd_pin) * 4))
+#define   SHOTPLUG_CTL_DDI_HPD_STATUS_MASK(hpd_pin)		(0x3 << (_HPD_PIN_DDI(hpd_pin) * 4))
+#define   SHOTPLUG_CTL_DDI_HPD_NO_DETECT(hpd_pin)		(0x0 << (_HPD_PIN_DDI(hpd_pin) * 4))
+#define   SHOTPLUG_CTL_DDI_HPD_SHORT_DETECT(hpd_pin)		(0x1 << (_HPD_PIN_DDI(hpd_pin) * 4))
+#define   SHOTPLUG_CTL_DDI_HPD_LONG_DETECT(hpd_pin)		(0x2 << (_HPD_PIN_DDI(hpd_pin) * 4))
+#define   SHOTPLUG_CTL_DDI_HPD_SHORT_LONG_DETECT(hpd_pin)	(0x3 << (_HPD_PIN_DDI(hpd_pin) * 4))
+
+#define SHOTPLUG_CTL_TC				_MMIO(0xc4034)
+#define   ICP_TC_HPD_ENABLE(hpd_pin)		(8 << (_HPD_PIN_TC(hpd_pin) * 4))
+#define   ICP_TC_HPD_LONG_DETECT(hpd_pin)	(2 << (_HPD_PIN_TC(hpd_pin) * 4))
+#define   ICP_TC_HPD_SHORT_DETECT(hpd_pin)	(1 << (_HPD_PIN_TC(hpd_pin) * 4))
+
+#define SHPD_FILTER_CNT				_MMIO(0xc4038)
+#define   SHPD_FILTER_CNT_500_ADJ		0x001D9
+#define   SHPD_FILTER_CNT_250			0x000F8
+
+#define _PCH_DPLL_A              0xc6014
+#define _PCH_DPLL_B              0xc6018
+#define PCH_DPLL(pll) _MMIO((pll) == 0 ? _PCH_DPLL_A : _PCH_DPLL_B)
+
+#define _PCH_FPA0                0xc6040
+#define _PCH_FPB0                0xc6048
+#define PCH_FP0(pll) _MMIO((pll) == 0 ? _PCH_FPA0 : _PCH_FPB0)
+#define  FP_CB_TUNE		(0x3 << 22)
+
+#define _PCH_FPA1                0xc6044
+#define _PCH_FPB1                0xc604c
+#define PCH_FP1(pll) _MMIO((pll) == 0 ? _PCH_FPA1 : _PCH_FPB1)
+
+#define PCH_DREF_CONTROL        _MMIO(0xC6200)
+#define  DREF_CONTROL_MASK      0x7fc3
+#define  DREF_CPU_SOURCE_OUTPUT_DISABLE         (0 << 13)
+#define  DREF_CPU_SOURCE_OUTPUT_DOWNSPREAD      (2 << 13)
+#define  DREF_CPU_SOURCE_OUTPUT_NONSPREAD       (3 << 13)
+#define  DREF_CPU_SOURCE_OUTPUT_MASK		(3 << 13)
+#define  DREF_SSC_SOURCE_DISABLE                (0 << 11)
+#define  DREF_SSC_SOURCE_ENABLE                 (2 << 11)
+#define  DREF_SSC_SOURCE_MASK			(3 << 11)
+#define  DREF_NONSPREAD_SOURCE_DISABLE          (0 << 9)
+#define  DREF_NONSPREAD_CK505_ENABLE		(1 << 9)
+#define  DREF_NONSPREAD_SOURCE_ENABLE           (2 << 9)
+#define  DREF_NONSPREAD_SOURCE_MASK		(3 << 9)
+#define  DREF_SUPERSPREAD_SOURCE_DISABLE        (0 << 7)
+#define  DREF_SUPERSPREAD_SOURCE_ENABLE         (2 << 7)
+#define  DREF_SUPERSPREAD_SOURCE_MASK		(3 << 7)
+#define  DREF_SSC4_DOWNSPREAD                   (0 << 6)
+#define  DREF_SSC4_CENTERSPREAD                 (1 << 6)
+#define  DREF_SSC1_DISABLE                      (0 << 1)
+#define  DREF_SSC1_ENABLE                       (1 << 1)
+#define  DREF_SSC4_DISABLE                      (0)
+#define  DREF_SSC4_ENABLE                       (1)
+
+#define PCH_RAWCLK_FREQ         _MMIO(0xc6204)
+#define  FDL_TP1_TIMER_SHIFT    12
+#define  FDL_TP1_TIMER_MASK     (3 << 12)
+#define  FDL_TP2_TIMER_SHIFT    10
+#define  FDL_TP2_TIMER_MASK     (3 << 10)
+#define  RAWCLK_FREQ_MASK       0x3ff
+#define  CNP_RAWCLK_DIV_MASK	(0x3ff << 16)
+#define  CNP_RAWCLK_DIV(div)	((div) << 16)
+#define  CNP_RAWCLK_FRAC_MASK	(0xf << 26)
+#define  CNP_RAWCLK_DEN(den)	((den) << 26)
+#define  ICP_RAWCLK_NUM(num)	((num) << 11)
+
+#define PCH_DPLL_SEL		_MMIO(0xc7000)
+#define	 TRANS_DPLLB_SEL(pipe)		(1 << ((pipe) * 4))
+#define	 TRANS_DPLLA_SEL(pipe)		0
+#define  TRANS_DPLL_ENABLE(pipe)	(1 << ((pipe) * 4 + 3))
+
+/* transcoder */
+#define _PCH_TRANS_HTOTAL_A		0xe0000
+#define _PCH_TRANS_HTOTAL_B		0xe1000
+#define PCH_TRANS_HTOTAL(pipe)		_MMIO_PIPE(pipe, _PCH_TRANS_HTOTAL_A, _PCH_TRANS_HTOTAL_B)
+#define  TRANS_HTOTAL_SHIFT		16
+#define  TRANS_HACTIVE_SHIFT		0
+
+#define _PCH_TRANS_HBLANK_A		0xe0004
+#define _PCH_TRANS_HBLANK_B		0xe1004
+#define PCH_TRANS_HBLANK(pipe)		_MMIO_PIPE(pipe, _PCH_TRANS_HBLANK_A, _PCH_TRANS_HBLANK_B)
+#define  TRANS_HBLANK_END_SHIFT		16
+#define  TRANS_HBLANK_START_SHIFT	0
+
+#define _PCH_TRANS_HSYNC_A		0xe0008
+#define _PCH_TRANS_HSYNC_B		0xe1008
+#define PCH_TRANS_HSYNC(pipe)		_MMIO_PIPE(pipe, _PCH_TRANS_HSYNC_A, _PCH_TRANS_HSYNC_B)
+#define  TRANS_HSYNC_END_SHIFT		16
+#define  TRANS_HSYNC_START_SHIFT	0
+
+#define _PCH_TRANS_VTOTAL_A		0xe000c
+#define _PCH_TRANS_VTOTAL_B		0xe100c
+#define PCH_TRANS_VTOTAL(pipe)		_MMIO_PIPE(pipe, _PCH_TRANS_VTOTAL_A, _PCH_TRANS_VTOTAL_B)
+#define  TRANS_VTOTAL_SHIFT		16
+#define  TRANS_VACTIVE_SHIFT		0
+
+#define _PCH_TRANS_VBLANK_A		0xe0010
+#define _PCH_TRANS_VBLANK_B		0xe1010
+#define PCH_TRANS_VBLANK(pipe)		_MMIO_PIPE(pipe, _PCH_TRANS_VBLANK_A, _PCH_TRANS_VBLANK_B)
+#define  TRANS_VBLANK_END_SHIFT		16
+#define  TRANS_VBLANK_START_SHIFT	0
+
+#define _PCH_TRANS_VSYNC_A		0xe0014
+#define _PCH_TRANS_VSYNC_B		0xe1014
+#define PCH_TRANS_VSYNC(pipe)		_MMIO_PIPE(pipe, _PCH_TRANS_VSYNC_A, _PCH_TRANS_VSYNC_B)
+#define  TRANS_VSYNC_END_SHIFT		16
+#define  TRANS_VSYNC_START_SHIFT	0
+
+#define _PCH_TRANS_VSYNCSHIFT_A		0xe0028
+#define _PCH_TRANS_VSYNCSHIFT_B		0xe1028
+#define PCH_TRANS_VSYNCSHIFT(pipe)	_MMIO_PIPE(pipe, _PCH_TRANS_VSYNCSHIFT_A, _PCH_TRANS_VSYNCSHIFT_B)
+
+#define _PCH_TRANSA_DATA_M1	0xe0030
+#define _PCH_TRANSB_DATA_M1	0xe1030
+#define PCH_TRANS_DATA_M1(pipe)	_MMIO_PIPE(pipe, _PCH_TRANSA_DATA_M1, _PCH_TRANSB_DATA_M1)
+
+#define _PCH_TRANSA_DATA_N1	0xe0034
+#define _PCH_TRANSB_DATA_N1	0xe1034
+#define PCH_TRANS_DATA_N1(pipe)	_MMIO_PIPE(pipe, _PCH_TRANSA_DATA_N1, _PCH_TRANSB_DATA_N1)
+
+#define _PCH_TRANSA_DATA_M2	0xe0038
+#define _PCH_TRANSB_DATA_M2	0xe1038
+#define PCH_TRANS_DATA_M2(pipe)	_MMIO_PIPE(pipe, _PCH_TRANSA_DATA_M2, _PCH_TRANSB_DATA_M2)
+
+#define _PCH_TRANSA_DATA_N2	0xe003c
+#define _PCH_TRANSB_DATA_N2	0xe103c
+#define PCH_TRANS_DATA_N2(pipe)	_MMIO_PIPE(pipe, _PCH_TRANSA_DATA_N2, _PCH_TRANSB_DATA_N2)
+
+#define _PCH_TRANSA_LINK_M1	0xe0040
+#define _PCH_TRANSB_LINK_M1	0xe1040
+#define PCH_TRANS_LINK_M1(pipe)	_MMIO_PIPE(pipe, _PCH_TRANSA_LINK_M1, _PCH_TRANSB_LINK_M1)
+
+#define _PCH_TRANSA_LINK_N1	0xe0044
+#define _PCH_TRANSB_LINK_N1	0xe1044
+#define PCH_TRANS_LINK_N1(pipe)	_MMIO_PIPE(pipe, _PCH_TRANSA_LINK_N1, _PCH_TRANSB_LINK_N1)
+
+#define _PCH_TRANSA_LINK_M2	0xe0048
+#define _PCH_TRANSB_LINK_M2	0xe1048
+#define PCH_TRANS_LINK_M2(pipe)	_MMIO_PIPE(pipe, _PCH_TRANSA_LINK_M2, _PCH_TRANSB_LINK_M2)
+
+#define _PCH_TRANSA_LINK_N2	0xe004c
+#define _PCH_TRANSB_LINK_N2	0xe104c
+#define PCH_TRANS_LINK_N2(pipe)	_MMIO_PIPE(pipe, _PCH_TRANSA_LINK_N2, _PCH_TRANSB_LINK_N2)
+
+/* Per-transcoder DIP controls (PCH) */
+#define _VIDEO_DIP_CTL_A         0xe0200
+#define _VIDEO_DIP_CTL_B         0xe1200
+#define TVIDEO_DIP_CTL(pipe) _MMIO_PIPE(pipe, _VIDEO_DIP_CTL_A, _VIDEO_DIP_CTL_B)
+
+#define _VIDEO_DIP_DATA_A        0xe0208
+#define _VIDEO_DIP_DATA_B        0xe1208
+#define TVIDEO_DIP_DATA(pipe) _MMIO_PIPE(pipe, _VIDEO_DIP_DATA_A, _VIDEO_DIP_DATA_B)
+
+#define _VIDEO_DIP_GCP_A         0xe0210
+#define _VIDEO_DIP_GCP_B         0xe1210
+#define TVIDEO_DIP_GCP(pipe) _MMIO_PIPE(pipe, _VIDEO_DIP_GCP_A, _VIDEO_DIP_GCP_B)
+#define  GCP_COLOR_INDICATION		(1 << 2)
+#define  GCP_DEFAULT_PHASE_ENABLE	(1 << 1)
+#define  GCP_AV_MUTE			(1 << 0)
+
+/* Per-transcoder DIP controls (VLV) */
+#define _VLV_VIDEO_DIP_CTL_A		0x60200
+#define _VLV_VIDEO_DIP_CTL_B		0x61170
+#define _CHV_VIDEO_DIP_CTL_C		0x611f0
+#define VLV_TVIDEO_DIP_CTL(pipe)	_MMIO_BASE_PIPE3(VLV_DISPLAY_BASE, (pipe), \
+							 _VLV_VIDEO_DIP_CTL_A, \
+							 _VLV_VIDEO_DIP_CTL_B, \
+							 _CHV_VIDEO_DIP_CTL_C)
+
+#define _VLV_VIDEO_DIP_DATA_A		0x60208
+#define _VLV_VIDEO_DIP_DATA_B		0x61174
+#define _CHV_VIDEO_DIP_DATA_C		0x611f4
+#define VLV_TVIDEO_DIP_DATA(pipe)	_MMIO_BASE_PIPE3(VLV_DISPLAY_BASE, (pipe), \
+							 _VLV_VIDEO_DIP_DATA_A, \
+							 _VLV_VIDEO_DIP_DATA_B, \
+							 _CHV_VIDEO_DIP_DATA_C)
+
+#define _VLV_VIDEO_DIP_GDCP_PAYLOAD_A	0x60210
+#define _VLV_VIDEO_DIP_GDCP_PAYLOAD_B	0x61178
+#define _CHV_VIDEO_DIP_GDCP_PAYLOAD_C	0x611f8
+#define VLV_TVIDEO_DIP_GCP(pipe)	_MMIO_BASE_PIPE3(VLV_DISPLAY_BASE, (pipe), \
+							 _VLV_VIDEO_DIP_GDCP_PAYLOAD_A, \
+							 _VLV_VIDEO_DIP_GDCP_PAYLOAD_B, \
+							 _CHV_VIDEO_DIP_GDCP_PAYLOAD_C)
+
+/* Haswell DIP controls */
+#define _HSW_VIDEO_DIP_CTL_A		0x60200
+#define _HSW_VIDEO_DIP_CTL_B		0x61200
+#define HSW_TVIDEO_DIP_CTL(dev_priv, trans)		_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_CTL_A)
+
+#define _HSW_VIDEO_DIP_AVI_DATA_A	0x60220
+#define _HSW_VIDEO_DIP_AVI_DATA_B	0x61220
+#define HSW_TVIDEO_DIP_AVI_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_AVI_DATA_A + (i) * 4)
+
+#define _HSW_VIDEO_DIP_VS_DATA_A	0x60260
+#define _HSW_VIDEO_DIP_VS_DATA_B	0x61260
+#define HSW_TVIDEO_DIP_VS_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_VS_DATA_A + (i) * 4)
+
+#define _HSW_VIDEO_DIP_SPD_DATA_A	0x602A0
+#define _HSW_VIDEO_DIP_SPD_DATA_B	0x612A0
+#define HSW_TVIDEO_DIP_SPD_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_SPD_DATA_A + (i) * 4)
+
+#define _HSW_VIDEO_DIP_GMP_DATA_A	0x602E0
+#define _HSW_VIDEO_DIP_GMP_DATA_B	0x612E0
+#define HSW_TVIDEO_DIP_GMP_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_GMP_DATA_A + (i) * 4)
+
+#define _HSW_VIDEO_DIP_VSC_DATA_A	0x60320
+#define _HSW_VIDEO_DIP_VSC_DATA_B	0x61320
+#define HSW_TVIDEO_DIP_VSC_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_VSC_DATA_A + (i) * 4)
+
+/*ADLP and later: */
+#define	_ADL_VIDEO_DIP_AS_DATA_A	0x60484
+#define _ADL_VIDEO_DIP_AS_DATA_B	0x61484
+#define ADL_TVIDEO_DIP_AS_SDP_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans,\
+							     _ADL_VIDEO_DIP_AS_DATA_A + (i) * 4)
+
+#define _GLK_VIDEO_DIP_DRM_DATA_A	0x60440
+#define _GLK_VIDEO_DIP_DRM_DATA_B	0x61440
+#define GLK_TVIDEO_DIP_DRM_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _GLK_VIDEO_DIP_DRM_DATA_A + (i) * 4)
+
+#define _HSW_VIDEO_DIP_GCP_A		0x60210
+#define _HSW_VIDEO_DIP_GCP_B		0x61210
+#define HSW_TVIDEO_DIP_GCP(dev_priv, trans)		_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_GCP_A)
+
+#define _ICL_VIDEO_DIP_PPS_DATA_A	0x60350
+#define _ICL_VIDEO_DIP_PPS_DATA_B	0x61350
+#define ICL_VIDEO_DIP_PPS_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _ICL_VIDEO_DIP_PPS_DATA_A + (i) * 4)
+
+#define _PCH_TRANSACONF              0xf0008
+#define _PCH_TRANSBCONF              0xf1008
+#define PCH_TRANSCONF(pipe)	_MMIO_PIPE(pipe, _PCH_TRANSACONF, _PCH_TRANSBCONF)
+#define LPT_TRANSCONF		PCH_TRANSCONF(PIPE_A) /* lpt has only one transcoder */
+#define  TRANS_ENABLE			REG_BIT(31)
+#define  TRANS_STATE_ENABLE		REG_BIT(30)
+#define  TRANS_FRAME_START_DELAY_MASK	REG_GENMASK(28, 27) /* ibx */
+#define  TRANS_FRAME_START_DELAY(x)	REG_FIELD_PREP(TRANS_FRAME_START_DELAY_MASK, (x)) /* ibx: 0-3 */
+#define  TRANS_INTERLACE_MASK		REG_GENMASK(23, 21)
+#define  TRANS_INTERLACE_PROGRESSIVE	REG_FIELD_PREP(TRANS_INTERLACE_MASK, 0)
+#define  TRANS_INTERLACE_LEGACY_VSYNC_IBX	REG_FIELD_PREP(TRANS_INTERLACE_MASK, 2) /* ibx */
+#define  TRANS_INTERLACE_INTERLACED	REG_FIELD_PREP(TRANS_INTERLACE_MASK, 3)
+#define  TRANS_BPC_MASK			REG_GENMASK(7, 5) /* ibx */
+#define  TRANS_BPC_8			REG_FIELD_PREP(TRANS_BPC_MASK, 0)
+#define  TRANS_BPC_10			REG_FIELD_PREP(TRANS_BPC_MASK, 1)
+#define  TRANS_BPC_6			REG_FIELD_PREP(TRANS_BPC_MASK, 2)
+#define  TRANS_BPC_12			REG_FIELD_PREP(TRANS_BPC_MASK, 3)
+
+#define PCH_DP_B		_MMIO(0xe4100)
+#define PCH_DP_C		_MMIO(0xe4200)
+#define PCH_DP_D		_MMIO(0xe4300)
+
+/* CPT */
+#define _TRANS_DP_CTL_A		0xe0300
+#define _TRANS_DP_CTL_B		0xe1300
+#define _TRANS_DP_CTL_C		0xe2300
+#define TRANS_DP_CTL(pipe)	_MMIO_PIPE(pipe, _TRANS_DP_CTL_A, _TRANS_DP_CTL_B)
+#define  TRANS_DP_OUTPUT_ENABLE		REG_BIT(31)
+#define  TRANS_DP_PORT_SEL_MASK		REG_GENMASK(30, 29)
+#define  TRANS_DP_PORT_SEL_NONE		REG_FIELD_PREP(TRANS_DP_PORT_SEL_MASK, 3)
+#define  TRANS_DP_PORT_SEL(port)	REG_FIELD_PREP(TRANS_DP_PORT_SEL_MASK, (port) - PORT_B)
+#define  TRANS_DP_AUDIO_ONLY		REG_BIT(26)
+#define  TRANS_DP_ENH_FRAMING		REG_BIT(18)
+#define  TRANS_DP_BPC_MASK		REG_GENMASK(10, 9)
+#define  TRANS_DP_BPC_8			REG_FIELD_PREP(TRANS_DP_BPC_MASK, 0)
+#define  TRANS_DP_BPC_10		REG_FIELD_PREP(TRANS_DP_BPC_MASK, 1)
+#define  TRANS_DP_BPC_6			REG_FIELD_PREP(TRANS_DP_BPC_MASK, 2)
+#define  TRANS_DP_BPC_12		REG_FIELD_PREP(TRANS_DP_BPC_MASK, 3)
+#define  TRANS_DP_VSYNC_ACTIVE_HIGH	REG_BIT(4)
+#define  TRANS_DP_HSYNC_ACTIVE_HIGH	REG_BIT(3)
+
+#define _TRANS_DP2_CTL_A			0x600a0
+#define _TRANS_DP2_CTL_B			0x610a0
+#define _TRANS_DP2_CTL_C			0x620a0
+#define _TRANS_DP2_CTL_D			0x630a0
+#define TRANS_DP2_CTL(trans)			_MMIO_TRANS(trans, _TRANS_DP2_CTL_A, _TRANS_DP2_CTL_B)
+#define  TRANS_DP2_128B132B_CHANNEL_CODING	REG_BIT(31)
+#define  TRANS_DP2_PANEL_REPLAY_ENABLE		REG_BIT(30)
+#define  TRANS_DP2_DEBUG_ENABLE			REG_BIT(23)
+
+#define _TRANS_DP2_VFREQHIGH_A			0x600a4
+#define _TRANS_DP2_VFREQHIGH_B			0x610a4
+#define _TRANS_DP2_VFREQHIGH_C			0x620a4
+#define _TRANS_DP2_VFREQHIGH_D			0x630a4
+#define TRANS_DP2_VFREQHIGH(trans)		_MMIO_TRANS(trans, _TRANS_DP2_VFREQHIGH_A, _TRANS_DP2_VFREQHIGH_B)
+#define  TRANS_DP2_VFREQ_PIXEL_CLOCK_MASK	REG_GENMASK(31, 8)
+#define  TRANS_DP2_VFREQ_PIXEL_CLOCK(clk_hz)	REG_FIELD_PREP(TRANS_DP2_VFREQ_PIXEL_CLOCK_MASK, (clk_hz))
+
+#define _TRANS_DP2_VFREQLOW_A			0x600a8
+#define _TRANS_DP2_VFREQLOW_B			0x610a8
+#define _TRANS_DP2_VFREQLOW_C			0x620a8
+#define _TRANS_DP2_VFREQLOW_D			0x630a8
+#define TRANS_DP2_VFREQLOW(trans)		_MMIO_TRANS(trans, _TRANS_DP2_VFREQLOW_A, _TRANS_DP2_VFREQLOW_B)
+
+#define _DP_MIN_HBLANK_CTL_A			0x600ac
+#define _DP_MIN_HBLANK_CTL_B			0x610ac
+#define DP_MIN_HBLANK_CTL(trans)		_MMIO_TRANS(trans, _DP_MIN_HBLANK_CTL_A, _DP_MIN_HBLANK_CTL_B)
+
+/* SNB eDP training params */
+/* SNB A-stepping */
+#define  EDP_LINK_TRAIN_400MV_0DB_SNB_A		(0x38 << 22)
+#define  EDP_LINK_TRAIN_400MV_6DB_SNB_A		(0x02 << 22)
+#define  EDP_LINK_TRAIN_600MV_3_5DB_SNB_A	(0x01 << 22)
+#define  EDP_LINK_TRAIN_800MV_0DB_SNB_A		(0x0 << 22)
+/* SNB B-stepping */
+#define  EDP_LINK_TRAIN_400_600MV_0DB_SNB_B	(0x0 << 22)
+#define  EDP_LINK_TRAIN_400MV_3_5DB_SNB_B	(0x1 << 22)
+#define  EDP_LINK_TRAIN_400_600MV_6DB_SNB_B	(0x3a << 22)
+#define  EDP_LINK_TRAIN_600_800MV_3_5DB_SNB_B	(0x39 << 22)
+#define  EDP_LINK_TRAIN_800_1200MV_0DB_SNB_B	(0x38 << 22)
+#define  EDP_LINK_TRAIN_VOL_EMP_MASK_SNB	(0x3f << 22)
+
+/* IVB */
+#define EDP_LINK_TRAIN_400MV_0DB_IVB		(0x24 << 22)
+#define EDP_LINK_TRAIN_400MV_3_5DB_IVB		(0x2a << 22)
+#define EDP_LINK_TRAIN_400MV_6DB_IVB		(0x2f << 22)
+#define EDP_LINK_TRAIN_600MV_0DB_IVB		(0x30 << 22)
+#define EDP_LINK_TRAIN_600MV_3_5DB_IVB		(0x36 << 22)
+#define EDP_LINK_TRAIN_800MV_0DB_IVB		(0x38 << 22)
+#define EDP_LINK_TRAIN_800MV_3_5DB_IVB		(0x3e << 22)
+
+/* legacy values */
+#define EDP_LINK_TRAIN_500MV_0DB_IVB		(0x00 << 22)
+#define EDP_LINK_TRAIN_1000MV_0DB_IVB		(0x20 << 22)
+#define EDP_LINK_TRAIN_500MV_3_5DB_IVB		(0x02 << 22)
+#define EDP_LINK_TRAIN_1000MV_3_5DB_IVB		(0x22 << 22)
+#define EDP_LINK_TRAIN_1000MV_6DB_IVB		(0x23 << 22)
+
+#define  EDP_LINK_TRAIN_VOL_EMP_MASK_IVB	(0x3f << 22)
+
+#define VLV_CHICKEN_3				_MMIO(VLV_DISPLAY_BASE + 0x7040C)
+#define  PIXEL_OVERLAP_CNT_MASK			(3 << 30)
+#define  PIXEL_OVERLAP_CNT_SHIFT		30
+
+/*
+ * HSW - ICL power wells
+ *
+ * Platforms have up to 3 power well control register sets, each set
+ * controlling up to 16 power wells via a request/status HW flag tuple:
+ * - main (HSW_PWR_WELL_CTL[1-4])
+ * - AUX  (ICL_PWR_WELL_CTL_AUX[1-4])
+ * - DDI  (ICL_PWR_WELL_CTL_DDI[1-4])
+ * Each control register set consists of up to 4 registers used by different
+ * sources that can request a power well to be enabled:
+ * - BIOS   (HSW_PWR_WELL_CTL1/ICL_PWR_WELL_CTL_AUX1/ICL_PWR_WELL_CTL_DDI1)
+ * - DRIVER (HSW_PWR_WELL_CTL2/ICL_PWR_WELL_CTL_AUX2/ICL_PWR_WELL_CTL_DDI2)
+ * - KVMR   (HSW_PWR_WELL_CTL3)   (only in the main register set)
+ * - DEBUG  (HSW_PWR_WELL_CTL4/ICL_PWR_WELL_CTL_AUX4/ICL_PWR_WELL_CTL_DDI4)
+ */
+#define HSW_PWR_WELL_CTL1			_MMIO(0x45400)
+#define HSW_PWR_WELL_CTL2			_MMIO(0x45404)
+#define HSW_PWR_WELL_CTL3			_MMIO(0x45408)
+#define HSW_PWR_WELL_CTL4			_MMIO(0x4540C)
+#define   HSW_PWR_WELL_CTL_REQ(pw_idx)		(0x2 << ((pw_idx) * 2))
+#define   HSW_PWR_WELL_CTL_STATE(pw_idx)	(0x1 << ((pw_idx) * 2))
+
+/* HSW/BDW power well */
+#define   HSW_PW_CTL_IDX_GLOBAL			15
+
+/* SKL/BXT/GLK power wells */
+#define   SKL_PW_CTL_IDX_PW_2			15
+#define   SKL_PW_CTL_IDX_PW_1			14
+#define   GLK_PW_CTL_IDX_AUX_C			10
+#define   GLK_PW_CTL_IDX_AUX_B			9
+#define   GLK_PW_CTL_IDX_AUX_A			8
+#define   SKL_PW_CTL_IDX_DDI_D			4
+#define   SKL_PW_CTL_IDX_DDI_C			3
+#define   SKL_PW_CTL_IDX_DDI_B			2
+#define   SKL_PW_CTL_IDX_DDI_A_E		1
+#define   GLK_PW_CTL_IDX_DDI_A			1
+#define   SKL_PW_CTL_IDX_MISC_IO		0
+
+/* ICL/TGL - power wells */
+#define   TGL_PW_CTL_IDX_PW_5			4
+#define   ICL_PW_CTL_IDX_PW_4			3
+#define   ICL_PW_CTL_IDX_PW_3			2
+#define   ICL_PW_CTL_IDX_PW_2			1
+#define   ICL_PW_CTL_IDX_PW_1			0
+
+/* XE_LPD - power wells */
+#define   XELPD_PW_CTL_IDX_PW_D			8
+#define   XELPD_PW_CTL_IDX_PW_C			7
+#define   XELPD_PW_CTL_IDX_PW_B			6
+#define   XELPD_PW_CTL_IDX_PW_A			5
+
+#define ICL_PWR_WELL_CTL_AUX1			_MMIO(0x45440)
+#define ICL_PWR_WELL_CTL_AUX2			_MMIO(0x45444)
+#define ICL_PWR_WELL_CTL_AUX4			_MMIO(0x4544C)
+#define   TGL_PW_CTL_IDX_AUX_TBT6		14
+#define   TGL_PW_CTL_IDX_AUX_TBT5		13
+#define   TGL_PW_CTL_IDX_AUX_TBT4		12
+#define   ICL_PW_CTL_IDX_AUX_TBT4		11
+#define   TGL_PW_CTL_IDX_AUX_TBT3		11
+#define   ICL_PW_CTL_IDX_AUX_TBT3		10
+#define   TGL_PW_CTL_IDX_AUX_TBT2		10
+#define   ICL_PW_CTL_IDX_AUX_TBT2		9
+#define   TGL_PW_CTL_IDX_AUX_TBT1		9
+#define   ICL_PW_CTL_IDX_AUX_TBT1		8
+#define   TGL_PW_CTL_IDX_AUX_TC6		8
+#define   XELPD_PW_CTL_IDX_AUX_E			8
+#define   TGL_PW_CTL_IDX_AUX_TC5		7
+#define   XELPD_PW_CTL_IDX_AUX_D			7
+#define   TGL_PW_CTL_IDX_AUX_TC4		6
+#define   ICL_PW_CTL_IDX_AUX_F			5
+#define   TGL_PW_CTL_IDX_AUX_TC3		5
+#define   ICL_PW_CTL_IDX_AUX_E			4
+#define   TGL_PW_CTL_IDX_AUX_TC2		4
+#define   ICL_PW_CTL_IDX_AUX_D			3
+#define   TGL_PW_CTL_IDX_AUX_TC1		3
+#define   ICL_PW_CTL_IDX_AUX_C			2
+#define   ICL_PW_CTL_IDX_AUX_B			1
+#define   ICL_PW_CTL_IDX_AUX_A			0
+
+#define ICL_PWR_WELL_CTL_DDI1			_MMIO(0x45450)
+#define ICL_PWR_WELL_CTL_DDI2			_MMIO(0x45454)
+#define ICL_PWR_WELL_CTL_DDI4			_MMIO(0x4545C)
+#define   XELPD_PW_CTL_IDX_DDI_E			8
+#define   TGL_PW_CTL_IDX_DDI_TC6		8
+#define   XELPD_PW_CTL_IDX_DDI_D			7
+#define   TGL_PW_CTL_IDX_DDI_TC5		7
+#define   TGL_PW_CTL_IDX_DDI_TC4		6
+#define   ICL_PW_CTL_IDX_DDI_F			5
+#define   TGL_PW_CTL_IDX_DDI_TC3		5
+#define   ICL_PW_CTL_IDX_DDI_E			4
+#define   TGL_PW_CTL_IDX_DDI_TC2		4
+#define   ICL_PW_CTL_IDX_DDI_D			3
+#define   TGL_PW_CTL_IDX_DDI_TC1		3
+#define   ICL_PW_CTL_IDX_DDI_C			2
+#define   ICL_PW_CTL_IDX_DDI_B			1
+#define   ICL_PW_CTL_IDX_DDI_A			0
+
+#define SKL_FUSE_STATUS				_MMIO(0x42000)
+#define  SKL_FUSE_DOWNLOAD_STATUS		(1 << 31)
+/*
+ * PG0 is HW controlled, so doesn't have a corresponding power well control knob
+ * SKL_DISP_PW1_IDX..SKL_DISP_PW2_IDX -> PG1..PG2
+ */
+#define  SKL_PW_CTL_IDX_TO_PG(pw_idx)		\
+	((pw_idx) - SKL_PW_CTL_IDX_PW_1 + SKL_PG1)
+/*
+ * PG0 is HW controlled, so doesn't have a corresponding power well control knob
+ * ICL_DISP_PW1_IDX..ICL_DISP_PW4_IDX -> PG1..PG4
+ */
+#define  ICL_PW_CTL_IDX_TO_PG(pw_idx)		\
+	((pw_idx) - ICL_PW_CTL_IDX_PW_1 + SKL_PG1)
+#define  SKL_FUSE_PG_DIST_STATUS(pg)		(1 << (27 - (pg)))
+
+/* Per-pipe DDI Function Control */
+#define _TRANS_DDI_FUNC_CTL_A		0x60400
+#define _TRANS_DDI_FUNC_CTL_B		0x61400
+#define _TRANS_DDI_FUNC_CTL_C		0x62400
+#define _TRANS_DDI_FUNC_CTL_D		0x63400
+#define _TRANS_DDI_FUNC_CTL_EDP		0x6F400
+#define _TRANS_DDI_FUNC_CTL_DSI0	0x6b400
+#define _TRANS_DDI_FUNC_CTL_DSI1	0x6bc00
+#define TRANS_DDI_FUNC_CTL(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, _TRANS_DDI_FUNC_CTL_A)
+
+#define  TRANS_DDI_FUNC_ENABLE		(1 << 31)
+/* Those bits are ignored by pipe EDP since it can only connect to DDI A */
+#define  TRANS_DDI_PORT_SHIFT		28
+#define  TGL_TRANS_DDI_PORT_SHIFT	27
+#define  TRANS_DDI_PORT_MASK		(7 << TRANS_DDI_PORT_SHIFT)
+#define  TGL_TRANS_DDI_PORT_MASK	(0xf << TGL_TRANS_DDI_PORT_SHIFT)
+#define  TRANS_DDI_SELECT_PORT(x)	((x) << TRANS_DDI_PORT_SHIFT)
+#define  TGL_TRANS_DDI_SELECT_PORT(x)	(((x) + 1) << TGL_TRANS_DDI_PORT_SHIFT)
+#define  TRANS_DDI_MODE_SELECT_MASK	(7 << 24)
+#define  TRANS_DDI_MODE_SELECT_HDMI	(0 << 24)
+#define  TRANS_DDI_MODE_SELECT_DVI	(1 << 24)
+#define  TRANS_DDI_MODE_SELECT_DP_SST	(2 << 24)
+#define  TRANS_DDI_MODE_SELECT_DP_MST	(3 << 24)
+#define  TRANS_DDI_MODE_SELECT_FDI_OR_128B132B	(4 << 24)
+#define  TRANS_DDI_BPC_MASK		(7 << 20)
+#define  TRANS_DDI_BPC_8		(0 << 20)
+#define  TRANS_DDI_BPC_10		(1 << 20)
+#define  TRANS_DDI_BPC_6		(2 << 20)
+#define  TRANS_DDI_BPC_12		(3 << 20)
+#define  TRANS_DDI_PORT_SYNC_MASTER_SELECT_MASK	REG_GENMASK(19, 18)
+#define  TRANS_DDI_PORT_SYNC_MASTER_SELECT(x)	REG_FIELD_PREP(TRANS_DDI_PORT_SYNC_MASTER_SELECT_MASK, (x))
+#define  TRANS_DDI_PVSYNC		(1 << 17)
+#define  TRANS_DDI_PHSYNC		(1 << 16)
+#define  TRANS_DDI_PORT_SYNC_ENABLE	REG_BIT(15)
+#define  XE3_TRANS_DDI_HDCP_LINE_REKEY_DISABLE	REG_BIT(15)
+#define  TRANS_DDI_EDP_INPUT_MASK	(7 << 12)
+#define  TRANS_DDI_EDP_INPUT_A_ON	(0 << 12)
+#define  TRANS_DDI_EDP_INPUT_A_ONOFF	(4 << 12)
+#define  TRANS_DDI_EDP_INPUT_B_ONOFF	(5 << 12)
+#define  TRANS_DDI_EDP_INPUT_C_ONOFF	(6 << 12)
+#define  TRANS_DDI_EDP_INPUT_D_ONOFF	(7 << 12)
+#define  TRANS_DDI_HDCP_LINE_REKEY_DISABLE	REG_BIT(12)
+#define  TRANS_DDI_MST_TRANSPORT_SELECT_MASK	REG_GENMASK(11, 10)
+#define  TRANS_DDI_MST_TRANSPORT_SELECT(trans)	\
+	REG_FIELD_PREP(TRANS_DDI_MST_TRANSPORT_SELECT_MASK, trans)
+#define  TRANS_DDI_HDCP_SIGNALLING	(1 << 9)
+#define  TRANS_DDI_DP_VC_PAYLOAD_ALLOC	(1 << 8)
+#define  TRANS_DDI_HDMI_SCRAMBLER_CTS_ENABLE (1 << 7)
+#define  TRANS_DDI_HDMI_SCRAMBLER_RESET_FREQ (1 << 6)
+#define  TRANS_DDI_HDCP_SELECT		REG_BIT(5)
+#define  TRANS_DDI_BFI_ENABLE		(1 << 4)
+#define  TRANS_DDI_HIGH_TMDS_CHAR_RATE	(1 << 4)
+#define  TRANS_DDI_PORT_WIDTH_MASK	REG_GENMASK(3, 1)
+#define  TRANS_DDI_PORT_WIDTH(width)	REG_FIELD_PREP(TRANS_DDI_PORT_WIDTH_MASK, (width) - 1)
+#define  TRANS_DDI_HDMI_SCRAMBLING	(1 << 0)
+#define  TRANS_DDI_HDMI_SCRAMBLING_MASK (TRANS_DDI_HDMI_SCRAMBLER_CTS_ENABLE \
+					| TRANS_DDI_HDMI_SCRAMBLER_RESET_FREQ \
+					| TRANS_DDI_HDMI_SCRAMBLING)
+
+#define _TRANS_DDI_FUNC_CTL2_A		0x60404
+#define _TRANS_DDI_FUNC_CTL2_B		0x61404
+#define _TRANS_DDI_FUNC_CTL2_C		0x62404
+#define _TRANS_DDI_FUNC_CTL2_EDP	0x6f404
+#define _TRANS_DDI_FUNC_CTL2_DSI0	0x6b404
+#define _TRANS_DDI_FUNC_CTL2_DSI1	0x6bc04
+#define TRANS_DDI_FUNC_CTL2(dev_priv, tran)	_MMIO_TRANS2(dev_priv, tran, _TRANS_DDI_FUNC_CTL2_A)
+#define  PORT_SYNC_MODE_ENABLE			REG_BIT(4)
+#define  CMTG_SECONDARY_MODE			REG_BIT(3)
+#define  PORT_SYNC_MODE_MASTER_SELECT_MASK	REG_GENMASK(2, 0)
+#define  PORT_SYNC_MODE_MASTER_SELECT(x)	REG_FIELD_PREP(PORT_SYNC_MODE_MASTER_SELECT_MASK, (x))
+
+#define TRANS_CMTG_CHICKEN		_MMIO(0x6fa90)
+#define  DISABLE_DPT_CLK_GATING		REG_BIT(1)
+
+/* DisplayPort Transport Control */
+#define _DP_TP_CTL_A			0x64040
+#define _DP_TP_CTL_B			0x64140
+#define _TGL_DP_TP_CTL_A		0x60540
+#define DP_TP_CTL(port) _MMIO_PORT(port, _DP_TP_CTL_A, _DP_TP_CTL_B)
+#define TGL_DP_TP_CTL(dev_priv, tran) _MMIO_TRANS2(dev_priv, (tran), _TGL_DP_TP_CTL_A)
+#define   DP_TP_CTL_ENABLE			REG_BIT(31)
+#define   DP_TP_CTL_FEC_ENABLE			REG_BIT(30)
+#define   DP_TP_CTL_MODE_MASK			REG_BIT(27)
+#define   DP_TP_CTL_MODE_SST			REG_FIELD_PREP(DP_TP_CTL_MODE_MASK, 0)
+#define   DP_TP_CTL_MODE_MST			REG_FIELD_PREP(DP_TP_CTL_MODE_MASK, 1)
+#define   DP_TP_CTL_FORCE_ACT			REG_BIT(25)
+#define   DP_TP_CTL_TRAIN_PAT4_SEL_MASK		REG_GENMASK(20, 19)
+#define   DP_TP_CTL_TRAIN_PAT4_SEL_TP4A		REG_FIELD_PREP(DP_TP_CTL_TRAIN_PAT4_SEL_MASK, 0)
+#define   DP_TP_CTL_TRAIN_PAT4_SEL_TP4B		REG_FIELD_PREP(DP_TP_CTL_TRAIN_PAT4_SEL_MASK, 1)
+#define   DP_TP_CTL_TRAIN_PAT4_SEL_TP4C		REG_FIELD_PREP(DP_TP_CTL_TRAIN_PAT4_SEL_MASK, 2)
+#define   DP_TP_CTL_ENHANCED_FRAME_ENABLE	REG_BIT(18)
+#define   DP_TP_CTL_FDI_AUTOTRAIN		REG_BIT(15)
+#define   DP_TP_CTL_LINK_TRAIN_MASK		REG_GENMASK(10, 8)
+#define   DP_TP_CTL_LINK_TRAIN_PAT1		REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 0)
+#define   DP_TP_CTL_LINK_TRAIN_PAT2		REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 1)
+#define   DP_TP_CTL_LINK_TRAIN_PAT3		REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 4)
+#define   DP_TP_CTL_LINK_TRAIN_PAT4		REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 5)
+#define   DP_TP_CTL_LINK_TRAIN_IDLE		REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 2)
+#define   DP_TP_CTL_LINK_TRAIN_NORMAL		REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 3)
+#define   DP_TP_CTL_SCRAMBLE_DISABLE		REG_BIT(7)
+
+/* DisplayPort Transport Status */
+#define _DP_TP_STATUS_A			0x64044
+#define _DP_TP_STATUS_B			0x64144
+#define _TGL_DP_TP_STATUS_A		0x60544
+#define DP_TP_STATUS(port) _MMIO_PORT(port, _DP_TP_STATUS_A, _DP_TP_STATUS_B)
+#define TGL_DP_TP_STATUS(dev_priv, tran) _MMIO_TRANS2(dev_priv, (tran), _TGL_DP_TP_STATUS_A)
+#define   DP_TP_STATUS_FEC_ENABLE_LIVE		REG_BIT(28)
+#define   DP_TP_STATUS_IDLE_DONE		REG_BIT(25)
+#define   DP_TP_STATUS_ACT_SENT			REG_BIT(24)
+#define   DP_TP_STATUS_MODE_STATUS_MST		REG_BIT(23)
+#define   DP_TP_STATUS_STREAMS_ENABLED_MASK	REG_GENMASK(18, 16) /* 17:16 on hsw but bit 18 mbz */
+#define   DP_TP_STATUS_AUTOTRAIN_DONE		REG_BIT(12)
+#define   DP_TP_STATUS_PAYLOAD_MAPPING_VC2_MASK REG_GENMASK(9, 8)
+#define   DP_TP_STATUS_PAYLOAD_MAPPING_VC1_MASK	REG_GENMASK(5, 4)
+#define   DP_TP_STATUS_PAYLOAD_MAPPING_VC0_MASK	REG_GENMASK(1, 0)
+
+/* DDI Buffer Control */
+#define _DDI_BUF_CTL_A				0x64000
+#define _DDI_BUF_CTL_B				0x64100
+/* Known as DDI_CTL_DE in MTL+ */
+#define DDI_BUF_CTL(port) _MMIO_PORT(port, _DDI_BUF_CTL_A, _DDI_BUF_CTL_B)
+#define  DDI_BUF_CTL_ENABLE			(1 << 31)
+#define  XE2LPD_DDI_BUF_D2D_LINK_ENABLE		REG_BIT(29)
+#define  XE2LPD_DDI_BUF_D2D_LINK_STATE		REG_BIT(28)
+#define  DDI_BUF_TRANS_SELECT(n)	((n) << 24)
+#define  DDI_BUF_EMP_MASK			(0xf << 24)
+#define  DDI_BUF_PHY_LINK_RATE(r)		((r) << 20)
+#define  DDI_BUF_PORT_DATA_MASK			REG_GENMASK(19, 18)
+#define  DDI_BUF_PORT_DATA_10BIT		REG_FIELD_PREP(DDI_BUF_PORT_DATA_MASK, 0)
+#define  DDI_BUF_PORT_DATA_20BIT		REG_FIELD_PREP(DDI_BUF_PORT_DATA_MASK, 1)
+#define  DDI_BUF_PORT_DATA_40BIT		REG_FIELD_PREP(DDI_BUF_PORT_DATA_MASK, 2)
+#define  DDI_BUF_PORT_REVERSAL			(1 << 16)
+#define  DDI_BUF_IS_IDLE			(1 << 7)
+#define  DDI_BUF_CTL_TC_PHY_OWNERSHIP		REG_BIT(6)
+#define  DDI_A_4_LANES				(1 << 4)
+#define  DDI_PORT_WIDTH(width)			(((width) - 1) << 1)
+#define  DDI_PORT_WIDTH_MASK			(7 << 1)
+#define  DDI_PORT_WIDTH_SHIFT			1
+#define  DDI_INIT_DISPLAY_DETECTED		(1 << 0)
+
+/* DDI Buffer Translations */
+#define _DDI_BUF_TRANS_A		0x64E00
+#define _DDI_BUF_TRANS_B		0x64E60
+#define DDI_BUF_TRANS_LO(port, i)	_MMIO(_PORT(port, _DDI_BUF_TRANS_A, _DDI_BUF_TRANS_B) + (i) * 8)
+#define  DDI_BUF_BALANCE_LEG_ENABLE	(1 << 31)
+#define DDI_BUF_TRANS_HI(port, i)	_MMIO(_PORT(port, _DDI_BUF_TRANS_A, _DDI_BUF_TRANS_B) + (i) * 8 + 4)
+
+/* DDI DP Compliance Control */
+#define _DDI_DP_COMP_CTL_A			0x605F0
+#define _DDI_DP_COMP_CTL_B			0x615F0
+#define DDI_DP_COMP_CTL(pipe)			_MMIO_PIPE(pipe, _DDI_DP_COMP_CTL_A, _DDI_DP_COMP_CTL_B)
+#define   DDI_DP_COMP_CTL_ENABLE		(1 << 31)
+#define   DDI_DP_COMP_CTL_D10_2			(0 << 28)
+#define   DDI_DP_COMP_CTL_SCRAMBLED_0		(1 << 28)
+#define   DDI_DP_COMP_CTL_PRBS7			(2 << 28)
+#define   DDI_DP_COMP_CTL_CUSTOM80		(3 << 28)
+#define   DDI_DP_COMP_CTL_HBR2			(4 << 28)
+#define   DDI_DP_COMP_CTL_SCRAMBLED_1		(5 << 28)
+#define   DDI_DP_COMP_CTL_HBR2_RESET		(0xFC << 0)
+
+/* DDI DP Compliance Pattern */
+#define _DDI_DP_COMP_PAT_A			0x605F4
+#define _DDI_DP_COMP_PAT_B			0x615F4
+#define DDI_DP_COMP_PAT(pipe, i)		_MMIO(_PIPE(pipe, _DDI_DP_COMP_PAT_A, _DDI_DP_COMP_PAT_B) + (i) * 4)
+
+/* SBI offsets */
+#define  SBI_SSCDIVINTPHASE			0x0200
+#define  SBI_SSCDIVINTPHASE6			0x0600
+#define   SBI_SSCDIVINTPHASE_DIVSEL_SHIFT	1
+#define   SBI_SSCDIVINTPHASE_DIVSEL_MASK	(0x7f << 1)
+#define   SBI_SSCDIVINTPHASE_DIVSEL(x)		((x) << 1)
+#define   SBI_SSCDIVINTPHASE_INCVAL_SHIFT	8
+#define   SBI_SSCDIVINTPHASE_INCVAL_MASK	(0x7f << 8)
+#define   SBI_SSCDIVINTPHASE_INCVAL(x)		((x) << 8)
+#define   SBI_SSCDIVINTPHASE_DIR(x)		((x) << 15)
+#define   SBI_SSCDIVINTPHASE_PROPAGATE		(1 << 0)
+#define  SBI_SSCDITHPHASE			0x0204
+#define  SBI_SSCCTL				0x020c
+#define  SBI_SSCCTL6				0x060C
+#define   SBI_SSCCTL_PATHALT			(1 << 3)
+#define   SBI_SSCCTL_DISABLE			(1 << 0)
+#define  SBI_SSCAUXDIV6				0x0610
+#define   SBI_SSCAUXDIV_FINALDIV2SEL_SHIFT	4
+#define   SBI_SSCAUXDIV_FINALDIV2SEL_MASK	(1 << 4)
+#define   SBI_SSCAUXDIV_FINALDIV2SEL(x)		((x) << 4)
+#define  SBI_DBUFF0				0x2a00
+#define  SBI_GEN0				0x1f00
+#define   SBI_GEN0_CFG_BUFFENABLE_DISABLE	(1 << 0)
+
+/* LPT PIXCLK_GATE */
+#define PIXCLK_GATE			_MMIO(0xC6020)
+#define  PIXCLK_GATE_UNGATE		(1 << 0)
+#define  PIXCLK_GATE_GATE		(0 << 0)
+
+/* SPLL */
+#define SPLL_CTL			_MMIO(0x46020)
+#define  SPLL_PLL_ENABLE		(1 << 31)
+#define  SPLL_REF_BCLK			(0 << 28)
+#define  SPLL_REF_MUXED_SSC		(1 << 28) /* CPU SSC if fused enabled, PCH SSC otherwise */
+#define  SPLL_REF_NON_SSC_HSW		(2 << 28)
+#define  SPLL_REF_PCH_SSC_BDW		(2 << 28)
+#define  SPLL_REF_LCPLL			(3 << 28)
+#define  SPLL_REF_MASK			(3 << 28)
+#define  SPLL_FREQ_810MHz		(0 << 26)
+#define  SPLL_FREQ_1350MHz		(1 << 26)
+#define  SPLL_FREQ_2700MHz		(2 << 26)
+#define  SPLL_FREQ_MASK			(3 << 26)
+
+/* WRPLL */
+#define _WRPLL_CTL1			0x46040
+#define _WRPLL_CTL2			0x46060
+#define WRPLL_CTL(pll)			_MMIO_PIPE(pll, _WRPLL_CTL1, _WRPLL_CTL2)
+#define  WRPLL_PLL_ENABLE		(1 << 31)
+#define  WRPLL_REF_BCLK			(0 << 28)
+#define  WRPLL_REF_PCH_SSC		(1 << 28)
+#define  WRPLL_REF_MUXED_SSC_BDW	(2 << 28) /* CPU SSC if fused enabled, PCH SSC otherwise */
+#define  WRPLL_REF_SPECIAL_HSW		(2 << 28) /* muxed SSC (ULT), non-SSC (non-ULT) */
+#define  WRPLL_REF_LCPLL		(3 << 28)
+#define  WRPLL_REF_MASK			(3 << 28)
+/* WRPLL divider programming */
+#define  WRPLL_DIVIDER_REFERENCE(x)	((x) << 0)
+#define  WRPLL_DIVIDER_REF_MASK		(0xff)
+#define  WRPLL_DIVIDER_POST(x)		((x) << 8)
+#define  WRPLL_DIVIDER_POST_MASK	(0x3f << 8)
+#define  WRPLL_DIVIDER_POST_SHIFT	8
+#define  WRPLL_DIVIDER_FEEDBACK(x)	((x) << 16)
+#define  WRPLL_DIVIDER_FB_SHIFT		16
+#define  WRPLL_DIVIDER_FB_MASK		(0xff << 16)
+
+/* Port clock selection */
+#define _PORT_CLK_SEL_A			0x46100
+#define _PORT_CLK_SEL_B			0x46104
+#define PORT_CLK_SEL(port) _MMIO_PORT(port, _PORT_CLK_SEL_A, _PORT_CLK_SEL_B)
+#define  PORT_CLK_SEL_MASK		REG_GENMASK(31, 29)
+#define  PORT_CLK_SEL_LCPLL_2700	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 0)
+#define  PORT_CLK_SEL_LCPLL_1350	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 1)
+#define  PORT_CLK_SEL_LCPLL_810		REG_FIELD_PREP(PORT_CLK_SEL_MASK, 2)
+#define  PORT_CLK_SEL_SPLL		REG_FIELD_PREP(PORT_CLK_SEL_MASK, 3)
+#define  PORT_CLK_SEL_WRPLL(pll)	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 4 + (pll))
+#define  PORT_CLK_SEL_WRPLL1		REG_FIELD_PREP(PORT_CLK_SEL_MASK, 4)
+#define  PORT_CLK_SEL_WRPLL2		REG_FIELD_PREP(PORT_CLK_SEL_MASK, 5)
+#define  PORT_CLK_SEL_NONE		REG_FIELD_PREP(PORT_CLK_SEL_MASK, 7)
+
+/* On ICL+ this is the same as PORT_CLK_SEL, but all bits change. */
+#define DDI_CLK_SEL(port)		PORT_CLK_SEL(port)
+#define  DDI_CLK_SEL_MASK		REG_GENMASK(31, 28)
+#define  DDI_CLK_SEL_NONE		REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0x0)
+#define  DDI_CLK_SEL_MG			REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0x8)
+#define  DDI_CLK_SEL_TBT_162		REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xC)
+#define  DDI_CLK_SEL_TBT_270		REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xD)
+#define  DDI_CLK_SEL_TBT_540		REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xE)
+#define  DDI_CLK_SEL_TBT_810		REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xF)
+
+/* Transcoder clock selection */
+#define _TRANS_CLK_SEL_A		0x46140
+#define _TRANS_CLK_SEL_B		0x46144
+#define TRANS_CLK_SEL(tran) _MMIO_TRANS(tran, _TRANS_CLK_SEL_A, _TRANS_CLK_SEL_B)
+/* For each transcoder, we need to select the corresponding port clock */
+#define  TRANS_CLK_SEL_DISABLED		(0x0 << 29)
+#define  TRANS_CLK_SEL_PORT(x)		(((x) + 1) << 29)
+#define  TGL_TRANS_CLK_SEL_DISABLED	(0x0 << 28)
+#define  TGL_TRANS_CLK_SEL_PORT(x)	(((x) + 1) << 28)
+
+#define CDCLK_FREQ			_MMIO(0x46200)
+
+#define _TRANSA_MSA_MISC		0x60410
+#define _TRANSB_MSA_MISC		0x61410
+#define _TRANSC_MSA_MISC		0x62410
+#define _TRANS_EDP_MSA_MISC		0x6f410
+#define TRANS_MSA_MISC(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, _TRANSA_MSA_MISC)
+/* See DP_MSA_MISC_* for the bit definitions */
+
+#define _TRANS_A_SET_CONTEXT_LATENCY		0x6007C
+#define _TRANS_B_SET_CONTEXT_LATENCY		0x6107C
+#define _TRANS_C_SET_CONTEXT_LATENCY		0x6207C
+#define _TRANS_D_SET_CONTEXT_LATENCY		0x6307C
+#define TRANS_SET_CONTEXT_LATENCY(dev_priv, tran)		_MMIO_TRANS2(dev_priv, tran, _TRANS_A_SET_CONTEXT_LATENCY)
+#define  TRANS_SET_CONTEXT_LATENCY_MASK		REG_GENMASK(15, 0)
+#define  TRANS_SET_CONTEXT_LATENCY_VALUE(x)	REG_FIELD_PREP(TRANS_SET_CONTEXT_LATENCY_MASK, (x))
+
+/* LCPLL Control */
+#define LCPLL_CTL			_MMIO(0x130040)
+#define  LCPLL_PLL_DISABLE		(1 << 31)
+#define  LCPLL_PLL_LOCK			(1 << 30)
+#define  LCPLL_REF_NON_SSC		(0 << 28)
+#define  LCPLL_REF_BCLK			(2 << 28)
+#define  LCPLL_REF_PCH_SSC		(3 << 28)
+#define  LCPLL_REF_MASK			(3 << 28)
+#define  LCPLL_CLK_FREQ_MASK		(3 << 26)
+#define  LCPLL_CLK_FREQ_450		(0 << 26)
+#define  LCPLL_CLK_FREQ_54O_BDW		(1 << 26)
+#define  LCPLL_CLK_FREQ_337_5_BDW	(2 << 26)
+#define  LCPLL_CLK_FREQ_675_BDW		(3 << 26)
+#define  LCPLL_CD_CLOCK_DISABLE		(1 << 25)
+#define  LCPLL_ROOT_CD_CLOCK_DISABLE	(1 << 24)
+#define  LCPLL_CD2X_CLOCK_DISABLE	(1 << 23)
+#define  LCPLL_POWER_DOWN_ALLOW		(1 << 22)
+#define  LCPLL_CD_SOURCE_FCLK		(1 << 21)
+#define  LCPLL_CD_SOURCE_FCLK_DONE	(1 << 19)
+
+/*
+ * SKL Clocks
+ */
+/* CDCLK_CTL */
+#define CDCLK_CTL			_MMIO(0x46000)
+#define  CDCLK_FREQ_SEL_MASK		REG_GENMASK(27, 26)
+#define  CDCLK_FREQ_450_432		REG_FIELD_PREP(CDCLK_FREQ_SEL_MASK, 0)
+#define  CDCLK_FREQ_540		REG_FIELD_PREP(CDCLK_FREQ_SEL_MASK, 1)
+#define  CDCLK_FREQ_337_308		REG_FIELD_PREP(CDCLK_FREQ_SEL_MASK, 2)
+#define  CDCLK_FREQ_675_617		REG_FIELD_PREP(CDCLK_FREQ_SEL_MASK, 3)
+#define  MDCLK_SOURCE_SEL_MASK		REG_GENMASK(25, 25)
+#define  MDCLK_SOURCE_SEL_CD2XCLK	REG_FIELD_PREP(MDCLK_SOURCE_SEL_MASK, 0)
+#define  MDCLK_SOURCE_SEL_CDCLK_PLL	REG_FIELD_PREP(MDCLK_SOURCE_SEL_MASK, 1)
+#define  BXT_CDCLK_CD2X_DIV_SEL_MASK	REG_GENMASK(23, 22)
+#define  BXT_CDCLK_CD2X_DIV_SEL_1	REG_FIELD_PREP(BXT_CDCLK_CD2X_DIV_SEL_MASK, 0)
+#define  BXT_CDCLK_CD2X_DIV_SEL_1_5	REG_FIELD_PREP(BXT_CDCLK_CD2X_DIV_SEL_MASK, 1)
+#define  BXT_CDCLK_CD2X_DIV_SEL_2	REG_FIELD_PREP(BXT_CDCLK_CD2X_DIV_SEL_MASK, 2)
+#define  BXT_CDCLK_CD2X_DIV_SEL_4	REG_FIELD_PREP(BXT_CDCLK_CD2X_DIV_SEL_MASK, 3)
+#define  BXT_CDCLK_CD2X_PIPE(pipe)	((pipe) << 20)
+#define  CDCLK_DIVMUX_CD_OVERRIDE	(1 << 19)
+#define  BXT_CDCLK_CD2X_PIPE_NONE	BXT_CDCLK_CD2X_PIPE(3)
+#define  ICL_CDCLK_CD2X_PIPE(pipe)	(_PICK(pipe, 0, 2, 6) << 19)
+#define  ICL_CDCLK_CD2X_PIPE_NONE	(7 << 19)
+#define  TGL_CDCLK_CD2X_PIPE(pipe)	BXT_CDCLK_CD2X_PIPE(pipe)
+#define  TGL_CDCLK_CD2X_PIPE_NONE	ICL_CDCLK_CD2X_PIPE_NONE
+#define  BXT_CDCLK_SSA_PRECHARGE_ENABLE	(1 << 16)
+#define  CDCLK_FREQ_DECIMAL_MASK	(0x7ff)
+
+/* CDCLK_SQUASH_CTL */
+#define CDCLK_SQUASH_CTL		_MMIO(0x46008)
+#define  CDCLK_SQUASH_ENABLE		REG_BIT(31)
+#define  CDCLK_SQUASH_WINDOW_SIZE_MASK	REG_GENMASK(27, 24)
+#define  CDCLK_SQUASH_WINDOW_SIZE(x)	REG_FIELD_PREP(CDCLK_SQUASH_WINDOW_SIZE_MASK, (x))
+#define  CDCLK_SQUASH_WAVEFORM_MASK	REG_GENMASK(15, 0)
+#define  CDCLK_SQUASH_WAVEFORM(x)	REG_FIELD_PREP(CDCLK_SQUASH_WAVEFORM_MASK, (x))
+
+/* LCPLL_CTL */
+#define LCPLL1_CTL		_MMIO(0x46010)
+#define LCPLL2_CTL		_MMIO(0x46014)
+#define  LCPLL_PLL_ENABLE	(1 << 31)
+
+/* DPLL control1 */
+#define DPLL_CTRL1		_MMIO(0x6C058)
+#define  DPLL_CTRL1_HDMI_MODE(id)		(1 << ((id) * 6 + 5))
+#define  DPLL_CTRL1_SSC(id)			(1 << ((id) * 6 + 4))
+#define  DPLL_CTRL1_LINK_RATE_MASK(id)		(7 << ((id) * 6 + 1))
+#define  DPLL_CTRL1_LINK_RATE_SHIFT(id)		((id) * 6 + 1)
+#define  DPLL_CTRL1_LINK_RATE(linkrate, id)	((linkrate) << ((id) * 6 + 1))
+#define  DPLL_CTRL1_OVERRIDE(id)		(1 << ((id) * 6))
+#define  DPLL_CTRL1_LINK_RATE_2700		0
+#define  DPLL_CTRL1_LINK_RATE_1350		1
+#define  DPLL_CTRL1_LINK_RATE_810		2
+#define  DPLL_CTRL1_LINK_RATE_1620		3
+#define  DPLL_CTRL1_LINK_RATE_1080		4
+#define  DPLL_CTRL1_LINK_RATE_2160		5
+
+/* DPLL control2 */
+#define DPLL_CTRL2				_MMIO(0x6C05C)
+#define  DPLL_CTRL2_DDI_CLK_OFF(port)		(1 << ((port) + 15))
+#define  DPLL_CTRL2_DDI_CLK_SEL_MASK(port)	(3 << ((port) * 3 + 1))
+#define  DPLL_CTRL2_DDI_CLK_SEL_SHIFT(port)    ((port) * 3 + 1)
+#define  DPLL_CTRL2_DDI_CLK_SEL(clk, port)	((clk) << ((port) * 3 + 1))
+#define  DPLL_CTRL2_DDI_SEL_OVERRIDE(port)     (1 << ((port) * 3))
+
+/* DPLL Status */
+#define DPLL_STATUS	_MMIO(0x6C060)
+#define  DPLL_LOCK(id) (1 << ((id) * 8))
+
+/* DPLL cfg */
+#define _DPLL1_CFGCR1	0x6C040
+#define _DPLL2_CFGCR1	0x6C048
+#define _DPLL3_CFGCR1	0x6C050
+#define DPLL_CFGCR1(id)	_MMIO_PIPE((id) - SKL_DPLL1, _DPLL1_CFGCR1, _DPLL2_CFGCR1)
+#define  DPLL_CFGCR1_FREQ_ENABLE	(1 << 31)
+#define  DPLL_CFGCR1_DCO_FRACTION_MASK	(0x7fff << 9)
+#define  DPLL_CFGCR1_DCO_FRACTION(x)	((x) << 9)
+#define  DPLL_CFGCR1_DCO_INTEGER_MASK	(0x1ff)
+
+#define _DPLL1_CFGCR2	0x6C044
+#define _DPLL2_CFGCR2	0x6C04C
+#define _DPLL3_CFGCR2	0x6C054
+#define DPLL_CFGCR2(id)	_MMIO_PIPE((id) - SKL_DPLL1, _DPLL1_CFGCR2, _DPLL2_CFGCR2)
+#define  DPLL_CFGCR2_QDIV_RATIO_MASK	(0xff << 8)
+#define  DPLL_CFGCR2_QDIV_RATIO(x)	((x) << 8)
+#define  DPLL_CFGCR2_QDIV_MODE(x)	((x) << 7)
+#define  DPLL_CFGCR2_KDIV_MASK		(3 << 5)
+#define  DPLL_CFGCR2_KDIV(x)		((x) << 5)
+#define  DPLL_CFGCR2_KDIV_5 (0 << 5)
+#define  DPLL_CFGCR2_KDIV_2 (1 << 5)
+#define  DPLL_CFGCR2_KDIV_3 (2 << 5)
+#define  DPLL_CFGCR2_KDIV_1 (3 << 5)
+#define  DPLL_CFGCR2_PDIV_MASK		(7 << 2)
+#define  DPLL_CFGCR2_PDIV(x)		((x) << 2)
+#define  DPLL_CFGCR2_PDIV_1 (0 << 2)
+#define  DPLL_CFGCR2_PDIV_2 (1 << 2)
+#define  DPLL_CFGCR2_PDIV_3 (2 << 2)
+#define  DPLL_CFGCR2_PDIV_7 (4 << 2)
+#define  DPLL_CFGCR2_PDIV_7_INVALID	(5 << 2)
+#define  DPLL_CFGCR2_CENTRAL_FREQ_MASK	(3)
+
+/* ICL Clocks */
+#define ICL_DPCLKA_CFGCR0			_MMIO(0x164280)
+#define  ICL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy)	(1 << _PICK(phy, 10, 11, 24, 4, 5))
+#define  RKL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy)	REG_BIT((phy) + 10)
+#define  ICL_DPCLKA_CFGCR0_TC_CLK_OFF(tc_port)	(1 << ((tc_port) < TC_PORT_4 ? \
+						       (tc_port) + 12 : \
+						       (tc_port) - TC_PORT_4 + 21))
+#define  ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy)	((phy) * 2)
+#define  ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK(phy)	(3 << ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
+#define  ICL_DPCLKA_CFGCR0_DDI_CLK_SEL(pll, phy)	((pll) << ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
+#define  RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy)	_PICK(phy, 0, 2, 4, 27)
+#define  RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK(phy) \
+	(3 << RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
+#define  RKL_DPCLKA_CFGCR0_DDI_CLK_SEL(pll, phy) \
+	((pll) << RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
+
+/*
+ * DG1 Clocks
+ * First registers controls the first A and B, while the second register
+ * controls the phy C and D. The bits on these registers are the
+ * same, but refer to different phys
+ */
+#define _DG1_DPCLKA_CFGCR0				0x164280
+#define _DG1_DPCLKA1_CFGCR0				0x16C280
+#define _DG1_DPCLKA_PHY_IDX(phy)			((phy) % 2)
+#define _DG1_DPCLKA_PLL_IDX(pll)			((pll) % 2)
+#define DG1_DPCLKA_CFGCR0(phy)				_MMIO_PHY((phy) / 2, \
+								  _DG1_DPCLKA_CFGCR0, \
+								  _DG1_DPCLKA1_CFGCR0)
+#define   DG1_DPCLKA_CFGCR0_DDI_CLK_OFF(phy)		REG_BIT(_DG1_DPCLKA_PHY_IDX(phy) + 10)
+#define   DG1_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy)	(_DG1_DPCLKA_PHY_IDX(phy) * 2)
+#define   DG1_DPCLKA_CFGCR0_DDI_CLK_SEL(pll, phy)	(_DG1_DPCLKA_PLL_IDX(pll) << DG1_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
+#define   DG1_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK(phy)	(0x3 << DG1_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
+
+/* ADLS Clocks */
+#define _ADLS_DPCLKA_CFGCR0			0x164280
+#define _ADLS_DPCLKA_CFGCR1			0x1642BC
+#define ADLS_DPCLKA_CFGCR(phy)			_MMIO_PHY((phy) / 3, \
+							  _ADLS_DPCLKA_CFGCR0, \
+							  _ADLS_DPCLKA_CFGCR1)
+#define  ADLS_DPCLKA_CFGCR_DDI_SHIFT(phy)		(((phy) % 3) * 2)
+/* ADLS DPCLKA_CFGCR0 DDI mask */
+#define  ADLS_DPCLKA_DDII_SEL_MASK			REG_GENMASK(5, 4)
+#define  ADLS_DPCLKA_DDIB_SEL_MASK			REG_GENMASK(3, 2)
+#define  ADLS_DPCLKA_DDIA_SEL_MASK			REG_GENMASK(1, 0)
+/* ADLS DPCLKA_CFGCR1 DDI mask */
+#define  ADLS_DPCLKA_DDIK_SEL_MASK			REG_GENMASK(3, 2)
+#define  ADLS_DPCLKA_DDIJ_SEL_MASK			REG_GENMASK(1, 0)
+#define  ADLS_DPCLKA_CFGCR_DDI_CLK_SEL_MASK(phy)	_PICK((phy), \
+							ADLS_DPCLKA_DDIA_SEL_MASK, \
+							ADLS_DPCLKA_DDIB_SEL_MASK, \
+							ADLS_DPCLKA_DDII_SEL_MASK, \
+							ADLS_DPCLKA_DDIJ_SEL_MASK, \
+							ADLS_DPCLKA_DDIK_SEL_MASK)
+
+/* ICL PLL */
+#define _DPLL0_ENABLE		0x46010
+#define _DPLL1_ENABLE		0x46014
+#define _ADLS_DPLL2_ENABLE	0x46018
+#define _ADLS_DPLL3_ENABLE	0x46030
+#define   PLL_ENABLE		REG_BIT(31)
+#define   PLL_LOCK		REG_BIT(30)
+#define   PLL_POWER_ENABLE	REG_BIT(27)
+#define   PLL_POWER_STATE	REG_BIT(26)
+#define ICL_DPLL_ENABLE(pll)	_MMIO(_PICK_EVEN_2RANGES(pll, 3,			\
+							_DPLL0_ENABLE, _DPLL1_ENABLE,	\
+							_ADLS_DPLL3_ENABLE, _ADLS_DPLL3_ENABLE))
+
+#define DG2_PLL_ENABLE(pll)	_MMIO(_PICK_EVEN_2RANGES(pll, 3,			\
+							_DPLL0_ENABLE, _DPLL1_ENABLE,	\
+							_DG2_PLL3_ENABLE, _DG2_PLL3_ENABLE))
+
+#define TBT_PLL_ENABLE		_MMIO(0x46020)
+
+#define _MG_PLL1_ENABLE		0x46030
+#define _MG_PLL2_ENABLE		0x46034
+#define _MG_PLL3_ENABLE		0x46038
+#define _MG_PLL4_ENABLE		0x4603C
+/* Bits are the same as _DPLL0_ENABLE */
+#define MG_PLL_ENABLE(tc_port)	_MMIO_PORT((tc_port), _MG_PLL1_ENABLE, \
+					   _MG_PLL2_ENABLE)
+
+/* DG1 PLL */
+#define DG1_DPLL_ENABLE(pll)    _MMIO(_PICK_EVEN_2RANGES(pll, 2,			\
+							_DPLL0_ENABLE, _DPLL1_ENABLE,	\
+							_MG_PLL1_ENABLE, _MG_PLL2_ENABLE))
+
+/* ADL-P Type C PLL */
+#define PORTTC1_PLL_ENABLE	0x46038
+#define PORTTC2_PLL_ENABLE	0x46040
+#define ADLP_PORTTC_PLL_ENABLE(tc_port)		_MMIO_PORT((tc_port), \
+							    PORTTC1_PLL_ENABLE, \
+							    PORTTC2_PLL_ENABLE)
+
+#define _ICL_DPLL0_CFGCR0		0x164000
+#define _ICL_DPLL1_CFGCR0		0x164080
+#define ICL_DPLL_CFGCR0(pll)		_MMIO_PLL(pll, _ICL_DPLL0_CFGCR0, \
+						  _ICL_DPLL1_CFGCR0)
+#define   DPLL_CFGCR0_HDMI_MODE		(1 << 30)
+#define   DPLL_CFGCR0_SSC_ENABLE	(1 << 29)
+#define   DPLL_CFGCR0_SSC_ENABLE_ICL	(1 << 25)
+#define   DPLL_CFGCR0_LINK_RATE_MASK	(0xf << 25)
+#define   DPLL_CFGCR0_LINK_RATE_2700	(0 << 25)
+#define   DPLL_CFGCR0_LINK_RATE_1350	(1 << 25)
+#define   DPLL_CFGCR0_LINK_RATE_810	(2 << 25)
+#define   DPLL_CFGCR0_LINK_RATE_1620	(3 << 25)
+#define   DPLL_CFGCR0_LINK_RATE_1080	(4 << 25)
+#define   DPLL_CFGCR0_LINK_RATE_2160	(5 << 25)
+#define   DPLL_CFGCR0_LINK_RATE_3240	(6 << 25)
+#define   DPLL_CFGCR0_LINK_RATE_4050	(7 << 25)
+#define   DPLL_CFGCR0_DCO_FRACTION_MASK	(0x7fff << 10)
+#define   DPLL_CFGCR0_DCO_FRACTION_SHIFT	(10)
+#define   DPLL_CFGCR0_DCO_FRACTION(x)	((x) << 10)
+#define   DPLL_CFGCR0_DCO_INTEGER_MASK	(0x3ff)
+
+#define _ICL_DPLL0_CFGCR1		0x164004
+#define _ICL_DPLL1_CFGCR1		0x164084
+#define ICL_DPLL_CFGCR1(pll)		_MMIO_PLL(pll, _ICL_DPLL0_CFGCR1, \
+						  _ICL_DPLL1_CFGCR1)
+#define   DPLL_CFGCR1_QDIV_RATIO_MASK	(0xff << 10)
+#define   DPLL_CFGCR1_QDIV_RATIO_SHIFT	(10)
+#define   DPLL_CFGCR1_QDIV_RATIO(x)	((x) << 10)
+#define   DPLL_CFGCR1_QDIV_MODE_SHIFT	(9)
+#define   DPLL_CFGCR1_QDIV_MODE(x)	((x) << 9)
+#define   DPLL_CFGCR1_KDIV_MASK		(7 << 6)
+#define   DPLL_CFGCR1_KDIV_SHIFT		(6)
+#define   DPLL_CFGCR1_KDIV(x)		((x) << 6)
+#define   DPLL_CFGCR1_KDIV_1		(1 << 6)
+#define   DPLL_CFGCR1_KDIV_2		(2 << 6)
+#define   DPLL_CFGCR1_KDIV_3		(4 << 6)
+#define   DPLL_CFGCR1_PDIV_MASK		(0xf << 2)
+#define   DPLL_CFGCR1_PDIV_SHIFT		(2)
+#define   DPLL_CFGCR1_PDIV(x)		((x) << 2)
+#define   DPLL_CFGCR1_PDIV_2		(1 << 2)
+#define   DPLL_CFGCR1_PDIV_3		(2 << 2)
+#define   DPLL_CFGCR1_PDIV_5		(4 << 2)
+#define   DPLL_CFGCR1_PDIV_7		(8 << 2)
+#define   DPLL_CFGCR1_CENTRAL_FREQ	(3 << 0)
+#define   DPLL_CFGCR1_CENTRAL_FREQ_8400	(3 << 0)
+#define   TGL_DPLL_CFGCR1_CFSELOVRD_NORMAL_XTAL	(0 << 0)
+
+#define _TGL_DPLL0_CFGCR0		0x164284
+#define _TGL_DPLL1_CFGCR0		0x16428C
+#define _TGL_TBTPLL_CFGCR0		0x16429C
+#define TGL_DPLL_CFGCR0(pll)		_MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
+					      _TGL_DPLL0_CFGCR0, _TGL_DPLL1_CFGCR0,	\
+					      _TGL_TBTPLL_CFGCR0, _TGL_TBTPLL_CFGCR0))
+#define RKL_DPLL_CFGCR0(pll)		_MMIO_PLL(pll, _TGL_DPLL0_CFGCR0, \
+						  _TGL_DPLL1_CFGCR0)
+
+#define _TGL_DPLL0_DIV0					0x164B00
+#define _TGL_DPLL1_DIV0					0x164C00
+#define TGL_DPLL0_DIV0(pll)				_MMIO_PLL(pll, _TGL_DPLL0_DIV0, _TGL_DPLL1_DIV0)
+#define   TGL_DPLL0_DIV0_AFC_STARTUP_MASK		REG_GENMASK(27, 25)
+#define   TGL_DPLL0_DIV0_AFC_STARTUP(val)		REG_FIELD_PREP(TGL_DPLL0_DIV0_AFC_STARTUP_MASK, (val))
+
+#define _TGL_DPLL0_CFGCR1		0x164288
+#define _TGL_DPLL1_CFGCR1		0x164290
+#define _TGL_TBTPLL_CFGCR1		0x1642A0
+#define TGL_DPLL_CFGCR1(pll)		_MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
+					      _TGL_DPLL0_CFGCR1, _TGL_DPLL1_CFGCR1,	\
+					      _TGL_TBTPLL_CFGCR1, _TGL_TBTPLL_CFGCR1))
+#define RKL_DPLL_CFGCR1(pll)		_MMIO_PLL(pll, _TGL_DPLL0_CFGCR1, \
+						  _TGL_DPLL1_CFGCR1)
+
+#define _DG1_DPLL2_CFGCR0		0x16C284
+#define _DG1_DPLL3_CFGCR0		0x16C28C
+#define DG1_DPLL_CFGCR0(pll)		_MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
+					      _TGL_DPLL0_CFGCR0, _TGL_DPLL1_CFGCR0,	\
+					      _DG1_DPLL2_CFGCR0, _DG1_DPLL3_CFGCR0))
+
+#define _DG1_DPLL2_CFGCR1               0x16C288
+#define _DG1_DPLL3_CFGCR1               0x16C290
+#define DG1_DPLL_CFGCR1(pll)            _MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
+					      _TGL_DPLL0_CFGCR1, _TGL_DPLL1_CFGCR1,	\
+					      _DG1_DPLL2_CFGCR1, _DG1_DPLL3_CFGCR1))
+
+/* For ADL-S DPLL4_CFGCR0/1 are used to control DPLL2 */
+#define _ADLS_DPLL4_CFGCR0		0x164294
+#define _ADLS_DPLL3_CFGCR0		0x1642C0
+#define ADLS_DPLL_CFGCR0(pll)		_MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
+					      _TGL_DPLL0_CFGCR0, _TGL_DPLL1_CFGCR0,	\
+					      _ADLS_DPLL4_CFGCR0, _ADLS_DPLL3_CFGCR0))
+
+#define _ADLS_DPLL4_CFGCR1		0x164298
+#define _ADLS_DPLL3_CFGCR1		0x1642C4
+#define ADLS_DPLL_CFGCR1(pll)		_MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
+					      _TGL_DPLL0_CFGCR1, _TGL_DPLL1_CFGCR1,	\
+					      _ADLS_DPLL4_CFGCR1, _ADLS_DPLL3_CFGCR1))
+
+/* BXT display engine PLL */
+#define BXT_DE_PLL_CTL			_MMIO(0x6d000)
+#define   BXT_DE_PLL_RATIO(x)		(x)	/* {60,65,100} * 19.2MHz */
+#define   BXT_DE_PLL_RATIO_MASK		0xff
+
+#define BXT_DE_PLL_ENABLE		_MMIO(0x46070)
+#define   BXT_DE_PLL_PLL_ENABLE		(1 << 31)
+#define   BXT_DE_PLL_LOCK		(1 << 30)
+#define   BXT_DE_PLL_FREQ_REQ		(1 << 23)
+#define   BXT_DE_PLL_FREQ_REQ_ACK	(1 << 22)
+#define   ICL_CDCLK_PLL_RATIO(x)	(x)
+#define   ICL_CDCLK_PLL_RATIO_MASK	0xff
+
+/* GEN9 DC */
+#define DC_STATE_EN			_MMIO(0x45504)
+#define  DC_STATE_DISABLE		0
+#define  DC_STATE_EN_DC3CO		REG_BIT(30)
+#define  DC_STATE_DC3CO_STATUS		REG_BIT(29)
+#define  HOLD_PHY_CLKREQ_PG1_LATCH	REG_BIT(21)
+#define  HOLD_PHY_PG1_LATCH		REG_BIT(20)
+#define  DC_STATE_EN_UPTO_DC5		(1 << 0)
+#define  DC_STATE_EN_DC9		(1 << 3)
+#define  DC_STATE_EN_UPTO_DC6		(2 << 0)
+#define  DC_STATE_EN_UPTO_DC5_DC6_MASK   0x3
+
+#define  DC_STATE_DEBUG                  _MMIO(0x45520)
+#define  DC_STATE_DEBUG_MASK_CORES	(1 << 0)
+#define  DC_STATE_DEBUG_MASK_MEMORY_UP	(1 << 1)
+
+#define D_COMP_BDW			_MMIO(0x138144)
+
+/* Pipe WM_LINETIME - watermark line time */
+#define _WM_LINETIME_A		0x45270
+#define _WM_LINETIME_B		0x45274
+#define WM_LINETIME(pipe) _MMIO_PIPE(pipe, _WM_LINETIME_A, _WM_LINETIME_B)
+#define  HSW_LINETIME_MASK	REG_GENMASK(8, 0)
+#define  HSW_LINETIME(x)	REG_FIELD_PREP(HSW_LINETIME_MASK, (x))
+#define  HSW_IPS_LINETIME_MASK	REG_GENMASK(24, 16)
+#define  HSW_IPS_LINETIME(x)	REG_FIELD_PREP(HSW_IPS_LINETIME_MASK, (x))
+
+/* SFUSE_STRAP */
+#define SFUSE_STRAP			_MMIO(0xc2014)
+#define  SFUSE_STRAP_FUSE_LOCK		(1 << 13)
+#define  SFUSE_STRAP_RAW_FREQUENCY	(1 << 8)
+#define  SFUSE_STRAP_DISPLAY_DISABLED	(1 << 7)
+#define  SFUSE_STRAP_CRT_DISABLED	(1 << 6)
+#define  SFUSE_STRAP_DDIF_DETECTED	(1 << 3)
+#define  SFUSE_STRAP_DDIB_DETECTED	(1 << 2)
+#define  SFUSE_STRAP_DDIC_DETECTED	(1 << 1)
+#define  SFUSE_STRAP_DDID_DETECTED	(1 << 0)
+
+/* Gen4+ Timestamp and Pipe Frame time stamp registers */
+#define GEN4_TIMESTAMP		_MMIO(0x2358)
+#define ILK_TIMESTAMP_HI	_MMIO(0x70070)
+#define IVB_TIMESTAMP_CTR	_MMIO(0x44070)
+
+/* g4x+, except vlv/chv! */
+#define _PIPE_FRMTMSTMP_A		0x70048
+#define _PIPE_FRMTMSTMP_B		0x71048
+#define PIPE_FRMTMSTMP(pipe)		\
+	_MMIO_PIPE(pipe, _PIPE_FRMTMSTMP_A, _PIPE_FRMTMSTMP_B)
+
+#define _VLV_PIPE_MSA_MISC_A			0x70048
+#define VLV_PIPE_MSA_MISC(pipe)		\
+			_MMIO_PIPE2(dev_priv, pipe, _VLV_PIPE_MSA_MISC_A)
+#define   VLV_MSA_MISC1_HW_ENABLE			REG_BIT(31)
+#define   VLV_MSA_MISC1_SW_S3D_MASK			REG_GENMASK(2, 0) /* MSA MISC1 3:1 */
+
+#define _ICL_PHY_MISC_A		0x64C00
+#define _ICL_PHY_MISC_B		0x64C04
+#define _DG2_PHY_MISC_TC1	0x64C14 /* TC1="PHY E" but offset as if "PHY F" */
+#define ICL_PHY_MISC(port)	_MMIO_PORT(port, _ICL_PHY_MISC_A, _ICL_PHY_MISC_B)
+#define DG2_PHY_MISC(port)	((port) == PHY_E ? _MMIO(_DG2_PHY_MISC_TC1) : \
+				 ICL_PHY_MISC(port))
+#define  ICL_PHY_MISC_MUX_DDID			(1 << 28)
+#define  ICL_PHY_MISC_DE_IO_COMP_PWR_DOWN	(1 << 23)
+#define  DG2_PHY_DP_TX_ACK_MASK			REG_GENMASK(23, 20)
+
+#define PORT_TX_DFLEXDPSP(fia)			_MMIO_FIA((fia), 0x008A0)
+#define   MODULAR_FIA_MASK			(1 << 4)
+#define   TC_LIVE_STATE_TBT(idx)		(1 << ((idx) * 8 + 6))
+#define   TC_LIVE_STATE_TC(idx)			(1 << ((idx) * 8 + 5))
+#define   DP_LANE_ASSIGNMENT_SHIFT(idx)		((idx) * 8)
+#define   DP_LANE_ASSIGNMENT_MASK(idx)		(0xf << ((idx) * 8))
+#define   DP_LANE_ASSIGNMENT(idx, x)		((x) << ((idx) * 8))
+
+#define PORT_TX_DFLEXDPPMS(fia)			_MMIO_FIA((fia), 0x00890)
+#define   DP_PHY_MODE_STATUS_COMPLETED(idx)	(1 << (idx))
+
+#define PORT_TX_DFLEXDPCSSS(fia)		_MMIO_FIA((fia), 0x00894)
+#define   DP_PHY_MODE_STATUS_NOT_SAFE(idx)	(1 << (idx))
+
+#define PORT_TX_DFLEXPA1(fia)			_MMIO_FIA((fia), 0x00880)
+#define   DP_PIN_ASSIGNMENT_SHIFT(idx)		((idx) * 4)
+#define   DP_PIN_ASSIGNMENT_MASK(idx)		(0xf << ((idx) * 4))
+#define   DP_PIN_ASSIGNMENT(idx, x)		((x) << ((idx) * 4))
+
+#define _TCSS_DDI_STATUS_1			0x161500
+#define _TCSS_DDI_STATUS_2			0x161504
+#define TCSS_DDI_STATUS(tc)			_MMIO(_PICK_EVEN(tc, \
+								 _TCSS_DDI_STATUS_1, \
+								 _TCSS_DDI_STATUS_2))
+#define  TCSS_DDI_STATUS_PIN_ASSIGNMENT_MASK	REG_GENMASK(28, 25)
+#define  TCSS_DDI_STATUS_READY			REG_BIT(2)
+#define  TCSS_DDI_STATUS_HPD_LIVE_STATUS_TBT	REG_BIT(1)
+#define  TCSS_DDI_STATUS_HPD_LIVE_STATUS_ALT	REG_BIT(0)
+
+#define CLKREQ_POLICY			_MMIO(0x101038)
+#define  CLKREQ_POLICY_MEM_UP_OVRD	REG_BIT(1)
+
+#define CLKGATE_DIS_MISC			_MMIO(0x46534)
+#define  CLKGATE_DIS_MISC_DMASC_GATING_DIS	REG_BIT(21)
+
+#define _MTL_CLKGATE_DIS_TRANS_A			0x604E8
+#define _MTL_CLKGATE_DIS_TRANS_B			0x614E8
+#define MTL_CLKGATE_DIS_TRANS(dev_priv, trans)			_MMIO_TRANS2(dev_priv, trans, _MTL_CLKGATE_DIS_TRANS_A)
+#define  MTL_CLKGATE_DIS_TRANS_DMASC_GATING_DIS		REG_BIT(7)
+
+#define MTL_MEM_SS_INFO_QGV_POINT_OFFSET	0x45710
+#define MTL_MEM_SS_INFO_QGV_POINT_LOW(point)	_MMIO(MTL_MEM_SS_INFO_QGV_POINT_OFFSET + (point) * 8)
+#define   MTL_TRCD_MASK			REG_GENMASK(31, 24)
+#define   MTL_TRP_MASK			REG_GENMASK(23, 16)
+#define   MTL_DCLK_MASK			REG_GENMASK(15, 0)
+
+#define MTL_MEM_SS_INFO_QGV_POINT_HIGH(point)	_MMIO(MTL_MEM_SS_INFO_QGV_POINT_OFFSET + (point) * 8 + 4)
+#define   MTL_TRAS_MASK			REG_GENMASK(16, 8)
+#define   MTL_TRDPRE_MASK		REG_GENMASK(7, 0)
+
+
+
+#endif /* __INTEL_DISPLAY_REGS_H__ */
diff --git a/drivers/gpu/drm/i915/display/intel_display_wa.c b/drivers/gpu/drm/i915/display/intel_display_wa.c
index e5a8022db664..864f7f318832 100644
--- a/drivers/gpu/drm/i915/display/intel_display_wa.c
+++ b/drivers/gpu/drm/i915/display/intel_display_wa.c
@@ -6,6 +6,7 @@
 #include "i915_drv.h"
 #include "i915_reg.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_wa.h"
 
 static void gen11_display_wa_apply(struct drm_i915_private *i915)
diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
index 221d3abda791..111d05585d5a 100644
--- a/drivers/gpu/drm/i915/display/intel_dmc.c
+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
@@ -28,6 +28,7 @@
 #include "i915_drv.h"
 #include "i915_reg.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_dmc.h"
 #include "intel_dmc_regs.h"
 #include "intel_step.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dmc_wl.c b/drivers/gpu/drm/i915/display/intel_dmc_wl.c
index 7e2ce0c2f6c3..082cb5597c1a 100644
--- a/drivers/gpu/drm/i915/display/intel_dmc_wl.c
+++ b/drivers/gpu/drm/i915/display/intel_dmc_wl.c
@@ -10,6 +10,7 @@
 #include "i915_drv.h"
 #include "i915_reg.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_dmc_regs.h"
 #include "intel_dmc_wl.h"
 
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index f7bd6946910d..1a8b2410fc10 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -34,7 +34,6 @@
 #include <linux/string_helpers.h>
 #include <linux/timekeeping.h>
 #include <linux/types.h>
-
 #include <asm/byteorder.h>
 
 #include <drm/display/drm_dp_helper.h>
@@ -58,10 +57,12 @@
 #include "intel_combo_phy_regs.h"
 #include "intel_connector.h"
 #include "intel_crtc.h"
+#include "intel_crtc_state_dump.h"
 #include "intel_cx0_phy.h"
 #include "intel_ddi.h"
 #include "intel_de.h"
 #include "intel_display_driver.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dp_aux.h"
@@ -87,12 +88,11 @@
 #include "intel_pfit.h"
 #include "intel_pps.h"
 #include "intel_psr.h"
-#include "intel_runtime_pm.h"
 #include "intel_quirks.h"
+#include "intel_runtime_pm.h"
 #include "intel_tc.h"
 #include "intel_vdsc.h"
 #include "intel_vrr.h"
-#include "intel_crtc_state_dump.h"
 
 /* DP DSC throughput values used for slice count calculations KPixels/s */
 #define DP_DSC_PEAK_PIXEL_RATE			2720000
diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
index 00c493cc8a4b..1b62a3ce79a6 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
@@ -14,6 +14,7 @@
 #include "i915_reg.h"
 #include "intel_ddi.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dp_hdcp.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index ae2db983eff9..218b46fe65d1 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -38,6 +38,7 @@
 #include "intel_ddi.h"
 #include "intel_de.h"
 #include "intel_display_driver.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dp_hdcp.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dp_test.c b/drivers/gpu/drm/i915/display/intel_dp_test.c
index 614b90d6938f..c4c7fd7899a1 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_test.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_test.c
@@ -11,6 +11,7 @@
 #include "i915_reg.h"
 #include "intel_ddi.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dp_link_training.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dpio_phy.c b/drivers/gpu/drm/i915/display/intel_dpio_phy.c
index 5f88702818d3..d0bb5f562f85 100644
--- a/drivers/gpu/drm/i915/display/intel_dpio_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_dpio_phy.c
@@ -28,6 +28,7 @@
 #include "intel_ddi_buf_trans.h"
 #include "intel_de.h"
 #include "intel_display_power_well.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dpio_phy.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dpll.c b/drivers/gpu/drm/i915/display/intel_dpll.c
index 3256b1293f7f..fb2267482e2d 100644
--- a/drivers/gpu/drm/i915/display/intel_dpll.c
+++ b/drivers/gpu/drm/i915/display/intel_dpll.c
@@ -13,6 +13,7 @@
 #include "intel_cx0_phy.h"
 #include "intel_de.h"
 #include "intel_display.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dpio_phy.h"
 #include "intel_dpll.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
index b8fa04d3cd5c..253ded981ca5 100644
--- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
+++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
@@ -28,6 +28,7 @@
 #include "i915_drv.h"
 #include "i915_reg.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dkl_phy.h"
 #include "intel_dkl_phy_regs.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dpt_common.c b/drivers/gpu/drm/i915/display/intel_dpt_common.c
index d2dede0a5229..4e05558d6b64 100644
--- a/drivers/gpu/drm/i915/display/intel_dpt_common.c
+++ b/drivers/gpu/drm/i915/display/intel_dpt_common.c
@@ -6,6 +6,7 @@
 #include "i915_drv.h"
 #include "i915_reg.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dpt_common.h"
 #include "skl_universal_plane_regs.h"
diff --git a/drivers/gpu/drm/i915/display/intel_drrs.c b/drivers/gpu/drm/i915/display/intel_drrs.c
index 0fec01b79b23..b0c1ceb978aa 100644
--- a/drivers/gpu/drm/i915/display/intel_drrs.c
+++ b/drivers/gpu/drm/i915/display/intel_drrs.c
@@ -9,6 +9,7 @@
 #include "i915_reg.h"
 #include "intel_atomic.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_drrs.h"
 #include "intel_frontbuffer.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index 2f2812c23972..bd1bca27403f 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -11,6 +11,7 @@
 #include "i915_reg.h"
 #include "intel_crtc.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dsb.h"
 #include "intel_dsb_buffer.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 7b2ffd14ae6e..1c67bfc9a277 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -31,17 +31,16 @@
 #include <linux/pinctrl/machine.h>
 #include <linux/slab.h>
 #include <linux/string_helpers.h>
-
 #include <linux/unaligned.h>
 
 #include <drm/drm_crtc.h>
 #include <drm/drm_edid.h>
-
 #include <video/mipi_display.h>
 
 #include "i915_drv.h"
 #include "i915_reg.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dsi.h"
 #include "intel_dsi_vbt.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dvo.c b/drivers/gpu/drm/i915/display/intel_dvo.c
index c310698a1a86..a773e4aaaadc 100644
--- a/drivers/gpu/drm/i915/display/intel_dvo.c
+++ b/drivers/gpu/drm/i915/display/intel_dvo.c
@@ -38,6 +38,7 @@
 #include "intel_connector.h"
 #include "intel_de.h"
 #include "intel_display_driver.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dvo.h"
 #include "intel_dvo_dev.h"
diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
index df05904bac8a..09ca2e90f478 100644
--- a/drivers/gpu/drm/i915/display/intel_fbc.c
+++ b/drivers/gpu/drm/i915/display/intel_fbc.c
@@ -45,7 +45,9 @@
 #include <drm/drm_fourcc.h>
 
 #include "gem/i915_gem_stolen.h"
+
 #include "gt/intel_gt_types.h"
+
 #include "i915_drv.h"
 #include "i915_reg.h"
 #include "i915_utils.h"
@@ -55,6 +57,7 @@
 #include "intel_cdclk.h"
 #include "intel_de.h"
 #include "intel_display_device.h"
+#include "intel_display_regs.h"
 #include "intel_display_trace.h"
 #include "intel_display_types.h"
 #include "intel_display_wa.h"
diff --git a/drivers/gpu/drm/i915/display/intel_fdi.c b/drivers/gpu/drm/i915/display/intel_fdi.c
index 3e8d6d8af780..be7a696cceda 100644
--- a/drivers/gpu/drm/i915/display/intel_fdi.c
+++ b/drivers/gpu/drm/i915/display/intel_fdi.c
@@ -13,8 +13,9 @@
 #include "intel_crtc.h"
 #include "intel_ddi.h"
 #include "intel_de.h"
-#include "intel_dp.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_dp.h"
 #include "intel_fdi.h"
 #include "intel_fdi_regs.h"
 #include "intel_link_bw.h"
diff --git a/drivers/gpu/drm/i915/display/intel_fifo_underrun.c b/drivers/gpu/drm/i915/display/intel_fifo_underrun.c
index 18fcdbe1248a..35de6975e196 100644
--- a/drivers/gpu/drm/i915/display/intel_fifo_underrun.c
+++ b/drivers/gpu/drm/i915/display/intel_fifo_underrun.c
@@ -29,6 +29,7 @@
 #include "i915_reg.h"
 #include "intel_de.h"
 #include "intel_display_irq.h"
+#include "intel_display_regs.h"
 #include "intel_display_trace.h"
 #include "intel_display_types.h"
 #include "intel_fbc.h"
diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c
index 807cf606e7a8..9260ae584899 100644
--- a/drivers/gpu/drm/i915/display/intel_gmbus.c
+++ b/drivers/gpu/drm/i915/display/intel_gmbus.c
@@ -37,6 +37,7 @@
 #include "i915_irq.h"
 #include "i915_reg.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_gmbus.h"
 #include "intel_gmbus_regs.h"
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
index 7cc0399b2a5d..75ba4ec598cd 100644
--- a/drivers/gpu/drm/i915/display/intel_hdcp.c
+++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
@@ -21,6 +21,7 @@
 #include "intel_de.h"
 #include "intel_display_power.h"
 #include "intel_display_power_well.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_hdcp.h"
 #include "intel_hdcp_gsc.h"
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 3b51238022f4..13965388daa6 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -40,7 +40,6 @@
 #include <drm/drm_edid.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/intel/intel_lpe_audio.h>
-
 #include <media/cec-notifier.h>
 
 #include "g4x_hdmi.h"
@@ -53,6 +52,7 @@
 #include "intel_ddi.h"
 #include "intel_de.h"
 #include "intel_display_driver.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_gmbus.h"
diff --git a/drivers/gpu/drm/i915/display/intel_hotplug_irq.c b/drivers/gpu/drm/i915/display/intel_hotplug_irq.c
index 2137ac7b882a..36e492094fb3 100644
--- a/drivers/gpu/drm/i915/display/intel_hotplug_irq.c
+++ b/drivers/gpu/drm/i915/display/intel_hotplug_irq.c
@@ -7,6 +7,7 @@
 #include "i915_reg.h"
 #include "intel_de.h"
 #include "intel_display_irq.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dp_aux.h"
 #include "intel_gmbus.h"
diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c
index 63c1afa30b05..3e60469687d4 100644
--- a/drivers/gpu/drm/i915/display/intel_lspcon.c
+++ b/drivers/gpu/drm/i915/display/intel_lspcon.c
@@ -31,6 +31,7 @@
 #include "i915_reg.h"
 #include "i915_utils.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_hdmi.h"
diff --git a/drivers/gpu/drm/i915/display/intel_lvds.c b/drivers/gpu/drm/i915/display/intel_lvds.c
index 4b0dce169d4e..8e8f61b2356a 100644
--- a/drivers/gpu/drm/i915/display/intel_lvds.c
+++ b/drivers/gpu/drm/i915/display/intel_lvds.c
@@ -27,12 +27,12 @@
  *      Jesse Barnes <jesse.barnes@intel.com>
  */
 
-#include <acpi/button.h>
 #include <linux/acpi.h>
 #include <linux/dmi.h>
 #include <linux/i2c.h>
 #include <linux/slab.h>
 #include <linux/vga_switcheroo.h>
+#include <acpi/button.h>
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_crtc.h>
@@ -45,6 +45,7 @@
 #include "intel_backlight.h"
 #include "intel_connector.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dpll.h"
 #include "intel_fdi.h"
diff --git a/drivers/gpu/drm/i915/display/intel_modeset_setup.c b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
index 10cdfdad82e4..4b2e08056d76 100644
--- a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
+++ b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
@@ -6,8 +6,8 @@
  * state.
  */
 
-#include <drm/drm_atomic_uapi.h>
 #include <drm/drm_atomic_state_helper.h>
+#include <drm/drm_atomic_uapi.h>
 #include <drm/drm_vblank.h>
 
 #include "i915_drv.h"
@@ -23,6 +23,7 @@
 #include "intel_de.h"
 #include "intel_display.h"
 #include "intel_display_power.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dmc.h"
 #include "intel_fifo_underrun.h"
diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c b/drivers/gpu/drm/i915/display/intel_overlay.c
index 4d00db86131b..e41a652a3550 100644
--- a/drivers/gpu/drm/i915/display/intel_overlay.c
+++ b/drivers/gpu/drm/i915/display/intel_overlay.c
@@ -31,6 +31,7 @@
 #include "gem/i915_gem_internal.h"
 #include "gem/i915_gem_object_frontbuffer.h"
 #include "gem/i915_gem_pm.h"
+
 #include "gt/intel_gpu_commands.h"
 #include "gt/intel_ring.h"
 
@@ -38,6 +39,7 @@
 #include "i915_reg.h"
 #include "intel_color_regs.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_frontbuffer.h"
 #include "intel_overlay.h"
diff --git a/drivers/gpu/drm/i915/display/intel_pch_display.c b/drivers/gpu/drm/i915/display/intel_pch_display.c
index 8fa5a6334d10..4baddf00f818 100644
--- a/drivers/gpu/drm/i915/display/intel_pch_display.c
+++ b/drivers/gpu/drm/i915/display/intel_pch_display.c
@@ -9,6 +9,7 @@
 #include "intel_crt.h"
 #include "intel_crt_regs.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dpll.h"
 #include "intel_fdi.h"
diff --git a/drivers/gpu/drm/i915/display/intel_pch_refclk.c b/drivers/gpu/drm/i915/display/intel_pch_refclk.c
index 71471c1d7dc9..80bc09fbd5e8 100644
--- a/drivers/gpu/drm/i915/display/intel_pch_refclk.c
+++ b/drivers/gpu/drm/i915/display/intel_pch_refclk.c
@@ -6,6 +6,7 @@
 #include "i915_drv.h"
 #include "i915_reg.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_panel.h"
 #include "intel_pch_refclk.h"
diff --git a/drivers/gpu/drm/i915/display/intel_pfit.c b/drivers/gpu/drm/i915/display/intel_pfit.c
index 4ee03d9d14ad..dbd51b25833c 100644
--- a/drivers/gpu/drm/i915/display/intel_pfit.c
+++ b/drivers/gpu/drm/i915/display/intel_pfit.c
@@ -7,6 +7,7 @@
 #include "i915_utils.h"
 #include "intel_display_core.h"
 #include "intel_display_driver.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_lvds_regs.h"
 #include "intel_pfit.h"
diff --git a/drivers/gpu/drm/i915/display/intel_pipe_crc.c b/drivers/gpu/drm/i915/display/intel_pipe_crc.c
index 90efc6f64e52..1f7867a4e90e 100644
--- a/drivers/gpu/drm/i915/display/intel_pipe_crc.c
+++ b/drivers/gpu/drm/i915/display/intel_pipe_crc.c
@@ -34,6 +34,7 @@
 #include "intel_atomic.h"
 #include "intel_de.h"
 #include "intel_display_irq.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_pipe_crc.h"
 #include "intel_pipe_crc_regs.h"
diff --git a/drivers/gpu/drm/i915/display/intel_pmdemand.c b/drivers/gpu/drm/i915/display/intel_pmdemand.c
index 63301a01906c..3e95b53dca3d 100644
--- a/drivers/gpu/drm/i915/display/intel_pmdemand.c
+++ b/drivers/gpu/drm/i915/display/intel_pmdemand.c
@@ -11,6 +11,7 @@
 #include "intel_bw.h"
 #include "intel_cdclk.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_trace.h"
 #include "intel_pmdemand.h"
 #include "intel_step.h"
diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c
index c0f65749a3f6..3244ce070d68 100644
--- a/drivers/gpu/drm/i915/display/intel_pps.c
+++ b/drivers/gpu/drm/i915/display/intel_pps.c
@@ -10,6 +10,7 @@
 #include "i915_reg.h"
 #include "intel_de.h"
 #include "intel_display_power_well.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dpio_phy.h"
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 861e50ceef85..17cfba1fcb95 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -36,6 +36,7 @@
 #include "intel_ddi.h"
 #include "intel_de.h"
 #include "intel_display_irq.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dp_aux.h"
diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
index ca8aeb17c909..c34330f8de89 100644
--- a/drivers/gpu/drm/i915/display/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
@@ -46,6 +46,7 @@
 #include "intel_crtc.h"
 #include "intel_de.h"
 #include "intel_display_driver.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_fdi.h"
 #include "intel_fifo_underrun.h"
diff --git a/drivers/gpu/drm/i915/display/intel_snps_phy.c b/drivers/gpu/drm/i915/display/intel_snps_phy.c
index 353221d3e29f..9db02bb8cea7 100644
--- a/drivers/gpu/drm/i915/display/intel_snps_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_snps_phy.c
@@ -10,6 +10,7 @@
 #include "intel_ddi.h"
 #include "intel_ddi_buf_trans.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_snps_hdmi_pll.h"
 #include "intel_snps_phy.h"
diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c
index 13811244c82b..50ef28ce2d7b 100644
--- a/drivers/gpu/drm/i915/display/intel_tc.c
+++ b/drivers/gpu/drm/i915/display/intel_tc.c
@@ -12,6 +12,7 @@
 #include "intel_display.h"
 #include "intel_display_driver.h"
 #include "intel_display_power_map.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dkl_phy_regs.h"
 #include "intel_dp.h"
diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c b/drivers/gpu/drm/i915/display/intel_vblank.c
index 4efd4f7d497a..ab548ddfd178 100644
--- a/drivers/gpu/drm/i915/display/intel_vblank.c
+++ b/drivers/gpu/drm/i915/display/intel_vblank.c
@@ -10,6 +10,7 @@
 #include "intel_color.h"
 #include "intel_crtc.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_vblank.h"
 #include "intel_vrr.h"
diff --git a/drivers/gpu/drm/i915/display/intel_vga.c b/drivers/gpu/drm/i915/display/intel_vga.c
index fd18dd07ae49..ad47a38c573e 100644
--- a/drivers/gpu/drm/i915/display/intel_vga.c
+++ b/drivers/gpu/drm/i915/display/intel_vga.c
@@ -7,11 +7,13 @@
 #include <linux/vgaarb.h>
 
 #include <video/vga.h>
+
 #include "soc/intel_gmch.h"
 
 #include "i915_drv.h"
 #include "i915_reg.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_vga.h"
 
 static i915_reg_t intel_vga_cntrl_reg(struct intel_display *display)
diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
index adb51609d0a3..06b147324b89 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -6,6 +6,7 @@
 
 #include "i915_reg.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_vrr.h"
diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c
index c8bf6fd92ce8..c8cc3d47ae3d 100644
--- a/drivers/gpu/drm/i915/display/skl_scaler.c
+++ b/drivers/gpu/drm/i915/display/skl_scaler.c
@@ -6,6 +6,7 @@
 #include "i915_drv.h"
 #include "i915_reg.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_trace.h"
 #include "intel_display_types.h"
 #include "intel_fb.h"
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index ee93361bba09..61128152b605 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -8,12 +8,15 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_fourcc.h>
 
+#include "pxp/intel_pxp.h"
+
 #include "i915_drv.h"
 #include "i915_reg.h"
 #include "intel_atomic_plane.h"
 #include "intel_bo.h"
 #include "intel_de.h"
 #include "intel_display_irq.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dpt.h"
 #include "intel_fb.h"
@@ -25,7 +28,6 @@
 #include "skl_universal_plane.h"
 #include "skl_universal_plane_regs.h"
 #include "skl_watermark.h"
-#include "pxp/intel_pxp.h"
 
 static const u32 skl_plane_formats[] = {
 	DRM_FORMAT_C8,
diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i915/display/skl_watermark.c
index 45fe4aaeb450..2b50496afad2 100644
--- a/drivers/gpu/drm/i915/display/skl_watermark.c
+++ b/drivers/gpu/drm/i915/display/skl_watermark.c
@@ -19,6 +19,7 @@
 #include "intel_de.h"
 #include "intel_display.h"
 #include "intel_display_power.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_fb.h"
 #include "intel_fixed.h"
diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c
index 14973e9cb899..aa06b4d40426 100644
--- a/drivers/gpu/drm/i915/display/vlv_dsi.c
+++ b/drivers/gpu/drm/i915/display/vlv_dsi.c
@@ -39,6 +39,7 @@
 #include "intel_connector.h"
 #include "intel_crtc.h"
 #include "intel_de.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_dsi.h"
 #include "intel_dsi_vbt.h"
diff --git a/drivers/gpu/drm/i915/gvt/display.c b/drivers/gpu/drm/i915/gvt/display.c
index c98dfcc3d0de..617d81f27b36 100644
--- a/drivers/gpu/drm/i915/gvt/display.c
+++ b/drivers/gpu/drm/i915/gvt/display.c
@@ -36,6 +36,7 @@
 
 #include "i915_drv.h"
 #include "i915_reg.h"
+#include "display/intel_display_regs.h"
 #include "gvt.h"
 
 #include "display/bxt_dpio_phy_regs.h"
diff --git a/drivers/gpu/drm/i915/gvt/fb_decoder.c b/drivers/gpu/drm/i915/gvt/fb_decoder.c
index f9f7ef131371..1b009543d9a2 100644
--- a/drivers/gpu/drm/i915/gvt/fb_decoder.c
+++ b/drivers/gpu/drm/i915/gvt/fb_decoder.c
@@ -39,6 +39,7 @@
 #include "i915_drv.h"
 #include "i915_pvinfo.h"
 #include "i915_reg.h"
+#include "display/intel_display_regs.h"
 
 #include "display/i9xx_plane_regs.h"
 #include "display/intel_cursor_regs.h"
diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
index 4efee6797873..cfc867a57244 100644
--- a/drivers/gpu/drm/i915/gvt/handlers.c
+++ b/drivers/gpu/drm/i915/gvt/handlers.c
@@ -40,6 +40,7 @@
 
 #include "i915_drv.h"
 #include "i915_reg.h"
+#include "display/intel_display_regs.h"
 #include "gvt.h"
 #include "i915_pvinfo.h"
 #include "intel_mchbar_regs.h"
diff --git a/drivers/gpu/drm/i915/gvt/interrupt.c b/drivers/gpu/drm/i915/gvt/interrupt.c
index 336d079c4207..a956da68e6bd 100644
--- a/drivers/gpu/drm/i915/gvt/interrupt.c
+++ b/drivers/gpu/drm/i915/gvt/interrupt.c
@@ -33,6 +33,7 @@
 
 #include "i915_drv.h"
 #include "i915_reg.h"
+#include "display/intel_display_regs.h"
 #include "gvt.h"
 #include "trace.h"
 
diff --git a/drivers/gpu/drm/i915/gvt/mmio.c b/drivers/gpu/drm/i915/gvt/mmio.c
index e16e0d4c9534..da1135fa7cda 100644
--- a/drivers/gpu/drm/i915/gvt/mmio.c
+++ b/drivers/gpu/drm/i915/gvt/mmio.c
@@ -36,6 +36,7 @@
 #include <linux/vmalloc.h>
 #include "i915_drv.h"
 #include "i915_reg.h"
+#include "display/intel_display_regs.h"
 #include "gvt.h"
 
 #include "display/bxt_dpio_phy_regs.h"
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 6e80508b544c..8497e64fef1f 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -116,9 +116,6 @@
  *  #define GEN8_BAR                    _MMIO(0xb888)
  */
 
-#define GU_CNTL_PROTECTED		_MMIO(0x10100C)
-#define   DEPRESENT			REG_BIT(9)
-
 #define GU_CNTL				_MMIO(0x101010)
 #define   LMEM_INIT			REG_BIT(7)
 #define   DRIVERFLR			REG_BIT(31)
@@ -187,46 +184,6 @@
 /* DPIO registers */
 #define DPIO_DEVFN			0
 
-#define DPIO_CTL			_MMIO(VLV_DISPLAY_BASE + 0x2110)
-#define  DPIO_MODSEL1			(1 << 3) /* if ref clk b == 27 */
-#define  DPIO_MODSEL0			(1 << 2) /* if ref clk a == 27 */
-#define  DPIO_SFR_BYPASS		(1 << 1)
-#define  DPIO_CMNRST			(1 << 0)
-
-#define BXT_P_CR_GT_DISP_PWRON		_MMIO(0x138090)
-#define  MIPIO_RST_CTRL				(1 << 2)
-
-#define _BXT_PHY_CTL_DDI_A		0x64C00
-#define _BXT_PHY_CTL_DDI_B		0x64C10
-#define _BXT_PHY_CTL_DDI_C		0x64C20
-#define   BXT_PHY_CMNLANE_POWERDOWN_ACK	(1 << 10)
-#define   BXT_PHY_LANE_POWERDOWN_ACK	(1 << 9)
-#define   BXT_PHY_LANE_ENABLED		(1 << 8)
-#define BXT_PHY_CTL(port)		_MMIO_PORT(port, _BXT_PHY_CTL_DDI_A, \
-							 _BXT_PHY_CTL_DDI_B)
-
-#define _PHY_CTL_FAMILY_DDI		0x64C90
-#define _PHY_CTL_FAMILY_EDP		0x64C80
-#define _PHY_CTL_FAMILY_DDI_C		0x64CA0
-#define   COMMON_RESET_DIS		(1 << 31)
-#define BXT_PHY_CTL_FAMILY(phy)							\
-	 _MMIO(_PICK_EVEN_2RANGES(phy, 1,					\
-				  _PHY_CTL_FAMILY_DDI, _PHY_CTL_FAMILY_DDI,	\
-				  _PHY_CTL_FAMILY_EDP, _PHY_CTL_FAMILY_DDI_C))
-
-/* UAIMI scratch pad register 1 */
-#define UAIMI_SPR1			_MMIO(0x4F074)
-/* SKL VccIO mask */
-#define SKL_VCCIO_MASK			0x1
-/* SKL balance leg register */
-#define DISPIO_CR_TX_BMU_CR0		_MMIO(0x6C00C)
-/* I_boost values */
-#define BALANCE_LEG_SHIFT(port)		(8 + 3 * (port))
-#define BALANCE_LEG_MASK(port)		(7 << (8 + 3 * (port)))
-/* Balance leg disable bits */
-#define BALANCE_LEG_DISABLE_SHIFT	23
-#define BALANCE_LEG_DISABLE(port)	(1 << (23 + (port)))
-
 /*
  * Fence registers
  * [0-7]  @ 0x2000 gen2,gen3
@@ -437,10 +394,6 @@
 #define VLV_PCBR	_MMIO(VLV_DISPLAY_BASE + 0x2120)
 #define VLV_PCBR_ADDR_SHIFT	12
 
-#define VLV_IRQ_REGS		I915_IRQ_REGS(VLV_IMR, \
-					      VLV_IER, \
-					      VLV_IIR)
-
 #define   DISPLAY_PLANE_FLIP_PENDING(plane) (1 << (11 - (plane))) /* A and B only */
 #define EIR		_MMIO(0x20b0)
 #define EMR		_MMIO(0x20b4)
@@ -475,23 +428,6 @@
 #define LM_FIFO_WATERMARK   0x0000001F
 #define MI_ARB_STATE	_MMIO(0x20e4) /* 915+ only */
 
-#define _MBUS_ABOX0_CTL			0x45038
-#define _MBUS_ABOX1_CTL			0x45048
-#define _MBUS_ABOX2_CTL			0x4504C
-#define MBUS_ABOX_CTL(x)							\
-	_MMIO(_PICK_EVEN_2RANGES(x, 2,						\
-				 _MBUS_ABOX0_CTL, _MBUS_ABOX1_CTL,		\
-				 _MBUS_ABOX2_CTL, _MBUS_ABOX2_CTL))
-
-#define MBUS_ABOX_BW_CREDIT_MASK	(3 << 20)
-#define MBUS_ABOX_BW_CREDIT(x)		((x) << 20)
-#define MBUS_ABOX_B_CREDIT_MASK		(0xF << 16)
-#define MBUS_ABOX_B_CREDIT(x)		((x) << 16)
-#define MBUS_ABOX_BT_CREDIT_POOL2_MASK	(0x1F << 8)
-#define MBUS_ABOX_BT_CREDIT_POOL2(x)	((x) << 8)
-#define MBUS_ABOX_BT_CREDIT_POOL1_MASK	(0x1F << 0)
-#define MBUS_ABOX_BT_CREDIT_POOL1(x)	((x) << 0)
-
 /*
  * Make render/texture TLB fetches lower priority than associated data
  * fetches. This is not turned on by default.
@@ -666,158 +602,6 @@
 #define   IVB_SPR_STRETCH_MAX_X2	REG_FIELD_PREP(IVB_SPR_STRETCH_MAX_MASK, 2)
 #define   IVB_SPR_STRETCH_MAX_X1	REG_FIELD_PREP(IVB_SPR_STRETCH_MAX_MASK, 3)
 
-#define IPS_CTL		_MMIO(0x43408)
-#define   IPS_ENABLE		REG_BIT(31)
-#define   IPS_FALSE_COLOR	REG_BIT(4)
-
-/*
- * Clock control & power management
- */
-#define _DPLL_A			0x6014
-#define _DPLL_B			0x6018
-#define _CHV_DPLL_C		0x6030
-#define DPLL(dev_priv, pipe)		_MMIO_BASE_PIPE3(DISPLAY_MMIO_BASE(dev_priv), \
-						 (pipe), _DPLL_A, _DPLL_B, _CHV_DPLL_C)
-
-#define VGA0	_MMIO(0x6000)
-#define VGA1	_MMIO(0x6004)
-#define VGA_PD	_MMIO(0x6010)
-#define   VGA0_PD_P2_DIV_4	(1 << 7)
-#define   VGA0_PD_P1_DIV_2	(1 << 5)
-#define   VGA0_PD_P1_SHIFT	0
-#define   VGA0_PD_P1_MASK	(0x1f << 0)
-#define   VGA1_PD_P2_DIV_4	(1 << 15)
-#define   VGA1_PD_P1_DIV_2	(1 << 13)
-#define   VGA1_PD_P1_SHIFT	8
-#define   VGA1_PD_P1_MASK	(0x1f << 8)
-#define   DPLL_VCO_ENABLE		(1 << 31)
-#define   DPLL_SDVO_HIGH_SPEED		(1 << 30)
-#define   DPLL_DVO_2X_MODE		(1 << 30)
-#define   DPLL_EXT_BUFFER_ENABLE_VLV	(1 << 30)
-#define   DPLL_SYNCLOCK_ENABLE		(1 << 29)
-#define   DPLL_REF_CLK_ENABLE_VLV	(1 << 29)
-#define   DPLL_VGA_MODE_DIS		(1 << 28)
-#define   DPLLB_MODE_DAC_SERIAL		(1 << 26) /* i915 */
-#define   DPLLB_MODE_LVDS		(2 << 26) /* i915 */
-#define   DPLL_MODE_MASK		(3 << 26)
-#define   DPLL_DAC_SERIAL_P2_CLOCK_DIV_10 (0 << 24) /* i915 */
-#define   DPLL_DAC_SERIAL_P2_CLOCK_DIV_5 (1 << 24) /* i915 */
-#define   DPLLB_LVDS_P2_CLOCK_DIV_14	(0 << 24) /* i915 */
-#define   DPLLB_LVDS_P2_CLOCK_DIV_7	(1 << 24) /* i915 */
-#define   DPLL_P2_CLOCK_DIV_MASK	0x03000000 /* i915 */
-#define   DPLL_FPA01_P1_POST_DIV_MASK	0x00ff0000 /* i915 */
-#define   DPLL_FPA01_P1_POST_DIV_MASK_PINEVIEW	0x00ff8000 /* Pineview */
-#define   DPLL_LOCK_VLV			(1 << 15)
-#define   DPLL_INTEGRATED_CRI_CLK_VLV	(1 << 14)
-#define   DPLL_INTEGRATED_REF_CLK_VLV	(1 << 13)
-#define   DPLL_SSC_REF_CLK_CHV		(1 << 13)
-#define   DPLL_PORTC_READY_MASK		(0xf << 4)
-#define   DPLL_PORTB_READY_MASK		(0xf)
-
-#define   DPLL_FPA01_P1_POST_DIV_MASK_I830	0x001f0000
-
-/* Additional CHV pll/phy registers */
-#define DPIO_PHY_STATUS			_MMIO(VLV_DISPLAY_BASE + 0x6240)
-#define   DPLL_PORTD_READY_MASK		(0xf)
-#define DISPLAY_PHY_CONTROL _MMIO(VLV_DISPLAY_BASE + 0x60100)
-#define   PHY_CH_POWER_DOWN_OVRD_EN(phy, ch)	(1 << (2 * (phy) + (ch) + 27))
-#define   PHY_LDO_DELAY_0NS			0x0
-#define   PHY_LDO_DELAY_200NS			0x1
-#define   PHY_LDO_DELAY_600NS			0x2
-#define   PHY_LDO_SEQ_DELAY(delay, phy)		((delay) << (2 * (phy) + 23))
-#define   PHY_CH_POWER_DOWN_OVRD(mask, phy, ch)	((mask) << (8 * (phy) + 4 * (ch) + 11))
-#define   PHY_CH_SU_PSR				0x1
-#define   PHY_CH_DEEP_PSR			0x7
-#define   PHY_CH_POWER_MODE(mode, phy, ch)	((mode) << (6 * (phy) + 3 * (ch) + 2))
-#define   PHY_COM_LANE_RESET_DEASSERT(phy)	(1 << (phy))
-#define DISPLAY_PHY_STATUS _MMIO(VLV_DISPLAY_BASE + 0x60104)
-#define   PHY_POWERGOOD(phy)	(((phy) == DPIO_PHY0) ? (1 << 31) : (1 << 30))
-#define   PHY_STATUS_CMN_LDO(phy, ch)                   (1 << (6 - (6 * (phy) + 3 * (ch))))
-#define   PHY_STATUS_SPLINE_LDO(phy, ch, spline)        (1 << (8 - (6 * (phy) + 3 * (ch) + (spline))))
-
-/*
- * The i830 generation, in LVDS mode, defines P1 as the bit number set within
- * this field (only one bit may be set).
- */
-#define   DPLL_FPA01_P1_POST_DIV_MASK_I830_LVDS	0x003f0000
-#define   DPLL_FPA01_P1_POST_DIV_SHIFT	16
-#define   DPLL_FPA01_P1_POST_DIV_SHIFT_PINEVIEW 15
-/* i830, required in DVO non-gang */
-#define   PLL_P2_DIVIDE_BY_4		(1 << 23)
-#define   PLL_P1_DIVIDE_BY_TWO		(1 << 21) /* i830 */
-#define   PLL_REF_INPUT_DREFCLK		(0 << 13)
-#define   PLL_REF_INPUT_TVCLKINA	(1 << 13) /* i830 */
-#define   PLL_REF_INPUT_TVCLKINBC	(2 << 13) /* SDVO TVCLKIN */
-#define   PLLB_REF_INPUT_SPREADSPECTRUMIN (3 << 13)
-#define   PLL_REF_INPUT_MASK		(3 << 13)
-#define   PLL_LOAD_PULSE_PHASE_SHIFT		9
-/* Ironlake */
-# define PLL_REF_SDVO_HDMI_MULTIPLIER_SHIFT     9
-# define PLL_REF_SDVO_HDMI_MULTIPLIER_MASK      (7 << 9)
-# define PLL_REF_SDVO_HDMI_MULTIPLIER(x)	(((x) - 1) << 9)
-# define DPLL_FPA1_P1_POST_DIV_SHIFT            0
-# define DPLL_FPA1_P1_POST_DIV_MASK             0xff
-
-/*
- * Parallel to Serial Load Pulse phase selection.
- * Selects the phase for the 10X DPLL clock for the PCIe
- * digital display port. The range is 4 to 13; 10 or more
- * is just a flip delay. The default is 6
- */
-#define   PLL_LOAD_PULSE_PHASE_MASK		(0xf << PLL_LOAD_PULSE_PHASE_SHIFT)
-#define   DISPLAY_RATE_SELECT_FPA1		(1 << 8)
-/*
- * SDVO multiplier for 945G/GM. Not used on 965.
- */
-#define   SDVO_MULTIPLIER_MASK			0x000000ff
-#define   SDVO_MULTIPLIER_SHIFT_HIRES		4
-#define   SDVO_MULTIPLIER_SHIFT_VGA		0
-
-#define _DPLL_A_MD		0x601c
-#define _DPLL_B_MD		0x6020
-#define _CHV_DPLL_C_MD		0x603c
-#define DPLL_MD(dev_priv, pipe)		_MMIO_BASE_PIPE3(DISPLAY_MMIO_BASE(dev_priv), \
-						 (pipe), _DPLL_A_MD, _DPLL_B_MD, _CHV_DPLL_C_MD)
-
-/*
- * UDI pixel divider, controlling how many pixels are stuffed into a packet.
- *
- * Value is pixels minus 1.  Must be set to 1 pixel for SDVO.
- */
-#define   DPLL_MD_UDI_DIVIDER_MASK		0x3f000000
-#define   DPLL_MD_UDI_DIVIDER_SHIFT		24
-/* UDI pixel divider for VGA, same as DPLL_MD_UDI_DIVIDER_MASK. */
-#define   DPLL_MD_VGA_UDI_DIVIDER_MASK		0x003f0000
-#define   DPLL_MD_VGA_UDI_DIVIDER_SHIFT		16
-/*
- * SDVO/UDI pixel multiplier.
- *
- * SDVO requires that the bus clock rate be between 1 and 2 Ghz, and the bus
- * clock rate is 10 times the DPLL clock.  At low resolution/refresh rate
- * modes, the bus rate would be below the limits, so SDVO allows for stuffing
- * dummy bytes in the datastream at an increased clock rate, with both sides of
- * the link knowing how many bytes are fill.
- *
- * So, for a mode with a dotclock of 65Mhz, we would want to double the clock
- * rate to 130Mhz to get a bus rate of 1.30Ghz.  The DPLL clock rate would be
- * set to 130Mhz, and the SDVO multiplier set to 2x in this register and
- * through an SDVO command.
- *
- * This register field has values of multiplication factor minus 1, with
- * a maximum multiplier of 5 for SDVO.
- */
-#define   DPLL_MD_UDI_MULTIPLIER_MASK		0x00003f00
-#define   DPLL_MD_UDI_MULTIPLIER_SHIFT		8
-/*
- * SDVO/UDI pixel multiplier for VGA, same as DPLL_MD_UDI_MULTIPLIER_MASK.
- * This best be set to the default value (3) or the CRT won't work. No,
- * I don't entirely understand what this does...
- */
-#define   DPLL_MD_VGA_UDI_MULTIPLIER_MASK	0x0000003f
-#define   DPLL_MD_VGA_UDI_MULTIPLIER_SHIFT	0
-
-#define RAWCLK_FREQ_VLV		_MMIO(VLV_DISPLAY_BASE + 0x6024)
-
 #define _FPA0	0x6040
 #define _FPA1	0x6044
 #define _FPB0	0x6048
@@ -963,27 +747,11 @@
 #define RAMCLK_GATE_D		_MMIO(0x6210)		/* CRL only */
 #define DEUC			_MMIO(0x6214)          /* CRL only */
 
-#define FW_BLC_SELF_VLV		_MMIO(VLV_DISPLAY_BASE + 0x6500)
-#define  FW_CSPWRDWNEN		(1 << 15)
-
-#define MI_ARB_VLV		_MMIO(VLV_DISPLAY_BASE + 0x6504)
-
 #define CZCLK_CDCLK_FREQ_RATIO	_MMIO(VLV_DISPLAY_BASE + 0x6508)
 #define   CDCLK_FREQ_SHIFT	4
 #define   CDCLK_FREQ_MASK	(0x1f << CDCLK_FREQ_SHIFT)
 #define   CZCLK_FREQ_MASK	0xf
 
-#define GCI_CONTROL		_MMIO(VLV_DISPLAY_BASE + 0x650C)
-#define   PFI_CREDIT_63		(9 << 28)		/* chv only */
-#define   PFI_CREDIT_31		(8 << 28)		/* chv only */
-#define   PFI_CREDIT(x)		(((x) - 8) << 28)	/* 8-15 */
-#define   PFI_CREDIT_RESEND	(1 << 27)
-#define   VGA_FAST_MODE_DISABLE	(1 << 14)
-
-#define GMBUSFREQ_VLV		_MMIO(VLV_DISPLAY_BASE + 0x6510)
-
-#define PEG_BAND_GAP_DATA	_MMIO(0x14d68)
-
 #define BXT_RP_STATE_CAP        _MMIO(0x138170)
 #define GEN9_RP_STATE_LIMITS	_MMIO(0x138148)
 
@@ -1013,19 +781,6 @@
 #define VLV_CLK_CTL2			_MMIO(0x101104)
 #define   CLK_CTL2_CZCOUNT_30NS_SHIFT	28
 
-/*
- * Overlay regs
- */
-#define OVADD			_MMIO(0x30000)
-#define DOVSTA			_MMIO(0x30008)
-#define OC_BUF			(0x3 << 20)
-#define OGAMC5			_MMIO(0x30010)
-#define OGAMC4			_MMIO(0x30014)
-#define OGAMC3			_MMIO(0x30018)
-#define OGAMC2			_MMIO(0x3001c)
-#define OGAMC1			_MMIO(0x30020)
-#define OGAMC0			_MMIO(0x30024)
-
 /*
  * GEN9 clock gating regs
  */
@@ -1040,513 +795,6 @@
 #define   TGL_VRH_GATING_DIS		REG_BIT(31)
 #define   DPT_GATING_DIS		REG_BIT(22)
 
-#define GEN9_CLKGATE_DIS_4		_MMIO(0x4653C)
-#define   BXT_GMBUS_GATING_DIS		(1 << 14)
-
-#define GEN9_CLKGATE_DIS_5		_MMIO(0x46540)
-#define   DPCE_GATING_DIS		REG_BIT(17)
-
-#define _CLKGATE_DIS_PSL_A		0x46520
-#define _CLKGATE_DIS_PSL_B		0x46524
-#define _CLKGATE_DIS_PSL_C		0x46528
-#define   DUPS1_GATING_DIS		(1 << 15)
-#define   DUPS2_GATING_DIS		(1 << 19)
-#define   DUPS3_GATING_DIS		(1 << 23)
-#define   CURSOR_GATING_DIS		REG_BIT(28)
-#define   DPF_GATING_DIS		(1 << 10)
-#define   DPF_RAM_GATING_DIS		(1 << 9)
-#define   DPFR_GATING_DIS		(1 << 8)
-
-#define CLKGATE_DIS_PSL(pipe) \
-	_MMIO_PIPE(pipe, _CLKGATE_DIS_PSL_A, _CLKGATE_DIS_PSL_B)
-
-#define _CLKGATE_DIS_PSL_EXT_A		0x4654C
-#define _CLKGATE_DIS_PSL_EXT_B		0x46550
-#define   PIPEDMC_GATING_DIS		REG_BIT(12)
-
-#define CLKGATE_DIS_PSL_EXT(pipe) \
-	_MMIO_PIPE(pipe, _CLKGATE_DIS_PSL_EXT_A, _CLKGATE_DIS_PSL_EXT_B)
-
-/*
- * Display engine regs
- */
-/* Pipe/transcoder A timing regs */
-#define _TRANS_HTOTAL_A		0x60000
-#define _TRANS_HTOTAL_B		0x61000
-#define TRANS_HTOTAL(dev_priv, trans)	_MMIO_TRANS2(dev_priv, (trans), _TRANS_HTOTAL_A)
-#define   HTOTAL_MASK			REG_GENMASK(31, 16)
-#define   HTOTAL(htotal)		REG_FIELD_PREP(HTOTAL_MASK, (htotal))
-#define   HACTIVE_MASK			REG_GENMASK(15, 0)
-#define   HACTIVE(hdisplay)		REG_FIELD_PREP(HACTIVE_MASK, (hdisplay))
-
-#define _TRANS_HBLANK_A		0x60004
-#define _TRANS_HBLANK_B		0x61004
-#define TRANS_HBLANK(dev_priv, trans)	_MMIO_TRANS2(dev_priv, (trans), _TRANS_HBLANK_A)
-#define   HBLANK_END_MASK		REG_GENMASK(31, 16)
-#define   HBLANK_END(hblank_end)	REG_FIELD_PREP(HBLANK_END_MASK, (hblank_end))
-#define   HBLANK_START_MASK		REG_GENMASK(15, 0)
-#define   HBLANK_START(hblank_start)	REG_FIELD_PREP(HBLANK_START_MASK, (hblank_start))
-
-#define _TRANS_HSYNC_A		0x60008
-#define _TRANS_HSYNC_B		0x61008
-#define TRANS_HSYNC(dev_priv, trans)	_MMIO_TRANS2(dev_priv, (trans), _TRANS_HSYNC_A)
-#define   HSYNC_END_MASK		REG_GENMASK(31, 16)
-#define   HSYNC_END(hsync_end)		REG_FIELD_PREP(HSYNC_END_MASK, (hsync_end))
-#define   HSYNC_START_MASK		REG_GENMASK(15, 0)
-#define   HSYNC_START(hsync_start)	REG_FIELD_PREP(HSYNC_START_MASK, (hsync_start))
-
-#define _TRANS_VTOTAL_A		0x6000c
-#define _TRANS_VTOTAL_B		0x6100c
-#define TRANS_VTOTAL(dev_priv, trans)	_MMIO_TRANS2(dev_priv, (trans), _TRANS_VTOTAL_A)
-#define   VTOTAL_MASK			REG_GENMASK(31, 16)
-#define   VTOTAL(vtotal)		REG_FIELD_PREP(VTOTAL_MASK, (vtotal))
-#define   VACTIVE_MASK			REG_GENMASK(15, 0)
-#define   VACTIVE(vdisplay)		REG_FIELD_PREP(VACTIVE_MASK, (vdisplay))
-
-#define _TRANS_VBLANK_A		0x60010
-#define _TRANS_VBLANK_B		0x61010
-#define TRANS_VBLANK(dev_priv, trans)	_MMIO_TRANS2(dev_priv, (trans), _TRANS_VBLANK_A)
-#define   VBLANK_END_MASK		REG_GENMASK(31, 16)
-#define   VBLANK_END(vblank_end)	REG_FIELD_PREP(VBLANK_END_MASK, (vblank_end))
-#define   VBLANK_START_MASK		REG_GENMASK(15, 0)
-#define   VBLANK_START(vblank_start)	REG_FIELD_PREP(VBLANK_START_MASK, (vblank_start))
-
-#define _TRANS_VSYNC_A		0x60014
-#define _TRANS_VSYNC_B		0x61014
-#define TRANS_VSYNC(dev_priv, trans)	_MMIO_TRANS2(dev_priv, (trans), _TRANS_VSYNC_A)
-#define   VSYNC_END_MASK		REG_GENMASK(31, 16)
-#define   VSYNC_END(vsync_end)		REG_FIELD_PREP(VSYNC_END_MASK, (vsync_end))
-#define   VSYNC_START_MASK		REG_GENMASK(15, 0)
-#define   VSYNC_START(vsync_start)	REG_FIELD_PREP(VSYNC_START_MASK, (vsync_start))
-
-#define _PIPEASRC		0x6001c
-#define _PIPEBSRC		0x6101c
-#define PIPESRC(dev_priv, pipe)		_MMIO_TRANS2(dev_priv, (pipe), _PIPEASRC)
-#define   PIPESRC_WIDTH_MASK	REG_GENMASK(31, 16)
-#define   PIPESRC_WIDTH(w)	REG_FIELD_PREP(PIPESRC_WIDTH_MASK, (w))
-#define   PIPESRC_HEIGHT_MASK	REG_GENMASK(15, 0)
-#define   PIPESRC_HEIGHT(h)	REG_FIELD_PREP(PIPESRC_HEIGHT_MASK, (h))
-
-#define _BCLRPAT_A		0x60020
-#define _BCLRPAT_B		0x61020
-#define BCLRPAT(dev_priv, trans)		_MMIO_TRANS2(dev_priv, (trans), _BCLRPAT_A)
-
-#define _TRANS_VSYNCSHIFT_A	0x60028
-#define _TRANS_VSYNCSHIFT_B	0x61028
-#define TRANS_VSYNCSHIFT(dev_priv, trans)	_MMIO_TRANS2(dev_priv, (trans), _TRANS_VSYNCSHIFT_A)
-
-#define _TRANS_MULT_A		0x6002c
-#define _TRANS_MULT_B		0x6102c
-#define TRANS_MULT(dev_priv, trans)	_MMIO_TRANS2(dev_priv, (trans), _TRANS_MULT_A)
-
-/* Hotplug control (945+ only) */
-#define PORT_HOTPLUG_EN(dev_priv)		_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61110)
-#define   PORTB_HOTPLUG_INT_EN			(1 << 29)
-#define   PORTC_HOTPLUG_INT_EN			(1 << 28)
-#define   PORTD_HOTPLUG_INT_EN			(1 << 27)
-#define   SDVOB_HOTPLUG_INT_EN			(1 << 26)
-#define   SDVOC_HOTPLUG_INT_EN			(1 << 25)
-#define   TV_HOTPLUG_INT_EN			(1 << 18)
-#define   CRT_HOTPLUG_INT_EN			(1 << 9)
-#define HOTPLUG_INT_EN_MASK			(PORTB_HOTPLUG_INT_EN | \
-						 PORTC_HOTPLUG_INT_EN | \
-						 PORTD_HOTPLUG_INT_EN | \
-						 SDVOC_HOTPLUG_INT_EN | \
-						 SDVOB_HOTPLUG_INT_EN | \
-						 CRT_HOTPLUG_INT_EN)
-#define   CRT_HOTPLUG_FORCE_DETECT		(1 << 3)
-#define CRT_HOTPLUG_ACTIVATION_PERIOD_32	(0 << 8)
-/* must use period 64 on GM45 according to docs */
-#define CRT_HOTPLUG_ACTIVATION_PERIOD_64	(1 << 8)
-#define CRT_HOTPLUG_DAC_ON_TIME_2M		(0 << 7)
-#define CRT_HOTPLUG_DAC_ON_TIME_4M		(1 << 7)
-#define CRT_HOTPLUG_VOLTAGE_COMPARE_40		(0 << 5)
-#define CRT_HOTPLUG_VOLTAGE_COMPARE_50		(1 << 5)
-#define CRT_HOTPLUG_VOLTAGE_COMPARE_60		(2 << 5)
-#define CRT_HOTPLUG_VOLTAGE_COMPARE_70		(3 << 5)
-#define CRT_HOTPLUG_VOLTAGE_COMPARE_MASK	(3 << 5)
-#define CRT_HOTPLUG_DETECT_DELAY_1G		(0 << 4)
-#define CRT_HOTPLUG_DETECT_DELAY_2G		(1 << 4)
-#define CRT_HOTPLUG_DETECT_VOLTAGE_325MV	(0 << 2)
-#define CRT_HOTPLUG_DETECT_VOLTAGE_475MV	(1 << 2)
-
-#define PORT_HOTPLUG_STAT(dev_priv)	_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61114)
-/* HDMI/DP bits are g4x+ */
-#define   PORTD_HOTPLUG_LIVE_STATUS_G4X		(1 << 27)
-#define   PORTC_HOTPLUG_LIVE_STATUS_G4X		(1 << 28)
-#define   PORTB_HOTPLUG_LIVE_STATUS_G4X		(1 << 29)
-#define   PORTD_HOTPLUG_INT_STATUS		(3 << 21)
-#define   PORTD_HOTPLUG_INT_LONG_PULSE		(2 << 21)
-#define   PORTD_HOTPLUG_INT_SHORT_PULSE		(1 << 21)
-#define   PORTC_HOTPLUG_INT_STATUS		(3 << 19)
-#define   PORTC_HOTPLUG_INT_LONG_PULSE		(2 << 19)
-#define   PORTC_HOTPLUG_INT_SHORT_PULSE		(1 << 19)
-#define   PORTB_HOTPLUG_INT_STATUS		(3 << 17)
-#define   PORTB_HOTPLUG_INT_LONG_PULSE		(2 << 17)
-#define   PORTB_HOTPLUG_INT_SHORT_PLUSE		(1 << 17)
-/* CRT/TV common between gen3+ */
-#define   CRT_HOTPLUG_INT_STATUS		(1 << 11)
-#define   TV_HOTPLUG_INT_STATUS			(1 << 10)
-#define   CRT_HOTPLUG_MONITOR_MASK		(3 << 8)
-#define   CRT_HOTPLUG_MONITOR_COLOR		(3 << 8)
-#define   CRT_HOTPLUG_MONITOR_MONO		(2 << 8)
-#define   CRT_HOTPLUG_MONITOR_NONE		(0 << 8)
-#define   DP_AUX_CHANNEL_D_INT_STATUS_G4X	(1 << 6)
-#define   DP_AUX_CHANNEL_C_INT_STATUS_G4X	(1 << 5)
-#define   DP_AUX_CHANNEL_B_INT_STATUS_G4X	(1 << 4)
-#define   DP_AUX_CHANNEL_MASK_INT_STATUS_G4X	(7 << 4)
-
-/* SDVO is different across gen3/4 */
-#define   SDVOC_HOTPLUG_INT_STATUS_G4X		(1 << 3)
-#define   SDVOB_HOTPLUG_INT_STATUS_G4X		(1 << 2)
-/*
- * Bspec seems to be seriously misleaded about the SDVO hpd bits on i965g/gm,
- * since reality corrobates that they're the same as on gen3. But keep these
- * bits here (and the comment!) to help any other lost wanderers back onto the
- * right tracks.
- */
-#define   SDVOC_HOTPLUG_INT_STATUS_I965		(3 << 4)
-#define   SDVOB_HOTPLUG_INT_STATUS_I965		(3 << 2)
-#define   SDVOC_HOTPLUG_INT_STATUS_I915		(1 << 7)
-#define   SDVOB_HOTPLUG_INT_STATUS_I915		(1 << 6)
-#define   HOTPLUG_INT_STATUS_G4X		(CRT_HOTPLUG_INT_STATUS | \
-						 SDVOB_HOTPLUG_INT_STATUS_G4X | \
-						 SDVOC_HOTPLUG_INT_STATUS_G4X | \
-						 PORTB_HOTPLUG_INT_STATUS | \
-						 PORTC_HOTPLUG_INT_STATUS | \
-						 PORTD_HOTPLUG_INT_STATUS)
-
-#define HOTPLUG_INT_STATUS_I915			(CRT_HOTPLUG_INT_STATUS | \
-						 SDVOB_HOTPLUG_INT_STATUS_I915 | \
-						 SDVOC_HOTPLUG_INT_STATUS_I915 | \
-						 PORTB_HOTPLUG_INT_STATUS | \
-						 PORTC_HOTPLUG_INT_STATUS | \
-						 PORTD_HOTPLUG_INT_STATUS)
-
-/* SDVO and HDMI port control.
- * The same register may be used for SDVO or HDMI */
-#define _GEN3_SDVOB	0x61140
-#define _GEN3_SDVOC	0x61160
-#define GEN3_SDVOB	_MMIO(_GEN3_SDVOB)
-#define GEN3_SDVOC	_MMIO(_GEN3_SDVOC)
-#define GEN4_HDMIB	GEN3_SDVOB
-#define GEN4_HDMIC	GEN3_SDVOC
-#define VLV_HDMIB	_MMIO(VLV_DISPLAY_BASE + 0x61140)
-#define VLV_HDMIC	_MMIO(VLV_DISPLAY_BASE + 0x61160)
-#define CHV_HDMID	_MMIO(VLV_DISPLAY_BASE + 0x6116C)
-#define PCH_SDVOB	_MMIO(0xe1140)
-#define PCH_HDMIB	PCH_SDVOB
-#define PCH_HDMIC	_MMIO(0xe1150)
-#define PCH_HDMID	_MMIO(0xe1160)
-
-#define PORT_DFT_I9XX				_MMIO(0x61150)
-#define   DC_BALANCE_RESET			(1 << 25)
-#define PORT_DFT2_G4X(dev_priv)		_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61154)
-#define   DC_BALANCE_RESET_VLV			(1 << 31)
-#define   PIPE_SCRAMBLE_RESET_MASK		((1 << 14) | (0x3 << 0))
-#define   PIPE_C_SCRAMBLE_RESET			REG_BIT(14) /* chv */
-#define   PIPE_B_SCRAMBLE_RESET			REG_BIT(1)
-#define   PIPE_A_SCRAMBLE_RESET			REG_BIT(0)
-
-/* Gen 3 SDVO bits: */
-#define   SDVO_ENABLE				(1 << 31)
-#define   SDVO_PIPE_SEL_SHIFT			30
-#define   SDVO_PIPE_SEL_MASK			(1 << 30)
-#define   SDVO_PIPE_SEL(pipe)			((pipe) << 30)
-#define   SDVO_STALL_SELECT			(1 << 29)
-#define   SDVO_INTERRUPT_ENABLE			(1 << 26)
-/*
- * 915G/GM SDVO pixel multiplier.
- * Programmed value is multiplier - 1, up to 5x.
- * \sa DPLL_MD_UDI_MULTIPLIER_MASK
- */
-#define   SDVO_PORT_MULTIPLY_MASK		(7 << 23)
-#define   SDVO_PORT_MULTIPLY_SHIFT		23
-#define   SDVO_PHASE_SELECT_MASK		(15 << 19)
-#define   SDVO_PHASE_SELECT_DEFAULT		(6 << 19)
-#define   SDVO_CLOCK_OUTPUT_INVERT		(1 << 18)
-#define   SDVOC_GANG_MODE			(1 << 16) /* Port C only */
-#define   SDVO_BORDER_ENABLE			(1 << 7) /* SDVO only */
-#define   SDVOB_PCIE_CONCURRENCY		(1 << 3) /* Port B only */
-#define   SDVO_DETECTED				(1 << 2)
-/* Bits to be preserved when writing */
-#define   SDVOB_PRESERVE_MASK ((1 << 17) | (1 << 16) | (1 << 14) | \
-			       SDVO_INTERRUPT_ENABLE)
-#define   SDVOC_PRESERVE_MASK ((1 << 17) | SDVO_INTERRUPT_ENABLE)
-
-/* Gen 4 SDVO/HDMI bits: */
-#define   SDVO_COLOR_FORMAT_8bpc		(0 << 26)
-#define   SDVO_COLOR_FORMAT_MASK		(7 << 26)
-#define   SDVO_ENCODING_SDVO			(0 << 10)
-#define   SDVO_ENCODING_HDMI			(2 << 10)
-#define   HDMI_MODE_SELECT_HDMI			(1 << 9) /* HDMI only */
-#define   HDMI_MODE_SELECT_DVI			(0 << 9) /* HDMI only */
-#define   HDMI_COLOR_RANGE_16_235		(1 << 8) /* HDMI only */
-#define   HDMI_AUDIO_ENABLE			(1 << 6) /* HDMI only */
-/* VSYNC/HSYNC bits new with 965, default is to be set */
-#define   SDVO_VSYNC_ACTIVE_HIGH		(1 << 4)
-#define   SDVO_HSYNC_ACTIVE_HIGH		(1 << 3)
-
-/* Gen 5 (IBX) SDVO/HDMI bits: */
-#define   HDMI_COLOR_FORMAT_12bpc		(3 << 26) /* HDMI only */
-#define   SDVOB_HOTPLUG_ENABLE			(1 << 23) /* SDVO only */
-
-/* Gen 6 (CPT) SDVO/HDMI bits: */
-#define   SDVO_PIPE_SEL_SHIFT_CPT		29
-#define   SDVO_PIPE_SEL_MASK_CPT		(3 << 29)
-#define   SDVO_PIPE_SEL_CPT(pipe)		((pipe) << 29)
-
-/* CHV SDVO/HDMI bits: */
-#define   SDVO_PIPE_SEL_SHIFT_CHV		24
-#define   SDVO_PIPE_SEL_MASK_CHV		(3 << 24)
-#define   SDVO_PIPE_SEL_CHV(pipe)		((pipe) << 24)
-
-/* Video Data Island Packet control */
-#define VIDEO_DIP_DATA		_MMIO(0x61178)
-/* Read the description of VIDEO_DIP_DATA (before Haswell) or VIDEO_DIP_ECC
- * (Haswell and newer) to see which VIDEO_DIP_DATA byte corresponds to each byte
- * of the infoframe structure specified by CEA-861. */
-#define   VIDEO_DIP_DATA_SIZE	32
-#define   VIDEO_DIP_ASYNC_DATA_SIZE	36
-#define   VIDEO_DIP_GMP_DATA_SIZE	36
-#define   VIDEO_DIP_VSC_DATA_SIZE	36
-#define   VIDEO_DIP_PPS_DATA_SIZE	132
-#define VIDEO_DIP_CTL		_MMIO(0x61170)
-/* Pre HSW: */
-#define   VIDEO_DIP_ENABLE		(1 << 31)
-#define   VIDEO_DIP_PORT(port)		((port) << 29)
-#define   VIDEO_DIP_PORT_MASK		(3 << 29)
-#define   VIDEO_DIP_ENABLE_GCP		(1 << 25) /* ilk+ */
-#define   VIDEO_DIP_ENABLE_AVI		(1 << 21)
-#define   VIDEO_DIP_ENABLE_VENDOR	(2 << 21)
-#define   VIDEO_DIP_ENABLE_GAMUT	(4 << 21) /* ilk+ */
-#define   VIDEO_DIP_ENABLE_SPD		(8 << 21)
-#define   VIDEO_DIP_SELECT_AVI		(0 << 19)
-#define   VIDEO_DIP_SELECT_VENDOR	(1 << 19)
-#define   VIDEO_DIP_SELECT_GAMUT	(2 << 19)
-#define   VIDEO_DIP_SELECT_SPD		(3 << 19)
-#define   VIDEO_DIP_SELECT_MASK		(3 << 19)
-#define   VIDEO_DIP_FREQ_ONCE		(0 << 16)
-#define   VIDEO_DIP_FREQ_VSYNC		(1 << 16)
-#define   VIDEO_DIP_FREQ_2VSYNC		(2 << 16)
-#define   VIDEO_DIP_FREQ_MASK		(3 << 16)
-/* HSW and later: */
-#define   VIDEO_DIP_ENABLE_DRM_GLK	(1 << 28)
-#define   PSR_VSC_BIT_7_SET		(1 << 27)
-#define   VSC_SELECT_MASK		(0x3 << 25)
-#define   VSC_SELECT_SHIFT		25
-#define   VSC_DIP_HW_HEA_DATA		(0 << 25)
-#define   VSC_DIP_HW_HEA_SW_DATA	(1 << 25)
-#define   VSC_DIP_HW_DATA_SW_HEA	(2 << 25)
-#define   VSC_DIP_SW_HEA_DATA		(3 << 25)
-#define   VDIP_ENABLE_PPS		(1 << 24)
-#define   VIDEO_DIP_ENABLE_VSC_HSW	(1 << 20)
-#define   VIDEO_DIP_ENABLE_GCP_HSW	(1 << 16)
-#define   VIDEO_DIP_ENABLE_AVI_HSW	(1 << 12)
-#define   VIDEO_DIP_ENABLE_VS_HSW	(1 << 8)
-#define   VIDEO_DIP_ENABLE_GMP_HSW	(1 << 4)
-#define   VIDEO_DIP_ENABLE_SPD_HSW	(1 << 0)
-/* ADL and later: */
-#define   VIDEO_DIP_ENABLE_AS_ADL	REG_BIT(23)
-
-/* Panel fitting */
-#define PFIT_CONTROL(dev_priv)	_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61230)
-#define   PFIT_ENABLE			REG_BIT(31)
-#define   PFIT_PIPE_MASK		REG_GENMASK(30, 29) /* 965+ */
-#define   PFIT_PIPE(pipe)		REG_FIELD_PREP(PFIT_PIPE_MASK, (pipe))
-#define   PFIT_SCALING_MASK		REG_GENMASK(28, 26) /* 965+ */
-#define   PFIT_SCALING_AUTO		REG_FIELD_PREP(PFIT_SCALING_MASK, 0)
-#define   PFIT_SCALING_PROGRAMMED	REG_FIELD_PREP(PFIT_SCALING_MASK, 1)
-#define   PFIT_SCALING_PILLAR		REG_FIELD_PREP(PFIT_SCALING_MASK, 2)
-#define   PFIT_SCALING_LETTER		REG_FIELD_PREP(PFIT_SCALING_MASK, 3)
-#define   PFIT_FILTER_MASK		REG_GENMASK(25, 24) /* 965+ */
-#define   PFIT_FILTER_FUZZY		REG_FIELD_PREP(PFIT_FILTER_MASK, 0)
-#define   PFIT_FILTER_CRISP		REG_FIELD_PREP(PFIT_FILTER_MASK, 1)
-#define   PFIT_FILTER_MEDIAN		REG_FIELD_PREP(PFIT_FILTER_MASK, 2)
-#define   PFIT_VERT_INTERP_MASK		REG_GENMASK(11, 10) /* pre-965 */
-#define   PFIT_VERT_INTERP_BILINEAR	REG_FIELD_PREP(PFIT_VERT_INTERP_MASK, 1)
-#define   PFIT_VERT_AUTO_SCALE		REG_BIT(9) /* pre-965 */
-#define   PFIT_HORIZ_INTERP_MASK	REG_GENMASK(7, 6) /* pre-965 */
-#define   PFIT_HORIZ_INTERP_BILINEAR	REG_FIELD_PREP(PFIT_HORIZ_INTERP_MASK, 1)
-#define   PFIT_HORIZ_AUTO_SCALE		REG_BIT(5) /* pre-965 */
-#define   PFIT_PANEL_8TO6_DITHER_ENABLE	REG_BIT(3) /* pre-965 */
-
-#define PFIT_PGM_RATIOS(dev_priv) _MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61234)
-#define   PFIT_VERT_SCALE_MASK		REG_GENMASK(31, 20) /* pre-965 */
-#define   PFIT_VERT_SCALE(x)		REG_FIELD_PREP(PFIT_VERT_SCALE_MASK, (x))
-#define   PFIT_HORIZ_SCALE_MASK		REG_GENMASK(15, 4) /* pre-965 */
-#define   PFIT_HORIZ_SCALE(x)		REG_FIELD_PREP(PFIT_HORIZ_SCALE_MASK, (x))
-#define   PFIT_VERT_SCALE_MASK_965	REG_GENMASK(28, 16) /* 965+ */
-#define   PFIT_HORIZ_SCALE_MASK_965	REG_GENMASK(12, 0) /* 965+ */
-
-#define PFIT_AUTO_RATIOS(dev_priv) _MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61238)
-
-#define PCH_GTC_CTL		_MMIO(0xe7000)
-#define   PCH_GTC_ENABLE	(1 << 31)
-
-/* Display Port */
-#define DP_A			_MMIO(0x64000) /* eDP */
-#define DP_B			_MMIO(0x64100)
-#define DP_C			_MMIO(0x64200)
-#define DP_D			_MMIO(0x64300)
-#define VLV_DP_B		_MMIO(VLV_DISPLAY_BASE + 0x64100)
-#define VLV_DP_C		_MMIO(VLV_DISPLAY_BASE + 0x64200)
-#define CHV_DP_D		_MMIO(VLV_DISPLAY_BASE + 0x64300)
-#define   DP_PORT_EN			REG_BIT(31)
-#define   DP_PIPE_SEL_MASK		REG_GENMASK(30, 30)
-#define   DP_PIPE_SEL(pipe)		REG_FIELD_PREP(DP_PIPE_SEL_MASK, (pipe))
-#define   DP_PIPE_SEL_MASK_IVB		REG_GENMASK(30, 29)
-#define   DP_PIPE_SEL_IVB(pipe)		REG_FIELD_PREP(DP_PIPE_SEL_MASK_IVB, (pipe))
-#define   DP_PIPE_SEL_SHIFT_CHV		16
-#define   DP_PIPE_SEL_MASK_CHV		REG_GENMASK(17, 16)
-#define   DP_PIPE_SEL_CHV(pipe)		REG_FIELD_PREP(DP_PIPE_SEL_MASK_CHV, (pipe))
-#define   DP_LINK_TRAIN_MASK		REG_GENMASK(29, 28)
-#define   DP_LINK_TRAIN_PAT_1		REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 0)
-#define   DP_LINK_TRAIN_PAT_2		REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 1)
-#define   DP_LINK_TRAIN_PAT_IDLE	REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 2)
-#define   DP_LINK_TRAIN_OFF		REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 3)
-#define   DP_LINK_TRAIN_MASK_CPT	REG_GENMASK(10, 8)
-#define   DP_LINK_TRAIN_PAT_1_CPT	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 0)
-#define   DP_LINK_TRAIN_PAT_2_CPT	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 1)
-#define   DP_LINK_TRAIN_PAT_IDLE_CPT	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 2)
-#define   DP_LINK_TRAIN_OFF_CPT		REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 3)
-#define   DP_VOLTAGE_MASK		REG_GENMASK(27, 25)
-#define   DP_VOLTAGE_0_4		REG_FIELD_PREP(DP_VOLTAGE_MASK, 0)
-#define   DP_VOLTAGE_0_6		REG_FIELD_PREP(DP_VOLTAGE_MASK, 1)
-#define   DP_VOLTAGE_0_8		REG_FIELD_PREP(DP_VOLTAGE_MASK, 2)
-#define   DP_VOLTAGE_1_2		REG_FIELD_PREP(DP_VOLTAGE_MASK, 3)
-#define   DP_PRE_EMPHASIS_MASK		REG_GENMASK(24, 22)
-#define   DP_PRE_EMPHASIS_0		REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 0)
-#define   DP_PRE_EMPHASIS_3_5		REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 1)
-#define   DP_PRE_EMPHASIS_6		REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 2)
-#define   DP_PRE_EMPHASIS_9_5		REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 3)
-#define   DP_PORT_WIDTH_MASK		REG_GENMASK(21, 19)
-#define   DP_PORT_WIDTH(width)		REG_FIELD_PREP(DP_PORT_WIDTH_MASK, (width) - 1)
-#define   DP_ENHANCED_FRAMING		REG_BIT(18)
-#define   EDP_PLL_FREQ_MASK		REG_GENMASK(17, 16)
-#define   EDP_PLL_FREQ_270MHZ		REG_FIELD_PREP(EDP_PLL_FREQ_MASK, 0)
-#define   EDP_PLL_FREQ_162MHZ		REG_FIELD_PREP(EDP_PLL_FREQ_MASK, 1)
-#define   DP_PORT_REVERSAL		REG_BIT(15)
-#define   EDP_PLL_ENABLE		REG_BIT(14)
-#define   DP_CLOCK_OUTPUT_ENABLE	REG_BIT(13)
-#define   DP_SCRAMBLING_DISABLE		REG_BIT(12)
-#define   DP_SCRAMBLING_DISABLE_ILK	REG_BIT(7)
-#define   DP_COLOR_RANGE_16_235		REG_BIT(8)
-#define   DP_AUDIO_OUTPUT_ENABLE	REG_BIT(6)
-#define   DP_SYNC_VS_HIGH		REG_BIT(4)
-#define   DP_SYNC_HS_HIGH		REG_BIT(3)
-#define   DP_DETECTED			REG_BIT(2)
-
-/*
- * Computing GMCH M and N values for the Display Port link
- *
- * GMCH M/N = dot clock * bytes per pixel / ls_clk * # of lanes
- *
- * ls_clk (we assume) is the DP link clock (1.62 or 2.7 GHz)
- *
- * The GMCH value is used internally
- *
- * bytes_per_pixel is the number of bytes coming out of the plane,
- * which is after the LUTs, so we want the bytes for our color format.
- * For our current usage, this is always 3, one byte for R, G and B.
- */
-#define _PIPEA_DATA_M_G4X	0x70050
-#define _PIPEB_DATA_M_G4X	0x71050
-#define PIPE_DATA_M_G4X(pipe) _MMIO_PIPE(pipe, _PIPEA_DATA_M_G4X, _PIPEB_DATA_M_G4X)
-/* Transfer unit size for display port - 1, default is 0x3f (for TU size 64) */
-#define  TU_SIZE_MASK		REG_GENMASK(30, 25)
-#define  TU_SIZE(x)		REG_FIELD_PREP(TU_SIZE_MASK, (x) - 1) /* default size 64 */
-#define  DATA_LINK_M_N_MASK	REG_GENMASK(23, 0)
-#define  DATA_LINK_N_MAX	(0x800000)
-
-#define _PIPEA_DATA_N_G4X	0x70054
-#define _PIPEB_DATA_N_G4X	0x71054
-#define PIPE_DATA_N_G4X(pipe) _MMIO_PIPE(pipe, _PIPEA_DATA_N_G4X, _PIPEB_DATA_N_G4X)
-
-/*
- * Computing Link M and N values for the Display Port link
- *
- * Link M / N = pixel_clock / ls_clk
- *
- * (the DP spec calls pixel_clock the 'strm_clk')
- *
- * The Link value is transmitted in the Main Stream
- * Attributes and VB-ID.
- */
-#define _PIPEA_LINK_M_G4X	0x70060
-#define _PIPEB_LINK_M_G4X	0x71060
-#define PIPE_LINK_M_G4X(pipe) _MMIO_PIPE(pipe, _PIPEA_LINK_M_G4X, _PIPEB_LINK_M_G4X)
-
-#define _PIPEA_LINK_N_G4X	0x70064
-#define _PIPEB_LINK_N_G4X	0x71064
-#define PIPE_LINK_N_G4X(pipe) _MMIO_PIPE(pipe, _PIPEA_LINK_N_G4X, _PIPEB_LINK_N_G4X)
-
-/* Pipe A */
-#define _PIPEADSL		0x70000
-#define PIPEDSL(dev_priv, pipe)		_MMIO_PIPE2(dev_priv, pipe, _PIPEADSL)
-#define   PIPEDSL_CURR_FIELD	REG_BIT(31) /* ctg+ */
-#define   PIPEDSL_LINE_MASK	REG_GENMASK(19, 0)
-
-#define _TRANSACONF		0x70008
-#define TRANSCONF(dev_priv, trans)	_MMIO_PIPE2(dev_priv, (trans), _TRANSACONF)
-#define   TRANSCONF_ENABLE			REG_BIT(31)
-#define   TRANSCONF_DOUBLE_WIDE			REG_BIT(30) /* pre-i965 */
-#define   TRANSCONF_STATE_ENABLE			REG_BIT(30) /* i965+ */
-#define   TRANSCONF_DSI_PLL_LOCKED		REG_BIT(29) /* vlv & pipe A only */
-#define   TRANSCONF_FRAME_START_DELAY_MASK	REG_GENMASK(28, 27) /* pre-hsw */
-#define   TRANSCONF_FRAME_START_DELAY(x)		REG_FIELD_PREP(TRANSCONF_FRAME_START_DELAY_MASK, (x)) /* pre-hsw: 0-3 */
-#define   TRANSCONF_PIPE_LOCKED			REG_BIT(25)
-#define   TRANSCONF_FORCE_BORDER			REG_BIT(25)
-#define   TRANSCONF_GAMMA_MODE_MASK_I9XX		REG_BIT(24) /* gmch */
-#define   TRANSCONF_GAMMA_MODE_MASK_ILK		REG_GENMASK(25, 24) /* ilk-ivb */
-#define   TRANSCONF_GAMMA_MODE_8BIT		REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK, 0)
-#define   TRANSCONF_GAMMA_MODE_10BIT		REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK, 1)
-#define   TRANSCONF_GAMMA_MODE_12BIT		REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK_ILK, 2) /* ilk-ivb */
-#define   TRANSCONF_GAMMA_MODE_SPLIT		REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK_ILK, 3) /* ivb */
-#define   TRANSCONF_GAMMA_MODE(x)		REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK_ILK, (x)) /* pass in GAMMA_MODE_MODE_* */
-#define   TRANSCONF_INTERLACE_MASK		REG_GENMASK(23, 21) /* gen3+ */
-#define   TRANSCONF_INTERLACE_PROGRESSIVE	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 0)
-#define   TRANSCONF_INTERLACE_W_SYNC_SHIFT_PANEL	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 4) /* gen4 only */
-#define   TRANSCONF_INTERLACE_W_SYNC_SHIFT	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 5) /* gen4 only */
-#define   TRANSCONF_INTERLACE_W_FIELD_INDICATION	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 6)
-#define   TRANSCONF_INTERLACE_FIELD_0_ONLY	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 7) /* gen3 only */
-/*
- * ilk+: PF/D=progressive fetch/display, IF/D=interlaced fetch/display,
- * DBL=power saving pixel doubling, PF-ID* requires panel fitter
- */
-#define   TRANSCONF_INTERLACE_MASK_ILK		REG_GENMASK(23, 21) /* ilk+ */
-#define   TRANSCONF_INTERLACE_MASK_HSW		REG_GENMASK(22, 21) /* hsw+ */
-#define   TRANSCONF_INTERLACE_PF_PD_ILK		REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 0)
-#define   TRANSCONF_INTERLACE_PF_ID_ILK		REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 1)
-#define   TRANSCONF_INTERLACE_IF_ID_ILK		REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 3)
-#define   TRANSCONF_INTERLACE_IF_ID_DBL_ILK	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 4) /* ilk/snb only */
-#define   TRANSCONF_INTERLACE_PF_ID_DBL_ILK	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 5) /* ilk/snb only */
-#define   TRANSCONF_REFRESH_RATE_ALT_ILK		REG_BIT(20)
-#define   TRANSCONF_MSA_TIMING_DELAY_MASK	REG_GENMASK(19, 18) /* ilk/snb/ivb */
-#define   TRANSCONF_MSA_TIMING_DELAY(x)		REG_FIELD_PREP(TRANSCONF_MSA_TIMING_DELAY_MASK, (x))
-#define   TRANSCONF_CXSR_DOWNCLOCK		REG_BIT(16)
-#define   TRANSCONF_WGC_ENABLE			REG_BIT(15) /* vlv/chv only */
-#define   TRANSCONF_REFRESH_RATE_ALT_VLV		REG_BIT(14)
-#define   TRANSCONF_COLOR_RANGE_SELECT		REG_BIT(13)
-#define   TRANSCONF_OUTPUT_COLORSPACE_MASK	REG_GENMASK(12, 11) /* ilk-ivb */
-#define   TRANSCONF_OUTPUT_COLORSPACE_RGB	REG_FIELD_PREP(TRANSCONF_OUTPUT_COLORSPACE_MASK, 0) /* ilk-ivb */
-#define   TRANSCONF_OUTPUT_COLORSPACE_YUV601	REG_FIELD_PREP(TRANSCONF_OUTPUT_COLORSPACE_MASK, 1) /* ilk-ivb */
-#define   TRANSCONF_OUTPUT_COLORSPACE_YUV709	REG_FIELD_PREP(TRANSCONF_OUTPUT_COLORSPACE_MASK, 2) /* ilk-ivb */
-#define   TRANSCONF_OUTPUT_COLORSPACE_YUV_HSW	REG_BIT(11) /* hsw only */
-#define   TRANSCONF_BPC_MASK			REG_GENMASK(7, 5) /* ctg-ivb */
-#define   TRANSCONF_BPC_8			REG_FIELD_PREP(TRANSCONF_BPC_MASK, 0)
-#define   TRANSCONF_BPC_10			REG_FIELD_PREP(TRANSCONF_BPC_MASK, 1)
-#define   TRANSCONF_BPC_6			REG_FIELD_PREP(TRANSCONF_BPC_MASK, 2)
-#define   TRANSCONF_BPC_12			REG_FIELD_PREP(TRANSCONF_BPC_MASK, 3)
-#define   TRANSCONF_DITHER_EN			REG_BIT(4)
-#define   TRANSCONF_DITHER_TYPE_MASK		REG_GENMASK(3, 2)
-#define   TRANSCONF_DITHER_TYPE_SP		REG_FIELD_PREP(TRANSCONF_DITHER_TYPE_MASK, 0)
-#define   TRANSCONF_DITHER_TYPE_ST1		REG_FIELD_PREP(TRANSCONF_DITHER_TYPE_MASK, 1)
-#define   TRANSCONF_DITHER_TYPE_ST2		REG_FIELD_PREP(TRANSCONF_DITHER_TYPE_MASK, 2)
-#define   TRANSCONF_DITHER_TYPE_TEMP		REG_FIELD_PREP(TRANSCONF_DITHER_TYPE_MASK, 3)
-#define   TRANSCONF_PIXEL_COUNT_SCALING_MASK	REG_GENMASK(1, 0)
-#define   TRANSCONF_PIXEL_COUNT_SCALING_X4	1
-
 #define _PIPEASTAT		0x70024
 #define PIPESTAT(dev_priv, pipe)		_MMIO_PIPE2(dev_priv, pipe, _PIPEASTAT)
 #define   PIPE_FIFO_UNDERRUN_STATUS		(1UL << 31)
@@ -1598,41 +846,6 @@
 #define   PIPESTAT_INT_ENABLE_MASK		0x7fff0000
 #define   PIPESTAT_INT_STATUS_MASK		0x0000ffff
 
-#define _PIPE_ARB_CTL_A			0x70028 /* icl+ */
-#define PIPE_ARB_CTL(dev_priv, pipe)		_MMIO_PIPE2(dev_priv, pipe, _PIPE_ARB_CTL_A)
-#define   PIPE_ARB_USE_PROG_SLOTS	REG_BIT(13)
-
-#define _PIPE_MISC_A			0x70030
-#define _PIPE_MISC_B			0x71030
-#define PIPE_MISC(pipe)			_MMIO_PIPE(pipe, _PIPE_MISC_A, _PIPE_MISC_B)
-#define   PIPE_MISC_YUV420_ENABLE		REG_BIT(27) /* glk+ */
-#define   PIPE_MISC_YUV420_MODE_FULL_BLEND	REG_BIT(26) /* glk+ */
-#define   PIPE_MISC_HDR_MODE_PRECISION		REG_BIT(23) /* icl+ */
-#define   PIPE_MISC_PSR_MASK_PRIMARY_FLIP	REG_BIT(23) /* bdw */
-#define   PIPE_MISC_PSR_MASK_SPRITE_ENABLE	REG_BIT(22) /* bdw */
-#define   PIPE_MISC_PSR_MASK_PIPE_REG_WRITE	REG_BIT(21) /* skl+ */
-#define   PIPE_MISC_PSR_MASK_CURSOR_MOVE	REG_BIT(21) /* bdw */
-#define   PIPE_MISC_PSR_MASK_VBLANK_VSYNC_INT	REG_BIT(20)
-#define   PIPE_MISC_OUTPUT_COLORSPACE_YUV	REG_BIT(11)
-#define   PIPE_MISC_PIXEL_ROUNDING_TRUNC	REG_BIT(8) /* tgl+ */
-/*
- * For Display < 13, Bits 5-7 of PIPE MISC represent DITHER BPC with
- * valid values of: 6, 8, 10 BPC.
- * ADLP+, the bits 5-7 represent PORT OUTPUT BPC with valid values of:
- * 6, 8, 10, 12 BPC.
- */
-#define   PIPE_MISC_BPC_MASK			REG_GENMASK(7, 5)
-#define   PIPE_MISC_BPC_8			REG_FIELD_PREP(PIPE_MISC_BPC_MASK, 0)
-#define   PIPE_MISC_BPC_10			REG_FIELD_PREP(PIPE_MISC_BPC_MASK, 1)
-#define   PIPE_MISC_BPC_6			REG_FIELD_PREP(PIPE_MISC_BPC_MASK, 2)
-#define   PIPE_MISC_BPC_12_ADLP			REG_FIELD_PREP(PIPE_MISC_BPC_MASK, 4) /* adlp+ */
-#define   PIPE_MISC_DITHER_ENABLE		REG_BIT(4)
-#define   PIPE_MISC_DITHER_TYPE_MASK		REG_GENMASK(3, 2)
-#define   PIPE_MISC_DITHER_TYPE_SP		REG_FIELD_PREP(PIPE_MISC_DITHER_TYPE_MASK, 0)
-#define   PIPE_MISC_DITHER_TYPE_ST1		REG_FIELD_PREP(PIPE_MISC_DITHER_TYPE_MASK, 1)
-#define   PIPE_MISC_DITHER_TYPE_ST2		REG_FIELD_PREP(PIPE_MISC_DITHER_TYPE_MASK, 2)
-#define   PIPE_MISC_DITHER_TYPE_TEMP		REG_FIELD_PREP(PIPE_MISC_DITHER_TYPE_MASK, 3)
-
 #define _PIPE_MISC2_A					0x7002C
 #define _PIPE_MISC2_B					0x7102C
 #define PIPE_MISC2(pipe)		_MMIO_PIPE(pipe, _PIPE_MISC2_A, _PIPE_MISC2_B)
@@ -1663,136 +876,16 @@
 #define   SPRITEE_FLIPDONE_INT_EN			REG_BIT(9)
 #define   PLANEC_FLIPDONE_INT_EN			REG_BIT(8)
 
-#define DPINVGTT				_MMIO(VLV_DISPLAY_BASE + 0x7002c) /* VLV/CHV only */
-#define   DPINVGTT_EN_MASK_CHV				REG_GENMASK(27, 16)
-#define   DPINVGTT_EN_MASK_VLV				REG_GENMASK(23, 16)
-#define   SPRITEF_INVALID_GTT_INT_EN			REG_BIT(27)
-#define   SPRITEE_INVALID_GTT_INT_EN			REG_BIT(26)
-#define   PLANEC_INVALID_GTT_INT_EN			REG_BIT(25)
-#define   CURSORC_INVALID_GTT_INT_EN			REG_BIT(24)
-#define   CURSORB_INVALID_GTT_INT_EN			REG_BIT(23)
-#define   CURSORA_INVALID_GTT_INT_EN			REG_BIT(22)
-#define   SPRITED_INVALID_GTT_INT_EN			REG_BIT(21)
-#define   SPRITEC_INVALID_GTT_INT_EN			REG_BIT(20)
-#define   PLANEB_INVALID_GTT_INT_EN			REG_BIT(19)
-#define   SPRITEB_INVALID_GTT_INT_EN			REG_BIT(18)
-#define   SPRITEA_INVALID_GTT_INT_EN			REG_BIT(17)
-#define   PLANEA_INVALID_GTT_INT_EN			REG_BIT(16)
-#define   DPINVGTT_STATUS_MASK_CHV			REG_GENMASK(11, 0)
-#define   DPINVGTT_STATUS_MASK_VLV			REG_GENMASK(7, 0)
-#define   SPRITEF_INVALID_GTT_STATUS			REG_BIT(11)
-#define   SPRITEE_INVALID_GTT_STATUS			REG_BIT(10)
-#define   PLANEC_INVALID_GTT_STATUS			REG_BIT(9)
-#define   CURSORC_INVALID_GTT_STATUS			REG_BIT(8)
-#define   CURSORB_INVALID_GTT_STATUS			REG_BIT(7)
-#define   CURSORA_INVALID_GTT_STATUS			REG_BIT(6)
-#define   SPRITED_INVALID_GTT_STATUS			REG_BIT(5)
-#define   SPRITEC_INVALID_GTT_STATUS			REG_BIT(4)
-#define   PLANEB_INVALID_GTT_STATUS			REG_BIT(3)
-#define   SPRITEB_INVALID_GTT_STATUS			REG_BIT(2)
-#define   SPRITEA_INVALID_GTT_STATUS			REG_BIT(1)
-#define   PLANEA_INVALID_GTT_STATUS			REG_BIT(0)
-
-#define CBR1_VLV			_MMIO(VLV_DISPLAY_BASE + 0x70400)
-#define  CBR_PND_DEADLINE_DISABLE	(1 << 31)
-#define  CBR_PWM_CLOCK_MUX_SELECT	(1 << 30)
-
-#define CBR4_VLV			_MMIO(VLV_DISPLAY_BASE + 0x70450)
-#define  CBR_DPLLBMD_PIPE(pipe)		(1 << (7 + (pipe) * 11)) /* pipes B and C */
-
-/*
- * The two pipe frame counter registers are not synchronized, so
- * reading a stable value is somewhat tricky. The following code
- * should work:
- *
- *  do {
- *    high1 = ((INREG(PIPEAFRAMEHIGH) & PIPE_FRAME_HIGH_MASK) >>
- *             PIPE_FRAME_HIGH_SHIFT;
- *    low1 =  ((INREG(PIPEAFRAMEPIXEL) & PIPE_FRAME_LOW_MASK) >>
- *             PIPE_FRAME_LOW_SHIFT);
- *    high2 = ((INREG(PIPEAFRAMEHIGH) & PIPE_FRAME_HIGH_MASK) >>
- *             PIPE_FRAME_HIGH_SHIFT);
- *  } while (high1 != high2);
- *  frame = (high1 << 8) | low1;
- */
-#define _PIPEAFRAMEHIGH          0x70040
-#define PIPEFRAME(dev_priv, pipe)		_MMIO_PIPE2(dev_priv, pipe, _PIPEAFRAMEHIGH)
-#define   PIPE_FRAME_HIGH_MASK    0x0000ffff
-#define   PIPE_FRAME_HIGH_SHIFT   0
-
-#define _PIPEAFRAMEPIXEL         0x70044
-#define PIPEFRAMEPIXEL(dev_priv, pipe)	_MMIO_PIPE2(dev_priv, pipe, _PIPEAFRAMEPIXEL)
-#define   PIPE_FRAME_LOW_MASK     0xff000000
-#define   PIPE_FRAME_LOW_SHIFT    24
-#define   PIPE_PIXEL_MASK         0x00ffffff
-#define   PIPE_PIXEL_SHIFT        0
-
-/* GM45+ just has to be different */
-#define _PIPEA_FRMCOUNT_G4X	0x70040
-#define PIPE_FRMCOUNT_G4X(dev_priv, pipe) _MMIO_PIPE2(dev_priv, pipe, _PIPEA_FRMCOUNT_G4X)
-
 #define _PIPEA_FLIPCOUNT_G4X	0x70044
 #define PIPE_FLIPCOUNT_G4X(dev_priv, pipe) _MMIO_PIPE2(dev_priv, pipe, _PIPEA_FLIPCOUNT_G4X)
 
-/* CHV pipe B blender */
-#define _CHV_BLEND_A		0x60a00
-#define CHV_BLEND(dev_priv, pipe)		_MMIO_TRANS2(dev_priv, pipe, _CHV_BLEND_A)
-#define   CHV_BLEND_MASK	REG_GENMASK(31, 30)
-#define   CHV_BLEND_LEGACY	REG_FIELD_PREP(CHV_BLEND_MASK, 0)
-#define   CHV_BLEND_ANDROID	REG_FIELD_PREP(CHV_BLEND_MASK, 1)
-#define   CHV_BLEND_MPO		REG_FIELD_PREP(CHV_BLEND_MASK, 2)
-
-#define _CHV_CANVAS_A		0x60a04
-#define CHV_CANVAS(dev_priv, pipe)	_MMIO_TRANS2(dev_priv, pipe, _CHV_CANVAS_A)
-#define   CHV_CANVAS_RED_MASK	REG_GENMASK(29, 20)
-#define   CHV_CANVAS_GREEN_MASK	REG_GENMASK(19, 10)
-#define   CHV_CANVAS_BLUE_MASK	REG_GENMASK(9, 0)
-
 /* Display/Sprite base address macros */
 #define DISP_BASEADDR_MASK	(0xfffff000)
 #define I915_LO_DISPBASE(val)	((val) & ~DISP_BASEADDR_MASK)
 #define I915_HI_DISPBASE(val)	((val) & DISP_BASEADDR_MASK)
 
-/*
- * VBIOS flags
- * gen2:
- * [00:06] alm,mgm
- * [10:16] all
- * [30:32] alm,mgm
- * gen3+:
- * [00:0f] all
- * [10:1f] all
- * [30:32] all
- */
-#define SWF0(dev_priv, i)	_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x70410 + (i) * 4)
-#define SWF1(dev_priv, i)	_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x71410 + (i) * 4)
-#define SWF3(dev_priv, i)	_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x72414 + (i) * 4)
-#define SWF_ILK(i)	_MMIO(0x4F000 + (i) * 4)
-
-/* VBIOS regs */
-#define VGACNTRL		_MMIO(0x71400)
-# define VGA_DISP_DISABLE			(1 << 31)
-# define VGA_2X_MODE				(1 << 30)
-# define VGA_PIPE_B_SELECT			(1 << 29)
-
-#define VLV_VGACNTRL		_MMIO(VLV_DISPLAY_BASE + 0x71400)
-
 /* Ironlake */
 
-#define CPU_VGACNTRL	_MMIO(0x41000)
-
-#define DIGITAL_PORT_HOTPLUG_CNTRL	_MMIO(0x44030)
-#define  DIGITAL_PORTA_HOTPLUG_ENABLE		(1 << 4)
-#define  DIGITAL_PORTA_PULSE_DURATION_2ms	(0 << 2) /* pre-HSW */
-#define  DIGITAL_PORTA_PULSE_DURATION_4_5ms	(1 << 2) /* pre-HSW */
-#define  DIGITAL_PORTA_PULSE_DURATION_6ms	(2 << 2) /* pre-HSW */
-#define  DIGITAL_PORTA_PULSE_DURATION_100ms	(3 << 2) /* pre-HSW */
-#define  DIGITAL_PORTA_PULSE_DURATION_MASK	(3 << 2) /* pre-HSW */
-#define  DIGITAL_PORTA_HOTPLUG_STATUS_MASK	(3 << 0)
-#define  DIGITAL_PORTA_HOTPLUG_NO_DETECT	(0 << 0)
-#define  DIGITAL_PORTA_HOTPLUG_SHORT_DETECT	(1 << 0)
-#define  DIGITAL_PORTA_HOTPLUG_LONG_DETECT	(2 << 0)
-
 /* refresh rate hardware control */
 #define RR_HW_CTL       _MMIO(0x45300)
 #define  RR_HW_LOW_POWER_FRAMES_MASK    0xff
@@ -1805,68 +898,6 @@
 #define PCH_3DCGDIS1		_MMIO(0x46024)
 # define VFMUNIT_CLOCK_GATE_DISABLE		(1 << 11)
 
-#define _PIPEA_DATA_M1		0x60030
-#define _PIPEB_DATA_M1		0x61030
-#define PIPE_DATA_M1(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, _PIPEA_DATA_M1)
-
-#define _PIPEA_DATA_N1		0x60034
-#define _PIPEB_DATA_N1		0x61034
-#define PIPE_DATA_N1(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, _PIPEA_DATA_N1)
-
-#define _PIPEA_DATA_M2		0x60038
-#define _PIPEB_DATA_M2		0x61038
-#define PIPE_DATA_M2(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, _PIPEA_DATA_M2)
-
-#define _PIPEA_DATA_N2		0x6003c
-#define _PIPEB_DATA_N2		0x6103c
-#define PIPE_DATA_N2(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, _PIPEA_DATA_N2)
-
-#define _PIPEA_LINK_M1		0x60040
-#define _PIPEB_LINK_M1		0x61040
-#define PIPE_LINK_M1(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, _PIPEA_LINK_M1)
-
-#define _PIPEA_LINK_N1		0x60044
-#define _PIPEB_LINK_N1		0x61044
-#define PIPE_LINK_N1(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, _PIPEA_LINK_N1)
-
-#define _PIPEA_LINK_M2		0x60048
-#define _PIPEB_LINK_M2		0x61048
-#define PIPE_LINK_M2(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, _PIPEA_LINK_M2)
-
-#define _PIPEA_LINK_N2		0x6004c
-#define _PIPEB_LINK_N2		0x6104c
-#define PIPE_LINK_N2(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, _PIPEA_LINK_N2)
-
-/* CPU panel fitter */
-/* IVB+ has 3 fitters, 0 is 7x5 capable, the other two only 3x3 */
-#define _PFA_CTL_1		0x68080
-#define _PFB_CTL_1		0x68880
-#define PF_CTL(pipe)		_MMIO_PIPE(pipe, _PFA_CTL_1, _PFB_CTL_1)
-#define   PF_ENABLE			REG_BIT(31)
-#define   PF_PIPE_SEL_MASK_IVB		REG_GENMASK(30, 29) /* ivb/hsw */
-#define   PF_PIPE_SEL_IVB(pipe)		REG_FIELD_PREP(PF_PIPE_SEL_MASK_IVB, (pipe))
-#define   PF_FILTER_MASK		REG_GENMASK(24, 23)
-#define   PF_FILTER_PROGRAMMED		REG_FIELD_PREP(PF_FILTER_MASK, 0)
-#define   PF_FILTER_MED_3x3		REG_FIELD_PREP(PF_FILTER_MASK, 1)
-#define   PF_FILTER_EDGE_ENHANCE	REG_FIELD_PREP(PF_FILTER_EDGE_MASK, 2)
-#define   PF_FILTER_EDGE_SOFTEN		REG_FIELD_PREP(PF_FILTER_EDGE_MASK, 3)
-
-#define _PFA_WIN_SZ		0x68074
-#define _PFB_WIN_SZ		0x68874
-#define PF_WIN_SZ(pipe)		_MMIO_PIPE(pipe, _PFA_WIN_SZ, _PFB_WIN_SZ)
-#define   PF_WIN_XSIZE_MASK	REG_GENMASK(31, 16)
-#define   PF_WIN_XSIZE(w)	REG_FIELD_PREP(PF_WIN_XSIZE_MASK, (w))
-#define   PF_WIN_YSIZE_MASK	REG_GENMASK(15, 0)
-#define   PF_WIN_YSIZE(h)	REG_FIELD_PREP(PF_WIN_YSIZE_MASK, (h))
-
-#define _PFA_WIN_POS		0x68070
-#define _PFB_WIN_POS		0x68870
-#define PF_WIN_POS(pipe)	_MMIO_PIPE(pipe, _PFA_WIN_POS, _PFB_WIN_POS)
-#define   PF_WIN_XPOS_MASK	REG_GENMASK(31, 16)
-#define   PF_WIN_XPOS(x)	REG_FIELD_PREP(PF_WIN_XPOS_MASK, (x))
-#define   PF_WIN_YPOS_MASK	REG_GENMASK(15, 0)
-#define   PF_WIN_YPOS(y)	REG_FIELD_PREP(PF_WIN_YPOS_MASK, (y))
-
 #define _PFA_VSCALE		0x68084
 #define _PFB_VSCALE		0x68884
 #define PF_VSCALE(pipe)		_MMIO_PIPE(pipe, _PFA_VSCALE, _PFB_VSCALE)
@@ -1875,65 +906,6 @@
 #define _PFB_HSCALE		0x68890
 #define PF_HSCALE(pipe)		_MMIO_PIPE(pipe, _PFA_HSCALE, _PFB_HSCALE)
 
-/*
- * Skylake scalers
- */
-#define _ID(id, a, b) _PICK_EVEN(id, a, b)
-#define _PS_1A_CTRL      0x68180
-#define _PS_2A_CTRL      0x68280
-#define _PS_1B_CTRL      0x68980
-#define _PS_2B_CTRL      0x68A80
-#define _PS_1C_CTRL      0x69180
-#define SKL_PS_CTRL(pipe, id) _MMIO_PIPE(pipe,        \
-			_ID(id, _PS_1A_CTRL, _PS_2A_CTRL),       \
-			_ID(id, _PS_1B_CTRL, _PS_2B_CTRL))
-#define   PS_SCALER_EN				REG_BIT(31)
-#define   PS_SCALER_TYPE_MASK			REG_BIT(30) /* icl+ */
-#define   PS_SCALER_TYPE_NON_LINEAR		REG_FIELD_PREP(PS_SCALER_TYPE_MASK, 0)
-#define   PS_SCALER_TYPE_LINEAR			REG_FIELD_PREP(PS_SCALER_TYPE_MASK, 1)
-#define   SKL_PS_SCALER_MODE_MASK		REG_GENMASK(29, 28) /* skl/bxt */
-#define   SKL_PS_SCALER_MODE_DYN		REG_FIELD_PREP(SKL_PS_SCALER_MODE_MASK, 0)
-#define   SKL_PS_SCALER_MODE_HQ			REG_FIELD_PREP(SKL_PS_SCALER_MODE_MASK, 1)
-#define   SKL_PS_SCALER_MODE_NV12		REG_FIELD_PREP(SKL_PS_SCALER_MODE_MASK, 2)
-#define   PS_SCALER_MODE_MASK			REG_BIT(29) /* glk-tgl */
-#define   PS_SCALER_MODE_NORMAL			REG_FIELD_PREP(PS_SCALER_MODE_MASK, 0)
-#define   PS_SCALER_MODE_PLANAR			REG_FIELD_PREP(PS_SCALER_MODE_MASK, 1)
-#define   PS_ADAPTIVE_FILTERING_EN		REG_BIT(28) /* icl+ */
-#define   PS_BINDING_MASK			REG_GENMASK(27, 25)
-#define   PS_BINDING_PIPE			REG_FIELD_PREP(PS_BINDING_MASK, 0)
-#define   PS_BINDING_PLANE(plane_id)		REG_FIELD_PREP(PS_BINDING_MASK, (plane_id) + 1)
-#define   PS_FILTER_MASK			REG_GENMASK(24, 23)
-#define   PS_FILTER_MEDIUM			REG_FIELD_PREP(PS_FILTER_MASK, 0)
-#define   PS_FILTER_PROGRAMMED			REG_FIELD_PREP(PS_FILTER_MASK, 1)
-#define   PS_FILTER_EDGE_ENHANCE		REG_FIELD_PREP(PS_FILTER_MASK, 2)
-#define   PS_FILTER_BILINEAR			REG_FIELD_PREP(PS_FILTER_MASK, 3)
-#define   PS_ADAPTIVE_FILTER_MASK		REG_BIT(22) /* icl+ */
-#define   PS_ADAPTIVE_FILTER_MEDIUM		REG_FIELD_PREP(PS_ADAPTIVE_FILTER_MASK, 0)
-#define   PS_ADAPTIVE_FILTER_EDGE_ENHANCE	REG_FIELD_PREP(PS_ADAPTIVE_FILTER_MASK, 1)
-#define   PS_PIPE_SCALER_LOC_MASK		REG_BIT(21) /* icl+ */
-#define   PS_PIPE_SCALER_LOC_AFTER_OUTPUT_CSC	REG_FIELD_PREP(PS_SCALER_LOCATION_MASK, 0) /* non-linear */
-#define   PS_PIPE_SCALER_LOC_AFTER_CSC		REG_FIELD_PREP(PS_SCALER_LOCATION_MASK, 1) /* linear */
-#define   PS_VERT3TAP				REG_BIT(21) /* skl/bxt */
-#define   PS_VERT_INT_INVERT_FIELD		REG_BIT(20)
-#define   PS_PROG_SCALE_FACTOR			REG_BIT(19) /* tgl+ */
-#define   PS_PWRUP_PROGRESS			REG_BIT(17)
-#define   PS_V_FILTER_BYPASS			REG_BIT(8)
-#define   PS_VADAPT_EN				REG_BIT(7) /* skl/bxt */
-#define   PS_VADAPT_MODE_MASK			REG_GENMASK(6, 5) /* skl/bxt */
-#define   PS_VADAPT_MODE_LEAST_ADAPT		REG_FIELD_PREP(PS_VADAPT_MODE_MASK, 0)
-#define   PS_VADAPT_MODE_MOD_ADAPT		REG_FIELD_PREP(PS_VADAPT_MODE_MASK, 1)
-#define   PS_VADAPT_MODE_MOST_ADAPT		REG_FIELD_PREP(PS_VADAPT_MODE_MASK, 3)
-#define   PS_BINDING_Y_MASK			REG_GENMASK(7, 5) /* icl-tgl */
-#define   PS_BINDING_Y_PLANE(plane_id)		REG_FIELD_PREP(PS_BINDING_Y_MASK, (plane_id) + 1)
-#define   PS_Y_VERT_FILTER_SELECT_MASK		REG_BIT(4) /* glk+ */
-#define   PS_Y_VERT_FILTER_SELECT(set)		REG_FIELD_PREP(PS_Y_VERT_FILTER_SELECT_MASK, (set))
-#define   PS_Y_HORZ_FILTER_SELECT_MASK		REG_BIT(3) /* glk+ */
-#define   PS_Y_HORZ_FILTER_SELECT(set)		REG_FIELD_PREP(PS_Y_HORZ_FILTER_SELECT_MASK, (set))
-#define   PS_UV_VERT_FILTER_SELECT_MASK		REG_BIT(2) /* glk+ */
-#define   PS_UV_VERT_FILTER_SELECT(set)		REG_FIELD_PREP(PS_UV_VERT_FILTER_SELECT_MASK, (set))
-#define   PS_UV_HORZ_FILTER_SELECT_MASK		REG_BIT(1) /* glk+ */
-#define   PS_UV_HORZ_FILTER_SELECT(set)		REG_FIELD_PREP(PS_UV_HORZ_FILTER_SELECT_MASK, (set))
-
 #define _PS_PWR_GATE_1A     0x68160
 #define _PS_PWR_GATE_2A     0x68260
 #define _PS_PWR_GATE_1B     0x68960
@@ -1954,32 +926,6 @@
 #define   PS_PWR_GATE_SLPEN_24			REG_FIELD_PREP(PS_PWR_GATE_SLPEN_MASK, 2)
 #define   PS_PWR_GATE_SLPEN_32			REG_FIELD_PREP(PS_PWR_GATE_SLPEN_MASK, 3)
 
-#define _PS_WIN_POS_1A      0x68170
-#define _PS_WIN_POS_2A      0x68270
-#define _PS_WIN_POS_1B      0x68970
-#define _PS_WIN_POS_2B      0x68A70
-#define _PS_WIN_POS_1C      0x69170
-#define SKL_PS_WIN_POS(pipe, id) _MMIO_PIPE(pipe,     \
-			_ID(id, _PS_WIN_POS_1A, _PS_WIN_POS_2A), \
-			_ID(id, _PS_WIN_POS_1B, _PS_WIN_POS_2B))
-#define   PS_WIN_XPOS_MASK			REG_GENMASK(31, 16)
-#define   PS_WIN_XPOS(x)			REG_FIELD_PREP(PS_WIN_XPOS_MASK, (x))
-#define   PS_WIN_YPOS_MASK			REG_GENMASK(15, 0)
-#define   PS_WIN_YPOS(y)			REG_FIELD_PREP(PS_WIN_YPOS_MASK, (y))
-
-#define _PS_WIN_SZ_1A       0x68174
-#define _PS_WIN_SZ_2A       0x68274
-#define _PS_WIN_SZ_1B       0x68974
-#define _PS_WIN_SZ_2B       0x68A74
-#define _PS_WIN_SZ_1C       0x69174
-#define SKL_PS_WIN_SZ(pipe, id)  _MMIO_PIPE(pipe,     \
-			_ID(id, _PS_WIN_SZ_1A, _PS_WIN_SZ_2A),   \
-			_ID(id, _PS_WIN_SZ_1B, _PS_WIN_SZ_2B))
-#define   PS_WIN_XSIZE_MASK			REG_GENMASK(31, 16)
-#define   PS_WIN_XSIZE(w)			REG_FIELD_PREP(PS_WIN_XSIZE_MASK, (w))
-#define   PS_WIN_YSIZE_MASK			REG_GENMASK(15, 0)
-#define   PS_WIN_YSIZE(h)			REG_FIELD_PREP(PS_WIN_YSIZE_MASK, (h))
-
 #define _PS_VSCALE_1A       0x68184
 #define _PS_VSCALE_2A       0x68284
 #define _PS_VSCALE_1B       0x68984
@@ -1998,30 +944,6 @@
 			_ID(id, _PS_HSCALE_1A, _PS_HSCALE_2A),   \
 			_ID(id, _PS_HSCALE_1B, _PS_HSCALE_2B))
 
-#define _PS_VPHASE_1A       0x68188
-#define _PS_VPHASE_2A       0x68288
-#define _PS_VPHASE_1B       0x68988
-#define _PS_VPHASE_2B       0x68A88
-#define _PS_VPHASE_1C       0x69188
-#define SKL_PS_VPHASE(pipe, id)  _MMIO_PIPE(pipe,     \
-			_ID(id, _PS_VPHASE_1A, _PS_VPHASE_2A),   \
-			_ID(id, _PS_VPHASE_1B, _PS_VPHASE_2B))
-#define   PS_Y_PHASE_MASK			REG_GENMASK(31, 16)
-#define   PS_Y_PHASE(x)				REG_FIELD_PREP(PS_Y_PHASE_MASK, (x))
-#define   PS_UV_RGB_PHASE_MASK			REG_GENMASK(15, 0)
-#define   PS_UV_RGB_PHASE(x)			REG_FIELD_PREP(PS_UV_RGB_PHASE_MASK, (x))
-#define   PS_PHASE_MASK				(0x7fff << 1) /* u2.13 */
-#define   PS_PHASE_TRIP				(1 << 0)
-
-#define _PS_HPHASE_1A       0x68194
-#define _PS_HPHASE_2A       0x68294
-#define _PS_HPHASE_1B       0x68994
-#define _PS_HPHASE_2B       0x68A94
-#define _PS_HPHASE_1C       0x69194
-#define SKL_PS_HPHASE(pipe, id)  _MMIO_PIPE(pipe,     \
-			_ID(id, _PS_HPHASE_1A, _PS_HPHASE_2A),   \
-			_ID(id, _PS_HPHASE_1B, _PS_HPHASE_2B))
-
 #define _PS_ECC_STAT_1A     0x681D0
 #define _PS_ECC_STAT_2A     0x682D0
 #define _PS_ECC_STAT_1B     0x689D0
@@ -2031,23 +953,6 @@
 			_ID(id, _PS_ECC_STAT_1A, _PS_ECC_STAT_2A),   \
 			_ID(id, _PS_ECC_STAT_1B, _PS_ECC_STAT_2B))
 
-#define _PS_COEF_SET0_INDEX_1A	   0x68198
-#define _PS_COEF_SET0_INDEX_2A	   0x68298
-#define _PS_COEF_SET0_INDEX_1B	   0x68998
-#define _PS_COEF_SET0_INDEX_2B	   0x68A98
-#define GLK_PS_COEF_INDEX_SET(pipe, id, set)  _MMIO_PIPE(pipe,    \
-			_ID(id, _PS_COEF_SET0_INDEX_1A, _PS_COEF_SET0_INDEX_2A) + (set) * 8, \
-			_ID(id, _PS_COEF_SET0_INDEX_1B, _PS_COEF_SET0_INDEX_2B) + (set) * 8)
-#define   PS_COEF_INDEX_AUTO_INC		REG_BIT(10)
-
-#define _PS_COEF_SET0_DATA_1A	   0x6819C
-#define _PS_COEF_SET0_DATA_2A	   0x6829C
-#define _PS_COEF_SET0_DATA_1B	   0x6899C
-#define _PS_COEF_SET0_DATA_2B	   0x68A9C
-#define GLK_PS_COEF_DATA_SET(pipe, id, set)  _MMIO_PIPE(pipe,     \
-			_ID(id, _PS_COEF_SET0_DATA_1A, _PS_COEF_SET0_DATA_2A) + (set) * 8, \
-			_ID(id, _PS_COEF_SET0_DATA_1B, _PS_COEF_SET0_DATA_2B) + (set) * 8)
-
 /* Display Internal Timeout Register */
 #define RM_TIMEOUT		_MMIO(0x42060)
 #define RM_TIMEOUT_REG_CAPTURE	_MMIO(0x420E0)
@@ -2086,25 +991,6 @@
 #define DE_PIPEA_FIFO_UNDERRUN  (1 << 0)
 #define DE_PIPE_FIFO_UNDERRUN(pipe)  (1 << (8 * (pipe)))
 
-/* More Ivybridge lolz */
-#define DE_ERR_INT_IVB			(1 << 30)
-#define DE_GSE_IVB			(1 << 29)
-#define DE_PCH_EVENT_IVB		(1 << 28)
-#define DE_DP_A_HOTPLUG_IVB		(1 << 27)
-#define DE_AUX_CHANNEL_A_IVB		(1 << 26)
-#define DE_EDP_PSR_INT_HSW		(1 << 19)
-#define DE_SPRITEC_FLIP_DONE_IVB	(1 << 14)
-#define DE_PLANEC_FLIP_DONE_IVB		(1 << 13)
-#define DE_PIPEC_VBLANK_IVB		(1 << 10)
-#define DE_SPRITEB_FLIP_DONE_IVB	(1 << 9)
-#define DE_PLANEB_FLIP_DONE_IVB		(1 << 8)
-#define DE_PIPEB_VBLANK_IVB		(1 << 5)
-#define DE_SPRITEA_FLIP_DONE_IVB	(1 << 4)
-#define DE_PLANEA_FLIP_DONE_IVB		(1 << 3)
-#define DE_PLANE_FLIP_DONE_IVB(plane)	(1 << (3 + 5 * (plane)))
-#define DE_PIPEA_VBLANK_IVB		(1 << 0)
-#define DE_PIPE_VBLANK_IVB(pipe)	(1 << ((pipe) * 5))
-
 #define VLV_MASTER_IER			_MMIO(0x4400c) /* Gunit master IER */
 #define   MASTER_INTERRUPT_ENABLE	(1 << 31)
 
@@ -2144,8 +1030,6 @@
 #define  GEN8_GT_BCS_IRQ		(1 << 1)
 #define  GEN8_GT_RCS_IRQ		(1 << 0)
 
-#define XELPD_DISPLAY_ERR_FATAL_MASK	_MMIO(0x4421c)
-
 #define GEN8_GT_ISR(which) _MMIO(0x44300 + (0x10 * (which)))
 #define GEN8_GT_IMR(which) _MMIO(0x44304 + (0x10 * (which)))
 #define GEN8_GT_IIR(which) _MMIO(0x44308 + (0x10 * (which)))
@@ -2162,91 +1046,9 @@
 #define GEN8_VECS_IRQ_SHIFT 0
 #define GEN8_WD_IRQ_SHIFT 16
 
-#define GEN8_DE_PIPE_ISR(pipe) _MMIO(0x44400 + (0x10 * (pipe)))
-#define GEN8_DE_PIPE_IMR(pipe) _MMIO(0x44404 + (0x10 * (pipe)))
-#define GEN8_DE_PIPE_IIR(pipe) _MMIO(0x44408 + (0x10 * (pipe)))
-#define GEN8_DE_PIPE_IER(pipe) _MMIO(0x4440c + (0x10 * (pipe)))
-#define  GEN8_PIPE_FIFO_UNDERRUN	REG_BIT(31)
-#define  GEN8_PIPE_CDCLK_CRC_ERROR	REG_BIT(29)
-#define  GEN8_PIPE_CDCLK_CRC_DONE	REG_BIT(28)
-#define  GEN12_PIPEDMC_INTERRUPT	REG_BIT(26) /* tgl+ */
-#define  GEN12_PIPEDMC_FAULT		REG_BIT(25) /* tgl+ */
-#define  MTL_PIPEDMC_ATS_FAULT		REG_BIT(24) /* mtl+ */
-#define  GEN11_PIPE_PLANE7_FAULT	REG_BIT(22) /* icl/tgl */
-#define  GEN11_PIPE_PLANE6_FAULT	REG_BIT(21) /* icl/tgl */
-#define  GEN11_PIPE_PLANE5_FAULT	REG_BIT(20) /* icl+ */
-#define  GEN12_PIPE_VBLANK_UNMOD	REG_BIT(19) /* tgl+ */
-#define  MTL_PLANE_ATS_FAULT		REG_BIT(18) /* mtl+ */
-#define  GEN11_PIPE_PLANE7_FLIP_DONE	REG_BIT(18) /* icl/tgl */
-#define  GEN11_PIPE_PLANE6_FLIP_DONE	REG_BIT(17) /* icl/tgl */
-#define  GEN11_PIPE_PLANE5_FLIP_DONE	REG_BIT(16) /* icl+ */
-#define  GEN12_DSB_2_INT		REG_BIT(15) /* tgl+ */
-#define  GEN12_DSB_1_INT		REG_BIT(14) /* tgl+ */
-#define  GEN12_DSB_0_INT		REG_BIT(13) /* tgl+ */
-#define  GEN12_DSB_INT(dsb_id)		REG_BIT(13 + (dsb_id))
-#define  GEN9_PIPE_CURSOR_FAULT		REG_BIT(11) /* skl+ */
-#define  GEN9_PIPE_PLANE4_FAULT		REG_BIT(10) /* skl+ */
-#define  GEN8_PIPE_CURSOR_FAULT		REG_BIT(10) /* bdw */
-#define  GEN9_PIPE_PLANE3_FAULT		REG_BIT(9) /* skl+ */
-#define  GEN8_PIPE_SPRITE_FAULT		REG_BIT(9) /* bdw */
-#define  GEN9_PIPE_PLANE2_FAULT		REG_BIT(8) /* skl+ */
-#define  GEN8_PIPE_PRIMARY_FAULT	REG_BIT(8) /* bdw */
-#define  GEN9_PIPE_PLANE1_FAULT		REG_BIT(7) /* skl+ */
-#define  GEN9_PIPE_PLANE4_FLIP_DONE	REG_BIT(6) /* skl+ */
-#define  GEN9_PIPE_PLANE3_FLIP_DONE	REG_BIT(5) /* skl+ */
-#define  GEN8_PIPE_SPRITE_FLIP_DONE	REG_BIT(5) /* bdw */
-#define  GEN9_PIPE_PLANE2_FLIP_DONE	REG_BIT(4) /* skl+ */
-#define  GEN8_PIPE_PRIMARY_FLIP_DONE	REG_BIT(4) /* bdw */
-#define  GEN9_PIPE_PLANE1_FLIP_DONE	REG_BIT(3) /* skl+ */
-#define  GEN9_PIPE_PLANE_FLIP_DONE(plane_id) \
-	REG_BIT(((plane_id) >= PLANE_5 ? 16 - PLANE_5 : 3 - PLANE_1) + (plane_id)) /* skl+ */
-#define  GEN8_PIPE_SCAN_LINE_EVENT	REG_BIT(2)
-#define  GEN8_PIPE_VSYNC		REG_BIT(1)
-#define  GEN8_PIPE_VBLANK		REG_BIT(0)
-
-#define GEN8_DE_PIPE_IRQ_REGS(pipe)	I915_IRQ_REGS(GEN8_DE_PIPE_IMR(pipe), \
-						      GEN8_DE_PIPE_IER(pipe), \
-						      GEN8_DE_PIPE_IIR(pipe))
-
 #define _HPD_PIN_DDI(hpd_pin)	((hpd_pin) - HPD_PORT_A)
 #define _HPD_PIN_TC(hpd_pin)	((hpd_pin) - HPD_PORT_TC1)
 
-#define GEN8_DE_PORT_ISR _MMIO(0x44440)
-#define GEN8_DE_PORT_IMR _MMIO(0x44444)
-#define GEN8_DE_PORT_IIR _MMIO(0x44448)
-#define GEN8_DE_PORT_IER _MMIO(0x4444c)
-#define  DSI1_NON_TE			(1 << 31)
-#define  DSI0_NON_TE			(1 << 30)
-#define  ICL_AUX_CHANNEL_E		(1 << 29)
-#define  ICL_AUX_CHANNEL_F		(1 << 28)
-#define  GEN9_AUX_CHANNEL_D		(1 << 27)
-#define  GEN9_AUX_CHANNEL_C		(1 << 26)
-#define  GEN9_AUX_CHANNEL_B		(1 << 25)
-#define  DSI1_TE			(1 << 24)
-#define  DSI0_TE			(1 << 23)
-#define  GEN8_DE_PORT_HOTPLUG(hpd_pin)	REG_BIT(3 + _HPD_PIN_DDI(hpd_pin))
-#define  BXT_DE_PORT_HOTPLUG_MASK	(GEN8_DE_PORT_HOTPLUG(HPD_PORT_A) | \
-					 GEN8_DE_PORT_HOTPLUG(HPD_PORT_B) | \
-					 GEN8_DE_PORT_HOTPLUG(HPD_PORT_C))
-#define  BDW_DE_PORT_HOTPLUG_MASK	GEN8_DE_PORT_HOTPLUG(HPD_PORT_A)
-#define  BXT_DE_PORT_GMBUS		(1 << 1)
-#define  GEN8_AUX_CHANNEL_A		(1 << 0)
-#define  TGL_DE_PORT_AUX_USBC6		REG_BIT(13)
-#define  XELPD_DE_PORT_AUX_DDIE		REG_BIT(13)
-#define  TGL_DE_PORT_AUX_USBC5		REG_BIT(12)
-#define  XELPD_DE_PORT_AUX_DDID		REG_BIT(12)
-#define  TGL_DE_PORT_AUX_USBC4		REG_BIT(11)
-#define  TGL_DE_PORT_AUX_USBC3		REG_BIT(10)
-#define  TGL_DE_PORT_AUX_USBC2		REG_BIT(9)
-#define  TGL_DE_PORT_AUX_USBC1		REG_BIT(8)
-#define  TGL_DE_PORT_AUX_DDIC		REG_BIT(2)
-#define  TGL_DE_PORT_AUX_DDIB		REG_BIT(1)
-#define  TGL_DE_PORT_AUX_DDIA		REG_BIT(0)
-
-#define GEN8_DE_PORT_IRQ_REGS		I915_IRQ_REGS(GEN8_DE_PORT_IMR, \
-						      GEN8_DE_PORT_IER, \
-						      GEN8_DE_PORT_IIR)
-
 #define GEN8_DE_MISC_ISR _MMIO(0x44460)
 #define GEN8_DE_MISC_IMR _MMIO(0x44464)
 #define GEN8_DE_MISC_IIR _MMIO(0x44468)
@@ -2258,10 +1060,6 @@
 #define  XELPDP_PMDEMAND_RSP		REG_BIT(3)
 #define  XE2LPD_DBUF_OVERLAP_DETECTED	REG_BIT(1)
 
-#define GEN8_DE_MISC_IRQ_REGS		I915_IRQ_REGS(GEN8_DE_MISC_IMR, \
-						      GEN8_DE_MISC_IER, \
-						      GEN8_DE_MISC_IIR)
-
 #define GEN8_PCU_ISR _MMIO(0x444e0)
 #define GEN8_PCU_IMR _MMIO(0x444e4)
 #define GEN8_PCU_IIR _MMIO(0x444e8)
@@ -2294,110 +1092,12 @@
 #define   DG1_MSTR_IRQ			REG_BIT(31)
 #define   DG1_MSTR_TILE(t)		REG_BIT(t)
 
-#define GEN11_DISPLAY_INT_CTL		_MMIO(0x44200)
-#define  GEN11_DISPLAY_IRQ_ENABLE	(1 << 31)
-#define  GEN11_AUDIO_CODEC_IRQ		(1 << 24)
-#define  GEN11_DE_PCH_IRQ		(1 << 23)
-#define  GEN11_DE_MISC_IRQ		(1 << 22)
-#define  GEN11_DE_HPD_IRQ		(1 << 21)
-#define  GEN11_DE_PORT_IRQ		(1 << 20)
-#define  GEN11_DE_PIPE_C		(1 << 18)
-#define  GEN11_DE_PIPE_B		(1 << 17)
-#define  GEN11_DE_PIPE_A		(1 << 16)
-
-#define GEN11_DE_HPD_ISR		_MMIO(0x44470)
-#define GEN11_DE_HPD_IMR		_MMIO(0x44474)
-#define GEN11_DE_HPD_IIR		_MMIO(0x44478)
-#define GEN11_DE_HPD_IER		_MMIO(0x4447c)
-#define  GEN11_TC_HOTPLUG(hpd_pin)		REG_BIT(16 + _HPD_PIN_TC(hpd_pin))
-#define  GEN11_DE_TC_HOTPLUG_MASK		(GEN11_TC_HOTPLUG(HPD_PORT_TC6) | \
-						 GEN11_TC_HOTPLUG(HPD_PORT_TC5) | \
-						 GEN11_TC_HOTPLUG(HPD_PORT_TC4) | \
-						 GEN11_TC_HOTPLUG(HPD_PORT_TC3) | \
-						 GEN11_TC_HOTPLUG(HPD_PORT_TC2) | \
-						 GEN11_TC_HOTPLUG(HPD_PORT_TC1))
-#define  GEN11_TBT_HOTPLUG(hpd_pin)		REG_BIT(_HPD_PIN_TC(hpd_pin))
-#define  GEN11_DE_TBT_HOTPLUG_MASK		(GEN11_TBT_HOTPLUG(HPD_PORT_TC6) | \
-						 GEN11_TBT_HOTPLUG(HPD_PORT_TC5) | \
-						 GEN11_TBT_HOTPLUG(HPD_PORT_TC4) | \
-						 GEN11_TBT_HOTPLUG(HPD_PORT_TC3) | \
-						 GEN11_TBT_HOTPLUG(HPD_PORT_TC2) | \
-						 GEN11_TBT_HOTPLUG(HPD_PORT_TC1))
-
-#define GEN11_DE_HPD_IRQ_REGS		I915_IRQ_REGS(GEN11_DE_HPD_IMR, \
-						      GEN11_DE_HPD_IER, \
-						      GEN11_DE_HPD_IIR)
-
-#define GEN11_TBT_HOTPLUG_CTL				_MMIO(0x44030)
-#define GEN11_TC_HOTPLUG_CTL				_MMIO(0x44038)
-#define  GEN11_HOTPLUG_CTL_ENABLE(hpd_pin)		(8 << (_HPD_PIN_TC(hpd_pin) * 4))
-#define  GEN11_HOTPLUG_CTL_LONG_DETECT(hpd_pin)		(2 << (_HPD_PIN_TC(hpd_pin) * 4))
-#define  GEN11_HOTPLUG_CTL_SHORT_DETECT(hpd_pin)	(1 << (_HPD_PIN_TC(hpd_pin) * 4))
-#define  GEN11_HOTPLUG_CTL_NO_DETECT(hpd_pin)		(0 << (_HPD_PIN_TC(hpd_pin) * 4))
-
-#define PICAINTERRUPT_ISR			_MMIO(0x16FE50)
-#define PICAINTERRUPT_IMR			_MMIO(0x16FE54)
-#define PICAINTERRUPT_IIR			_MMIO(0x16FE58)
-#define PICAINTERRUPT_IER			_MMIO(0x16FE5C)
-#define  XELPDP_DP_ALT_HOTPLUG(hpd_pin)		REG_BIT(16 + _HPD_PIN_TC(hpd_pin))
-#define  XELPDP_DP_ALT_HOTPLUG_MASK		REG_GENMASK(19, 16)
-#define  XELPDP_AUX_TC(hpd_pin)			REG_BIT(8 + _HPD_PIN_TC(hpd_pin))
-#define  XELPDP_AUX_TC_MASK			REG_GENMASK(11, 8)
-#define  XE2LPD_AUX_DDI(hpd_pin)		REG_BIT(6 + _HPD_PIN_DDI(hpd_pin))
-#define  XE2LPD_AUX_DDI_MASK			REG_GENMASK(7, 6)
-#define  XELPDP_TBT_HOTPLUG(hpd_pin)		REG_BIT(_HPD_PIN_TC(hpd_pin))
-#define  XELPDP_TBT_HOTPLUG_MASK		REG_GENMASK(3, 0)
-
-#define PICAINTERRUPT_IRQ_REGS			I915_IRQ_REGS(PICAINTERRUPT_IMR, \
-							      PICAINTERRUPT_IER, \
-							      PICAINTERRUPT_IIR)
-
-#define XELPDP_PORT_HOTPLUG_CTL(hpd_pin)	_MMIO(0x16F270 + (_HPD_PIN_TC(hpd_pin) * 0x200))
-#define  XELPDP_TBT_HOTPLUG_ENABLE		REG_BIT(6)
-#define  XELPDP_TBT_HPD_LONG_DETECT		REG_BIT(5)
-#define  XELPDP_TBT_HPD_SHORT_DETECT		REG_BIT(4)
-#define  XELPDP_DP_ALT_HOTPLUG_ENABLE		REG_BIT(2)
-#define  XELPDP_DP_ALT_HPD_LONG_DETECT		REG_BIT(1)
-#define  XELPDP_DP_ALT_HPD_SHORT_DETECT		REG_BIT(0)
-
-#define XELPDP_INITIATE_PMDEMAND_REQUEST(dword)		_MMIO(0x45230 + 4 * (dword))
-#define  XELPDP_PMDEMAND_QCLK_GV_BW_MASK		REG_GENMASK(31, 16)
-#define  XELPDP_PMDEMAND_VOLTAGE_INDEX_MASK		REG_GENMASK(14, 12)
-#define  XELPDP_PMDEMAND_QCLK_GV_INDEX_MASK		REG_GENMASK(11, 8)
-#define  XE3_PMDEMAND_PIPES_MASK			REG_GENMASK(7, 4)
-#define  XELPDP_PMDEMAND_PIPES_MASK			REG_GENMASK(7, 6)
-#define  XELPDP_PMDEMAND_DBUFS_MASK			REG_GENMASK(5, 4)
-#define  XELPDP_PMDEMAND_PHYS_MASK			REG_GENMASK(2, 0)
-
-#define  XELPDP_PMDEMAND_REQ_ENABLE			REG_BIT(31)
-#define  XELPDP_PMDEMAND_CDCLK_FREQ_MASK		REG_GENMASK(30, 20)
-#define  XELPDP_PMDEMAND_DDICLK_FREQ_MASK		REG_GENMASK(18, 8)
-#define  XELPDP_PMDEMAND_SCALERS_MASK			REG_GENMASK(6, 4)
-#define  XELPDP_PMDEMAND_PLLS_MASK			REG_GENMASK(2, 0)
-
-#define GEN12_DCPR_STATUS_1				_MMIO(0x46440)
-#define  XELPDP_PMDEMAND_INFLIGHT_STATUS		REG_BIT(26)
-
 #define ILK_DISPLAY_CHICKEN2	_MMIO(0x42004)
 /* Required on all Ironlake and Sandybridge according to the B-Spec. */
 #define   ILK_ELPIN_409_SELECT	REG_BIT(25)
 #define   ILK_DPARB_GATE	REG_BIT(22)
 #define   ILK_VSDPFD_FULL	REG_BIT(21)
 
-#define FUSE_STRAP		_MMIO(0x42014)
-#define   ILK_INTERNAL_GRAPHICS_DISABLE	REG_BIT(31)
-#define   ILK_INTERNAL_DISPLAY_DISABLE	REG_BIT(30)
-#define   ILK_DISPLAY_DEBUG_DISABLE	REG_BIT(29)
-#define   IVB_PIPE_C_DISABLE		REG_BIT(28)
-#define   ILK_HDCP_DISABLE		REG_BIT(25)
-#define   ILK_eDP_A_DISABLE		REG_BIT(24)
-#define   HSW_CDCLK_LIMIT		REG_BIT(24)
-#define   ILK_DESKTOP			REG_BIT(23)
-#define   HSW_CPU_SSC_ENABLE		REG_BIT(21)
-
-#define FUSE_STRAP3		_MMIO(0x42020)
-#define   HSW_REF_CLK_SELECT		REG_BIT(1)
-
 #define ILK_DSPCLK_GATE_D	_MMIO(0x42020)
 #define   ILK_VRHUNIT_CLOCK_GATE_DISABLE	REG_BIT(28)
 #define   ILK_DPFCUNIT_CLOCK_GATE_DISABLE	REG_BIT(9)
@@ -2422,25 +1122,6 @@
 #define CHICKEN_PAR2_1		_MMIO(0x42090)
 #define   KVM_CONFIG_CHANGE_NOTIFICATION_SELECT	REG_BIT(14)
 
-#define CHICKEN_MISC_2		_MMIO(0x42084)
-#define   CHICKEN_MISC_DISABLE_DPT	REG_BIT(30) /* adl,dg2 */
-#define   BMG_DARB_HALF_BLK_END_BURST	REG_BIT(27)
-#define   KBL_ARB_FILL_SPARE_14		REG_BIT(14)
-#define   KBL_ARB_FILL_SPARE_13		REG_BIT(13)
-#define   GLK_CL2_PWR_DOWN		REG_BIT(12)
-#define   GLK_CL1_PWR_DOWN		REG_BIT(11)
-#define   GLK_CL0_PWR_DOWN		REG_BIT(10)
-
-#define CHICKEN_MISC_3		_MMIO(0x42088)
-#define   DP_MST_DPT_DPTP_ALIGN_WA(trans)	REG_BIT(9 + (trans) - TRANSCODER_A)
-#define   DP_MST_SHORT_HBLANK_WA(trans)		REG_BIT(5 + (trans) - TRANSCODER_A)
-#define   DP_MST_FEC_BS_JITTER_WA(trans)	REG_BIT(0 + (trans) - TRANSCODER_A)
-
-#define CHICKEN_MISC_4		_MMIO(0x4208c)
-#define   CHICKEN_FBC_STRIDE_OVERRIDE	REG_BIT(13)
-#define   CHICKEN_FBC_STRIDE_MASK	REG_GENMASK(12, 0)
-#define   CHICKEN_FBC_STRIDE(x)		REG_FIELD_PREP(CHICKEN_FBC_STRIDE_MASK, (x))
-
 #define _CHICKEN_PIPESL_1_A	0x420b0
 #define _CHICKEN_PIPESL_1_B	0x420b4
 #define CHICKEN_PIPESL_1(pipe)	_MMIO_PIPE(pipe, _CHICKEN_PIPESL_1_A, _CHICKEN_PIPESL_1_B)
@@ -2464,72 +1145,11 @@
 #define   SKL_PLANE1_STRETCH_MAX_X1	REG_FIELD_PREP(SKL_PLANE1_STRETCH_MAX_MASK, 3)
 #define   BDW_UNMASK_VBL_TO_REGS_IN_SRD	REG_BIT(0) /* bdw */
 
-#define _CHICKEN_TRANS_A	0x420c0
-#define _CHICKEN_TRANS_B	0x420c4
-#define _CHICKEN_TRANS_C	0x420c8
-#define _CHICKEN_TRANS_EDP	0x420cc
-#define _CHICKEN_TRANS_D	0x420d8
-#define _CHICKEN_TRANS(trans)	_MMIO(_PICK((trans), \
-					    [TRANSCODER_EDP] = _CHICKEN_TRANS_EDP, \
-					    [TRANSCODER_A] = _CHICKEN_TRANS_A, \
-					    [TRANSCODER_B] = _CHICKEN_TRANS_B, \
-					    [TRANSCODER_C] = _CHICKEN_TRANS_C, \
-					    [TRANSCODER_D] = _CHICKEN_TRANS_D))
-#define _MTL_CHICKEN_TRANS_A	0x604e0
-#define _MTL_CHICKEN_TRANS_B	0x614e0
-#define _MTL_CHICKEN_TRANS(trans)	_MMIO_TRANS((trans), \
-						    _MTL_CHICKEN_TRANS_A, \
-						    _MTL_CHICKEN_TRANS_B)
-#define CHICKEN_TRANS(display, trans)	(DISPLAY_VER(display) >= 14 ? _MTL_CHICKEN_TRANS(trans) : _CHICKEN_TRANS(trans))
-#define   PIPE_VBLANK_WITH_DELAY	REG_BIT(31) /* tgl+ */
-#define   SKL_UNMASK_VBL_TO_PIPE_IN_SRD	REG_BIT(30) /* skl+ */
-#define   HSW_FRAME_START_DELAY_MASK	REG_GENMASK(28, 27)
-#define   HSW_FRAME_START_DELAY(x)	REG_FIELD_PREP(HSW_FRAME_START_DELAY_MASK, x)
-#define   VSC_DATA_SEL_SOFTWARE_CONTROL	REG_BIT(25) /* GLK */
-#define   FECSTALL_DIS_DPTSTREAM_DPTTG	REG_BIT(23)
-#define   DDI_TRAINING_OVERRIDE_ENABLE	REG_BIT(19)
-#define   ADLP_1_BASED_X_GRANULARITY	REG_BIT(18)
-#define   DDI_TRAINING_OVERRIDE_VALUE	REG_BIT(18)
-#define   DDIE_TRAINING_OVERRIDE_ENABLE	REG_BIT(17) /* CHICKEN_TRANS_A only */
-#define   DDIE_TRAINING_OVERRIDE_VALUE	REG_BIT(16) /* CHICKEN_TRANS_A only */
-#define   PSR2_ADD_VERTICAL_LINE_COUNT	REG_BIT(15)
-#define   DP_FEC_BS_JITTER_WA		REG_BIT(15)
-#define   PSR2_VSC_ENABLE_PROG_HEADER	REG_BIT(12)
-#define   DP_DSC_INSERT_SF_AT_EOL_WA	REG_BIT(4)
-#define   HDCP_LINE_REKEY_DISABLE	REG_BIT(0)
-
 #define DISP_ARB_CTL	_MMIO(0x45000)
 #define   DISP_FBC_MEMORY_WAKE		REG_BIT(31)
 #define   DISP_TILE_SURFACE_SWIZZLING	REG_BIT(13)
 #define   DISP_FBC_WM_DIS		REG_BIT(15)
 
-#define DISP_ARB_CTL2	_MMIO(0x45004)
-#define   DISP_DATA_PARTITION_5_6	REG_BIT(6)
-#define   DISP_IPC_ENABLE		REG_BIT(3)
-
-#define GEN7_MSG_CTL	_MMIO(0x45010)
-#define  WAIT_FOR_PCH_RESET_ACK		(1 << 1)
-#define  WAIT_FOR_PCH_FLR_ACK		(1 << 0)
-
-#define _BW_BUDDY0_CTL			0x45130
-#define _BW_BUDDY1_CTL			0x45140
-#define BW_BUDDY_CTL(x)			_MMIO(_PICK_EVEN(x, \
-							 _BW_BUDDY0_CTL, \
-							 _BW_BUDDY1_CTL))
-#define   BW_BUDDY_DISABLE		REG_BIT(31)
-#define   BW_BUDDY_TLB_REQ_TIMER_MASK	REG_GENMASK(21, 16)
-#define   BW_BUDDY_TLB_REQ_TIMER(x)	REG_FIELD_PREP(BW_BUDDY_TLB_REQ_TIMER_MASK, x)
-
-#define _BW_BUDDY0_PAGE_MASK		0x45134
-#define _BW_BUDDY1_PAGE_MASK		0x45144
-#define BW_BUDDY_PAGE_MASK(x)		_MMIO(_PICK_EVEN(x, \
-							 _BW_BUDDY0_PAGE_MASK, \
-							 _BW_BUDDY1_PAGE_MASK))
-
-#define HSW_NDE_RSTWRN_OPT	_MMIO(0x46408)
-#define  MTL_RESET_PICA_HANDSHAKE_EN	REG_BIT(6)
-#define  RESET_PCH_HANDSHAKE_ENABLE	REG_BIT(4)
-
 #define GEN8_CHICKEN_DCPR_1			_MMIO(0x46430)
 #define   _LATENCY_REPORTING_REMOVED_PIPE_D	REG_BIT(31)
 #define   SKL_SELECT_ALTERNATE_DC_EXIT		REG_BIT(30)
@@ -2546,171 +1166,13 @@
 #define   MASK_WAKEMEM				REG_BIT(13)
 #define   DDI_CLOCK_REG_ACCESS			REG_BIT(7)
 
-#define GEN11_CHICKEN_DCPR_2			_MMIO(0x46434)
-#define   DCPR_MASK_MAXLATENCY_MEMUP_CLR	REG_BIT(27)
-#define   DCPR_MASK_LPMODE			REG_BIT(26)
-#define   DCPR_SEND_RESP_IMM			REG_BIT(25)
-#define   DCPR_CLEAR_MEMSTAT_DIS		REG_BIT(24)
-
-#define XELPD_CHICKEN_DCPR_3			_MMIO(0x46438)
-#define   DMD_RSP_TIMEOUT_DISABLE		REG_BIT(19)
-
-#define SKL_DFSM			_MMIO(0x51000)
-#define   SKL_DFSM_DISPLAY_PM_DISABLE	(1 << 27)
-#define   SKL_DFSM_DISPLAY_HDCP_DISABLE	(1 << 25)
-#define   SKL_DFSM_CDCLK_LIMIT_MASK	(3 << 23)
-#define   SKL_DFSM_CDCLK_LIMIT_675	(0 << 23)
-#define   SKL_DFSM_CDCLK_LIMIT_540	(1 << 23)
-#define   SKL_DFSM_CDCLK_LIMIT_450	(2 << 23)
-#define   SKL_DFSM_CDCLK_LIMIT_337_5	(3 << 23)
-#define   ICL_DFSM_DMC_DISABLE		(1 << 23)
-#define   SKL_DFSM_PIPE_A_DISABLE	(1 << 30)
-#define   SKL_DFSM_PIPE_B_DISABLE	(1 << 21)
-#define   SKL_DFSM_PIPE_C_DISABLE	(1 << 28)
-#define   TGL_DFSM_PIPE_D_DISABLE	(1 << 22)
-#define   GLK_DFSM_DISPLAY_DSC_DISABLE	(1 << 7)
-#define   XE2LPD_DFSM_DBUF_OVERLAP_DISABLE	(1 << 3)
-
-#define XE2LPD_DE_CAP			_MMIO(0x41100)
-#define   XE2LPD_DE_CAP_3DLUT_MASK	REG_GENMASK(31, 30)
-#define   XE2LPD_DE_CAP_DSC_MASK	REG_GENMASK(29, 28)
-#define   XE2LPD_DE_CAP_DSC_REMOVED	1
-#define   XE2LPD_DE_CAP_SCALER_MASK	REG_GENMASK(27, 26)
-#define   XE2LPD_DE_CAP_SCALER_SINGLE	1
-
-#define SKL_DSSM				_MMIO(0x51004)
-#define ICL_DSSM_CDCLK_PLL_REFCLK_MASK		(7 << 29)
-#define ICL_DSSM_CDCLK_PLL_REFCLK_24MHz		(0 << 29)
-#define ICL_DSSM_CDCLK_PLL_REFCLK_19_2MHz	(1 << 29)
-#define ICL_DSSM_CDCLK_PLL_REFCLK_38_4MHz	(2 << 29)
-
 #define GMD_ID_DISPLAY				_MMIO(0x510a0)
 #define   GMD_ID_ARCH_MASK			REG_GENMASK(31, 22)
 #define   GMD_ID_RELEASE_MASK			REG_GENMASK(21, 14)
 #define   GMD_ID_STEP				REG_GENMASK(5, 0)
 
-/*GEN11 chicken */
-#define _PIPEA_CHICKEN				0x70038
-#define _PIPEB_CHICKEN				0x71038
-#define _PIPEC_CHICKEN				0x72038
-#define PIPE_CHICKEN(pipe)			_MMIO_PIPE(pipe, _PIPEA_CHICKEN,\
-							   _PIPEB_CHICKEN)
-#define   UNDERRUN_RECOVERY_DISABLE_ADLP	REG_BIT(30)
-#define   UNDERRUN_RECOVERY_ENABLE_DG2		REG_BIT(30)
-#define   PIXEL_ROUNDING_TRUNC_FB_PASSTHRU	REG_BIT(15)
-#define   DG2_RENDER_CCSTAG_4_3_EN		REG_BIT(12)
-#define   PER_PIXEL_ALPHA_BYPASS_EN		REG_BIT(7)
-
 /* PCH */
 
-#define PCH_DISPLAY_BASE	0xc0000u
-
-/* south display engine interrupt: IBX */
-#define SDE_AUDIO_POWER_D	(1 << 27)
-#define SDE_AUDIO_POWER_C	(1 << 26)
-#define SDE_AUDIO_POWER_B	(1 << 25)
-#define SDE_AUDIO_POWER_SHIFT	(25)
-#define SDE_AUDIO_POWER_MASK	(7 << SDE_AUDIO_POWER_SHIFT)
-#define SDE_GMBUS		(1 << 24)
-#define SDE_AUDIO_HDCP_TRANSB	(1 << 23)
-#define SDE_AUDIO_HDCP_TRANSA	(1 << 22)
-#define SDE_AUDIO_HDCP_MASK	(3 << 22)
-#define SDE_AUDIO_TRANSB	(1 << 21)
-#define SDE_AUDIO_TRANSA	(1 << 20)
-#define SDE_AUDIO_TRANS_MASK	(3 << 20)
-#define SDE_POISON		(1 << 19)
-/* 18 reserved */
-#define SDE_FDI_RXB		(1 << 17)
-#define SDE_FDI_RXA		(1 << 16)
-#define SDE_FDI_MASK		(3 << 16)
-#define SDE_AUXD		(1 << 15)
-#define SDE_AUXC		(1 << 14)
-#define SDE_AUXB		(1 << 13)
-#define SDE_AUX_MASK		(7 << 13)
-/* 12 reserved */
-#define SDE_CRT_HOTPLUG         (1 << 11)
-#define SDE_PORTD_HOTPLUG       (1 << 10)
-#define SDE_PORTC_HOTPLUG       (1 << 9)
-#define SDE_PORTB_HOTPLUG       (1 << 8)
-#define SDE_SDVOB_HOTPLUG       (1 << 6)
-#define SDE_HOTPLUG_MASK        (SDE_CRT_HOTPLUG | \
-				 SDE_SDVOB_HOTPLUG |	\
-				 SDE_PORTB_HOTPLUG |	\
-				 SDE_PORTC_HOTPLUG |	\
-				 SDE_PORTD_HOTPLUG)
-#define SDE_TRANSB_CRC_DONE	(1 << 5)
-#define SDE_TRANSB_CRC_ERR	(1 << 4)
-#define SDE_TRANSB_FIFO_UNDER	(1 << 3)
-#define SDE_TRANSA_CRC_DONE	(1 << 2)
-#define SDE_TRANSA_CRC_ERR	(1 << 1)
-#define SDE_TRANSA_FIFO_UNDER	(1 << 0)
-#define SDE_TRANS_MASK		(0x3f)
-
-/* south display engine interrupt: CPT - CNP */
-#define SDE_AUDIO_POWER_D_CPT	(1 << 31)
-#define SDE_AUDIO_POWER_C_CPT	(1 << 30)
-#define SDE_AUDIO_POWER_B_CPT	(1 << 29)
-#define SDE_AUDIO_POWER_SHIFT_CPT   29
-#define SDE_AUDIO_POWER_MASK_CPT    (7 << 29)
-#define SDE_AUXD_CPT		(1 << 27)
-#define SDE_AUXC_CPT		(1 << 26)
-#define SDE_AUXB_CPT		(1 << 25)
-#define SDE_AUX_MASK_CPT	(7 << 25)
-#define SDE_PORTE_HOTPLUG_SPT	(1 << 25)
-#define SDE_PORTA_HOTPLUG_SPT	(1 << 24)
-#define SDE_PORTD_HOTPLUG_CPT	(1 << 23)
-#define SDE_PORTC_HOTPLUG_CPT	(1 << 22)
-#define SDE_PORTB_HOTPLUG_CPT	(1 << 21)
-#define SDE_CRT_HOTPLUG_CPT	(1 << 19)
-#define SDE_SDVOB_HOTPLUG_CPT	(1 << 18)
-#define SDE_HOTPLUG_MASK_CPT	(SDE_CRT_HOTPLUG_CPT |		\
-				 SDE_SDVOB_HOTPLUG_CPT |	\
-				 SDE_PORTD_HOTPLUG_CPT |	\
-				 SDE_PORTC_HOTPLUG_CPT |	\
-				 SDE_PORTB_HOTPLUG_CPT)
-#define SDE_HOTPLUG_MASK_SPT	(SDE_PORTE_HOTPLUG_SPT |	\
-				 SDE_PORTD_HOTPLUG_CPT |	\
-				 SDE_PORTC_HOTPLUG_CPT |	\
-				 SDE_PORTB_HOTPLUG_CPT |	\
-				 SDE_PORTA_HOTPLUG_SPT)
-#define SDE_GMBUS_CPT		(1 << 17)
-#define SDE_ERROR_CPT		(1 << 16)
-#define SDE_AUDIO_CP_REQ_C_CPT	(1 << 10)
-#define SDE_AUDIO_CP_CHG_C_CPT	(1 << 9)
-#define SDE_FDI_RXC_CPT		(1 << 8)
-#define SDE_AUDIO_CP_REQ_B_CPT	(1 << 6)
-#define SDE_AUDIO_CP_CHG_B_CPT	(1 << 5)
-#define SDE_FDI_RXB_CPT		(1 << 4)
-#define SDE_AUDIO_CP_REQ_A_CPT	(1 << 2)
-#define SDE_AUDIO_CP_CHG_A_CPT	(1 << 1)
-#define SDE_FDI_RXA_CPT		(1 << 0)
-#define SDE_AUDIO_CP_REQ_CPT	(SDE_AUDIO_CP_REQ_C_CPT | \
-				 SDE_AUDIO_CP_REQ_B_CPT | \
-				 SDE_AUDIO_CP_REQ_A_CPT)
-#define SDE_AUDIO_CP_CHG_CPT	(SDE_AUDIO_CP_CHG_C_CPT | \
-				 SDE_AUDIO_CP_CHG_B_CPT | \
-				 SDE_AUDIO_CP_CHG_A_CPT)
-#define SDE_FDI_MASK_CPT	(SDE_FDI_RXC_CPT | \
-				 SDE_FDI_RXB_CPT | \
-				 SDE_FDI_RXA_CPT)
-
-/* south display engine interrupt: ICP/TGP/MTP */
-#define SDE_PICAINTERRUPT		REG_BIT(31)
-#define SDE_GMBUS_ICP			(1 << 23)
-#define SDE_TC_HOTPLUG_ICP(hpd_pin)	REG_BIT(24 + _HPD_PIN_TC(hpd_pin))
-#define SDE_TC_HOTPLUG_DG2(hpd_pin)	REG_BIT(25 + _HPD_PIN_TC(hpd_pin)) /* sigh */
-#define SDE_DDI_HOTPLUG_ICP(hpd_pin)	REG_BIT(16 + _HPD_PIN_DDI(hpd_pin))
-#define SDE_DDI_HOTPLUG_MASK_ICP	(SDE_DDI_HOTPLUG_ICP(HPD_PORT_D) | \
-					 SDE_DDI_HOTPLUG_ICP(HPD_PORT_C) | \
-					 SDE_DDI_HOTPLUG_ICP(HPD_PORT_B) | \
-					 SDE_DDI_HOTPLUG_ICP(HPD_PORT_A))
-#define SDE_TC_HOTPLUG_MASK_ICP		(SDE_TC_HOTPLUG_ICP(HPD_PORT_TC6) | \
-					 SDE_TC_HOTPLUG_ICP(HPD_PORT_TC5) | \
-					 SDE_TC_HOTPLUG_ICP(HPD_PORT_TC4) | \
-					 SDE_TC_HOTPLUG_ICP(HPD_PORT_TC3) | \
-					 SDE_TC_HOTPLUG_ICP(HPD_PORT_TC2) | \
-					 SDE_TC_HOTPLUG_ICP(HPD_PORT_TC1))
-
 #define SDEISR  _MMIO(0xc4000)
 #define SDEIMR  _MMIO(0xc4004)
 #define SDEIIR  _MMIO(0xc4008)
@@ -2724,288 +1186,13 @@
 #define  SERR_INT_POISON		(1 << 31)
 #define  SERR_INT_TRANS_FIFO_UNDERRUN(pipe)	(1 << ((pipe) * 3))
 
-/* digital port hotplug */
-#define PCH_PORT_HOTPLUG		_MMIO(0xc4030)	/* SHOTPLUG_CTL */
-#define  PORTA_HOTPLUG_ENABLE		(1 << 28) /* LPT:LP+ & BXT */
-#define  BXT_DDIA_HPD_INVERT            (1 << 27)
-#define  PORTA_HOTPLUG_STATUS_MASK	(3 << 24) /* SPT+ & BXT */
-#define  PORTA_HOTPLUG_NO_DETECT	(0 << 24) /* SPT+ & BXT */
-#define  PORTA_HOTPLUG_SHORT_DETECT	(1 << 24) /* SPT+ & BXT */
-#define  PORTA_HOTPLUG_LONG_DETECT	(2 << 24) /* SPT+ & BXT */
-#define  PORTD_HOTPLUG_ENABLE		(1 << 20)
-#define  PORTD_PULSE_DURATION_2ms	(0 << 18) /* pre-LPT */
-#define  PORTD_PULSE_DURATION_4_5ms	(1 << 18) /* pre-LPT */
-#define  PORTD_PULSE_DURATION_6ms	(2 << 18) /* pre-LPT */
-#define  PORTD_PULSE_DURATION_100ms	(3 << 18) /* pre-LPT */
-#define  PORTD_PULSE_DURATION_MASK	(3 << 18) /* pre-LPT */
-#define  PORTD_HOTPLUG_STATUS_MASK	(3 << 16)
-#define  PORTD_HOTPLUG_NO_DETECT	(0 << 16)
-#define  PORTD_HOTPLUG_SHORT_DETECT	(1 << 16)
-#define  PORTD_HOTPLUG_LONG_DETECT	(2 << 16)
-#define  PORTC_HOTPLUG_ENABLE		(1 << 12)
-#define  BXT_DDIC_HPD_INVERT            (1 << 11)
-#define  PORTC_PULSE_DURATION_2ms	(0 << 10) /* pre-LPT */
-#define  PORTC_PULSE_DURATION_4_5ms	(1 << 10) /* pre-LPT */
-#define  PORTC_PULSE_DURATION_6ms	(2 << 10) /* pre-LPT */
-#define  PORTC_PULSE_DURATION_100ms	(3 << 10) /* pre-LPT */
-#define  PORTC_PULSE_DURATION_MASK	(3 << 10) /* pre-LPT */
-#define  PORTC_HOTPLUG_STATUS_MASK	(3 << 8)
-#define  PORTC_HOTPLUG_NO_DETECT	(0 << 8)
-#define  PORTC_HOTPLUG_SHORT_DETECT	(1 << 8)
-#define  PORTC_HOTPLUG_LONG_DETECT	(2 << 8)
-#define  PORTB_HOTPLUG_ENABLE		(1 << 4)
-#define  BXT_DDIB_HPD_INVERT            (1 << 3)
-#define  PORTB_PULSE_DURATION_2ms	(0 << 2) /* pre-LPT */
-#define  PORTB_PULSE_DURATION_4_5ms	(1 << 2) /* pre-LPT */
-#define  PORTB_PULSE_DURATION_6ms	(2 << 2) /* pre-LPT */
-#define  PORTB_PULSE_DURATION_100ms	(3 << 2) /* pre-LPT */
-#define  PORTB_PULSE_DURATION_MASK	(3 << 2) /* pre-LPT */
-#define  PORTB_HOTPLUG_STATUS_MASK	(3 << 0)
-#define  PORTB_HOTPLUG_NO_DETECT	(0 << 0)
-#define  PORTB_HOTPLUG_SHORT_DETECT	(1 << 0)
-#define  PORTB_HOTPLUG_LONG_DETECT	(2 << 0)
-#define  BXT_DDI_HPD_INVERT_MASK	(BXT_DDIA_HPD_INVERT | \
-					BXT_DDIB_HPD_INVERT | \
-					BXT_DDIC_HPD_INVERT)
-
-#define PCH_PORT_HOTPLUG2		_MMIO(0xc403C)	/* SHOTPLUG_CTL2 SPT+ */
-#define  PORTE_HOTPLUG_ENABLE		(1 << 4)
-#define  PORTE_HOTPLUG_STATUS_MASK	(3 << 0)
-#define  PORTE_HOTPLUG_NO_DETECT	(0 << 0)
-#define  PORTE_HOTPLUG_SHORT_DETECT	(1 << 0)
-#define  PORTE_HOTPLUG_LONG_DETECT	(2 << 0)
-
-/* This register is a reuse of PCH_PORT_HOTPLUG register. The
- * functionality covered in PCH_PORT_HOTPLUG is split into
- * SHOTPLUG_CTL_DDI and SHOTPLUG_CTL_TC.
- */
-#define SHOTPLUG_CTL_DDI				_MMIO(0xc4030)
-#define   SHOTPLUG_CTL_DDI_HPD_ENABLE(hpd_pin)			(0x8 << (_HPD_PIN_DDI(hpd_pin) * 4))
-#define   SHOTPLUG_CTL_DDI_HPD_OUTPUT_DATA(hpd_pin)		(0x4 << (_HPD_PIN_DDI(hpd_pin) * 4))
-#define   SHOTPLUG_CTL_DDI_HPD_STATUS_MASK(hpd_pin)		(0x3 << (_HPD_PIN_DDI(hpd_pin) * 4))
-#define   SHOTPLUG_CTL_DDI_HPD_NO_DETECT(hpd_pin)		(0x0 << (_HPD_PIN_DDI(hpd_pin) * 4))
-#define   SHOTPLUG_CTL_DDI_HPD_SHORT_DETECT(hpd_pin)		(0x1 << (_HPD_PIN_DDI(hpd_pin) * 4))
-#define   SHOTPLUG_CTL_DDI_HPD_LONG_DETECT(hpd_pin)		(0x2 << (_HPD_PIN_DDI(hpd_pin) * 4))
-#define   SHOTPLUG_CTL_DDI_HPD_SHORT_LONG_DETECT(hpd_pin)	(0x3 << (_HPD_PIN_DDI(hpd_pin) * 4))
-
-#define SHOTPLUG_CTL_TC				_MMIO(0xc4034)
-#define   ICP_TC_HPD_ENABLE(hpd_pin)		(8 << (_HPD_PIN_TC(hpd_pin) * 4))
-#define   ICP_TC_HPD_LONG_DETECT(hpd_pin)	(2 << (_HPD_PIN_TC(hpd_pin) * 4))
-#define   ICP_TC_HPD_SHORT_DETECT(hpd_pin)	(1 << (_HPD_PIN_TC(hpd_pin) * 4))
-
-#define SHPD_FILTER_CNT				_MMIO(0xc4038)
-#define   SHPD_FILTER_CNT_500_ADJ		0x001D9
-#define   SHPD_FILTER_CNT_250			0x000F8
-
-#define _PCH_DPLL_A              0xc6014
-#define _PCH_DPLL_B              0xc6018
-#define PCH_DPLL(pll) _MMIO((pll) == 0 ? _PCH_DPLL_A : _PCH_DPLL_B)
-
-#define _PCH_FPA0                0xc6040
-#define _PCH_FPB0                0xc6048
-#define PCH_FP0(pll) _MMIO((pll) == 0 ? _PCH_FPA0 : _PCH_FPB0)
-#define  FP_CB_TUNE		(0x3 << 22)
-
-#define _PCH_FPA1                0xc6044
-#define _PCH_FPB1                0xc604c
-#define PCH_FP1(pll) _MMIO((pll) == 0 ? _PCH_FPA1 : _PCH_FPB1)
-
 #define PCH_DPLL_TEST           _MMIO(0xc606c)
 
-#define PCH_DREF_CONTROL        _MMIO(0xC6200)
-#define  DREF_CONTROL_MASK      0x7fc3
-#define  DREF_CPU_SOURCE_OUTPUT_DISABLE         (0 << 13)
-#define  DREF_CPU_SOURCE_OUTPUT_DOWNSPREAD      (2 << 13)
-#define  DREF_CPU_SOURCE_OUTPUT_NONSPREAD       (3 << 13)
-#define  DREF_CPU_SOURCE_OUTPUT_MASK		(3 << 13)
-#define  DREF_SSC_SOURCE_DISABLE                (0 << 11)
-#define  DREF_SSC_SOURCE_ENABLE                 (2 << 11)
-#define  DREF_SSC_SOURCE_MASK			(3 << 11)
-#define  DREF_NONSPREAD_SOURCE_DISABLE          (0 << 9)
-#define  DREF_NONSPREAD_CK505_ENABLE		(1 << 9)
-#define  DREF_NONSPREAD_SOURCE_ENABLE           (2 << 9)
-#define  DREF_NONSPREAD_SOURCE_MASK		(3 << 9)
-#define  DREF_SUPERSPREAD_SOURCE_DISABLE        (0 << 7)
-#define  DREF_SUPERSPREAD_SOURCE_ENABLE         (2 << 7)
-#define  DREF_SUPERSPREAD_SOURCE_MASK		(3 << 7)
-#define  DREF_SSC4_DOWNSPREAD                   (0 << 6)
-#define  DREF_SSC4_CENTERSPREAD                 (1 << 6)
-#define  DREF_SSC1_DISABLE                      (0 << 1)
-#define  DREF_SSC1_ENABLE                       (1 << 1)
-#define  DREF_SSC4_DISABLE                      (0)
-#define  DREF_SSC4_ENABLE                       (1)
-
-#define PCH_RAWCLK_FREQ         _MMIO(0xc6204)
-#define  FDL_TP1_TIMER_SHIFT    12
-#define  FDL_TP1_TIMER_MASK     (3 << 12)
-#define  FDL_TP2_TIMER_SHIFT    10
-#define  FDL_TP2_TIMER_MASK     (3 << 10)
-#define  RAWCLK_FREQ_MASK       0x3ff
-#define  CNP_RAWCLK_DIV_MASK	(0x3ff << 16)
-#define  CNP_RAWCLK_DIV(div)	((div) << 16)
-#define  CNP_RAWCLK_FRAC_MASK	(0xf << 26)
-#define  CNP_RAWCLK_DEN(den)	((den) << 26)
-#define  ICP_RAWCLK_NUM(num)	((num) << 11)
-
 #define PCH_DPLL_TMR_CFG        _MMIO(0xc6208)
 
 #define PCH_SSC4_PARMS          _MMIO(0xc6210)
 #define PCH_SSC4_AUX_PARMS      _MMIO(0xc6214)
 
-#define PCH_DPLL_SEL		_MMIO(0xc7000)
-#define	 TRANS_DPLLB_SEL(pipe)		(1 << ((pipe) * 4))
-#define	 TRANS_DPLLA_SEL(pipe)		0
-#define  TRANS_DPLL_ENABLE(pipe)	(1 << ((pipe) * 4 + 3))
-
-/* transcoder */
-#define _PCH_TRANS_HTOTAL_A		0xe0000
-#define _PCH_TRANS_HTOTAL_B		0xe1000
-#define PCH_TRANS_HTOTAL(pipe)		_MMIO_PIPE(pipe, _PCH_TRANS_HTOTAL_A, _PCH_TRANS_HTOTAL_B)
-#define  TRANS_HTOTAL_SHIFT		16
-#define  TRANS_HACTIVE_SHIFT		0
-
-#define _PCH_TRANS_HBLANK_A		0xe0004
-#define _PCH_TRANS_HBLANK_B		0xe1004
-#define PCH_TRANS_HBLANK(pipe)		_MMIO_PIPE(pipe, _PCH_TRANS_HBLANK_A, _PCH_TRANS_HBLANK_B)
-#define  TRANS_HBLANK_END_SHIFT		16
-#define  TRANS_HBLANK_START_SHIFT	0
-
-#define _PCH_TRANS_HSYNC_A		0xe0008
-#define _PCH_TRANS_HSYNC_B		0xe1008
-#define PCH_TRANS_HSYNC(pipe)		_MMIO_PIPE(pipe, _PCH_TRANS_HSYNC_A, _PCH_TRANS_HSYNC_B)
-#define  TRANS_HSYNC_END_SHIFT		16
-#define  TRANS_HSYNC_START_SHIFT	0
-
-#define _PCH_TRANS_VTOTAL_A		0xe000c
-#define _PCH_TRANS_VTOTAL_B		0xe100c
-#define PCH_TRANS_VTOTAL(pipe)		_MMIO_PIPE(pipe, _PCH_TRANS_VTOTAL_A, _PCH_TRANS_VTOTAL_B)
-#define  TRANS_VTOTAL_SHIFT		16
-#define  TRANS_VACTIVE_SHIFT		0
-
-#define _PCH_TRANS_VBLANK_A		0xe0010
-#define _PCH_TRANS_VBLANK_B		0xe1010
-#define PCH_TRANS_VBLANK(pipe)		_MMIO_PIPE(pipe, _PCH_TRANS_VBLANK_A, _PCH_TRANS_VBLANK_B)
-#define  TRANS_VBLANK_END_SHIFT		16
-#define  TRANS_VBLANK_START_SHIFT	0
-
-#define _PCH_TRANS_VSYNC_A		0xe0014
-#define _PCH_TRANS_VSYNC_B		0xe1014
-#define PCH_TRANS_VSYNC(pipe)		_MMIO_PIPE(pipe, _PCH_TRANS_VSYNC_A, _PCH_TRANS_VSYNC_B)
-#define  TRANS_VSYNC_END_SHIFT		16
-#define  TRANS_VSYNC_START_SHIFT	0
-
-#define _PCH_TRANS_VSYNCSHIFT_A		0xe0028
-#define _PCH_TRANS_VSYNCSHIFT_B		0xe1028
-#define PCH_TRANS_VSYNCSHIFT(pipe)	_MMIO_PIPE(pipe, _PCH_TRANS_VSYNCSHIFT_A, _PCH_TRANS_VSYNCSHIFT_B)
-
-#define _PCH_TRANSA_DATA_M1	0xe0030
-#define _PCH_TRANSB_DATA_M1	0xe1030
-#define PCH_TRANS_DATA_M1(pipe)	_MMIO_PIPE(pipe, _PCH_TRANSA_DATA_M1, _PCH_TRANSB_DATA_M1)
-
-#define _PCH_TRANSA_DATA_N1	0xe0034
-#define _PCH_TRANSB_DATA_N1	0xe1034
-#define PCH_TRANS_DATA_N1(pipe)	_MMIO_PIPE(pipe, _PCH_TRANSA_DATA_N1, _PCH_TRANSB_DATA_N1)
-
-#define _PCH_TRANSA_DATA_M2	0xe0038
-#define _PCH_TRANSB_DATA_M2	0xe1038
-#define PCH_TRANS_DATA_M2(pipe)	_MMIO_PIPE(pipe, _PCH_TRANSA_DATA_M2, _PCH_TRANSB_DATA_M2)
-
-#define _PCH_TRANSA_DATA_N2	0xe003c
-#define _PCH_TRANSB_DATA_N2	0xe103c
-#define PCH_TRANS_DATA_N2(pipe)	_MMIO_PIPE(pipe, _PCH_TRANSA_DATA_N2, _PCH_TRANSB_DATA_N2)
-
-#define _PCH_TRANSA_LINK_M1	0xe0040
-#define _PCH_TRANSB_LINK_M1	0xe1040
-#define PCH_TRANS_LINK_M1(pipe)	_MMIO_PIPE(pipe, _PCH_TRANSA_LINK_M1, _PCH_TRANSB_LINK_M1)
-
-#define _PCH_TRANSA_LINK_N1	0xe0044
-#define _PCH_TRANSB_LINK_N1	0xe1044
-#define PCH_TRANS_LINK_N1(pipe)	_MMIO_PIPE(pipe, _PCH_TRANSA_LINK_N1, _PCH_TRANSB_LINK_N1)
-
-#define _PCH_TRANSA_LINK_M2	0xe0048
-#define _PCH_TRANSB_LINK_M2	0xe1048
-#define PCH_TRANS_LINK_M2(pipe)	_MMIO_PIPE(pipe, _PCH_TRANSA_LINK_M2, _PCH_TRANSB_LINK_M2)
-
-#define _PCH_TRANSA_LINK_N2	0xe004c
-#define _PCH_TRANSB_LINK_N2	0xe104c
-#define PCH_TRANS_LINK_N2(pipe)	_MMIO_PIPE(pipe, _PCH_TRANSA_LINK_N2, _PCH_TRANSB_LINK_N2)
-
-/* Per-transcoder DIP controls (PCH) */
-#define _VIDEO_DIP_CTL_A         0xe0200
-#define _VIDEO_DIP_CTL_B         0xe1200
-#define TVIDEO_DIP_CTL(pipe) _MMIO_PIPE(pipe, _VIDEO_DIP_CTL_A, _VIDEO_DIP_CTL_B)
-
-#define _VIDEO_DIP_DATA_A        0xe0208
-#define _VIDEO_DIP_DATA_B        0xe1208
-#define TVIDEO_DIP_DATA(pipe) _MMIO_PIPE(pipe, _VIDEO_DIP_DATA_A, _VIDEO_DIP_DATA_B)
-
-#define _VIDEO_DIP_GCP_A         0xe0210
-#define _VIDEO_DIP_GCP_B         0xe1210
-#define TVIDEO_DIP_GCP(pipe) _MMIO_PIPE(pipe, _VIDEO_DIP_GCP_A, _VIDEO_DIP_GCP_B)
-#define  GCP_COLOR_INDICATION		(1 << 2)
-#define  GCP_DEFAULT_PHASE_ENABLE	(1 << 1)
-#define  GCP_AV_MUTE			(1 << 0)
-
-/* Per-transcoder DIP controls (VLV) */
-#define _VLV_VIDEO_DIP_CTL_A		0x60200
-#define _VLV_VIDEO_DIP_CTL_B		0x61170
-#define _CHV_VIDEO_DIP_CTL_C		0x611f0
-#define VLV_TVIDEO_DIP_CTL(pipe)	_MMIO_BASE_PIPE3(VLV_DISPLAY_BASE, (pipe), \
-							 _VLV_VIDEO_DIP_CTL_A, \
-							 _VLV_VIDEO_DIP_CTL_B, \
-							 _CHV_VIDEO_DIP_CTL_C)
-
-#define _VLV_VIDEO_DIP_DATA_A		0x60208
-#define _VLV_VIDEO_DIP_DATA_B		0x61174
-#define _CHV_VIDEO_DIP_DATA_C		0x611f4
-#define VLV_TVIDEO_DIP_DATA(pipe)	_MMIO_BASE_PIPE3(VLV_DISPLAY_BASE, (pipe), \
-							 _VLV_VIDEO_DIP_DATA_A, \
-							 _VLV_VIDEO_DIP_DATA_B, \
-							 _CHV_VIDEO_DIP_DATA_C)
-
-#define _VLV_VIDEO_DIP_GDCP_PAYLOAD_A	0x60210
-#define _VLV_VIDEO_DIP_GDCP_PAYLOAD_B	0x61178
-#define _CHV_VIDEO_DIP_GDCP_PAYLOAD_C	0x611f8
-#define VLV_TVIDEO_DIP_GCP(pipe)	_MMIO_BASE_PIPE3(VLV_DISPLAY_BASE, (pipe), \
-							 _VLV_VIDEO_DIP_GDCP_PAYLOAD_A, \
-							 _VLV_VIDEO_DIP_GDCP_PAYLOAD_B, \
-							 _CHV_VIDEO_DIP_GDCP_PAYLOAD_C)
-
-/* Haswell DIP controls */
-#define _HSW_VIDEO_DIP_CTL_A		0x60200
-#define _HSW_VIDEO_DIP_CTL_B		0x61200
-#define HSW_TVIDEO_DIP_CTL(dev_priv, trans)		_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_CTL_A)
-
-#define _HSW_VIDEO_DIP_AVI_DATA_A	0x60220
-#define _HSW_VIDEO_DIP_AVI_DATA_B	0x61220
-#define HSW_TVIDEO_DIP_AVI_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_AVI_DATA_A + (i) * 4)
-
-#define _HSW_VIDEO_DIP_VS_DATA_A	0x60260
-#define _HSW_VIDEO_DIP_VS_DATA_B	0x61260
-#define HSW_TVIDEO_DIP_VS_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_VS_DATA_A + (i) * 4)
-
-#define _HSW_VIDEO_DIP_SPD_DATA_A	0x602A0
-#define _HSW_VIDEO_DIP_SPD_DATA_B	0x612A0
-#define HSW_TVIDEO_DIP_SPD_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_SPD_DATA_A + (i) * 4)
-
-#define _HSW_VIDEO_DIP_GMP_DATA_A	0x602E0
-#define _HSW_VIDEO_DIP_GMP_DATA_B	0x612E0
-#define HSW_TVIDEO_DIP_GMP_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_GMP_DATA_A + (i) * 4)
-
-#define _HSW_VIDEO_DIP_VSC_DATA_A	0x60320
-#define _HSW_VIDEO_DIP_VSC_DATA_B	0x61320
-#define HSW_TVIDEO_DIP_VSC_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_VSC_DATA_A + (i) * 4)
-
-/*ADLP and later: */
-#define	_ADL_VIDEO_DIP_AS_DATA_A	0x60484
-#define _ADL_VIDEO_DIP_AS_DATA_B	0x61484
-#define ADL_TVIDEO_DIP_AS_SDP_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans,\
-							     _ADL_VIDEO_DIP_AS_DATA_A + (i) * 4)
-
-#define _GLK_VIDEO_DIP_DRM_DATA_A	0x60440
-#define _GLK_VIDEO_DIP_DRM_DATA_B	0x61440
-#define GLK_TVIDEO_DIP_DRM_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _GLK_VIDEO_DIP_DRM_DATA_A + (i) * 4)
-
 #define _HSW_VIDEO_DIP_AVI_ECC_A	0x60240
 #define _HSW_VIDEO_DIP_BVI_ECC_B	0x61240
 #define _HSW_VIDEO_DIP_VS_ECC_A		0x60280
@@ -3017,20 +1204,12 @@
 #define _HSW_VIDEO_DIP_VSC_ECC_A	0x60344
 #define _HSW_VIDEO_DIP_VSC_ECC_B	0x61344
 
-#define _HSW_VIDEO_DIP_GCP_A		0x60210
-#define _HSW_VIDEO_DIP_GCP_B		0x61210
-#define HSW_TVIDEO_DIP_GCP(dev_priv, trans)		_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_GCP_A)
-
 /* Icelake PPS_DATA and _ECC DIP Registers.
  * These are available for transcoders B,C and eDP.
  * Adding the _A so as to reuse the _MMIO_TRANS2
  * definition, with which it offsets to the right location.
  */
 
-#define _ICL_VIDEO_DIP_PPS_DATA_A	0x60350
-#define _ICL_VIDEO_DIP_PPS_DATA_B	0x61350
-#define ICL_VIDEO_DIP_PPS_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _ICL_VIDEO_DIP_PPS_DATA_A + (i) * 4)
-
 #define _ICL_VIDEO_DIP_PPS_ECC_A	0x603D4
 #define _ICL_VIDEO_DIP_PPS_ECC_B	0x613D4
 #define ICL_VIDEO_DIP_PPS_ECC(dev_priv, trans, i)		_MMIO_TRANS2(dev_priv, trans, _ICL_VIDEO_DIP_PPS_ECC_A + (i) * 4)
@@ -3040,24 +1219,6 @@
 #define HSW_STEREO_3D_CTL(dev_priv, trans)	_MMIO_PIPE2(dev_priv, trans, _HSW_STEREO_3D_CTL_A)
 #define   S3D_ENABLE			(1 << 31)
 
-#define _PCH_TRANSACONF              0xf0008
-#define _PCH_TRANSBCONF              0xf1008
-#define PCH_TRANSCONF(pipe)	_MMIO_PIPE(pipe, _PCH_TRANSACONF, _PCH_TRANSBCONF)
-#define LPT_TRANSCONF		PCH_TRANSCONF(PIPE_A) /* lpt has only one transcoder */
-#define  TRANS_ENABLE			REG_BIT(31)
-#define  TRANS_STATE_ENABLE		REG_BIT(30)
-#define  TRANS_FRAME_START_DELAY_MASK	REG_GENMASK(28, 27) /* ibx */
-#define  TRANS_FRAME_START_DELAY(x)	REG_FIELD_PREP(TRANS_FRAME_START_DELAY_MASK, (x)) /* ibx: 0-3 */
-#define  TRANS_INTERLACE_MASK		REG_GENMASK(23, 21)
-#define  TRANS_INTERLACE_PROGRESSIVE	REG_FIELD_PREP(TRANS_INTERLACE_MASK, 0)
-#define  TRANS_INTERLACE_LEGACY_VSYNC_IBX	REG_FIELD_PREP(TRANS_INTERLACE_MASK, 2) /* ibx */
-#define  TRANS_INTERLACE_INTERLACED	REG_FIELD_PREP(TRANS_INTERLACE_MASK, 3)
-#define  TRANS_BPC_MASK			REG_GENMASK(7, 5) /* ibx */
-#define  TRANS_BPC_8			REG_FIELD_PREP(TRANS_BPC_MASK, 0)
-#define  TRANS_BPC_10			REG_FIELD_PREP(TRANS_BPC_MASK, 1)
-#define  TRANS_BPC_6			REG_FIELD_PREP(TRANS_BPC_MASK, 2)
-#define  TRANS_BPC_12			REG_FIELD_PREP(TRANS_BPC_MASK, 3)
-
 #define _TRANSA_CHICKEN1	 0xf0060
 #define _TRANSB_CHICKEN1	 0xf1060
 #define TRANS_CHICKEN1(pipe)	_MMIO_PIPE(pipe, _TRANSA_CHICKEN1, _TRANSB_CHICKEN1)
@@ -3110,88 +1271,6 @@
 #define  CNP_PWM_CGE_GATING_DISABLE (1 << 13)
 #define  PCH_LP_PARTITION_LEVEL_DISABLE  (1 << 12)
 
-#define PCH_DP_B		_MMIO(0xe4100)
-#define PCH_DP_C		_MMIO(0xe4200)
-#define PCH_DP_D		_MMIO(0xe4300)
-
-/* CPT */
-#define _TRANS_DP_CTL_A		0xe0300
-#define _TRANS_DP_CTL_B		0xe1300
-#define _TRANS_DP_CTL_C		0xe2300
-#define TRANS_DP_CTL(pipe)	_MMIO_PIPE(pipe, _TRANS_DP_CTL_A, _TRANS_DP_CTL_B)
-#define  TRANS_DP_OUTPUT_ENABLE		REG_BIT(31)
-#define  TRANS_DP_PORT_SEL_MASK		REG_GENMASK(30, 29)
-#define  TRANS_DP_PORT_SEL_NONE		REG_FIELD_PREP(TRANS_DP_PORT_SEL_MASK, 3)
-#define  TRANS_DP_PORT_SEL(port)	REG_FIELD_PREP(TRANS_DP_PORT_SEL_MASK, (port) - PORT_B)
-#define  TRANS_DP_AUDIO_ONLY		REG_BIT(26)
-#define  TRANS_DP_ENH_FRAMING		REG_BIT(18)
-#define  TRANS_DP_BPC_MASK		REG_GENMASK(10, 9)
-#define  TRANS_DP_BPC_8			REG_FIELD_PREP(TRANS_DP_BPC_MASK, 0)
-#define  TRANS_DP_BPC_10		REG_FIELD_PREP(TRANS_DP_BPC_MASK, 1)
-#define  TRANS_DP_BPC_6			REG_FIELD_PREP(TRANS_DP_BPC_MASK, 2)
-#define  TRANS_DP_BPC_12		REG_FIELD_PREP(TRANS_DP_BPC_MASK, 3)
-#define  TRANS_DP_VSYNC_ACTIVE_HIGH	REG_BIT(4)
-#define  TRANS_DP_HSYNC_ACTIVE_HIGH	REG_BIT(3)
-
-#define _TRANS_DP2_CTL_A			0x600a0
-#define _TRANS_DP2_CTL_B			0x610a0
-#define _TRANS_DP2_CTL_C			0x620a0
-#define _TRANS_DP2_CTL_D			0x630a0
-#define TRANS_DP2_CTL(trans)			_MMIO_TRANS(trans, _TRANS_DP2_CTL_A, _TRANS_DP2_CTL_B)
-#define  TRANS_DP2_128B132B_CHANNEL_CODING	REG_BIT(31)
-#define  TRANS_DP2_PANEL_REPLAY_ENABLE		REG_BIT(30)
-#define  TRANS_DP2_DEBUG_ENABLE			REG_BIT(23)
-
-#define _TRANS_DP2_VFREQHIGH_A			0x600a4
-#define _TRANS_DP2_VFREQHIGH_B			0x610a4
-#define _TRANS_DP2_VFREQHIGH_C			0x620a4
-#define _TRANS_DP2_VFREQHIGH_D			0x630a4
-#define TRANS_DP2_VFREQHIGH(trans)		_MMIO_TRANS(trans, _TRANS_DP2_VFREQHIGH_A, _TRANS_DP2_VFREQHIGH_B)
-#define  TRANS_DP2_VFREQ_PIXEL_CLOCK_MASK	REG_GENMASK(31, 8)
-#define  TRANS_DP2_VFREQ_PIXEL_CLOCK(clk_hz)	REG_FIELD_PREP(TRANS_DP2_VFREQ_PIXEL_CLOCK_MASK, (clk_hz))
-
-#define _TRANS_DP2_VFREQLOW_A			0x600a8
-#define _TRANS_DP2_VFREQLOW_B			0x610a8
-#define _TRANS_DP2_VFREQLOW_C			0x620a8
-#define _TRANS_DP2_VFREQLOW_D			0x630a8
-#define TRANS_DP2_VFREQLOW(trans)		_MMIO_TRANS(trans, _TRANS_DP2_VFREQLOW_A, _TRANS_DP2_VFREQLOW_B)
-
-#define _DP_MIN_HBLANK_CTL_A			0x600ac
-#define _DP_MIN_HBLANK_CTL_B			0x610ac
-#define DP_MIN_HBLANK_CTL(trans)		_MMIO_TRANS(trans, _DP_MIN_HBLANK_CTL_A, _DP_MIN_HBLANK_CTL_B)
-
-/* SNB eDP training params */
-/* SNB A-stepping */
-#define  EDP_LINK_TRAIN_400MV_0DB_SNB_A		(0x38 << 22)
-#define  EDP_LINK_TRAIN_400MV_6DB_SNB_A		(0x02 << 22)
-#define  EDP_LINK_TRAIN_600MV_3_5DB_SNB_A	(0x01 << 22)
-#define  EDP_LINK_TRAIN_800MV_0DB_SNB_A		(0x0 << 22)
-/* SNB B-stepping */
-#define  EDP_LINK_TRAIN_400_600MV_0DB_SNB_B	(0x0 << 22)
-#define  EDP_LINK_TRAIN_400MV_3_5DB_SNB_B	(0x1 << 22)
-#define  EDP_LINK_TRAIN_400_600MV_6DB_SNB_B	(0x3a << 22)
-#define  EDP_LINK_TRAIN_600_800MV_3_5DB_SNB_B	(0x39 << 22)
-#define  EDP_LINK_TRAIN_800_1200MV_0DB_SNB_B	(0x38 << 22)
-#define  EDP_LINK_TRAIN_VOL_EMP_MASK_SNB	(0x3f << 22)
-
-/* IVB */
-#define EDP_LINK_TRAIN_400MV_0DB_IVB		(0x24 << 22)
-#define EDP_LINK_TRAIN_400MV_3_5DB_IVB		(0x2a << 22)
-#define EDP_LINK_TRAIN_400MV_6DB_IVB		(0x2f << 22)
-#define EDP_LINK_TRAIN_600MV_0DB_IVB		(0x30 << 22)
-#define EDP_LINK_TRAIN_600MV_3_5DB_IVB		(0x36 << 22)
-#define EDP_LINK_TRAIN_800MV_0DB_IVB		(0x38 << 22)
-#define EDP_LINK_TRAIN_800MV_3_5DB_IVB		(0x3e << 22)
-
-/* legacy values */
-#define EDP_LINK_TRAIN_500MV_0DB_IVB		(0x00 << 22)
-#define EDP_LINK_TRAIN_1000MV_0DB_IVB		(0x20 << 22)
-#define EDP_LINK_TRAIN_500MV_3_5DB_IVB		(0x02 << 22)
-#define EDP_LINK_TRAIN_1000MV_3_5DB_IVB		(0x22 << 22)
-#define EDP_LINK_TRAIN_1000MV_6DB_IVB		(0x23 << 22)
-
-#define  EDP_LINK_TRAIN_VOL_EMP_MASK_IVB	(0x3f << 22)
-
 #define  VLV_PMWGICZ				_MMIO(0x1300a4)
 
 #define  HSW_EDRAM_CAP				_MMIO(0x120010)
@@ -3200,10 +1279,6 @@
 #define    EDRAM_WAYS_IDX(cap)			(((cap) >> 5) & 0x7)
 #define    EDRAM_SETS_IDX(cap)			(((cap) >> 8) & 0x3)
 
-#define VLV_CHICKEN_3				_MMIO(VLV_DISPLAY_BASE + 0x7040C)
-#define  PIXEL_OVERLAP_CNT_MASK			(3 << 30)
-#define  PIXEL_OVERLAP_CNT_SHIFT		30
-
 #define GEN6_PCODE_MAILBOX			_MMIO(0x138124)
 #define   GEN6_PCODE_READY			(1 << 31)
 #define   GEN6_PCODE_MB_PARAM2			REG_GENMASK(23, 16)
@@ -3332,103 +1407,6 @@
  */
 #define GEN7_SO_WRITE_OFFSET(n)		_MMIO(0x5280 + (n) * 4)
 
-/*
- * HSW - ICL power wells
- *
- * Platforms have up to 3 power well control register sets, each set
- * controlling up to 16 power wells via a request/status HW flag tuple:
- * - main (HSW_PWR_WELL_CTL[1-4])
- * - AUX  (ICL_PWR_WELL_CTL_AUX[1-4])
- * - DDI  (ICL_PWR_WELL_CTL_DDI[1-4])
- * Each control register set consists of up to 4 registers used by different
- * sources that can request a power well to be enabled:
- * - BIOS   (HSW_PWR_WELL_CTL1/ICL_PWR_WELL_CTL_AUX1/ICL_PWR_WELL_CTL_DDI1)
- * - DRIVER (HSW_PWR_WELL_CTL2/ICL_PWR_WELL_CTL_AUX2/ICL_PWR_WELL_CTL_DDI2)
- * - KVMR   (HSW_PWR_WELL_CTL3)   (only in the main register set)
- * - DEBUG  (HSW_PWR_WELL_CTL4/ICL_PWR_WELL_CTL_AUX4/ICL_PWR_WELL_CTL_DDI4)
- */
-#define HSW_PWR_WELL_CTL1			_MMIO(0x45400)
-#define HSW_PWR_WELL_CTL2			_MMIO(0x45404)
-#define HSW_PWR_WELL_CTL3			_MMIO(0x45408)
-#define HSW_PWR_WELL_CTL4			_MMIO(0x4540C)
-#define   HSW_PWR_WELL_CTL_REQ(pw_idx)		(0x2 << ((pw_idx) * 2))
-#define   HSW_PWR_WELL_CTL_STATE(pw_idx)	(0x1 << ((pw_idx) * 2))
-
-/* HSW/BDW power well */
-#define   HSW_PW_CTL_IDX_GLOBAL			15
-
-/* SKL/BXT/GLK power wells */
-#define   SKL_PW_CTL_IDX_PW_2			15
-#define   SKL_PW_CTL_IDX_PW_1			14
-#define   GLK_PW_CTL_IDX_AUX_C			10
-#define   GLK_PW_CTL_IDX_AUX_B			9
-#define   GLK_PW_CTL_IDX_AUX_A			8
-#define   SKL_PW_CTL_IDX_DDI_D			4
-#define   SKL_PW_CTL_IDX_DDI_C			3
-#define   SKL_PW_CTL_IDX_DDI_B			2
-#define   SKL_PW_CTL_IDX_DDI_A_E		1
-#define   GLK_PW_CTL_IDX_DDI_A			1
-#define   SKL_PW_CTL_IDX_MISC_IO		0
-
-/* ICL/TGL - power wells */
-#define   TGL_PW_CTL_IDX_PW_5			4
-#define   ICL_PW_CTL_IDX_PW_4			3
-#define   ICL_PW_CTL_IDX_PW_3			2
-#define   ICL_PW_CTL_IDX_PW_2			1
-#define   ICL_PW_CTL_IDX_PW_1			0
-
-/* XE_LPD - power wells */
-#define   XELPD_PW_CTL_IDX_PW_D			8
-#define   XELPD_PW_CTL_IDX_PW_C			7
-#define   XELPD_PW_CTL_IDX_PW_B			6
-#define   XELPD_PW_CTL_IDX_PW_A			5
-
-#define ICL_PWR_WELL_CTL_AUX1			_MMIO(0x45440)
-#define ICL_PWR_WELL_CTL_AUX2			_MMIO(0x45444)
-#define ICL_PWR_WELL_CTL_AUX4			_MMIO(0x4544C)
-#define   TGL_PW_CTL_IDX_AUX_TBT6		14
-#define   TGL_PW_CTL_IDX_AUX_TBT5		13
-#define   TGL_PW_CTL_IDX_AUX_TBT4		12
-#define   ICL_PW_CTL_IDX_AUX_TBT4		11
-#define   TGL_PW_CTL_IDX_AUX_TBT3		11
-#define   ICL_PW_CTL_IDX_AUX_TBT3		10
-#define   TGL_PW_CTL_IDX_AUX_TBT2		10
-#define   ICL_PW_CTL_IDX_AUX_TBT2		9
-#define   TGL_PW_CTL_IDX_AUX_TBT1		9
-#define   ICL_PW_CTL_IDX_AUX_TBT1		8
-#define   TGL_PW_CTL_IDX_AUX_TC6		8
-#define   XELPD_PW_CTL_IDX_AUX_E			8
-#define   TGL_PW_CTL_IDX_AUX_TC5		7
-#define   XELPD_PW_CTL_IDX_AUX_D			7
-#define   TGL_PW_CTL_IDX_AUX_TC4		6
-#define   ICL_PW_CTL_IDX_AUX_F			5
-#define   TGL_PW_CTL_IDX_AUX_TC3		5
-#define   ICL_PW_CTL_IDX_AUX_E			4
-#define   TGL_PW_CTL_IDX_AUX_TC2		4
-#define   ICL_PW_CTL_IDX_AUX_D			3
-#define   TGL_PW_CTL_IDX_AUX_TC1		3
-#define   ICL_PW_CTL_IDX_AUX_C			2
-#define   ICL_PW_CTL_IDX_AUX_B			1
-#define   ICL_PW_CTL_IDX_AUX_A			0
-
-#define ICL_PWR_WELL_CTL_DDI1			_MMIO(0x45450)
-#define ICL_PWR_WELL_CTL_DDI2			_MMIO(0x45454)
-#define ICL_PWR_WELL_CTL_DDI4			_MMIO(0x4545C)
-#define   XELPD_PW_CTL_IDX_DDI_E			8
-#define   TGL_PW_CTL_IDX_DDI_TC6		8
-#define   XELPD_PW_CTL_IDX_DDI_D			7
-#define   TGL_PW_CTL_IDX_DDI_TC5		7
-#define   TGL_PW_CTL_IDX_DDI_TC4		6
-#define   ICL_PW_CTL_IDX_DDI_F			5
-#define   TGL_PW_CTL_IDX_DDI_TC3		5
-#define   ICL_PW_CTL_IDX_DDI_E			4
-#define   TGL_PW_CTL_IDX_DDI_TC2		4
-#define   ICL_PW_CTL_IDX_DDI_D			3
-#define   TGL_PW_CTL_IDX_DDI_TC1		3
-#define   ICL_PW_CTL_IDX_DDI_C			2
-#define   ICL_PW_CTL_IDX_DDI_B			1
-#define   ICL_PW_CTL_IDX_DDI_A			0
-
 /* HSW - power well misc debug registers */
 #define HSW_PWR_WELL_CTL5			_MMIO(0x45410)
 #define   HSW_PWR_WELL_ENABLE_SINGLE_STEP	(1 << 31)
@@ -3445,188 +1423,6 @@ enum skl_power_gate {
 	ICL_PG4,
 };
 
-#define SKL_FUSE_STATUS				_MMIO(0x42000)
-#define  SKL_FUSE_DOWNLOAD_STATUS		(1 << 31)
-/*
- * PG0 is HW controlled, so doesn't have a corresponding power well control knob
- * SKL_DISP_PW1_IDX..SKL_DISP_PW2_IDX -> PG1..PG2
- */
-#define  SKL_PW_CTL_IDX_TO_PG(pw_idx)		\
-	((pw_idx) - SKL_PW_CTL_IDX_PW_1 + SKL_PG1)
-/*
- * PG0 is HW controlled, so doesn't have a corresponding power well control knob
- * ICL_DISP_PW1_IDX..ICL_DISP_PW4_IDX -> PG1..PG4
- */
-#define  ICL_PW_CTL_IDX_TO_PG(pw_idx)		\
-	((pw_idx) - ICL_PW_CTL_IDX_PW_1 + SKL_PG1)
-#define  SKL_FUSE_PG_DIST_STATUS(pg)		(1 << (27 - (pg)))
-
-/* Per-pipe DDI Function Control */
-#define _TRANS_DDI_FUNC_CTL_A		0x60400
-#define _TRANS_DDI_FUNC_CTL_B		0x61400
-#define _TRANS_DDI_FUNC_CTL_C		0x62400
-#define _TRANS_DDI_FUNC_CTL_D		0x63400
-#define _TRANS_DDI_FUNC_CTL_EDP		0x6F400
-#define _TRANS_DDI_FUNC_CTL_DSI0	0x6b400
-#define _TRANS_DDI_FUNC_CTL_DSI1	0x6bc00
-#define TRANS_DDI_FUNC_CTL(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, _TRANS_DDI_FUNC_CTL_A)
-
-#define  TRANS_DDI_FUNC_ENABLE		(1 << 31)
-/* Those bits are ignored by pipe EDP since it can only connect to DDI A */
-#define  TRANS_DDI_PORT_SHIFT		28
-#define  TGL_TRANS_DDI_PORT_SHIFT	27
-#define  TRANS_DDI_PORT_MASK		(7 << TRANS_DDI_PORT_SHIFT)
-#define  TGL_TRANS_DDI_PORT_MASK	(0xf << TGL_TRANS_DDI_PORT_SHIFT)
-#define  TRANS_DDI_SELECT_PORT(x)	((x) << TRANS_DDI_PORT_SHIFT)
-#define  TGL_TRANS_DDI_SELECT_PORT(x)	(((x) + 1) << TGL_TRANS_DDI_PORT_SHIFT)
-#define  TRANS_DDI_MODE_SELECT_MASK	(7 << 24)
-#define  TRANS_DDI_MODE_SELECT_HDMI	(0 << 24)
-#define  TRANS_DDI_MODE_SELECT_DVI	(1 << 24)
-#define  TRANS_DDI_MODE_SELECT_DP_SST	(2 << 24)
-#define  TRANS_DDI_MODE_SELECT_DP_MST	(3 << 24)
-#define  TRANS_DDI_MODE_SELECT_FDI_OR_128B132B	(4 << 24)
-#define  TRANS_DDI_BPC_MASK		(7 << 20)
-#define  TRANS_DDI_BPC_8		(0 << 20)
-#define  TRANS_DDI_BPC_10		(1 << 20)
-#define  TRANS_DDI_BPC_6		(2 << 20)
-#define  TRANS_DDI_BPC_12		(3 << 20)
-#define  TRANS_DDI_PORT_SYNC_MASTER_SELECT_MASK	REG_GENMASK(19, 18)
-#define  TRANS_DDI_PORT_SYNC_MASTER_SELECT(x)	REG_FIELD_PREP(TRANS_DDI_PORT_SYNC_MASTER_SELECT_MASK, (x))
-#define  TRANS_DDI_PVSYNC		(1 << 17)
-#define  TRANS_DDI_PHSYNC		(1 << 16)
-#define  TRANS_DDI_PORT_SYNC_ENABLE	REG_BIT(15)
-#define  XE3_TRANS_DDI_HDCP_LINE_REKEY_DISABLE	REG_BIT(15)
-#define  TRANS_DDI_EDP_INPUT_MASK	(7 << 12)
-#define  TRANS_DDI_EDP_INPUT_A_ON	(0 << 12)
-#define  TRANS_DDI_EDP_INPUT_A_ONOFF	(4 << 12)
-#define  TRANS_DDI_EDP_INPUT_B_ONOFF	(5 << 12)
-#define  TRANS_DDI_EDP_INPUT_C_ONOFF	(6 << 12)
-#define  TRANS_DDI_EDP_INPUT_D_ONOFF	(7 << 12)
-#define  TRANS_DDI_HDCP_LINE_REKEY_DISABLE	REG_BIT(12)
-#define  TRANS_DDI_MST_TRANSPORT_SELECT_MASK	REG_GENMASK(11, 10)
-#define  TRANS_DDI_MST_TRANSPORT_SELECT(trans)	\
-	REG_FIELD_PREP(TRANS_DDI_MST_TRANSPORT_SELECT_MASK, trans)
-#define  TRANS_DDI_HDCP_SIGNALLING	(1 << 9)
-#define  TRANS_DDI_DP_VC_PAYLOAD_ALLOC	(1 << 8)
-#define  TRANS_DDI_HDMI_SCRAMBLER_CTS_ENABLE (1 << 7)
-#define  TRANS_DDI_HDMI_SCRAMBLER_RESET_FREQ (1 << 6)
-#define  TRANS_DDI_HDCP_SELECT		REG_BIT(5)
-#define  TRANS_DDI_BFI_ENABLE		(1 << 4)
-#define  TRANS_DDI_HIGH_TMDS_CHAR_RATE	(1 << 4)
-#define  TRANS_DDI_PORT_WIDTH_MASK	REG_GENMASK(3, 1)
-#define  TRANS_DDI_PORT_WIDTH(width)	REG_FIELD_PREP(TRANS_DDI_PORT_WIDTH_MASK, (width) - 1)
-#define  TRANS_DDI_HDMI_SCRAMBLING	(1 << 0)
-#define  TRANS_DDI_HDMI_SCRAMBLING_MASK (TRANS_DDI_HDMI_SCRAMBLER_CTS_ENABLE \
-					| TRANS_DDI_HDMI_SCRAMBLER_RESET_FREQ \
-					| TRANS_DDI_HDMI_SCRAMBLING)
-
-#define _TRANS_DDI_FUNC_CTL2_A		0x60404
-#define _TRANS_DDI_FUNC_CTL2_B		0x61404
-#define _TRANS_DDI_FUNC_CTL2_C		0x62404
-#define _TRANS_DDI_FUNC_CTL2_EDP	0x6f404
-#define _TRANS_DDI_FUNC_CTL2_DSI0	0x6b404
-#define _TRANS_DDI_FUNC_CTL2_DSI1	0x6bc04
-#define TRANS_DDI_FUNC_CTL2(dev_priv, tran)	_MMIO_TRANS2(dev_priv, tran, _TRANS_DDI_FUNC_CTL2_A)
-#define  PORT_SYNC_MODE_ENABLE			REG_BIT(4)
-#define  CMTG_SECONDARY_MODE			REG_BIT(3)
-#define  PORT_SYNC_MODE_MASTER_SELECT_MASK	REG_GENMASK(2, 0)
-#define  PORT_SYNC_MODE_MASTER_SELECT(x)	REG_FIELD_PREP(PORT_SYNC_MODE_MASTER_SELECT_MASK, (x))
-
-#define TRANS_CMTG_CHICKEN		_MMIO(0x6fa90)
-#define  DISABLE_DPT_CLK_GATING		REG_BIT(1)
-
-/* DisplayPort Transport Control */
-#define _DP_TP_CTL_A			0x64040
-#define _DP_TP_CTL_B			0x64140
-#define _TGL_DP_TP_CTL_A		0x60540
-#define DP_TP_CTL(port) _MMIO_PORT(port, _DP_TP_CTL_A, _DP_TP_CTL_B)
-#define TGL_DP_TP_CTL(dev_priv, tran) _MMIO_TRANS2(dev_priv, (tran), _TGL_DP_TP_CTL_A)
-#define   DP_TP_CTL_ENABLE			REG_BIT(31)
-#define   DP_TP_CTL_FEC_ENABLE			REG_BIT(30)
-#define   DP_TP_CTL_MODE_MASK			REG_BIT(27)
-#define   DP_TP_CTL_MODE_SST			REG_FIELD_PREP(DP_TP_CTL_MODE_MASK, 0)
-#define   DP_TP_CTL_MODE_MST			REG_FIELD_PREP(DP_TP_CTL_MODE_MASK, 1)
-#define   DP_TP_CTL_FORCE_ACT			REG_BIT(25)
-#define   DP_TP_CTL_TRAIN_PAT4_SEL_MASK		REG_GENMASK(20, 19)
-#define   DP_TP_CTL_TRAIN_PAT4_SEL_TP4A		REG_FIELD_PREP(DP_TP_CTL_TRAIN_PAT4_SEL_MASK, 0)
-#define   DP_TP_CTL_TRAIN_PAT4_SEL_TP4B		REG_FIELD_PREP(DP_TP_CTL_TRAIN_PAT4_SEL_MASK, 1)
-#define   DP_TP_CTL_TRAIN_PAT4_SEL_TP4C		REG_FIELD_PREP(DP_TP_CTL_TRAIN_PAT4_SEL_MASK, 2)
-#define   DP_TP_CTL_ENHANCED_FRAME_ENABLE	REG_BIT(18)
-#define   DP_TP_CTL_FDI_AUTOTRAIN		REG_BIT(15)
-#define   DP_TP_CTL_LINK_TRAIN_MASK		REG_GENMASK(10, 8)
-#define   DP_TP_CTL_LINK_TRAIN_PAT1		REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 0)
-#define   DP_TP_CTL_LINK_TRAIN_PAT2		REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 1)
-#define   DP_TP_CTL_LINK_TRAIN_PAT3		REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 4)
-#define   DP_TP_CTL_LINK_TRAIN_PAT4		REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 5)
-#define   DP_TP_CTL_LINK_TRAIN_IDLE		REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 2)
-#define   DP_TP_CTL_LINK_TRAIN_NORMAL		REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 3)
-#define   DP_TP_CTL_SCRAMBLE_DISABLE		REG_BIT(7)
-
-/* DisplayPort Transport Status */
-#define _DP_TP_STATUS_A			0x64044
-#define _DP_TP_STATUS_B			0x64144
-#define _TGL_DP_TP_STATUS_A		0x60544
-#define DP_TP_STATUS(port) _MMIO_PORT(port, _DP_TP_STATUS_A, _DP_TP_STATUS_B)
-#define TGL_DP_TP_STATUS(dev_priv, tran) _MMIO_TRANS2(dev_priv, (tran), _TGL_DP_TP_STATUS_A)
-#define   DP_TP_STATUS_FEC_ENABLE_LIVE		REG_BIT(28)
-#define   DP_TP_STATUS_IDLE_DONE		REG_BIT(25)
-#define   DP_TP_STATUS_ACT_SENT			REG_BIT(24)
-#define   DP_TP_STATUS_MODE_STATUS_MST		REG_BIT(23)
-#define   DP_TP_STATUS_STREAMS_ENABLED_MASK	REG_GENMASK(18, 16) /* 17:16 on hsw but bit 18 mbz */
-#define   DP_TP_STATUS_AUTOTRAIN_DONE		REG_BIT(12)
-#define   DP_TP_STATUS_PAYLOAD_MAPPING_VC2_MASK REG_GENMASK(9, 8)
-#define   DP_TP_STATUS_PAYLOAD_MAPPING_VC1_MASK	REG_GENMASK(5, 4)
-#define   DP_TP_STATUS_PAYLOAD_MAPPING_VC0_MASK	REG_GENMASK(1, 0)
-
-/* DDI Buffer Control */
-#define _DDI_BUF_CTL_A				0x64000
-#define _DDI_BUF_CTL_B				0x64100
-/* Known as DDI_CTL_DE in MTL+ */
-#define DDI_BUF_CTL(port) _MMIO_PORT(port, _DDI_BUF_CTL_A, _DDI_BUF_CTL_B)
-#define  DDI_BUF_CTL_ENABLE			(1 << 31)
-#define  XE2LPD_DDI_BUF_D2D_LINK_ENABLE		REG_BIT(29)
-#define  XE2LPD_DDI_BUF_D2D_LINK_STATE		REG_BIT(28)
-#define  DDI_BUF_TRANS_SELECT(n)	((n) << 24)
-#define  DDI_BUF_EMP_MASK			(0xf << 24)
-#define  DDI_BUF_PHY_LINK_RATE(r)		((r) << 20)
-#define  DDI_BUF_PORT_DATA_MASK			REG_GENMASK(19, 18)
-#define  DDI_BUF_PORT_DATA_10BIT		REG_FIELD_PREP(DDI_BUF_PORT_DATA_MASK, 0)
-#define  DDI_BUF_PORT_DATA_20BIT		REG_FIELD_PREP(DDI_BUF_PORT_DATA_MASK, 1)
-#define  DDI_BUF_PORT_DATA_40BIT		REG_FIELD_PREP(DDI_BUF_PORT_DATA_MASK, 2)
-#define  DDI_BUF_PORT_REVERSAL			(1 << 16)
-#define  DDI_BUF_IS_IDLE			(1 << 7)
-#define  DDI_BUF_CTL_TC_PHY_OWNERSHIP		REG_BIT(6)
-#define  DDI_A_4_LANES				(1 << 4)
-#define  DDI_PORT_WIDTH(width)			(((width) - 1) << 1)
-#define  DDI_PORT_WIDTH_MASK			(7 << 1)
-#define  DDI_PORT_WIDTH_SHIFT			1
-#define  DDI_INIT_DISPLAY_DETECTED		(1 << 0)
-
-/* DDI Buffer Translations */
-#define _DDI_BUF_TRANS_A		0x64E00
-#define _DDI_BUF_TRANS_B		0x64E60
-#define DDI_BUF_TRANS_LO(port, i)	_MMIO(_PORT(port, _DDI_BUF_TRANS_A, _DDI_BUF_TRANS_B) + (i) * 8)
-#define  DDI_BUF_BALANCE_LEG_ENABLE	(1 << 31)
-#define DDI_BUF_TRANS_HI(port, i)	_MMIO(_PORT(port, _DDI_BUF_TRANS_A, _DDI_BUF_TRANS_B) + (i) * 8 + 4)
-
-/* DDI DP Compliance Control */
-#define _DDI_DP_COMP_CTL_A			0x605F0
-#define _DDI_DP_COMP_CTL_B			0x615F0
-#define DDI_DP_COMP_CTL(pipe)			_MMIO_PIPE(pipe, _DDI_DP_COMP_CTL_A, _DDI_DP_COMP_CTL_B)
-#define   DDI_DP_COMP_CTL_ENABLE		(1 << 31)
-#define   DDI_DP_COMP_CTL_D10_2			(0 << 28)
-#define   DDI_DP_COMP_CTL_SCRAMBLED_0		(1 << 28)
-#define   DDI_DP_COMP_CTL_PRBS7			(2 << 28)
-#define   DDI_DP_COMP_CTL_CUSTOM80		(3 << 28)
-#define   DDI_DP_COMP_CTL_HBR2			(4 << 28)
-#define   DDI_DP_COMP_CTL_SCRAMBLED_1		(5 << 28)
-#define   DDI_DP_COMP_CTL_HBR2_RESET		(0xFC << 0)
-
-/* DDI DP Compliance Pattern */
-#define _DDI_DP_COMP_PAT_A			0x605F4
-#define _DDI_DP_COMP_PAT_B			0x615F4
-#define DDI_DP_COMP_PAT(pipe, i)		_MMIO(_PIPE(pipe, _DDI_DP_COMP_PAT_A, _DDI_DP_COMP_PAT_B) + (i) * 4)
-
 /* Sideband Interface (SBI) is programmed indirectly, via
  * SBI_ADDR, which contains the register offset; and SBI_DATA,
  * which contains the payload */
@@ -3644,502 +1440,15 @@ enum skl_power_gate {
 #define  SBI_BUSY			(0x1 << 0)
 #define  SBI_READY			(0x0 << 0)
 
-/* SBI offsets */
-#define  SBI_SSCDIVINTPHASE			0x0200
-#define  SBI_SSCDIVINTPHASE6			0x0600
-#define   SBI_SSCDIVINTPHASE_DIVSEL_SHIFT	1
-#define   SBI_SSCDIVINTPHASE_DIVSEL_MASK	(0x7f << 1)
-#define   SBI_SSCDIVINTPHASE_DIVSEL(x)		((x) << 1)
-#define   SBI_SSCDIVINTPHASE_INCVAL_SHIFT	8
-#define   SBI_SSCDIVINTPHASE_INCVAL_MASK	(0x7f << 8)
-#define   SBI_SSCDIVINTPHASE_INCVAL(x)		((x) << 8)
-#define   SBI_SSCDIVINTPHASE_DIR(x)		((x) << 15)
-#define   SBI_SSCDIVINTPHASE_PROPAGATE		(1 << 0)
-#define  SBI_SSCDITHPHASE			0x0204
-#define  SBI_SSCCTL				0x020c
-#define  SBI_SSCCTL6				0x060C
-#define   SBI_SSCCTL_PATHALT			(1 << 3)
-#define   SBI_SSCCTL_DISABLE			(1 << 0)
-#define  SBI_SSCAUXDIV6				0x0610
-#define   SBI_SSCAUXDIV_FINALDIV2SEL_SHIFT	4
-#define   SBI_SSCAUXDIV_FINALDIV2SEL_MASK	(1 << 4)
-#define   SBI_SSCAUXDIV_FINALDIV2SEL(x)		((x) << 4)
-#define  SBI_DBUFF0				0x2a00
-#define  SBI_GEN0				0x1f00
-#define   SBI_GEN0_CFG_BUFFENABLE_DISABLE	(1 << 0)
-
-/* LPT PIXCLK_GATE */
-#define PIXCLK_GATE			_MMIO(0xC6020)
-#define  PIXCLK_GATE_UNGATE		(1 << 0)
-#define  PIXCLK_GATE_GATE		(0 << 0)
-
-/* SPLL */
-#define SPLL_CTL			_MMIO(0x46020)
-#define  SPLL_PLL_ENABLE		(1 << 31)
-#define  SPLL_REF_BCLK			(0 << 28)
-#define  SPLL_REF_MUXED_SSC		(1 << 28) /* CPU SSC if fused enabled, PCH SSC otherwise */
-#define  SPLL_REF_NON_SSC_HSW		(2 << 28)
-#define  SPLL_REF_PCH_SSC_BDW		(2 << 28)
-#define  SPLL_REF_LCPLL			(3 << 28)
-#define  SPLL_REF_MASK			(3 << 28)
-#define  SPLL_FREQ_810MHz		(0 << 26)
-#define  SPLL_FREQ_1350MHz		(1 << 26)
-#define  SPLL_FREQ_2700MHz		(2 << 26)
-#define  SPLL_FREQ_MASK			(3 << 26)
-
-/* WRPLL */
-#define _WRPLL_CTL1			0x46040
-#define _WRPLL_CTL2			0x46060
-#define WRPLL_CTL(pll)			_MMIO_PIPE(pll, _WRPLL_CTL1, _WRPLL_CTL2)
-#define  WRPLL_PLL_ENABLE		(1 << 31)
-#define  WRPLL_REF_BCLK			(0 << 28)
-#define  WRPLL_REF_PCH_SSC		(1 << 28)
-#define  WRPLL_REF_MUXED_SSC_BDW	(2 << 28) /* CPU SSC if fused enabled, PCH SSC otherwise */
-#define  WRPLL_REF_SPECIAL_HSW		(2 << 28) /* muxed SSC (ULT), non-SSC (non-ULT) */
-#define  WRPLL_REF_LCPLL		(3 << 28)
-#define  WRPLL_REF_MASK			(3 << 28)
-/* WRPLL divider programming */
-#define  WRPLL_DIVIDER_REFERENCE(x)	((x) << 0)
-#define  WRPLL_DIVIDER_REF_MASK		(0xff)
-#define  WRPLL_DIVIDER_POST(x)		((x) << 8)
-#define  WRPLL_DIVIDER_POST_MASK	(0x3f << 8)
-#define  WRPLL_DIVIDER_POST_SHIFT	8
-#define  WRPLL_DIVIDER_FEEDBACK(x)	((x) << 16)
-#define  WRPLL_DIVIDER_FB_SHIFT		16
-#define  WRPLL_DIVIDER_FB_MASK		(0xff << 16)
-
-/* Port clock selection */
-#define _PORT_CLK_SEL_A			0x46100
-#define _PORT_CLK_SEL_B			0x46104
-#define PORT_CLK_SEL(port) _MMIO_PORT(port, _PORT_CLK_SEL_A, _PORT_CLK_SEL_B)
-#define  PORT_CLK_SEL_MASK		REG_GENMASK(31, 29)
-#define  PORT_CLK_SEL_LCPLL_2700	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 0)
-#define  PORT_CLK_SEL_LCPLL_1350	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 1)
-#define  PORT_CLK_SEL_LCPLL_810		REG_FIELD_PREP(PORT_CLK_SEL_MASK, 2)
-#define  PORT_CLK_SEL_SPLL		REG_FIELD_PREP(PORT_CLK_SEL_MASK, 3)
-#define  PORT_CLK_SEL_WRPLL(pll)	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 4 + (pll))
-#define  PORT_CLK_SEL_WRPLL1		REG_FIELD_PREP(PORT_CLK_SEL_MASK, 4)
-#define  PORT_CLK_SEL_WRPLL2		REG_FIELD_PREP(PORT_CLK_SEL_MASK, 5)
-#define  PORT_CLK_SEL_NONE		REG_FIELD_PREP(PORT_CLK_SEL_MASK, 7)
-
-/* On ICL+ this is the same as PORT_CLK_SEL, but all bits change. */
-#define DDI_CLK_SEL(port)		PORT_CLK_SEL(port)
-#define  DDI_CLK_SEL_MASK		REG_GENMASK(31, 28)
-#define  DDI_CLK_SEL_NONE		REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0x0)
-#define  DDI_CLK_SEL_MG			REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0x8)
-#define  DDI_CLK_SEL_TBT_162		REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xC)
-#define  DDI_CLK_SEL_TBT_270		REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xD)
-#define  DDI_CLK_SEL_TBT_540		REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xE)
-#define  DDI_CLK_SEL_TBT_810		REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xF)
-
-/* Transcoder clock selection */
-#define _TRANS_CLK_SEL_A		0x46140
-#define _TRANS_CLK_SEL_B		0x46144
-#define TRANS_CLK_SEL(tran) _MMIO_TRANS(tran, _TRANS_CLK_SEL_A, _TRANS_CLK_SEL_B)
-/* For each transcoder, we need to select the corresponding port clock */
-#define  TRANS_CLK_SEL_DISABLED		(0x0 << 29)
-#define  TRANS_CLK_SEL_PORT(x)		(((x) + 1) << 29)
-#define  TGL_TRANS_CLK_SEL_DISABLED	(0x0 << 28)
-#define  TGL_TRANS_CLK_SEL_PORT(x)	(((x) + 1) << 28)
-
-
-#define CDCLK_FREQ			_MMIO(0x46200)
-
-#define _TRANSA_MSA_MISC		0x60410
-#define _TRANSB_MSA_MISC		0x61410
-#define _TRANSC_MSA_MISC		0x62410
-#define _TRANS_EDP_MSA_MISC		0x6f410
-#define TRANS_MSA_MISC(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, _TRANSA_MSA_MISC)
-/* See DP_MSA_MISC_* for the bit definitions */
-
-#define _TRANS_A_SET_CONTEXT_LATENCY		0x6007C
-#define _TRANS_B_SET_CONTEXT_LATENCY		0x6107C
-#define _TRANS_C_SET_CONTEXT_LATENCY		0x6207C
-#define _TRANS_D_SET_CONTEXT_LATENCY		0x6307C
-#define TRANS_SET_CONTEXT_LATENCY(dev_priv, tran)		_MMIO_TRANS2(dev_priv, tran, _TRANS_A_SET_CONTEXT_LATENCY)
-#define  TRANS_SET_CONTEXT_LATENCY_MASK		REG_GENMASK(15, 0)
-#define  TRANS_SET_CONTEXT_LATENCY_VALUE(x)	REG_FIELD_PREP(TRANS_SET_CONTEXT_LATENCY_MASK, (x))
-
-/* LCPLL Control */
-#define LCPLL_CTL			_MMIO(0x130040)
-#define  LCPLL_PLL_DISABLE		(1 << 31)
-#define  LCPLL_PLL_LOCK			(1 << 30)
-#define  LCPLL_REF_NON_SSC		(0 << 28)
-#define  LCPLL_REF_BCLK			(2 << 28)
-#define  LCPLL_REF_PCH_SSC		(3 << 28)
-#define  LCPLL_REF_MASK			(3 << 28)
-#define  LCPLL_CLK_FREQ_MASK		(3 << 26)
-#define  LCPLL_CLK_FREQ_450		(0 << 26)
-#define  LCPLL_CLK_FREQ_54O_BDW		(1 << 26)
-#define  LCPLL_CLK_FREQ_337_5_BDW	(2 << 26)
-#define  LCPLL_CLK_FREQ_675_BDW		(3 << 26)
-#define  LCPLL_CD_CLOCK_DISABLE		(1 << 25)
-#define  LCPLL_ROOT_CD_CLOCK_DISABLE	(1 << 24)
-#define  LCPLL_CD2X_CLOCK_DISABLE	(1 << 23)
-#define  LCPLL_POWER_DOWN_ALLOW		(1 << 22)
-#define  LCPLL_CD_SOURCE_FCLK		(1 << 21)
-#define  LCPLL_CD_SOURCE_FCLK_DONE	(1 << 19)
-
-/*
- * SKL Clocks
- */
-/* CDCLK_CTL */
-#define CDCLK_CTL			_MMIO(0x46000)
-#define  CDCLK_FREQ_SEL_MASK		REG_GENMASK(27, 26)
-#define  CDCLK_FREQ_450_432		REG_FIELD_PREP(CDCLK_FREQ_SEL_MASK, 0)
-#define  CDCLK_FREQ_540		REG_FIELD_PREP(CDCLK_FREQ_SEL_MASK, 1)
-#define  CDCLK_FREQ_337_308		REG_FIELD_PREP(CDCLK_FREQ_SEL_MASK, 2)
-#define  CDCLK_FREQ_675_617		REG_FIELD_PREP(CDCLK_FREQ_SEL_MASK, 3)
-#define  MDCLK_SOURCE_SEL_MASK		REG_GENMASK(25, 25)
-#define  MDCLK_SOURCE_SEL_CD2XCLK	REG_FIELD_PREP(MDCLK_SOURCE_SEL_MASK, 0)
-#define  MDCLK_SOURCE_SEL_CDCLK_PLL	REG_FIELD_PREP(MDCLK_SOURCE_SEL_MASK, 1)
-#define  BXT_CDCLK_CD2X_DIV_SEL_MASK	REG_GENMASK(23, 22)
-#define  BXT_CDCLK_CD2X_DIV_SEL_1	REG_FIELD_PREP(BXT_CDCLK_CD2X_DIV_SEL_MASK, 0)
-#define  BXT_CDCLK_CD2X_DIV_SEL_1_5	REG_FIELD_PREP(BXT_CDCLK_CD2X_DIV_SEL_MASK, 1)
-#define  BXT_CDCLK_CD2X_DIV_SEL_2	REG_FIELD_PREP(BXT_CDCLK_CD2X_DIV_SEL_MASK, 2)
-#define  BXT_CDCLK_CD2X_DIV_SEL_4	REG_FIELD_PREP(BXT_CDCLK_CD2X_DIV_SEL_MASK, 3)
-#define  BXT_CDCLK_CD2X_PIPE(pipe)	((pipe) << 20)
-#define  CDCLK_DIVMUX_CD_OVERRIDE	(1 << 19)
-#define  BXT_CDCLK_CD2X_PIPE_NONE	BXT_CDCLK_CD2X_PIPE(3)
-#define  ICL_CDCLK_CD2X_PIPE(pipe)	(_PICK(pipe, 0, 2, 6) << 19)
-#define  ICL_CDCLK_CD2X_PIPE_NONE	(7 << 19)
-#define  TGL_CDCLK_CD2X_PIPE(pipe)	BXT_CDCLK_CD2X_PIPE(pipe)
-#define  TGL_CDCLK_CD2X_PIPE_NONE	ICL_CDCLK_CD2X_PIPE_NONE
-#define  BXT_CDCLK_SSA_PRECHARGE_ENABLE	(1 << 16)
-#define  CDCLK_FREQ_DECIMAL_MASK	(0x7ff)
-
-/* CDCLK_SQUASH_CTL */
-#define CDCLK_SQUASH_CTL		_MMIO(0x46008)
-#define  CDCLK_SQUASH_ENABLE		REG_BIT(31)
-#define  CDCLK_SQUASH_WINDOW_SIZE_MASK	REG_GENMASK(27, 24)
-#define  CDCLK_SQUASH_WINDOW_SIZE(x)	REG_FIELD_PREP(CDCLK_SQUASH_WINDOW_SIZE_MASK, (x))
-#define  CDCLK_SQUASH_WAVEFORM_MASK	REG_GENMASK(15, 0)
-#define  CDCLK_SQUASH_WAVEFORM(x)	REG_FIELD_PREP(CDCLK_SQUASH_WAVEFORM_MASK, (x))
-
-/* LCPLL_CTL */
-#define LCPLL1_CTL		_MMIO(0x46010)
-#define LCPLL2_CTL		_MMIO(0x46014)
-#define  LCPLL_PLL_ENABLE	(1 << 31)
-
-/* DPLL control1 */
-#define DPLL_CTRL1		_MMIO(0x6C058)
-#define  DPLL_CTRL1_HDMI_MODE(id)		(1 << ((id) * 6 + 5))
-#define  DPLL_CTRL1_SSC(id)			(1 << ((id) * 6 + 4))
-#define  DPLL_CTRL1_LINK_RATE_MASK(id)		(7 << ((id) * 6 + 1))
-#define  DPLL_CTRL1_LINK_RATE_SHIFT(id)		((id) * 6 + 1)
-#define  DPLL_CTRL1_LINK_RATE(linkrate, id)	((linkrate) << ((id) * 6 + 1))
-#define  DPLL_CTRL1_OVERRIDE(id)		(1 << ((id) * 6))
-#define  DPLL_CTRL1_LINK_RATE_2700		0
-#define  DPLL_CTRL1_LINK_RATE_1350		1
-#define  DPLL_CTRL1_LINK_RATE_810		2
-#define  DPLL_CTRL1_LINK_RATE_1620		3
-#define  DPLL_CTRL1_LINK_RATE_1080		4
-#define  DPLL_CTRL1_LINK_RATE_2160		5
-
-/* DPLL control2 */
-#define DPLL_CTRL2				_MMIO(0x6C05C)
-#define  DPLL_CTRL2_DDI_CLK_OFF(port)		(1 << ((port) + 15))
-#define  DPLL_CTRL2_DDI_CLK_SEL_MASK(port)	(3 << ((port) * 3 + 1))
-#define  DPLL_CTRL2_DDI_CLK_SEL_SHIFT(port)    ((port) * 3 + 1)
-#define  DPLL_CTRL2_DDI_CLK_SEL(clk, port)	((clk) << ((port) * 3 + 1))
-#define  DPLL_CTRL2_DDI_SEL_OVERRIDE(port)     (1 << ((port) * 3))
-
-/* DPLL Status */
-#define DPLL_STATUS	_MMIO(0x6C060)
-#define  DPLL_LOCK(id) (1 << ((id) * 8))
-
-/* DPLL cfg */
-#define _DPLL1_CFGCR1	0x6C040
-#define _DPLL2_CFGCR1	0x6C048
-#define _DPLL3_CFGCR1	0x6C050
-#define DPLL_CFGCR1(id)	_MMIO_PIPE((id) - SKL_DPLL1, _DPLL1_CFGCR1, _DPLL2_CFGCR1)
-#define  DPLL_CFGCR1_FREQ_ENABLE	(1 << 31)
-#define  DPLL_CFGCR1_DCO_FRACTION_MASK	(0x7fff << 9)
-#define  DPLL_CFGCR1_DCO_FRACTION(x)	((x) << 9)
-#define  DPLL_CFGCR1_DCO_INTEGER_MASK	(0x1ff)
-
-#define _DPLL1_CFGCR2	0x6C044
-#define _DPLL2_CFGCR2	0x6C04C
-#define _DPLL3_CFGCR2	0x6C054
-#define DPLL_CFGCR2(id)	_MMIO_PIPE((id) - SKL_DPLL1, _DPLL1_CFGCR2, _DPLL2_CFGCR2)
-#define  DPLL_CFGCR2_QDIV_RATIO_MASK	(0xff << 8)
-#define  DPLL_CFGCR2_QDIV_RATIO(x)	((x) << 8)
-#define  DPLL_CFGCR2_QDIV_MODE(x)	((x) << 7)
-#define  DPLL_CFGCR2_KDIV_MASK		(3 << 5)
-#define  DPLL_CFGCR2_KDIV(x)		((x) << 5)
-#define  DPLL_CFGCR2_KDIV_5 (0 << 5)
-#define  DPLL_CFGCR2_KDIV_2 (1 << 5)
-#define  DPLL_CFGCR2_KDIV_3 (2 << 5)
-#define  DPLL_CFGCR2_KDIV_1 (3 << 5)
-#define  DPLL_CFGCR2_PDIV_MASK		(7 << 2)
-#define  DPLL_CFGCR2_PDIV(x)		((x) << 2)
-#define  DPLL_CFGCR2_PDIV_1 (0 << 2)
-#define  DPLL_CFGCR2_PDIV_2 (1 << 2)
-#define  DPLL_CFGCR2_PDIV_3 (2 << 2)
-#define  DPLL_CFGCR2_PDIV_7 (4 << 2)
-#define  DPLL_CFGCR2_PDIV_7_INVALID	(5 << 2)
-#define  DPLL_CFGCR2_CENTRAL_FREQ_MASK	(3)
-
-/* ICL Clocks */
-#define ICL_DPCLKA_CFGCR0			_MMIO(0x164280)
-#define  ICL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy)	(1 << _PICK(phy, 10, 11, 24, 4, 5))
-#define  RKL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy)	REG_BIT((phy) + 10)
-#define  ICL_DPCLKA_CFGCR0_TC_CLK_OFF(tc_port)	(1 << ((tc_port) < TC_PORT_4 ? \
-						       (tc_port) + 12 : \
-						       (tc_port) - TC_PORT_4 + 21))
-#define  ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy)	((phy) * 2)
-#define  ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK(phy)	(3 << ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
-#define  ICL_DPCLKA_CFGCR0_DDI_CLK_SEL(pll, phy)	((pll) << ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
-#define  RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy)	_PICK(phy, 0, 2, 4, 27)
-#define  RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK(phy) \
-	(3 << RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
-#define  RKL_DPCLKA_CFGCR0_DDI_CLK_SEL(pll, phy) \
-	((pll) << RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
-
-/*
- * DG1 Clocks
- * First registers controls the first A and B, while the second register
- * controls the phy C and D. The bits on these registers are the
- * same, but refer to different phys
- */
-#define _DG1_DPCLKA_CFGCR0				0x164280
-#define _DG1_DPCLKA1_CFGCR0				0x16C280
-#define _DG1_DPCLKA_PHY_IDX(phy)			((phy) % 2)
-#define _DG1_DPCLKA_PLL_IDX(pll)			((pll) % 2)
-#define DG1_DPCLKA_CFGCR0(phy)				_MMIO_PHY((phy) / 2, \
-								  _DG1_DPCLKA_CFGCR0, \
-								  _DG1_DPCLKA1_CFGCR0)
-#define   DG1_DPCLKA_CFGCR0_DDI_CLK_OFF(phy)		REG_BIT(_DG1_DPCLKA_PHY_IDX(phy) + 10)
-#define   DG1_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy)	(_DG1_DPCLKA_PHY_IDX(phy) * 2)
-#define   DG1_DPCLKA_CFGCR0_DDI_CLK_SEL(pll, phy)	(_DG1_DPCLKA_PLL_IDX(pll) << DG1_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
-#define   DG1_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK(phy)	(0x3 << DG1_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
-
-/* ADLS Clocks */
-#define _ADLS_DPCLKA_CFGCR0			0x164280
-#define _ADLS_DPCLKA_CFGCR1			0x1642BC
-#define ADLS_DPCLKA_CFGCR(phy)			_MMIO_PHY((phy) / 3, \
-							  _ADLS_DPCLKA_CFGCR0, \
-							  _ADLS_DPCLKA_CFGCR1)
-#define  ADLS_DPCLKA_CFGCR_DDI_SHIFT(phy)		(((phy) % 3) * 2)
-/* ADLS DPCLKA_CFGCR0 DDI mask */
-#define  ADLS_DPCLKA_DDII_SEL_MASK			REG_GENMASK(5, 4)
-#define  ADLS_DPCLKA_DDIB_SEL_MASK			REG_GENMASK(3, 2)
-#define  ADLS_DPCLKA_DDIA_SEL_MASK			REG_GENMASK(1, 0)
-/* ADLS DPCLKA_CFGCR1 DDI mask */
-#define  ADLS_DPCLKA_DDIK_SEL_MASK			REG_GENMASK(3, 2)
-#define  ADLS_DPCLKA_DDIJ_SEL_MASK			REG_GENMASK(1, 0)
-#define  ADLS_DPCLKA_CFGCR_DDI_CLK_SEL_MASK(phy)	_PICK((phy), \
-							ADLS_DPCLKA_DDIA_SEL_MASK, \
-							ADLS_DPCLKA_DDIB_SEL_MASK, \
-							ADLS_DPCLKA_DDII_SEL_MASK, \
-							ADLS_DPCLKA_DDIJ_SEL_MASK, \
-							ADLS_DPCLKA_DDIK_SEL_MASK)
-
-/* ICL PLL */
-#define _DPLL0_ENABLE		0x46010
-#define _DPLL1_ENABLE		0x46014
-#define _ADLS_DPLL2_ENABLE	0x46018
-#define _ADLS_DPLL3_ENABLE	0x46030
-#define   PLL_ENABLE		REG_BIT(31)
-#define   PLL_LOCK		REG_BIT(30)
-#define   PLL_POWER_ENABLE	REG_BIT(27)
-#define   PLL_POWER_STATE	REG_BIT(26)
-#define ICL_DPLL_ENABLE(pll)	_MMIO(_PICK_EVEN_2RANGES(pll, 3,			\
-							_DPLL0_ENABLE, _DPLL1_ENABLE,	\
-							_ADLS_DPLL3_ENABLE, _ADLS_DPLL3_ENABLE))
 
 #define _DG2_PLL3_ENABLE	0x4601C
 
-#define DG2_PLL_ENABLE(pll)	_MMIO(_PICK_EVEN_2RANGES(pll, 3,			\
-							_DPLL0_ENABLE, _DPLL1_ENABLE,	\
-							_DG2_PLL3_ENABLE, _DG2_PLL3_ENABLE))
-
-#define TBT_PLL_ENABLE		_MMIO(0x46020)
-
-#define _MG_PLL1_ENABLE		0x46030
-#define _MG_PLL2_ENABLE		0x46034
-#define _MG_PLL3_ENABLE		0x46038
-#define _MG_PLL4_ENABLE		0x4603C
-/* Bits are the same as _DPLL0_ENABLE */
-#define MG_PLL_ENABLE(tc_port)	_MMIO_PORT((tc_port), _MG_PLL1_ENABLE, \
-					   _MG_PLL2_ENABLE)
-
-/* DG1 PLL */
-#define DG1_DPLL_ENABLE(pll)    _MMIO(_PICK_EVEN_2RANGES(pll, 2,			\
-							_DPLL0_ENABLE, _DPLL1_ENABLE,	\
-							_MG_PLL1_ENABLE, _MG_PLL2_ENABLE))
-
-/* ADL-P Type C PLL */
-#define PORTTC1_PLL_ENABLE	0x46038
-#define PORTTC2_PLL_ENABLE	0x46040
-#define ADLP_PORTTC_PLL_ENABLE(tc_port)		_MMIO_PORT((tc_port), \
-							    PORTTC1_PLL_ENABLE, \
-							    PORTTC2_PLL_ENABLE)
-
-#define _ICL_DPLL0_CFGCR0		0x164000
-#define _ICL_DPLL1_CFGCR0		0x164080
-#define ICL_DPLL_CFGCR0(pll)		_MMIO_PLL(pll, _ICL_DPLL0_CFGCR0, \
-						  _ICL_DPLL1_CFGCR0)
-#define   DPLL_CFGCR0_HDMI_MODE		(1 << 30)
-#define   DPLL_CFGCR0_SSC_ENABLE	(1 << 29)
-#define   DPLL_CFGCR0_SSC_ENABLE_ICL	(1 << 25)
-#define   DPLL_CFGCR0_LINK_RATE_MASK	(0xf << 25)
-#define   DPLL_CFGCR0_LINK_RATE_2700	(0 << 25)
-#define   DPLL_CFGCR0_LINK_RATE_1350	(1 << 25)
-#define   DPLL_CFGCR0_LINK_RATE_810	(2 << 25)
-#define   DPLL_CFGCR0_LINK_RATE_1620	(3 << 25)
-#define   DPLL_CFGCR0_LINK_RATE_1080	(4 << 25)
-#define   DPLL_CFGCR0_LINK_RATE_2160	(5 << 25)
-#define   DPLL_CFGCR0_LINK_RATE_3240	(6 << 25)
-#define   DPLL_CFGCR0_LINK_RATE_4050	(7 << 25)
-#define   DPLL_CFGCR0_DCO_FRACTION_MASK	(0x7fff << 10)
-#define   DPLL_CFGCR0_DCO_FRACTION_SHIFT	(10)
-#define   DPLL_CFGCR0_DCO_FRACTION(x)	((x) << 10)
-#define   DPLL_CFGCR0_DCO_INTEGER_MASK	(0x3ff)
-
-#define _ICL_DPLL0_CFGCR1		0x164004
-#define _ICL_DPLL1_CFGCR1		0x164084
-#define ICL_DPLL_CFGCR1(pll)		_MMIO_PLL(pll, _ICL_DPLL0_CFGCR1, \
-						  _ICL_DPLL1_CFGCR1)
-#define   DPLL_CFGCR1_QDIV_RATIO_MASK	(0xff << 10)
-#define   DPLL_CFGCR1_QDIV_RATIO_SHIFT	(10)
-#define   DPLL_CFGCR1_QDIV_RATIO(x)	((x) << 10)
-#define   DPLL_CFGCR1_QDIV_MODE_SHIFT	(9)
-#define   DPLL_CFGCR1_QDIV_MODE(x)	((x) << 9)
-#define   DPLL_CFGCR1_KDIV_MASK		(7 << 6)
-#define   DPLL_CFGCR1_KDIV_SHIFT		(6)
-#define   DPLL_CFGCR1_KDIV(x)		((x) << 6)
-#define   DPLL_CFGCR1_KDIV_1		(1 << 6)
-#define   DPLL_CFGCR1_KDIV_2		(2 << 6)
-#define   DPLL_CFGCR1_KDIV_3		(4 << 6)
-#define   DPLL_CFGCR1_PDIV_MASK		(0xf << 2)
-#define   DPLL_CFGCR1_PDIV_SHIFT		(2)
-#define   DPLL_CFGCR1_PDIV(x)		((x) << 2)
-#define   DPLL_CFGCR1_PDIV_2		(1 << 2)
-#define   DPLL_CFGCR1_PDIV_3		(2 << 2)
-#define   DPLL_CFGCR1_PDIV_5		(4 << 2)
-#define   DPLL_CFGCR1_PDIV_7		(8 << 2)
-#define   DPLL_CFGCR1_CENTRAL_FREQ	(3 << 0)
-#define   DPLL_CFGCR1_CENTRAL_FREQ_8400	(3 << 0)
-#define   TGL_DPLL_CFGCR1_CFSELOVRD_NORMAL_XTAL	(0 << 0)
-
-#define _TGL_DPLL0_CFGCR0		0x164284
-#define _TGL_DPLL1_CFGCR0		0x16428C
-#define _TGL_TBTPLL_CFGCR0		0x16429C
-#define TGL_DPLL_CFGCR0(pll)		_MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
-					      _TGL_DPLL0_CFGCR0, _TGL_DPLL1_CFGCR0,	\
-					      _TGL_TBTPLL_CFGCR0, _TGL_TBTPLL_CFGCR0))
-#define RKL_DPLL_CFGCR0(pll)		_MMIO_PLL(pll, _TGL_DPLL0_CFGCR0, \
-						  _TGL_DPLL1_CFGCR0)
-
-#define _TGL_DPLL0_DIV0					0x164B00
-#define _TGL_DPLL1_DIV0					0x164C00
-#define TGL_DPLL0_DIV0(pll)				_MMIO_PLL(pll, _TGL_DPLL0_DIV0, _TGL_DPLL1_DIV0)
-#define   TGL_DPLL0_DIV0_AFC_STARTUP_MASK		REG_GENMASK(27, 25)
-#define   TGL_DPLL0_DIV0_AFC_STARTUP(val)		REG_FIELD_PREP(TGL_DPLL0_DIV0_AFC_STARTUP_MASK, (val))
-
-#define _TGL_DPLL0_CFGCR1		0x164288
-#define _TGL_DPLL1_CFGCR1		0x164290
-#define _TGL_TBTPLL_CFGCR1		0x1642A0
-#define TGL_DPLL_CFGCR1(pll)		_MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
-					      _TGL_DPLL0_CFGCR1, _TGL_DPLL1_CFGCR1,	\
-					      _TGL_TBTPLL_CFGCR1, _TGL_TBTPLL_CFGCR1))
-#define RKL_DPLL_CFGCR1(pll)		_MMIO_PLL(pll, _TGL_DPLL0_CFGCR1, \
-						  _TGL_DPLL1_CFGCR1)
-
-#define _DG1_DPLL2_CFGCR0		0x16C284
-#define _DG1_DPLL3_CFGCR0		0x16C28C
-#define DG1_DPLL_CFGCR0(pll)		_MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
-					      _TGL_DPLL0_CFGCR0, _TGL_DPLL1_CFGCR0,	\
-					      _DG1_DPLL2_CFGCR0, _DG1_DPLL3_CFGCR0))
-
-#define _DG1_DPLL2_CFGCR1               0x16C288
-#define _DG1_DPLL3_CFGCR1               0x16C290
-#define DG1_DPLL_CFGCR1(pll)            _MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
-					      _TGL_DPLL0_CFGCR1, _TGL_DPLL1_CFGCR1,	\
-					      _DG1_DPLL2_CFGCR1, _DG1_DPLL3_CFGCR1))
-
-/* For ADL-S DPLL4_CFGCR0/1 are used to control DPLL2 */
-#define _ADLS_DPLL4_CFGCR0		0x164294
-#define _ADLS_DPLL3_CFGCR0		0x1642C0
-#define ADLS_DPLL_CFGCR0(pll)		_MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
-					      _TGL_DPLL0_CFGCR0, _TGL_DPLL1_CFGCR0,	\
-					      _ADLS_DPLL4_CFGCR0, _ADLS_DPLL3_CFGCR0))
-
-#define _ADLS_DPLL4_CFGCR1		0x164298
-#define _ADLS_DPLL3_CFGCR1		0x1642C4
-#define ADLS_DPLL_CFGCR1(pll)		_MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
-					      _TGL_DPLL0_CFGCR1, _TGL_DPLL1_CFGCR1,	\
-					      _ADLS_DPLL4_CFGCR1, _ADLS_DPLL3_CFGCR1))
-
-/* BXT display engine PLL */
-#define BXT_DE_PLL_CTL			_MMIO(0x6d000)
-#define   BXT_DE_PLL_RATIO(x)		(x)	/* {60,65,100} * 19.2MHz */
-#define   BXT_DE_PLL_RATIO_MASK		0xff
-
-#define BXT_DE_PLL_ENABLE		_MMIO(0x46070)
-#define   BXT_DE_PLL_PLL_ENABLE		(1 << 31)
-#define   BXT_DE_PLL_LOCK		(1 << 30)
-#define   BXT_DE_PLL_FREQ_REQ		(1 << 23)
-#define   BXT_DE_PLL_FREQ_REQ_ACK	(1 << 22)
-#define   ICL_CDCLK_PLL_RATIO(x)	(x)
-#define   ICL_CDCLK_PLL_RATIO_MASK	0xff
-
-/* GEN9 DC */
-#define DC_STATE_EN			_MMIO(0x45504)
-#define  DC_STATE_DISABLE		0
-#define  DC_STATE_EN_DC3CO		REG_BIT(30)
-#define  DC_STATE_DC3CO_STATUS		REG_BIT(29)
-#define  HOLD_PHY_CLKREQ_PG1_LATCH	REG_BIT(21)
-#define  HOLD_PHY_PG1_LATCH		REG_BIT(20)
-#define  DC_STATE_EN_UPTO_DC5		(1 << 0)
-#define  DC_STATE_EN_DC9		(1 << 3)
-#define  DC_STATE_EN_UPTO_DC6		(2 << 0)
-#define  DC_STATE_EN_UPTO_DC5_DC6_MASK   0x3
-
-#define  DC_STATE_DEBUG                  _MMIO(0x45520)
-#define  DC_STATE_DEBUG_MASK_CORES	(1 << 0)
-#define  DC_STATE_DEBUG_MASK_MEMORY_UP	(1 << 1)
-
-#define D_COMP_BDW			_MMIO(0x138144)
-
-/* Pipe WM_LINETIME - watermark line time */
-#define _WM_LINETIME_A		0x45270
-#define _WM_LINETIME_B		0x45274
-#define WM_LINETIME(pipe) _MMIO_PIPE(pipe, _WM_LINETIME_A, _WM_LINETIME_B)
-#define  HSW_LINETIME_MASK	REG_GENMASK(8, 0)
-#define  HSW_LINETIME(x)	REG_FIELD_PREP(HSW_LINETIME_MASK, (x))
-#define  HSW_IPS_LINETIME_MASK	REG_GENMASK(24, 16)
-#define  HSW_IPS_LINETIME(x)	REG_FIELD_PREP(HSW_IPS_LINETIME_MASK, (x))
-
-/* SFUSE_STRAP */
-#define SFUSE_STRAP			_MMIO(0xc2014)
-#define  SFUSE_STRAP_FUSE_LOCK		(1 << 13)
-#define  SFUSE_STRAP_RAW_FREQUENCY	(1 << 8)
-#define  SFUSE_STRAP_DISPLAY_DISABLED	(1 << 7)
-#define  SFUSE_STRAP_CRT_DISABLED	(1 << 6)
-#define  SFUSE_STRAP_DDIF_DETECTED	(1 << 3)
-#define  SFUSE_STRAP_DDIB_DETECTED	(1 << 2)
-#define  SFUSE_STRAP_DDIC_DETECTED	(1 << 1)
-#define  SFUSE_STRAP_DDID_DETECTED	(1 << 0)
-
-/* Gen4+ Timestamp and Pipe Frame time stamp registers */
-#define GEN4_TIMESTAMP		_MMIO(0x2358)
-#define ILK_TIMESTAMP_HI	_MMIO(0x70070)
-#define IVB_TIMESTAMP_CTR	_MMIO(0x44070)
-
 #define GEN9_TIMESTAMP_OVERRIDE				_MMIO(0x44074)
 #define  GEN9_TIMESTAMP_OVERRIDE_US_COUNTER_DIVIDER_SHIFT	0
 #define  GEN9_TIMESTAMP_OVERRIDE_US_COUNTER_DIVIDER_MASK	0x3ff
 #define  GEN9_TIMESTAMP_OVERRIDE_US_COUNTER_DENOMINATOR_SHIFT	12
 #define  GEN9_TIMESTAMP_OVERRIDE_US_COUNTER_DENOMINATOR_MASK	(0xf << 12)
 
-/* g4x+, except vlv/chv! */
-#define _PIPE_FRMTMSTMP_A		0x70048
-#define _PIPE_FRMTMSTMP_B		0x71048
-#define PIPE_FRMTMSTMP(pipe)		\
-	_MMIO_PIPE(pipe, _PIPE_FRMTMSTMP_A, _PIPE_FRMTMSTMP_B)
-
 /* g4x+, except vlv/chv! */
 #define _PIPE_FLIPTMSTMP_A		0x7004C
 #define _PIPE_FLIPTMSTMP_B		0x7104C
@@ -4152,12 +1461,6 @@ enum skl_power_gate {
 #define PIPE_FLIPDONETIMSTMP(pipe)	\
 	_MMIO_PIPE(pipe, _PIPE_FLIPDONETMSTMP_A, _PIPE_FLIPDONETMSTMP_B)
 
-#define _VLV_PIPE_MSA_MISC_A			0x70048
-#define VLV_PIPE_MSA_MISC(pipe)		\
-			_MMIO_PIPE2(dev_priv, pipe, _VLV_PIPE_MSA_MISC_A)
-#define   VLV_MSA_MISC1_HW_ENABLE			REG_BIT(31)
-#define   VLV_MSA_MISC1_SW_S3D_MASK			REG_GENMASK(2, 0) /* MSA MISC1 3:1 */
-
 #define GGC				_MMIO(0x108040)
 #define   GMS_MASK			REG_GENMASK(15, 8)
 #define   GGMS_MASK			REG_GENMASK(7, 6)
@@ -4172,45 +1475,6 @@ enum skl_power_gate {
 #define   SGGI_DIS			REG_BIT(15)
 #define   SGR_DIS			REG_BIT(13)
 
-#define _ICL_PHY_MISC_A		0x64C00
-#define _ICL_PHY_MISC_B		0x64C04
-#define _DG2_PHY_MISC_TC1	0x64C14 /* TC1="PHY E" but offset as if "PHY F" */
-#define ICL_PHY_MISC(port)	_MMIO_PORT(port, _ICL_PHY_MISC_A, _ICL_PHY_MISC_B)
-#define DG2_PHY_MISC(port)	((port) == PHY_E ? _MMIO(_DG2_PHY_MISC_TC1) : \
-				 ICL_PHY_MISC(port))
-#define  ICL_PHY_MISC_MUX_DDID			(1 << 28)
-#define  ICL_PHY_MISC_DE_IO_COMP_PWR_DOWN	(1 << 23)
-#define  DG2_PHY_DP_TX_ACK_MASK			REG_GENMASK(23, 20)
-
-#define PORT_TX_DFLEXDPSP(fia)			_MMIO_FIA((fia), 0x008A0)
-#define   MODULAR_FIA_MASK			(1 << 4)
-#define   TC_LIVE_STATE_TBT(idx)		(1 << ((idx) * 8 + 6))
-#define   TC_LIVE_STATE_TC(idx)			(1 << ((idx) * 8 + 5))
-#define   DP_LANE_ASSIGNMENT_SHIFT(idx)		((idx) * 8)
-#define   DP_LANE_ASSIGNMENT_MASK(idx)		(0xf << ((idx) * 8))
-#define   DP_LANE_ASSIGNMENT(idx, x)		((x) << ((idx) * 8))
-
-#define PORT_TX_DFLEXDPPMS(fia)			_MMIO_FIA((fia), 0x00890)
-#define   DP_PHY_MODE_STATUS_COMPLETED(idx)	(1 << (idx))
-
-#define PORT_TX_DFLEXDPCSSS(fia)		_MMIO_FIA((fia), 0x00894)
-#define   DP_PHY_MODE_STATUS_NOT_SAFE(idx)	(1 << (idx))
-
-#define PORT_TX_DFLEXPA1(fia)			_MMIO_FIA((fia), 0x00880)
-#define   DP_PIN_ASSIGNMENT_SHIFT(idx)		((idx) * 4)
-#define   DP_PIN_ASSIGNMENT_MASK(idx)		(0xf << ((idx) * 4))
-#define   DP_PIN_ASSIGNMENT(idx, x)		((x) << ((idx) * 4))
-
-#define _TCSS_DDI_STATUS_1			0x161500
-#define _TCSS_DDI_STATUS_2			0x161504
-#define TCSS_DDI_STATUS(tc)			_MMIO(_PICK_EVEN(tc, \
-								 _TCSS_DDI_STATUS_1, \
-								 _TCSS_DDI_STATUS_2))
-#define  TCSS_DDI_STATUS_PIN_ASSIGNMENT_MASK	REG_GENMASK(28, 25)
-#define  TCSS_DDI_STATUS_READY			REG_BIT(2)
-#define  TCSS_DDI_STATUS_HPD_LIVE_STATUS_TBT	REG_BIT(1)
-#define  TCSS_DDI_STATUS_HPD_LIVE_STATUS_ALT	REG_BIT(0)
-
 #define PRIMARY_SPI_TRIGGER			_MMIO(0x102040)
 #define PRIMARY_SPI_ADDRESS			_MMIO(0x102080)
 #define PRIMARY_SPI_REGIONID			_MMIO(0x102084)
@@ -4219,32 +1483,11 @@ enum skl_power_gate {
 #define OROM_OFFSET				_MMIO(0x1020c0)
 #define   OROM_OFFSET_MASK			REG_GENMASK(20, 16)
 
-#define CLKREQ_POLICY			_MMIO(0x101038)
-#define  CLKREQ_POLICY_MEM_UP_OVRD	REG_BIT(1)
-
-#define CLKGATE_DIS_MISC			_MMIO(0x46534)
-#define  CLKGATE_DIS_MISC_DMASC_GATING_DIS	REG_BIT(21)
-
-#define _MTL_CLKGATE_DIS_TRANS_A			0x604E8
-#define _MTL_CLKGATE_DIS_TRANS_B			0x614E8
-#define MTL_CLKGATE_DIS_TRANS(dev_priv, trans)			_MMIO_TRANS2(dev_priv, trans, _MTL_CLKGATE_DIS_TRANS_A)
-#define  MTL_CLKGATE_DIS_TRANS_DMASC_GATING_DIS		REG_BIT(7)
-
 #define MTL_MEM_SS_INFO_GLOBAL			_MMIO(0x45700)
 #define   MTL_N_OF_ENABLED_QGV_POINTS_MASK	REG_GENMASK(11, 8)
 #define   MTL_N_OF_POPULATED_CH_MASK		REG_GENMASK(7, 4)
 #define   MTL_DDR_TYPE_MASK			REG_GENMASK(3, 0)
 
-#define MTL_MEM_SS_INFO_QGV_POINT_OFFSET	0x45710
-#define MTL_MEM_SS_INFO_QGV_POINT_LOW(point)	_MMIO(MTL_MEM_SS_INFO_QGV_POINT_OFFSET + (point) * 8)
-#define   MTL_TRCD_MASK			REG_GENMASK(31, 24)
-#define   MTL_TRP_MASK			REG_GENMASK(23, 16)
-#define   MTL_DCLK_MASK			REG_GENMASK(15, 0)
-
-#define MTL_MEM_SS_INFO_QGV_POINT_HIGH(point)	_MMIO(MTL_MEM_SS_INFO_QGV_POINT_OFFSET + (point) * 8 + 4)
-#define   MTL_TRAS_MASK			REG_GENMASK(16, 8)
-#define   MTL_TRDPRE_MASK		REG_GENMASK(7, 0)
-
 #define MTL_MEDIA_GSI_BASE		0x380000
 
 #endif /* _I915_REG_H_ */
diff --git a/drivers/gpu/drm/i915/intel_gvt_mmio_table.c b/drivers/gpu/drm/i915/intel_gvt_mmio_table.c
index 04076316e139..0dca0b7e738c 100644
--- a/drivers/gpu/drm/i915/intel_gvt_mmio_table.c
+++ b/drivers/gpu/drm/i915/intel_gvt_mmio_table.c
@@ -30,6 +30,7 @@
 #include "i915_drv.h"
 #include "i915_pvinfo.h"
 #include "i915_reg.h"
+#include "display/intel_display_regs.h"
 #include "intel_gvt.h"
 #include "intel_mchbar_regs.h"
 
diff --git a/drivers/gpu/drm/xe/display/xe_plane_initial.c b/drivers/gpu/drm/xe/display/xe_plane_initial.c
index 4ca0cb571194..20dd6ed1f184 100644
--- a/drivers/gpu/drm/xe/display/xe_plane_initial.c
+++ b/drivers/gpu/drm/xe/display/xe_plane_initial.c
@@ -10,10 +10,10 @@
 #include "xe_ggtt.h"
 #include "xe_mmio.h"
 
-#include "i915_reg.h"
 #include "intel_atomic_plane.h"
 #include "intel_crtc.h"
 #include "intel_display.h"
+#include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_fb.h"
 #include "intel_fb_pin.h"
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: i915_reg.h display split
  2025-02-07 13:35 [PATCH 0/3] drm/i915: i915_reg.h display split Jani Nikula
                   ` (2 preceding siblings ...)
  2025-02-07 13:35 ` [PATCH 3/3] drm/i915: split out display register macros to a separate file Jani Nikula
@ 2025-02-07 16:12 ` Patchwork
  2025-02-07 19:54 ` ✗ i915.CI.BAT: failure " Patchwork
  4 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2025-02-07 16:12 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: i915_reg.h display split
URL   : https://patchwork.freedesktop.org/series/144505/
State : warning

== Summary ==

Error: dim checkpatch failed
dc241ad94e8c drm/i915/reg: use REG_BIT and friends to define DP registers
adfada3efcca drm/i915/reg: Remove some extra blank lines
01ac518767ad drm/i915: split out display register macros to a separate file
-:332: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#332: 
new file mode 100644

-:476: WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#476: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:140:
+#define   PHY_STATUS_SPLINE_LDO(phy, ch, spline)        (1 << (8 - (6 * (phy) + 3 * (ch) + (spline))))

-:774: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#774: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:438:
+ * The same register may be used for SDVO or HDMI */

-:855: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#855: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:519:
+ * of the infoframe structure specified by CEA-861. */

-:1044: WARNING:LONG_LINE: line length of 128 exceeds 100 columns
#1044: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:708:
+#define   TRANSCONF_FRAME_START_DELAY(x)		REG_FIELD_PREP(TRANSCONF_FRAME_START_DELAY_MASK, (x)) /* pre-hsw: 0-3 */

-:1051: WARNING:LONG_LINE_COMMENT: line length of 110 exceeds 100 columns
#1051: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:715:
+#define   TRANSCONF_GAMMA_MODE_12BIT		REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK_ILK, 2) /* ilk-ivb */

-:1052: WARNING:LONG_LINE_COMMENT: line length of 106 exceeds 100 columns
#1052: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:716:
+#define   TRANSCONF_GAMMA_MODE_SPLIT		REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK_ILK, 3) /* ivb */

-:1053: WARNING:LONG_LINE_COMMENT: line length of 130 exceeds 100 columns
#1053: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:717:
+#define   TRANSCONF_GAMMA_MODE(x)		REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK_ILK, (x)) /* pass in GAMMA_MODE_MODE_* */

-:1056: WARNING:LONG_LINE_COMMENT: line length of 115 exceeds 100 columns
#1056: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:720:
+#define   TRANSCONF_INTERLACE_W_SYNC_SHIFT_PANEL	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 4) /* gen4 only */

-:1057: WARNING:LONG_LINE_COMMENT: line length of 107 exceeds 100 columns
#1057: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:721:
+#define   TRANSCONF_INTERLACE_W_SYNC_SHIFT	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 5) /* gen4 only */

-:1059: WARNING:LONG_LINE_COMMENT: line length of 107 exceeds 100 columns
#1059: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:723:
+#define   TRANSCONF_INTERLACE_FIELD_0_ONLY	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 7) /* gen3 only */

-:1069: WARNING:LONG_LINE_COMMENT: line length of 114 exceeds 100 columns
#1069: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:733:
+#define   TRANSCONF_INTERLACE_IF_ID_DBL_ILK	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 4) /* ilk/snb only */

-:1070: WARNING:LONG_LINE_COMMENT: line length of 114 exceeds 100 columns
#1070: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:734:
+#define   TRANSCONF_INTERLACE_PF_ID_DBL_ILK	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 5) /* ilk/snb only */

-:1079: WARNING:LONG_LINE_COMMENT: line length of 113 exceeds 100 columns
#1079: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:743:
+#define   TRANSCONF_OUTPUT_COLORSPACE_RGB	REG_FIELD_PREP(TRANSCONF_OUTPUT_COLORSPACE_MASK, 0) /* ilk-ivb */

-:1080: WARNING:LONG_LINE_COMMENT: line length of 113 exceeds 100 columns
#1080: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:744:
+#define   TRANSCONF_OUTPUT_COLORSPACE_YUV601	REG_FIELD_PREP(TRANSCONF_OUTPUT_COLORSPACE_MASK, 1) /* ilk-ivb */

-:1081: WARNING:LONG_LINE_COMMENT: line length of 113 exceeds 100 columns
#1081: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:745:
+#define   TRANSCONF_OUTPUT_COLORSPACE_YUV709	REG_FIELD_PREP(TRANSCONF_OUTPUT_COLORSPACE_MASK, 2) /* ilk-ivb */

-:1323: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id' - possible side-effects?
#1323: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:987:
+#define SKL_PS_CTRL(pipe, id) _MMIO_PIPE(pipe,        \
+			_ID(id, _PS_1A_CTRL, _PS_2A_CTRL),       \
+			_ID(id, _PS_1B_CTRL, _PS_2B_CTRL))

-:1350: WARNING:LONG_LINE_COMMENT: line length of 107 exceeds 100 columns
#1350: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1014:
+#define   PS_PIPE_SCALER_LOC_AFTER_OUTPUT_CSC	REG_FIELD_PREP(PS_SCALER_LOCATION_MASK, 0) /* non-linear */

-:1351: WARNING:LONG_LINE_COMMENT: line length of 103 exceeds 100 columns
#1351: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1015:
+#define   PS_PIPE_SCALER_LOC_AFTER_CSC		REG_FIELD_PREP(PS_SCALER_LOCATION_MASK, 1) /* linear */

-:1378: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id' - possible side-effects?
#1378: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1042:
+#define SKL_PS_WIN_POS(pipe, id) _MMIO_PIPE(pipe,     \
+			_ID(id, _PS_WIN_POS_1A, _PS_WIN_POS_2A), \
+			_ID(id, _PS_WIN_POS_1B, _PS_WIN_POS_2B))

-:1391: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id' - possible side-effects?
#1391: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1055:
+#define SKL_PS_WIN_SZ(pipe, id)  _MMIO_PIPE(pipe,     \
+			_ID(id, _PS_WIN_SZ_1A, _PS_WIN_SZ_2A),   \
+			_ID(id, _PS_WIN_SZ_1B, _PS_WIN_SZ_2B))

-:1404: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id' - possible side-effects?
#1404: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1068:
+#define SKL_PS_VPHASE(pipe, id)  _MMIO_PIPE(pipe,     \
+			_ID(id, _PS_VPHASE_1A, _PS_VPHASE_2A),   \
+			_ID(id, _PS_VPHASE_1B, _PS_VPHASE_2B))

-:1419: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id' - possible side-effects?
#1419: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1083:
+#define SKL_PS_HPHASE(pipe, id)  _MMIO_PIPE(pipe,     \
+			_ID(id, _PS_HPHASE_1A, _PS_HPHASE_2A),   \
+			_ID(id, _PS_HPHASE_1B, _PS_HPHASE_2B))

-:1427: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id' - possible side-effects?
#1427: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1091:
+#define GLK_PS_COEF_INDEX_SET(pipe, id, set)  _MMIO_PIPE(pipe,    \
+			_ID(id, _PS_COEF_SET0_INDEX_1A, _PS_COEF_SET0_INDEX_2A) + (set) * 8, \
+			_ID(id, _PS_COEF_SET0_INDEX_1B, _PS_COEF_SET0_INDEX_2B) + (set) * 8)

-:1427: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'set' - possible side-effects?
#1427: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1091:
+#define GLK_PS_COEF_INDEX_SET(pipe, id, set)  _MMIO_PIPE(pipe,    \
+			_ID(id, _PS_COEF_SET0_INDEX_1A, _PS_COEF_SET0_INDEX_2A) + (set) * 8, \
+			_ID(id, _PS_COEF_SET0_INDEX_1B, _PS_COEF_SET0_INDEX_2B) + (set) * 8)

-:1436: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id' - possible side-effects?
#1436: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1100:
+#define GLK_PS_COEF_DATA_SET(pipe, id, set)  _MMIO_PIPE(pipe,     \
+			_ID(id, _PS_COEF_SET0_DATA_1A, _PS_COEF_SET0_DATA_2A) + (set) * 8, \
+			_ID(id, _PS_COEF_SET0_DATA_1B, _PS_COEF_SET0_DATA_2B) + (set) * 8)

-:1436: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'set' - possible side-effects?
#1436: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1100:
+#define GLK_PS_COEF_DATA_SET(pipe, id, set)  _MMIO_PIPE(pipe,     \
+			_ID(id, _PS_COEF_SET0_DATA_1A, _PS_COEF_SET0_DATA_2A) + (set) * 8, \
+			_ID(id, _PS_COEF_SET0_DATA_1B, _PS_COEF_SET0_DATA_2B) + (set) * 8)

-:1497: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plane_id' - possible side-effects?
#1497: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1161:
+#define  GEN9_PIPE_PLANE_FLIP_DONE(plane_id) \
+	REG_BIT(((plane_id) >= PLANE_5 ? 16 - PLANE_5 : 3 - PLANE_1) + (plane_id)) /* skl+ */

-:1503: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects?
#1503: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1167:
+#define GEN8_DE_PIPE_IRQ_REGS(pipe)	I915_IRQ_REGS(GEN8_DE_PIPE_IMR(pipe), \
+						      GEN8_DE_PIPE_IER(pipe), \
+						      GEN8_DE_PIPE_IIR(pipe))

-:1680: WARNING:LONG_LINE: line length of 120 exceeds 100 columns
#1680: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1344:
+#define CHICKEN_TRANS(display, trans)	(DISPLAY_VER(display) >= 14 ? _MTL_CHICKEN_TRANS(trans) : _CHICKEN_TRANS(trans))

-:1680: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'trans' - possible side-effects?
#1680: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1344:
+#define CHICKEN_TRANS(display, trans)	(DISPLAY_VER(display) >= 14 ? _MTL_CHICKEN_TRANS(trans) : _CHICKEN_TRANS(trans))

-:2006: WARNING:MACRO_ARG_UNUSED: Argument 'pipe' is not used in function-like macro
#2006: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1670:
+#define	 TRANS_DPLLA_SEL(pipe)		0

-:2048: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#2048: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1712:
+#define PCH_TRANS_VSYNCSHIFT(pipe)	_MMIO_PIPE(pipe, _PCH_TRANS_VSYNCSHIFT_A, _PCH_TRANS_VSYNCSHIFT_B)

-:2126: WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#2126: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1790:
+#define HSW_TVIDEO_DIP_CTL(dev_priv, trans)		_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_CTL_A)

-:2130: WARNING:LONG_LINE: line length of 122 exceeds 100 columns
#2130: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1794:
+#define HSW_TVIDEO_DIP_AVI_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_AVI_DATA_A + (i) * 4)

-:2134: WARNING:LONG_LINE: line length of 121 exceeds 100 columns
#2134: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1798:
+#define HSW_TVIDEO_DIP_VS_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_VS_DATA_A + (i) * 4)

-:2138: WARNING:LONG_LINE: line length of 122 exceeds 100 columns
#2138: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1802:
+#define HSW_TVIDEO_DIP_SPD_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_SPD_DATA_A + (i) * 4)

-:2142: WARNING:LONG_LINE: line length of 122 exceeds 100 columns
#2142: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1806:
+#define HSW_TVIDEO_DIP_GMP_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_GMP_DATA_A + (i) * 4)

-:2146: WARNING:LONG_LINE: line length of 122 exceeds 100 columns
#2146: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1810:
+#define HSW_TVIDEO_DIP_VSC_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_VSC_DATA_A + (i) * 4)

-:2156: WARNING:LONG_LINE: line length of 122 exceeds 100 columns
#2156: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1820:
+#define GLK_TVIDEO_DIP_DRM_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _GLK_VIDEO_DIP_DRM_DATA_A + (i) * 4)

-:2160: WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#2160: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1824:
+#define HSW_TVIDEO_DIP_GCP(dev_priv, trans)		_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_GCP_A)

-:2164: WARNING:LONG_LINE: line length of 122 exceeds 100 columns
#2164: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1828:
+#define ICL_VIDEO_DIP_PPS_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans, _ICL_VIDEO_DIP_PPS_DATA_A + (i) * 4)

-:2173: WARNING:LONG_LINE_COMMENT: line length of 104 exceeds 100 columns
#2173: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1837:
+#define  TRANS_FRAME_START_DELAY(x)	REG_FIELD_PREP(TRANS_FRAME_START_DELAY_MASK, (x)) /* ibx: 0-3 */

-:2211: WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#2211: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1875:
+#define TRANS_DP2_CTL(trans)			_MMIO_TRANS(trans, _TRANS_DP2_CTL_A, _TRANS_DP2_CTL_B)

-:2220: WARNING:LONG_LINE: line length of 114 exceeds 100 columns
#2220: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1884:
+#define TRANS_DP2_VFREQHIGH(trans)		_MMIO_TRANS(trans, _TRANS_DP2_VFREQHIGH_A, _TRANS_DP2_VFREQHIGH_B)

-:2222: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#2222: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1886:
+#define  TRANS_DP2_VFREQ_PIXEL_CLOCK(clk_hz)	REG_FIELD_PREP(TRANS_DP2_VFREQ_PIXEL_CLOCK_MASK, (clk_hz))

-:2228: WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#2228: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1892:
+#define TRANS_DP2_VFREQLOW(trans)		_MMIO_TRANS(trans, _TRANS_DP2_VFREQLOW_A, _TRANS_DP2_VFREQLOW_B)

-:2232: WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#2232: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1896:
+#define DP_MIN_HBLANK_CTL(trans)		_MMIO_TRANS(trans, _DP_MIN_HBLANK_CTL_A, _DP_MIN_HBLANK_CTL_B)

-:2413: WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#2413: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2077:
+#define  TRANS_DDI_PORT_SYNC_MASTER_SELECT(x)	REG_FIELD_PREP(TRANS_DDI_PORT_SYNC_MASTER_SELECT_MASK, (x))

-:2452: WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#2452: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2116:
+#define  PORT_SYNC_MODE_MASTER_SELECT(x)	REG_FIELD_PREP(PORT_SYNC_MODE_MASTER_SELECT_MASK, (x))

-:2494: WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#2494: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2158:
+#define   DP_TP_STATUS_STREAMS_ENABLED_MASK	REG_GENMASK(18, 16) /* 17:16 on hsw but bit 18 mbz */

-:2527: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#2527: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2191:
+#define DDI_BUF_TRANS_LO(port, i)	_MMIO(_PORT(port, _DDI_BUF_TRANS_A, _DDI_BUF_TRANS_B) + (i) * 8)

-:2529: WARNING:LONG_LINE: line length of 108 exceeds 100 columns
#2529: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2193:
+#define DDI_BUF_TRANS_HI(port, i)	_MMIO(_PORT(port, _DDI_BUF_TRANS_A, _DDI_BUF_TRANS_B) + (i) * 8 + 4)

-:2534: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#2534: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2198:
+#define DDI_DP_COMP_CTL(pipe)			_MMIO_PIPE(pipe, _DDI_DP_COMP_CTL_A, _DDI_DP_COMP_CTL_B)

-:2547: WARNING:LONG_LINE: line length of 116 exceeds 100 columns
#2547: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2211:
+#define DDI_DP_COMP_PAT(pipe, i)		_MMIO(_PIPE(pipe, _DDI_DP_COMP_PAT_A, _DDI_DP_COMP_PAT_B) + (i) * 4)

-:2660: WARNING:LONG_LINE: line length of 122 exceeds 100 columns
#2660: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2324:
+#define TRANS_SET_CONTEXT_LATENCY(dev_priv, tran)		_MMIO_TRANS2(dev_priv, tran, _TRANS_A_SET_CONTEXT_LATENCY)

-:2788: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc_port' - possible side-effects?
#2788: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2452:
+#define  ICL_DPCLKA_CFGCR0_TC_CLK_OFF(tc_port)	(1 << ((tc_port) < TC_PORT_4 ? \
+						       (tc_port) + 12 : \
+						       (tc_port) - TC_PORT_4 + 21))

-:2792: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#2792: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2456:
+#define  ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK(phy)	(3 << ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))

-:2793: WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#2793: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2457:
+#define  ICL_DPCLKA_CFGCR0_DDI_CLK_SEL(pll, phy)	((pll) << ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))

-:2815: WARNING:LONG_LINE: line length of 126 exceeds 100 columns
#2815: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2479:
+#define   DG1_DPCLKA_CFGCR0_DDI_CLK_SEL(pll, phy)	(_DG1_DPCLKA_PLL_IDX(pll) << DG1_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))

-:2816: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#2816: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2480:
+#define   DG1_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK(phy)	(0x3 << DG1_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))

-:2936: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#2936: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2600:
+#define TGL_DPLL0_DIV0(pll)				_MMIO_PLL(pll, _TGL_DPLL0_DIV0, _TGL_DPLL1_DIV0)

-:2938: WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#2938: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2602:
+#define   TGL_DPLL0_DIV0_AFC_STARTUP(val)		REG_FIELD_PREP(TGL_DPLL0_DIV0_AFC_STARTUP_MASK, (val))

-:3046: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'port' - possible side-effects?
#3046: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2710:
+#define DG2_PHY_MISC(port)	((port) == PHY_E ? _MMIO(_DG2_PHY_MISC_TC1) : \
+				 ICL_PHY_MISC(port))

-:3089: WARNING:LONG_LINE: line length of 119 exceeds 100 columns
#3089: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2753:
+#define MTL_CLKGATE_DIS_TRANS(dev_priv, trans)			_MMIO_TRANS2(dev_priv, trans, _MTL_CLKGATE_DIS_TRANS_A)

-:3093: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#3093: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2757:
+#define MTL_MEM_SS_INFO_QGV_POINT_LOW(point)	_MMIO(MTL_MEM_SS_INFO_QGV_POINT_OFFSET + (point) * 8)

-:3098: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#3098: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2762:
+#define MTL_MEM_SS_INFO_QGV_POINT_HIGH(point)	_MMIO(MTL_MEM_SS_INFO_QGV_POINT_OFFSET + (point) * 8 + 4)

-:3102: CHECK:LINE_SPACING: Please don't use multiple blank lines
#3102: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:2766:
+
+

total: 0 errors, 53 warnings, 15 checks, 6452 lines checked



^ permalink raw reply	[flat|nested] 15+ messages in thread

* ✗ i915.CI.BAT: failure for drm/i915: i915_reg.h display split
  2025-02-07 13:35 [PATCH 0/3] drm/i915: i915_reg.h display split Jani Nikula
                   ` (3 preceding siblings ...)
  2025-02-07 16:12 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: i915_reg.h display split Patchwork
@ 2025-02-07 19:54 ` Patchwork
  4 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2025-02-07 19:54 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

[-- Attachment #1: Type: text/plain, Size: 10578 bytes --]

== Series Details ==

Series: drm/i915: i915_reg.h display split
URL   : https://patchwork.freedesktop.org/series/144505/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_16084 -> Patchwork_144505v1
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_144505v1 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_144505v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/index.html

Participating hosts (45 -> 44)
------------------------------

  Additional (1): bat-arlh-2 
  Missing    (2): fi-snb-2520m fi-pnv-d510 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_144505v1:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live:
    - fi-hsw-4770:        [PASS][1] -> [DMESG-WARN][2] +1 other test dmesg-warn
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16084/fi-hsw-4770/igt@i915_selftest@live.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/fi-hsw-4770/igt@i915_selftest@live.html

  
Known issues
------------

  Here are the changes found in Patchwork_144505v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@debugfs_test@basic-hwmon:
    - bat-arlh-2:         NOTRUN -> [SKIP][3] ([i915#11346] / [i915#9318])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-arlh-2/igt@debugfs_test@basic-hwmon.html

  * igt@fbdev@eof:
    - bat-arlh-2:         NOTRUN -> [SKIP][4] ([i915#11345] / [i915#11346]) +3 other tests skip
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-arlh-2/igt@fbdev@eof.html

  * igt@fbdev@info:
    - bat-arlh-2:         NOTRUN -> [SKIP][5] ([i915#11346] / [i915#1849])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-arlh-2/igt@fbdev@info.html

  * igt@gem_lmem_swapping@basic:
    - bat-arlh-2:         NOTRUN -> [SKIP][6] ([i915#10213] / [i915#11346] / [i915#11671]) +3 other tests skip
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-arlh-2/igt@gem_lmem_swapping@basic.html

  * igt@gem_mmap@basic:
    - bat-arlh-2:         NOTRUN -> [SKIP][7] ([i915#11343] / [i915#11346])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-arlh-2/igt@gem_mmap@basic.html

  * igt@gem_render_tiled_blits@basic:
    - bat-arlh-2:         NOTRUN -> [SKIP][8] ([i915#10197] / [i915#10211] / [i915#11346] / [i915#11725])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-arlh-2/igt@gem_render_tiled_blits@basic.html

  * igt@gem_tiled_blits@basic:
    - bat-arlh-2:         NOTRUN -> [SKIP][9] ([i915#11346] / [i915#12637]) +4 other tests skip
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-arlh-2/igt@gem_tiled_blits@basic.html

  * igt@gem_tiled_pread_basic:
    - bat-arlh-2:         NOTRUN -> [SKIP][10] ([i915#10206] / [i915#11346] / [i915#11724])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-arlh-2/igt@gem_tiled_pread_basic.html

  * igt@i915_pm_rpm@module-reload:
    - bat-adls-6:         [PASS][11] -> [FAIL][12] ([i915#13633])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16084/bat-adls-6/igt@i915_pm_rpm@module-reload.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-adls-6/igt@i915_pm_rpm@module-reload.html
    - bat-rpls-4:         [PASS][13] -> [FAIL][14] ([i915#13633])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16084/bat-rpls-4/igt@i915_pm_rpm@module-reload.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-rpls-4/igt@i915_pm_rpm@module-reload.html

  * igt@i915_pm_rps@basic-api:
    - bat-arlh-2:         NOTRUN -> [SKIP][15] ([i915#10209] / [i915#11346] / [i915#11681])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-arlh-2/igt@i915_pm_rps@basic-api.html

  * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
    - bat-arlh-2:         NOTRUN -> [SKIP][16] ([i915#10200] / [i915#11346] / [i915#11666] / [i915#12203])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-arlh-2/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html

  * igt@kms_addfb_basic@basic-x-tiled-legacy:
    - bat-arlh-2:         NOTRUN -> [SKIP][17] ([i915#10200] / [i915#11346] / [i915#11666]) +8 other tests skip
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-arlh-2/igt@kms_addfb_basic@basic-x-tiled-legacy.html

  * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
    - bat-dg2-11:         [PASS][18] -> [SKIP][19] ([i915#9197]) +3 other tests skip
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16084/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html

  * igt@kms_psr@psr-primary-page-flip:
    - bat-arlh-2:         NOTRUN -> [SKIP][20] ([i915#11346]) +32 other tests skip
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-arlh-2/igt@kms_psr@psr-primary-page-flip.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - bat-arlh-2:         NOTRUN -> [SKIP][21] ([i915#10208] / [i915#11346] / [i915#8809])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-arlh-2/igt@kms_setmode@basic-clone-single-crtc.html

  * igt@prime_vgem@basic-fence-read:
    - bat-arlh-2:         NOTRUN -> [SKIP][22] ([i915#10212] / [i915#11346] / [i915#11726])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-arlh-2/igt@prime_vgem@basic-fence-read.html

  * igt@prime_vgem@basic-read:
    - bat-arlh-2:         NOTRUN -> [SKIP][23] ([i915#10214] / [i915#11346] / [i915#11726])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-arlh-2/igt@prime_vgem@basic-read.html

  * igt@prime_vgem@basic-write:
    - bat-arlh-2:         NOTRUN -> [SKIP][24] ([i915#10216] / [i915#11346] / [i915#11723])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-arlh-2/igt@prime_vgem@basic-write.html

  
#### Possible fixes ####

  * igt@i915_module_load@load:
    - bat-mtlp-9:         [DMESG-WARN][25] ([i915#13494]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16084/bat-mtlp-9/igt@i915_module_load@load.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-mtlp-9/igt@i915_module_load@load.html

  * igt@i915_selftest@live@workarounds:
    - bat-arlh-3:         [DMESG-FAIL][27] ([i915#12061]) -> [PASS][28] +1 other test pass
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16084/bat-arlh-3/igt@i915_selftest@live@workarounds.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-arlh-3/igt@i915_selftest@live@workarounds.html
    - bat-arls-5:         [DMESG-FAIL][29] ([i915#12061]) -> [PASS][30] +1 other test pass
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16084/bat-arls-5/igt@i915_selftest@live@workarounds.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-arls-5/igt@i915_selftest@live@workarounds.html
    - bat-mtlp-9:         [DMESG-FAIL][31] ([i915#12061]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16084/bat-mtlp-9/igt@i915_selftest@live@workarounds.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/bat-mtlp-9/igt@i915_selftest@live@workarounds.html

  
  [i915#10197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10197
  [i915#10200]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10200
  [i915#10206]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10206
  [i915#10208]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10208
  [i915#10209]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10209
  [i915#10211]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10211
  [i915#10212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10212
  [i915#10213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10213
  [i915#10214]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10214
  [i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216
  [i915#11343]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11343
  [i915#11345]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11345
  [i915#11346]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11346
  [i915#11666]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11666
  [i915#11671]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11671
  [i915#11681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11681
  [i915#11723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11723
  [i915#11724]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11724
  [i915#11725]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11725
  [i915#11726]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11726
  [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
  [i915#12203]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12203
  [i915#12637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12637
  [i915#13494]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13494
  [i915#13633]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13633
  [i915#1849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1849
  [i915#8809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8809
  [i915#9197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9197
  [i915#9318]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9318


Build changes
-------------

  * Linux: CI_DRM_16084 -> Patchwork_144505v1

  CI-20190529: 20190529
  CI_DRM_16084: f8ea772f4fb5a761d1dc321aad5749633d0801eb @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_8224: c659b986ba648584d36b3cfece897bc84a33dcbb @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_144505v1: f8ea772f4fb5a761d1dc321aad5749633d0801eb @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144505v1/index.html

[-- Attachment #2: Type: text/html, Size: 13241 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [PATCH 1/3] drm/i915/reg: use REG_BIT and friends to define DP registers
  2025-02-07 13:35 ` [PATCH 1/3] drm/i915/reg: use REG_BIT and friends to define DP registers Jani Nikula
@ 2025-02-12  8:07   ` Kandpal, Suraj
  2025-02-12  9:39     ` Jani Nikula
  0 siblings, 1 reply; 15+ messages in thread
From: Kandpal, Suraj @ 2025-02-12  8:07 UTC (permalink / raw)
  To: Nikula, Jani, intel-gfx@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org
  Cc: Nikula, Jani, ville.syrjala@linux.intel.com, Deak, Imre



> -----Original Message-----
> From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf Of Jani
> Nikula
> Sent: Friday, February 7, 2025 7:05 PM
> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org
> Cc: Nikula, Jani <jani.nikula@intel.com>; ville.syrjala@linux.intel.com; Deak,
> Imre <imre.deak@intel.com>
> Subject: [PATCH 1/3] drm/i915/reg: use REG_BIT and friends to define DP
> registers
> 
> Define the DP register contents using the REG_BIT, REG_GENMASK, etc.
> macros. Ditch the unhelpful comments. Rename eDP related register content
> macros to have EDP_ prefix.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/display/g4x_dp.c |  23 +++--
>  drivers/gpu/drm/i915/i915_reg.h       | 124 +++++++++-----------------
>  2 files changed, 54 insertions(+), 93 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/g4x_dp.c
> b/drivers/gpu/drm/i915/display/g4x_dp.c
> index 56353377466c..a82102d3a167 100644
> --- a/drivers/gpu/drm/i915/display/g4x_dp.c
> +++ b/drivers/gpu/drm/i915/display/g4x_dp.c
> @@ -183,7 +183,7 @@ static void assert_dp_port(struct intel_dp *intel_dp,
> bool state)  static void assert_edp_pll(struct drm_i915_private *dev_priv,
> bool state)  {
>  	struct intel_display *display = &dev_priv->display;
> -	bool cur_state = intel_de_read(display, DP_A) & DP_PLL_ENABLE;
> +	bool cur_state = intel_de_read(display, DP_A) & EDP_PLL_ENABLE;
> 
>  	INTEL_DISPLAY_STATE_WARN(display, cur_state != state,
>  				 "eDP PLL state assertion failure (expected
> %s, current %s)\n", @@ -206,12 +206,12 @@ static void
> ilk_edp_pll_on(struct intel_dp *intel_dp,
>  	drm_dbg_kms(display->drm, "enabling eDP PLL for clock %d\n",
>  		    pipe_config->port_clock);
> 
> -	intel_dp->DP &= ~DP_PLL_FREQ_MASK;
> +	intel_dp->DP &= ~EDP_PLL_FREQ_MASK;
> 
>  	if (pipe_config->port_clock == 162000)
> -		intel_dp->DP |= DP_PLL_FREQ_162MHZ;
> +		intel_dp->DP |= EDP_PLL_FREQ_162MHZ;
>  	else
> -		intel_dp->DP |= DP_PLL_FREQ_270MHZ;
> +		intel_dp->DP |= EDP_PLL_FREQ_270MHZ;
> 
>  	intel_de_write(display, DP_A, intel_dp->DP);
>  	intel_de_posting_read(display, DP_A);
> @@ -226,7 +226,7 @@ static void ilk_edp_pll_on(struct intel_dp *intel_dp,
>  	if (IS_IRONLAKE(dev_priv))
>  		intel_wait_for_vblank_if_active(dev_priv, !crtc->pipe);
> 
> -	intel_dp->DP |= DP_PLL_ENABLE;
> +	intel_dp->DP |= EDP_PLL_ENABLE;
> 
>  	intel_de_write(display, DP_A, intel_dp->DP);
>  	intel_de_posting_read(display, DP_A);
> @@ -246,7 +246,7 @@ static void ilk_edp_pll_off(struct intel_dp *intel_dp,
> 
>  	drm_dbg_kms(display->drm, "disabling eDP PLL\n");
> 
> -	intel_dp->DP &= ~DP_PLL_ENABLE;
> +	intel_dp->DP &= ~EDP_PLL_ENABLE;
> 
>  	intel_de_write(display, DP_A, intel_dp->DP);
>  	intel_de_posting_read(display, DP_A);
> @@ -291,13 +291,13 @@ bool g4x_dp_port_enabled(struct
> drm_i915_private *dev_priv,
> 
>  	/* asserts want to know the pipe even if the port is disabled */
>  	if (IS_IVYBRIDGE(dev_priv) && port == PORT_A)
> -		*pipe = (val & DP_PIPE_SEL_MASK_IVB) >>
> DP_PIPE_SEL_SHIFT_IVB;
> +		*pipe = REG_FIELD_GET(DP_PIPE_SEL_MASK_IVB, val);
>  	else if (HAS_PCH_CPT(dev_priv) && port != PORT_A)
>  		ret &= cpt_dp_port_selected(dev_priv, port, pipe);
>  	else if (IS_CHERRYVIEW(dev_priv))
> -		*pipe = (val & DP_PIPE_SEL_MASK_CHV) >>
> DP_PIPE_SEL_SHIFT_CHV;
> +		*pipe = REG_FIELD_GET(DP_PIPE_SEL_MASK_CHV, val);
>  	else
> -		*pipe = (val & DP_PIPE_SEL_MASK) >> DP_PIPE_SEL_SHIFT;
> +		*pipe = REG_FIELD_GET(DP_PIPE_SEL_MASK, val);
> 
>  	return ret;
>  }
> @@ -393,13 +393,12 @@ static void intel_dp_get_config(struct
> intel_encoder *encoder,
>  	if (IS_G4X(dev_priv) && tmp & DP_COLOR_RANGE_16_235)
>  		pipe_config->limited_color_range = true;
> 
> -	pipe_config->lane_count =
> -		((tmp & DP_PORT_WIDTH_MASK) >>
> DP_PORT_WIDTH_SHIFT) + 1;
> +	pipe_config->lane_count = REG_FIELD_GET(DP_PORT_WIDTH_MASK,
> tmp) + 1;
> 
>  	g4x_dp_get_m_n(pipe_config);
> 
>  	if (port == PORT_A) {
> -		if ((intel_de_read(display, DP_A) & DP_PLL_FREQ_MASK) ==
> DP_PLL_FREQ_162MHZ)
> +		if ((intel_de_read(display, DP_A) & EDP_PLL_FREQ_MASK) ==
> +EDP_PLL_FREQ_162MHZ)
>  			pipe_config->port_clock = 162000;
>  		else
>  			pipe_config->port_clock = 270000;
> diff --git a/drivers/gpu/drm/i915/i915_reg.h
> b/drivers/gpu/drm/i915/i915_reg.h index 670cd2371f94..da658c3591f0
> 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -1394,88 +1394,50 @@
>  #define VLV_DP_B		_MMIO(VLV_DISPLAY_BASE + 0x64100)
>  #define VLV_DP_C		_MMIO(VLV_DISPLAY_BASE + 0x64200)
>  #define CHV_DP_D		_MMIO(VLV_DISPLAY_BASE + 0x64300)
> -#define   DP_PORT_EN			(1 << 31)
> -#define   DP_PIPE_SEL_SHIFT		30
> -#define   DP_PIPE_SEL_MASK		(1 << 30)
> -#define   DP_PIPE_SEL(pipe)		((pipe) << 30)
> -#define   DP_PIPE_SEL_SHIFT_IVB		29
> -#define   DP_PIPE_SEL_MASK_IVB		(3 << 29)
> -#define   DP_PIPE_SEL_IVB(pipe)		((pipe) << 29)
> +#define   DP_PORT_EN			REG_BIT(31)
> +#define   DP_PIPE_SEL_MASK		REG_GENMASK(30, 30)

Why not use REG_BIT() here REG_GENMASK for a single bit seems wrong

Regards,
Suraj Kandpal

> +#define   DP_PIPE_SEL(pipe)		REG_FIELD_PREP(DP_PIPE_SEL_MASK,
> (pipe))
> +#define   DP_PIPE_SEL_MASK_IVB		REG_GENMASK(30, 29)
> +#define   DP_PIPE_SEL_IVB(pipe)
> 	REG_FIELD_PREP(DP_PIPE_SEL_MASK_IVB, (pipe))
>  #define   DP_PIPE_SEL_SHIFT_CHV		16
> -#define   DP_PIPE_SEL_MASK_CHV		(3 << 16)
> -#define   DP_PIPE_SEL_CHV(pipe)		((pipe) << 16)
> -
> -/* Link training mode - select a suitable mode for each stage */
> -#define   DP_LINK_TRAIN_PAT_1		(0 << 28)
> -#define   DP_LINK_TRAIN_PAT_2		(1 << 28)
> -#define   DP_LINK_TRAIN_PAT_IDLE	(2 << 28)
> -#define   DP_LINK_TRAIN_OFF		(3 << 28)
> -#define   DP_LINK_TRAIN_MASK		(3 << 28)
> -#define   DP_LINK_TRAIN_SHIFT		28
> -
> -/* CPT Link training mode */
> -#define   DP_LINK_TRAIN_PAT_1_CPT	(0 << 8)
> -#define   DP_LINK_TRAIN_PAT_2_CPT	(1 << 8)
> -#define   DP_LINK_TRAIN_PAT_IDLE_CPT	(2 << 8)
> -#define   DP_LINK_TRAIN_OFF_CPT		(3 << 8)
> -#define   DP_LINK_TRAIN_MASK_CPT	(7 << 8)
> -#define   DP_LINK_TRAIN_SHIFT_CPT	8
> -
> -/* Signal voltages. These are mostly controlled by the other end */
> -#define   DP_VOLTAGE_0_4		(0 << 25)
> -#define   DP_VOLTAGE_0_6		(1 << 25)
> -#define   DP_VOLTAGE_0_8		(2 << 25)
> -#define   DP_VOLTAGE_1_2		(3 << 25)
> -#define   DP_VOLTAGE_MASK		(7 << 25)
> -#define   DP_VOLTAGE_SHIFT		25
> -
> -/* Signal pre-emphasis levels, like voltages, the other end tells us what
> - * they want
> - */
> -#define   DP_PRE_EMPHASIS_0		(0 << 22)
> -#define   DP_PRE_EMPHASIS_3_5		(1 << 22)
> -#define   DP_PRE_EMPHASIS_6		(2 << 22)
> -#define   DP_PRE_EMPHASIS_9_5		(3 << 22)
> -#define   DP_PRE_EMPHASIS_MASK		(7 << 22)
> -#define   DP_PRE_EMPHASIS_SHIFT		22
> -
> -/* How many wires to use. I guess 3 was too hard */
> -#define   DP_PORT_WIDTH(width)		(((width) - 1) << 19)
> -#define   DP_PORT_WIDTH_MASK		(7 << 19)
> -#define   DP_PORT_WIDTH_SHIFT		19
> -
> -/* Mystic DPCD version 1.1 special mode */
> -#define   DP_ENHANCED_FRAMING		(1 << 18)
> -
> -/* eDP */
> -#define   DP_PLL_FREQ_270MHZ		(0 << 16)
> -#define   DP_PLL_FREQ_162MHZ		(1 << 16)
> -#define   DP_PLL_FREQ_MASK		(3 << 16)
> -
> -/* locked once port is enabled */
> -#define   DP_PORT_REVERSAL		(1 << 15)
> -
> -/* eDP */
> -#define   DP_PLL_ENABLE			(1 << 14)
> -
> -/* sends the clock on lane 15 of the PEG for debug */
> -#define   DP_CLOCK_OUTPUT_ENABLE	(1 << 13)
> -
> -#define   DP_SCRAMBLING_DISABLE		(1 << 12)
> -#define   DP_SCRAMBLING_DISABLE_IRONLAKE	(1 << 7)
> -
> -/* limit RGB values to avoid confusing TVs */
> -#define   DP_COLOR_RANGE_16_235		(1 << 8)
> -
> -/* Turn on the audio link */
> -#define   DP_AUDIO_OUTPUT_ENABLE	(1 << 6)
> -
> -/* vs and hs sync polarity */
> -#define   DP_SYNC_VS_HIGH		(1 << 4)
> -#define   DP_SYNC_HS_HIGH		(1 << 3)
> -
> -/* A fantasy */
> -#define   DP_DETECTED			(1 << 2)
> +#define   DP_PIPE_SEL_MASK_CHV		REG_GENMASK(17, 16)
> +#define   DP_PIPE_SEL_CHV(pipe)
> 	REG_FIELD_PREP(DP_PIPE_SEL_MASK_CHV, (pipe))
> +#define   DP_LINK_TRAIN_MASK		REG_GENMASK(29, 28)
> +#define   DP_LINK_TRAIN_PAT_1
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 0)
> +#define   DP_LINK_TRAIN_PAT_2
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 1)
> +#define   DP_LINK_TRAIN_PAT_IDLE
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 2)
> +#define   DP_LINK_TRAIN_OFF
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 3)
> +#define   DP_LINK_TRAIN_MASK_CPT	REG_GENMASK(10, 8)
> +#define   DP_LINK_TRAIN_PAT_1_CPT
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 0)
> +#define   DP_LINK_TRAIN_PAT_2_CPT
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 1)
> +#define   DP_LINK_TRAIN_PAT_IDLE_CPT
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 2)
> +#define   DP_LINK_TRAIN_OFF_CPT
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 3)
> +#define   DP_VOLTAGE_MASK		REG_GENMASK(27, 25)
> +#define   DP_VOLTAGE_0_4
> 	REG_FIELD_PREP(DP_VOLTAGE_MASK, 0)
> +#define   DP_VOLTAGE_0_6
> 	REG_FIELD_PREP(DP_VOLTAGE_MASK, 1)
> +#define   DP_VOLTAGE_0_8
> 	REG_FIELD_PREP(DP_VOLTAGE_MASK, 2)
> +#define   DP_VOLTAGE_1_2
> 	REG_FIELD_PREP(DP_VOLTAGE_MASK, 3)
> +#define   DP_PRE_EMPHASIS_MASK		REG_GENMASK(24, 22)
> +#define   DP_PRE_EMPHASIS_0
> 	REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 0)
> +#define   DP_PRE_EMPHASIS_3_5
> 	REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 1)
> +#define   DP_PRE_EMPHASIS_6
> 	REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 2)
> +#define   DP_PRE_EMPHASIS_9_5
> 	REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 3)
> +#define   DP_PORT_WIDTH_MASK		REG_GENMASK(21, 19)
> +#define   DP_PORT_WIDTH(width)
> 	REG_FIELD_PREP(DP_PORT_WIDTH_MASK, (width) - 1)
> +#define   DP_ENHANCED_FRAMING		REG_BIT(18)
> +#define   EDP_PLL_FREQ_MASK		REG_GENMASK(17, 16)
> +#define   EDP_PLL_FREQ_270MHZ
> 	REG_FIELD_PREP(EDP_PLL_FREQ_MASK, 0)
> +#define   EDP_PLL_FREQ_162MHZ
> 	REG_FIELD_PREP(EDP_PLL_FREQ_MASK, 1)
> +#define   DP_PORT_REVERSAL		REG_BIT(15)
> +#define   EDP_PLL_ENABLE		REG_BIT(14)
> +#define   DP_CLOCK_OUTPUT_ENABLE	REG_BIT(13)
> +#define   DP_SCRAMBLING_DISABLE		REG_BIT(12)
> +#define   DP_SCRAMBLING_DISABLE_ILK	REG_BIT(7)
> +#define   DP_COLOR_RANGE_16_235		REG_BIT(8)
> +#define   DP_AUDIO_OUTPUT_ENABLE	REG_BIT(6)
> +#define   DP_SYNC_VS_HIGH		REG_BIT(4)
> +#define   DP_SYNC_HS_HIGH		REG_BIT(3)
> +#define   DP_DETECTED			REG_BIT(2)
> 
>  /*
>   * Computing GMCH M and N values for the Display Port link
> --
> 2.39.5


^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [PATCH 2/3] drm/i915/reg: Remove some extra blank lines
  2025-02-07 13:35 ` [PATCH 2/3] drm/i915/reg: Remove some extra blank lines Jani Nikula
@ 2025-02-12  8:07   ` Kandpal, Suraj
  0 siblings, 0 replies; 15+ messages in thread
From: Kandpal, Suraj @ 2025-02-12  8:07 UTC (permalink / raw)
  To: Nikula, Jani, intel-gfx@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org
  Cc: Nikula, Jani, ville.syrjala@linux.intel.com, Deak, Imre



> -----Original Message-----
> From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf Of Jani
> Nikula
> Sent: Friday, February 7, 2025 7:05 PM
> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org
> Cc: Nikula, Jani <jani.nikula@intel.com>; ville.syrjala@linux.intel.com; Deak,
> Imre <imre.deak@intel.com>
> Subject: [PATCH 2/3] drm/i915/reg: Remove some extra blank lines
> 
> Remove some blank lines from i915_reg.h primarily to help the scripted
> refactoring coming up, keeping the comments together.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

LGTM,
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>

> ---
>  drivers/gpu/drm/i915/i915_reg.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_reg.h
> b/drivers/gpu/drm/i915/i915_reg.h index da658c3591f0..6e80508b544c
> 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -1016,7 +1016,6 @@
>  /*
>   * Overlay regs
>   */
> -
>  #define OVADD			_MMIO(0x30000)
>  #define DOVSTA			_MMIO(0x30008)
>  #define OC_BUF			(0x3 << 20)
> @@ -1071,7 +1070,6 @@
>  /*
>   * Display engine regs
>   */
> -
>  /* Pipe/transcoder A timing regs */
>  #define _TRANS_HTOTAL_A		0x60000
>  #define _TRANS_HTOTAL_B		0x61000
> @@ -2781,7 +2779,6 @@
>   * functionality covered in PCH_PORT_HOTPLUG is split into
>   * SHOTPLUG_CTL_DDI and SHOTPLUG_CTL_TC.
>   */
> -
>  #define SHOTPLUG_CTL_DDI				_MMIO(0xc4030)
>  #define   SHOTPLUG_CTL_DDI_HPD_ENABLE(hpd_pin)			(0x8
> << (_HPD_PIN_DDI(hpd_pin) * 4))
>  #define   SHOTPLUG_CTL_DDI_HPD_OUTPUT_DATA(hpd_pin)		(0x4
> << (_HPD_PIN_DDI(hpd_pin) * 4))
> @@ -2861,7 +2858,6 @@
>  #define  TRANS_DPLL_ENABLE(pipe)	(1 << ((pipe) * 4 + 3))
> 
>  /* transcoder */
> -
>  #define _PCH_TRANS_HTOTAL_A		0xe0000
>  #define _PCH_TRANS_HTOTAL_B		0xe1000
>  #define PCH_TRANS_HTOTAL(pipe)		_MMIO_PIPE(pipe,
> _PCH_TRANS_HTOTAL_A, _PCH_TRANS_HTOTAL_B)
> @@ -3787,7 +3783,6 @@ enum skl_power_gate {
>  /*
>   * SKL Clocks
>   */
> -
>  /* CDCLK_CTL */
>  #define CDCLK_CTL			_MMIO(0x46000)
>  #define  CDCLK_FREQ_SEL_MASK		REG_GENMASK(27, 26)
> --
> 2.39.5


^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [PATCH 3/3] drm/i915: split out display register macros to a separate file
  2025-02-07 13:35 ` [PATCH 3/3] drm/i915: split out display register macros to a separate file Jani Nikula
@ 2025-02-12  8:48   ` Kandpal, Suraj
  2025-02-12  9:41     ` Jani Nikula
  2025-02-12 14:45   ` Ville Syrjälä
  1 sibling, 1 reply; 15+ messages in thread
From: Kandpal, Suraj @ 2025-02-12  8:48 UTC (permalink / raw)
  To: Nikula, Jani, intel-gfx@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org
  Cc: Nikula, Jani, ville.syrjala@linux.intel.com, Deak, Imre



> -----Original Message-----
> From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf Of Jani
> Nikula
> Sent: Friday, February 7, 2025 7:05 PM
> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org
> Cc: Nikula, Jani <jani.nikula@intel.com>; ville.syrjala@linux.intel.com; Deak,
> Imre <imre.deak@intel.com>
> Subject: [PATCH 3/3] drm/i915: split out display register macros to a
> separate file
> 
> This is a scripted split of the display related register macros from
> i915_reg.h to display/intel_display_regs.h. Basically move all the
> macros that are only used in display code (or GVT). If there are users
> in core i915 code or soc/, or no users anywhere, keep the macros in
> i915_reg.h. This is done in groups of macros separated by blank lines,
> moving the comments along with the groups.
> 
> This is obviously a very crude approach. It's not perfect. But there are
> 4.2k lines in i915_reg.h, and its refactoring has ground to a halt. This
> is the big hammer that splits the file to two, and enables further
> cleanup.
> 

This is a really big patch and I may have very well missed something but
Seeing that this is majorly code movement and things like conversion of 1<<x
To reg_bit will need to happen In a different patch or series LGTM,
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>

> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/display/g4x_dp.c         |    1 +
>  drivers/gpu/drm/i915/display/g4x_hdmi.c       |    1 +
>  drivers/gpu/drm/i915/display/hsw_ips.c        |    1 +
>  .../gpu/drm/i915/display/i9xx_display_sr.c    |    1 +
>  drivers/gpu/drm/i915/display/i9xx_plane.c     |    2 +
>  drivers/gpu/drm/i915/display/i9xx_wm.c        |    1 +
>  drivers/gpu/drm/i915/display/icl_dsi.c        |    1 +
>  .../gpu/drm/i915/display/intel_backlight.c    |    2 +-
>  drivers/gpu/drm/i915/display/intel_bw.c       |    3 +-
>  drivers/gpu/drm/i915/display/intel_cdclk.c    |    1 +
>  drivers/gpu/drm/i915/display/intel_cmtg.c     |    3 +-
>  .../gpu/drm/i915/display/intel_combo_phy.c    |    1 +
>  drivers/gpu/drm/i915/display/intel_crt.c      |    1 +
>  drivers/gpu/drm/i915/display/intel_ddi.c      |    1 +
>  drivers/gpu/drm/i915/display/intel_display.c  |    3 +-
>  .../drm/i915/display/intel_display_debugfs.c  |    1 +
>  .../drm/i915/display/intel_display_device.c   |    6 +-
>  .../gpu/drm/i915/display/intel_display_irq.c  |    2 +
>  .../drm/i915/display/intel_display_power.c    |    1 +
>  .../i915/display/intel_display_power_map.c    |    1 +
>  .../i915/display/intel_display_power_well.c   |    1 +
>  .../gpu/drm/i915/display/intel_display_regs.h | 2768 +++++++++++++++++
>  .../gpu/drm/i915/display/intel_display_wa.c   |    1 +
>  drivers/gpu/drm/i915/display/intel_dmc.c      |    1 +
>  drivers/gpu/drm/i915/display/intel_dmc_wl.c   |    1 +
>  drivers/gpu/drm/i915/display/intel_dp.c       |    6 +-
>  drivers/gpu/drm/i915/display/intel_dp_hdcp.c  |    1 +
>  drivers/gpu/drm/i915/display/intel_dp_mst.c   |    1 +
>  drivers/gpu/drm/i915/display/intel_dp_test.c  |    1 +
>  drivers/gpu/drm/i915/display/intel_dpio_phy.c |    1 +
>  drivers/gpu/drm/i915/display/intel_dpll.c     |    1 +
>  drivers/gpu/drm/i915/display/intel_dpll_mgr.c |    1 +
>  .../gpu/drm/i915/display/intel_dpt_common.c   |    1 +
>  drivers/gpu/drm/i915/display/intel_drrs.c     |    1 +
>  drivers/gpu/drm/i915/display/intel_dsb.c      |    1 +
>  drivers/gpu/drm/i915/display/intel_dsi_vbt.c  |    3 +-
>  drivers/gpu/drm/i915/display/intel_dvo.c      |    1 +
>  drivers/gpu/drm/i915/display/intel_fbc.c      |    3 +
>  drivers/gpu/drm/i915/display/intel_fdi.c      |    3 +-
>  .../drm/i915/display/intel_fifo_underrun.c    |    1 +
>  drivers/gpu/drm/i915/display/intel_gmbus.c    |    1 +
>  drivers/gpu/drm/i915/display/intel_hdcp.c     |    1 +
>  drivers/gpu/drm/i915/display/intel_hdmi.c     |    2 +-
>  .../gpu/drm/i915/display/intel_hotplug_irq.c  |    1 +
>  drivers/gpu/drm/i915/display/intel_lspcon.c   |    1 +
>  drivers/gpu/drm/i915/display/intel_lvds.c     |    3 +-
>  .../drm/i915/display/intel_modeset_setup.c    |    3 +-
>  drivers/gpu/drm/i915/display/intel_overlay.c  |    2 +
>  .../gpu/drm/i915/display/intel_pch_display.c  |    1 +
>  .../gpu/drm/i915/display/intel_pch_refclk.c   |    1 +
>  drivers/gpu/drm/i915/display/intel_pfit.c     |    1 +
>  drivers/gpu/drm/i915/display/intel_pipe_crc.c |    1 +
>  drivers/gpu/drm/i915/display/intel_pmdemand.c |    1 +
>  drivers/gpu/drm/i915/display/intel_pps.c      |    1 +
>  drivers/gpu/drm/i915/display/intel_psr.c      |    1 +
>  drivers/gpu/drm/i915/display/intel_sdvo.c     |    1 +
>  drivers/gpu/drm/i915/display/intel_snps_phy.c |    1 +
>  drivers/gpu/drm/i915/display/intel_tc.c       |    1 +
>  drivers/gpu/drm/i915/display/intel_vblank.c   |    1 +
>  drivers/gpu/drm/i915/display/intel_vga.c      |    2 +
>  drivers/gpu/drm/i915/display/intel_vrr.c      |    1 +
>  drivers/gpu/drm/i915/display/skl_scaler.c     |    1 +
>  .../drm/i915/display/skl_universal_plane.c    |    4 +-
>  drivers/gpu/drm/i915/display/skl_watermark.c  |    1 +
>  drivers/gpu/drm/i915/display/vlv_dsi.c        |    1 +
>  drivers/gpu/drm/i915/gvt/display.c            |    1 +
>  drivers/gpu/drm/i915/gvt/fb_decoder.c         |    1 +
>  drivers/gpu/drm/i915/gvt/handlers.c           |    1 +
>  drivers/gpu/drm/i915/gvt/interrupt.c          |    1 +
>  drivers/gpu/drm/i915/gvt/mmio.c               |    1 +
>  drivers/gpu/drm/i915/i915_reg.h               | 2757 ----------------
>  drivers/gpu/drm/i915/intel_gvt_mmio_table.c   |    1 +
>  drivers/gpu/drm/xe/display/xe_plane_initial.c |    2 +-
>  73 files changed, 2858 insertions(+), 2774 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/display/intel_display_regs.h
> 
> diff --git a/drivers/gpu/drm/i915/display/g4x_dp.c
> b/drivers/gpu/drm/i915/display/g4x_dp.c
> index a82102d3a167..4e37312f6139 100644
> --- a/drivers/gpu/drm/i915/display/g4x_dp.c
> +++ b/drivers/gpu/drm/i915/display/g4x_dp.c
> @@ -16,6 +16,7 @@
>  #include "intel_crtc.h"
>  #include "intel_de.h"
>  #include "intel_display_power.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dp.h"
>  #include "intel_dp_aux.h"
> diff --git a/drivers/gpu/drm/i915/display/g4x_hdmi.c
> b/drivers/gpu/drm/i915/display/g4x_hdmi.c
> index 98e6a931042f..2448d510dbc2 100644
> --- a/drivers/gpu/drm/i915/display/g4x_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/g4x_hdmi.c
> @@ -14,6 +14,7 @@
>  #include "intel_crtc.h"
>  #include "intel_de.h"
>  #include "intel_display_power.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dp_aux.h"
>  #include "intel_dpio_phy.h"
> diff --git a/drivers/gpu/drm/i915/display/hsw_ips.c
> b/drivers/gpu/drm/i915/display/hsw_ips.c
> index d02c328bf902..53ff21be6a4b 100644
> --- a/drivers/gpu/drm/i915/display/hsw_ips.c
> +++ b/drivers/gpu/drm/i915/display/hsw_ips.c
> @@ -10,6 +10,7 @@
>  #include "i915_reg.h"
>  #include "intel_color_regs.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_pcode.h"
> 
> diff --git a/drivers/gpu/drm/i915/display/i9xx_display_sr.c
> b/drivers/gpu/drm/i915/display/i9xx_display_sr.c
> index 32abe9743014..357212f09a0f 100644
> --- a/drivers/gpu/drm/i915/display/i9xx_display_sr.c
> +++ b/drivers/gpu/drm/i915/display/i9xx_display_sr.c
> @@ -9,6 +9,7 @@
>  #include "i9xx_display_sr.h"
>  #include "i9xx_wm_regs.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_gmbus.h"
>  #include "intel_pci_config.h"
> 
> diff --git a/drivers/gpu/drm/i915/display/i9xx_plane.c
> b/drivers/gpu/drm/i915/display/i9xx_plane.c
> index bd3f8db13700..a5362ee1ce90 100644
> --- a/drivers/gpu/drm/i915/display/i9xx_plane.c
> +++ b/drivers/gpu/drm/i915/display/i9xx_plane.c
> @@ -2,6 +2,7 @@
>  /*
>   * Copyright © 2020 Intel Corporation
>   */
> +
>  #include <linux/kernel.h>
> 
>  #include <drm/drm_atomic_helper.h>
> @@ -16,6 +17,7 @@
>  #include "intel_atomic_plane.h"
>  #include "intel_de.h"
>  #include "intel_display_irq.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_fb.h"
>  #include "intel_fbc.h"
> diff --git a/drivers/gpu/drm/i915/display/i9xx_wm.c
> b/drivers/gpu/drm/i915/display/i9xx_wm.c
> index 497850a6ac81..53a427829fe3 100644
> --- a/drivers/gpu/drm/i915/display/i9xx_wm.c
> +++ b/drivers/gpu/drm/i915/display/i9xx_wm.c
> @@ -10,6 +10,7 @@
>  #include "intel_atomic.h"
>  #include "intel_bo.h"
>  #include "intel_display.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_trace.h"
>  #include "intel_fb.h"
>  #include "intel_mchbar_regs.h"
> diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c
> b/drivers/gpu/drm/i915/display/icl_dsi.c
> index ee1c3fb500a7..26c595cafdd3 100644
> --- a/drivers/gpu/drm/i915/display/icl_dsi.c
> +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
> @@ -44,6 +44,7 @@
>  #include "intel_crtc.h"
>  #include "intel_ddi.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_dsi.h"
>  #include "intel_dsi_vbt.h"
>  #include "intel_panel.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_backlight.c
> b/drivers/gpu/drm/i915/display/intel_backlight.c
> index 477b21af71a4..d4e6d4926141 100644
> --- a/drivers/gpu/drm/i915/display/intel_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_backlight.c
> @@ -7,7 +7,6 @@
>  #include <linux/kernel.h>
>  #include <linux/pwm.h>
>  #include <linux/string_helpers.h>
> -
>  #include <acpi/video.h>
> 
>  #include "i915_drv.h"
> @@ -16,6 +15,7 @@
>  #include "intel_backlight_regs.h"
>  #include "intel_connector.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dp_aux_backlight.h"
>  #include "intel_dsi_dcs_backlight.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_bw.c
> b/drivers/gpu/drm/i915/display/intel_bw.c
> index 23edc81741de..e4646d467300 100644
> --- a/drivers/gpu/drm/i915/display/intel_bw.c
> +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> @@ -12,10 +12,11 @@
>  #include "intel_bw.h"
>  #include "intel_cdclk.h"
>  #include "intel_display_core.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
> -#include "skl_watermark.h"
>  #include "intel_mchbar_regs.h"
>  #include "intel_pcode.h"
> +#include "skl_watermark.h"
> 
>  /* Parameters for Qclk Geyserville (QGV) */
>  struct intel_qgv_point {
> diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c
> b/drivers/gpu/drm/i915/display/intel_cdclk.c
> index 753ba3e3a0b7..ac9f1c47580d 100644
> --- a/drivers/gpu/drm/i915/display/intel_cdclk.c
> +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
> @@ -38,6 +38,7 @@
>  #include "intel_cdclk.h"
>  #include "intel_crtc.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_mchbar_regs.h"
>  #include "intel_pci_config.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_cmtg.c
> b/drivers/gpu/drm/i915/display/intel_cmtg.c
> index 6b6fb82009f5..342b4407b391 100644
> --- a/drivers/gpu/drm/i915/display/intel_cmtg.c
> +++ b/drivers/gpu/drm/i915/display/intel_cmtg.c
> @@ -11,12 +11,13 @@
> 
>  #include "i915_drv.h"
>  #include "i915_reg.h"
> -#include "intel_crtc.h"
>  #include "intel_cmtg.h"
>  #include "intel_cmtg_regs.h"
> +#include "intel_crtc.h"
>  #include "intel_de.h"
>  #include "intel_display_device.h"
>  #include "intel_display_power.h"
> +#include "intel_display_regs.h"
> 
>  /**
>   * DOC: Common Primary Timing Generator (CMTG)
> diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c
> b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> index 4fbe2e3542ca..6bd47caae08a 100644
> --- a/drivers/gpu/drm/i915/display/intel_combo_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> @@ -8,6 +8,7 @@
>  #include "intel_combo_phy.h"
>  #include "intel_combo_phy_regs.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
> 
>  #define for_each_combo_phy(__dev_priv, __phy) \
> diff --git a/drivers/gpu/drm/i915/display/intel_crt.c
> b/drivers/gpu/drm/i915/display/intel_crt.c
> index b5367e059ee3..8f58681c7a5b 100644
> --- a/drivers/gpu/drm/i915/display/intel_crt.c
> +++ b/drivers/gpu/drm/i915/display/intel_crt.c
> @@ -44,6 +44,7 @@
>  #include "intel_ddi_buf_trans.h"
>  #include "intel_de.h"
>  #include "intel_display_driver.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_fdi.h"
>  #include "intel_fdi_regs.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
> b/drivers/gpu/drm/i915/display/intel_ddi.c
> index db3c2d85c57b..6dfe3fc45ece 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -48,6 +48,7 @@
>  #include "intel_ddi_buf_trans.h"
>  #include "intel_de.h"
>  #include "intel_display_power.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dkl_phy.h"
>  #include "intel_dkl_phy_regs.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index a50b0a008231..5ad084c3d31c 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -66,13 +66,14 @@
>  #include "intel_crt.h"
>  #include "intel_crtc.h"
>  #include "intel_crtc_state_dump.h"
> +#include "intel_cursor.h"
>  #include "intel_cursor_regs.h"
>  #include "intel_cx0_phy.h"
> -#include "intel_cursor.h"
>  #include "intel_ddi.h"
>  #include "intel_de.h"
>  #include "intel_display_driver.h"
>  #include "intel_display_power.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dmc.h"
>  #include "intel_dp.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index 926f09c35084..c9fb2eca84f8 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -24,6 +24,7 @@
>  #include "intel_display_debugfs_params.h"
>  #include "intel_display_power.h"
>  #include "intel_display_power_well.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dmc.h"
>  #include "intel_dp.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c
> b/drivers/gpu/drm/i915/display/intel_display_device.c
> index 738ae522c8f4..cf4ab425984b 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.c
> @@ -3,10 +3,11 @@
>   * Copyright © 2023 Intel Corporation
>   */
> 
> -#include <drm/intel/pciids.h>
> -#include <drm/drm_color_mgmt.h>
>  #include <linux/pci.h>
> 
> +#include <drm/drm_color_mgmt.h>
> +#include <drm/intel/pciids.h>
> +
>  #include "i915_drv.h"
>  #include "i915_reg.h"
>  #include "intel_cx0_phy_regs.h"
> @@ -16,6 +17,7 @@
>  #include "intel_display_params.h"
>  #include "intel_display_power.h"
>  #include "intel_display_reg_defs.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_fbc.h"
>  #include "intel_step.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c
> b/drivers/gpu/drm/i915/display/intel_display_irq.c
> index d9734fcd0d45..e08589fc79e4 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_irq.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_irq.c
> @@ -6,6 +6,7 @@
>  #include <drm/drm_vblank.h>
> 
>  #include "gt/intel_rps.h"
> +
>  #include "i915_drv.h"
>  #include "i915_irq.h"
>  #include "i915_reg.h"
> @@ -13,6 +14,7 @@
>  #include "intel_crtc.h"
>  #include "intel_de.h"
>  #include "intel_display_irq.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_trace.h"
>  #include "intel_display_types.h"
>  #include "intel_dmc_wl.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c
> b/drivers/gpu/drm/i915/display/intel_display_power.c
> index 14ae60749f02..4fa19507a7fa 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> @@ -16,6 +16,7 @@
>  #include "intel_display_power.h"
>  #include "intel_display_power_map.h"
>  #include "intel_display_power_well.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dmc.h"
>  #include "intel_mchbar_regs.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power_map.c
> b/drivers/gpu/drm/i915/display/intel_display_power_map.c
> index 0c8ac1af6db7..dfbcd2521e04 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power_map.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power_map.c
> @@ -7,6 +7,7 @@
>  #include "intel_display_core.h"
>  #include "intel_display_power_map.h"
>  #include "intel_display_power_well.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "vlv_sideband_reg.h"
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power_well.c
> b/drivers/gpu/drm/i915/display/intel_display_power_well.c
> index f45a4f9ba23c..930e7f9ad502 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power_well.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power_well.c
> @@ -13,6 +13,7 @@
>  #include "intel_de.h"
>  #include "intel_display_irq.h"
>  #include "intel_display_power_well.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dkl_phy.h"
>  #include "intel_dkl_phy_regs.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_display_regs.h
> b/drivers/gpu/drm/i915/display/intel_display_regs.h
> new file mode 100644
> index 000000000000..1c070bd5c694
> --- /dev/null
> +++ b/drivers/gpu/drm/i915/display/intel_display_regs.h
> @@ -0,0 +1,2768 @@
> +/* SPDX-License-Identifier: MIT */
> +/* Copyright © 2024 Intel Corporation */
> +
> +#ifndef __INTEL_DISPLAY_REGS_H__
> +#define __INTEL_DISPLAY_REGS_H__
> +
> +#include "intel_display_reg_defs.h"
> +
> +#define GU_CNTL_PROTECTED		_MMIO(0x10100C)
> +#define   DEPRESENT			REG_BIT(9)
> +
> +#define DPIO_CTL			_MMIO(VLV_DISPLAY_BASE + 0x2110)
> +#define  DPIO_MODSEL1			(1 << 3) /* if ref clk b == 27 */
> +#define  DPIO_MODSEL0			(1 << 2) /* if ref clk a == 27 */
> +#define  DPIO_SFR_BYPASS		(1 << 1)
> +#define  DPIO_CMNRST			(1 << 0)
> +
> +#define BXT_P_CR_GT_DISP_PWRON		_MMIO(0x138090)
> +#define  MIPIO_RST_CTRL				(1 << 2)
> +
> +#define _BXT_PHY_CTL_DDI_A		0x64C00
> +#define _BXT_PHY_CTL_DDI_B		0x64C10
> +#define _BXT_PHY_CTL_DDI_C		0x64C20
> +#define   BXT_PHY_CMNLANE_POWERDOWN_ACK	(1 << 10)
> +#define   BXT_PHY_LANE_POWERDOWN_ACK	(1 << 9)
> +#define   BXT_PHY_LANE_ENABLED		(1 << 8)
> +#define BXT_PHY_CTL(port)		_MMIO_PORT(port,
> _BXT_PHY_CTL_DDI_A, \
> +
> _BXT_PHY_CTL_DDI_B)
> +
> +#define _PHY_CTL_FAMILY_DDI		0x64C90
> +#define _PHY_CTL_FAMILY_EDP		0x64C80
> +#define _PHY_CTL_FAMILY_DDI_C		0x64CA0
> +#define   COMMON_RESET_DIS		(1 << 31)
> +#define BXT_PHY_CTL_FAMILY(phy)
> 		\
> +	 _MMIO(_PICK_EVEN_2RANGES(phy, 1,
> 	\
> +				  _PHY_CTL_FAMILY_DDI,
> _PHY_CTL_FAMILY_DDI,	\
> +				  _PHY_CTL_FAMILY_EDP,
> _PHY_CTL_FAMILY_DDI_C))
> +
> +/* UAIMI scratch pad register 1 */
> +#define UAIMI_SPR1			_MMIO(0x4F074)
> +/* SKL VccIO mask */
> +#define SKL_VCCIO_MASK			0x1
> +/* SKL balance leg register */
> +#define DISPIO_CR_TX_BMU_CR0		_MMIO(0x6C00C)
> +/* I_boost values */
> +#define BALANCE_LEG_SHIFT(port)		(8 + 3 * (port))
> +#define BALANCE_LEG_MASK(port)		(7 << (8 + 3 * (port)))
> +/* Balance leg disable bits */
> +#define BALANCE_LEG_DISABLE_SHIFT	23
> +#define BALANCE_LEG_DISABLE(port)	(1 << (23 + (port)))
> +
> +#define VLV_IRQ_REGS		I915_IRQ_REGS(VLV_IMR, \
> +					      VLV_IER, \
> +					      VLV_IIR)
> +
> +#define _MBUS_ABOX0_CTL			0x45038
> +#define _MBUS_ABOX1_CTL			0x45048
> +#define _MBUS_ABOX2_CTL			0x4504C
> +#define MBUS_ABOX_CTL(x)
> 	\
> +	_MMIO(_PICK_EVEN_2RANGES(x, 2,
> 		\
> +				 _MBUS_ABOX0_CTL, _MBUS_ABOX1_CTL,
> 		\
> +				 _MBUS_ABOX2_CTL, _MBUS_ABOX2_CTL))
> +
> +#define MBUS_ABOX_BW_CREDIT_MASK	(3 << 20)
> +#define MBUS_ABOX_BW_CREDIT(x)		((x) << 20)
> +#define MBUS_ABOX_B_CREDIT_MASK		(0xF << 16)
> +#define MBUS_ABOX_B_CREDIT(x)		((x) << 16)
> +#define MBUS_ABOX_BT_CREDIT_POOL2_MASK	(0x1F << 8)
> +#define MBUS_ABOX_BT_CREDIT_POOL2(x)	((x) << 8)
> +#define MBUS_ABOX_BT_CREDIT_POOL1_MASK	(0x1F << 0)
> +#define MBUS_ABOX_BT_CREDIT_POOL1(x)	((x) << 0)
> +
> +#define IPS_CTL		_MMIO(0x43408)
> +#define   IPS_ENABLE		REG_BIT(31)
> +#define   IPS_FALSE_COLOR	REG_BIT(4)
> +
> +/*
> + * Clock control & power management
> + */
> +#define _DPLL_A			0x6014
> +#define _DPLL_B			0x6018
> +#define _CHV_DPLL_C		0x6030
> +#define DPLL(dev_priv, pipe)
> 	_MMIO_BASE_PIPE3(DISPLAY_MMIO_BASE(dev_priv), \
> +						 (pipe), _DPLL_A, _DPLL_B,
> _CHV_DPLL_C)
> +
> +#define VGA0	_MMIO(0x6000)
> +#define VGA1	_MMIO(0x6004)
> +#define VGA_PD	_MMIO(0x6010)
> +#define   VGA0_PD_P2_DIV_4	(1 << 7)
> +#define   VGA0_PD_P1_DIV_2	(1 << 5)
> +#define   VGA0_PD_P1_SHIFT	0
> +#define   VGA0_PD_P1_MASK	(0x1f << 0)
> +#define   VGA1_PD_P2_DIV_4	(1 << 15)
> +#define   VGA1_PD_P1_DIV_2	(1 << 13)
> +#define   VGA1_PD_P1_SHIFT	8
> +#define   VGA1_PD_P1_MASK	(0x1f << 8)
> +#define   DPLL_VCO_ENABLE		(1 << 31)
> +#define   DPLL_SDVO_HIGH_SPEED		(1 << 30)
> +#define   DPLL_DVO_2X_MODE		(1 << 30)
> +#define   DPLL_EXT_BUFFER_ENABLE_VLV	(1 << 30)
> +#define   DPLL_SYNCLOCK_ENABLE		(1 << 29)
> +#define   DPLL_REF_CLK_ENABLE_VLV	(1 << 29)
> +#define   DPLL_VGA_MODE_DIS		(1 << 28)
> +#define   DPLLB_MODE_DAC_SERIAL		(1 << 26) /* i915 */
> +#define   DPLLB_MODE_LVDS		(2 << 26) /* i915 */
> +#define   DPLL_MODE_MASK		(3 << 26)
> +#define   DPLL_DAC_SERIAL_P2_CLOCK_DIV_10 (0 << 24) /* i915 */
> +#define   DPLL_DAC_SERIAL_P2_CLOCK_DIV_5 (1 << 24) /* i915 */
> +#define   DPLLB_LVDS_P2_CLOCK_DIV_14	(0 << 24) /* i915 */
> +#define   DPLLB_LVDS_P2_CLOCK_DIV_7	(1 << 24) /* i915 */
> +#define   DPLL_P2_CLOCK_DIV_MASK	0x03000000 /* i915 */
> +#define   DPLL_FPA01_P1_POST_DIV_MASK	0x00ff0000 /* i915 */
> +#define   DPLL_FPA01_P1_POST_DIV_MASK_PINEVIEW	0x00ff8000 /*
> Pineview */
> +#define   DPLL_LOCK_VLV			(1 << 15)
> +#define   DPLL_INTEGRATED_CRI_CLK_VLV	(1 << 14)
> +#define   DPLL_INTEGRATED_REF_CLK_VLV	(1 << 13)
> +#define   DPLL_SSC_REF_CLK_CHV		(1 << 13)
> +#define   DPLL_PORTC_READY_MASK		(0xf << 4)
> +#define   DPLL_PORTB_READY_MASK		(0xf)
> +
> +#define   DPLL_FPA01_P1_POST_DIV_MASK_I830	0x001f0000
> +
> +/* Additional CHV pll/phy registers */
> +#define DPIO_PHY_STATUS			_MMIO(VLV_DISPLAY_BASE +
> 0x6240)
> +#define   DPLL_PORTD_READY_MASK		(0xf)
> +#define DISPLAY_PHY_CONTROL _MMIO(VLV_DISPLAY_BASE + 0x60100)
> +#define   PHY_CH_POWER_DOWN_OVRD_EN(phy, ch)	(1 << (2 * (phy) + (ch)
> + 27))
> +#define   PHY_LDO_DELAY_0NS			0x0
> +#define   PHY_LDO_DELAY_200NS			0x1
> +#define   PHY_LDO_DELAY_600NS			0x2
> +#define   PHY_LDO_SEQ_DELAY(delay, phy)		((delay) << (2 * (phy)
> + 23))
> +#define   PHY_CH_POWER_DOWN_OVRD(mask, phy, ch)	((mask) << (8
> * (phy) + 4 * (ch) + 11))
> +#define   PHY_CH_SU_PSR				0x1
> +#define   PHY_CH_DEEP_PSR			0x7
> +#define   PHY_CH_POWER_MODE(mode, phy, ch)	((mode) << (6 * (phy)
> + 3 * (ch) + 2))
> +#define   PHY_COM_LANE_RESET_DEASSERT(phy)	(1 << (phy))
> +#define DISPLAY_PHY_STATUS _MMIO(VLV_DISPLAY_BASE + 0x60104)
> +#define   PHY_POWERGOOD(phy)	(((phy) == DPIO_PHY0) ? (1 << 31) : (1
> << 30))
> +#define   PHY_STATUS_CMN_LDO(phy, ch)                   (1 << (6 - (6 * (phy) + 3
> * (ch))))
> +#define   PHY_STATUS_SPLINE_LDO(phy, ch, spline)        (1 << (8 - (6 * (phy)
> + 3 * (ch) + (spline))))
> +
> +/*
> + * The i830 generation, in LVDS mode, defines P1 as the bit number set
> within
> + * this field (only one bit may be set).
> + */
> +#define   DPLL_FPA01_P1_POST_DIV_MASK_I830_LVDS	0x003f0000
> +#define   DPLL_FPA01_P1_POST_DIV_SHIFT	16
> +#define   DPLL_FPA01_P1_POST_DIV_SHIFT_PINEVIEW 15
> +/* i830, required in DVO non-gang */
> +#define   PLL_P2_DIVIDE_BY_4		(1 << 23)
> +#define   PLL_P1_DIVIDE_BY_TWO		(1 << 21) /* i830 */
> +#define   PLL_REF_INPUT_DREFCLK		(0 << 13)
> +#define   PLL_REF_INPUT_TVCLKINA	(1 << 13) /* i830 */
> +#define   PLL_REF_INPUT_TVCLKINBC	(2 << 13) /* SDVO TVCLKIN */
> +#define   PLLB_REF_INPUT_SPREADSPECTRUMIN (3 << 13)
> +#define   PLL_REF_INPUT_MASK		(3 << 13)
> +#define   PLL_LOAD_PULSE_PHASE_SHIFT		9
> +/* Ironlake */
> +# define PLL_REF_SDVO_HDMI_MULTIPLIER_SHIFT     9
> +# define PLL_REF_SDVO_HDMI_MULTIPLIER_MASK      (7 << 9)
> +# define PLL_REF_SDVO_HDMI_MULTIPLIER(x)	(((x) - 1) << 9)
> +# define DPLL_FPA1_P1_POST_DIV_SHIFT            0
> +# define DPLL_FPA1_P1_POST_DIV_MASK             0xff
> +
> +/*
> + * Parallel to Serial Load Pulse phase selection.
> + * Selects the phase for the 10X DPLL clock for the PCIe
> + * digital display port. The range is 4 to 13; 10 or more
> + * is just a flip delay. The default is 6
> + */
> +#define   PLL_LOAD_PULSE_PHASE_MASK		(0xf <<
> PLL_LOAD_PULSE_PHASE_SHIFT)
> +#define   DISPLAY_RATE_SELECT_FPA1		(1 << 8)
> +/*
> + * SDVO multiplier for 945G/GM. Not used on 965.
> + */
> +#define   SDVO_MULTIPLIER_MASK			0x000000ff
> +#define   SDVO_MULTIPLIER_SHIFT_HIRES		4
> +#define   SDVO_MULTIPLIER_SHIFT_VGA		0
> +
> +#define _DPLL_A_MD		0x601c
> +#define _DPLL_B_MD		0x6020
> +#define _CHV_DPLL_C_MD		0x603c
> +#define DPLL_MD(dev_priv, pipe)
> 	_MMIO_BASE_PIPE3(DISPLAY_MMIO_BASE(dev_priv), \
> +						 (pipe), _DPLL_A_MD,
> _DPLL_B_MD, _CHV_DPLL_C_MD)
> +
> +/*
> + * UDI pixel divider, controlling how many pixels are stuffed into a packet.
> + *
> + * Value is pixels minus 1.  Must be set to 1 pixel for SDVO.
> + */
> +#define   DPLL_MD_UDI_DIVIDER_MASK		0x3f000000
> +#define   DPLL_MD_UDI_DIVIDER_SHIFT		24
> +/* UDI pixel divider for VGA, same as DPLL_MD_UDI_DIVIDER_MASK. */
> +#define   DPLL_MD_VGA_UDI_DIVIDER_MASK		0x003f0000
> +#define   DPLL_MD_VGA_UDI_DIVIDER_SHIFT		16
> +/*
> + * SDVO/UDI pixel multiplier.
> + *
> + * SDVO requires that the bus clock rate be between 1 and 2 Ghz, and the
> bus
> + * clock rate is 10 times the DPLL clock.  At low resolution/refresh rate
> + * modes, the bus rate would be below the limits, so SDVO allows for
> stuffing
> + * dummy bytes in the datastream at an increased clock rate, with both
> sides of
> + * the link knowing how many bytes are fill.
> + *
> + * So, for a mode with a dotclock of 65Mhz, we would want to double the
> clock
> + * rate to 130Mhz to get a bus rate of 1.30Ghz.  The DPLL clock rate would
> be
> + * set to 130Mhz, and the SDVO multiplier set to 2x in this register and
> + * through an SDVO command.
> + *
> + * This register field has values of multiplication factor minus 1, with
> + * a maximum multiplier of 5 for SDVO.
> + */
> +#define   DPLL_MD_UDI_MULTIPLIER_MASK		0x00003f00
> +#define   DPLL_MD_UDI_MULTIPLIER_SHIFT		8
> +/*
> + * SDVO/UDI pixel multiplier for VGA, same as
> DPLL_MD_UDI_MULTIPLIER_MASK.
> + * This best be set to the default value (3) or the CRT won't work. No,
> + * I don't entirely understand what this does...
> + */
> +#define   DPLL_MD_VGA_UDI_MULTIPLIER_MASK	0x0000003f
> +#define   DPLL_MD_VGA_UDI_MULTIPLIER_SHIFT	0
> +
> +#define RAWCLK_FREQ_VLV		_MMIO(VLV_DISPLAY_BASE + 0x6024)
> +
> +#define FW_BLC_SELF_VLV		_MMIO(VLV_DISPLAY_BASE + 0x6500)
> +#define  FW_CSPWRDWNEN		(1 << 15)
> +
> +#define MI_ARB_VLV		_MMIO(VLV_DISPLAY_BASE + 0x6504)
> +
> +#define GCI_CONTROL		_MMIO(VLV_DISPLAY_BASE + 0x650C)
> +#define   PFI_CREDIT_63		(9 << 28)		/* chv only */
> +#define   PFI_CREDIT_31		(8 << 28)		/* chv only */
> +#define   PFI_CREDIT(x)		(((x) - 8) << 28)	/* 8-15 */
> +#define   PFI_CREDIT_RESEND	(1 << 27)
> +#define   VGA_FAST_MODE_DISABLE	(1 << 14)
> +
> +#define GMBUSFREQ_VLV		_MMIO(VLV_DISPLAY_BASE + 0x6510)
> +
> +#define PEG_BAND_GAP_DATA	_MMIO(0x14d68)
> +
> +/*
> + * Overlay regs
> + */
> +#define OVADD			_MMIO(0x30000)
> +#define DOVSTA			_MMIO(0x30008)
> +#define OC_BUF			(0x3 << 20)
> +#define OGAMC5			_MMIO(0x30010)
> +#define OGAMC4			_MMIO(0x30014)
> +#define OGAMC3			_MMIO(0x30018)
> +#define OGAMC2			_MMIO(0x3001c)
> +#define OGAMC1			_MMIO(0x30020)
> +#define OGAMC0			_MMIO(0x30024)
> +
> +#define GEN9_CLKGATE_DIS_4		_MMIO(0x4653C)
> +#define   BXT_GMBUS_GATING_DIS		(1 << 14)
> +
> +#define GEN9_CLKGATE_DIS_5		_MMIO(0x46540)
> +#define   DPCE_GATING_DIS		REG_BIT(17)
> +
> +#define _CLKGATE_DIS_PSL_A		0x46520
> +#define _CLKGATE_DIS_PSL_B		0x46524
> +#define _CLKGATE_DIS_PSL_C		0x46528
> +#define   DUPS1_GATING_DIS		(1 << 15)
> +#define   DUPS2_GATING_DIS		(1 << 19)
> +#define   DUPS3_GATING_DIS		(1 << 23)
> +#define   CURSOR_GATING_DIS		REG_BIT(28)
> +#define   DPF_GATING_DIS		(1 << 10)
> +#define   DPF_RAM_GATING_DIS		(1 << 9)
> +#define   DPFR_GATING_DIS		(1 << 8)
> +
> +#define CLKGATE_DIS_PSL(pipe) \
> +	_MMIO_PIPE(pipe, _CLKGATE_DIS_PSL_A, _CLKGATE_DIS_PSL_B)
> +
> +#define _CLKGATE_DIS_PSL_EXT_A		0x4654C
> +#define _CLKGATE_DIS_PSL_EXT_B		0x46550
> +#define   PIPEDMC_GATING_DIS		REG_BIT(12)
> +
> +#define CLKGATE_DIS_PSL_EXT(pipe) \
> +	_MMIO_PIPE(pipe, _CLKGATE_DIS_PSL_EXT_A,
> _CLKGATE_DIS_PSL_EXT_B)
> +
> +/*
> + * Display engine regs
> + */
> +/* Pipe/transcoder A timing regs */
> +#define _TRANS_HTOTAL_A		0x60000
> +#define _TRANS_HTOTAL_B		0x61000
> +#define TRANS_HTOTAL(dev_priv, trans)	_MMIO_TRANS2(dev_priv,
> (trans), _TRANS_HTOTAL_A)
> +#define   HTOTAL_MASK			REG_GENMASK(31, 16)
> +#define   HTOTAL(htotal)		REG_FIELD_PREP(HTOTAL_MASK,
> (htotal))
> +#define   HACTIVE_MASK			REG_GENMASK(15, 0)
> +#define   HACTIVE(hdisplay)		REG_FIELD_PREP(HACTIVE_MASK,
> (hdisplay))
> +
> +#define _TRANS_HBLANK_A		0x60004
> +#define _TRANS_HBLANK_B		0x61004
> +#define TRANS_HBLANK(dev_priv, trans)	_MMIO_TRANS2(dev_priv,
> (trans), _TRANS_HBLANK_A)
> +#define   HBLANK_END_MASK		REG_GENMASK(31, 16)
> +#define   HBLANK_END(hblank_end)
> 	REG_FIELD_PREP(HBLANK_END_MASK, (hblank_end))
> +#define   HBLANK_START_MASK		REG_GENMASK(15, 0)
> +#define   HBLANK_START(hblank_start)
> 	REG_FIELD_PREP(HBLANK_START_MASK, (hblank_start))
> +
> +#define _TRANS_HSYNC_A		0x60008
> +#define _TRANS_HSYNC_B		0x61008
> +#define TRANS_HSYNC(dev_priv, trans)	_MMIO_TRANS2(dev_priv,
> (trans), _TRANS_HSYNC_A)
> +#define   HSYNC_END_MASK		REG_GENMASK(31, 16)
> +#define   HSYNC_END(hsync_end)
> 	REG_FIELD_PREP(HSYNC_END_MASK, (hsync_end))
> +#define   HSYNC_START_MASK		REG_GENMASK(15, 0)
> +#define   HSYNC_START(hsync_start)
> 	REG_FIELD_PREP(HSYNC_START_MASK, (hsync_start))
> +
> +#define _TRANS_VTOTAL_A		0x6000c
> +#define _TRANS_VTOTAL_B		0x6100c
> +#define TRANS_VTOTAL(dev_priv, trans)	_MMIO_TRANS2(dev_priv,
> (trans), _TRANS_VTOTAL_A)
> +#define   VTOTAL_MASK			REG_GENMASK(31, 16)
> +#define   VTOTAL(vtotal)		REG_FIELD_PREP(VTOTAL_MASK,
> (vtotal))
> +#define   VACTIVE_MASK			REG_GENMASK(15, 0)
> +#define   VACTIVE(vdisplay)		REG_FIELD_PREP(VACTIVE_MASK,
> (vdisplay))
> +
> +#define _TRANS_VBLANK_A		0x60010
> +#define _TRANS_VBLANK_B		0x61010
> +#define TRANS_VBLANK(dev_priv, trans)	_MMIO_TRANS2(dev_priv,
> (trans), _TRANS_VBLANK_A)
> +#define   VBLANK_END_MASK		REG_GENMASK(31, 16)
> +#define   VBLANK_END(vblank_end)
> 	REG_FIELD_PREP(VBLANK_END_MASK, (vblank_end))
> +#define   VBLANK_START_MASK		REG_GENMASK(15, 0)
> +#define   VBLANK_START(vblank_start)
> 	REG_FIELD_PREP(VBLANK_START_MASK, (vblank_start))
> +
> +#define _TRANS_VSYNC_A		0x60014
> +#define _TRANS_VSYNC_B		0x61014
> +#define TRANS_VSYNC(dev_priv, trans)	_MMIO_TRANS2(dev_priv,
> (trans), _TRANS_VSYNC_A)
> +#define   VSYNC_END_MASK		REG_GENMASK(31, 16)
> +#define   VSYNC_END(vsync_end)
> 	REG_FIELD_PREP(VSYNC_END_MASK, (vsync_end))
> +#define   VSYNC_START_MASK		REG_GENMASK(15, 0)
> +#define   VSYNC_START(vsync_start)
> 	REG_FIELD_PREP(VSYNC_START_MASK, (vsync_start))
> +
> +#define _PIPEASRC		0x6001c
> +#define _PIPEBSRC		0x6101c
> +#define PIPESRC(dev_priv, pipe)		_MMIO_TRANS2(dev_priv,
> (pipe), _PIPEASRC)
> +#define   PIPESRC_WIDTH_MASK	REG_GENMASK(31, 16)
> +#define   PIPESRC_WIDTH(w)	REG_FIELD_PREP(PIPESRC_WIDTH_MASK,
> (w))
> +#define   PIPESRC_HEIGHT_MASK	REG_GENMASK(15, 0)
> +#define   PIPESRC_HEIGHT(h)	REG_FIELD_PREP(PIPESRC_HEIGHT_MASK,
> (h))
> +
> +#define _BCLRPAT_A		0x60020
> +#define _BCLRPAT_B		0x61020
> +#define BCLRPAT(dev_priv, trans)		_MMIO_TRANS2(dev_priv,
> (trans), _BCLRPAT_A)
> +
> +#define _TRANS_VSYNCSHIFT_A	0x60028
> +#define _TRANS_VSYNCSHIFT_B	0x61028
> +#define TRANS_VSYNCSHIFT(dev_priv, trans)	_MMIO_TRANS2(dev_priv,
> (trans), _TRANS_VSYNCSHIFT_A)
> +
> +#define _TRANS_MULT_A		0x6002c
> +#define _TRANS_MULT_B		0x6102c
> +#define TRANS_MULT(dev_priv, trans)	_MMIO_TRANS2(dev_priv,
> (trans), _TRANS_MULT_A)
> +
> +/* Hotplug control (945+ only) */
> +#define PORT_HOTPLUG_EN(dev_priv)
> 	_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61110)
> +#define   PORTB_HOTPLUG_INT_EN			(1 << 29)
> +#define   PORTC_HOTPLUG_INT_EN			(1 << 28)
> +#define   PORTD_HOTPLUG_INT_EN			(1 << 27)
> +#define   SDVOB_HOTPLUG_INT_EN			(1 << 26)
> +#define   SDVOC_HOTPLUG_INT_EN			(1 << 25)
> +#define   TV_HOTPLUG_INT_EN			(1 << 18)
> +#define   CRT_HOTPLUG_INT_EN			(1 << 9)
> +#define HOTPLUG_INT_EN_MASK
> 	(PORTB_HOTPLUG_INT_EN | \
> +						 PORTC_HOTPLUG_INT_EN | \
> +						 PORTD_HOTPLUG_INT_EN |
> \
> +						 SDVOC_HOTPLUG_INT_EN |
> \
> +						 SDVOB_HOTPLUG_INT_EN |
> \
> +						 CRT_HOTPLUG_INT_EN)
> +#define   CRT_HOTPLUG_FORCE_DETECT		(1 << 3)
> +#define CRT_HOTPLUG_ACTIVATION_PERIOD_32	(0 << 8)
> +/* must use period 64 on GM45 according to docs */
> +#define CRT_HOTPLUG_ACTIVATION_PERIOD_64	(1 << 8)
> +#define CRT_HOTPLUG_DAC_ON_TIME_2M		(0 << 7)
> +#define CRT_HOTPLUG_DAC_ON_TIME_4M		(1 << 7)
> +#define CRT_HOTPLUG_VOLTAGE_COMPARE_40		(0 << 5)
> +#define CRT_HOTPLUG_VOLTAGE_COMPARE_50		(1 << 5)
> +#define CRT_HOTPLUG_VOLTAGE_COMPARE_60		(2 << 5)
> +#define CRT_HOTPLUG_VOLTAGE_COMPARE_70		(3 << 5)
> +#define CRT_HOTPLUG_VOLTAGE_COMPARE_MASK	(3 << 5)
> +#define CRT_HOTPLUG_DETECT_DELAY_1G		(0 << 4)
> +#define CRT_HOTPLUG_DETECT_DELAY_2G		(1 << 4)
> +#define CRT_HOTPLUG_DETECT_VOLTAGE_325MV	(0 << 2)
> +#define CRT_HOTPLUG_DETECT_VOLTAGE_475MV	(1 << 2)
> +
> +#define PORT_HOTPLUG_STAT(dev_priv)
> 	_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61114)
> +/* HDMI/DP bits are g4x+ */
> +#define   PORTD_HOTPLUG_LIVE_STATUS_G4X		(1 << 27)
> +#define   PORTC_HOTPLUG_LIVE_STATUS_G4X		(1 << 28)
> +#define   PORTB_HOTPLUG_LIVE_STATUS_G4X		(1 << 29)
> +#define   PORTD_HOTPLUG_INT_STATUS		(3 << 21)
> +#define   PORTD_HOTPLUG_INT_LONG_PULSE		(2 << 21)
> +#define   PORTD_HOTPLUG_INT_SHORT_PULSE		(1 << 21)
> +#define   PORTC_HOTPLUG_INT_STATUS		(3 << 19)
> +#define   PORTC_HOTPLUG_INT_LONG_PULSE		(2 << 19)
> +#define   PORTC_HOTPLUG_INT_SHORT_PULSE		(1 << 19)
> +#define   PORTB_HOTPLUG_INT_STATUS		(3 << 17)
> +#define   PORTB_HOTPLUG_INT_LONG_PULSE		(2 << 17)
> +#define   PORTB_HOTPLUG_INT_SHORT_PLUSE		(1 << 17)
> +/* CRT/TV common between gen3+ */
> +#define   CRT_HOTPLUG_INT_STATUS		(1 << 11)
> +#define   TV_HOTPLUG_INT_STATUS			(1 << 10)
> +#define   CRT_HOTPLUG_MONITOR_MASK		(3 << 8)
> +#define   CRT_HOTPLUG_MONITOR_COLOR		(3 << 8)
> +#define   CRT_HOTPLUG_MONITOR_MONO		(2 << 8)
> +#define   CRT_HOTPLUG_MONITOR_NONE		(0 << 8)
> +#define   DP_AUX_CHANNEL_D_INT_STATUS_G4X	(1 << 6)
> +#define   DP_AUX_CHANNEL_C_INT_STATUS_G4X	(1 << 5)
> +#define   DP_AUX_CHANNEL_B_INT_STATUS_G4X	(1 << 4)
> +#define   DP_AUX_CHANNEL_MASK_INT_STATUS_G4X	(7 << 4)
> +
> +/* SDVO is different across gen3/4 */
> +#define   SDVOC_HOTPLUG_INT_STATUS_G4X		(1 << 3)
> +#define   SDVOB_HOTPLUG_INT_STATUS_G4X		(1 << 2)
> +/*
> + * Bspec seems to be seriously misleaded about the SDVO hpd bits on
> i965g/gm,
> + * since reality corrobates that they're the same as on gen3. But keep these
> + * bits here (and the comment!) to help any other lost wanderers back
> onto the
> + * right tracks.
> + */
> +#define   SDVOC_HOTPLUG_INT_STATUS_I965		(3 << 4)
> +#define   SDVOB_HOTPLUG_INT_STATUS_I965		(3 << 2)
> +#define   SDVOC_HOTPLUG_INT_STATUS_I915		(1 << 7)
> +#define   SDVOB_HOTPLUG_INT_STATUS_I915		(1 << 6)
> +#define   HOTPLUG_INT_STATUS_G4X		(CRT_HOTPLUG_INT_STATUS
> | \
> +
> SDVOB_HOTPLUG_INT_STATUS_G4X | \
> +
> SDVOC_HOTPLUG_INT_STATUS_G4X | \
> +
> PORTB_HOTPLUG_INT_STATUS | \
> +
> PORTC_HOTPLUG_INT_STATUS | \
> +
> PORTD_HOTPLUG_INT_STATUS)
> +
> +#define HOTPLUG_INT_STATUS_I915
> 	(CRT_HOTPLUG_INT_STATUS | \
> +
> SDVOB_HOTPLUG_INT_STATUS_I915 | \
> +
> SDVOC_HOTPLUG_INT_STATUS_I915 | \
> +
> PORTB_HOTPLUG_INT_STATUS | \
> +
> PORTC_HOTPLUG_INT_STATUS | \
> +
> PORTD_HOTPLUG_INT_STATUS)
> +
> +/* SDVO and HDMI port control.
> + * The same register may be used for SDVO or HDMI */
> +#define _GEN3_SDVOB	0x61140
> +#define _GEN3_SDVOC	0x61160
> +#define GEN3_SDVOB	_MMIO(_GEN3_SDVOB)
> +#define GEN3_SDVOC	_MMIO(_GEN3_SDVOC)
> +#define GEN4_HDMIB	GEN3_SDVOB
> +#define GEN4_HDMIC	GEN3_SDVOC
> +#define VLV_HDMIB	_MMIO(VLV_DISPLAY_BASE + 0x61140)
> +#define VLV_HDMIC	_MMIO(VLV_DISPLAY_BASE + 0x61160)
> +#define CHV_HDMID	_MMIO(VLV_DISPLAY_BASE + 0x6116C)
> +#define PCH_SDVOB	_MMIO(0xe1140)
> +#define PCH_HDMIB	PCH_SDVOB
> +#define PCH_HDMIC	_MMIO(0xe1150)
> +#define PCH_HDMID	_MMIO(0xe1160)
> +
> +#define PORT_DFT_I9XX				_MMIO(0x61150)
> +#define   DC_BALANCE_RESET			(1 << 25)
> +#define PORT_DFT2_G4X(dev_priv)
> 	_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61154)
> +#define   DC_BALANCE_RESET_VLV			(1 << 31)
> +#define   PIPE_SCRAMBLE_RESET_MASK		((1 << 14) | (0x3 <<
> 0))
> +#define   PIPE_C_SCRAMBLE_RESET			REG_BIT(14) /* chv */
> +#define   PIPE_B_SCRAMBLE_RESET			REG_BIT(1)
> +#define   PIPE_A_SCRAMBLE_RESET			REG_BIT(0)
> +
> +/* Gen 3 SDVO bits: */
> +#define   SDVO_ENABLE				(1 << 31)
> +#define   SDVO_PIPE_SEL_SHIFT			30
> +#define   SDVO_PIPE_SEL_MASK			(1 << 30)
> +#define   SDVO_PIPE_SEL(pipe)			((pipe) << 30)
> +#define   SDVO_STALL_SELECT			(1 << 29)
> +#define   SDVO_INTERRUPT_ENABLE			(1 << 26)
> +/*
> + * 915G/GM SDVO pixel multiplier.
> + * Programmed value is multiplier - 1, up to 5x.
> + * \sa DPLL_MD_UDI_MULTIPLIER_MASK
> + */
> +#define   SDVO_PORT_MULTIPLY_MASK		(7 << 23)
> +#define   SDVO_PORT_MULTIPLY_SHIFT		23
> +#define   SDVO_PHASE_SELECT_MASK		(15 << 19)
> +#define   SDVO_PHASE_SELECT_DEFAULT		(6 << 19)
> +#define   SDVO_CLOCK_OUTPUT_INVERT		(1 << 18)
> +#define   SDVOC_GANG_MODE			(1 << 16) /* Port C
> only */
> +#define   SDVO_BORDER_ENABLE			(1 << 7) /* SDVO only
> */
> +#define   SDVOB_PCIE_CONCURRENCY		(1 << 3) /* Port B only
> */
> +#define   SDVO_DETECTED				(1 << 2)
> +/* Bits to be preserved when writing */
> +#define   SDVOB_PRESERVE_MASK ((1 << 17) | (1 << 16) | (1 << 14) | \
> +			       SDVO_INTERRUPT_ENABLE)
> +#define   SDVOC_PRESERVE_MASK ((1 << 17) | SDVO_INTERRUPT_ENABLE)
> +
> +/* Gen 4 SDVO/HDMI bits: */
> +#define   SDVO_COLOR_FORMAT_8bpc		(0 << 26)
> +#define   SDVO_COLOR_FORMAT_MASK		(7 << 26)
> +#define   SDVO_ENCODING_SDVO			(0 << 10)
> +#define   SDVO_ENCODING_HDMI			(2 << 10)
> +#define   HDMI_MODE_SELECT_HDMI			(1 << 9) /* HDMI only
> */
> +#define   HDMI_MODE_SELECT_DVI			(0 << 9) /* HDMI only
> */
> +#define   HDMI_COLOR_RANGE_16_235		(1 << 8) /* HDMI only
> */
> +#define   HDMI_AUDIO_ENABLE			(1 << 6) /* HDMI only
> */
> +/* VSYNC/HSYNC bits new with 965, default is to be set */
> +#define   SDVO_VSYNC_ACTIVE_HIGH		(1 << 4)
> +#define   SDVO_HSYNC_ACTIVE_HIGH		(1 << 3)
> +
> +/* Gen 5 (IBX) SDVO/HDMI bits: */
> +#define   HDMI_COLOR_FORMAT_12bpc		(3 << 26) /* HDMI
> only */
> +#define   SDVOB_HOTPLUG_ENABLE			(1 << 23) /* SDVO
> only */
> +
> +/* Gen 6 (CPT) SDVO/HDMI bits: */
> +#define   SDVO_PIPE_SEL_SHIFT_CPT		29
> +#define   SDVO_PIPE_SEL_MASK_CPT		(3 << 29)
> +#define   SDVO_PIPE_SEL_CPT(pipe)		((pipe) << 29)
> +
> +/* CHV SDVO/HDMI bits: */
> +#define   SDVO_PIPE_SEL_SHIFT_CHV		24
> +#define   SDVO_PIPE_SEL_MASK_CHV		(3 << 24)
> +#define   SDVO_PIPE_SEL_CHV(pipe)		((pipe) << 24)
> +
> +/* Video Data Island Packet control */
> +#define VIDEO_DIP_DATA		_MMIO(0x61178)
> +/* Read the description of VIDEO_DIP_DATA (before Haswell) or
> VIDEO_DIP_ECC
> + * (Haswell and newer) to see which VIDEO_DIP_DATA byte corresponds to
> each byte
> + * of the infoframe structure specified by CEA-861. */
> +#define   VIDEO_DIP_DATA_SIZE	32
> +#define   VIDEO_DIP_ASYNC_DATA_SIZE	36
> +#define   VIDEO_DIP_GMP_DATA_SIZE	36
> +#define   VIDEO_DIP_VSC_DATA_SIZE	36
> +#define   VIDEO_DIP_PPS_DATA_SIZE	132
> +#define VIDEO_DIP_CTL		_MMIO(0x61170)
> +/* Pre HSW: */
> +#define   VIDEO_DIP_ENABLE		(1 << 31)
> +#define   VIDEO_DIP_PORT(port)		((port) << 29)
> +#define   VIDEO_DIP_PORT_MASK		(3 << 29)
> +#define   VIDEO_DIP_ENABLE_GCP		(1 << 25) /* ilk+ */
> +#define   VIDEO_DIP_ENABLE_AVI		(1 << 21)
> +#define   VIDEO_DIP_ENABLE_VENDOR	(2 << 21)
> +#define   VIDEO_DIP_ENABLE_GAMUT	(4 << 21) /* ilk+ */
> +#define   VIDEO_DIP_ENABLE_SPD		(8 << 21)
> +#define   VIDEO_DIP_SELECT_AVI		(0 << 19)
> +#define   VIDEO_DIP_SELECT_VENDOR	(1 << 19)
> +#define   VIDEO_DIP_SELECT_GAMUT	(2 << 19)
> +#define   VIDEO_DIP_SELECT_SPD		(3 << 19)
> +#define   VIDEO_DIP_SELECT_MASK		(3 << 19)
> +#define   VIDEO_DIP_FREQ_ONCE		(0 << 16)
> +#define   VIDEO_DIP_FREQ_VSYNC		(1 << 16)
> +#define   VIDEO_DIP_FREQ_2VSYNC		(2 << 16)
> +#define   VIDEO_DIP_FREQ_MASK		(3 << 16)
> +/* HSW and later: */
> +#define   VIDEO_DIP_ENABLE_DRM_GLK	(1 << 28)
> +#define   PSR_VSC_BIT_7_SET		(1 << 27)
> +#define   VSC_SELECT_MASK		(0x3 << 25)
> +#define   VSC_SELECT_SHIFT		25
> +#define   VSC_DIP_HW_HEA_DATA		(0 << 25)
> +#define   VSC_DIP_HW_HEA_SW_DATA	(1 << 25)
> +#define   VSC_DIP_HW_DATA_SW_HEA	(2 << 25)
> +#define   VSC_DIP_SW_HEA_DATA		(3 << 25)
> +#define   VDIP_ENABLE_PPS		(1 << 24)
> +#define   VIDEO_DIP_ENABLE_VSC_HSW	(1 << 20)
> +#define   VIDEO_DIP_ENABLE_GCP_HSW	(1 << 16)
> +#define   VIDEO_DIP_ENABLE_AVI_HSW	(1 << 12)
> +#define   VIDEO_DIP_ENABLE_VS_HSW	(1 << 8)
> +#define   VIDEO_DIP_ENABLE_GMP_HSW	(1 << 4)
> +#define   VIDEO_DIP_ENABLE_SPD_HSW	(1 << 0)
> +/* ADL and later: */
> +#define   VIDEO_DIP_ENABLE_AS_ADL	REG_BIT(23)
> +
> +/* Panel fitting */
> +#define PFIT_CONTROL(dev_priv)
> 	_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61230)
> +#define   PFIT_ENABLE			REG_BIT(31)
> +#define   PFIT_PIPE_MASK		REG_GENMASK(30, 29) /* 965+ */
> +#define   PFIT_PIPE(pipe)		REG_FIELD_PREP(PFIT_PIPE_MASK,
> (pipe))
> +#define   PFIT_SCALING_MASK		REG_GENMASK(28, 26) /*
> 965+ */
> +#define   PFIT_SCALING_AUTO
> 	REG_FIELD_PREP(PFIT_SCALING_MASK, 0)
> +#define   PFIT_SCALING_PROGRAMMED
> 	REG_FIELD_PREP(PFIT_SCALING_MASK, 1)
> +#define   PFIT_SCALING_PILLAR
> 	REG_FIELD_PREP(PFIT_SCALING_MASK, 2)
> +#define   PFIT_SCALING_LETTER
> 	REG_FIELD_PREP(PFIT_SCALING_MASK, 3)
> +#define   PFIT_FILTER_MASK		REG_GENMASK(25, 24) /* 965+ */
> +#define   PFIT_FILTER_FUZZY		REG_FIELD_PREP(PFIT_FILTER_MASK,
> 0)
> +#define   PFIT_FILTER_CRISP		REG_FIELD_PREP(PFIT_FILTER_MASK,
> 1)
> +#define   PFIT_FILTER_MEDIAN
> 	REG_FIELD_PREP(PFIT_FILTER_MASK, 2)
> +#define   PFIT_VERT_INTERP_MASK		REG_GENMASK(11, 10) /*
> pre-965 */
> +#define   PFIT_VERT_INTERP_BILINEAR
> 	REG_FIELD_PREP(PFIT_VERT_INTERP_MASK, 1)
> +#define   PFIT_VERT_AUTO_SCALE		REG_BIT(9) /* pre-965 */
> +#define   PFIT_HORIZ_INTERP_MASK	REG_GENMASK(7, 6) /* pre-965 */
> +#define   PFIT_HORIZ_INTERP_BILINEAR
> 	REG_FIELD_PREP(PFIT_HORIZ_INTERP_MASK, 1)
> +#define   PFIT_HORIZ_AUTO_SCALE		REG_BIT(5) /* pre-965 */
> +#define   PFIT_PANEL_8TO6_DITHER_ENABLE	REG_BIT(3) /* pre-965 */
> +
> +#define PFIT_PGM_RATIOS(dev_priv)
> _MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61234)
> +#define   PFIT_VERT_SCALE_MASK		REG_GENMASK(31, 20) /*
> pre-965 */
> +#define   PFIT_VERT_SCALE(x)
> 	REG_FIELD_PREP(PFIT_VERT_SCALE_MASK, (x))
> +#define   PFIT_HORIZ_SCALE_MASK		REG_GENMASK(15, 4) /* pre-
> 965 */
> +#define   PFIT_HORIZ_SCALE(x)
> 	REG_FIELD_PREP(PFIT_HORIZ_SCALE_MASK, (x))
> +#define   PFIT_VERT_SCALE_MASK_965	REG_GENMASK(28, 16) /*
> 965+ */
> +#define   PFIT_HORIZ_SCALE_MASK_965	REG_GENMASK(12, 0) /*
> 965+ */
> +
> +#define PFIT_AUTO_RATIOS(dev_priv)
> _MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61238)
> +
> +#define PCH_GTC_CTL		_MMIO(0xe7000)
> +#define   PCH_GTC_ENABLE	(1 << 31)
> +
> +/* Display Port */
> +#define DP_A			_MMIO(0x64000) /* eDP */
> +#define DP_B			_MMIO(0x64100)
> +#define DP_C			_MMIO(0x64200)
> +#define DP_D			_MMIO(0x64300)
> +#define VLV_DP_B		_MMIO(VLV_DISPLAY_BASE + 0x64100)
> +#define VLV_DP_C		_MMIO(VLV_DISPLAY_BASE + 0x64200)
> +#define CHV_DP_D		_MMIO(VLV_DISPLAY_BASE + 0x64300)
> +#define   DP_PORT_EN			REG_BIT(31)
> +#define   DP_PIPE_SEL_MASK		REG_GENMASK(30, 30)
> +#define   DP_PIPE_SEL(pipe)		REG_FIELD_PREP(DP_PIPE_SEL_MASK,
> (pipe))
> +#define   DP_PIPE_SEL_MASK_IVB		REG_GENMASK(30, 29)
> +#define   DP_PIPE_SEL_IVB(pipe)
> 	REG_FIELD_PREP(DP_PIPE_SEL_MASK_IVB, (pipe))
> +#define   DP_PIPE_SEL_SHIFT_CHV		16
> +#define   DP_PIPE_SEL_MASK_CHV		REG_GENMASK(17, 16)
> +#define   DP_PIPE_SEL_CHV(pipe)
> 	REG_FIELD_PREP(DP_PIPE_SEL_MASK_CHV, (pipe))
> +#define   DP_LINK_TRAIN_MASK		REG_GENMASK(29, 28)
> +#define   DP_LINK_TRAIN_PAT_1
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 0)
> +#define   DP_LINK_TRAIN_PAT_2
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 1)
> +#define   DP_LINK_TRAIN_PAT_IDLE
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 2)
> +#define   DP_LINK_TRAIN_OFF
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 3)
> +#define   DP_LINK_TRAIN_MASK_CPT	REG_GENMASK(10, 8)
> +#define   DP_LINK_TRAIN_PAT_1_CPT
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 0)
> +#define   DP_LINK_TRAIN_PAT_2_CPT
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 1)
> +#define   DP_LINK_TRAIN_PAT_IDLE_CPT
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 2)
> +#define   DP_LINK_TRAIN_OFF_CPT
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 3)
> +#define   DP_VOLTAGE_MASK		REG_GENMASK(27, 25)
> +#define   DP_VOLTAGE_0_4
> 	REG_FIELD_PREP(DP_VOLTAGE_MASK, 0)
> +#define   DP_VOLTAGE_0_6
> 	REG_FIELD_PREP(DP_VOLTAGE_MASK, 1)
> +#define   DP_VOLTAGE_0_8
> 	REG_FIELD_PREP(DP_VOLTAGE_MASK, 2)
> +#define   DP_VOLTAGE_1_2
> 	REG_FIELD_PREP(DP_VOLTAGE_MASK, 3)
> +#define   DP_PRE_EMPHASIS_MASK		REG_GENMASK(24, 22)
> +#define   DP_PRE_EMPHASIS_0
> 	REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 0)
> +#define   DP_PRE_EMPHASIS_3_5
> 	REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 1)
> +#define   DP_PRE_EMPHASIS_6
> 	REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 2)
> +#define   DP_PRE_EMPHASIS_9_5
> 	REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 3)
> +#define   DP_PORT_WIDTH_MASK		REG_GENMASK(21, 19)
> +#define   DP_PORT_WIDTH(width)
> 	REG_FIELD_PREP(DP_PORT_WIDTH_MASK, (width) - 1)
> +#define   DP_ENHANCED_FRAMING		REG_BIT(18)
> +#define   EDP_PLL_FREQ_MASK		REG_GENMASK(17, 16)
> +#define   EDP_PLL_FREQ_270MHZ
> 	REG_FIELD_PREP(EDP_PLL_FREQ_MASK, 0)
> +#define   EDP_PLL_FREQ_162MHZ
> 	REG_FIELD_PREP(EDP_PLL_FREQ_MASK, 1)
> +#define   DP_PORT_REVERSAL		REG_BIT(15)
> +#define   EDP_PLL_ENABLE		REG_BIT(14)
> +#define   DP_CLOCK_OUTPUT_ENABLE	REG_BIT(13)
> +#define   DP_SCRAMBLING_DISABLE		REG_BIT(12)
> +#define   DP_SCRAMBLING_DISABLE_ILK	REG_BIT(7)
> +#define   DP_COLOR_RANGE_16_235		REG_BIT(8)
> +#define   DP_AUDIO_OUTPUT_ENABLE	REG_BIT(6)
> +#define   DP_SYNC_VS_HIGH		REG_BIT(4)
> +#define   DP_SYNC_HS_HIGH		REG_BIT(3)
> +#define   DP_DETECTED			REG_BIT(2)
> +
> +/*
> + * Computing GMCH M and N values for the Display Port link
> + *
> + * GMCH M/N = dot clock * bytes per pixel / ls_clk * # of lanes
> + *
> + * ls_clk (we assume) is the DP link clock (1.62 or 2.7 GHz)
> + *
> + * The GMCH value is used internally
> + *
> + * bytes_per_pixel is the number of bytes coming out of the plane,
> + * which is after the LUTs, so we want the bytes for our color format.
> + * For our current usage, this is always 3, one byte for R, G and B.
> + */
> +#define _PIPEA_DATA_M_G4X	0x70050
> +#define _PIPEB_DATA_M_G4X	0x71050
> +#define PIPE_DATA_M_G4X(pipe) _MMIO_PIPE(pipe, _PIPEA_DATA_M_G4X,
> _PIPEB_DATA_M_G4X)
> +/* Transfer unit size for display port - 1, default is 0x3f (for TU size 64) */
> +#define  TU_SIZE_MASK		REG_GENMASK(30, 25)
> +#define  TU_SIZE(x)		REG_FIELD_PREP(TU_SIZE_MASK, (x) - 1) /*
> default size 64 */
> +#define  DATA_LINK_M_N_MASK	REG_GENMASK(23, 0)
> +#define  DATA_LINK_N_MAX	(0x800000)
> +
> +#define _PIPEA_DATA_N_G4X	0x70054
> +#define _PIPEB_DATA_N_G4X	0x71054
> +#define PIPE_DATA_N_G4X(pipe) _MMIO_PIPE(pipe, _PIPEA_DATA_N_G4X,
> _PIPEB_DATA_N_G4X)
> +
> +/*
> + * Computing Link M and N values for the Display Port link
> + *
> + * Link M / N = pixel_clock / ls_clk
> + *
> + * (the DP spec calls pixel_clock the 'strm_clk')
> + *
> + * The Link value is transmitted in the Main Stream
> + * Attributes and VB-ID.
> + */
> +#define _PIPEA_LINK_M_G4X	0x70060
> +#define _PIPEB_LINK_M_G4X	0x71060
> +#define PIPE_LINK_M_G4X(pipe) _MMIO_PIPE(pipe, _PIPEA_LINK_M_G4X,
> _PIPEB_LINK_M_G4X)
> +
> +#define _PIPEA_LINK_N_G4X	0x70064
> +#define _PIPEB_LINK_N_G4X	0x71064
> +#define PIPE_LINK_N_G4X(pipe) _MMIO_PIPE(pipe, _PIPEA_LINK_N_G4X,
> _PIPEB_LINK_N_G4X)
> +
> +/* Pipe A */
> +#define _PIPEADSL		0x70000
> +#define PIPEDSL(dev_priv, pipe)		_MMIO_PIPE2(dev_priv, pipe,
> _PIPEADSL)
> +#define   PIPEDSL_CURR_FIELD	REG_BIT(31) /* ctg+ */
> +#define   PIPEDSL_LINE_MASK	REG_GENMASK(19, 0)
> +
> +#define _TRANSACONF		0x70008
> +#define TRANSCONF(dev_priv, trans)	_MMIO_PIPE2(dev_priv, (trans),
> _TRANSACONF)
> +#define   TRANSCONF_ENABLE			REG_BIT(31)
> +#define   TRANSCONF_DOUBLE_WIDE			REG_BIT(30) /* pre-
> i965 */
> +#define   TRANSCONF_STATE_ENABLE			REG_BIT(30) /* i965+
> */
> +#define   TRANSCONF_DSI_PLL_LOCKED		REG_BIT(29) /* vlv &
> pipe A only */
> +#define   TRANSCONF_FRAME_START_DELAY_MASK	REG_GENMASK(28,
> 27) /* pre-hsw */
> +#define   TRANSCONF_FRAME_START_DELAY(x)
> 	REG_FIELD_PREP(TRANSCONF_FRAME_START_DELAY_MASK, (x)) /*
> pre-hsw: 0-3 */
> +#define   TRANSCONF_PIPE_LOCKED			REG_BIT(25)
> +#define   TRANSCONF_FORCE_BORDER			REG_BIT(25)
> +#define   TRANSCONF_GAMMA_MODE_MASK_I9XX		REG_BIT(24)
> /* gmch */
> +#define   TRANSCONF_GAMMA_MODE_MASK_ILK
> 	REG_GENMASK(25, 24) /* ilk-ivb */
> +#define   TRANSCONF_GAMMA_MODE_8BIT
> 	REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK, 0)
> +#define   TRANSCONF_GAMMA_MODE_10BIT
> 	REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK, 1)
> +#define   TRANSCONF_GAMMA_MODE_12BIT
> 	REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK_ILK, 2) /* ilk-
> ivb */
> +#define   TRANSCONF_GAMMA_MODE_SPLIT
> 	REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK_ILK, 3) /* ivb
> */
> +#define   TRANSCONF_GAMMA_MODE(x)
> 	REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK_ILK, (x)) /*
> pass in GAMMA_MODE_MODE_* */
> +#define   TRANSCONF_INTERLACE_MASK		REG_GENMASK(23,
> 21) /* gen3+ */
> +#define   TRANSCONF_INTERLACE_PROGRESSIVE
> 	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 0)
> +#define   TRANSCONF_INTERLACE_W_SYNC_SHIFT_PANEL
> 	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 4) /* gen4 only */
> +#define   TRANSCONF_INTERLACE_W_SYNC_SHIFT
> 	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 5) /* gen4 only */
> +#define   TRANSCONF_INTERLACE_W_FIELD_INDICATION
> 	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 6)
> +#define   TRANSCONF_INTERLACE_FIELD_0_ONLY
> 	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 7) /* gen3 only */
> +/*
> + * ilk+: PF/D=progressive fetch/display, IF/D=interlaced fetch/display,
> + * DBL=power saving pixel doubling, PF-ID* requires panel fitter
> + */
> +#define   TRANSCONF_INTERLACE_MASK_ILK		REG_GENMASK(23,
> 21) /* ilk+ */
> +#define   TRANSCONF_INTERLACE_MASK_HSW
> 	REG_GENMASK(22, 21) /* hsw+ */
> +#define   TRANSCONF_INTERLACE_PF_PD_ILK
> 	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 0)
> +#define   TRANSCONF_INTERLACE_PF_ID_ILK
> 	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 1)
> +#define   TRANSCONF_INTERLACE_IF_ID_ILK
> 	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 3)
> +#define   TRANSCONF_INTERLACE_IF_ID_DBL_ILK
> 	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 4) /* ilk/snb
> only */
> +#define   TRANSCONF_INTERLACE_PF_ID_DBL_ILK
> 	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 5) /* ilk/snb
> only */
> +#define   TRANSCONF_REFRESH_RATE_ALT_ILK		REG_BIT(20)
> +#define   TRANSCONF_MSA_TIMING_DELAY_MASK	REG_GENMASK(19,
> 18) /* ilk/snb/ivb */
> +#define   TRANSCONF_MSA_TIMING_DELAY(x)
> 	REG_FIELD_PREP(TRANSCONF_MSA_TIMING_DELAY_MASK, (x))
> +#define   TRANSCONF_CXSR_DOWNCLOCK		REG_BIT(16)
> +#define   TRANSCONF_WGC_ENABLE			REG_BIT(15) /*
> vlv/chv only */
> +#define   TRANSCONF_REFRESH_RATE_ALT_VLV		REG_BIT(14)
> +#define   TRANSCONF_COLOR_RANGE_SELECT		REG_BIT(13)
> +#define   TRANSCONF_OUTPUT_COLORSPACE_MASK	REG_GENMASK(12,
> 11) /* ilk-ivb */
> +#define   TRANSCONF_OUTPUT_COLORSPACE_RGB
> 	REG_FIELD_PREP(TRANSCONF_OUTPUT_COLORSPACE_MASK, 0) /*
> ilk-ivb */
> +#define   TRANSCONF_OUTPUT_COLORSPACE_YUV601
> 	REG_FIELD_PREP(TRANSCONF_OUTPUT_COLORSPACE_MASK, 1) /*
> ilk-ivb */
> +#define   TRANSCONF_OUTPUT_COLORSPACE_YUV709
> 	REG_FIELD_PREP(TRANSCONF_OUTPUT_COLORSPACE_MASK, 2) /*
> ilk-ivb */
> +#define   TRANSCONF_OUTPUT_COLORSPACE_YUV_HSW	REG_BIT(11)
> /* hsw only */
> +#define   TRANSCONF_BPC_MASK			REG_GENMASK(7, 5)
> /* ctg-ivb */
> +#define   TRANSCONF_BPC_8
> 	REG_FIELD_PREP(TRANSCONF_BPC_MASK, 0)
> +#define   TRANSCONF_BPC_10
> 	REG_FIELD_PREP(TRANSCONF_BPC_MASK, 1)
> +#define   TRANSCONF_BPC_6
> 	REG_FIELD_PREP(TRANSCONF_BPC_MASK, 2)
> +#define   TRANSCONF_BPC_12
> 	REG_FIELD_PREP(TRANSCONF_BPC_MASK, 3)
> +#define   TRANSCONF_DITHER_EN			REG_BIT(4)
> +#define   TRANSCONF_DITHER_TYPE_MASK		REG_GENMASK(3, 2)
> +#define   TRANSCONF_DITHER_TYPE_SP
> 	REG_FIELD_PREP(TRANSCONF_DITHER_TYPE_MASK, 0)
> +#define   TRANSCONF_DITHER_TYPE_ST1
> 	REG_FIELD_PREP(TRANSCONF_DITHER_TYPE_MASK, 1)
> +#define   TRANSCONF_DITHER_TYPE_ST2
> 	REG_FIELD_PREP(TRANSCONF_DITHER_TYPE_MASK, 2)
> +#define   TRANSCONF_DITHER_TYPE_TEMP
> 	REG_FIELD_PREP(TRANSCONF_DITHER_TYPE_MASK, 3)
> +#define   TRANSCONF_PIXEL_COUNT_SCALING_MASK	REG_GENMASK(1, 0)
> +#define   TRANSCONF_PIXEL_COUNT_SCALING_X4	1
> +
> +#define _PIPE_ARB_CTL_A			0x70028 /* icl+ */
> +#define PIPE_ARB_CTL(dev_priv, pipe)
> 	_MMIO_PIPE2(dev_priv, pipe, _PIPE_ARB_CTL_A)
> +#define   PIPE_ARB_USE_PROG_SLOTS	REG_BIT(13)
> +
> +#define _PIPE_MISC_A			0x70030
> +#define _PIPE_MISC_B			0x71030
> +#define PIPE_MISC(pipe)			_MMIO_PIPE(pipe,
> _PIPE_MISC_A, _PIPE_MISC_B)
> +#define   PIPE_MISC_YUV420_ENABLE		REG_BIT(27) /* glk+ */
> +#define   PIPE_MISC_YUV420_MODE_FULL_BLEND	REG_BIT(26) /* glk+
> */
> +#define   PIPE_MISC_HDR_MODE_PRECISION		REG_BIT(23) /* icl+ */
> +#define   PIPE_MISC_PSR_MASK_PRIMARY_FLIP	REG_BIT(23) /* bdw
> */
> +#define   PIPE_MISC_PSR_MASK_SPRITE_ENABLE	REG_BIT(22) /* bdw
> */
> +#define   PIPE_MISC_PSR_MASK_PIPE_REG_WRITE	REG_BIT(21) /* skl+
> */
> +#define   PIPE_MISC_PSR_MASK_CURSOR_MOVE	REG_BIT(21) /* bdw
> */
> +#define   PIPE_MISC_PSR_MASK_VBLANK_VSYNC_INT	REG_BIT(20)
> +#define   PIPE_MISC_OUTPUT_COLORSPACE_YUV	REG_BIT(11)
> +#define   PIPE_MISC_PIXEL_ROUNDING_TRUNC	REG_BIT(8) /* tgl+ */
> +/*
> + * For Display < 13, Bits 5-7 of PIPE MISC represent DITHER BPC with
> + * valid values of: 6, 8, 10 BPC.
> + * ADLP+, the bits 5-7 represent PORT OUTPUT BPC with valid values of:
> + * 6, 8, 10, 12 BPC.
> + */
> +#define   PIPE_MISC_BPC_MASK			REG_GENMASK(7, 5)
> +#define   PIPE_MISC_BPC_8
> 	REG_FIELD_PREP(PIPE_MISC_BPC_MASK, 0)
> +#define   PIPE_MISC_BPC_10
> 	REG_FIELD_PREP(PIPE_MISC_BPC_MASK, 1)
> +#define   PIPE_MISC_BPC_6
> 	REG_FIELD_PREP(PIPE_MISC_BPC_MASK, 2)
> +#define   PIPE_MISC_BPC_12_ADLP
> 	REG_FIELD_PREP(PIPE_MISC_BPC_MASK, 4) /* adlp+ */
> +#define   PIPE_MISC_DITHER_ENABLE		REG_BIT(4)
> +#define   PIPE_MISC_DITHER_TYPE_MASK		REG_GENMASK(3, 2)
> +#define   PIPE_MISC_DITHER_TYPE_SP
> 	REG_FIELD_PREP(PIPE_MISC_DITHER_TYPE_MASK, 0)
> +#define   PIPE_MISC_DITHER_TYPE_ST1
> 	REG_FIELD_PREP(PIPE_MISC_DITHER_TYPE_MASK, 1)
> +#define   PIPE_MISC_DITHER_TYPE_ST2
> 	REG_FIELD_PREP(PIPE_MISC_DITHER_TYPE_MASK, 2)
> +#define   PIPE_MISC_DITHER_TYPE_TEMP
> 	REG_FIELD_PREP(PIPE_MISC_DITHER_TYPE_MASK, 3)
> +
> +#define DPINVGTT				_MMIO(VLV_DISPLAY_BASE +
> 0x7002c) /* VLV/CHV only */
> +#define   DPINVGTT_EN_MASK_CHV
> 	REG_GENMASK(27, 16)
> +#define   DPINVGTT_EN_MASK_VLV
> 	REG_GENMASK(23, 16)
> +#define   SPRITEF_INVALID_GTT_INT_EN			REG_BIT(27)
> +#define   SPRITEE_INVALID_GTT_INT_EN			REG_BIT(26)
> +#define   PLANEC_INVALID_GTT_INT_EN			REG_BIT(25)
> +#define   CURSORC_INVALID_GTT_INT_EN			REG_BIT(24)
> +#define   CURSORB_INVALID_GTT_INT_EN			REG_BIT(23)
> +#define   CURSORA_INVALID_GTT_INT_EN			REG_BIT(22)
> +#define   SPRITED_INVALID_GTT_INT_EN			REG_BIT(21)
> +#define   SPRITEC_INVALID_GTT_INT_EN			REG_BIT(20)
> +#define   PLANEB_INVALID_GTT_INT_EN			REG_BIT(19)
> +#define   SPRITEB_INVALID_GTT_INT_EN			REG_BIT(18)
> +#define   SPRITEA_INVALID_GTT_INT_EN			REG_BIT(17)
> +#define   PLANEA_INVALID_GTT_INT_EN			REG_BIT(16)
> +#define   DPINVGTT_STATUS_MASK_CHV
> 	REG_GENMASK(11, 0)
> +#define   DPINVGTT_STATUS_MASK_VLV
> 	REG_GENMASK(7, 0)
> +#define   SPRITEF_INVALID_GTT_STATUS			REG_BIT(11)
> +#define   SPRITEE_INVALID_GTT_STATUS			REG_BIT(10)
> +#define   PLANEC_INVALID_GTT_STATUS			REG_BIT(9)
> +#define   CURSORC_INVALID_GTT_STATUS			REG_BIT(8)
> +#define   CURSORB_INVALID_GTT_STATUS			REG_BIT(7)
> +#define   CURSORA_INVALID_GTT_STATUS			REG_BIT(6)
> +#define   SPRITED_INVALID_GTT_STATUS			REG_BIT(5)
> +#define   SPRITEC_INVALID_GTT_STATUS			REG_BIT(4)
> +#define   PLANEB_INVALID_GTT_STATUS			REG_BIT(3)
> +#define   SPRITEB_INVALID_GTT_STATUS			REG_BIT(2)
> +#define   SPRITEA_INVALID_GTT_STATUS			REG_BIT(1)
> +#define   PLANEA_INVALID_GTT_STATUS			REG_BIT(0)
> +
> +#define CBR1_VLV			_MMIO(VLV_DISPLAY_BASE +
> 0x70400)
> +#define  CBR_PND_DEADLINE_DISABLE	(1 << 31)
> +#define  CBR_PWM_CLOCK_MUX_SELECT	(1 << 30)
> +
> +#define CBR4_VLV			_MMIO(VLV_DISPLAY_BASE +
> 0x70450)
> +#define  CBR_DPLLBMD_PIPE(pipe)		(1 << (7 + (pipe) * 11)) /*
> pipes B and C */
> +
> +/*
> + * The two pipe frame counter registers are not synchronized, so
> + * reading a stable value is somewhat tricky. The following code
> + * should work:
> + *
> + *  do {
> + *    high1 = ((INREG(PIPEAFRAMEHIGH) & PIPE_FRAME_HIGH_MASK) >>
> + *             PIPE_FRAME_HIGH_SHIFT;
> + *    low1 =  ((INREG(PIPEAFRAMEPIXEL) & PIPE_FRAME_LOW_MASK) >>
> + *             PIPE_FRAME_LOW_SHIFT);
> + *    high2 = ((INREG(PIPEAFRAMEHIGH) & PIPE_FRAME_HIGH_MASK) >>
> + *             PIPE_FRAME_HIGH_SHIFT);
> + *  } while (high1 != high2);
> + *  frame = (high1 << 8) | low1;
> + */
> +#define _PIPEAFRAMEHIGH          0x70040
> +#define PIPEFRAME(dev_priv, pipe)		_MMIO_PIPE2(dev_priv, pipe,
> _PIPEAFRAMEHIGH)
> +#define   PIPE_FRAME_HIGH_MASK    0x0000ffff
> +#define   PIPE_FRAME_HIGH_SHIFT   0
> +
> +#define _PIPEAFRAMEPIXEL         0x70044
> +#define PIPEFRAMEPIXEL(dev_priv, pipe)	_MMIO_PIPE2(dev_priv, pipe,
> _PIPEAFRAMEPIXEL)
> +#define   PIPE_FRAME_LOW_MASK     0xff000000
> +#define   PIPE_FRAME_LOW_SHIFT    24
> +#define   PIPE_PIXEL_MASK         0x00ffffff
> +#define   PIPE_PIXEL_SHIFT        0
> +
> +/* GM45+ just has to be different */
> +#define _PIPEA_FRMCOUNT_G4X	0x70040
> +#define PIPE_FRMCOUNT_G4X(dev_priv, pipe) _MMIO_PIPE2(dev_priv,
> pipe, _PIPEA_FRMCOUNT_G4X)
> +
> +/* CHV pipe B blender */
> +#define _CHV_BLEND_A		0x60a00
> +#define CHV_BLEND(dev_priv, pipe)		_MMIO_TRANS2(dev_priv,
> pipe, _CHV_BLEND_A)
> +#define   CHV_BLEND_MASK	REG_GENMASK(31, 30)
> +#define   CHV_BLEND_LEGACY	REG_FIELD_PREP(CHV_BLEND_MASK,
> 0)
> +#define   CHV_BLEND_ANDROID	REG_FIELD_PREP(CHV_BLEND_MASK,
> 1)
> +#define   CHV_BLEND_MPO		REG_FIELD_PREP(CHV_BLEND_MASK,
> 2)
> +
> +#define _CHV_CANVAS_A		0x60a04
> +#define CHV_CANVAS(dev_priv, pipe)	_MMIO_TRANS2(dev_priv, pipe,
> _CHV_CANVAS_A)
> +#define   CHV_CANVAS_RED_MASK	REG_GENMASK(29, 20)
> +#define   CHV_CANVAS_GREEN_MASK	REG_GENMASK(19, 10)
> +#define   CHV_CANVAS_BLUE_MASK	REG_GENMASK(9, 0)
> +
> +/*
> + * VBIOS flags
> + * gen2:
> + * [00:06] alm,mgm
> + * [10:16] all
> + * [30:32] alm,mgm
> + * gen3+:
> + * [00:0f] all
> + * [10:1f] all
> + * [30:32] all
> + */
> +#define SWF0(dev_priv, i)	_MMIO(DISPLAY_MMIO_BASE(dev_priv) +
> 0x70410 + (i) * 4)
> +#define SWF1(dev_priv, i)	_MMIO(DISPLAY_MMIO_BASE(dev_priv) +
> 0x71410 + (i) * 4)
> +#define SWF3(dev_priv, i)	_MMIO(DISPLAY_MMIO_BASE(dev_priv) +
> 0x72414 + (i) * 4)
> +#define SWF_ILK(i)	_MMIO(0x4F000 + (i) * 4)
> +
> +/* VBIOS regs */
> +#define VGACNTRL		_MMIO(0x71400)
> +# define VGA_DISP_DISABLE			(1 << 31)
> +# define VGA_2X_MODE				(1 << 30)
> +# define VGA_PIPE_B_SELECT			(1 << 29)
> +
> +#define VLV_VGACNTRL		_MMIO(VLV_DISPLAY_BASE +
> 0x71400)
> +
> +#define CPU_VGACNTRL	_MMIO(0x41000)
> +
> +#define DIGITAL_PORT_HOTPLUG_CNTRL	_MMIO(0x44030)
> +#define  DIGITAL_PORTA_HOTPLUG_ENABLE		(1 << 4)
> +#define  DIGITAL_PORTA_PULSE_DURATION_2ms	(0 << 2) /* pre-HSW
> */
> +#define  DIGITAL_PORTA_PULSE_DURATION_4_5ms	(1 << 2) /* pre-HSW
> */
> +#define  DIGITAL_PORTA_PULSE_DURATION_6ms	(2 << 2) /* pre-HSW
> */
> +#define  DIGITAL_PORTA_PULSE_DURATION_100ms	(3 << 2) /* pre-HSW
> */
> +#define  DIGITAL_PORTA_PULSE_DURATION_MASK	(3 << 2) /* pre-HSW
> */
> +#define  DIGITAL_PORTA_HOTPLUG_STATUS_MASK	(3 << 0)
> +#define  DIGITAL_PORTA_HOTPLUG_NO_DETECT	(0 << 0)
> +#define  DIGITAL_PORTA_HOTPLUG_SHORT_DETECT	(1 << 0)
> +#define  DIGITAL_PORTA_HOTPLUG_LONG_DETECT	(2 << 0)
> +
> +#define _PIPEA_DATA_M1		0x60030
> +#define _PIPEB_DATA_M1		0x61030
> +#define PIPE_DATA_M1(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran,
> _PIPEA_DATA_M1)
> +
> +#define _PIPEA_DATA_N1		0x60034
> +#define _PIPEB_DATA_N1		0x61034
> +#define PIPE_DATA_N1(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran,
> _PIPEA_DATA_N1)
> +
> +#define _PIPEA_DATA_M2		0x60038
> +#define _PIPEB_DATA_M2		0x61038
> +#define PIPE_DATA_M2(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran,
> _PIPEA_DATA_M2)
> +
> +#define _PIPEA_DATA_N2		0x6003c
> +#define _PIPEB_DATA_N2		0x6103c
> +#define PIPE_DATA_N2(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran,
> _PIPEA_DATA_N2)
> +
> +#define _PIPEA_LINK_M1		0x60040
> +#define _PIPEB_LINK_M1		0x61040
> +#define PIPE_LINK_M1(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran,
> _PIPEA_LINK_M1)
> +
> +#define _PIPEA_LINK_N1		0x60044
> +#define _PIPEB_LINK_N1		0x61044
> +#define PIPE_LINK_N1(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran,
> _PIPEA_LINK_N1)
> +
> +#define _PIPEA_LINK_M2		0x60048
> +#define _PIPEB_LINK_M2		0x61048
> +#define PIPE_LINK_M2(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran,
> _PIPEA_LINK_M2)
> +
> +#define _PIPEA_LINK_N2		0x6004c
> +#define _PIPEB_LINK_N2		0x6104c
> +#define PIPE_LINK_N2(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran,
> _PIPEA_LINK_N2)
> +
> +/* CPU panel fitter */
> +/* IVB+ has 3 fitters, 0 is 7x5 capable, the other two only 3x3 */
> +#define _PFA_CTL_1		0x68080
> +#define _PFB_CTL_1		0x68880
> +#define PF_CTL(pipe)		_MMIO_PIPE(pipe, _PFA_CTL_1, _PFB_CTL_1)
> +#define   PF_ENABLE			REG_BIT(31)
> +#define   PF_PIPE_SEL_MASK_IVB		REG_GENMASK(30, 29) /*
> ivb/hsw */
> +#define   PF_PIPE_SEL_IVB(pipe)
> 	REG_FIELD_PREP(PF_PIPE_SEL_MASK_IVB, (pipe))
> +#define   PF_FILTER_MASK		REG_GENMASK(24, 23)
> +#define   PF_FILTER_PROGRAMMED
> 	REG_FIELD_PREP(PF_FILTER_MASK, 0)
> +#define   PF_FILTER_MED_3x3		REG_FIELD_PREP(PF_FILTER_MASK, 1)
> +#define   PF_FILTER_EDGE_ENHANCE
> 	REG_FIELD_PREP(PF_FILTER_EDGE_MASK, 2)
> +#define   PF_FILTER_EDGE_SOFTEN
> 	REG_FIELD_PREP(PF_FILTER_EDGE_MASK, 3)
> +
> +#define _PFA_WIN_SZ		0x68074
> +#define _PFB_WIN_SZ		0x68874
> +#define PF_WIN_SZ(pipe)		_MMIO_PIPE(pipe, _PFA_WIN_SZ,
> _PFB_WIN_SZ)
> +#define   PF_WIN_XSIZE_MASK	REG_GENMASK(31, 16)
> +#define   PF_WIN_XSIZE(w)	REG_FIELD_PREP(PF_WIN_XSIZE_MASK, (w))
> +#define   PF_WIN_YSIZE_MASK	REG_GENMASK(15, 0)
> +#define   PF_WIN_YSIZE(h)	REG_FIELD_PREP(PF_WIN_YSIZE_MASK, (h))
> +
> +#define _PFA_WIN_POS		0x68070
> +#define _PFB_WIN_POS		0x68870
> +#define PF_WIN_POS(pipe)	_MMIO_PIPE(pipe, _PFA_WIN_POS,
> _PFB_WIN_POS)
> +#define   PF_WIN_XPOS_MASK	REG_GENMASK(31, 16)
> +#define   PF_WIN_XPOS(x)	REG_FIELD_PREP(PF_WIN_XPOS_MASK, (x))
> +#define   PF_WIN_YPOS_MASK	REG_GENMASK(15, 0)
> +#define   PF_WIN_YPOS(y)	REG_FIELD_PREP(PF_WIN_YPOS_MASK, (y))
> +
> +/*
> + * Skylake scalers
> + */
> +#define _ID(id, a, b) _PICK_EVEN(id, a, b)
> +#define _PS_1A_CTRL      0x68180
> +#define _PS_2A_CTRL      0x68280
> +#define _PS_1B_CTRL      0x68980
> +#define _PS_2B_CTRL      0x68A80
> +#define _PS_1C_CTRL      0x69180
> +#define SKL_PS_CTRL(pipe, id) _MMIO_PIPE(pipe,        \
> +			_ID(id, _PS_1A_CTRL, _PS_2A_CTRL),       \
> +			_ID(id, _PS_1B_CTRL, _PS_2B_CTRL))
> +#define   PS_SCALER_EN				REG_BIT(31)
> +#define   PS_SCALER_TYPE_MASK			REG_BIT(30) /* icl+ */
> +#define   PS_SCALER_TYPE_NON_LINEAR
> 	REG_FIELD_PREP(PS_SCALER_TYPE_MASK, 0)
> +#define   PS_SCALER_TYPE_LINEAR
> 	REG_FIELD_PREP(PS_SCALER_TYPE_MASK, 1)
> +#define   SKL_PS_SCALER_MODE_MASK		REG_GENMASK(29,
> 28) /* skl/bxt */
> +#define   SKL_PS_SCALER_MODE_DYN
> 	REG_FIELD_PREP(SKL_PS_SCALER_MODE_MASK, 0)
> +#define   SKL_PS_SCALER_MODE_HQ
> 	REG_FIELD_PREP(SKL_PS_SCALER_MODE_MASK, 1)
> +#define   SKL_PS_SCALER_MODE_NV12
> 	REG_FIELD_PREP(SKL_PS_SCALER_MODE_MASK, 2)
> +#define   PS_SCALER_MODE_MASK			REG_BIT(29) /* glk-tgl
> */
> +#define   PS_SCALER_MODE_NORMAL
> 	REG_FIELD_PREP(PS_SCALER_MODE_MASK, 0)
> +#define   PS_SCALER_MODE_PLANAR
> 	REG_FIELD_PREP(PS_SCALER_MODE_MASK, 1)
> +#define   PS_ADAPTIVE_FILTERING_EN		REG_BIT(28) /* icl+ */
> +#define   PS_BINDING_MASK			REG_GENMASK(27, 25)
> +#define   PS_BINDING_PIPE
> 	REG_FIELD_PREP(PS_BINDING_MASK, 0)
> +#define   PS_BINDING_PLANE(plane_id)
> 	REG_FIELD_PREP(PS_BINDING_MASK, (plane_id) + 1)
> +#define   PS_FILTER_MASK			REG_GENMASK(24, 23)
> +#define   PS_FILTER_MEDIUM
> 	REG_FIELD_PREP(PS_FILTER_MASK, 0)
> +#define   PS_FILTER_PROGRAMMED
> 	REG_FIELD_PREP(PS_FILTER_MASK, 1)
> +#define   PS_FILTER_EDGE_ENHANCE
> 	REG_FIELD_PREP(PS_FILTER_MASK, 2)
> +#define   PS_FILTER_BILINEAR
> 	REG_FIELD_PREP(PS_FILTER_MASK, 3)
> +#define   PS_ADAPTIVE_FILTER_MASK		REG_BIT(22) /* icl+ */
> +#define   PS_ADAPTIVE_FILTER_MEDIUM
> 	REG_FIELD_PREP(PS_ADAPTIVE_FILTER_MASK, 0)
> +#define   PS_ADAPTIVE_FILTER_EDGE_ENHANCE
> 	REG_FIELD_PREP(PS_ADAPTIVE_FILTER_MASK, 1)
> +#define   PS_PIPE_SCALER_LOC_MASK		REG_BIT(21) /* icl+ */
> +#define   PS_PIPE_SCALER_LOC_AFTER_OUTPUT_CSC
> 	REG_FIELD_PREP(PS_SCALER_LOCATION_MASK, 0) /* non-linear */
> +#define   PS_PIPE_SCALER_LOC_AFTER_CSC
> 	REG_FIELD_PREP(PS_SCALER_LOCATION_MASK, 1) /* linear */
> +#define   PS_VERT3TAP				REG_BIT(21) /*
> skl/bxt */
> +#define   PS_VERT_INT_INVERT_FIELD		REG_BIT(20)
> +#define   PS_PROG_SCALE_FACTOR			REG_BIT(19) /* tgl+
> */
> +#define   PS_PWRUP_PROGRESS			REG_BIT(17)
> +#define   PS_V_FILTER_BYPASS			REG_BIT(8)
> +#define   PS_VADAPT_EN				REG_BIT(7) /* skl/bxt
> */
> +#define   PS_VADAPT_MODE_MASK			REG_GENMASK(6, 5)
> /* skl/bxt */
> +#define   PS_VADAPT_MODE_LEAST_ADAPT
> 	REG_FIELD_PREP(PS_VADAPT_MODE_MASK, 0)
> +#define   PS_VADAPT_MODE_MOD_ADAPT
> 	REG_FIELD_PREP(PS_VADAPT_MODE_MASK, 1)
> +#define   PS_VADAPT_MODE_MOST_ADAPT
> 	REG_FIELD_PREP(PS_VADAPT_MODE_MASK, 3)
> +#define   PS_BINDING_Y_MASK			REG_GENMASK(7, 5)
> /* icl-tgl */
> +#define   PS_BINDING_Y_PLANE(plane_id)
> 	REG_FIELD_PREP(PS_BINDING_Y_MASK, (plane_id) + 1)
> +#define   PS_Y_VERT_FILTER_SELECT_MASK		REG_BIT(4) /* glk+ */
> +#define   PS_Y_VERT_FILTER_SELECT(set)
> 	REG_FIELD_PREP(PS_Y_VERT_FILTER_SELECT_MASK, (set))
> +#define   PS_Y_HORZ_FILTER_SELECT_MASK		REG_BIT(3) /* glk+ */
> +#define   PS_Y_HORZ_FILTER_SELECT(set)
> 	REG_FIELD_PREP(PS_Y_HORZ_FILTER_SELECT_MASK, (set))
> +#define   PS_UV_VERT_FILTER_SELECT_MASK		REG_BIT(2) /* glk+ */
> +#define   PS_UV_VERT_FILTER_SELECT(set)
> 	REG_FIELD_PREP(PS_UV_VERT_FILTER_SELECT_MASK, (set))
> +#define   PS_UV_HORZ_FILTER_SELECT_MASK		REG_BIT(1) /* glk+ */
> +#define   PS_UV_HORZ_FILTER_SELECT(set)
> 	REG_FIELD_PREP(PS_UV_HORZ_FILTER_SELECT_MASK, (set))
> +
> +#define _PS_WIN_POS_1A      0x68170
> +#define _PS_WIN_POS_2A      0x68270
> +#define _PS_WIN_POS_1B      0x68970
> +#define _PS_WIN_POS_2B      0x68A70
> +#define _PS_WIN_POS_1C      0x69170
> +#define SKL_PS_WIN_POS(pipe, id) _MMIO_PIPE(pipe,     \
> +			_ID(id, _PS_WIN_POS_1A, _PS_WIN_POS_2A), \
> +			_ID(id, _PS_WIN_POS_1B, _PS_WIN_POS_2B))
> +#define   PS_WIN_XPOS_MASK			REG_GENMASK(31,
> 16)
> +#define   PS_WIN_XPOS(x)
> 	REG_FIELD_PREP(PS_WIN_XPOS_MASK, (x))
> +#define   PS_WIN_YPOS_MASK			REG_GENMASK(15, 0)
> +#define   PS_WIN_YPOS(y)
> 	REG_FIELD_PREP(PS_WIN_YPOS_MASK, (y))
> +
> +#define _PS_WIN_SZ_1A       0x68174
> +#define _PS_WIN_SZ_2A       0x68274
> +#define _PS_WIN_SZ_1B       0x68974
> +#define _PS_WIN_SZ_2B       0x68A74
> +#define _PS_WIN_SZ_1C       0x69174
> +#define SKL_PS_WIN_SZ(pipe, id)  _MMIO_PIPE(pipe,     \
> +			_ID(id, _PS_WIN_SZ_1A, _PS_WIN_SZ_2A),   \
> +			_ID(id, _PS_WIN_SZ_1B, _PS_WIN_SZ_2B))
> +#define   PS_WIN_XSIZE_MASK			REG_GENMASK(31,
> 16)
> +#define   PS_WIN_XSIZE(w)
> 	REG_FIELD_PREP(PS_WIN_XSIZE_MASK, (w))
> +#define   PS_WIN_YSIZE_MASK			REG_GENMASK(15, 0)
> +#define   PS_WIN_YSIZE(h)
> 	REG_FIELD_PREP(PS_WIN_YSIZE_MASK, (h))
> +
> +#define _PS_VPHASE_1A       0x68188
> +#define _PS_VPHASE_2A       0x68288
> +#define _PS_VPHASE_1B       0x68988
> +#define _PS_VPHASE_2B       0x68A88
> +#define _PS_VPHASE_1C       0x69188
> +#define SKL_PS_VPHASE(pipe, id)  _MMIO_PIPE(pipe,     \
> +			_ID(id, _PS_VPHASE_1A, _PS_VPHASE_2A),   \
> +			_ID(id, _PS_VPHASE_1B, _PS_VPHASE_2B))
> +#define   PS_Y_PHASE_MASK			REG_GENMASK(31, 16)
> +#define   PS_Y_PHASE(x)
> 	REG_FIELD_PREP(PS_Y_PHASE_MASK, (x))
> +#define   PS_UV_RGB_PHASE_MASK			REG_GENMASK(15, 0)
> +#define   PS_UV_RGB_PHASE(x)
> 	REG_FIELD_PREP(PS_UV_RGB_PHASE_MASK, (x))
> +#define   PS_PHASE_MASK				(0x7fff << 1) /* u2.13
> */
> +#define   PS_PHASE_TRIP				(1 << 0)
> +
> +#define _PS_HPHASE_1A       0x68194
> +#define _PS_HPHASE_2A       0x68294
> +#define _PS_HPHASE_1B       0x68994
> +#define _PS_HPHASE_2B       0x68A94
> +#define _PS_HPHASE_1C       0x69194
> +#define SKL_PS_HPHASE(pipe, id)  _MMIO_PIPE(pipe,     \
> +			_ID(id, _PS_HPHASE_1A, _PS_HPHASE_2A),   \
> +			_ID(id, _PS_HPHASE_1B, _PS_HPHASE_2B))
> +
> +#define _PS_COEF_SET0_INDEX_1A	   0x68198
> +#define _PS_COEF_SET0_INDEX_2A	   0x68298
> +#define _PS_COEF_SET0_INDEX_1B	   0x68998
> +#define _PS_COEF_SET0_INDEX_2B	   0x68A98
> +#define GLK_PS_COEF_INDEX_SET(pipe, id, set)  _MMIO_PIPE(pipe,    \
> +			_ID(id, _PS_COEF_SET0_INDEX_1A,
> _PS_COEF_SET0_INDEX_2A) + (set) * 8, \
> +			_ID(id, _PS_COEF_SET0_INDEX_1B,
> _PS_COEF_SET0_INDEX_2B) + (set) * 8)
> +#define   PS_COEF_INDEX_AUTO_INC		REG_BIT(10)
> +
> +#define _PS_COEF_SET0_DATA_1A	   0x6819C
> +#define _PS_COEF_SET0_DATA_2A	   0x6829C
> +#define _PS_COEF_SET0_DATA_1B	   0x6899C
> +#define _PS_COEF_SET0_DATA_2B	   0x68A9C
> +#define GLK_PS_COEF_DATA_SET(pipe, id, set)  _MMIO_PIPE(pipe,     \
> +			_ID(id, _PS_COEF_SET0_DATA_1A,
> _PS_COEF_SET0_DATA_2A) + (set) * 8, \
> +			_ID(id, _PS_COEF_SET0_DATA_1B,
> _PS_COEF_SET0_DATA_2B) + (set) * 8)
> +
> +/* More Ivybridge lolz */
> +#define DE_ERR_INT_IVB			(1 << 30)
> +#define DE_GSE_IVB			(1 << 29)
> +#define DE_PCH_EVENT_IVB		(1 << 28)
> +#define DE_DP_A_HOTPLUG_IVB		(1 << 27)
> +#define DE_AUX_CHANNEL_A_IVB		(1 << 26)
> +#define DE_EDP_PSR_INT_HSW		(1 << 19)
> +#define DE_SPRITEC_FLIP_DONE_IVB	(1 << 14)
> +#define DE_PLANEC_FLIP_DONE_IVB		(1 << 13)
> +#define DE_PIPEC_VBLANK_IVB		(1 << 10)
> +#define DE_SPRITEB_FLIP_DONE_IVB	(1 << 9)
> +#define DE_PLANEB_FLIP_DONE_IVB		(1 << 8)
> +#define DE_PIPEB_VBLANK_IVB		(1 << 5)
> +#define DE_SPRITEA_FLIP_DONE_IVB	(1 << 4)
> +#define DE_PLANEA_FLIP_DONE_IVB		(1 << 3)
> +#define DE_PLANE_FLIP_DONE_IVB(plane)	(1 << (3 + 5 * (plane)))
> +#define DE_PIPEA_VBLANK_IVB		(1 << 0)
> +#define DE_PIPE_VBLANK_IVB(pipe)	(1 << ((pipe) * 5))
> +
> +#define XELPD_DISPLAY_ERR_FATAL_MASK	_MMIO(0x4421c)
> +
> +#define GEN8_DE_PIPE_ISR(pipe) _MMIO(0x44400 + (0x10 * (pipe)))
> +#define GEN8_DE_PIPE_IMR(pipe) _MMIO(0x44404 + (0x10 * (pipe)))
> +#define GEN8_DE_PIPE_IIR(pipe) _MMIO(0x44408 + (0x10 * (pipe)))
> +#define GEN8_DE_PIPE_IER(pipe) _MMIO(0x4440c + (0x10 * (pipe)))
> +#define  GEN8_PIPE_FIFO_UNDERRUN	REG_BIT(31)
> +#define  GEN8_PIPE_CDCLK_CRC_ERROR	REG_BIT(29)
> +#define  GEN8_PIPE_CDCLK_CRC_DONE	REG_BIT(28)
> +#define  GEN12_PIPEDMC_INTERRUPT	REG_BIT(26) /* tgl+ */
> +#define  GEN12_PIPEDMC_FAULT		REG_BIT(25) /* tgl+ */
> +#define  MTL_PIPEDMC_ATS_FAULT		REG_BIT(24) /* mtl+ */
> +#define  GEN11_PIPE_PLANE7_FAULT	REG_BIT(22) /* icl/tgl */
> +#define  GEN11_PIPE_PLANE6_FAULT	REG_BIT(21) /* icl/tgl */
> +#define  GEN11_PIPE_PLANE5_FAULT	REG_BIT(20) /* icl+ */
> +#define  GEN12_PIPE_VBLANK_UNMOD	REG_BIT(19) /* tgl+ */
> +#define  MTL_PLANE_ATS_FAULT		REG_BIT(18) /* mtl+ */
> +#define  GEN11_PIPE_PLANE7_FLIP_DONE	REG_BIT(18) /* icl/tgl */
> +#define  GEN11_PIPE_PLANE6_FLIP_DONE	REG_BIT(17) /* icl/tgl */
> +#define  GEN11_PIPE_PLANE5_FLIP_DONE	REG_BIT(16) /* icl+ */
> +#define  GEN12_DSB_2_INT		REG_BIT(15) /* tgl+ */
> +#define  GEN12_DSB_1_INT		REG_BIT(14) /* tgl+ */
> +#define  GEN12_DSB_0_INT		REG_BIT(13) /* tgl+ */
> +#define  GEN12_DSB_INT(dsb_id)		REG_BIT(13 + (dsb_id))
> +#define  GEN9_PIPE_CURSOR_FAULT		REG_BIT(11) /* skl+ */
> +#define  GEN9_PIPE_PLANE4_FAULT		REG_BIT(10) /* skl+ */
> +#define  GEN8_PIPE_CURSOR_FAULT		REG_BIT(10) /* bdw */
> +#define  GEN9_PIPE_PLANE3_FAULT		REG_BIT(9) /* skl+ */
> +#define  GEN8_PIPE_SPRITE_FAULT		REG_BIT(9) /* bdw */
> +#define  GEN9_PIPE_PLANE2_FAULT		REG_BIT(8) /* skl+ */
> +#define  GEN8_PIPE_PRIMARY_FAULT	REG_BIT(8) /* bdw */
> +#define  GEN9_PIPE_PLANE1_FAULT		REG_BIT(7) /* skl+ */
> +#define  GEN9_PIPE_PLANE4_FLIP_DONE	REG_BIT(6) /* skl+ */
> +#define  GEN9_PIPE_PLANE3_FLIP_DONE	REG_BIT(5) /* skl+ */
> +#define  GEN8_PIPE_SPRITE_FLIP_DONE	REG_BIT(5) /* bdw */
> +#define  GEN9_PIPE_PLANE2_FLIP_DONE	REG_BIT(4) /* skl+ */
> +#define  GEN8_PIPE_PRIMARY_FLIP_DONE	REG_BIT(4) /* bdw */
> +#define  GEN9_PIPE_PLANE1_FLIP_DONE	REG_BIT(3) /* skl+ */
> +#define  GEN9_PIPE_PLANE_FLIP_DONE(plane_id) \
> +	REG_BIT(((plane_id) >= PLANE_5 ? 16 - PLANE_5 : 3 - PLANE_1) +
> (plane_id)) /* skl+ */
> +#define  GEN8_PIPE_SCAN_LINE_EVENT	REG_BIT(2)
> +#define  GEN8_PIPE_VSYNC		REG_BIT(1)
> +#define  GEN8_PIPE_VBLANK		REG_BIT(0)
> +
> +#define GEN8_DE_PIPE_IRQ_REGS(pipe)
> 	I915_IRQ_REGS(GEN8_DE_PIPE_IMR(pipe), \
> +						      GEN8_DE_PIPE_IER(pipe),
> \
> +						      GEN8_DE_PIPE_IIR(pipe))
> +
> +#define GEN8_DE_PORT_ISR _MMIO(0x44440)
> +#define GEN8_DE_PORT_IMR _MMIO(0x44444)
> +#define GEN8_DE_PORT_IIR _MMIO(0x44448)
> +#define GEN8_DE_PORT_IER _MMIO(0x4444c)
> +#define  DSI1_NON_TE			(1 << 31)
> +#define  DSI0_NON_TE			(1 << 30)
> +#define  ICL_AUX_CHANNEL_E		(1 << 29)
> +#define  ICL_AUX_CHANNEL_F		(1 << 28)
> +#define  GEN9_AUX_CHANNEL_D		(1 << 27)
> +#define  GEN9_AUX_CHANNEL_C		(1 << 26)
> +#define  GEN9_AUX_CHANNEL_B		(1 << 25)
> +#define  DSI1_TE			(1 << 24)
> +#define  DSI0_TE			(1 << 23)
> +#define  GEN8_DE_PORT_HOTPLUG(hpd_pin)	REG_BIT(3 +
> _HPD_PIN_DDI(hpd_pin))
> +#define  BXT_DE_PORT_HOTPLUG_MASK
> 	(GEN8_DE_PORT_HOTPLUG(HPD_PORT_A) | \
> +
> GEN8_DE_PORT_HOTPLUG(HPD_PORT_B) | \
> +
> GEN8_DE_PORT_HOTPLUG(HPD_PORT_C))
> +#define  BDW_DE_PORT_HOTPLUG_MASK
> 	GEN8_DE_PORT_HOTPLUG(HPD_PORT_A)
> +#define  BXT_DE_PORT_GMBUS		(1 << 1)
> +#define  GEN8_AUX_CHANNEL_A		(1 << 0)
> +#define  TGL_DE_PORT_AUX_USBC6		REG_BIT(13)
> +#define  XELPD_DE_PORT_AUX_DDIE		REG_BIT(13)
> +#define  TGL_DE_PORT_AUX_USBC5		REG_BIT(12)
> +#define  XELPD_DE_PORT_AUX_DDID		REG_BIT(12)
> +#define  TGL_DE_PORT_AUX_USBC4		REG_BIT(11)
> +#define  TGL_DE_PORT_AUX_USBC3		REG_BIT(10)
> +#define  TGL_DE_PORT_AUX_USBC2		REG_BIT(9)
> +#define  TGL_DE_PORT_AUX_USBC1		REG_BIT(8)
> +#define  TGL_DE_PORT_AUX_DDIC		REG_BIT(2)
> +#define  TGL_DE_PORT_AUX_DDIB		REG_BIT(1)
> +#define  TGL_DE_PORT_AUX_DDIA		REG_BIT(0)
> +
> +#define GEN8_DE_PORT_IRQ_REGS
> 	I915_IRQ_REGS(GEN8_DE_PORT_IMR, \
> +						      GEN8_DE_PORT_IER, \
> +						      GEN8_DE_PORT_IIR)
> +
> +#define GEN8_DE_MISC_IRQ_REGS
> 	I915_IRQ_REGS(GEN8_DE_MISC_IMR, \
> +						      GEN8_DE_MISC_IER, \
> +						      GEN8_DE_MISC_IIR)
> +
> +#define GEN11_DISPLAY_INT_CTL		_MMIO(0x44200)
> +#define  GEN11_DISPLAY_IRQ_ENABLE	(1 << 31)
> +#define  GEN11_AUDIO_CODEC_IRQ		(1 << 24)
> +#define  GEN11_DE_PCH_IRQ		(1 << 23)
> +#define  GEN11_DE_MISC_IRQ		(1 << 22)
> +#define  GEN11_DE_HPD_IRQ		(1 << 21)
> +#define  GEN11_DE_PORT_IRQ		(1 << 20)
> +#define  GEN11_DE_PIPE_C		(1 << 18)
> +#define  GEN11_DE_PIPE_B		(1 << 17)
> +#define  GEN11_DE_PIPE_A		(1 << 16)
> +
> +#define GEN11_DE_HPD_ISR		_MMIO(0x44470)
> +#define GEN11_DE_HPD_IMR		_MMIO(0x44474)
> +#define GEN11_DE_HPD_IIR		_MMIO(0x44478)
> +#define GEN11_DE_HPD_IER		_MMIO(0x4447c)
> +#define  GEN11_TC_HOTPLUG(hpd_pin)		REG_BIT(16 +
> _HPD_PIN_TC(hpd_pin))
> +#define  GEN11_DE_TC_HOTPLUG_MASK
> 	(GEN11_TC_HOTPLUG(HPD_PORT_TC6) | \
> +
> GEN11_TC_HOTPLUG(HPD_PORT_TC5) | \
> +
> GEN11_TC_HOTPLUG(HPD_PORT_TC4) | \
> +
> GEN11_TC_HOTPLUG(HPD_PORT_TC3) | \
> +
> GEN11_TC_HOTPLUG(HPD_PORT_TC2) | \
> +
> GEN11_TC_HOTPLUG(HPD_PORT_TC1))
> +#define  GEN11_TBT_HOTPLUG(hpd_pin)
> 	REG_BIT(_HPD_PIN_TC(hpd_pin))
> +#define  GEN11_DE_TBT_HOTPLUG_MASK
> 	(GEN11_TBT_HOTPLUG(HPD_PORT_TC6) | \
> +
> GEN11_TBT_HOTPLUG(HPD_PORT_TC5) | \
> +
> GEN11_TBT_HOTPLUG(HPD_PORT_TC4) | \
> +
> GEN11_TBT_HOTPLUG(HPD_PORT_TC3) | \
> +
> GEN11_TBT_HOTPLUG(HPD_PORT_TC2) | \
> +
> GEN11_TBT_HOTPLUG(HPD_PORT_TC1))
> +
> +#define GEN11_DE_HPD_IRQ_REGS
> 	I915_IRQ_REGS(GEN11_DE_HPD_IMR, \
> +						      GEN11_DE_HPD_IER, \
> +						      GEN11_DE_HPD_IIR)
> +
> +#define GEN11_TBT_HOTPLUG_CTL
> 	_MMIO(0x44030)
> +#define GEN11_TC_HOTPLUG_CTL
> 	_MMIO(0x44038)
> +#define  GEN11_HOTPLUG_CTL_ENABLE(hpd_pin)		(8 <<
> (_HPD_PIN_TC(hpd_pin) * 4))
> +#define  GEN11_HOTPLUG_CTL_LONG_DETECT(hpd_pin)		(2 <<
> (_HPD_PIN_TC(hpd_pin) * 4))
> +#define  GEN11_HOTPLUG_CTL_SHORT_DETECT(hpd_pin)	(1 <<
> (_HPD_PIN_TC(hpd_pin) * 4))
> +#define  GEN11_HOTPLUG_CTL_NO_DETECT(hpd_pin)		(0 <<
> (_HPD_PIN_TC(hpd_pin) * 4))
> +
> +#define PICAINTERRUPT_ISR			_MMIO(0x16FE50)
> +#define PICAINTERRUPT_IMR			_MMIO(0x16FE54)
> +#define PICAINTERRUPT_IIR			_MMIO(0x16FE58)
> +#define PICAINTERRUPT_IER			_MMIO(0x16FE5C)
> +#define  XELPDP_DP_ALT_HOTPLUG(hpd_pin)		REG_BIT(16 +
> _HPD_PIN_TC(hpd_pin))
> +#define  XELPDP_DP_ALT_HOTPLUG_MASK		REG_GENMASK(19,
> 16)
> +#define  XELPDP_AUX_TC(hpd_pin)			REG_BIT(8 +
> _HPD_PIN_TC(hpd_pin))
> +#define  XELPDP_AUX_TC_MASK			REG_GENMASK(11, 8)
> +#define  XE2LPD_AUX_DDI(hpd_pin)		REG_BIT(6 +
> _HPD_PIN_DDI(hpd_pin))
> +#define  XE2LPD_AUX_DDI_MASK			REG_GENMASK(7, 6)
> +#define  XELPDP_TBT_HOTPLUG(hpd_pin)
> 	REG_BIT(_HPD_PIN_TC(hpd_pin))
> +#define  XELPDP_TBT_HOTPLUG_MASK		REG_GENMASK(3, 0)
> +
> +#define PICAINTERRUPT_IRQ_REGS
> 	I915_IRQ_REGS(PICAINTERRUPT_IMR, \
> +
> PICAINTERRUPT_IER, \
> +
> PICAINTERRUPT_IIR)
> +
> +#define XELPDP_PORT_HOTPLUG_CTL(hpd_pin)	_MMIO(0x16F270 +
> (_HPD_PIN_TC(hpd_pin) * 0x200))
> +#define  XELPDP_TBT_HOTPLUG_ENABLE		REG_BIT(6)
> +#define  XELPDP_TBT_HPD_LONG_DETECT		REG_BIT(5)
> +#define  XELPDP_TBT_HPD_SHORT_DETECT		REG_BIT(4)
> +#define  XELPDP_DP_ALT_HOTPLUG_ENABLE		REG_BIT(2)
> +#define  XELPDP_DP_ALT_HPD_LONG_DETECT		REG_BIT(1)
> +#define  XELPDP_DP_ALT_HPD_SHORT_DETECT		REG_BIT(0)
> +
> +#define XELPDP_INITIATE_PMDEMAND_REQUEST(dword)
> 	_MMIO(0x45230 + 4 * (dword))
> +#define  XELPDP_PMDEMAND_QCLK_GV_BW_MASK
> 	REG_GENMASK(31, 16)
> +#define  XELPDP_PMDEMAND_VOLTAGE_INDEX_MASK
> 	REG_GENMASK(14, 12)
> +#define  XELPDP_PMDEMAND_QCLK_GV_INDEX_MASK
> 	REG_GENMASK(11, 8)
> +#define  XE3_PMDEMAND_PIPES_MASK
> 	REG_GENMASK(7, 4)
> +#define  XELPDP_PMDEMAND_PIPES_MASK
> 	REG_GENMASK(7, 6)
> +#define  XELPDP_PMDEMAND_DBUFS_MASK
> 	REG_GENMASK(5, 4)
> +#define  XELPDP_PMDEMAND_PHYS_MASK
> 	REG_GENMASK(2, 0)
> +
> +#define  XELPDP_PMDEMAND_REQ_ENABLE			REG_BIT(31)
> +#define  XELPDP_PMDEMAND_CDCLK_FREQ_MASK
> 	REG_GENMASK(30, 20)
> +#define  XELPDP_PMDEMAND_DDICLK_FREQ_MASK
> 	REG_GENMASK(18, 8)
> +#define  XELPDP_PMDEMAND_SCALERS_MASK
> 	REG_GENMASK(6, 4)
> +#define  XELPDP_PMDEMAND_PLLS_MASK
> 	REG_GENMASK(2, 0)
> +
> +#define GEN12_DCPR_STATUS_1
> 	_MMIO(0x46440)
> +#define  XELPDP_PMDEMAND_INFLIGHT_STATUS		REG_BIT(26)
> +
> +#define FUSE_STRAP		_MMIO(0x42014)
> +#define   ILK_INTERNAL_GRAPHICS_DISABLE	REG_BIT(31)
> +#define   ILK_INTERNAL_DISPLAY_DISABLE	REG_BIT(30)
> +#define   ILK_DISPLAY_DEBUG_DISABLE	REG_BIT(29)
> +#define   IVB_PIPE_C_DISABLE		REG_BIT(28)
> +#define   ILK_HDCP_DISABLE		REG_BIT(25)
> +#define   ILK_eDP_A_DISABLE		REG_BIT(24)
> +#define   HSW_CDCLK_LIMIT		REG_BIT(24)
> +#define   ILK_DESKTOP			REG_BIT(23)
> +#define   HSW_CPU_SSC_ENABLE		REG_BIT(21)
> +
> +#define FUSE_STRAP3		_MMIO(0x42020)
> +#define   HSW_REF_CLK_SELECT		REG_BIT(1)
> +
> +#define CHICKEN_MISC_2		_MMIO(0x42084)
> +#define   CHICKEN_MISC_DISABLE_DPT	REG_BIT(30) /* adl,dg2 */
> +#define   BMG_DARB_HALF_BLK_END_BURST	REG_BIT(27)
> +#define   KBL_ARB_FILL_SPARE_14		REG_BIT(14)
> +#define   KBL_ARB_FILL_SPARE_13		REG_BIT(13)
> +#define   GLK_CL2_PWR_DOWN		REG_BIT(12)
> +#define   GLK_CL1_PWR_DOWN		REG_BIT(11)
> +#define   GLK_CL0_PWR_DOWN		REG_BIT(10)
> +
> +#define CHICKEN_MISC_3		_MMIO(0x42088)
> +#define   DP_MST_DPT_DPTP_ALIGN_WA(trans)	REG_BIT(9 + (trans) -
> TRANSCODER_A)
> +#define   DP_MST_SHORT_HBLANK_WA(trans)		REG_BIT(5 +
> (trans) - TRANSCODER_A)
> +#define   DP_MST_FEC_BS_JITTER_WA(trans)	REG_BIT(0 + (trans) -
> TRANSCODER_A)
> +
> +#define CHICKEN_MISC_4		_MMIO(0x4208c)
> +#define   CHICKEN_FBC_STRIDE_OVERRIDE	REG_BIT(13)
> +#define   CHICKEN_FBC_STRIDE_MASK	REG_GENMASK(12, 0)
> +#define   CHICKEN_FBC_STRIDE(x)
> 	REG_FIELD_PREP(CHICKEN_FBC_STRIDE_MASK, (x))
> +
> +#define _CHICKEN_TRANS_A	0x420c0
> +#define _CHICKEN_TRANS_B	0x420c4
> +#define _CHICKEN_TRANS_C	0x420c8
> +#define _CHICKEN_TRANS_EDP	0x420cc
> +#define _CHICKEN_TRANS_D	0x420d8
> +#define _CHICKEN_TRANS(trans)	_MMIO(_PICK((trans), \
> +					    [TRANSCODER_EDP] =
> _CHICKEN_TRANS_EDP, \
> +					    [TRANSCODER_A] =
> _CHICKEN_TRANS_A, \
> +					    [TRANSCODER_B] =
> _CHICKEN_TRANS_B, \
> +					    [TRANSCODER_C] =
> _CHICKEN_TRANS_C, \
> +					    [TRANSCODER_D] =
> _CHICKEN_TRANS_D))
> +#define _MTL_CHICKEN_TRANS_A	0x604e0
> +#define _MTL_CHICKEN_TRANS_B	0x614e0
> +#define _MTL_CHICKEN_TRANS(trans)	_MMIO_TRANS((trans), \
> +						    _MTL_CHICKEN_TRANS_A,
> \
> +						    _MTL_CHICKEN_TRANS_B)
> +#define CHICKEN_TRANS(display, trans)	(DISPLAY_VER(display) >= 14 ?
> _MTL_CHICKEN_TRANS(trans) : _CHICKEN_TRANS(trans))
> +#define   PIPE_VBLANK_WITH_DELAY	REG_BIT(31) /* tgl+ */
> +#define   SKL_UNMASK_VBL_TO_PIPE_IN_SRD	REG_BIT(30) /* skl+ */
> +#define   HSW_FRAME_START_DELAY_MASK	REG_GENMASK(28, 27)
> +#define   HSW_FRAME_START_DELAY(x)
> 	REG_FIELD_PREP(HSW_FRAME_START_DELAY_MASK, x)
> +#define   VSC_DATA_SEL_SOFTWARE_CONTROL	REG_BIT(25) /* GLK
> */
> +#define   FECSTALL_DIS_DPTSTREAM_DPTTG	REG_BIT(23)
> +#define   DDI_TRAINING_OVERRIDE_ENABLE	REG_BIT(19)
> +#define   ADLP_1_BASED_X_GRANULARITY	REG_BIT(18)
> +#define   DDI_TRAINING_OVERRIDE_VALUE	REG_BIT(18)
> +#define   DDIE_TRAINING_OVERRIDE_ENABLE	REG_BIT(17) /*
> CHICKEN_TRANS_A only */
> +#define   DDIE_TRAINING_OVERRIDE_VALUE	REG_BIT(16) /*
> CHICKEN_TRANS_A only */
> +#define   PSR2_ADD_VERTICAL_LINE_COUNT	REG_BIT(15)
> +#define   DP_FEC_BS_JITTER_WA		REG_BIT(15)
> +#define   PSR2_VSC_ENABLE_PROG_HEADER	REG_BIT(12)
> +#define   DP_DSC_INSERT_SF_AT_EOL_WA	REG_BIT(4)
> +#define   HDCP_LINE_REKEY_DISABLE	REG_BIT(0)
> +
> +#define DISP_ARB_CTL2	_MMIO(0x45004)
> +#define   DISP_DATA_PARTITION_5_6	REG_BIT(6)
> +#define   DISP_IPC_ENABLE		REG_BIT(3)
> +
> +#define GEN7_MSG_CTL	_MMIO(0x45010)
> +#define  WAIT_FOR_PCH_RESET_ACK		(1 << 1)
> +#define  WAIT_FOR_PCH_FLR_ACK		(1 << 0)
> +
> +#define _BW_BUDDY0_CTL			0x45130
> +#define _BW_BUDDY1_CTL			0x45140
> +#define BW_BUDDY_CTL(x)			_MMIO(_PICK_EVEN(x, \
> +							 _BW_BUDDY0_CTL, \
> +							 _BW_BUDDY1_CTL))
> +#define   BW_BUDDY_DISABLE		REG_BIT(31)
> +#define   BW_BUDDY_TLB_REQ_TIMER_MASK	REG_GENMASK(21, 16)
> +#define   BW_BUDDY_TLB_REQ_TIMER(x)
> 	REG_FIELD_PREP(BW_BUDDY_TLB_REQ_TIMER_MASK, x)
> +
> +#define _BW_BUDDY0_PAGE_MASK		0x45134
> +#define _BW_BUDDY1_PAGE_MASK		0x45144
> +#define BW_BUDDY_PAGE_MASK(x)		_MMIO(_PICK_EVEN(x, \
> +
> _BW_BUDDY0_PAGE_MASK, \
> +
> _BW_BUDDY1_PAGE_MASK))
> +
> +#define HSW_NDE_RSTWRN_OPT	_MMIO(0x46408)
> +#define  MTL_RESET_PICA_HANDSHAKE_EN	REG_BIT(6)
> +#define  RESET_PCH_HANDSHAKE_ENABLE	REG_BIT(4)
> +
> +#define GEN11_CHICKEN_DCPR_2			_MMIO(0x46434)
> +#define   DCPR_MASK_MAXLATENCY_MEMUP_CLR	REG_BIT(27)
> +#define   DCPR_MASK_LPMODE			REG_BIT(26)
> +#define   DCPR_SEND_RESP_IMM			REG_BIT(25)
> +#define   DCPR_CLEAR_MEMSTAT_DIS		REG_BIT(24)
> +
> +#define XELPD_CHICKEN_DCPR_3			_MMIO(0x46438)
> +#define   DMD_RSP_TIMEOUT_DISABLE		REG_BIT(19)
> +
> +#define SKL_DFSM			_MMIO(0x51000)
> +#define   SKL_DFSM_DISPLAY_PM_DISABLE	(1 << 27)
> +#define   SKL_DFSM_DISPLAY_HDCP_DISABLE	(1 << 25)
> +#define   SKL_DFSM_CDCLK_LIMIT_MASK	(3 << 23)
> +#define   SKL_DFSM_CDCLK_LIMIT_675	(0 << 23)
> +#define   SKL_DFSM_CDCLK_LIMIT_540	(1 << 23)
> +#define   SKL_DFSM_CDCLK_LIMIT_450	(2 << 23)
> +#define   SKL_DFSM_CDCLK_LIMIT_337_5	(3 << 23)
> +#define   ICL_DFSM_DMC_DISABLE		(1 << 23)
> +#define   SKL_DFSM_PIPE_A_DISABLE	(1 << 30)
> +#define   SKL_DFSM_PIPE_B_DISABLE	(1 << 21)
> +#define   SKL_DFSM_PIPE_C_DISABLE	(1 << 28)
> +#define   TGL_DFSM_PIPE_D_DISABLE	(1 << 22)
> +#define   GLK_DFSM_DISPLAY_DSC_DISABLE	(1 << 7)
> +#define   XE2LPD_DFSM_DBUF_OVERLAP_DISABLE	(1 << 3)
> +
> +#define XE2LPD_DE_CAP			_MMIO(0x41100)
> +#define   XE2LPD_DE_CAP_3DLUT_MASK	REG_GENMASK(31, 30)
> +#define   XE2LPD_DE_CAP_DSC_MASK	REG_GENMASK(29, 28)
> +#define   XE2LPD_DE_CAP_DSC_REMOVED	1
> +#define   XE2LPD_DE_CAP_SCALER_MASK	REG_GENMASK(27, 26)
> +#define   XE2LPD_DE_CAP_SCALER_SINGLE	1
> +
> +#define SKL_DSSM				_MMIO(0x51004)
> +#define ICL_DSSM_CDCLK_PLL_REFCLK_MASK		(7 << 29)
> +#define ICL_DSSM_CDCLK_PLL_REFCLK_24MHz		(0 << 29)
> +#define ICL_DSSM_CDCLK_PLL_REFCLK_19_2MHz	(1 << 29)
> +#define ICL_DSSM_CDCLK_PLL_REFCLK_38_4MHz	(2 << 29)
> +
> +/*GEN11 chicken */
> +#define _PIPEA_CHICKEN				0x70038
> +#define _PIPEB_CHICKEN				0x71038
> +#define _PIPEC_CHICKEN				0x72038
> +#define PIPE_CHICKEN(pipe)			_MMIO_PIPE(pipe,
> _PIPEA_CHICKEN,\
> +							   _PIPEB_CHICKEN)
> +#define   UNDERRUN_RECOVERY_DISABLE_ADLP	REG_BIT(30)
> +#define   UNDERRUN_RECOVERY_ENABLE_DG2		REG_BIT(30)
> +#define   PIXEL_ROUNDING_TRUNC_FB_PASSTHRU	REG_BIT(15)
> +#define   DG2_RENDER_CCSTAG_4_3_EN		REG_BIT(12)
> +#define   PER_PIXEL_ALPHA_BYPASS_EN		REG_BIT(7)
> +
> +#define PCH_DISPLAY_BASE	0xc0000u
> +
> +/* south display engine interrupt: IBX */
> +#define SDE_AUDIO_POWER_D	(1 << 27)
> +#define SDE_AUDIO_POWER_C	(1 << 26)
> +#define SDE_AUDIO_POWER_B	(1 << 25)
> +#define SDE_AUDIO_POWER_SHIFT	(25)
> +#define SDE_AUDIO_POWER_MASK	(7 << SDE_AUDIO_POWER_SHIFT)
> +#define SDE_GMBUS		(1 << 24)
> +#define SDE_AUDIO_HDCP_TRANSB	(1 << 23)
> +#define SDE_AUDIO_HDCP_TRANSA	(1 << 22)
> +#define SDE_AUDIO_HDCP_MASK	(3 << 22)
> +#define SDE_AUDIO_TRANSB	(1 << 21)
> +#define SDE_AUDIO_TRANSA	(1 << 20)
> +#define SDE_AUDIO_TRANS_MASK	(3 << 20)
> +#define SDE_POISON		(1 << 19)
> +/* 18 reserved */
> +#define SDE_FDI_RXB		(1 << 17)
> +#define SDE_FDI_RXA		(1 << 16)
> +#define SDE_FDI_MASK		(3 << 16)
> +#define SDE_AUXD		(1 << 15)
> +#define SDE_AUXC		(1 << 14)
> +#define SDE_AUXB		(1 << 13)
> +#define SDE_AUX_MASK		(7 << 13)
> +/* 12 reserved */
> +#define SDE_CRT_HOTPLUG         (1 << 11)
> +#define SDE_PORTD_HOTPLUG       (1 << 10)
> +#define SDE_PORTC_HOTPLUG       (1 << 9)
> +#define SDE_PORTB_HOTPLUG       (1 << 8)
> +#define SDE_SDVOB_HOTPLUG       (1 << 6)
> +#define SDE_HOTPLUG_MASK        (SDE_CRT_HOTPLUG | \
> +				 SDE_SDVOB_HOTPLUG |	\
> +				 SDE_PORTB_HOTPLUG |	\
> +				 SDE_PORTC_HOTPLUG |	\
> +				 SDE_PORTD_HOTPLUG)
> +#define SDE_TRANSB_CRC_DONE	(1 << 5)
> +#define SDE_TRANSB_CRC_ERR	(1 << 4)
> +#define SDE_TRANSB_FIFO_UNDER	(1 << 3)
> +#define SDE_TRANSA_CRC_DONE	(1 << 2)
> +#define SDE_TRANSA_CRC_ERR	(1 << 1)
> +#define SDE_TRANSA_FIFO_UNDER	(1 << 0)
> +#define SDE_TRANS_MASK		(0x3f)
> +
> +/* south display engine interrupt: CPT - CNP */
> +#define SDE_AUDIO_POWER_D_CPT	(1 << 31)
> +#define SDE_AUDIO_POWER_C_CPT	(1 << 30)
> +#define SDE_AUDIO_POWER_B_CPT	(1 << 29)
> +#define SDE_AUDIO_POWER_SHIFT_CPT   29
> +#define SDE_AUDIO_POWER_MASK_CPT    (7 << 29)
> +#define SDE_AUXD_CPT		(1 << 27)
> +#define SDE_AUXC_CPT		(1 << 26)
> +#define SDE_AUXB_CPT		(1 << 25)
> +#define SDE_AUX_MASK_CPT	(7 << 25)
> +#define SDE_PORTE_HOTPLUG_SPT	(1 << 25)
> +#define SDE_PORTA_HOTPLUG_SPT	(1 << 24)
> +#define SDE_PORTD_HOTPLUG_CPT	(1 << 23)
> +#define SDE_PORTC_HOTPLUG_CPT	(1 << 22)
> +#define SDE_PORTB_HOTPLUG_CPT	(1 << 21)
> +#define SDE_CRT_HOTPLUG_CPT	(1 << 19)
> +#define SDE_SDVOB_HOTPLUG_CPT	(1 << 18)
> +#define SDE_HOTPLUG_MASK_CPT	(SDE_CRT_HOTPLUG_CPT |
> 	\
> +				 SDE_SDVOB_HOTPLUG_CPT |	\
> +				 SDE_PORTD_HOTPLUG_CPT |	\
> +				 SDE_PORTC_HOTPLUG_CPT |	\
> +				 SDE_PORTB_HOTPLUG_CPT)
> +#define SDE_HOTPLUG_MASK_SPT	(SDE_PORTE_HOTPLUG_SPT |	\
> +				 SDE_PORTD_HOTPLUG_CPT |	\
> +				 SDE_PORTC_HOTPLUG_CPT |	\
> +				 SDE_PORTB_HOTPLUG_CPT |	\
> +				 SDE_PORTA_HOTPLUG_SPT)
> +#define SDE_GMBUS_CPT		(1 << 17)
> +#define SDE_ERROR_CPT		(1 << 16)
> +#define SDE_AUDIO_CP_REQ_C_CPT	(1 << 10)
> +#define SDE_AUDIO_CP_CHG_C_CPT	(1 << 9)
> +#define SDE_FDI_RXC_CPT		(1 << 8)
> +#define SDE_AUDIO_CP_REQ_B_CPT	(1 << 6)
> +#define SDE_AUDIO_CP_CHG_B_CPT	(1 << 5)
> +#define SDE_FDI_RXB_CPT		(1 << 4)
> +#define SDE_AUDIO_CP_REQ_A_CPT	(1 << 2)
> +#define SDE_AUDIO_CP_CHG_A_CPT	(1 << 1)
> +#define SDE_FDI_RXA_CPT		(1 << 0)
> +#define SDE_AUDIO_CP_REQ_CPT	(SDE_AUDIO_CP_REQ_C_CPT | \
> +				 SDE_AUDIO_CP_REQ_B_CPT | \
> +				 SDE_AUDIO_CP_REQ_A_CPT)
> +#define SDE_AUDIO_CP_CHG_CPT	(SDE_AUDIO_CP_CHG_C_CPT | \
> +				 SDE_AUDIO_CP_CHG_B_CPT | \
> +				 SDE_AUDIO_CP_CHG_A_CPT)
> +#define SDE_FDI_MASK_CPT	(SDE_FDI_RXC_CPT | \
> +				 SDE_FDI_RXB_CPT | \
> +				 SDE_FDI_RXA_CPT)
> +
> +/* south display engine interrupt: ICP/TGP/MTP */
> +#define SDE_PICAINTERRUPT		REG_BIT(31)
> +#define SDE_GMBUS_ICP			(1 << 23)
> +#define SDE_TC_HOTPLUG_ICP(hpd_pin)	REG_BIT(24 +
> _HPD_PIN_TC(hpd_pin))
> +#define SDE_TC_HOTPLUG_DG2(hpd_pin)	REG_BIT(25 +
> _HPD_PIN_TC(hpd_pin)) /* sigh */
> +#define SDE_DDI_HOTPLUG_ICP(hpd_pin)	REG_BIT(16 +
> _HPD_PIN_DDI(hpd_pin))
> +#define SDE_DDI_HOTPLUG_MASK_ICP
> 	(SDE_DDI_HOTPLUG_ICP(HPD_PORT_D) | \
> +
> SDE_DDI_HOTPLUG_ICP(HPD_PORT_C) | \
> +
> SDE_DDI_HOTPLUG_ICP(HPD_PORT_B) | \
> +
> SDE_DDI_HOTPLUG_ICP(HPD_PORT_A))
> +#define SDE_TC_HOTPLUG_MASK_ICP
> 	(SDE_TC_HOTPLUG_ICP(HPD_PORT_TC6) | \
> +
> SDE_TC_HOTPLUG_ICP(HPD_PORT_TC5) | \
> +
> SDE_TC_HOTPLUG_ICP(HPD_PORT_TC4) | \
> +
> SDE_TC_HOTPLUG_ICP(HPD_PORT_TC3) | \
> +
> SDE_TC_HOTPLUG_ICP(HPD_PORT_TC2) | \
> +
> SDE_TC_HOTPLUG_ICP(HPD_PORT_TC1))
> +
> +/* digital port hotplug */
> +#define PCH_PORT_HOTPLUG		_MMIO(0xc4030)	/*
> SHOTPLUG_CTL */
> +#define  PORTA_HOTPLUG_ENABLE		(1 << 28) /* LPT:LP+ & BXT */
> +#define  BXT_DDIA_HPD_INVERT            (1 << 27)
> +#define  PORTA_HOTPLUG_STATUS_MASK	(3 << 24) /* SPT+ & BXT */
> +#define  PORTA_HOTPLUG_NO_DETECT	(0 << 24) /* SPT+ & BXT */
> +#define  PORTA_HOTPLUG_SHORT_DETECT	(1 << 24) /* SPT+ & BXT */
> +#define  PORTA_HOTPLUG_LONG_DETECT	(2 << 24) /* SPT+ & BXT */
> +#define  PORTD_HOTPLUG_ENABLE		(1 << 20)
> +#define  PORTD_PULSE_DURATION_2ms	(0 << 18) /* pre-LPT */
> +#define  PORTD_PULSE_DURATION_4_5ms	(1 << 18) /* pre-LPT */
> +#define  PORTD_PULSE_DURATION_6ms	(2 << 18) /* pre-LPT */
> +#define  PORTD_PULSE_DURATION_100ms	(3 << 18) /* pre-LPT */
> +#define  PORTD_PULSE_DURATION_MASK	(3 << 18) /* pre-LPT */
> +#define  PORTD_HOTPLUG_STATUS_MASK	(3 << 16)
> +#define  PORTD_HOTPLUG_NO_DETECT	(0 << 16)
> +#define  PORTD_HOTPLUG_SHORT_DETECT	(1 << 16)
> +#define  PORTD_HOTPLUG_LONG_DETECT	(2 << 16)
> +#define  PORTC_HOTPLUG_ENABLE		(1 << 12)
> +#define  BXT_DDIC_HPD_INVERT            (1 << 11)
> +#define  PORTC_PULSE_DURATION_2ms	(0 << 10) /* pre-LPT */
> +#define  PORTC_PULSE_DURATION_4_5ms	(1 << 10) /* pre-LPT */
> +#define  PORTC_PULSE_DURATION_6ms	(2 << 10) /* pre-LPT */
> +#define  PORTC_PULSE_DURATION_100ms	(3 << 10) /* pre-LPT */
> +#define  PORTC_PULSE_DURATION_MASK	(3 << 10) /* pre-LPT */
> +#define  PORTC_HOTPLUG_STATUS_MASK	(3 << 8)
> +#define  PORTC_HOTPLUG_NO_DETECT	(0 << 8)
> +#define  PORTC_HOTPLUG_SHORT_DETECT	(1 << 8)
> +#define  PORTC_HOTPLUG_LONG_DETECT	(2 << 8)
> +#define  PORTB_HOTPLUG_ENABLE		(1 << 4)
> +#define  BXT_DDIB_HPD_INVERT            (1 << 3)
> +#define  PORTB_PULSE_DURATION_2ms	(0 << 2) /* pre-LPT */
> +#define  PORTB_PULSE_DURATION_4_5ms	(1 << 2) /* pre-LPT */
> +#define  PORTB_PULSE_DURATION_6ms	(2 << 2) /* pre-LPT */
> +#define  PORTB_PULSE_DURATION_100ms	(3 << 2) /* pre-LPT */
> +#define  PORTB_PULSE_DURATION_MASK	(3 << 2) /* pre-LPT */
> +#define  PORTB_HOTPLUG_STATUS_MASK	(3 << 0)
> +#define  PORTB_HOTPLUG_NO_DETECT	(0 << 0)
> +#define  PORTB_HOTPLUG_SHORT_DETECT	(1 << 0)
> +#define  PORTB_HOTPLUG_LONG_DETECT	(2 << 0)
> +#define  BXT_DDI_HPD_INVERT_MASK	(BXT_DDIA_HPD_INVERT | \
> +					BXT_DDIB_HPD_INVERT | \
> +					BXT_DDIC_HPD_INVERT)
> +
> +#define PCH_PORT_HOTPLUG2		_MMIO(0xc403C)	/*
> SHOTPLUG_CTL2 SPT+ */
> +#define  PORTE_HOTPLUG_ENABLE		(1 << 4)
> +#define  PORTE_HOTPLUG_STATUS_MASK	(3 << 0)
> +#define  PORTE_HOTPLUG_NO_DETECT	(0 << 0)
> +#define  PORTE_HOTPLUG_SHORT_DETECT	(1 << 0)
> +#define  PORTE_HOTPLUG_LONG_DETECT	(2 << 0)
> +
> +/* This register is a reuse of PCH_PORT_HOTPLUG register. The
> + * functionality covered in PCH_PORT_HOTPLUG is split into
> + * SHOTPLUG_CTL_DDI and SHOTPLUG_CTL_TC.
> + */
> +#define SHOTPLUG_CTL_DDI				_MMIO(0xc4030)
> +#define   SHOTPLUG_CTL_DDI_HPD_ENABLE(hpd_pin)
> 	(0x8 << (_HPD_PIN_DDI(hpd_pin) * 4))
> +#define   SHOTPLUG_CTL_DDI_HPD_OUTPUT_DATA(hpd_pin)		(0x4
> << (_HPD_PIN_DDI(hpd_pin) * 4))
> +#define   SHOTPLUG_CTL_DDI_HPD_STATUS_MASK(hpd_pin)		(0x3
> << (_HPD_PIN_DDI(hpd_pin) * 4))
> +#define   SHOTPLUG_CTL_DDI_HPD_NO_DETECT(hpd_pin)		(0x0
> << (_HPD_PIN_DDI(hpd_pin) * 4))
> +#define   SHOTPLUG_CTL_DDI_HPD_SHORT_DETECT(hpd_pin)		(0x1
> << (_HPD_PIN_DDI(hpd_pin) * 4))
> +#define   SHOTPLUG_CTL_DDI_HPD_LONG_DETECT(hpd_pin)		(0x2
> << (_HPD_PIN_DDI(hpd_pin) * 4))
> +#define   SHOTPLUG_CTL_DDI_HPD_SHORT_LONG_DETECT(hpd_pin)	(0x3
> << (_HPD_PIN_DDI(hpd_pin) * 4))
> +
> +#define SHOTPLUG_CTL_TC				_MMIO(0xc4034)
> +#define   ICP_TC_HPD_ENABLE(hpd_pin)		(8 <<
> (_HPD_PIN_TC(hpd_pin) * 4))
> +#define   ICP_TC_HPD_LONG_DETECT(hpd_pin)	(2 <<
> (_HPD_PIN_TC(hpd_pin) * 4))
> +#define   ICP_TC_HPD_SHORT_DETECT(hpd_pin)	(1 <<
> (_HPD_PIN_TC(hpd_pin) * 4))
> +
> +#define SHPD_FILTER_CNT				_MMIO(0xc4038)
> +#define   SHPD_FILTER_CNT_500_ADJ		0x001D9
> +#define   SHPD_FILTER_CNT_250			0x000F8
> +
> +#define _PCH_DPLL_A              0xc6014
> +#define _PCH_DPLL_B              0xc6018
> +#define PCH_DPLL(pll) _MMIO((pll) == 0 ? _PCH_DPLL_A : _PCH_DPLL_B)
> +
> +#define _PCH_FPA0                0xc6040
> +#define _PCH_FPB0                0xc6048
> +#define PCH_FP0(pll) _MMIO((pll) == 0 ? _PCH_FPA0 : _PCH_FPB0)
> +#define  FP_CB_TUNE		(0x3 << 22)
> +
> +#define _PCH_FPA1                0xc6044
> +#define _PCH_FPB1                0xc604c
> +#define PCH_FP1(pll) _MMIO((pll) == 0 ? _PCH_FPA1 : _PCH_FPB1)
> +
> +#define PCH_DREF_CONTROL        _MMIO(0xC6200)
> +#define  DREF_CONTROL_MASK      0x7fc3
> +#define  DREF_CPU_SOURCE_OUTPUT_DISABLE         (0 << 13)
> +#define  DREF_CPU_SOURCE_OUTPUT_DOWNSPREAD      (2 << 13)
> +#define  DREF_CPU_SOURCE_OUTPUT_NONSPREAD       (3 << 13)
> +#define  DREF_CPU_SOURCE_OUTPUT_MASK		(3 << 13)
> +#define  DREF_SSC_SOURCE_DISABLE                (0 << 11)
> +#define  DREF_SSC_SOURCE_ENABLE                 (2 << 11)
> +#define  DREF_SSC_SOURCE_MASK			(3 << 11)
> +#define  DREF_NONSPREAD_SOURCE_DISABLE          (0 << 9)
> +#define  DREF_NONSPREAD_CK505_ENABLE		(1 << 9)
> +#define  DREF_NONSPREAD_SOURCE_ENABLE           (2 << 9)
> +#define  DREF_NONSPREAD_SOURCE_MASK		(3 << 9)
> +#define  DREF_SUPERSPREAD_SOURCE_DISABLE        (0 << 7)
> +#define  DREF_SUPERSPREAD_SOURCE_ENABLE         (2 << 7)
> +#define  DREF_SUPERSPREAD_SOURCE_MASK		(3 << 7)
> +#define  DREF_SSC4_DOWNSPREAD                   (0 << 6)
> +#define  DREF_SSC4_CENTERSPREAD                 (1 << 6)
> +#define  DREF_SSC1_DISABLE                      (0 << 1)
> +#define  DREF_SSC1_ENABLE                       (1 << 1)
> +#define  DREF_SSC4_DISABLE                      (0)
> +#define  DREF_SSC4_ENABLE                       (1)
> +
> +#define PCH_RAWCLK_FREQ         _MMIO(0xc6204)
> +#define  FDL_TP1_TIMER_SHIFT    12
> +#define  FDL_TP1_TIMER_MASK     (3 << 12)
> +#define  FDL_TP2_TIMER_SHIFT    10
> +#define  FDL_TP2_TIMER_MASK     (3 << 10)
> +#define  RAWCLK_FREQ_MASK       0x3ff
> +#define  CNP_RAWCLK_DIV_MASK	(0x3ff << 16)
> +#define  CNP_RAWCLK_DIV(div)	((div) << 16)
> +#define  CNP_RAWCLK_FRAC_MASK	(0xf << 26)
> +#define  CNP_RAWCLK_DEN(den)	((den) << 26)
> +#define  ICP_RAWCLK_NUM(num)	((num) << 11)
> +
> +#define PCH_DPLL_SEL		_MMIO(0xc7000)
> +#define	 TRANS_DPLLB_SEL(pipe)		(1 << ((pipe) * 4))
> +#define	 TRANS_DPLLA_SEL(pipe)		0
> +#define  TRANS_DPLL_ENABLE(pipe)	(1 << ((pipe) * 4 + 3))
> +
> +/* transcoder */
> +#define _PCH_TRANS_HTOTAL_A		0xe0000
> +#define _PCH_TRANS_HTOTAL_B		0xe1000
> +#define PCH_TRANS_HTOTAL(pipe)		_MMIO_PIPE(pipe,
> _PCH_TRANS_HTOTAL_A, _PCH_TRANS_HTOTAL_B)
> +#define  TRANS_HTOTAL_SHIFT		16
> +#define  TRANS_HACTIVE_SHIFT		0
> +
> +#define _PCH_TRANS_HBLANK_A		0xe0004
> +#define _PCH_TRANS_HBLANK_B		0xe1004
> +#define PCH_TRANS_HBLANK(pipe)		_MMIO_PIPE(pipe,
> _PCH_TRANS_HBLANK_A, _PCH_TRANS_HBLANK_B)
> +#define  TRANS_HBLANK_END_SHIFT		16
> +#define  TRANS_HBLANK_START_SHIFT	0
> +
> +#define _PCH_TRANS_HSYNC_A		0xe0008
> +#define _PCH_TRANS_HSYNC_B		0xe1008
> +#define PCH_TRANS_HSYNC(pipe)		_MMIO_PIPE(pipe,
> _PCH_TRANS_HSYNC_A, _PCH_TRANS_HSYNC_B)
> +#define  TRANS_HSYNC_END_SHIFT		16
> +#define  TRANS_HSYNC_START_SHIFT	0
> +
> +#define _PCH_TRANS_VTOTAL_A		0xe000c
> +#define _PCH_TRANS_VTOTAL_B		0xe100c
> +#define PCH_TRANS_VTOTAL(pipe)		_MMIO_PIPE(pipe,
> _PCH_TRANS_VTOTAL_A, _PCH_TRANS_VTOTAL_B)
> +#define  TRANS_VTOTAL_SHIFT		16
> +#define  TRANS_VACTIVE_SHIFT		0
> +
> +#define _PCH_TRANS_VBLANK_A		0xe0010
> +#define _PCH_TRANS_VBLANK_B		0xe1010
> +#define PCH_TRANS_VBLANK(pipe)		_MMIO_PIPE(pipe,
> _PCH_TRANS_VBLANK_A, _PCH_TRANS_VBLANK_B)
> +#define  TRANS_VBLANK_END_SHIFT		16
> +#define  TRANS_VBLANK_START_SHIFT	0
> +
> +#define _PCH_TRANS_VSYNC_A		0xe0014
> +#define _PCH_TRANS_VSYNC_B		0xe1014
> +#define PCH_TRANS_VSYNC(pipe)		_MMIO_PIPE(pipe,
> _PCH_TRANS_VSYNC_A, _PCH_TRANS_VSYNC_B)
> +#define  TRANS_VSYNC_END_SHIFT		16
> +#define  TRANS_VSYNC_START_SHIFT	0
> +
> +#define _PCH_TRANS_VSYNCSHIFT_A		0xe0028
> +#define _PCH_TRANS_VSYNCSHIFT_B		0xe1028
> +#define PCH_TRANS_VSYNCSHIFT(pipe)	_MMIO_PIPE(pipe,
> _PCH_TRANS_VSYNCSHIFT_A, _PCH_TRANS_VSYNCSHIFT_B)
> +
> +#define _PCH_TRANSA_DATA_M1	0xe0030
> +#define _PCH_TRANSB_DATA_M1	0xe1030
> +#define PCH_TRANS_DATA_M1(pipe)	_MMIO_PIPE(pipe,
> _PCH_TRANSA_DATA_M1, _PCH_TRANSB_DATA_M1)
> +
> +#define _PCH_TRANSA_DATA_N1	0xe0034
> +#define _PCH_TRANSB_DATA_N1	0xe1034
> +#define PCH_TRANS_DATA_N1(pipe)	_MMIO_PIPE(pipe,
> _PCH_TRANSA_DATA_N1, _PCH_TRANSB_DATA_N1)
> +
> +#define _PCH_TRANSA_DATA_M2	0xe0038
> +#define _PCH_TRANSB_DATA_M2	0xe1038
> +#define PCH_TRANS_DATA_M2(pipe)	_MMIO_PIPE(pipe,
> _PCH_TRANSA_DATA_M2, _PCH_TRANSB_DATA_M2)
> +
> +#define _PCH_TRANSA_DATA_N2	0xe003c
> +#define _PCH_TRANSB_DATA_N2	0xe103c
> +#define PCH_TRANS_DATA_N2(pipe)	_MMIO_PIPE(pipe,
> _PCH_TRANSA_DATA_N2, _PCH_TRANSB_DATA_N2)
> +
> +#define _PCH_TRANSA_LINK_M1	0xe0040
> +#define _PCH_TRANSB_LINK_M1	0xe1040
> +#define PCH_TRANS_LINK_M1(pipe)	_MMIO_PIPE(pipe,
> _PCH_TRANSA_LINK_M1, _PCH_TRANSB_LINK_M1)
> +
> +#define _PCH_TRANSA_LINK_N1	0xe0044
> +#define _PCH_TRANSB_LINK_N1	0xe1044
> +#define PCH_TRANS_LINK_N1(pipe)	_MMIO_PIPE(pipe,
> _PCH_TRANSA_LINK_N1, _PCH_TRANSB_LINK_N1)
> +
> +#define _PCH_TRANSA_LINK_M2	0xe0048
> +#define _PCH_TRANSB_LINK_M2	0xe1048
> +#define PCH_TRANS_LINK_M2(pipe)	_MMIO_PIPE(pipe,
> _PCH_TRANSA_LINK_M2, _PCH_TRANSB_LINK_M2)
> +
> +#define _PCH_TRANSA_LINK_N2	0xe004c
> +#define _PCH_TRANSB_LINK_N2	0xe104c
> +#define PCH_TRANS_LINK_N2(pipe)	_MMIO_PIPE(pipe,
> _PCH_TRANSA_LINK_N2, _PCH_TRANSB_LINK_N2)
> +
> +/* Per-transcoder DIP controls (PCH) */
> +#define _VIDEO_DIP_CTL_A         0xe0200
> +#define _VIDEO_DIP_CTL_B         0xe1200
> +#define TVIDEO_DIP_CTL(pipe) _MMIO_PIPE(pipe, _VIDEO_DIP_CTL_A,
> _VIDEO_DIP_CTL_B)
> +
> +#define _VIDEO_DIP_DATA_A        0xe0208
> +#define _VIDEO_DIP_DATA_B        0xe1208
> +#define TVIDEO_DIP_DATA(pipe) _MMIO_PIPE(pipe, _VIDEO_DIP_DATA_A,
> _VIDEO_DIP_DATA_B)
> +
> +#define _VIDEO_DIP_GCP_A         0xe0210
> +#define _VIDEO_DIP_GCP_B         0xe1210
> +#define TVIDEO_DIP_GCP(pipe) _MMIO_PIPE(pipe, _VIDEO_DIP_GCP_A,
> _VIDEO_DIP_GCP_B)
> +#define  GCP_COLOR_INDICATION		(1 << 2)
> +#define  GCP_DEFAULT_PHASE_ENABLE	(1 << 1)
> +#define  GCP_AV_MUTE			(1 << 0)
> +
> +/* Per-transcoder DIP controls (VLV) */
> +#define _VLV_VIDEO_DIP_CTL_A		0x60200
> +#define _VLV_VIDEO_DIP_CTL_B		0x61170
> +#define _CHV_VIDEO_DIP_CTL_C		0x611f0
> +#define VLV_TVIDEO_DIP_CTL(pipe)
> 	_MMIO_BASE_PIPE3(VLV_DISPLAY_BASE, (pipe), \
> +
> _VLV_VIDEO_DIP_CTL_A, \
> +
> _VLV_VIDEO_DIP_CTL_B, \
> +
> _CHV_VIDEO_DIP_CTL_C)
> +
> +#define _VLV_VIDEO_DIP_DATA_A		0x60208
> +#define _VLV_VIDEO_DIP_DATA_B		0x61174
> +#define _CHV_VIDEO_DIP_DATA_C		0x611f4
> +#define VLV_TVIDEO_DIP_DATA(pipe)
> 	_MMIO_BASE_PIPE3(VLV_DISPLAY_BASE, (pipe), \
> +
> _VLV_VIDEO_DIP_DATA_A, \
> +
> _VLV_VIDEO_DIP_DATA_B, \
> +
> _CHV_VIDEO_DIP_DATA_C)
> +
> +#define _VLV_VIDEO_DIP_GDCP_PAYLOAD_A	0x60210
> +#define _VLV_VIDEO_DIP_GDCP_PAYLOAD_B	0x61178
> +#define _CHV_VIDEO_DIP_GDCP_PAYLOAD_C	0x611f8
> +#define VLV_TVIDEO_DIP_GCP(pipe)
> 	_MMIO_BASE_PIPE3(VLV_DISPLAY_BASE, (pipe), \
> +
> _VLV_VIDEO_DIP_GDCP_PAYLOAD_A, \
> +
> _VLV_VIDEO_DIP_GDCP_PAYLOAD_B, \
> +
> _CHV_VIDEO_DIP_GDCP_PAYLOAD_C)
> +
> +/* Haswell DIP controls */
> +#define _HSW_VIDEO_DIP_CTL_A		0x60200
> +#define _HSW_VIDEO_DIP_CTL_B		0x61200
> +#define HSW_TVIDEO_DIP_CTL(dev_priv, trans)
> 	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_CTL_A)
> +
> +#define _HSW_VIDEO_DIP_AVI_DATA_A	0x60220
> +#define _HSW_VIDEO_DIP_AVI_DATA_B	0x61220
> +#define HSW_TVIDEO_DIP_AVI_DATA(dev_priv, trans, i)
> 	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_AVI_DATA_A + (i)
> * 4)
> +
> +#define _HSW_VIDEO_DIP_VS_DATA_A	0x60260
> +#define _HSW_VIDEO_DIP_VS_DATA_B	0x61260
> +#define HSW_TVIDEO_DIP_VS_DATA(dev_priv, trans, i)
> 	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_VS_DATA_A + (i)
> * 4)
> +
> +#define _HSW_VIDEO_DIP_SPD_DATA_A	0x602A0
> +#define _HSW_VIDEO_DIP_SPD_DATA_B	0x612A0
> +#define HSW_TVIDEO_DIP_SPD_DATA(dev_priv, trans, i)
> 	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_SPD_DATA_A +
> (i) * 4)
> +
> +#define _HSW_VIDEO_DIP_GMP_DATA_A	0x602E0
> +#define _HSW_VIDEO_DIP_GMP_DATA_B	0x612E0
> +#define HSW_TVIDEO_DIP_GMP_DATA(dev_priv, trans, i)
> 	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_GMP_DATA_A +
> (i) * 4)
> +
> +#define _HSW_VIDEO_DIP_VSC_DATA_A	0x60320
> +#define _HSW_VIDEO_DIP_VSC_DATA_B	0x61320
> +#define HSW_TVIDEO_DIP_VSC_DATA(dev_priv, trans, i)
> 	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_VSC_DATA_A +
> (i) * 4)
> +
> +/*ADLP and later: */
> +#define	_ADL_VIDEO_DIP_AS_DATA_A	0x60484
> +#define _ADL_VIDEO_DIP_AS_DATA_B	0x61484
> +#define ADL_TVIDEO_DIP_AS_SDP_DATA(dev_priv, trans, i)
> 	_MMIO_TRANS2(dev_priv, trans,\
> +
> _ADL_VIDEO_DIP_AS_DATA_A + (i) * 4)
> +
> +#define _GLK_VIDEO_DIP_DRM_DATA_A	0x60440
> +#define _GLK_VIDEO_DIP_DRM_DATA_B	0x61440
> +#define GLK_TVIDEO_DIP_DRM_DATA(dev_priv, trans, i)
> 	_MMIO_TRANS2(dev_priv, trans, _GLK_VIDEO_DIP_DRM_DATA_A +
> (i) * 4)
> +
> +#define _HSW_VIDEO_DIP_GCP_A		0x60210
> +#define _HSW_VIDEO_DIP_GCP_B		0x61210
> +#define HSW_TVIDEO_DIP_GCP(dev_priv, trans)
> 	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_GCP_A)
> +
> +#define _ICL_VIDEO_DIP_PPS_DATA_A	0x60350
> +#define _ICL_VIDEO_DIP_PPS_DATA_B	0x61350
> +#define ICL_VIDEO_DIP_PPS_DATA(dev_priv, trans, i)
> 	_MMIO_TRANS2(dev_priv, trans, _ICL_VIDEO_DIP_PPS_DATA_A + (i) *
> 4)
> +
> +#define _PCH_TRANSACONF              0xf0008
> +#define _PCH_TRANSBCONF              0xf1008
> +#define PCH_TRANSCONF(pipe)	_MMIO_PIPE(pipe,
> _PCH_TRANSACONF, _PCH_TRANSBCONF)
> +#define LPT_TRANSCONF		PCH_TRANSCONF(PIPE_A) /* lpt has
> only one transcoder */
> +#define  TRANS_ENABLE			REG_BIT(31)
> +#define  TRANS_STATE_ENABLE		REG_BIT(30)
> +#define  TRANS_FRAME_START_DELAY_MASK	REG_GENMASK(28, 27) /* ibx
> */
> +#define  TRANS_FRAME_START_DELAY(x)
> 	REG_FIELD_PREP(TRANS_FRAME_START_DELAY_MASK, (x)) /* ibx: 0-3
> */
> +#define  TRANS_INTERLACE_MASK		REG_GENMASK(23, 21)
> +#define  TRANS_INTERLACE_PROGRESSIVE
> 	REG_FIELD_PREP(TRANS_INTERLACE_MASK, 0)
> +#define  TRANS_INTERLACE_LEGACY_VSYNC_IBX
> 	REG_FIELD_PREP(TRANS_INTERLACE_MASK, 2) /* ibx */
> +#define  TRANS_INTERLACE_INTERLACED
> 	REG_FIELD_PREP(TRANS_INTERLACE_MASK, 3)
> +#define  TRANS_BPC_MASK			REG_GENMASK(7, 5) /* ibx */
> +#define  TRANS_BPC_8
> 	REG_FIELD_PREP(TRANS_BPC_MASK, 0)
> +#define  TRANS_BPC_10
> 	REG_FIELD_PREP(TRANS_BPC_MASK, 1)
> +#define  TRANS_BPC_6
> 	REG_FIELD_PREP(TRANS_BPC_MASK, 2)
> +#define  TRANS_BPC_12
> 	REG_FIELD_PREP(TRANS_BPC_MASK, 3)
> +
> +#define PCH_DP_B		_MMIO(0xe4100)
> +#define PCH_DP_C		_MMIO(0xe4200)
> +#define PCH_DP_D		_MMIO(0xe4300)
> +
> +/* CPT */
> +#define _TRANS_DP_CTL_A		0xe0300
> +#define _TRANS_DP_CTL_B		0xe1300
> +#define _TRANS_DP_CTL_C		0xe2300
> +#define TRANS_DP_CTL(pipe)	_MMIO_PIPE(pipe, _TRANS_DP_CTL_A,
> _TRANS_DP_CTL_B)
> +#define  TRANS_DP_OUTPUT_ENABLE		REG_BIT(31)
> +#define  TRANS_DP_PORT_SEL_MASK		REG_GENMASK(30, 29)
> +#define  TRANS_DP_PORT_SEL_NONE
> 	REG_FIELD_PREP(TRANS_DP_PORT_SEL_MASK, 3)
> +#define  TRANS_DP_PORT_SEL(port)
> 	REG_FIELD_PREP(TRANS_DP_PORT_SEL_MASK, (port) - PORT_B)
> +#define  TRANS_DP_AUDIO_ONLY		REG_BIT(26)
> +#define  TRANS_DP_ENH_FRAMING		REG_BIT(18)
> +#define  TRANS_DP_BPC_MASK		REG_GENMASK(10, 9)
> +#define  TRANS_DP_BPC_8
> 	REG_FIELD_PREP(TRANS_DP_BPC_MASK, 0)
> +#define  TRANS_DP_BPC_10
> 	REG_FIELD_PREP(TRANS_DP_BPC_MASK, 1)
> +#define  TRANS_DP_BPC_6
> 	REG_FIELD_PREP(TRANS_DP_BPC_MASK, 2)
> +#define  TRANS_DP_BPC_12
> 	REG_FIELD_PREP(TRANS_DP_BPC_MASK, 3)
> +#define  TRANS_DP_VSYNC_ACTIVE_HIGH	REG_BIT(4)
> +#define  TRANS_DP_HSYNC_ACTIVE_HIGH	REG_BIT(3)
> +
> +#define _TRANS_DP2_CTL_A			0x600a0
> +#define _TRANS_DP2_CTL_B			0x610a0
> +#define _TRANS_DP2_CTL_C			0x620a0
> +#define _TRANS_DP2_CTL_D			0x630a0
> +#define TRANS_DP2_CTL(trans)			_MMIO_TRANS(trans,
> _TRANS_DP2_CTL_A, _TRANS_DP2_CTL_B)
> +#define  TRANS_DP2_128B132B_CHANNEL_CODING	REG_BIT(31)
> +#define  TRANS_DP2_PANEL_REPLAY_ENABLE		REG_BIT(30)
> +#define  TRANS_DP2_DEBUG_ENABLE			REG_BIT(23)
> +
> +#define _TRANS_DP2_VFREQHIGH_A			0x600a4
> +#define _TRANS_DP2_VFREQHIGH_B			0x610a4
> +#define _TRANS_DP2_VFREQHIGH_C			0x620a4
> +#define _TRANS_DP2_VFREQHIGH_D			0x630a4
> +#define TRANS_DP2_VFREQHIGH(trans)		_MMIO_TRANS(trans,
> _TRANS_DP2_VFREQHIGH_A, _TRANS_DP2_VFREQHIGH_B)
> +#define  TRANS_DP2_VFREQ_PIXEL_CLOCK_MASK	REG_GENMASK(31, 8)
> +#define  TRANS_DP2_VFREQ_PIXEL_CLOCK(clk_hz)
> 	REG_FIELD_PREP(TRANS_DP2_VFREQ_PIXEL_CLOCK_MASK, (clk_hz))
> +
> +#define _TRANS_DP2_VFREQLOW_A			0x600a8
> +#define _TRANS_DP2_VFREQLOW_B			0x610a8
> +#define _TRANS_DP2_VFREQLOW_C			0x620a8
> +#define _TRANS_DP2_VFREQLOW_D			0x630a8
> +#define TRANS_DP2_VFREQLOW(trans)		_MMIO_TRANS(trans,
> _TRANS_DP2_VFREQLOW_A, _TRANS_DP2_VFREQLOW_B)
> +
> +#define _DP_MIN_HBLANK_CTL_A			0x600ac
> +#define _DP_MIN_HBLANK_CTL_B			0x610ac
> +#define DP_MIN_HBLANK_CTL(trans)		_MMIO_TRANS(trans,
> _DP_MIN_HBLANK_CTL_A, _DP_MIN_HBLANK_CTL_B)
> +
> +/* SNB eDP training params */
> +/* SNB A-stepping */
> +#define  EDP_LINK_TRAIN_400MV_0DB_SNB_A		(0x38 << 22)
> +#define  EDP_LINK_TRAIN_400MV_6DB_SNB_A		(0x02 << 22)
> +#define  EDP_LINK_TRAIN_600MV_3_5DB_SNB_A	(0x01 << 22)
> +#define  EDP_LINK_TRAIN_800MV_0DB_SNB_A		(0x0 << 22)
> +/* SNB B-stepping */
> +#define  EDP_LINK_TRAIN_400_600MV_0DB_SNB_B	(0x0 << 22)
> +#define  EDP_LINK_TRAIN_400MV_3_5DB_SNB_B	(0x1 << 22)
> +#define  EDP_LINK_TRAIN_400_600MV_6DB_SNB_B	(0x3a << 22)
> +#define  EDP_LINK_TRAIN_600_800MV_3_5DB_SNB_B	(0x39 << 22)
> +#define  EDP_LINK_TRAIN_800_1200MV_0DB_SNB_B	(0x38 << 22)
> +#define  EDP_LINK_TRAIN_VOL_EMP_MASK_SNB	(0x3f << 22)
> +
> +/* IVB */
> +#define EDP_LINK_TRAIN_400MV_0DB_IVB		(0x24 << 22)
> +#define EDP_LINK_TRAIN_400MV_3_5DB_IVB		(0x2a << 22)
> +#define EDP_LINK_TRAIN_400MV_6DB_IVB		(0x2f << 22)
> +#define EDP_LINK_TRAIN_600MV_0DB_IVB		(0x30 << 22)
> +#define EDP_LINK_TRAIN_600MV_3_5DB_IVB		(0x36 << 22)
> +#define EDP_LINK_TRAIN_800MV_0DB_IVB		(0x38 << 22)
> +#define EDP_LINK_TRAIN_800MV_3_5DB_IVB		(0x3e << 22)
> +
> +/* legacy values */
> +#define EDP_LINK_TRAIN_500MV_0DB_IVB		(0x00 << 22)
> +#define EDP_LINK_TRAIN_1000MV_0DB_IVB		(0x20 << 22)
> +#define EDP_LINK_TRAIN_500MV_3_5DB_IVB		(0x02 << 22)
> +#define EDP_LINK_TRAIN_1000MV_3_5DB_IVB		(0x22 << 22)
> +#define EDP_LINK_TRAIN_1000MV_6DB_IVB		(0x23 << 22)
> +
> +#define  EDP_LINK_TRAIN_VOL_EMP_MASK_IVB	(0x3f << 22)
> +
> +#define VLV_CHICKEN_3
> 	_MMIO(VLV_DISPLAY_BASE + 0x7040C)
> +#define  PIXEL_OVERLAP_CNT_MASK			(3 << 30)
> +#define  PIXEL_OVERLAP_CNT_SHIFT		30
> +
> +/*
> + * HSW - ICL power wells
> + *
> + * Platforms have up to 3 power well control register sets, each set
> + * controlling up to 16 power wells via a request/status HW flag tuple:
> + * - main (HSW_PWR_WELL_CTL[1-4])
> + * - AUX  (ICL_PWR_WELL_CTL_AUX[1-4])
> + * - DDI  (ICL_PWR_WELL_CTL_DDI[1-4])
> + * Each control register set consists of up to 4 registers used by different
> + * sources that can request a power well to be enabled:
> + * - BIOS
> (HSW_PWR_WELL_CTL1/ICL_PWR_WELL_CTL_AUX1/ICL_PWR_WELL_CTL_DD
> I1)
> + * - DRIVER
> (HSW_PWR_WELL_CTL2/ICL_PWR_WELL_CTL_AUX2/ICL_PWR_WELL_CTL_DD
> I2)
> + * - KVMR   (HSW_PWR_WELL_CTL3)   (only in the main register set)
> + * - DEBUG
> (HSW_PWR_WELL_CTL4/ICL_PWR_WELL_CTL_AUX4/ICL_PWR_WELL_CTL_DD
> I4)
> + */
> +#define HSW_PWR_WELL_CTL1			_MMIO(0x45400)
> +#define HSW_PWR_WELL_CTL2			_MMIO(0x45404)
> +#define HSW_PWR_WELL_CTL3			_MMIO(0x45408)
> +#define HSW_PWR_WELL_CTL4			_MMIO(0x4540C)
> +#define   HSW_PWR_WELL_CTL_REQ(pw_idx)		(0x2 << ((pw_idx) *
> 2))
> +#define   HSW_PWR_WELL_CTL_STATE(pw_idx)	(0x1 << ((pw_idx) *
> 2))
> +
> +/* HSW/BDW power well */
> +#define   HSW_PW_CTL_IDX_GLOBAL			15
> +
> +/* SKL/BXT/GLK power wells */
> +#define   SKL_PW_CTL_IDX_PW_2			15
> +#define   SKL_PW_CTL_IDX_PW_1			14
> +#define   GLK_PW_CTL_IDX_AUX_C			10
> +#define   GLK_PW_CTL_IDX_AUX_B			9
> +#define   GLK_PW_CTL_IDX_AUX_A			8
> +#define   SKL_PW_CTL_IDX_DDI_D			4
> +#define   SKL_PW_CTL_IDX_DDI_C			3
> +#define   SKL_PW_CTL_IDX_DDI_B			2
> +#define   SKL_PW_CTL_IDX_DDI_A_E		1
> +#define   GLK_PW_CTL_IDX_DDI_A			1
> +#define   SKL_PW_CTL_IDX_MISC_IO		0
> +
> +/* ICL/TGL - power wells */
> +#define   TGL_PW_CTL_IDX_PW_5			4
> +#define   ICL_PW_CTL_IDX_PW_4			3
> +#define   ICL_PW_CTL_IDX_PW_3			2
> +#define   ICL_PW_CTL_IDX_PW_2			1
> +#define   ICL_PW_CTL_IDX_PW_1			0
> +
> +/* XE_LPD - power wells */
> +#define   XELPD_PW_CTL_IDX_PW_D			8
> +#define   XELPD_PW_CTL_IDX_PW_C			7
> +#define   XELPD_PW_CTL_IDX_PW_B			6
> +#define   XELPD_PW_CTL_IDX_PW_A			5
> +
> +#define ICL_PWR_WELL_CTL_AUX1			_MMIO(0x45440)
> +#define ICL_PWR_WELL_CTL_AUX2			_MMIO(0x45444)
> +#define ICL_PWR_WELL_CTL_AUX4			_MMIO(0x4544C)
> +#define   TGL_PW_CTL_IDX_AUX_TBT6		14
> +#define   TGL_PW_CTL_IDX_AUX_TBT5		13
> +#define   TGL_PW_CTL_IDX_AUX_TBT4		12
> +#define   ICL_PW_CTL_IDX_AUX_TBT4		11
> +#define   TGL_PW_CTL_IDX_AUX_TBT3		11
> +#define   ICL_PW_CTL_IDX_AUX_TBT3		10
> +#define   TGL_PW_CTL_IDX_AUX_TBT2		10
> +#define   ICL_PW_CTL_IDX_AUX_TBT2		9
> +#define   TGL_PW_CTL_IDX_AUX_TBT1		9
> +#define   ICL_PW_CTL_IDX_AUX_TBT1		8
> +#define   TGL_PW_CTL_IDX_AUX_TC6		8
> +#define   XELPD_PW_CTL_IDX_AUX_E			8
> +#define   TGL_PW_CTL_IDX_AUX_TC5		7
> +#define   XELPD_PW_CTL_IDX_AUX_D			7
> +#define   TGL_PW_CTL_IDX_AUX_TC4		6
> +#define   ICL_PW_CTL_IDX_AUX_F			5
> +#define   TGL_PW_CTL_IDX_AUX_TC3		5
> +#define   ICL_PW_CTL_IDX_AUX_E			4
> +#define   TGL_PW_CTL_IDX_AUX_TC2		4
> +#define   ICL_PW_CTL_IDX_AUX_D			3
> +#define   TGL_PW_CTL_IDX_AUX_TC1		3
> +#define   ICL_PW_CTL_IDX_AUX_C			2
> +#define   ICL_PW_CTL_IDX_AUX_B			1
> +#define   ICL_PW_CTL_IDX_AUX_A			0
> +
> +#define ICL_PWR_WELL_CTL_DDI1			_MMIO(0x45450)
> +#define ICL_PWR_WELL_CTL_DDI2			_MMIO(0x45454)
> +#define ICL_PWR_WELL_CTL_DDI4			_MMIO(0x4545C)
> +#define   XELPD_PW_CTL_IDX_DDI_E			8
> +#define   TGL_PW_CTL_IDX_DDI_TC6		8
> +#define   XELPD_PW_CTL_IDX_DDI_D			7
> +#define   TGL_PW_CTL_IDX_DDI_TC5		7
> +#define   TGL_PW_CTL_IDX_DDI_TC4		6
> +#define   ICL_PW_CTL_IDX_DDI_F			5
> +#define   TGL_PW_CTL_IDX_DDI_TC3		5
> +#define   ICL_PW_CTL_IDX_DDI_E			4
> +#define   TGL_PW_CTL_IDX_DDI_TC2		4
> +#define   ICL_PW_CTL_IDX_DDI_D			3
> +#define   TGL_PW_CTL_IDX_DDI_TC1		3
> +#define   ICL_PW_CTL_IDX_DDI_C			2
> +#define   ICL_PW_CTL_IDX_DDI_B			1
> +#define   ICL_PW_CTL_IDX_DDI_A			0
> +
> +#define SKL_FUSE_STATUS				_MMIO(0x42000)
> +#define  SKL_FUSE_DOWNLOAD_STATUS		(1 << 31)
> +/*
> + * PG0 is HW controlled, so doesn't have a corresponding power well
> control knob
> + * SKL_DISP_PW1_IDX..SKL_DISP_PW2_IDX -> PG1..PG2
> + */
> +#define  SKL_PW_CTL_IDX_TO_PG(pw_idx)		\
> +	((pw_idx) - SKL_PW_CTL_IDX_PW_1 + SKL_PG1)
> +/*
> + * PG0 is HW controlled, so doesn't have a corresponding power well
> control knob
> + * ICL_DISP_PW1_IDX..ICL_DISP_PW4_IDX -> PG1..PG4
> + */
> +#define  ICL_PW_CTL_IDX_TO_PG(pw_idx)		\
> +	((pw_idx) - ICL_PW_CTL_IDX_PW_1 + SKL_PG1)
> +#define  SKL_FUSE_PG_DIST_STATUS(pg)		(1 << (27 - (pg)))
> +
> +/* Per-pipe DDI Function Control */
> +#define _TRANS_DDI_FUNC_CTL_A		0x60400
> +#define _TRANS_DDI_FUNC_CTL_B		0x61400
> +#define _TRANS_DDI_FUNC_CTL_C		0x62400
> +#define _TRANS_DDI_FUNC_CTL_D		0x63400
> +#define _TRANS_DDI_FUNC_CTL_EDP		0x6F400
> +#define _TRANS_DDI_FUNC_CTL_DSI0	0x6b400
> +#define _TRANS_DDI_FUNC_CTL_DSI1	0x6bc00
> +#define TRANS_DDI_FUNC_CTL(dev_priv, tran) _MMIO_TRANS2(dev_priv,
> tran, _TRANS_DDI_FUNC_CTL_A)
> +
> +#define  TRANS_DDI_FUNC_ENABLE		(1 << 31)
> +/* Those bits are ignored by pipe EDP since it can only connect to DDI A */
> +#define  TRANS_DDI_PORT_SHIFT		28
> +#define  TGL_TRANS_DDI_PORT_SHIFT	27
> +#define  TRANS_DDI_PORT_MASK		(7 <<
> TRANS_DDI_PORT_SHIFT)
> +#define  TGL_TRANS_DDI_PORT_MASK	(0xf <<
> TGL_TRANS_DDI_PORT_SHIFT)
> +#define  TRANS_DDI_SELECT_PORT(x)	((x) << TRANS_DDI_PORT_SHIFT)
> +#define  TGL_TRANS_DDI_SELECT_PORT(x)	(((x) + 1) <<
> TGL_TRANS_DDI_PORT_SHIFT)
> +#define  TRANS_DDI_MODE_SELECT_MASK	(7 << 24)
> +#define  TRANS_DDI_MODE_SELECT_HDMI	(0 << 24)
> +#define  TRANS_DDI_MODE_SELECT_DVI	(1 << 24)
> +#define  TRANS_DDI_MODE_SELECT_DP_SST	(2 << 24)
> +#define  TRANS_DDI_MODE_SELECT_DP_MST	(3 << 24)
> +#define  TRANS_DDI_MODE_SELECT_FDI_OR_128B132B	(4 << 24)
> +#define  TRANS_DDI_BPC_MASK		(7 << 20)
> +#define  TRANS_DDI_BPC_8		(0 << 20)
> +#define  TRANS_DDI_BPC_10		(1 << 20)
> +#define  TRANS_DDI_BPC_6		(2 << 20)
> +#define  TRANS_DDI_BPC_12		(3 << 20)
> +#define  TRANS_DDI_PORT_SYNC_MASTER_SELECT_MASK
> 	REG_GENMASK(19, 18)
> +#define  TRANS_DDI_PORT_SYNC_MASTER_SELECT(x)
> 	REG_FIELD_PREP(TRANS_DDI_PORT_SYNC_MASTER_SELECT_MASK,
> (x))
> +#define  TRANS_DDI_PVSYNC		(1 << 17)
> +#define  TRANS_DDI_PHSYNC		(1 << 16)
> +#define  TRANS_DDI_PORT_SYNC_ENABLE	REG_BIT(15)
> +#define  XE3_TRANS_DDI_HDCP_LINE_REKEY_DISABLE	REG_BIT(15)
> +#define  TRANS_DDI_EDP_INPUT_MASK	(7 << 12)
> +#define  TRANS_DDI_EDP_INPUT_A_ON	(0 << 12)
> +#define  TRANS_DDI_EDP_INPUT_A_ONOFF	(4 << 12)
> +#define  TRANS_DDI_EDP_INPUT_B_ONOFF	(5 << 12)
> +#define  TRANS_DDI_EDP_INPUT_C_ONOFF	(6 << 12)
> +#define  TRANS_DDI_EDP_INPUT_D_ONOFF	(7 << 12)
> +#define  TRANS_DDI_HDCP_LINE_REKEY_DISABLE	REG_BIT(12)
> +#define  TRANS_DDI_MST_TRANSPORT_SELECT_MASK
> 	REG_GENMASK(11, 10)
> +#define  TRANS_DDI_MST_TRANSPORT_SELECT(trans)	\
> +	REG_FIELD_PREP(TRANS_DDI_MST_TRANSPORT_SELECT_MASK,
> trans)
> +#define  TRANS_DDI_HDCP_SIGNALLING	(1 << 9)
> +#define  TRANS_DDI_DP_VC_PAYLOAD_ALLOC	(1 << 8)
> +#define  TRANS_DDI_HDMI_SCRAMBLER_CTS_ENABLE (1 << 7)
> +#define  TRANS_DDI_HDMI_SCRAMBLER_RESET_FREQ (1 << 6)
> +#define  TRANS_DDI_HDCP_SELECT		REG_BIT(5)
> +#define  TRANS_DDI_BFI_ENABLE		(1 << 4)
> +#define  TRANS_DDI_HIGH_TMDS_CHAR_RATE	(1 << 4)
> +#define  TRANS_DDI_PORT_WIDTH_MASK	REG_GENMASK(3, 1)
> +#define  TRANS_DDI_PORT_WIDTH(width)
> 	REG_FIELD_PREP(TRANS_DDI_PORT_WIDTH_MASK, (width) - 1)
> +#define  TRANS_DDI_HDMI_SCRAMBLING	(1 << 0)
> +#define  TRANS_DDI_HDMI_SCRAMBLING_MASK
> (TRANS_DDI_HDMI_SCRAMBLER_CTS_ENABLE \
> +					|
> TRANS_DDI_HDMI_SCRAMBLER_RESET_FREQ \
> +					| TRANS_DDI_HDMI_SCRAMBLING)
> +
> +#define _TRANS_DDI_FUNC_CTL2_A		0x60404
> +#define _TRANS_DDI_FUNC_CTL2_B		0x61404
> +#define _TRANS_DDI_FUNC_CTL2_C		0x62404
> +#define _TRANS_DDI_FUNC_CTL2_EDP	0x6f404
> +#define _TRANS_DDI_FUNC_CTL2_DSI0	0x6b404
> +#define _TRANS_DDI_FUNC_CTL2_DSI1	0x6bc04
> +#define TRANS_DDI_FUNC_CTL2(dev_priv, tran)
> 	_MMIO_TRANS2(dev_priv, tran, _TRANS_DDI_FUNC_CTL2_A)
> +#define  PORT_SYNC_MODE_ENABLE			REG_BIT(4)
> +#define  CMTG_SECONDARY_MODE			REG_BIT(3)
> +#define  PORT_SYNC_MODE_MASTER_SELECT_MASK	REG_GENMASK(2, 0)
> +#define  PORT_SYNC_MODE_MASTER_SELECT(x)
> 	REG_FIELD_PREP(PORT_SYNC_MODE_MASTER_SELECT_MASK, (x))
> +
> +#define TRANS_CMTG_CHICKEN		_MMIO(0x6fa90)
> +#define  DISABLE_DPT_CLK_GATING		REG_BIT(1)
> +
> +/* DisplayPort Transport Control */
> +#define _DP_TP_CTL_A			0x64040
> +#define _DP_TP_CTL_B			0x64140
> +#define _TGL_DP_TP_CTL_A		0x60540
> +#define DP_TP_CTL(port) _MMIO_PORT(port, _DP_TP_CTL_A,
> _DP_TP_CTL_B)
> +#define TGL_DP_TP_CTL(dev_priv, tran) _MMIO_TRANS2(dev_priv, (tran),
> _TGL_DP_TP_CTL_A)
> +#define   DP_TP_CTL_ENABLE			REG_BIT(31)
> +#define   DP_TP_CTL_FEC_ENABLE			REG_BIT(30)
> +#define   DP_TP_CTL_MODE_MASK			REG_BIT(27)
> +#define   DP_TP_CTL_MODE_SST
> 	REG_FIELD_PREP(DP_TP_CTL_MODE_MASK, 0)
> +#define   DP_TP_CTL_MODE_MST
> 	REG_FIELD_PREP(DP_TP_CTL_MODE_MASK, 1)
> +#define   DP_TP_CTL_FORCE_ACT			REG_BIT(25)
> +#define   DP_TP_CTL_TRAIN_PAT4_SEL_MASK		REG_GENMASK(20,
> 19)
> +#define   DP_TP_CTL_TRAIN_PAT4_SEL_TP4A
> 	REG_FIELD_PREP(DP_TP_CTL_TRAIN_PAT4_SEL_MASK, 0)
> +#define   DP_TP_CTL_TRAIN_PAT4_SEL_TP4B
> 	REG_FIELD_PREP(DP_TP_CTL_TRAIN_PAT4_SEL_MASK, 1)
> +#define   DP_TP_CTL_TRAIN_PAT4_SEL_TP4C
> 	REG_FIELD_PREP(DP_TP_CTL_TRAIN_PAT4_SEL_MASK, 2)
> +#define   DP_TP_CTL_ENHANCED_FRAME_ENABLE	REG_BIT(18)
> +#define   DP_TP_CTL_FDI_AUTOTRAIN		REG_BIT(15)
> +#define   DP_TP_CTL_LINK_TRAIN_MASK		REG_GENMASK(10, 8)
> +#define   DP_TP_CTL_LINK_TRAIN_PAT1
> 	REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 0)
> +#define   DP_TP_CTL_LINK_TRAIN_PAT2
> 	REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 1)
> +#define   DP_TP_CTL_LINK_TRAIN_PAT3
> 	REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 4)
> +#define   DP_TP_CTL_LINK_TRAIN_PAT4
> 	REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 5)
> +#define   DP_TP_CTL_LINK_TRAIN_IDLE
> 	REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 2)
> +#define   DP_TP_CTL_LINK_TRAIN_NORMAL
> 	REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 3)
> +#define   DP_TP_CTL_SCRAMBLE_DISABLE		REG_BIT(7)
> +
> +/* DisplayPort Transport Status */
> +#define _DP_TP_STATUS_A			0x64044
> +#define _DP_TP_STATUS_B			0x64144
> +#define _TGL_DP_TP_STATUS_A		0x60544
> +#define DP_TP_STATUS(port) _MMIO_PORT(port, _DP_TP_STATUS_A,
> _DP_TP_STATUS_B)
> +#define TGL_DP_TP_STATUS(dev_priv, tran) _MMIO_TRANS2(dev_priv,
> (tran), _TGL_DP_TP_STATUS_A)
> +#define   DP_TP_STATUS_FEC_ENABLE_LIVE		REG_BIT(28)
> +#define   DP_TP_STATUS_IDLE_DONE		REG_BIT(25)
> +#define   DP_TP_STATUS_ACT_SENT			REG_BIT(24)
> +#define   DP_TP_STATUS_MODE_STATUS_MST		REG_BIT(23)
> +#define   DP_TP_STATUS_STREAMS_ENABLED_MASK	REG_GENMASK(18,
> 16) /* 17:16 on hsw but bit 18 mbz */
> +#define   DP_TP_STATUS_AUTOTRAIN_DONE		REG_BIT(12)
> +#define   DP_TP_STATUS_PAYLOAD_MAPPING_VC2_MASK REG_GENMASK(9,
> 8)
> +#define   DP_TP_STATUS_PAYLOAD_MAPPING_VC1_MASK
> 	REG_GENMASK(5, 4)
> +#define   DP_TP_STATUS_PAYLOAD_MAPPING_VC0_MASK
> 	REG_GENMASK(1, 0)
> +
> +/* DDI Buffer Control */
> +#define _DDI_BUF_CTL_A				0x64000
> +#define _DDI_BUF_CTL_B				0x64100
> +/* Known as DDI_CTL_DE in MTL+ */
> +#define DDI_BUF_CTL(port) _MMIO_PORT(port, _DDI_BUF_CTL_A,
> _DDI_BUF_CTL_B)
> +#define  DDI_BUF_CTL_ENABLE			(1 << 31)
> +#define  XE2LPD_DDI_BUF_D2D_LINK_ENABLE		REG_BIT(29)
> +#define  XE2LPD_DDI_BUF_D2D_LINK_STATE		REG_BIT(28)
> +#define  DDI_BUF_TRANS_SELECT(n)	((n) << 24)
> +#define  DDI_BUF_EMP_MASK			(0xf << 24)
> +#define  DDI_BUF_PHY_LINK_RATE(r)		((r) << 20)
> +#define  DDI_BUF_PORT_DATA_MASK			REG_GENMASK(19,
> 18)
> +#define  DDI_BUF_PORT_DATA_10BIT
> 	REG_FIELD_PREP(DDI_BUF_PORT_DATA_MASK, 0)
> +#define  DDI_BUF_PORT_DATA_20BIT
> 	REG_FIELD_PREP(DDI_BUF_PORT_DATA_MASK, 1)
> +#define  DDI_BUF_PORT_DATA_40BIT
> 	REG_FIELD_PREP(DDI_BUF_PORT_DATA_MASK, 2)
> +#define  DDI_BUF_PORT_REVERSAL			(1 << 16)
> +#define  DDI_BUF_IS_IDLE			(1 << 7)
> +#define  DDI_BUF_CTL_TC_PHY_OWNERSHIP		REG_BIT(6)
> +#define  DDI_A_4_LANES				(1 << 4)
> +#define  DDI_PORT_WIDTH(width)			(((width) - 1) << 1)
> +#define  DDI_PORT_WIDTH_MASK			(7 << 1)
> +#define  DDI_PORT_WIDTH_SHIFT			1
> +#define  DDI_INIT_DISPLAY_DETECTED		(1 << 0)
> +
> +/* DDI Buffer Translations */
> +#define _DDI_BUF_TRANS_A		0x64E00
> +#define _DDI_BUF_TRANS_B		0x64E60
> +#define DDI_BUF_TRANS_LO(port, i)	_MMIO(_PORT(port,
> _DDI_BUF_TRANS_A, _DDI_BUF_TRANS_B) + (i) * 8)
> +#define  DDI_BUF_BALANCE_LEG_ENABLE	(1 << 31)
> +#define DDI_BUF_TRANS_HI(port, i)	_MMIO(_PORT(port,
> _DDI_BUF_TRANS_A, _DDI_BUF_TRANS_B) + (i) * 8 + 4)
> +
> +/* DDI DP Compliance Control */
> +#define _DDI_DP_COMP_CTL_A			0x605F0
> +#define _DDI_DP_COMP_CTL_B			0x615F0
> +#define DDI_DP_COMP_CTL(pipe)			_MMIO_PIPE(pipe,
> _DDI_DP_COMP_CTL_A, _DDI_DP_COMP_CTL_B)
> +#define   DDI_DP_COMP_CTL_ENABLE		(1 << 31)
> +#define   DDI_DP_COMP_CTL_D10_2			(0 << 28)
> +#define   DDI_DP_COMP_CTL_SCRAMBLED_0		(1 << 28)
> +#define   DDI_DP_COMP_CTL_PRBS7			(2 << 28)
> +#define   DDI_DP_COMP_CTL_CUSTOM80		(3 << 28)
> +#define   DDI_DP_COMP_CTL_HBR2			(4 << 28)
> +#define   DDI_DP_COMP_CTL_SCRAMBLED_1		(5 << 28)
> +#define   DDI_DP_COMP_CTL_HBR2_RESET		(0xFC << 0)
> +
> +/* DDI DP Compliance Pattern */
> +#define _DDI_DP_COMP_PAT_A			0x605F4
> +#define _DDI_DP_COMP_PAT_B			0x615F4
> +#define DDI_DP_COMP_PAT(pipe, i)		_MMIO(_PIPE(pipe,
> _DDI_DP_COMP_PAT_A, _DDI_DP_COMP_PAT_B) + (i) * 4)
> +
> +/* SBI offsets */
> +#define  SBI_SSCDIVINTPHASE			0x0200
> +#define  SBI_SSCDIVINTPHASE6			0x0600
> +#define   SBI_SSCDIVINTPHASE_DIVSEL_SHIFT	1
> +#define   SBI_SSCDIVINTPHASE_DIVSEL_MASK	(0x7f << 1)
> +#define   SBI_SSCDIVINTPHASE_DIVSEL(x)		((x) << 1)
> +#define   SBI_SSCDIVINTPHASE_INCVAL_SHIFT	8
> +#define   SBI_SSCDIVINTPHASE_INCVAL_MASK	(0x7f << 8)
> +#define   SBI_SSCDIVINTPHASE_INCVAL(x)		((x) << 8)
> +#define   SBI_SSCDIVINTPHASE_DIR(x)		((x) << 15)
> +#define   SBI_SSCDIVINTPHASE_PROPAGATE		(1 << 0)
> +#define  SBI_SSCDITHPHASE			0x0204
> +#define  SBI_SSCCTL				0x020c
> +#define  SBI_SSCCTL6				0x060C
> +#define   SBI_SSCCTL_PATHALT			(1 << 3)
> +#define   SBI_SSCCTL_DISABLE			(1 << 0)
> +#define  SBI_SSCAUXDIV6				0x0610
> +#define   SBI_SSCAUXDIV_FINALDIV2SEL_SHIFT	4
> +#define   SBI_SSCAUXDIV_FINALDIV2SEL_MASK	(1 << 4)
> +#define   SBI_SSCAUXDIV_FINALDIV2SEL(x)		((x) << 4)
> +#define  SBI_DBUFF0				0x2a00
> +#define  SBI_GEN0				0x1f00
> +#define   SBI_GEN0_CFG_BUFFENABLE_DISABLE	(1 << 0)
> +
> +/* LPT PIXCLK_GATE */
> +#define PIXCLK_GATE			_MMIO(0xC6020)
> +#define  PIXCLK_GATE_UNGATE		(1 << 0)
> +#define  PIXCLK_GATE_GATE		(0 << 0)
> +
> +/* SPLL */
> +#define SPLL_CTL			_MMIO(0x46020)
> +#define  SPLL_PLL_ENABLE		(1 << 31)
> +#define  SPLL_REF_BCLK			(0 << 28)
> +#define  SPLL_REF_MUXED_SSC		(1 << 28) /* CPU SSC if fused
> enabled, PCH SSC otherwise */
> +#define  SPLL_REF_NON_SSC_HSW		(2 << 28)
> +#define  SPLL_REF_PCH_SSC_BDW		(2 << 28)
> +#define  SPLL_REF_LCPLL			(3 << 28)
> +#define  SPLL_REF_MASK			(3 << 28)
> +#define  SPLL_FREQ_810MHz		(0 << 26)
> +#define  SPLL_FREQ_1350MHz		(1 << 26)
> +#define  SPLL_FREQ_2700MHz		(2 << 26)
> +#define  SPLL_FREQ_MASK			(3 << 26)
> +
> +/* WRPLL */
> +#define _WRPLL_CTL1			0x46040
> +#define _WRPLL_CTL2			0x46060
> +#define WRPLL_CTL(pll)			_MMIO_PIPE(pll,
> _WRPLL_CTL1, _WRPLL_CTL2)
> +#define  WRPLL_PLL_ENABLE		(1 << 31)
> +#define  WRPLL_REF_BCLK			(0 << 28)
> +#define  WRPLL_REF_PCH_SSC		(1 << 28)
> +#define  WRPLL_REF_MUXED_SSC_BDW	(2 << 28) /* CPU SSC if fused
> enabled, PCH SSC otherwise */
> +#define  WRPLL_REF_SPECIAL_HSW		(2 << 28) /* muxed SSC (ULT),
> non-SSC (non-ULT) */
> +#define  WRPLL_REF_LCPLL		(3 << 28)
> +#define  WRPLL_REF_MASK			(3 << 28)
> +/* WRPLL divider programming */
> +#define  WRPLL_DIVIDER_REFERENCE(x)	((x) << 0)
> +#define  WRPLL_DIVIDER_REF_MASK		(0xff)
> +#define  WRPLL_DIVIDER_POST(x)		((x) << 8)
> +#define  WRPLL_DIVIDER_POST_MASK	(0x3f << 8)
> +#define  WRPLL_DIVIDER_POST_SHIFT	8
> +#define  WRPLL_DIVIDER_FEEDBACK(x)	((x) << 16)
> +#define  WRPLL_DIVIDER_FB_SHIFT		16
> +#define  WRPLL_DIVIDER_FB_MASK		(0xff << 16)
> +
> +/* Port clock selection */
> +#define _PORT_CLK_SEL_A			0x46100
> +#define _PORT_CLK_SEL_B			0x46104
> +#define PORT_CLK_SEL(port) _MMIO_PORT(port, _PORT_CLK_SEL_A,
> _PORT_CLK_SEL_B)
> +#define  PORT_CLK_SEL_MASK		REG_GENMASK(31, 29)
> +#define  PORT_CLK_SEL_LCPLL_2700
> 	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 0)
> +#define  PORT_CLK_SEL_LCPLL_1350
> 	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 1)
> +#define  PORT_CLK_SEL_LCPLL_810
> 	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 2)
> +#define  PORT_CLK_SEL_SPLL
> 	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 3)
> +#define  PORT_CLK_SEL_WRPLL(pll)
> 	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 4 + (pll))
> +#define  PORT_CLK_SEL_WRPLL1
> 	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 4)
> +#define  PORT_CLK_SEL_WRPLL2
> 	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 5)
> +#define  PORT_CLK_SEL_NONE
> 	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 7)
> +
> +/* On ICL+ this is the same as PORT_CLK_SEL, but all bits change. */
> +#define DDI_CLK_SEL(port)		PORT_CLK_SEL(port)
> +#define  DDI_CLK_SEL_MASK		REG_GENMASK(31, 28)
> +#define  DDI_CLK_SEL_NONE
> 	REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0x0)
> +#define  DDI_CLK_SEL_MG
> 	REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0x8)
> +#define  DDI_CLK_SEL_TBT_162
> 	REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xC)
> +#define  DDI_CLK_SEL_TBT_270
> 	REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xD)
> +#define  DDI_CLK_SEL_TBT_540
> 	REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xE)
> +#define  DDI_CLK_SEL_TBT_810
> 	REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xF)
> +
> +/* Transcoder clock selection */
> +#define _TRANS_CLK_SEL_A		0x46140
> +#define _TRANS_CLK_SEL_B		0x46144
> +#define TRANS_CLK_SEL(tran) _MMIO_TRANS(tran, _TRANS_CLK_SEL_A,
> _TRANS_CLK_SEL_B)
> +/* For each transcoder, we need to select the corresponding port clock */
> +#define  TRANS_CLK_SEL_DISABLED		(0x0 << 29)
> +#define  TRANS_CLK_SEL_PORT(x)		(((x) + 1) << 29)
> +#define  TGL_TRANS_CLK_SEL_DISABLED	(0x0 << 28)
> +#define  TGL_TRANS_CLK_SEL_PORT(x)	(((x) + 1) << 28)
> +
> +#define CDCLK_FREQ			_MMIO(0x46200)
> +
> +#define _TRANSA_MSA_MISC		0x60410
> +#define _TRANSB_MSA_MISC		0x61410
> +#define _TRANSC_MSA_MISC		0x62410
> +#define _TRANS_EDP_MSA_MISC		0x6f410
> +#define TRANS_MSA_MISC(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran,
> _TRANSA_MSA_MISC)
> +/* See DP_MSA_MISC_* for the bit definitions */
> +
> +#define _TRANS_A_SET_CONTEXT_LATENCY		0x6007C
> +#define _TRANS_B_SET_CONTEXT_LATENCY		0x6107C
> +#define _TRANS_C_SET_CONTEXT_LATENCY		0x6207C
> +#define _TRANS_D_SET_CONTEXT_LATENCY		0x6307C
> +#define TRANS_SET_CONTEXT_LATENCY(dev_priv, tran)
> 	_MMIO_TRANS2(dev_priv, tran, _TRANS_A_SET_CONTEXT_LATENCY)
> +#define  TRANS_SET_CONTEXT_LATENCY_MASK
> 	REG_GENMASK(15, 0)
> +#define  TRANS_SET_CONTEXT_LATENCY_VALUE(x)
> 	REG_FIELD_PREP(TRANS_SET_CONTEXT_LATENCY_MASK, (x))
> +
> +/* LCPLL Control */
> +#define LCPLL_CTL			_MMIO(0x130040)
> +#define  LCPLL_PLL_DISABLE		(1 << 31)
> +#define  LCPLL_PLL_LOCK			(1 << 30)
> +#define  LCPLL_REF_NON_SSC		(0 << 28)
> +#define  LCPLL_REF_BCLK			(2 << 28)
> +#define  LCPLL_REF_PCH_SSC		(3 << 28)
> +#define  LCPLL_REF_MASK			(3 << 28)
> +#define  LCPLL_CLK_FREQ_MASK		(3 << 26)
> +#define  LCPLL_CLK_FREQ_450		(0 << 26)
> +#define  LCPLL_CLK_FREQ_54O_BDW		(1 << 26)
> +#define  LCPLL_CLK_FREQ_337_5_BDW	(2 << 26)
> +#define  LCPLL_CLK_FREQ_675_BDW		(3 << 26)
> +#define  LCPLL_CD_CLOCK_DISABLE		(1 << 25)
> +#define  LCPLL_ROOT_CD_CLOCK_DISABLE	(1 << 24)
> +#define  LCPLL_CD2X_CLOCK_DISABLE	(1 << 23)
> +#define  LCPLL_POWER_DOWN_ALLOW		(1 << 22)
> +#define  LCPLL_CD_SOURCE_FCLK		(1 << 21)
> +#define  LCPLL_CD_SOURCE_FCLK_DONE	(1 << 19)
> +
> +/*
> + * SKL Clocks
> + */
> +/* CDCLK_CTL */
> +#define CDCLK_CTL			_MMIO(0x46000)
> +#define  CDCLK_FREQ_SEL_MASK		REG_GENMASK(27, 26)
> +#define  CDCLK_FREQ_450_432
> 	REG_FIELD_PREP(CDCLK_FREQ_SEL_MASK, 0)
> +#define  CDCLK_FREQ_540
> 	REG_FIELD_PREP(CDCLK_FREQ_SEL_MASK, 1)
> +#define  CDCLK_FREQ_337_308
> 	REG_FIELD_PREP(CDCLK_FREQ_SEL_MASK, 2)
> +#define  CDCLK_FREQ_675_617
> 	REG_FIELD_PREP(CDCLK_FREQ_SEL_MASK, 3)
> +#define  MDCLK_SOURCE_SEL_MASK		REG_GENMASK(25, 25)
> +#define  MDCLK_SOURCE_SEL_CD2XCLK
> 	REG_FIELD_PREP(MDCLK_SOURCE_SEL_MASK, 0)
> +#define  MDCLK_SOURCE_SEL_CDCLK_PLL
> 	REG_FIELD_PREP(MDCLK_SOURCE_SEL_MASK, 1)
> +#define  BXT_CDCLK_CD2X_DIV_SEL_MASK	REG_GENMASK(23, 22)
> +#define  BXT_CDCLK_CD2X_DIV_SEL_1
> 	REG_FIELD_PREP(BXT_CDCLK_CD2X_DIV_SEL_MASK, 0)
> +#define  BXT_CDCLK_CD2X_DIV_SEL_1_5
> 	REG_FIELD_PREP(BXT_CDCLK_CD2X_DIV_SEL_MASK, 1)
> +#define  BXT_CDCLK_CD2X_DIV_SEL_2
> 	REG_FIELD_PREP(BXT_CDCLK_CD2X_DIV_SEL_MASK, 2)
> +#define  BXT_CDCLK_CD2X_DIV_SEL_4
> 	REG_FIELD_PREP(BXT_CDCLK_CD2X_DIV_SEL_MASK, 3)
> +#define  BXT_CDCLK_CD2X_PIPE(pipe)	((pipe) << 20)
> +#define  CDCLK_DIVMUX_CD_OVERRIDE	(1 << 19)
> +#define  BXT_CDCLK_CD2X_PIPE_NONE	BXT_CDCLK_CD2X_PIPE(3)
> +#define  ICL_CDCLK_CD2X_PIPE(pipe)	(_PICK(pipe, 0, 2, 6) << 19)
> +#define  ICL_CDCLK_CD2X_PIPE_NONE	(7 << 19)
> +#define  TGL_CDCLK_CD2X_PIPE(pipe)	BXT_CDCLK_CD2X_PIPE(pipe)
> +#define  TGL_CDCLK_CD2X_PIPE_NONE	ICL_CDCLK_CD2X_PIPE_NONE
> +#define  BXT_CDCLK_SSA_PRECHARGE_ENABLE	(1 << 16)
> +#define  CDCLK_FREQ_DECIMAL_MASK	(0x7ff)
> +
> +/* CDCLK_SQUASH_CTL */
> +#define CDCLK_SQUASH_CTL		_MMIO(0x46008)
> +#define  CDCLK_SQUASH_ENABLE		REG_BIT(31)
> +#define  CDCLK_SQUASH_WINDOW_SIZE_MASK	REG_GENMASK(27,
> 24)
> +#define  CDCLK_SQUASH_WINDOW_SIZE(x)
> 	REG_FIELD_PREP(CDCLK_SQUASH_WINDOW_SIZE_MASK, (x))
> +#define  CDCLK_SQUASH_WAVEFORM_MASK	REG_GENMASK(15, 0)
> +#define  CDCLK_SQUASH_WAVEFORM(x)
> 	REG_FIELD_PREP(CDCLK_SQUASH_WAVEFORM_MASK, (x))
> +
> +/* LCPLL_CTL */
> +#define LCPLL1_CTL		_MMIO(0x46010)
> +#define LCPLL2_CTL		_MMIO(0x46014)
> +#define  LCPLL_PLL_ENABLE	(1 << 31)
> +
> +/* DPLL control1 */
> +#define DPLL_CTRL1		_MMIO(0x6C058)
> +#define  DPLL_CTRL1_HDMI_MODE(id)		(1 << ((id) * 6 + 5))
> +#define  DPLL_CTRL1_SSC(id)			(1 << ((id) * 6 + 4))
> +#define  DPLL_CTRL1_LINK_RATE_MASK(id)		(7 << ((id) * 6 + 1))
> +#define  DPLL_CTRL1_LINK_RATE_SHIFT(id)		((id) * 6 + 1)
> +#define  DPLL_CTRL1_LINK_RATE(linkrate, id)	((linkrate) << ((id) * 6 + 1))
> +#define  DPLL_CTRL1_OVERRIDE(id)		(1 << ((id) * 6))
> +#define  DPLL_CTRL1_LINK_RATE_2700		0
> +#define  DPLL_CTRL1_LINK_RATE_1350		1
> +#define  DPLL_CTRL1_LINK_RATE_810		2
> +#define  DPLL_CTRL1_LINK_RATE_1620		3
> +#define  DPLL_CTRL1_LINK_RATE_1080		4
> +#define  DPLL_CTRL1_LINK_RATE_2160		5
> +
> +/* DPLL control2 */
> +#define DPLL_CTRL2				_MMIO(0x6C05C)
> +#define  DPLL_CTRL2_DDI_CLK_OFF(port)		(1 << ((port) + 15))
> +#define  DPLL_CTRL2_DDI_CLK_SEL_MASK(port)	(3 << ((port) * 3 + 1))
> +#define  DPLL_CTRL2_DDI_CLK_SEL_SHIFT(port)    ((port) * 3 + 1)
> +#define  DPLL_CTRL2_DDI_CLK_SEL(clk, port)	((clk) << ((port) * 3 + 1))
> +#define  DPLL_CTRL2_DDI_SEL_OVERRIDE(port)     (1 << ((port) * 3))
> +
> +/* DPLL Status */
> +#define DPLL_STATUS	_MMIO(0x6C060)
> +#define  DPLL_LOCK(id) (1 << ((id) * 8))
> +
> +/* DPLL cfg */
> +#define _DPLL1_CFGCR1	0x6C040
> +#define _DPLL2_CFGCR1	0x6C048
> +#define _DPLL3_CFGCR1	0x6C050
> +#define DPLL_CFGCR1(id)	_MMIO_PIPE((id) - SKL_DPLL1,
> _DPLL1_CFGCR1, _DPLL2_CFGCR1)
> +#define  DPLL_CFGCR1_FREQ_ENABLE	(1 << 31)
> +#define  DPLL_CFGCR1_DCO_FRACTION_MASK	(0x7fff << 9)
> +#define  DPLL_CFGCR1_DCO_FRACTION(x)	((x) << 9)
> +#define  DPLL_CFGCR1_DCO_INTEGER_MASK	(0x1ff)
> +
> +#define _DPLL1_CFGCR2	0x6C044
> +#define _DPLL2_CFGCR2	0x6C04C
> +#define _DPLL3_CFGCR2	0x6C054
> +#define DPLL_CFGCR2(id)	_MMIO_PIPE((id) - SKL_DPLL1,
> _DPLL1_CFGCR2, _DPLL2_CFGCR2)
> +#define  DPLL_CFGCR2_QDIV_RATIO_MASK	(0xff << 8)
> +#define  DPLL_CFGCR2_QDIV_RATIO(x)	((x) << 8)
> +#define  DPLL_CFGCR2_QDIV_MODE(x)	((x) << 7)
> +#define  DPLL_CFGCR2_KDIV_MASK		(3 << 5)
> +#define  DPLL_CFGCR2_KDIV(x)		((x) << 5)
> +#define  DPLL_CFGCR2_KDIV_5 (0 << 5)
> +#define  DPLL_CFGCR2_KDIV_2 (1 << 5)
> +#define  DPLL_CFGCR2_KDIV_3 (2 << 5)
> +#define  DPLL_CFGCR2_KDIV_1 (3 << 5)
> +#define  DPLL_CFGCR2_PDIV_MASK		(7 << 2)
> +#define  DPLL_CFGCR2_PDIV(x)		((x) << 2)
> +#define  DPLL_CFGCR2_PDIV_1 (0 << 2)
> +#define  DPLL_CFGCR2_PDIV_2 (1 << 2)
> +#define  DPLL_CFGCR2_PDIV_3 (2 << 2)
> +#define  DPLL_CFGCR2_PDIV_7 (4 << 2)
> +#define  DPLL_CFGCR2_PDIV_7_INVALID	(5 << 2)
> +#define  DPLL_CFGCR2_CENTRAL_FREQ_MASK	(3)
> +
> +/* ICL Clocks */
> +#define ICL_DPCLKA_CFGCR0			_MMIO(0x164280)
> +#define  ICL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy)	(1 << _PICK(phy, 10,
> 11, 24, 4, 5))
> +#define  RKL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy)	REG_BIT((phy) + 10)
> +#define  ICL_DPCLKA_CFGCR0_TC_CLK_OFF(tc_port)	(1 << ((tc_port) <
> TC_PORT_4 ? \
> +						       (tc_port) + 12 : \
> +						       (tc_port) - TC_PORT_4 +
> 21))
> +#define  ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy)	((phy) * 2)
> +#define  ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK(phy)	(3 <<
> ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
> +#define  ICL_DPCLKA_CFGCR0_DDI_CLK_SEL(pll, phy)	((pll) <<
> ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
> +#define  RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy)	_PICK(phy, 0,
> 2, 4, 27)
> +#define  RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK(phy) \
> +	(3 << RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
> +#define  RKL_DPCLKA_CFGCR0_DDI_CLK_SEL(pll, phy) \
> +	((pll) << RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
> +
> +/*
> + * DG1 Clocks
> + * First registers controls the first A and B, while the second register
> + * controls the phy C and D. The bits on these registers are the
> + * same, but refer to different phys
> + */
> +#define _DG1_DPCLKA_CFGCR0				0x164280
> +#define _DG1_DPCLKA1_CFGCR0				0x16C280
> +#define _DG1_DPCLKA_PHY_IDX(phy)			((phy) % 2)
> +#define _DG1_DPCLKA_PLL_IDX(pll)			((pll) % 2)
> +#define DG1_DPCLKA_CFGCR0(phy)
> 	_MMIO_PHY((phy) / 2, \
> +
> _DG1_DPCLKA_CFGCR0, \
> +
> _DG1_DPCLKA1_CFGCR0)
> +#define   DG1_DPCLKA_CFGCR0_DDI_CLK_OFF(phy)
> 	REG_BIT(_DG1_DPCLKA_PHY_IDX(phy) + 10)
> +#define   DG1_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy)
> 	(_DG1_DPCLKA_PHY_IDX(phy) * 2)
> +#define   DG1_DPCLKA_CFGCR0_DDI_CLK_SEL(pll, phy)
> 	(_DG1_DPCLKA_PLL_IDX(pll) <<
> DG1_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
> +#define   DG1_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK(phy)	(0x3 <<
> DG1_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
> +
> +/* ADLS Clocks */
> +#define _ADLS_DPCLKA_CFGCR0			0x164280
> +#define _ADLS_DPCLKA_CFGCR1			0x1642BC
> +#define ADLS_DPCLKA_CFGCR(phy)			_MMIO_PHY((phy) /
> 3, \
> +
> _ADLS_DPCLKA_CFGCR0, \
> +
> _ADLS_DPCLKA_CFGCR1)
> +#define  ADLS_DPCLKA_CFGCR_DDI_SHIFT(phy)		(((phy) % 3) *
> 2)
> +/* ADLS DPCLKA_CFGCR0 DDI mask */
> +#define  ADLS_DPCLKA_DDII_SEL_MASK
> 	REG_GENMASK(5, 4)
> +#define  ADLS_DPCLKA_DDIB_SEL_MASK
> 	REG_GENMASK(3, 2)
> +#define  ADLS_DPCLKA_DDIA_SEL_MASK
> 	REG_GENMASK(1, 0)
> +/* ADLS DPCLKA_CFGCR1 DDI mask */
> +#define  ADLS_DPCLKA_DDIK_SEL_MASK
> 	REG_GENMASK(3, 2)
> +#define  ADLS_DPCLKA_DDIJ_SEL_MASK
> 	REG_GENMASK(1, 0)
> +#define  ADLS_DPCLKA_CFGCR_DDI_CLK_SEL_MASK(phy)	_PICK((phy), \
> +
> 	ADLS_DPCLKA_DDIA_SEL_MASK, \
> +
> 	ADLS_DPCLKA_DDIB_SEL_MASK, \
> +
> 	ADLS_DPCLKA_DDII_SEL_MASK, \
> +
> 	ADLS_DPCLKA_DDIJ_SEL_MASK, \
> +
> 	ADLS_DPCLKA_DDIK_SEL_MASK)
> +
> +/* ICL PLL */
> +#define _DPLL0_ENABLE		0x46010
> +#define _DPLL1_ENABLE		0x46014
> +#define _ADLS_DPLL2_ENABLE	0x46018
> +#define _ADLS_DPLL3_ENABLE	0x46030
> +#define   PLL_ENABLE		REG_BIT(31)
> +#define   PLL_LOCK		REG_BIT(30)
> +#define   PLL_POWER_ENABLE	REG_BIT(27)
> +#define   PLL_POWER_STATE	REG_BIT(26)
> +#define ICL_DPLL_ENABLE(pll)	_MMIO(_PICK_EVEN_2RANGES(pll, 3,
> 		\
> +							_DPLL0_ENABLE,
> _DPLL1_ENABLE,	\
> +
> 	_ADLS_DPLL3_ENABLE, _ADLS_DPLL3_ENABLE))
> +
> +#define DG2_PLL_ENABLE(pll)	_MMIO(_PICK_EVEN_2RANGES(pll, 3,
> 		\
> +							_DPLL0_ENABLE,
> _DPLL1_ENABLE,	\
> +							_DG2_PLL3_ENABLE,
> _DG2_PLL3_ENABLE))
> +
> +#define TBT_PLL_ENABLE		_MMIO(0x46020)
> +
> +#define _MG_PLL1_ENABLE		0x46030
> +#define _MG_PLL2_ENABLE		0x46034
> +#define _MG_PLL3_ENABLE		0x46038
> +#define _MG_PLL4_ENABLE		0x4603C
> +/* Bits are the same as _DPLL0_ENABLE */
> +#define MG_PLL_ENABLE(tc_port)	_MMIO_PORT((tc_port),
> _MG_PLL1_ENABLE, \
> +					   _MG_PLL2_ENABLE)
> +
> +/* DG1 PLL */
> +#define DG1_DPLL_ENABLE(pll)    _MMIO(_PICK_EVEN_2RANGES(pll, 2,
> 			\
> +							_DPLL0_ENABLE,
> _DPLL1_ENABLE,	\
> +							_MG_PLL1_ENABLE,
> _MG_PLL2_ENABLE))
> +
> +/* ADL-P Type C PLL */
> +#define PORTTC1_PLL_ENABLE	0x46038
> +#define PORTTC2_PLL_ENABLE	0x46040
> +#define ADLP_PORTTC_PLL_ENABLE(tc_port)
> 	_MMIO_PORT((tc_port), \
> +
> PORTTC1_PLL_ENABLE, \
> +
> PORTTC2_PLL_ENABLE)
> +
> +#define _ICL_DPLL0_CFGCR0		0x164000
> +#define _ICL_DPLL1_CFGCR0		0x164080
> +#define ICL_DPLL_CFGCR0(pll)		_MMIO_PLL(pll, _ICL_DPLL0_CFGCR0,
> \
> +						  _ICL_DPLL1_CFGCR0)
> +#define   DPLL_CFGCR0_HDMI_MODE		(1 << 30)
> +#define   DPLL_CFGCR0_SSC_ENABLE	(1 << 29)
> +#define   DPLL_CFGCR0_SSC_ENABLE_ICL	(1 << 25)
> +#define   DPLL_CFGCR0_LINK_RATE_MASK	(0xf << 25)
> +#define   DPLL_CFGCR0_LINK_RATE_2700	(0 << 25)
> +#define   DPLL_CFGCR0_LINK_RATE_1350	(1 << 25)
> +#define   DPLL_CFGCR0_LINK_RATE_810	(2 << 25)
> +#define   DPLL_CFGCR0_LINK_RATE_1620	(3 << 25)
> +#define   DPLL_CFGCR0_LINK_RATE_1080	(4 << 25)
> +#define   DPLL_CFGCR0_LINK_RATE_2160	(5 << 25)
> +#define   DPLL_CFGCR0_LINK_RATE_3240	(6 << 25)
> +#define   DPLL_CFGCR0_LINK_RATE_4050	(7 << 25)
> +#define   DPLL_CFGCR0_DCO_FRACTION_MASK	(0x7fff << 10)
> +#define   DPLL_CFGCR0_DCO_FRACTION_SHIFT	(10)
> +#define   DPLL_CFGCR0_DCO_FRACTION(x)	((x) << 10)
> +#define   DPLL_CFGCR0_DCO_INTEGER_MASK	(0x3ff)
> +
> +#define _ICL_DPLL0_CFGCR1		0x164004
> +#define _ICL_DPLL1_CFGCR1		0x164084
> +#define ICL_DPLL_CFGCR1(pll)		_MMIO_PLL(pll, _ICL_DPLL0_CFGCR1,
> \
> +						  _ICL_DPLL1_CFGCR1)
> +#define   DPLL_CFGCR1_QDIV_RATIO_MASK	(0xff << 10)
> +#define   DPLL_CFGCR1_QDIV_RATIO_SHIFT	(10)
> +#define   DPLL_CFGCR1_QDIV_RATIO(x)	((x) << 10)
> +#define   DPLL_CFGCR1_QDIV_MODE_SHIFT	(9)
> +#define   DPLL_CFGCR1_QDIV_MODE(x)	((x) << 9)
> +#define   DPLL_CFGCR1_KDIV_MASK		(7 << 6)
> +#define   DPLL_CFGCR1_KDIV_SHIFT		(6)
> +#define   DPLL_CFGCR1_KDIV(x)		((x) << 6)
> +#define   DPLL_CFGCR1_KDIV_1		(1 << 6)
> +#define   DPLL_CFGCR1_KDIV_2		(2 << 6)
> +#define   DPLL_CFGCR1_KDIV_3		(4 << 6)
> +#define   DPLL_CFGCR1_PDIV_MASK		(0xf << 2)
> +#define   DPLL_CFGCR1_PDIV_SHIFT		(2)
> +#define   DPLL_CFGCR1_PDIV(x)		((x) << 2)
> +#define   DPLL_CFGCR1_PDIV_2		(1 << 2)
> +#define   DPLL_CFGCR1_PDIV_3		(2 << 2)
> +#define   DPLL_CFGCR1_PDIV_5		(4 << 2)
> +#define   DPLL_CFGCR1_PDIV_7		(8 << 2)
> +#define   DPLL_CFGCR1_CENTRAL_FREQ	(3 << 0)
> +#define   DPLL_CFGCR1_CENTRAL_FREQ_8400	(3 << 0)
> +#define   TGL_DPLL_CFGCR1_CFSELOVRD_NORMAL_XTAL	(0 << 0)
> +
> +#define _TGL_DPLL0_CFGCR0		0x164284
> +#define _TGL_DPLL1_CFGCR0		0x16428C
> +#define _TGL_TBTPLL_CFGCR0		0x16429C
> +#define TGL_DPLL_CFGCR0(pll)
> 	_MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
> +					      _TGL_DPLL0_CFGCR0,
> _TGL_DPLL1_CFGCR0,	\
> +					      _TGL_TBTPLL_CFGCR0,
> _TGL_TBTPLL_CFGCR0))
> +#define RKL_DPLL_CFGCR0(pll)		_MMIO_PLL(pll,
> _TGL_DPLL0_CFGCR0, \
> +						  _TGL_DPLL1_CFGCR0)
> +
> +#define _TGL_DPLL0_DIV0					0x164B00
> +#define _TGL_DPLL1_DIV0					0x164C00
> +#define TGL_DPLL0_DIV0(pll)				_MMIO_PLL(pll,
> _TGL_DPLL0_DIV0, _TGL_DPLL1_DIV0)
> +#define   TGL_DPLL0_DIV0_AFC_STARTUP_MASK
> 	REG_GENMASK(27, 25)
> +#define   TGL_DPLL0_DIV0_AFC_STARTUP(val)
> 	REG_FIELD_PREP(TGL_DPLL0_DIV0_AFC_STARTUP_MASK, (val))
> +
> +#define _TGL_DPLL0_CFGCR1		0x164288
> +#define _TGL_DPLL1_CFGCR1		0x164290
> +#define _TGL_TBTPLL_CFGCR1		0x1642A0
> +#define TGL_DPLL_CFGCR1(pll)
> 	_MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
> +					      _TGL_DPLL0_CFGCR1,
> _TGL_DPLL1_CFGCR1,	\
> +					      _TGL_TBTPLL_CFGCR1,
> _TGL_TBTPLL_CFGCR1))
> +#define RKL_DPLL_CFGCR1(pll)		_MMIO_PLL(pll,
> _TGL_DPLL0_CFGCR1, \
> +						  _TGL_DPLL1_CFGCR1)
> +
> +#define _DG1_DPLL2_CFGCR0		0x16C284
> +#define _DG1_DPLL3_CFGCR0		0x16C28C
> +#define DG1_DPLL_CFGCR0(pll)
> 	_MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
> +					      _TGL_DPLL0_CFGCR0,
> _TGL_DPLL1_CFGCR0,	\
> +					      _DG1_DPLL2_CFGCR0,
> _DG1_DPLL3_CFGCR0))
> +
> +#define _DG1_DPLL2_CFGCR1               0x16C288
> +#define _DG1_DPLL3_CFGCR1               0x16C290
> +#define DG1_DPLL_CFGCR1(pll)            _MMIO(_PICK_EVEN_2RANGES(pll, 2,
> 		\
> +					      _TGL_DPLL0_CFGCR1,
> _TGL_DPLL1_CFGCR1,	\
> +					      _DG1_DPLL2_CFGCR1,
> _DG1_DPLL3_CFGCR1))
> +
> +/* For ADL-S DPLL4_CFGCR0/1 are used to control DPLL2 */
> +#define _ADLS_DPLL4_CFGCR0		0x164294
> +#define _ADLS_DPLL3_CFGCR0		0x1642C0
> +#define ADLS_DPLL_CFGCR0(pll)
> 	_MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
> +					      _TGL_DPLL0_CFGCR0,
> _TGL_DPLL1_CFGCR0,	\
> +					      _ADLS_DPLL4_CFGCR0,
> _ADLS_DPLL3_CFGCR0))
> +
> +#define _ADLS_DPLL4_CFGCR1		0x164298
> +#define _ADLS_DPLL3_CFGCR1		0x1642C4
> +#define ADLS_DPLL_CFGCR1(pll)
> 	_MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
> +					      _TGL_DPLL0_CFGCR1,
> _TGL_DPLL1_CFGCR1,	\
> +					      _ADLS_DPLL4_CFGCR1,
> _ADLS_DPLL3_CFGCR1))
> +
> +/* BXT display engine PLL */
> +#define BXT_DE_PLL_CTL			_MMIO(0x6d000)
> +#define   BXT_DE_PLL_RATIO(x)		(x)	/* {60,65,100} *
> 19.2MHz */
> +#define   BXT_DE_PLL_RATIO_MASK		0xff
> +
> +#define BXT_DE_PLL_ENABLE		_MMIO(0x46070)
> +#define   BXT_DE_PLL_PLL_ENABLE		(1 << 31)
> +#define   BXT_DE_PLL_LOCK		(1 << 30)
> +#define   BXT_DE_PLL_FREQ_REQ		(1 << 23)
> +#define   BXT_DE_PLL_FREQ_REQ_ACK	(1 << 22)
> +#define   ICL_CDCLK_PLL_RATIO(x)	(x)
> +#define   ICL_CDCLK_PLL_RATIO_MASK	0xff
> +
> +/* GEN9 DC */
> +#define DC_STATE_EN			_MMIO(0x45504)
> +#define  DC_STATE_DISABLE		0
> +#define  DC_STATE_EN_DC3CO		REG_BIT(30)
> +#define  DC_STATE_DC3CO_STATUS		REG_BIT(29)
> +#define  HOLD_PHY_CLKREQ_PG1_LATCH	REG_BIT(21)
> +#define  HOLD_PHY_PG1_LATCH		REG_BIT(20)
> +#define  DC_STATE_EN_UPTO_DC5		(1 << 0)
> +#define  DC_STATE_EN_DC9		(1 << 3)
> +#define  DC_STATE_EN_UPTO_DC6		(2 << 0)
> +#define  DC_STATE_EN_UPTO_DC5_DC6_MASK   0x3
> +
> +#define  DC_STATE_DEBUG                  _MMIO(0x45520)
> +#define  DC_STATE_DEBUG_MASK_CORES	(1 << 0)
> +#define  DC_STATE_DEBUG_MASK_MEMORY_UP	(1 << 1)
> +
> +#define D_COMP_BDW			_MMIO(0x138144)
> +
> +/* Pipe WM_LINETIME - watermark line time */
> +#define _WM_LINETIME_A		0x45270
> +#define _WM_LINETIME_B		0x45274
> +#define WM_LINETIME(pipe) _MMIO_PIPE(pipe, _WM_LINETIME_A,
> _WM_LINETIME_B)
> +#define  HSW_LINETIME_MASK	REG_GENMASK(8, 0)
> +#define  HSW_LINETIME(x)	REG_FIELD_PREP(HSW_LINETIME_MASK, (x))
> +#define  HSW_IPS_LINETIME_MASK	REG_GENMASK(24, 16)
> +#define  HSW_IPS_LINETIME(x)
> 	REG_FIELD_PREP(HSW_IPS_LINETIME_MASK, (x))
> +
> +/* SFUSE_STRAP */
> +#define SFUSE_STRAP			_MMIO(0xc2014)
> +#define  SFUSE_STRAP_FUSE_LOCK		(1 << 13)
> +#define  SFUSE_STRAP_RAW_FREQUENCY	(1 << 8)
> +#define  SFUSE_STRAP_DISPLAY_DISABLED	(1 << 7)
> +#define  SFUSE_STRAP_CRT_DISABLED	(1 << 6)
> +#define  SFUSE_STRAP_DDIF_DETECTED	(1 << 3)
> +#define  SFUSE_STRAP_DDIB_DETECTED	(1 << 2)
> +#define  SFUSE_STRAP_DDIC_DETECTED	(1 << 1)
> +#define  SFUSE_STRAP_DDID_DETECTED	(1 << 0)
> +
> +/* Gen4+ Timestamp and Pipe Frame time stamp registers */
> +#define GEN4_TIMESTAMP		_MMIO(0x2358)
> +#define ILK_TIMESTAMP_HI	_MMIO(0x70070)
> +#define IVB_TIMESTAMP_CTR	_MMIO(0x44070)
> +
> +/* g4x+, except vlv/chv! */
> +#define _PIPE_FRMTMSTMP_A		0x70048
> +#define _PIPE_FRMTMSTMP_B		0x71048
> +#define PIPE_FRMTMSTMP(pipe)		\
> +	_MMIO_PIPE(pipe, _PIPE_FRMTMSTMP_A, _PIPE_FRMTMSTMP_B)
> +
> +#define _VLV_PIPE_MSA_MISC_A			0x70048
> +#define VLV_PIPE_MSA_MISC(pipe)		\
> +			_MMIO_PIPE2(dev_priv, pipe,
> _VLV_PIPE_MSA_MISC_A)
> +#define   VLV_MSA_MISC1_HW_ENABLE			REG_BIT(31)
> +#define   VLV_MSA_MISC1_SW_S3D_MASK
> 	REG_GENMASK(2, 0) /* MSA MISC1 3:1 */
> +
> +#define _ICL_PHY_MISC_A		0x64C00
> +#define _ICL_PHY_MISC_B		0x64C04
> +#define _DG2_PHY_MISC_TC1	0x64C14 /* TC1="PHY E" but offset as if "PHY
> F" */
> +#define ICL_PHY_MISC(port)	_MMIO_PORT(port, _ICL_PHY_MISC_A,
> _ICL_PHY_MISC_B)
> +#define DG2_PHY_MISC(port)	((port) == PHY_E ?
> _MMIO(_DG2_PHY_MISC_TC1) : \
> +				 ICL_PHY_MISC(port))
> +#define  ICL_PHY_MISC_MUX_DDID			(1 << 28)
> +#define  ICL_PHY_MISC_DE_IO_COMP_PWR_DOWN	(1 << 23)
> +#define  DG2_PHY_DP_TX_ACK_MASK			REG_GENMASK(23,
> 20)
> +
> +#define PORT_TX_DFLEXDPSP(fia)			_MMIO_FIA((fia),
> 0x008A0)
> +#define   MODULAR_FIA_MASK			(1 << 4)
> +#define   TC_LIVE_STATE_TBT(idx)		(1 << ((idx) * 8 + 6))
> +#define   TC_LIVE_STATE_TC(idx)			(1 << ((idx) * 8 + 5))
> +#define   DP_LANE_ASSIGNMENT_SHIFT(idx)		((idx) * 8)
> +#define   DP_LANE_ASSIGNMENT_MASK(idx)		(0xf << ((idx) * 8))
> +#define   DP_LANE_ASSIGNMENT(idx, x)		((x) << ((idx) * 8))
> +
> +#define PORT_TX_DFLEXDPPMS(fia)			_MMIO_FIA((fia),
> 0x00890)
> +#define   DP_PHY_MODE_STATUS_COMPLETED(idx)	(1 << (idx))
> +
> +#define PORT_TX_DFLEXDPCSSS(fia)		_MMIO_FIA((fia), 0x00894)
> +#define   DP_PHY_MODE_STATUS_NOT_SAFE(idx)	(1 << (idx))
> +
> +#define PORT_TX_DFLEXPA1(fia)			_MMIO_FIA((fia),
> 0x00880)
> +#define   DP_PIN_ASSIGNMENT_SHIFT(idx)		((idx) * 4)
> +#define   DP_PIN_ASSIGNMENT_MASK(idx)		(0xf << ((idx) * 4))
> +#define   DP_PIN_ASSIGNMENT(idx, x)		((x) << ((idx) * 4))
> +
> +#define _TCSS_DDI_STATUS_1			0x161500
> +#define _TCSS_DDI_STATUS_2			0x161504
> +#define TCSS_DDI_STATUS(tc)			_MMIO(_PICK_EVEN(tc, \
> +
> _TCSS_DDI_STATUS_1, \
> +
> _TCSS_DDI_STATUS_2))
> +#define  TCSS_DDI_STATUS_PIN_ASSIGNMENT_MASK	REG_GENMASK(28,
> 25)
> +#define  TCSS_DDI_STATUS_READY			REG_BIT(2)
> +#define  TCSS_DDI_STATUS_HPD_LIVE_STATUS_TBT	REG_BIT(1)
> +#define  TCSS_DDI_STATUS_HPD_LIVE_STATUS_ALT	REG_BIT(0)
> +
> +#define CLKREQ_POLICY			_MMIO(0x101038)
> +#define  CLKREQ_POLICY_MEM_UP_OVRD	REG_BIT(1)
> +
> +#define CLKGATE_DIS_MISC			_MMIO(0x46534)
> +#define  CLKGATE_DIS_MISC_DMASC_GATING_DIS	REG_BIT(21)
> +
> +#define _MTL_CLKGATE_DIS_TRANS_A			0x604E8
> +#define _MTL_CLKGATE_DIS_TRANS_B			0x614E8
> +#define MTL_CLKGATE_DIS_TRANS(dev_priv, trans)
> 	_MMIO_TRANS2(dev_priv, trans, _MTL_CLKGATE_DIS_TRANS_A)
> +#define  MTL_CLKGATE_DIS_TRANS_DMASC_GATING_DIS
> 	REG_BIT(7)
> +
> +#define MTL_MEM_SS_INFO_QGV_POINT_OFFSET	0x45710
> +#define MTL_MEM_SS_INFO_QGV_POINT_LOW(point)
> 	_MMIO(MTL_MEM_SS_INFO_QGV_POINT_OFFSET + (point) * 8)
> +#define   MTL_TRCD_MASK			REG_GENMASK(31, 24)
> +#define   MTL_TRP_MASK			REG_GENMASK(23, 16)
> +#define   MTL_DCLK_MASK			REG_GENMASK(15, 0)
> +
> +#define MTL_MEM_SS_INFO_QGV_POINT_HIGH(point)
> 	_MMIO(MTL_MEM_SS_INFO_QGV_POINT_OFFSET + (point) * 8 + 4)
> +#define   MTL_TRAS_MASK			REG_GENMASK(16, 8)
> +#define   MTL_TRDPRE_MASK		REG_GENMASK(7, 0)
> +
> +
> +
> +#endif /* __INTEL_DISPLAY_REGS_H__ */
> diff --git a/drivers/gpu/drm/i915/display/intel_display_wa.c
> b/drivers/gpu/drm/i915/display/intel_display_wa.c
> index e5a8022db664..864f7f318832 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_wa.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_wa.c
> @@ -6,6 +6,7 @@
>  #include "i915_drv.h"
>  #include "i915_reg.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_wa.h"
> 
>  static void gen11_display_wa_apply(struct drm_i915_private *i915)
> diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c
> b/drivers/gpu/drm/i915/display/intel_dmc.c
> index 221d3abda791..111d05585d5a 100644
> --- a/drivers/gpu/drm/i915/display/intel_dmc.c
> +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> @@ -28,6 +28,7 @@
>  #include "i915_drv.h"
>  #include "i915_reg.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_dmc.h"
>  #include "intel_dmc_regs.h"
>  #include "intel_step.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_dmc_wl.c
> b/drivers/gpu/drm/i915/display/intel_dmc_wl.c
> index 7e2ce0c2f6c3..082cb5597c1a 100644
> --- a/drivers/gpu/drm/i915/display/intel_dmc_wl.c
> +++ b/drivers/gpu/drm/i915/display/intel_dmc_wl.c
> @@ -10,6 +10,7 @@
>  #include "i915_drv.h"
>  #include "i915_reg.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_dmc_regs.h"
>  #include "intel_dmc_wl.h"
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index f7bd6946910d..1a8b2410fc10 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -34,7 +34,6 @@
>  #include <linux/string_helpers.h>
>  #include <linux/timekeeping.h>
>  #include <linux/types.h>
> -
>  #include <asm/byteorder.h>
> 
>  #include <drm/display/drm_dp_helper.h>
> @@ -58,10 +57,12 @@
>  #include "intel_combo_phy_regs.h"
>  #include "intel_connector.h"
>  #include "intel_crtc.h"
> +#include "intel_crtc_state_dump.h"
>  #include "intel_cx0_phy.h"
>  #include "intel_ddi.h"
>  #include "intel_de.h"
>  #include "intel_display_driver.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dp.h"
>  #include "intel_dp_aux.h"
> @@ -87,12 +88,11 @@
>  #include "intel_pfit.h"
>  #include "intel_pps.h"
>  #include "intel_psr.h"
> -#include "intel_runtime_pm.h"
>  #include "intel_quirks.h"
> +#include "intel_runtime_pm.h"
>  #include "intel_tc.h"
>  #include "intel_vdsc.h"
>  #include "intel_vrr.h"
> -#include "intel_crtc_state_dump.h"
> 
>  /* DP DSC throughput values used for slice count calculations KPixels/s */
>  #define DP_DSC_PEAK_PIXEL_RATE			2720000
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> index 00c493cc8a4b..1b62a3ce79a6 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> @@ -14,6 +14,7 @@
>  #include "i915_reg.h"
>  #include "intel_ddi.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dp.h"
>  #include "intel_dp_hdcp.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index ae2db983eff9..218b46fe65d1 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -38,6 +38,7 @@
>  #include "intel_ddi.h"
>  #include "intel_de.h"
>  #include "intel_display_driver.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dp.h"
>  #include "intel_dp_hdcp.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_test.c
> b/drivers/gpu/drm/i915/display/intel_dp_test.c
> index 614b90d6938f..c4c7fd7899a1 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_test.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_test.c
> @@ -11,6 +11,7 @@
>  #include "i915_reg.h"
>  #include "intel_ddi.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dp.h"
>  #include "intel_dp_link_training.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_dpio_phy.c
> b/drivers/gpu/drm/i915/display/intel_dpio_phy.c
> index 5f88702818d3..d0bb5f562f85 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpio_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpio_phy.c
> @@ -28,6 +28,7 @@
>  #include "intel_ddi_buf_trans.h"
>  #include "intel_de.h"
>  #include "intel_display_power_well.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dp.h"
>  #include "intel_dpio_phy.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_dpll.c
> b/drivers/gpu/drm/i915/display/intel_dpll.c
> index 3256b1293f7f..fb2267482e2d 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpll.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpll.c
> @@ -13,6 +13,7 @@
>  #include "intel_cx0_phy.h"
>  #include "intel_de.h"
>  #include "intel_display.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dpio_phy.h"
>  #include "intel_dpll.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> index b8fa04d3cd5c..253ded981ca5 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> @@ -28,6 +28,7 @@
>  #include "i915_drv.h"
>  #include "i915_reg.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dkl_phy.h"
>  #include "intel_dkl_phy_regs.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_dpt_common.c
> b/drivers/gpu/drm/i915/display/intel_dpt_common.c
> index d2dede0a5229..4e05558d6b64 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpt_common.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpt_common.c
> @@ -6,6 +6,7 @@
>  #include "i915_drv.h"
>  #include "i915_reg.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dpt_common.h"
>  #include "skl_universal_plane_regs.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_drrs.c
> b/drivers/gpu/drm/i915/display/intel_drrs.c
> index 0fec01b79b23..b0c1ceb978aa 100644
> --- a/drivers/gpu/drm/i915/display/intel_drrs.c
> +++ b/drivers/gpu/drm/i915/display/intel_drrs.c
> @@ -9,6 +9,7 @@
>  #include "i915_reg.h"
>  #include "intel_atomic.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_drrs.h"
>  #include "intel_frontbuffer.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c
> b/drivers/gpu/drm/i915/display/intel_dsb.c
> index 2f2812c23972..bd1bca27403f 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -11,6 +11,7 @@
>  #include "i915_reg.h"
>  #include "intel_crtc.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dsb.h"
>  #include "intel_dsb_buffer.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
> b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
> index 7b2ffd14ae6e..1c67bfc9a277 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
> @@ -31,17 +31,16 @@
>  #include <linux/pinctrl/machine.h>
>  #include <linux/slab.h>
>  #include <linux/string_helpers.h>
> -
>  #include <linux/unaligned.h>
> 
>  #include <drm/drm_crtc.h>
>  #include <drm/drm_edid.h>
> -
>  #include <video/mipi_display.h>
> 
>  #include "i915_drv.h"
>  #include "i915_reg.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dsi.h"
>  #include "intel_dsi_vbt.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_dvo.c
> b/drivers/gpu/drm/i915/display/intel_dvo.c
> index c310698a1a86..a773e4aaaadc 100644
> --- a/drivers/gpu/drm/i915/display/intel_dvo.c
> +++ b/drivers/gpu/drm/i915/display/intel_dvo.c
> @@ -38,6 +38,7 @@
>  #include "intel_connector.h"
>  #include "intel_de.h"
>  #include "intel_display_driver.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dvo.h"
>  #include "intel_dvo_dev.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c
> b/drivers/gpu/drm/i915/display/intel_fbc.c
> index df05904bac8a..09ca2e90f478 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> @@ -45,7 +45,9 @@
>  #include <drm/drm_fourcc.h>
> 
>  #include "gem/i915_gem_stolen.h"
> +
>  #include "gt/intel_gt_types.h"
> +
>  #include "i915_drv.h"
>  #include "i915_reg.h"
>  #include "i915_utils.h"
> @@ -55,6 +57,7 @@
>  #include "intel_cdclk.h"
>  #include "intel_de.h"
>  #include "intel_display_device.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_trace.h"
>  #include "intel_display_types.h"
>  #include "intel_display_wa.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_fdi.c
> b/drivers/gpu/drm/i915/display/intel_fdi.c
> index 3e8d6d8af780..be7a696cceda 100644
> --- a/drivers/gpu/drm/i915/display/intel_fdi.c
> +++ b/drivers/gpu/drm/i915/display/intel_fdi.c
> @@ -13,8 +13,9 @@
>  #include "intel_crtc.h"
>  #include "intel_ddi.h"
>  #include "intel_de.h"
> -#include "intel_dp.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_dp.h"
>  #include "intel_fdi.h"
>  #include "intel_fdi_regs.h"
>  #include "intel_link_bw.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_fifo_underrun.c
> b/drivers/gpu/drm/i915/display/intel_fifo_underrun.c
> index 18fcdbe1248a..35de6975e196 100644
> --- a/drivers/gpu/drm/i915/display/intel_fifo_underrun.c
> +++ b/drivers/gpu/drm/i915/display/intel_fifo_underrun.c
> @@ -29,6 +29,7 @@
>  #include "i915_reg.h"
>  #include "intel_de.h"
>  #include "intel_display_irq.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_trace.h"
>  #include "intel_display_types.h"
>  #include "intel_fbc.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c
> b/drivers/gpu/drm/i915/display/intel_gmbus.c
> index 807cf606e7a8..9260ae584899 100644
> --- a/drivers/gpu/drm/i915/display/intel_gmbus.c
> +++ b/drivers/gpu/drm/i915/display/intel_gmbus.c
> @@ -37,6 +37,7 @@
>  #include "i915_irq.h"
>  #include "i915_reg.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_gmbus.h"
>  #include "intel_gmbus_regs.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c
> b/drivers/gpu/drm/i915/display/intel_hdcp.c
> index 7cc0399b2a5d..75ba4ec598cd 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
> @@ -21,6 +21,7 @@
>  #include "intel_de.h"
>  #include "intel_display_power.h"
>  #include "intel_display_power_well.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_hdcp.h"
>  #include "intel_hdcp_gsc.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c
> b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 3b51238022f4..13965388daa6 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -40,7 +40,6 @@
>  #include <drm/drm_edid.h>
>  #include <drm/drm_probe_helper.h>
>  #include <drm/intel/intel_lpe_audio.h>
> -
>  #include <media/cec-notifier.h>
> 
>  #include "g4x_hdmi.h"
> @@ -53,6 +52,7 @@
>  #include "intel_ddi.h"
>  #include "intel_de.h"
>  #include "intel_display_driver.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dp.h"
>  #include "intel_gmbus.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_hotplug_irq.c
> b/drivers/gpu/drm/i915/display/intel_hotplug_irq.c
> index 2137ac7b882a..36e492094fb3 100644
> --- a/drivers/gpu/drm/i915/display/intel_hotplug_irq.c
> +++ b/drivers/gpu/drm/i915/display/intel_hotplug_irq.c
> @@ -7,6 +7,7 @@
>  #include "i915_reg.h"
>  #include "intel_de.h"
>  #include "intel_display_irq.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dp_aux.h"
>  #include "intel_gmbus.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c
> b/drivers/gpu/drm/i915/display/intel_lspcon.c
> index 63c1afa30b05..3e60469687d4 100644
> --- a/drivers/gpu/drm/i915/display/intel_lspcon.c
> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c
> @@ -31,6 +31,7 @@
>  #include "i915_reg.h"
>  #include "i915_utils.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dp.h"
>  #include "intel_hdmi.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_lvds.c
> b/drivers/gpu/drm/i915/display/intel_lvds.c
> index 4b0dce169d4e..8e8f61b2356a 100644
> --- a/drivers/gpu/drm/i915/display/intel_lvds.c
> +++ b/drivers/gpu/drm/i915/display/intel_lvds.c
> @@ -27,12 +27,12 @@
>   *      Jesse Barnes <jesse.barnes@intel.com>
>   */
> 
> -#include <acpi/button.h>
>  #include <linux/acpi.h>
>  #include <linux/dmi.h>
>  #include <linux/i2c.h>
>  #include <linux/slab.h>
>  #include <linux/vga_switcheroo.h>
> +#include <acpi/button.h>
> 
>  #include <drm/drm_atomic_helper.h>
>  #include <drm/drm_crtc.h>
> @@ -45,6 +45,7 @@
>  #include "intel_backlight.h"
>  #include "intel_connector.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dpll.h"
>  #include "intel_fdi.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> index 10cdfdad82e4..4b2e08056d76 100644
> --- a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> +++ b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> @@ -6,8 +6,8 @@
>   * state.
>   */
> 
> -#include <drm/drm_atomic_uapi.h>
>  #include <drm/drm_atomic_state_helper.h>
> +#include <drm/drm_atomic_uapi.h>
>  #include <drm/drm_vblank.h>
> 
>  #include "i915_drv.h"
> @@ -23,6 +23,7 @@
>  #include "intel_de.h"
>  #include "intel_display.h"
>  #include "intel_display_power.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dmc.h"
>  #include "intel_fifo_underrun.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c
> b/drivers/gpu/drm/i915/display/intel_overlay.c
> index 4d00db86131b..e41a652a3550 100644
> --- a/drivers/gpu/drm/i915/display/intel_overlay.c
> +++ b/drivers/gpu/drm/i915/display/intel_overlay.c
> @@ -31,6 +31,7 @@
>  #include "gem/i915_gem_internal.h"
>  #include "gem/i915_gem_object_frontbuffer.h"
>  #include "gem/i915_gem_pm.h"
> +
>  #include "gt/intel_gpu_commands.h"
>  #include "gt/intel_ring.h"
> 
> @@ -38,6 +39,7 @@
>  #include "i915_reg.h"
>  #include "intel_color_regs.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_frontbuffer.h"
>  #include "intel_overlay.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_pch_display.c
> b/drivers/gpu/drm/i915/display/intel_pch_display.c
> index 8fa5a6334d10..4baddf00f818 100644
> --- a/drivers/gpu/drm/i915/display/intel_pch_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_pch_display.c
> @@ -9,6 +9,7 @@
>  #include "intel_crt.h"
>  #include "intel_crt_regs.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dpll.h"
>  #include "intel_fdi.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_pch_refclk.c
> b/drivers/gpu/drm/i915/display/intel_pch_refclk.c
> index 71471c1d7dc9..80bc09fbd5e8 100644
> --- a/drivers/gpu/drm/i915/display/intel_pch_refclk.c
> +++ b/drivers/gpu/drm/i915/display/intel_pch_refclk.c
> @@ -6,6 +6,7 @@
>  #include "i915_drv.h"
>  #include "i915_reg.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_panel.h"
>  #include "intel_pch_refclk.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_pfit.c
> b/drivers/gpu/drm/i915/display/intel_pfit.c
> index 4ee03d9d14ad..dbd51b25833c 100644
> --- a/drivers/gpu/drm/i915/display/intel_pfit.c
> +++ b/drivers/gpu/drm/i915/display/intel_pfit.c
> @@ -7,6 +7,7 @@
>  #include "i915_utils.h"
>  #include "intel_display_core.h"
>  #include "intel_display_driver.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_lvds_regs.h"
>  #include "intel_pfit.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_pipe_crc.c
> b/drivers/gpu/drm/i915/display/intel_pipe_crc.c
> index 90efc6f64e52..1f7867a4e90e 100644
> --- a/drivers/gpu/drm/i915/display/intel_pipe_crc.c
> +++ b/drivers/gpu/drm/i915/display/intel_pipe_crc.c
> @@ -34,6 +34,7 @@
>  #include "intel_atomic.h"
>  #include "intel_de.h"
>  #include "intel_display_irq.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_pipe_crc.h"
>  #include "intel_pipe_crc_regs.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_pmdemand.c
> b/drivers/gpu/drm/i915/display/intel_pmdemand.c
> index 63301a01906c..3e95b53dca3d 100644
> --- a/drivers/gpu/drm/i915/display/intel_pmdemand.c
> +++ b/drivers/gpu/drm/i915/display/intel_pmdemand.c
> @@ -11,6 +11,7 @@
>  #include "intel_bw.h"
>  #include "intel_cdclk.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_trace.h"
>  #include "intel_pmdemand.h"
>  #include "intel_step.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c
> b/drivers/gpu/drm/i915/display/intel_pps.c
> index c0f65749a3f6..3244ce070d68 100644
> --- a/drivers/gpu/drm/i915/display/intel_pps.c
> +++ b/drivers/gpu/drm/i915/display/intel_pps.c
> @@ -10,6 +10,7 @@
>  #include "i915_reg.h"
>  #include "intel_de.h"
>  #include "intel_display_power_well.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dp.h"
>  #include "intel_dpio_phy.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index 861e50ceef85..17cfba1fcb95 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -36,6 +36,7 @@
>  #include "intel_ddi.h"
>  #include "intel_de.h"
>  #include "intel_display_irq.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dp.h"
>  #include "intel_dp_aux.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c
> b/drivers/gpu/drm/i915/display/intel_sdvo.c
> index ca8aeb17c909..c34330f8de89 100644
> --- a/drivers/gpu/drm/i915/display/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
> @@ -46,6 +46,7 @@
>  #include "intel_crtc.h"
>  #include "intel_de.h"
>  #include "intel_display_driver.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_fdi.h"
>  #include "intel_fifo_underrun.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_snps_phy.c
> b/drivers/gpu/drm/i915/display/intel_snps_phy.c
> index 353221d3e29f..9db02bb8cea7 100644
> --- a/drivers/gpu/drm/i915/display/intel_snps_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_snps_phy.c
> @@ -10,6 +10,7 @@
>  #include "intel_ddi.h"
>  #include "intel_ddi_buf_trans.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_snps_hdmi_pll.h"
>  #include "intel_snps_phy.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_tc.c
> b/drivers/gpu/drm/i915/display/intel_tc.c
> index 13811244c82b..50ef28ce2d7b 100644
> --- a/drivers/gpu/drm/i915/display/intel_tc.c
> +++ b/drivers/gpu/drm/i915/display/intel_tc.c
> @@ -12,6 +12,7 @@
>  #include "intel_display.h"
>  #include "intel_display_driver.h"
>  #include "intel_display_power_map.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dkl_phy_regs.h"
>  #include "intel_dp.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c
> b/drivers/gpu/drm/i915/display/intel_vblank.c
> index 4efd4f7d497a..ab548ddfd178 100644
> --- a/drivers/gpu/drm/i915/display/intel_vblank.c
> +++ b/drivers/gpu/drm/i915/display/intel_vblank.c
> @@ -10,6 +10,7 @@
>  #include "intel_color.h"
>  #include "intel_crtc.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_vblank.h"
>  #include "intel_vrr.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_vga.c
> b/drivers/gpu/drm/i915/display/intel_vga.c
> index fd18dd07ae49..ad47a38c573e 100644
> --- a/drivers/gpu/drm/i915/display/intel_vga.c
> +++ b/drivers/gpu/drm/i915/display/intel_vga.c
> @@ -7,11 +7,13 @@
>  #include <linux/vgaarb.h>
> 
>  #include <video/vga.h>
> +
>  #include "soc/intel_gmch.h"
> 
>  #include "i915_drv.h"
>  #include "i915_reg.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_vga.h"
> 
>  static i915_reg_t intel_vga_cntrl_reg(struct intel_display *display)
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c
> b/drivers/gpu/drm/i915/display/intel_vrr.c
> index adb51609d0a3..06b147324b89 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.c
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.c
> @@ -6,6 +6,7 @@
> 
>  #include "i915_reg.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dp.h"
>  #include "intel_vrr.h"
> diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c
> b/drivers/gpu/drm/i915/display/skl_scaler.c
> index c8bf6fd92ce8..c8cc3d47ae3d 100644
> --- a/drivers/gpu/drm/i915/display/skl_scaler.c
> +++ b/drivers/gpu/drm/i915/display/skl_scaler.c
> @@ -6,6 +6,7 @@
>  #include "i915_drv.h"
>  #include "i915_reg.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_trace.h"
>  #include "intel_display_types.h"
>  #include "intel_fb.h"
> diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> index ee93361bba09..61128152b605 100644
> --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> @@ -8,12 +8,15 @@
>  #include <drm/drm_damage_helper.h>
>  #include <drm/drm_fourcc.h>
> 
> +#include "pxp/intel_pxp.h"
> +
>  #include "i915_drv.h"
>  #include "i915_reg.h"
>  #include "intel_atomic_plane.h"
>  #include "intel_bo.h"
>  #include "intel_de.h"
>  #include "intel_display_irq.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dpt.h"
>  #include "intel_fb.h"
> @@ -25,7 +28,6 @@
>  #include "skl_universal_plane.h"
>  #include "skl_universal_plane_regs.h"
>  #include "skl_watermark.h"
> -#include "pxp/intel_pxp.h"
> 
>  static const u32 skl_plane_formats[] = {
>  	DRM_FORMAT_C8,
> diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c
> b/drivers/gpu/drm/i915/display/skl_watermark.c
> index 45fe4aaeb450..2b50496afad2 100644
> --- a/drivers/gpu/drm/i915/display/skl_watermark.c
> +++ b/drivers/gpu/drm/i915/display/skl_watermark.c
> @@ -19,6 +19,7 @@
>  #include "intel_de.h"
>  #include "intel_display.h"
>  #include "intel_display_power.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_fb.h"
>  #include "intel_fixed.h"
> diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c
> b/drivers/gpu/drm/i915/display/vlv_dsi.c
> index 14973e9cb899..aa06b4d40426 100644
> --- a/drivers/gpu/drm/i915/display/vlv_dsi.c
> +++ b/drivers/gpu/drm/i915/display/vlv_dsi.c
> @@ -39,6 +39,7 @@
>  #include "intel_connector.h"
>  #include "intel_crtc.h"
>  #include "intel_de.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_dsi.h"
>  #include "intel_dsi_vbt.h"
> diff --git a/drivers/gpu/drm/i915/gvt/display.c
> b/drivers/gpu/drm/i915/gvt/display.c
> index c98dfcc3d0de..617d81f27b36 100644
> --- a/drivers/gpu/drm/i915/gvt/display.c
> +++ b/drivers/gpu/drm/i915/gvt/display.c
> @@ -36,6 +36,7 @@
> 
>  #include "i915_drv.h"
>  #include "i915_reg.h"
> +#include "display/intel_display_regs.h"
>  #include "gvt.h"
> 
>  #include "display/bxt_dpio_phy_regs.h"
> diff --git a/drivers/gpu/drm/i915/gvt/fb_decoder.c
> b/drivers/gpu/drm/i915/gvt/fb_decoder.c
> index f9f7ef131371..1b009543d9a2 100644
> --- a/drivers/gpu/drm/i915/gvt/fb_decoder.c
> +++ b/drivers/gpu/drm/i915/gvt/fb_decoder.c
> @@ -39,6 +39,7 @@
>  #include "i915_drv.h"
>  #include "i915_pvinfo.h"
>  #include "i915_reg.h"
> +#include "display/intel_display_regs.h"
> 
>  #include "display/i9xx_plane_regs.h"
>  #include "display/intel_cursor_regs.h"
> diff --git a/drivers/gpu/drm/i915/gvt/handlers.c
> b/drivers/gpu/drm/i915/gvt/handlers.c
> index 4efee6797873..cfc867a57244 100644
> --- a/drivers/gpu/drm/i915/gvt/handlers.c
> +++ b/drivers/gpu/drm/i915/gvt/handlers.c
> @@ -40,6 +40,7 @@
> 
>  #include "i915_drv.h"
>  #include "i915_reg.h"
> +#include "display/intel_display_regs.h"
>  #include "gvt.h"
>  #include "i915_pvinfo.h"
>  #include "intel_mchbar_regs.h"
> diff --git a/drivers/gpu/drm/i915/gvt/interrupt.c
> b/drivers/gpu/drm/i915/gvt/interrupt.c
> index 336d079c4207..a956da68e6bd 100644
> --- a/drivers/gpu/drm/i915/gvt/interrupt.c
> +++ b/drivers/gpu/drm/i915/gvt/interrupt.c
> @@ -33,6 +33,7 @@
> 
>  #include "i915_drv.h"
>  #include "i915_reg.h"
> +#include "display/intel_display_regs.h"
>  #include "gvt.h"
>  #include "trace.h"
> 
> diff --git a/drivers/gpu/drm/i915/gvt/mmio.c
> b/drivers/gpu/drm/i915/gvt/mmio.c
> index e16e0d4c9534..da1135fa7cda 100644
> --- a/drivers/gpu/drm/i915/gvt/mmio.c
> +++ b/drivers/gpu/drm/i915/gvt/mmio.c
> @@ -36,6 +36,7 @@
>  #include <linux/vmalloc.h>
>  #include "i915_drv.h"
>  #include "i915_reg.h"
> +#include "display/intel_display_regs.h"
>  #include "gvt.h"
> 
>  #include "display/bxt_dpio_phy_regs.h"
> diff --git a/drivers/gpu/drm/i915/i915_reg.h
> b/drivers/gpu/drm/i915/i915_reg.h
> index 6e80508b544c..8497e64fef1f 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -116,9 +116,6 @@
>   *  #define GEN8_BAR                    _MMIO(0xb888)
>   */
> 
> -#define GU_CNTL_PROTECTED		_MMIO(0x10100C)
> -#define   DEPRESENT			REG_BIT(9)
> -
>  #define GU_CNTL				_MMIO(0x101010)
>  #define   LMEM_INIT			REG_BIT(7)
>  #define   DRIVERFLR			REG_BIT(31)
> @@ -187,46 +184,6 @@
>  /* DPIO registers */
>  #define DPIO_DEVFN			0
> 
> -#define DPIO_CTL			_MMIO(VLV_DISPLAY_BASE + 0x2110)
> -#define  DPIO_MODSEL1			(1 << 3) /* if ref clk b == 27 */
> -#define  DPIO_MODSEL0			(1 << 2) /* if ref clk a == 27 */
> -#define  DPIO_SFR_BYPASS		(1 << 1)
> -#define  DPIO_CMNRST			(1 << 0)
> -
> -#define BXT_P_CR_GT_DISP_PWRON		_MMIO(0x138090)
> -#define  MIPIO_RST_CTRL				(1 << 2)
> -
> -#define _BXT_PHY_CTL_DDI_A		0x64C00
> -#define _BXT_PHY_CTL_DDI_B		0x64C10
> -#define _BXT_PHY_CTL_DDI_C		0x64C20
> -#define   BXT_PHY_CMNLANE_POWERDOWN_ACK	(1 << 10)
> -#define   BXT_PHY_LANE_POWERDOWN_ACK	(1 << 9)
> -#define   BXT_PHY_LANE_ENABLED		(1 << 8)
> -#define BXT_PHY_CTL(port)		_MMIO_PORT(port,
> _BXT_PHY_CTL_DDI_A, \
> -
> _BXT_PHY_CTL_DDI_B)
> -
> -#define _PHY_CTL_FAMILY_DDI		0x64C90
> -#define _PHY_CTL_FAMILY_EDP		0x64C80
> -#define _PHY_CTL_FAMILY_DDI_C		0x64CA0
> -#define   COMMON_RESET_DIS		(1 << 31)
> -#define BXT_PHY_CTL_FAMILY(phy)
> 		\
> -	 _MMIO(_PICK_EVEN_2RANGES(phy, 1,
> 	\
> -				  _PHY_CTL_FAMILY_DDI,
> _PHY_CTL_FAMILY_DDI,	\
> -				  _PHY_CTL_FAMILY_EDP,
> _PHY_CTL_FAMILY_DDI_C))
> -
> -/* UAIMI scratch pad register 1 */
> -#define UAIMI_SPR1			_MMIO(0x4F074)
> -/* SKL VccIO mask */
> -#define SKL_VCCIO_MASK			0x1
> -/* SKL balance leg register */
> -#define DISPIO_CR_TX_BMU_CR0		_MMIO(0x6C00C)
> -/* I_boost values */
> -#define BALANCE_LEG_SHIFT(port)		(8 + 3 * (port))
> -#define BALANCE_LEG_MASK(port)		(7 << (8 + 3 * (port)))
> -/* Balance leg disable bits */
> -#define BALANCE_LEG_DISABLE_SHIFT	23
> -#define BALANCE_LEG_DISABLE(port)	(1 << (23 + (port)))
> -
>  /*
>   * Fence registers
>   * [0-7]  @ 0x2000 gen2,gen3
> @@ -437,10 +394,6 @@
>  #define VLV_PCBR	_MMIO(VLV_DISPLAY_BASE + 0x2120)
>  #define VLV_PCBR_ADDR_SHIFT	12
> 
> -#define VLV_IRQ_REGS		I915_IRQ_REGS(VLV_IMR, \
> -					      VLV_IER, \
> -					      VLV_IIR)
> -
>  #define   DISPLAY_PLANE_FLIP_PENDING(plane) (1 << (11 - (plane))) /* A
> and B only */
>  #define EIR		_MMIO(0x20b0)
>  #define EMR		_MMIO(0x20b4)
> @@ -475,23 +428,6 @@
>  #define LM_FIFO_WATERMARK   0x0000001F
>  #define MI_ARB_STATE	_MMIO(0x20e4) /* 915+ only */
> 
> -#define _MBUS_ABOX0_CTL			0x45038
> -#define _MBUS_ABOX1_CTL			0x45048
> -#define _MBUS_ABOX2_CTL			0x4504C
> -#define MBUS_ABOX_CTL(x)
> 	\
> -	_MMIO(_PICK_EVEN_2RANGES(x, 2,
> 		\
> -				 _MBUS_ABOX0_CTL, _MBUS_ABOX1_CTL,
> 		\
> -				 _MBUS_ABOX2_CTL, _MBUS_ABOX2_CTL))
> -
> -#define MBUS_ABOX_BW_CREDIT_MASK	(3 << 20)
> -#define MBUS_ABOX_BW_CREDIT(x)		((x) << 20)
> -#define MBUS_ABOX_B_CREDIT_MASK		(0xF << 16)
> -#define MBUS_ABOX_B_CREDIT(x)		((x) << 16)
> -#define MBUS_ABOX_BT_CREDIT_POOL2_MASK	(0x1F << 8)
> -#define MBUS_ABOX_BT_CREDIT_POOL2(x)	((x) << 8)
> -#define MBUS_ABOX_BT_CREDIT_POOL1_MASK	(0x1F << 0)
> -#define MBUS_ABOX_BT_CREDIT_POOL1(x)	((x) << 0)
> -
>  /*
>   * Make render/texture TLB fetches lower priority than associated data
>   * fetches. This is not turned on by default.
> @@ -666,158 +602,6 @@
>  #define   IVB_SPR_STRETCH_MAX_X2
> 	REG_FIELD_PREP(IVB_SPR_STRETCH_MAX_MASK, 2)
>  #define   IVB_SPR_STRETCH_MAX_X1
> 	REG_FIELD_PREP(IVB_SPR_STRETCH_MAX_MASK, 3)
> 
> -#define IPS_CTL		_MMIO(0x43408)
> -#define   IPS_ENABLE		REG_BIT(31)
> -#define   IPS_FALSE_COLOR	REG_BIT(4)
> -
> -/*
> - * Clock control & power management
> - */
> -#define _DPLL_A			0x6014
> -#define _DPLL_B			0x6018
> -#define _CHV_DPLL_C		0x6030
> -#define DPLL(dev_priv, pipe)
> 	_MMIO_BASE_PIPE3(DISPLAY_MMIO_BASE(dev_priv), \
> -						 (pipe), _DPLL_A, _DPLL_B,
> _CHV_DPLL_C)
> -
> -#define VGA0	_MMIO(0x6000)
> -#define VGA1	_MMIO(0x6004)
> -#define VGA_PD	_MMIO(0x6010)
> -#define   VGA0_PD_P2_DIV_4	(1 << 7)
> -#define   VGA0_PD_P1_DIV_2	(1 << 5)
> -#define   VGA0_PD_P1_SHIFT	0
> -#define   VGA0_PD_P1_MASK	(0x1f << 0)
> -#define   VGA1_PD_P2_DIV_4	(1 << 15)
> -#define   VGA1_PD_P1_DIV_2	(1 << 13)
> -#define   VGA1_PD_P1_SHIFT	8
> -#define   VGA1_PD_P1_MASK	(0x1f << 8)
> -#define   DPLL_VCO_ENABLE		(1 << 31)
> -#define   DPLL_SDVO_HIGH_SPEED		(1 << 30)
> -#define   DPLL_DVO_2X_MODE		(1 << 30)
> -#define   DPLL_EXT_BUFFER_ENABLE_VLV	(1 << 30)
> -#define   DPLL_SYNCLOCK_ENABLE		(1 << 29)
> -#define   DPLL_REF_CLK_ENABLE_VLV	(1 << 29)
> -#define   DPLL_VGA_MODE_DIS		(1 << 28)
> -#define   DPLLB_MODE_DAC_SERIAL		(1 << 26) /* i915 */
> -#define   DPLLB_MODE_LVDS		(2 << 26) /* i915 */
> -#define   DPLL_MODE_MASK		(3 << 26)
> -#define   DPLL_DAC_SERIAL_P2_CLOCK_DIV_10 (0 << 24) /* i915 */
> -#define   DPLL_DAC_SERIAL_P2_CLOCK_DIV_5 (1 << 24) /* i915 */
> -#define   DPLLB_LVDS_P2_CLOCK_DIV_14	(0 << 24) /* i915 */
> -#define   DPLLB_LVDS_P2_CLOCK_DIV_7	(1 << 24) /* i915 */
> -#define   DPLL_P2_CLOCK_DIV_MASK	0x03000000 /* i915 */
> -#define   DPLL_FPA01_P1_POST_DIV_MASK	0x00ff0000 /* i915 */
> -#define   DPLL_FPA01_P1_POST_DIV_MASK_PINEVIEW	0x00ff8000 /*
> Pineview */
> -#define   DPLL_LOCK_VLV			(1 << 15)
> -#define   DPLL_INTEGRATED_CRI_CLK_VLV	(1 << 14)
> -#define   DPLL_INTEGRATED_REF_CLK_VLV	(1 << 13)
> -#define   DPLL_SSC_REF_CLK_CHV		(1 << 13)
> -#define   DPLL_PORTC_READY_MASK		(0xf << 4)
> -#define   DPLL_PORTB_READY_MASK		(0xf)
> -
> -#define   DPLL_FPA01_P1_POST_DIV_MASK_I830	0x001f0000
> -
> -/* Additional CHV pll/phy registers */
> -#define DPIO_PHY_STATUS			_MMIO(VLV_DISPLAY_BASE +
> 0x6240)
> -#define   DPLL_PORTD_READY_MASK		(0xf)
> -#define DISPLAY_PHY_CONTROL _MMIO(VLV_DISPLAY_BASE + 0x60100)
> -#define   PHY_CH_POWER_DOWN_OVRD_EN(phy, ch)	(1 << (2 * (phy) + (ch)
> + 27))
> -#define   PHY_LDO_DELAY_0NS			0x0
> -#define   PHY_LDO_DELAY_200NS			0x1
> -#define   PHY_LDO_DELAY_600NS			0x2
> -#define   PHY_LDO_SEQ_DELAY(delay, phy)		((delay) << (2 * (phy)
> + 23))
> -#define   PHY_CH_POWER_DOWN_OVRD(mask, phy, ch)	((mask) << (8
> * (phy) + 4 * (ch) + 11))
> -#define   PHY_CH_SU_PSR				0x1
> -#define   PHY_CH_DEEP_PSR			0x7
> -#define   PHY_CH_POWER_MODE(mode, phy, ch)	((mode) << (6 * (phy)
> + 3 * (ch) + 2))
> -#define   PHY_COM_LANE_RESET_DEASSERT(phy)	(1 << (phy))
> -#define DISPLAY_PHY_STATUS _MMIO(VLV_DISPLAY_BASE + 0x60104)
> -#define   PHY_POWERGOOD(phy)	(((phy) == DPIO_PHY0) ? (1 << 31) : (1
> << 30))
> -#define   PHY_STATUS_CMN_LDO(phy, ch)                   (1 << (6 - (6 * (phy) + 3
> * (ch))))
> -#define   PHY_STATUS_SPLINE_LDO(phy, ch, spline)        (1 << (8 - (6 * (phy) +
> 3 * (ch) + (spline))))
> -
> -/*
> - * The i830 generation, in LVDS mode, defines P1 as the bit number set
> within
> - * this field (only one bit may be set).
> - */
> -#define   DPLL_FPA01_P1_POST_DIV_MASK_I830_LVDS	0x003f0000
> -#define   DPLL_FPA01_P1_POST_DIV_SHIFT	16
> -#define   DPLL_FPA01_P1_POST_DIV_SHIFT_PINEVIEW 15
> -/* i830, required in DVO non-gang */
> -#define   PLL_P2_DIVIDE_BY_4		(1 << 23)
> -#define   PLL_P1_DIVIDE_BY_TWO		(1 << 21) /* i830 */
> -#define   PLL_REF_INPUT_DREFCLK		(0 << 13)
> -#define   PLL_REF_INPUT_TVCLKINA	(1 << 13) /* i830 */
> -#define   PLL_REF_INPUT_TVCLKINBC	(2 << 13) /* SDVO TVCLKIN */
> -#define   PLLB_REF_INPUT_SPREADSPECTRUMIN (3 << 13)
> -#define   PLL_REF_INPUT_MASK		(3 << 13)
> -#define   PLL_LOAD_PULSE_PHASE_SHIFT		9
> -/* Ironlake */
> -# define PLL_REF_SDVO_HDMI_MULTIPLIER_SHIFT     9
> -# define PLL_REF_SDVO_HDMI_MULTIPLIER_MASK      (7 << 9)
> -# define PLL_REF_SDVO_HDMI_MULTIPLIER(x)	(((x) - 1) << 9)
> -# define DPLL_FPA1_P1_POST_DIV_SHIFT            0
> -# define DPLL_FPA1_P1_POST_DIV_MASK             0xff
> -
> -/*
> - * Parallel to Serial Load Pulse phase selection.
> - * Selects the phase for the 10X DPLL clock for the PCIe
> - * digital display port. The range is 4 to 13; 10 or more
> - * is just a flip delay. The default is 6
> - */
> -#define   PLL_LOAD_PULSE_PHASE_MASK		(0xf <<
> PLL_LOAD_PULSE_PHASE_SHIFT)
> -#define   DISPLAY_RATE_SELECT_FPA1		(1 << 8)
> -/*
> - * SDVO multiplier for 945G/GM. Not used on 965.
> - */
> -#define   SDVO_MULTIPLIER_MASK			0x000000ff
> -#define   SDVO_MULTIPLIER_SHIFT_HIRES		4
> -#define   SDVO_MULTIPLIER_SHIFT_VGA		0
> -
> -#define _DPLL_A_MD		0x601c
> -#define _DPLL_B_MD		0x6020
> -#define _CHV_DPLL_C_MD		0x603c
> -#define DPLL_MD(dev_priv, pipe)
> 	_MMIO_BASE_PIPE3(DISPLAY_MMIO_BASE(dev_priv), \
> -						 (pipe), _DPLL_A_MD,
> _DPLL_B_MD, _CHV_DPLL_C_MD)
> -
> -/*
> - * UDI pixel divider, controlling how many pixels are stuffed into a packet.
> - *
> - * Value is pixels minus 1.  Must be set to 1 pixel for SDVO.
> - */
> -#define   DPLL_MD_UDI_DIVIDER_MASK		0x3f000000
> -#define   DPLL_MD_UDI_DIVIDER_SHIFT		24
> -/* UDI pixel divider for VGA, same as DPLL_MD_UDI_DIVIDER_MASK. */
> -#define   DPLL_MD_VGA_UDI_DIVIDER_MASK		0x003f0000
> -#define   DPLL_MD_VGA_UDI_DIVIDER_SHIFT		16
> -/*
> - * SDVO/UDI pixel multiplier.
> - *
> - * SDVO requires that the bus clock rate be between 1 and 2 Ghz, and the
> bus
> - * clock rate is 10 times the DPLL clock.  At low resolution/refresh rate
> - * modes, the bus rate would be below the limits, so SDVO allows for
> stuffing
> - * dummy bytes in the datastream at an increased clock rate, with both
> sides of
> - * the link knowing how many bytes are fill.
> - *
> - * So, for a mode with a dotclock of 65Mhz, we would want to double the
> clock
> - * rate to 130Mhz to get a bus rate of 1.30Ghz.  The DPLL clock rate would
> be
> - * set to 130Mhz, and the SDVO multiplier set to 2x in this register and
> - * through an SDVO command.
> - *
> - * This register field has values of multiplication factor minus 1, with
> - * a maximum multiplier of 5 for SDVO.
> - */
> -#define   DPLL_MD_UDI_MULTIPLIER_MASK		0x00003f00
> -#define   DPLL_MD_UDI_MULTIPLIER_SHIFT		8
> -/*
> - * SDVO/UDI pixel multiplier for VGA, same as
> DPLL_MD_UDI_MULTIPLIER_MASK.
> - * This best be set to the default value (3) or the CRT won't work. No,
> - * I don't entirely understand what this does...
> - */
> -#define   DPLL_MD_VGA_UDI_MULTIPLIER_MASK	0x0000003f
> -#define   DPLL_MD_VGA_UDI_MULTIPLIER_SHIFT	0
> -
> -#define RAWCLK_FREQ_VLV		_MMIO(VLV_DISPLAY_BASE + 0x6024)
> -
>  #define _FPA0	0x6040
>  #define _FPA1	0x6044
>  #define _FPB0	0x6048
> @@ -963,27 +747,11 @@
>  #define RAMCLK_GATE_D		_MMIO(0x6210)		/*
> CRL only */
>  #define DEUC			_MMIO(0x6214)          /* CRL only */
> 
> -#define FW_BLC_SELF_VLV		_MMIO(VLV_DISPLAY_BASE + 0x6500)
> -#define  FW_CSPWRDWNEN		(1 << 15)
> -
> -#define MI_ARB_VLV		_MMIO(VLV_DISPLAY_BASE + 0x6504)
> -
>  #define CZCLK_CDCLK_FREQ_RATIO	_MMIO(VLV_DISPLAY_BASE + 0x6508)
>  #define   CDCLK_FREQ_SHIFT	4
>  #define   CDCLK_FREQ_MASK	(0x1f << CDCLK_FREQ_SHIFT)
>  #define   CZCLK_FREQ_MASK	0xf
> 
> -#define GCI_CONTROL		_MMIO(VLV_DISPLAY_BASE + 0x650C)
> -#define   PFI_CREDIT_63		(9 << 28)		/* chv only */
> -#define   PFI_CREDIT_31		(8 << 28)		/* chv only */
> -#define   PFI_CREDIT(x)		(((x) - 8) << 28)	/* 8-15 */
> -#define   PFI_CREDIT_RESEND	(1 << 27)
> -#define   VGA_FAST_MODE_DISABLE	(1 << 14)
> -
> -#define GMBUSFREQ_VLV		_MMIO(VLV_DISPLAY_BASE + 0x6510)
> -
> -#define PEG_BAND_GAP_DATA	_MMIO(0x14d68)
> -
>  #define BXT_RP_STATE_CAP        _MMIO(0x138170)
>  #define GEN9_RP_STATE_LIMITS	_MMIO(0x138148)
> 
> @@ -1013,19 +781,6 @@
>  #define VLV_CLK_CTL2			_MMIO(0x101104)
>  #define   CLK_CTL2_CZCOUNT_30NS_SHIFT	28
> 
> -/*
> - * Overlay regs
> - */
> -#define OVADD			_MMIO(0x30000)
> -#define DOVSTA			_MMIO(0x30008)
> -#define OC_BUF			(0x3 << 20)
> -#define OGAMC5			_MMIO(0x30010)
> -#define OGAMC4			_MMIO(0x30014)
> -#define OGAMC3			_MMIO(0x30018)
> -#define OGAMC2			_MMIO(0x3001c)
> -#define OGAMC1			_MMIO(0x30020)
> -#define OGAMC0			_MMIO(0x30024)
> -
>  /*
>   * GEN9 clock gating regs
>   */
> @@ -1040,513 +795,6 @@
>  #define   TGL_VRH_GATING_DIS		REG_BIT(31)
>  #define   DPT_GATING_DIS		REG_BIT(22)
> 
> -#define GEN9_CLKGATE_DIS_4		_MMIO(0x4653C)
> -#define   BXT_GMBUS_GATING_DIS		(1 << 14)
> -
> -#define GEN9_CLKGATE_DIS_5		_MMIO(0x46540)
> -#define   DPCE_GATING_DIS		REG_BIT(17)
> -
> -#define _CLKGATE_DIS_PSL_A		0x46520
> -#define _CLKGATE_DIS_PSL_B		0x46524
> -#define _CLKGATE_DIS_PSL_C		0x46528
> -#define   DUPS1_GATING_DIS		(1 << 15)
> -#define   DUPS2_GATING_DIS		(1 << 19)
> -#define   DUPS3_GATING_DIS		(1 << 23)
> -#define   CURSOR_GATING_DIS		REG_BIT(28)
> -#define   DPF_GATING_DIS		(1 << 10)
> -#define   DPF_RAM_GATING_DIS		(1 << 9)
> -#define   DPFR_GATING_DIS		(1 << 8)
> -
> -#define CLKGATE_DIS_PSL(pipe) \
> -	_MMIO_PIPE(pipe, _CLKGATE_DIS_PSL_A, _CLKGATE_DIS_PSL_B)
> -
> -#define _CLKGATE_DIS_PSL_EXT_A		0x4654C
> -#define _CLKGATE_DIS_PSL_EXT_B		0x46550
> -#define   PIPEDMC_GATING_DIS		REG_BIT(12)
> -
> -#define CLKGATE_DIS_PSL_EXT(pipe) \
> -	_MMIO_PIPE(pipe, _CLKGATE_DIS_PSL_EXT_A,
> _CLKGATE_DIS_PSL_EXT_B)
> -
> -/*
> - * Display engine regs
> - */
> -/* Pipe/transcoder A timing regs */
> -#define _TRANS_HTOTAL_A		0x60000
> -#define _TRANS_HTOTAL_B		0x61000
> -#define TRANS_HTOTAL(dev_priv, trans)	_MMIO_TRANS2(dev_priv,
> (trans), _TRANS_HTOTAL_A)
> -#define   HTOTAL_MASK			REG_GENMASK(31, 16)
> -#define   HTOTAL(htotal)		REG_FIELD_PREP(HTOTAL_MASK,
> (htotal))
> -#define   HACTIVE_MASK			REG_GENMASK(15, 0)
> -#define   HACTIVE(hdisplay)		REG_FIELD_PREP(HACTIVE_MASK,
> (hdisplay))
> -
> -#define _TRANS_HBLANK_A		0x60004
> -#define _TRANS_HBLANK_B		0x61004
> -#define TRANS_HBLANK(dev_priv, trans)	_MMIO_TRANS2(dev_priv,
> (trans), _TRANS_HBLANK_A)
> -#define   HBLANK_END_MASK		REG_GENMASK(31, 16)
> -#define   HBLANK_END(hblank_end)
> 	REG_FIELD_PREP(HBLANK_END_MASK, (hblank_end))
> -#define   HBLANK_START_MASK		REG_GENMASK(15, 0)
> -#define   HBLANK_START(hblank_start)
> 	REG_FIELD_PREP(HBLANK_START_MASK, (hblank_start))
> -
> -#define _TRANS_HSYNC_A		0x60008
> -#define _TRANS_HSYNC_B		0x61008
> -#define TRANS_HSYNC(dev_priv, trans)	_MMIO_TRANS2(dev_priv,
> (trans), _TRANS_HSYNC_A)
> -#define   HSYNC_END_MASK		REG_GENMASK(31, 16)
> -#define   HSYNC_END(hsync_end)
> 	REG_FIELD_PREP(HSYNC_END_MASK, (hsync_end))
> -#define   HSYNC_START_MASK		REG_GENMASK(15, 0)
> -#define   HSYNC_START(hsync_start)
> 	REG_FIELD_PREP(HSYNC_START_MASK, (hsync_start))
> -
> -#define _TRANS_VTOTAL_A		0x6000c
> -#define _TRANS_VTOTAL_B		0x6100c
> -#define TRANS_VTOTAL(dev_priv, trans)	_MMIO_TRANS2(dev_priv,
> (trans), _TRANS_VTOTAL_A)
> -#define   VTOTAL_MASK			REG_GENMASK(31, 16)
> -#define   VTOTAL(vtotal)		REG_FIELD_PREP(VTOTAL_MASK,
> (vtotal))
> -#define   VACTIVE_MASK			REG_GENMASK(15, 0)
> -#define   VACTIVE(vdisplay)		REG_FIELD_PREP(VACTIVE_MASK,
> (vdisplay))
> -
> -#define _TRANS_VBLANK_A		0x60010
> -#define _TRANS_VBLANK_B		0x61010
> -#define TRANS_VBLANK(dev_priv, trans)	_MMIO_TRANS2(dev_priv,
> (trans), _TRANS_VBLANK_A)
> -#define   VBLANK_END_MASK		REG_GENMASK(31, 16)
> -#define   VBLANK_END(vblank_end)
> 	REG_FIELD_PREP(VBLANK_END_MASK, (vblank_end))
> -#define   VBLANK_START_MASK		REG_GENMASK(15, 0)
> -#define   VBLANK_START(vblank_start)
> 	REG_FIELD_PREP(VBLANK_START_MASK, (vblank_start))
> -
> -#define _TRANS_VSYNC_A		0x60014
> -#define _TRANS_VSYNC_B		0x61014
> -#define TRANS_VSYNC(dev_priv, trans)	_MMIO_TRANS2(dev_priv,
> (trans), _TRANS_VSYNC_A)
> -#define   VSYNC_END_MASK		REG_GENMASK(31, 16)
> -#define   VSYNC_END(vsync_end)
> 	REG_FIELD_PREP(VSYNC_END_MASK, (vsync_end))
> -#define   VSYNC_START_MASK		REG_GENMASK(15, 0)
> -#define   VSYNC_START(vsync_start)
> 	REG_FIELD_PREP(VSYNC_START_MASK, (vsync_start))
> -
> -#define _PIPEASRC		0x6001c
> -#define _PIPEBSRC		0x6101c
> -#define PIPESRC(dev_priv, pipe)		_MMIO_TRANS2(dev_priv,
> (pipe), _PIPEASRC)
> -#define   PIPESRC_WIDTH_MASK	REG_GENMASK(31, 16)
> -#define   PIPESRC_WIDTH(w)	REG_FIELD_PREP(PIPESRC_WIDTH_MASK,
> (w))
> -#define   PIPESRC_HEIGHT_MASK	REG_GENMASK(15, 0)
> -#define   PIPESRC_HEIGHT(h)	REG_FIELD_PREP(PIPESRC_HEIGHT_MASK,
> (h))
> -
> -#define _BCLRPAT_A		0x60020
> -#define _BCLRPAT_B		0x61020
> -#define BCLRPAT(dev_priv, trans)		_MMIO_TRANS2(dev_priv,
> (trans), _BCLRPAT_A)
> -
> -#define _TRANS_VSYNCSHIFT_A	0x60028
> -#define _TRANS_VSYNCSHIFT_B	0x61028
> -#define TRANS_VSYNCSHIFT(dev_priv, trans)	_MMIO_TRANS2(dev_priv,
> (trans), _TRANS_VSYNCSHIFT_A)
> -
> -#define _TRANS_MULT_A		0x6002c
> -#define _TRANS_MULT_B		0x6102c
> -#define TRANS_MULT(dev_priv, trans)	_MMIO_TRANS2(dev_priv, (trans),
> _TRANS_MULT_A)
> -
> -/* Hotplug control (945+ only) */
> -#define PORT_HOTPLUG_EN(dev_priv)
> 	_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61110)
> -#define   PORTB_HOTPLUG_INT_EN			(1 << 29)
> -#define   PORTC_HOTPLUG_INT_EN			(1 << 28)
> -#define   PORTD_HOTPLUG_INT_EN			(1 << 27)
> -#define   SDVOB_HOTPLUG_INT_EN			(1 << 26)
> -#define   SDVOC_HOTPLUG_INT_EN			(1 << 25)
> -#define   TV_HOTPLUG_INT_EN			(1 << 18)
> -#define   CRT_HOTPLUG_INT_EN			(1 << 9)
> -#define HOTPLUG_INT_EN_MASK
> 	(PORTB_HOTPLUG_INT_EN | \
> -						 PORTC_HOTPLUG_INT_EN | \
> -						 PORTD_HOTPLUG_INT_EN |
> \
> -						 SDVOC_HOTPLUG_INT_EN |
> \
> -						 SDVOB_HOTPLUG_INT_EN |
> \
> -						 CRT_HOTPLUG_INT_EN)
> -#define   CRT_HOTPLUG_FORCE_DETECT		(1 << 3)
> -#define CRT_HOTPLUG_ACTIVATION_PERIOD_32	(0 << 8)
> -/* must use period 64 on GM45 according to docs */
> -#define CRT_HOTPLUG_ACTIVATION_PERIOD_64	(1 << 8)
> -#define CRT_HOTPLUG_DAC_ON_TIME_2M		(0 << 7)
> -#define CRT_HOTPLUG_DAC_ON_TIME_4M		(1 << 7)
> -#define CRT_HOTPLUG_VOLTAGE_COMPARE_40		(0 << 5)
> -#define CRT_HOTPLUG_VOLTAGE_COMPARE_50		(1 << 5)
> -#define CRT_HOTPLUG_VOLTAGE_COMPARE_60		(2 << 5)
> -#define CRT_HOTPLUG_VOLTAGE_COMPARE_70		(3 << 5)
> -#define CRT_HOTPLUG_VOLTAGE_COMPARE_MASK	(3 << 5)
> -#define CRT_HOTPLUG_DETECT_DELAY_1G		(0 << 4)
> -#define CRT_HOTPLUG_DETECT_DELAY_2G		(1 << 4)
> -#define CRT_HOTPLUG_DETECT_VOLTAGE_325MV	(0 << 2)
> -#define CRT_HOTPLUG_DETECT_VOLTAGE_475MV	(1 << 2)
> -
> -#define PORT_HOTPLUG_STAT(dev_priv)
> 	_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61114)
> -/* HDMI/DP bits are g4x+ */
> -#define   PORTD_HOTPLUG_LIVE_STATUS_G4X		(1 << 27)
> -#define   PORTC_HOTPLUG_LIVE_STATUS_G4X		(1 << 28)
> -#define   PORTB_HOTPLUG_LIVE_STATUS_G4X		(1 << 29)
> -#define   PORTD_HOTPLUG_INT_STATUS		(3 << 21)
> -#define   PORTD_HOTPLUG_INT_LONG_PULSE		(2 << 21)
> -#define   PORTD_HOTPLUG_INT_SHORT_PULSE		(1 << 21)
> -#define   PORTC_HOTPLUG_INT_STATUS		(3 << 19)
> -#define   PORTC_HOTPLUG_INT_LONG_PULSE		(2 << 19)
> -#define   PORTC_HOTPLUG_INT_SHORT_PULSE		(1 << 19)
> -#define   PORTB_HOTPLUG_INT_STATUS		(3 << 17)
> -#define   PORTB_HOTPLUG_INT_LONG_PULSE		(2 << 17)
> -#define   PORTB_HOTPLUG_INT_SHORT_PLUSE		(1 << 17)
> -/* CRT/TV common between gen3+ */
> -#define   CRT_HOTPLUG_INT_STATUS		(1 << 11)
> -#define   TV_HOTPLUG_INT_STATUS			(1 << 10)
> -#define   CRT_HOTPLUG_MONITOR_MASK		(3 << 8)
> -#define   CRT_HOTPLUG_MONITOR_COLOR		(3 << 8)
> -#define   CRT_HOTPLUG_MONITOR_MONO		(2 << 8)
> -#define   CRT_HOTPLUG_MONITOR_NONE		(0 << 8)
> -#define   DP_AUX_CHANNEL_D_INT_STATUS_G4X	(1 << 6)
> -#define   DP_AUX_CHANNEL_C_INT_STATUS_G4X	(1 << 5)
> -#define   DP_AUX_CHANNEL_B_INT_STATUS_G4X	(1 << 4)
> -#define   DP_AUX_CHANNEL_MASK_INT_STATUS_G4X	(7 << 4)
> -
> -/* SDVO is different across gen3/4 */
> -#define   SDVOC_HOTPLUG_INT_STATUS_G4X		(1 << 3)
> -#define   SDVOB_HOTPLUG_INT_STATUS_G4X		(1 << 2)
> -/*
> - * Bspec seems to be seriously misleaded about the SDVO hpd bits on
> i965g/gm,
> - * since reality corrobates that they're the same as on gen3. But keep these
> - * bits here (and the comment!) to help any other lost wanderers back
> onto the
> - * right tracks.
> - */
> -#define   SDVOC_HOTPLUG_INT_STATUS_I965		(3 << 4)
> -#define   SDVOB_HOTPLUG_INT_STATUS_I965		(3 << 2)
> -#define   SDVOC_HOTPLUG_INT_STATUS_I915		(1 << 7)
> -#define   SDVOB_HOTPLUG_INT_STATUS_I915		(1 << 6)
> -#define   HOTPLUG_INT_STATUS_G4X		(CRT_HOTPLUG_INT_STATUS
> | \
> -
> SDVOB_HOTPLUG_INT_STATUS_G4X | \
> -
> SDVOC_HOTPLUG_INT_STATUS_G4X | \
> -
> PORTB_HOTPLUG_INT_STATUS | \
> -
> PORTC_HOTPLUG_INT_STATUS | \
> -
> PORTD_HOTPLUG_INT_STATUS)
> -
> -#define HOTPLUG_INT_STATUS_I915
> 	(CRT_HOTPLUG_INT_STATUS | \
> -
> SDVOB_HOTPLUG_INT_STATUS_I915 | \
> -
> SDVOC_HOTPLUG_INT_STATUS_I915 | \
> -
> PORTB_HOTPLUG_INT_STATUS | \
> -
> PORTC_HOTPLUG_INT_STATUS | \
> -
> PORTD_HOTPLUG_INT_STATUS)
> -
> -/* SDVO and HDMI port control.
> - * The same register may be used for SDVO or HDMI */
> -#define _GEN3_SDVOB	0x61140
> -#define _GEN3_SDVOC	0x61160
> -#define GEN3_SDVOB	_MMIO(_GEN3_SDVOB)
> -#define GEN3_SDVOC	_MMIO(_GEN3_SDVOC)
> -#define GEN4_HDMIB	GEN3_SDVOB
> -#define GEN4_HDMIC	GEN3_SDVOC
> -#define VLV_HDMIB	_MMIO(VLV_DISPLAY_BASE + 0x61140)
> -#define VLV_HDMIC	_MMIO(VLV_DISPLAY_BASE + 0x61160)
> -#define CHV_HDMID	_MMIO(VLV_DISPLAY_BASE + 0x6116C)
> -#define PCH_SDVOB	_MMIO(0xe1140)
> -#define PCH_HDMIB	PCH_SDVOB
> -#define PCH_HDMIC	_MMIO(0xe1150)
> -#define PCH_HDMID	_MMIO(0xe1160)
> -
> -#define PORT_DFT_I9XX				_MMIO(0x61150)
> -#define   DC_BALANCE_RESET			(1 << 25)
> -#define PORT_DFT2_G4X(dev_priv)
> 	_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61154)
> -#define   DC_BALANCE_RESET_VLV			(1 << 31)
> -#define   PIPE_SCRAMBLE_RESET_MASK		((1 << 14) | (0x3 <<
> 0))
> -#define   PIPE_C_SCRAMBLE_RESET			REG_BIT(14) /* chv */
> -#define   PIPE_B_SCRAMBLE_RESET			REG_BIT(1)
> -#define   PIPE_A_SCRAMBLE_RESET			REG_BIT(0)
> -
> -/* Gen 3 SDVO bits: */
> -#define   SDVO_ENABLE				(1 << 31)
> -#define   SDVO_PIPE_SEL_SHIFT			30
> -#define   SDVO_PIPE_SEL_MASK			(1 << 30)
> -#define   SDVO_PIPE_SEL(pipe)			((pipe) << 30)
> -#define   SDVO_STALL_SELECT			(1 << 29)
> -#define   SDVO_INTERRUPT_ENABLE			(1 << 26)
> -/*
> - * 915G/GM SDVO pixel multiplier.
> - * Programmed value is multiplier - 1, up to 5x.
> - * \sa DPLL_MD_UDI_MULTIPLIER_MASK
> - */
> -#define   SDVO_PORT_MULTIPLY_MASK		(7 << 23)
> -#define   SDVO_PORT_MULTIPLY_SHIFT		23
> -#define   SDVO_PHASE_SELECT_MASK		(15 << 19)
> -#define   SDVO_PHASE_SELECT_DEFAULT		(6 << 19)
> -#define   SDVO_CLOCK_OUTPUT_INVERT		(1 << 18)
> -#define   SDVOC_GANG_MODE			(1 << 16) /* Port C
> only */
> -#define   SDVO_BORDER_ENABLE			(1 << 7) /* SDVO only
> */
> -#define   SDVOB_PCIE_CONCURRENCY		(1 << 3) /* Port B only */
> -#define   SDVO_DETECTED				(1 << 2)
> -/* Bits to be preserved when writing */
> -#define   SDVOB_PRESERVE_MASK ((1 << 17) | (1 << 16) | (1 << 14) | \
> -			       SDVO_INTERRUPT_ENABLE)
> -#define   SDVOC_PRESERVE_MASK ((1 << 17) | SDVO_INTERRUPT_ENABLE)
> -
> -/* Gen 4 SDVO/HDMI bits: */
> -#define   SDVO_COLOR_FORMAT_8bpc		(0 << 26)
> -#define   SDVO_COLOR_FORMAT_MASK		(7 << 26)
> -#define   SDVO_ENCODING_SDVO			(0 << 10)
> -#define   SDVO_ENCODING_HDMI			(2 << 10)
> -#define   HDMI_MODE_SELECT_HDMI			(1 << 9) /* HDMI only
> */
> -#define   HDMI_MODE_SELECT_DVI			(0 << 9) /* HDMI only
> */
> -#define   HDMI_COLOR_RANGE_16_235		(1 << 8) /* HDMI only
> */
> -#define   HDMI_AUDIO_ENABLE			(1 << 6) /* HDMI only
> */
> -/* VSYNC/HSYNC bits new with 965, default is to be set */
> -#define   SDVO_VSYNC_ACTIVE_HIGH		(1 << 4)
> -#define   SDVO_HSYNC_ACTIVE_HIGH		(1 << 3)
> -
> -/* Gen 5 (IBX) SDVO/HDMI bits: */
> -#define   HDMI_COLOR_FORMAT_12bpc		(3 << 26) /* HDMI
> only */
> -#define   SDVOB_HOTPLUG_ENABLE			(1 << 23) /* SDVO
> only */
> -
> -/* Gen 6 (CPT) SDVO/HDMI bits: */
> -#define   SDVO_PIPE_SEL_SHIFT_CPT		29
> -#define   SDVO_PIPE_SEL_MASK_CPT		(3 << 29)
> -#define   SDVO_PIPE_SEL_CPT(pipe)		((pipe) << 29)
> -
> -/* CHV SDVO/HDMI bits: */
> -#define   SDVO_PIPE_SEL_SHIFT_CHV		24
> -#define   SDVO_PIPE_SEL_MASK_CHV		(3 << 24)
> -#define   SDVO_PIPE_SEL_CHV(pipe)		((pipe) << 24)
> -
> -/* Video Data Island Packet control */
> -#define VIDEO_DIP_DATA		_MMIO(0x61178)
> -/* Read the description of VIDEO_DIP_DATA (before Haswell) or
> VIDEO_DIP_ECC
> - * (Haswell and newer) to see which VIDEO_DIP_DATA byte corresponds to
> each byte
> - * of the infoframe structure specified by CEA-861. */
> -#define   VIDEO_DIP_DATA_SIZE	32
> -#define   VIDEO_DIP_ASYNC_DATA_SIZE	36
> -#define   VIDEO_DIP_GMP_DATA_SIZE	36
> -#define   VIDEO_DIP_VSC_DATA_SIZE	36
> -#define   VIDEO_DIP_PPS_DATA_SIZE	132
> -#define VIDEO_DIP_CTL		_MMIO(0x61170)
> -/* Pre HSW: */
> -#define   VIDEO_DIP_ENABLE		(1 << 31)
> -#define   VIDEO_DIP_PORT(port)		((port) << 29)
> -#define   VIDEO_DIP_PORT_MASK		(3 << 29)
> -#define   VIDEO_DIP_ENABLE_GCP		(1 << 25) /* ilk+ */
> -#define   VIDEO_DIP_ENABLE_AVI		(1 << 21)
> -#define   VIDEO_DIP_ENABLE_VENDOR	(2 << 21)
> -#define   VIDEO_DIP_ENABLE_GAMUT	(4 << 21) /* ilk+ */
> -#define   VIDEO_DIP_ENABLE_SPD		(8 << 21)
> -#define   VIDEO_DIP_SELECT_AVI		(0 << 19)
> -#define   VIDEO_DIP_SELECT_VENDOR	(1 << 19)
> -#define   VIDEO_DIP_SELECT_GAMUT	(2 << 19)
> -#define   VIDEO_DIP_SELECT_SPD		(3 << 19)
> -#define   VIDEO_DIP_SELECT_MASK		(3 << 19)
> -#define   VIDEO_DIP_FREQ_ONCE		(0 << 16)
> -#define   VIDEO_DIP_FREQ_VSYNC		(1 << 16)
> -#define   VIDEO_DIP_FREQ_2VSYNC		(2 << 16)
> -#define   VIDEO_DIP_FREQ_MASK		(3 << 16)
> -/* HSW and later: */
> -#define   VIDEO_DIP_ENABLE_DRM_GLK	(1 << 28)
> -#define   PSR_VSC_BIT_7_SET		(1 << 27)
> -#define   VSC_SELECT_MASK		(0x3 << 25)
> -#define   VSC_SELECT_SHIFT		25
> -#define   VSC_DIP_HW_HEA_DATA		(0 << 25)
> -#define   VSC_DIP_HW_HEA_SW_DATA	(1 << 25)
> -#define   VSC_DIP_HW_DATA_SW_HEA	(2 << 25)
> -#define   VSC_DIP_SW_HEA_DATA		(3 << 25)
> -#define   VDIP_ENABLE_PPS		(1 << 24)
> -#define   VIDEO_DIP_ENABLE_VSC_HSW	(1 << 20)
> -#define   VIDEO_DIP_ENABLE_GCP_HSW	(1 << 16)
> -#define   VIDEO_DIP_ENABLE_AVI_HSW	(1 << 12)
> -#define   VIDEO_DIP_ENABLE_VS_HSW	(1 << 8)
> -#define   VIDEO_DIP_ENABLE_GMP_HSW	(1 << 4)
> -#define   VIDEO_DIP_ENABLE_SPD_HSW	(1 << 0)
> -/* ADL and later: */
> -#define   VIDEO_DIP_ENABLE_AS_ADL	REG_BIT(23)
> -
> -/* Panel fitting */
> -#define PFIT_CONTROL(dev_priv)
> 	_MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61230)
> -#define   PFIT_ENABLE			REG_BIT(31)
> -#define   PFIT_PIPE_MASK		REG_GENMASK(30, 29) /* 965+ */
> -#define   PFIT_PIPE(pipe)		REG_FIELD_PREP(PFIT_PIPE_MASK,
> (pipe))
> -#define   PFIT_SCALING_MASK		REG_GENMASK(28, 26) /* 965+ */
> -#define   PFIT_SCALING_AUTO
> 	REG_FIELD_PREP(PFIT_SCALING_MASK, 0)
> -#define   PFIT_SCALING_PROGRAMMED
> 	REG_FIELD_PREP(PFIT_SCALING_MASK, 1)
> -#define   PFIT_SCALING_PILLAR
> 	REG_FIELD_PREP(PFIT_SCALING_MASK, 2)
> -#define   PFIT_SCALING_LETTER
> 	REG_FIELD_PREP(PFIT_SCALING_MASK, 3)
> -#define   PFIT_FILTER_MASK		REG_GENMASK(25, 24) /* 965+ */
> -#define   PFIT_FILTER_FUZZY		REG_FIELD_PREP(PFIT_FILTER_MASK,
> 0)
> -#define   PFIT_FILTER_CRISP		REG_FIELD_PREP(PFIT_FILTER_MASK,
> 1)
> -#define   PFIT_FILTER_MEDIAN
> 	REG_FIELD_PREP(PFIT_FILTER_MASK, 2)
> -#define   PFIT_VERT_INTERP_MASK		REG_GENMASK(11, 10) /*
> pre-965 */
> -#define   PFIT_VERT_INTERP_BILINEAR
> 	REG_FIELD_PREP(PFIT_VERT_INTERP_MASK, 1)
> -#define   PFIT_VERT_AUTO_SCALE		REG_BIT(9) /* pre-965 */
> -#define   PFIT_HORIZ_INTERP_MASK	REG_GENMASK(7, 6) /* pre-965 */
> -#define   PFIT_HORIZ_INTERP_BILINEAR
> 	REG_FIELD_PREP(PFIT_HORIZ_INTERP_MASK, 1)
> -#define   PFIT_HORIZ_AUTO_SCALE		REG_BIT(5) /* pre-965 */
> -#define   PFIT_PANEL_8TO6_DITHER_ENABLE	REG_BIT(3) /* pre-965 */
> -
> -#define PFIT_PGM_RATIOS(dev_priv)
> _MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61234)
> -#define   PFIT_VERT_SCALE_MASK		REG_GENMASK(31, 20) /*
> pre-965 */
> -#define   PFIT_VERT_SCALE(x)
> 	REG_FIELD_PREP(PFIT_VERT_SCALE_MASK, (x))
> -#define   PFIT_HORIZ_SCALE_MASK		REG_GENMASK(15, 4) /* pre-
> 965 */
> -#define   PFIT_HORIZ_SCALE(x)
> 	REG_FIELD_PREP(PFIT_HORIZ_SCALE_MASK, (x))
> -#define   PFIT_VERT_SCALE_MASK_965	REG_GENMASK(28, 16) /*
> 965+ */
> -#define   PFIT_HORIZ_SCALE_MASK_965	REG_GENMASK(12, 0) /*
> 965+ */
> -
> -#define PFIT_AUTO_RATIOS(dev_priv)
> _MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61238)
> -
> -#define PCH_GTC_CTL		_MMIO(0xe7000)
> -#define   PCH_GTC_ENABLE	(1 << 31)
> -
> -/* Display Port */
> -#define DP_A			_MMIO(0x64000) /* eDP */
> -#define DP_B			_MMIO(0x64100)
> -#define DP_C			_MMIO(0x64200)
> -#define DP_D			_MMIO(0x64300)
> -#define VLV_DP_B		_MMIO(VLV_DISPLAY_BASE + 0x64100)
> -#define VLV_DP_C		_MMIO(VLV_DISPLAY_BASE + 0x64200)
> -#define CHV_DP_D		_MMIO(VLV_DISPLAY_BASE + 0x64300)
> -#define   DP_PORT_EN			REG_BIT(31)
> -#define   DP_PIPE_SEL_MASK		REG_GENMASK(30, 30)
> -#define   DP_PIPE_SEL(pipe)		REG_FIELD_PREP(DP_PIPE_SEL_MASK,
> (pipe))
> -#define   DP_PIPE_SEL_MASK_IVB		REG_GENMASK(30, 29)
> -#define   DP_PIPE_SEL_IVB(pipe)
> 	REG_FIELD_PREP(DP_PIPE_SEL_MASK_IVB, (pipe))
> -#define   DP_PIPE_SEL_SHIFT_CHV		16
> -#define   DP_PIPE_SEL_MASK_CHV		REG_GENMASK(17, 16)
> -#define   DP_PIPE_SEL_CHV(pipe)
> 	REG_FIELD_PREP(DP_PIPE_SEL_MASK_CHV, (pipe))
> -#define   DP_LINK_TRAIN_MASK		REG_GENMASK(29, 28)
> -#define   DP_LINK_TRAIN_PAT_1
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 0)
> -#define   DP_LINK_TRAIN_PAT_2
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 1)
> -#define   DP_LINK_TRAIN_PAT_IDLE
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 2)
> -#define   DP_LINK_TRAIN_OFF
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK, 3)
> -#define   DP_LINK_TRAIN_MASK_CPT	REG_GENMASK(10, 8)
> -#define   DP_LINK_TRAIN_PAT_1_CPT
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 0)
> -#define   DP_LINK_TRAIN_PAT_2_CPT
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 1)
> -#define   DP_LINK_TRAIN_PAT_IDLE_CPT
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 2)
> -#define   DP_LINK_TRAIN_OFF_CPT
> 	REG_FIELD_PREP(DP_LINK_TRAIN_MASK_CPT, 3)
> -#define   DP_VOLTAGE_MASK		REG_GENMASK(27, 25)
> -#define   DP_VOLTAGE_0_4
> 	REG_FIELD_PREP(DP_VOLTAGE_MASK, 0)
> -#define   DP_VOLTAGE_0_6
> 	REG_FIELD_PREP(DP_VOLTAGE_MASK, 1)
> -#define   DP_VOLTAGE_0_8
> 	REG_FIELD_PREP(DP_VOLTAGE_MASK, 2)
> -#define   DP_VOLTAGE_1_2
> 	REG_FIELD_PREP(DP_VOLTAGE_MASK, 3)
> -#define   DP_PRE_EMPHASIS_MASK		REG_GENMASK(24, 22)
> -#define   DP_PRE_EMPHASIS_0
> 	REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 0)
> -#define   DP_PRE_EMPHASIS_3_5
> 	REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 1)
> -#define   DP_PRE_EMPHASIS_6
> 	REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 2)
> -#define   DP_PRE_EMPHASIS_9_5
> 	REG_FIELD_PREP(DP_PRE_EMPHASIS_MASK, 3)
> -#define   DP_PORT_WIDTH_MASK		REG_GENMASK(21, 19)
> -#define   DP_PORT_WIDTH(width)
> 	REG_FIELD_PREP(DP_PORT_WIDTH_MASK, (width) - 1)
> -#define   DP_ENHANCED_FRAMING		REG_BIT(18)
> -#define   EDP_PLL_FREQ_MASK		REG_GENMASK(17, 16)
> -#define   EDP_PLL_FREQ_270MHZ
> 	REG_FIELD_PREP(EDP_PLL_FREQ_MASK, 0)
> -#define   EDP_PLL_FREQ_162MHZ
> 	REG_FIELD_PREP(EDP_PLL_FREQ_MASK, 1)
> -#define   DP_PORT_REVERSAL		REG_BIT(15)
> -#define   EDP_PLL_ENABLE		REG_BIT(14)
> -#define   DP_CLOCK_OUTPUT_ENABLE	REG_BIT(13)
> -#define   DP_SCRAMBLING_DISABLE		REG_BIT(12)
> -#define   DP_SCRAMBLING_DISABLE_ILK	REG_BIT(7)
> -#define   DP_COLOR_RANGE_16_235		REG_BIT(8)
> -#define   DP_AUDIO_OUTPUT_ENABLE	REG_BIT(6)
> -#define   DP_SYNC_VS_HIGH		REG_BIT(4)
> -#define   DP_SYNC_HS_HIGH		REG_BIT(3)
> -#define   DP_DETECTED			REG_BIT(2)
> -
> -/*
> - * Computing GMCH M and N values for the Display Port link
> - *
> - * GMCH M/N = dot clock * bytes per pixel / ls_clk * # of lanes
> - *
> - * ls_clk (we assume) is the DP link clock (1.62 or 2.7 GHz)
> - *
> - * The GMCH value is used internally
> - *
> - * bytes_per_pixel is the number of bytes coming out of the plane,
> - * which is after the LUTs, so we want the bytes for our color format.
> - * For our current usage, this is always 3, one byte for R, G and B.
> - */
> -#define _PIPEA_DATA_M_G4X	0x70050
> -#define _PIPEB_DATA_M_G4X	0x71050
> -#define PIPE_DATA_M_G4X(pipe) _MMIO_PIPE(pipe, _PIPEA_DATA_M_G4X,
> _PIPEB_DATA_M_G4X)
> -/* Transfer unit size for display port - 1, default is 0x3f (for TU size 64) */
> -#define  TU_SIZE_MASK		REG_GENMASK(30, 25)
> -#define  TU_SIZE(x)		REG_FIELD_PREP(TU_SIZE_MASK, (x) - 1) /*
> default size 64 */
> -#define  DATA_LINK_M_N_MASK	REG_GENMASK(23, 0)
> -#define  DATA_LINK_N_MAX	(0x800000)
> -
> -#define _PIPEA_DATA_N_G4X	0x70054
> -#define _PIPEB_DATA_N_G4X	0x71054
> -#define PIPE_DATA_N_G4X(pipe) _MMIO_PIPE(pipe, _PIPEA_DATA_N_G4X,
> _PIPEB_DATA_N_G4X)
> -
> -/*
> - * Computing Link M and N values for the Display Port link
> - *
> - * Link M / N = pixel_clock / ls_clk
> - *
> - * (the DP spec calls pixel_clock the 'strm_clk')
> - *
> - * The Link value is transmitted in the Main Stream
> - * Attributes and VB-ID.
> - */
> -#define _PIPEA_LINK_M_G4X	0x70060
> -#define _PIPEB_LINK_M_G4X	0x71060
> -#define PIPE_LINK_M_G4X(pipe) _MMIO_PIPE(pipe, _PIPEA_LINK_M_G4X,
> _PIPEB_LINK_M_G4X)
> -
> -#define _PIPEA_LINK_N_G4X	0x70064
> -#define _PIPEB_LINK_N_G4X	0x71064
> -#define PIPE_LINK_N_G4X(pipe) _MMIO_PIPE(pipe, _PIPEA_LINK_N_G4X,
> _PIPEB_LINK_N_G4X)
> -
> -/* Pipe A */
> -#define _PIPEADSL		0x70000
> -#define PIPEDSL(dev_priv, pipe)		_MMIO_PIPE2(dev_priv, pipe,
> _PIPEADSL)
> -#define   PIPEDSL_CURR_FIELD	REG_BIT(31) /* ctg+ */
> -#define   PIPEDSL_LINE_MASK	REG_GENMASK(19, 0)
> -
> -#define _TRANSACONF		0x70008
> -#define TRANSCONF(dev_priv, trans)	_MMIO_PIPE2(dev_priv, (trans),
> _TRANSACONF)
> -#define   TRANSCONF_ENABLE			REG_BIT(31)
> -#define   TRANSCONF_DOUBLE_WIDE			REG_BIT(30) /* pre-
> i965 */
> -#define   TRANSCONF_STATE_ENABLE			REG_BIT(30) /* i965+
> */
> -#define   TRANSCONF_DSI_PLL_LOCKED		REG_BIT(29) /* vlv &
> pipe A only */
> -#define   TRANSCONF_FRAME_START_DELAY_MASK	REG_GENMASK(28,
> 27) /* pre-hsw */
> -#define   TRANSCONF_FRAME_START_DELAY(x)
> 	REG_FIELD_PREP(TRANSCONF_FRAME_START_DELAY_MASK, (x)) /*
> pre-hsw: 0-3 */
> -#define   TRANSCONF_PIPE_LOCKED			REG_BIT(25)
> -#define   TRANSCONF_FORCE_BORDER			REG_BIT(25)
> -#define   TRANSCONF_GAMMA_MODE_MASK_I9XX		REG_BIT(24)
> /* gmch */
> -#define   TRANSCONF_GAMMA_MODE_MASK_ILK
> 	REG_GENMASK(25, 24) /* ilk-ivb */
> -#define   TRANSCONF_GAMMA_MODE_8BIT
> 	REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK, 0)
> -#define   TRANSCONF_GAMMA_MODE_10BIT
> 	REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK, 1)
> -#define   TRANSCONF_GAMMA_MODE_12BIT
> 	REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK_ILK, 2) /* ilk-
> ivb */
> -#define   TRANSCONF_GAMMA_MODE_SPLIT
> 	REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK_ILK, 3) /* ivb
> */
> -#define   TRANSCONF_GAMMA_MODE(x)
> 	REG_FIELD_PREP(TRANSCONF_GAMMA_MODE_MASK_ILK, (x)) /*
> pass in GAMMA_MODE_MODE_* */
> -#define   TRANSCONF_INTERLACE_MASK		REG_GENMASK(23,
> 21) /* gen3+ */
> -#define   TRANSCONF_INTERLACE_PROGRESSIVE
> 	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 0)
> -#define   TRANSCONF_INTERLACE_W_SYNC_SHIFT_PANEL
> 	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 4) /* gen4 only */
> -#define   TRANSCONF_INTERLACE_W_SYNC_SHIFT
> 	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 5) /* gen4 only */
> -#define   TRANSCONF_INTERLACE_W_FIELD_INDICATION
> 	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 6)
> -#define   TRANSCONF_INTERLACE_FIELD_0_ONLY
> 	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK, 7) /* gen3 only */
> -/*
> - * ilk+: PF/D=progressive fetch/display, IF/D=interlaced fetch/display,
> - * DBL=power saving pixel doubling, PF-ID* requires panel fitter
> - */
> -#define   TRANSCONF_INTERLACE_MASK_ILK		REG_GENMASK(23,
> 21) /* ilk+ */
> -#define   TRANSCONF_INTERLACE_MASK_HSW
> 	REG_GENMASK(22, 21) /* hsw+ */
> -#define   TRANSCONF_INTERLACE_PF_PD_ILK
> 	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 0)
> -#define   TRANSCONF_INTERLACE_PF_ID_ILK
> 	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 1)
> -#define   TRANSCONF_INTERLACE_IF_ID_ILK
> 	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 3)
> -#define   TRANSCONF_INTERLACE_IF_ID_DBL_ILK
> 	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 4) /* ilk/snb
> only */
> -#define   TRANSCONF_INTERLACE_PF_ID_DBL_ILK
> 	REG_FIELD_PREP(TRANSCONF_INTERLACE_MASK_ILK, 5) /* ilk/snb
> only */
> -#define   TRANSCONF_REFRESH_RATE_ALT_ILK		REG_BIT(20)
> -#define   TRANSCONF_MSA_TIMING_DELAY_MASK	REG_GENMASK(19,
> 18) /* ilk/snb/ivb */
> -#define   TRANSCONF_MSA_TIMING_DELAY(x)
> 	REG_FIELD_PREP(TRANSCONF_MSA_TIMING_DELAY_MASK, (x))
> -#define   TRANSCONF_CXSR_DOWNCLOCK		REG_BIT(16)
> -#define   TRANSCONF_WGC_ENABLE			REG_BIT(15) /*
> vlv/chv only */
> -#define   TRANSCONF_REFRESH_RATE_ALT_VLV		REG_BIT(14)
> -#define   TRANSCONF_COLOR_RANGE_SELECT		REG_BIT(13)
> -#define   TRANSCONF_OUTPUT_COLORSPACE_MASK	REG_GENMASK(12,
> 11) /* ilk-ivb */
> -#define   TRANSCONF_OUTPUT_COLORSPACE_RGB
> 	REG_FIELD_PREP(TRANSCONF_OUTPUT_COLORSPACE_MASK, 0) /*
> ilk-ivb */
> -#define   TRANSCONF_OUTPUT_COLORSPACE_YUV601
> 	REG_FIELD_PREP(TRANSCONF_OUTPUT_COLORSPACE_MASK, 1) /*
> ilk-ivb */
> -#define   TRANSCONF_OUTPUT_COLORSPACE_YUV709
> 	REG_FIELD_PREP(TRANSCONF_OUTPUT_COLORSPACE_MASK, 2) /*
> ilk-ivb */
> -#define   TRANSCONF_OUTPUT_COLORSPACE_YUV_HSW	REG_BIT(11)
> /* hsw only */
> -#define   TRANSCONF_BPC_MASK			REG_GENMASK(7, 5)
> /* ctg-ivb */
> -#define   TRANSCONF_BPC_8
> 	REG_FIELD_PREP(TRANSCONF_BPC_MASK, 0)
> -#define   TRANSCONF_BPC_10
> 	REG_FIELD_PREP(TRANSCONF_BPC_MASK, 1)
> -#define   TRANSCONF_BPC_6
> 	REG_FIELD_PREP(TRANSCONF_BPC_MASK, 2)
> -#define   TRANSCONF_BPC_12
> 	REG_FIELD_PREP(TRANSCONF_BPC_MASK, 3)
> -#define   TRANSCONF_DITHER_EN			REG_BIT(4)
> -#define   TRANSCONF_DITHER_TYPE_MASK		REG_GENMASK(3, 2)
> -#define   TRANSCONF_DITHER_TYPE_SP
> 	REG_FIELD_PREP(TRANSCONF_DITHER_TYPE_MASK, 0)
> -#define   TRANSCONF_DITHER_TYPE_ST1
> 	REG_FIELD_PREP(TRANSCONF_DITHER_TYPE_MASK, 1)
> -#define   TRANSCONF_DITHER_TYPE_ST2
> 	REG_FIELD_PREP(TRANSCONF_DITHER_TYPE_MASK, 2)
> -#define   TRANSCONF_DITHER_TYPE_TEMP
> 	REG_FIELD_PREP(TRANSCONF_DITHER_TYPE_MASK, 3)
> -#define   TRANSCONF_PIXEL_COUNT_SCALING_MASK	REG_GENMASK(1, 0)
> -#define   TRANSCONF_PIXEL_COUNT_SCALING_X4	1
> -
>  #define _PIPEASTAT		0x70024
>  #define PIPESTAT(dev_priv, pipe)		_MMIO_PIPE2(dev_priv, pipe,
> _PIPEASTAT)
>  #define   PIPE_FIFO_UNDERRUN_STATUS		(1UL << 31)
> @@ -1598,41 +846,6 @@
>  #define   PIPESTAT_INT_ENABLE_MASK		0x7fff0000
>  #define   PIPESTAT_INT_STATUS_MASK		0x0000ffff
> 
> -#define _PIPE_ARB_CTL_A			0x70028 /* icl+ */
> -#define PIPE_ARB_CTL(dev_priv, pipe)		_MMIO_PIPE2(dev_priv, pipe,
> _PIPE_ARB_CTL_A)
> -#define   PIPE_ARB_USE_PROG_SLOTS	REG_BIT(13)
> -
> -#define _PIPE_MISC_A			0x70030
> -#define _PIPE_MISC_B			0x71030
> -#define PIPE_MISC(pipe)			_MMIO_PIPE(pipe,
> _PIPE_MISC_A, _PIPE_MISC_B)
> -#define   PIPE_MISC_YUV420_ENABLE		REG_BIT(27) /* glk+ */
> -#define   PIPE_MISC_YUV420_MODE_FULL_BLEND	REG_BIT(26) /* glk+
> */
> -#define   PIPE_MISC_HDR_MODE_PRECISION		REG_BIT(23) /* icl+ */
> -#define   PIPE_MISC_PSR_MASK_PRIMARY_FLIP	REG_BIT(23) /* bdw
> */
> -#define   PIPE_MISC_PSR_MASK_SPRITE_ENABLE	REG_BIT(22) /* bdw
> */
> -#define   PIPE_MISC_PSR_MASK_PIPE_REG_WRITE	REG_BIT(21) /* skl+
> */
> -#define   PIPE_MISC_PSR_MASK_CURSOR_MOVE	REG_BIT(21) /* bdw
> */
> -#define   PIPE_MISC_PSR_MASK_VBLANK_VSYNC_INT	REG_BIT(20)
> -#define   PIPE_MISC_OUTPUT_COLORSPACE_YUV	REG_BIT(11)
> -#define   PIPE_MISC_PIXEL_ROUNDING_TRUNC	REG_BIT(8) /* tgl+ */
> -/*
> - * For Display < 13, Bits 5-7 of PIPE MISC represent DITHER BPC with
> - * valid values of: 6, 8, 10 BPC.
> - * ADLP+, the bits 5-7 represent PORT OUTPUT BPC with valid values of:
> - * 6, 8, 10, 12 BPC.
> - */
> -#define   PIPE_MISC_BPC_MASK			REG_GENMASK(7, 5)
> -#define   PIPE_MISC_BPC_8
> 	REG_FIELD_PREP(PIPE_MISC_BPC_MASK, 0)
> -#define   PIPE_MISC_BPC_10
> 	REG_FIELD_PREP(PIPE_MISC_BPC_MASK, 1)
> -#define   PIPE_MISC_BPC_6
> 	REG_FIELD_PREP(PIPE_MISC_BPC_MASK, 2)
> -#define   PIPE_MISC_BPC_12_ADLP
> 	REG_FIELD_PREP(PIPE_MISC_BPC_MASK, 4) /* adlp+ */
> -#define   PIPE_MISC_DITHER_ENABLE		REG_BIT(4)
> -#define   PIPE_MISC_DITHER_TYPE_MASK		REG_GENMASK(3, 2)
> -#define   PIPE_MISC_DITHER_TYPE_SP
> 	REG_FIELD_PREP(PIPE_MISC_DITHER_TYPE_MASK, 0)
> -#define   PIPE_MISC_DITHER_TYPE_ST1
> 	REG_FIELD_PREP(PIPE_MISC_DITHER_TYPE_MASK, 1)
> -#define   PIPE_MISC_DITHER_TYPE_ST2
> 	REG_FIELD_PREP(PIPE_MISC_DITHER_TYPE_MASK, 2)
> -#define   PIPE_MISC_DITHER_TYPE_TEMP
> 	REG_FIELD_PREP(PIPE_MISC_DITHER_TYPE_MASK, 3)
> -
>  #define _PIPE_MISC2_A					0x7002C
>  #define _PIPE_MISC2_B					0x7102C
>  #define PIPE_MISC2(pipe)		_MMIO_PIPE(pipe, _PIPE_MISC2_A,
> _PIPE_MISC2_B)
> @@ -1663,136 +876,16 @@
>  #define   SPRITEE_FLIPDONE_INT_EN			REG_BIT(9)
>  #define   PLANEC_FLIPDONE_INT_EN			REG_BIT(8)
> 
> -#define DPINVGTT				_MMIO(VLV_DISPLAY_BASE +
> 0x7002c) /* VLV/CHV only */
> -#define   DPINVGTT_EN_MASK_CHV
> 	REG_GENMASK(27, 16)
> -#define   DPINVGTT_EN_MASK_VLV
> 	REG_GENMASK(23, 16)
> -#define   SPRITEF_INVALID_GTT_INT_EN			REG_BIT(27)
> -#define   SPRITEE_INVALID_GTT_INT_EN			REG_BIT(26)
> -#define   PLANEC_INVALID_GTT_INT_EN			REG_BIT(25)
> -#define   CURSORC_INVALID_GTT_INT_EN			REG_BIT(24)
> -#define   CURSORB_INVALID_GTT_INT_EN			REG_BIT(23)
> -#define   CURSORA_INVALID_GTT_INT_EN			REG_BIT(22)
> -#define   SPRITED_INVALID_GTT_INT_EN			REG_BIT(21)
> -#define   SPRITEC_INVALID_GTT_INT_EN			REG_BIT(20)
> -#define   PLANEB_INVALID_GTT_INT_EN			REG_BIT(19)
> -#define   SPRITEB_INVALID_GTT_INT_EN			REG_BIT(18)
> -#define   SPRITEA_INVALID_GTT_INT_EN			REG_BIT(17)
> -#define   PLANEA_INVALID_GTT_INT_EN			REG_BIT(16)
> -#define   DPINVGTT_STATUS_MASK_CHV
> 	REG_GENMASK(11, 0)
> -#define   DPINVGTT_STATUS_MASK_VLV
> 	REG_GENMASK(7, 0)
> -#define   SPRITEF_INVALID_GTT_STATUS			REG_BIT(11)
> -#define   SPRITEE_INVALID_GTT_STATUS			REG_BIT(10)
> -#define   PLANEC_INVALID_GTT_STATUS			REG_BIT(9)
> -#define   CURSORC_INVALID_GTT_STATUS			REG_BIT(8)
> -#define   CURSORB_INVALID_GTT_STATUS			REG_BIT(7)
> -#define   CURSORA_INVALID_GTT_STATUS			REG_BIT(6)
> -#define   SPRITED_INVALID_GTT_STATUS			REG_BIT(5)
> -#define   SPRITEC_INVALID_GTT_STATUS			REG_BIT(4)
> -#define   PLANEB_INVALID_GTT_STATUS			REG_BIT(3)
> -#define   SPRITEB_INVALID_GTT_STATUS			REG_BIT(2)
> -#define   SPRITEA_INVALID_GTT_STATUS			REG_BIT(1)
> -#define   PLANEA_INVALID_GTT_STATUS			REG_BIT(0)
> -
> -#define CBR1_VLV			_MMIO(VLV_DISPLAY_BASE +
> 0x70400)
> -#define  CBR_PND_DEADLINE_DISABLE	(1 << 31)
> -#define  CBR_PWM_CLOCK_MUX_SELECT	(1 << 30)
> -
> -#define CBR4_VLV			_MMIO(VLV_DISPLAY_BASE +
> 0x70450)
> -#define  CBR_DPLLBMD_PIPE(pipe)		(1 << (7 + (pipe) * 11)) /*
> pipes B and C */
> -
> -/*
> - * The two pipe frame counter registers are not synchronized, so
> - * reading a stable value is somewhat tricky. The following code
> - * should work:
> - *
> - *  do {
> - *    high1 = ((INREG(PIPEAFRAMEHIGH) & PIPE_FRAME_HIGH_MASK) >>
> - *             PIPE_FRAME_HIGH_SHIFT;
> - *    low1 =  ((INREG(PIPEAFRAMEPIXEL) & PIPE_FRAME_LOW_MASK) >>
> - *             PIPE_FRAME_LOW_SHIFT);
> - *    high2 = ((INREG(PIPEAFRAMEHIGH) & PIPE_FRAME_HIGH_MASK) >>
> - *             PIPE_FRAME_HIGH_SHIFT);
> - *  } while (high1 != high2);
> - *  frame = (high1 << 8) | low1;
> - */
> -#define _PIPEAFRAMEHIGH          0x70040
> -#define PIPEFRAME(dev_priv, pipe)		_MMIO_PIPE2(dev_priv, pipe,
> _PIPEAFRAMEHIGH)
> -#define   PIPE_FRAME_HIGH_MASK    0x0000ffff
> -#define   PIPE_FRAME_HIGH_SHIFT   0
> -
> -#define _PIPEAFRAMEPIXEL         0x70044
> -#define PIPEFRAMEPIXEL(dev_priv, pipe)	_MMIO_PIPE2(dev_priv, pipe,
> _PIPEAFRAMEPIXEL)
> -#define   PIPE_FRAME_LOW_MASK     0xff000000
> -#define   PIPE_FRAME_LOW_SHIFT    24
> -#define   PIPE_PIXEL_MASK         0x00ffffff
> -#define   PIPE_PIXEL_SHIFT        0
> -
> -/* GM45+ just has to be different */
> -#define _PIPEA_FRMCOUNT_G4X	0x70040
> -#define PIPE_FRMCOUNT_G4X(dev_priv, pipe) _MMIO_PIPE2(dev_priv, pipe,
> _PIPEA_FRMCOUNT_G4X)
> -
>  #define _PIPEA_FLIPCOUNT_G4X	0x70044
>  #define PIPE_FLIPCOUNT_G4X(dev_priv, pipe) _MMIO_PIPE2(dev_priv, pipe,
> _PIPEA_FLIPCOUNT_G4X)
> 
> -/* CHV pipe B blender */
> -#define _CHV_BLEND_A		0x60a00
> -#define CHV_BLEND(dev_priv, pipe)		_MMIO_TRANS2(dev_priv,
> pipe, _CHV_BLEND_A)
> -#define   CHV_BLEND_MASK	REG_GENMASK(31, 30)
> -#define   CHV_BLEND_LEGACY	REG_FIELD_PREP(CHV_BLEND_MASK, 0)
> -#define   CHV_BLEND_ANDROID	REG_FIELD_PREP(CHV_BLEND_MASK,
> 1)
> -#define   CHV_BLEND_MPO		REG_FIELD_PREP(CHV_BLEND_MASK,
> 2)
> -
> -#define _CHV_CANVAS_A		0x60a04
> -#define CHV_CANVAS(dev_priv, pipe)	_MMIO_TRANS2(dev_priv, pipe,
> _CHV_CANVAS_A)
> -#define   CHV_CANVAS_RED_MASK	REG_GENMASK(29, 20)
> -#define   CHV_CANVAS_GREEN_MASK	REG_GENMASK(19, 10)
> -#define   CHV_CANVAS_BLUE_MASK	REG_GENMASK(9, 0)
> -
>  /* Display/Sprite base address macros */
>  #define DISP_BASEADDR_MASK	(0xfffff000)
>  #define I915_LO_DISPBASE(val)	((val) & ~DISP_BASEADDR_MASK)
>  #define I915_HI_DISPBASE(val)	((val) & DISP_BASEADDR_MASK)
> 
> -/*
> - * VBIOS flags
> - * gen2:
> - * [00:06] alm,mgm
> - * [10:16] all
> - * [30:32] alm,mgm
> - * gen3+:
> - * [00:0f] all
> - * [10:1f] all
> - * [30:32] all
> - */
> -#define SWF0(dev_priv, i)	_MMIO(DISPLAY_MMIO_BASE(dev_priv) +
> 0x70410 + (i) * 4)
> -#define SWF1(dev_priv, i)	_MMIO(DISPLAY_MMIO_BASE(dev_priv) +
> 0x71410 + (i) * 4)
> -#define SWF3(dev_priv, i)	_MMIO(DISPLAY_MMIO_BASE(dev_priv) +
> 0x72414 + (i) * 4)
> -#define SWF_ILK(i)	_MMIO(0x4F000 + (i) * 4)
> -
> -/* VBIOS regs */
> -#define VGACNTRL		_MMIO(0x71400)
> -# define VGA_DISP_DISABLE			(1 << 31)
> -# define VGA_2X_MODE				(1 << 30)
> -# define VGA_PIPE_B_SELECT			(1 << 29)
> -
> -#define VLV_VGACNTRL		_MMIO(VLV_DISPLAY_BASE +
> 0x71400)
> -
>  /* Ironlake */
> 
> -#define CPU_VGACNTRL	_MMIO(0x41000)
> -
> -#define DIGITAL_PORT_HOTPLUG_CNTRL	_MMIO(0x44030)
> -#define  DIGITAL_PORTA_HOTPLUG_ENABLE		(1 << 4)
> -#define  DIGITAL_PORTA_PULSE_DURATION_2ms	(0 << 2) /* pre-HSW
> */
> -#define  DIGITAL_PORTA_PULSE_DURATION_4_5ms	(1 << 2) /* pre-HSW
> */
> -#define  DIGITAL_PORTA_PULSE_DURATION_6ms	(2 << 2) /* pre-HSW
> */
> -#define  DIGITAL_PORTA_PULSE_DURATION_100ms	(3 << 2) /* pre-HSW
> */
> -#define  DIGITAL_PORTA_PULSE_DURATION_MASK	(3 << 2) /* pre-HSW
> */
> -#define  DIGITAL_PORTA_HOTPLUG_STATUS_MASK	(3 << 0)
> -#define  DIGITAL_PORTA_HOTPLUG_NO_DETECT	(0 << 0)
> -#define  DIGITAL_PORTA_HOTPLUG_SHORT_DETECT	(1 << 0)
> -#define  DIGITAL_PORTA_HOTPLUG_LONG_DETECT	(2 << 0)
> -
>  /* refresh rate hardware control */
>  #define RR_HW_CTL       _MMIO(0x45300)
>  #define  RR_HW_LOW_POWER_FRAMES_MASK    0xff
> @@ -1805,68 +898,6 @@
>  #define PCH_3DCGDIS1		_MMIO(0x46024)
>  # define VFMUNIT_CLOCK_GATE_DISABLE		(1 << 11)
> 
> -#define _PIPEA_DATA_M1		0x60030
> -#define _PIPEB_DATA_M1		0x61030
> -#define PIPE_DATA_M1(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran,
> _PIPEA_DATA_M1)
> -
> -#define _PIPEA_DATA_N1		0x60034
> -#define _PIPEB_DATA_N1		0x61034
> -#define PIPE_DATA_N1(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran,
> _PIPEA_DATA_N1)
> -
> -#define _PIPEA_DATA_M2		0x60038
> -#define _PIPEB_DATA_M2		0x61038
> -#define PIPE_DATA_M2(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran,
> _PIPEA_DATA_M2)
> -
> -#define _PIPEA_DATA_N2		0x6003c
> -#define _PIPEB_DATA_N2		0x6103c
> -#define PIPE_DATA_N2(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran,
> _PIPEA_DATA_N2)
> -
> -#define _PIPEA_LINK_M1		0x60040
> -#define _PIPEB_LINK_M1		0x61040
> -#define PIPE_LINK_M1(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran,
> _PIPEA_LINK_M1)
> -
> -#define _PIPEA_LINK_N1		0x60044
> -#define _PIPEB_LINK_N1		0x61044
> -#define PIPE_LINK_N1(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran,
> _PIPEA_LINK_N1)
> -
> -#define _PIPEA_LINK_M2		0x60048
> -#define _PIPEB_LINK_M2		0x61048
> -#define PIPE_LINK_M2(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran,
> _PIPEA_LINK_M2)
> -
> -#define _PIPEA_LINK_N2		0x6004c
> -#define _PIPEB_LINK_N2		0x6104c
> -#define PIPE_LINK_N2(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran,
> _PIPEA_LINK_N2)
> -
> -/* CPU panel fitter */
> -/* IVB+ has 3 fitters, 0 is 7x5 capable, the other two only 3x3 */
> -#define _PFA_CTL_1		0x68080
> -#define _PFB_CTL_1		0x68880
> -#define PF_CTL(pipe)		_MMIO_PIPE(pipe, _PFA_CTL_1, _PFB_CTL_1)
> -#define   PF_ENABLE			REG_BIT(31)
> -#define   PF_PIPE_SEL_MASK_IVB		REG_GENMASK(30, 29) /*
> ivb/hsw */
> -#define   PF_PIPE_SEL_IVB(pipe)
> 	REG_FIELD_PREP(PF_PIPE_SEL_MASK_IVB, (pipe))
> -#define   PF_FILTER_MASK		REG_GENMASK(24, 23)
> -#define   PF_FILTER_PROGRAMMED
> 	REG_FIELD_PREP(PF_FILTER_MASK, 0)
> -#define   PF_FILTER_MED_3x3		REG_FIELD_PREP(PF_FILTER_MASK, 1)
> -#define   PF_FILTER_EDGE_ENHANCE
> 	REG_FIELD_PREP(PF_FILTER_EDGE_MASK, 2)
> -#define   PF_FILTER_EDGE_SOFTEN
> 	REG_FIELD_PREP(PF_FILTER_EDGE_MASK, 3)
> -
> -#define _PFA_WIN_SZ		0x68074
> -#define _PFB_WIN_SZ		0x68874
> -#define PF_WIN_SZ(pipe)		_MMIO_PIPE(pipe, _PFA_WIN_SZ,
> _PFB_WIN_SZ)
> -#define   PF_WIN_XSIZE_MASK	REG_GENMASK(31, 16)
> -#define   PF_WIN_XSIZE(w)	REG_FIELD_PREP(PF_WIN_XSIZE_MASK, (w))
> -#define   PF_WIN_YSIZE_MASK	REG_GENMASK(15, 0)
> -#define   PF_WIN_YSIZE(h)	REG_FIELD_PREP(PF_WIN_YSIZE_MASK, (h))
> -
> -#define _PFA_WIN_POS		0x68070
> -#define _PFB_WIN_POS		0x68870
> -#define PF_WIN_POS(pipe)	_MMIO_PIPE(pipe, _PFA_WIN_POS,
> _PFB_WIN_POS)
> -#define   PF_WIN_XPOS_MASK	REG_GENMASK(31, 16)
> -#define   PF_WIN_XPOS(x)	REG_FIELD_PREP(PF_WIN_XPOS_MASK, (x))
> -#define   PF_WIN_YPOS_MASK	REG_GENMASK(15, 0)
> -#define   PF_WIN_YPOS(y)	REG_FIELD_PREP(PF_WIN_YPOS_MASK, (y))
> -
>  #define _PFA_VSCALE		0x68084
>  #define _PFB_VSCALE		0x68884
>  #define PF_VSCALE(pipe)		_MMIO_PIPE(pipe, _PFA_VSCALE,
> _PFB_VSCALE)
> @@ -1875,65 +906,6 @@
>  #define _PFB_HSCALE		0x68890
>  #define PF_HSCALE(pipe)		_MMIO_PIPE(pipe, _PFA_HSCALE,
> _PFB_HSCALE)
> 
> -/*
> - * Skylake scalers
> - */
> -#define _ID(id, a, b) _PICK_EVEN(id, a, b)
> -#define _PS_1A_CTRL      0x68180
> -#define _PS_2A_CTRL      0x68280
> -#define _PS_1B_CTRL      0x68980
> -#define _PS_2B_CTRL      0x68A80
> -#define _PS_1C_CTRL      0x69180
> -#define SKL_PS_CTRL(pipe, id) _MMIO_PIPE(pipe,        \
> -			_ID(id, _PS_1A_CTRL, _PS_2A_CTRL),       \
> -			_ID(id, _PS_1B_CTRL, _PS_2B_CTRL))
> -#define   PS_SCALER_EN				REG_BIT(31)
> -#define   PS_SCALER_TYPE_MASK			REG_BIT(30) /* icl+ */
> -#define   PS_SCALER_TYPE_NON_LINEAR
> 	REG_FIELD_PREP(PS_SCALER_TYPE_MASK, 0)
> -#define   PS_SCALER_TYPE_LINEAR
> 	REG_FIELD_PREP(PS_SCALER_TYPE_MASK, 1)
> -#define   SKL_PS_SCALER_MODE_MASK		REG_GENMASK(29,
> 28) /* skl/bxt */
> -#define   SKL_PS_SCALER_MODE_DYN
> 	REG_FIELD_PREP(SKL_PS_SCALER_MODE_MASK, 0)
> -#define   SKL_PS_SCALER_MODE_HQ
> 	REG_FIELD_PREP(SKL_PS_SCALER_MODE_MASK, 1)
> -#define   SKL_PS_SCALER_MODE_NV12
> 	REG_FIELD_PREP(SKL_PS_SCALER_MODE_MASK, 2)
> -#define   PS_SCALER_MODE_MASK			REG_BIT(29) /* glk-tgl
> */
> -#define   PS_SCALER_MODE_NORMAL
> 	REG_FIELD_PREP(PS_SCALER_MODE_MASK, 0)
> -#define   PS_SCALER_MODE_PLANAR
> 	REG_FIELD_PREP(PS_SCALER_MODE_MASK, 1)
> -#define   PS_ADAPTIVE_FILTERING_EN		REG_BIT(28) /* icl+ */
> -#define   PS_BINDING_MASK			REG_GENMASK(27, 25)
> -#define   PS_BINDING_PIPE
> 	REG_FIELD_PREP(PS_BINDING_MASK, 0)
> -#define   PS_BINDING_PLANE(plane_id)
> 	REG_FIELD_PREP(PS_BINDING_MASK, (plane_id) + 1)
> -#define   PS_FILTER_MASK			REG_GENMASK(24, 23)
> -#define   PS_FILTER_MEDIUM
> 	REG_FIELD_PREP(PS_FILTER_MASK, 0)
> -#define   PS_FILTER_PROGRAMMED
> 	REG_FIELD_PREP(PS_FILTER_MASK, 1)
> -#define   PS_FILTER_EDGE_ENHANCE
> 	REG_FIELD_PREP(PS_FILTER_MASK, 2)
> -#define   PS_FILTER_BILINEAR
> 	REG_FIELD_PREP(PS_FILTER_MASK, 3)
> -#define   PS_ADAPTIVE_FILTER_MASK		REG_BIT(22) /* icl+ */
> -#define   PS_ADAPTIVE_FILTER_MEDIUM
> 	REG_FIELD_PREP(PS_ADAPTIVE_FILTER_MASK, 0)
> -#define   PS_ADAPTIVE_FILTER_EDGE_ENHANCE
> 	REG_FIELD_PREP(PS_ADAPTIVE_FILTER_MASK, 1)
> -#define   PS_PIPE_SCALER_LOC_MASK		REG_BIT(21) /* icl+ */
> -#define   PS_PIPE_SCALER_LOC_AFTER_OUTPUT_CSC
> 	REG_FIELD_PREP(PS_SCALER_LOCATION_MASK, 0) /* non-linear */
> -#define   PS_PIPE_SCALER_LOC_AFTER_CSC
> 	REG_FIELD_PREP(PS_SCALER_LOCATION_MASK, 1) /* linear */
> -#define   PS_VERT3TAP				REG_BIT(21) /*
> skl/bxt */
> -#define   PS_VERT_INT_INVERT_FIELD		REG_BIT(20)
> -#define   PS_PROG_SCALE_FACTOR			REG_BIT(19) /* tgl+
> */
> -#define   PS_PWRUP_PROGRESS			REG_BIT(17)
> -#define   PS_V_FILTER_BYPASS			REG_BIT(8)
> -#define   PS_VADAPT_EN				REG_BIT(7) /* skl/bxt
> */
> -#define   PS_VADAPT_MODE_MASK			REG_GENMASK(6, 5)
> /* skl/bxt */
> -#define   PS_VADAPT_MODE_LEAST_ADAPT
> 	REG_FIELD_PREP(PS_VADAPT_MODE_MASK, 0)
> -#define   PS_VADAPT_MODE_MOD_ADAPT
> 	REG_FIELD_PREP(PS_VADAPT_MODE_MASK, 1)
> -#define   PS_VADAPT_MODE_MOST_ADAPT
> 	REG_FIELD_PREP(PS_VADAPT_MODE_MASK, 3)
> -#define   PS_BINDING_Y_MASK			REG_GENMASK(7, 5)
> /* icl-tgl */
> -#define   PS_BINDING_Y_PLANE(plane_id)
> 	REG_FIELD_PREP(PS_BINDING_Y_MASK, (plane_id) + 1)
> -#define   PS_Y_VERT_FILTER_SELECT_MASK		REG_BIT(4) /* glk+ */
> -#define   PS_Y_VERT_FILTER_SELECT(set)
> 	REG_FIELD_PREP(PS_Y_VERT_FILTER_SELECT_MASK, (set))
> -#define   PS_Y_HORZ_FILTER_SELECT_MASK		REG_BIT(3) /* glk+ */
> -#define   PS_Y_HORZ_FILTER_SELECT(set)
> 	REG_FIELD_PREP(PS_Y_HORZ_FILTER_SELECT_MASK, (set))
> -#define   PS_UV_VERT_FILTER_SELECT_MASK		REG_BIT(2) /* glk+ */
> -#define   PS_UV_VERT_FILTER_SELECT(set)
> 	REG_FIELD_PREP(PS_UV_VERT_FILTER_SELECT_MASK, (set))
> -#define   PS_UV_HORZ_FILTER_SELECT_MASK		REG_BIT(1) /* glk+ */
> -#define   PS_UV_HORZ_FILTER_SELECT(set)
> 	REG_FIELD_PREP(PS_UV_HORZ_FILTER_SELECT_MASK, (set))
> -
>  #define _PS_PWR_GATE_1A     0x68160
>  #define _PS_PWR_GATE_2A     0x68260
>  #define _PS_PWR_GATE_1B     0x68960
> @@ -1954,32 +926,6 @@
>  #define   PS_PWR_GATE_SLPEN_24
> 	REG_FIELD_PREP(PS_PWR_GATE_SLPEN_MASK, 2)
>  #define   PS_PWR_GATE_SLPEN_32
> 	REG_FIELD_PREP(PS_PWR_GATE_SLPEN_MASK, 3)
> 
> -#define _PS_WIN_POS_1A      0x68170
> -#define _PS_WIN_POS_2A      0x68270
> -#define _PS_WIN_POS_1B      0x68970
> -#define _PS_WIN_POS_2B      0x68A70
> -#define _PS_WIN_POS_1C      0x69170
> -#define SKL_PS_WIN_POS(pipe, id) _MMIO_PIPE(pipe,     \
> -			_ID(id, _PS_WIN_POS_1A, _PS_WIN_POS_2A), \
> -			_ID(id, _PS_WIN_POS_1B, _PS_WIN_POS_2B))
> -#define   PS_WIN_XPOS_MASK			REG_GENMASK(31,
> 16)
> -#define   PS_WIN_XPOS(x)
> 	REG_FIELD_PREP(PS_WIN_XPOS_MASK, (x))
> -#define   PS_WIN_YPOS_MASK			REG_GENMASK(15, 0)
> -#define   PS_WIN_YPOS(y)
> 	REG_FIELD_PREP(PS_WIN_YPOS_MASK, (y))
> -
> -#define _PS_WIN_SZ_1A       0x68174
> -#define _PS_WIN_SZ_2A       0x68274
> -#define _PS_WIN_SZ_1B       0x68974
> -#define _PS_WIN_SZ_2B       0x68A74
> -#define _PS_WIN_SZ_1C       0x69174
> -#define SKL_PS_WIN_SZ(pipe, id)  _MMIO_PIPE(pipe,     \
> -			_ID(id, _PS_WIN_SZ_1A, _PS_WIN_SZ_2A),   \
> -			_ID(id, _PS_WIN_SZ_1B, _PS_WIN_SZ_2B))
> -#define   PS_WIN_XSIZE_MASK			REG_GENMASK(31,
> 16)
> -#define   PS_WIN_XSIZE(w)
> 	REG_FIELD_PREP(PS_WIN_XSIZE_MASK, (w))
> -#define   PS_WIN_YSIZE_MASK			REG_GENMASK(15, 0)
> -#define   PS_WIN_YSIZE(h)
> 	REG_FIELD_PREP(PS_WIN_YSIZE_MASK, (h))
> -
>  #define _PS_VSCALE_1A       0x68184
>  #define _PS_VSCALE_2A       0x68284
>  #define _PS_VSCALE_1B       0x68984
> @@ -1998,30 +944,6 @@
>  			_ID(id, _PS_HSCALE_1A, _PS_HSCALE_2A),   \
>  			_ID(id, _PS_HSCALE_1B, _PS_HSCALE_2B))
> 
> -#define _PS_VPHASE_1A       0x68188
> -#define _PS_VPHASE_2A       0x68288
> -#define _PS_VPHASE_1B       0x68988
> -#define _PS_VPHASE_2B       0x68A88
> -#define _PS_VPHASE_1C       0x69188
> -#define SKL_PS_VPHASE(pipe, id)  _MMIO_PIPE(pipe,     \
> -			_ID(id, _PS_VPHASE_1A, _PS_VPHASE_2A),   \
> -			_ID(id, _PS_VPHASE_1B, _PS_VPHASE_2B))
> -#define   PS_Y_PHASE_MASK			REG_GENMASK(31, 16)
> -#define   PS_Y_PHASE(x)
> 	REG_FIELD_PREP(PS_Y_PHASE_MASK, (x))
> -#define   PS_UV_RGB_PHASE_MASK			REG_GENMASK(15, 0)
> -#define   PS_UV_RGB_PHASE(x)
> 	REG_FIELD_PREP(PS_UV_RGB_PHASE_MASK, (x))
> -#define   PS_PHASE_MASK				(0x7fff << 1) /* u2.13
> */
> -#define   PS_PHASE_TRIP				(1 << 0)
> -
> -#define _PS_HPHASE_1A       0x68194
> -#define _PS_HPHASE_2A       0x68294
> -#define _PS_HPHASE_1B       0x68994
> -#define _PS_HPHASE_2B       0x68A94
> -#define _PS_HPHASE_1C       0x69194
> -#define SKL_PS_HPHASE(pipe, id)  _MMIO_PIPE(pipe,     \
> -			_ID(id, _PS_HPHASE_1A, _PS_HPHASE_2A),   \
> -			_ID(id, _PS_HPHASE_1B, _PS_HPHASE_2B))
> -
>  #define _PS_ECC_STAT_1A     0x681D0
>  #define _PS_ECC_STAT_2A     0x682D0
>  #define _PS_ECC_STAT_1B     0x689D0
> @@ -2031,23 +953,6 @@
>  			_ID(id, _PS_ECC_STAT_1A, _PS_ECC_STAT_2A),   \
>  			_ID(id, _PS_ECC_STAT_1B, _PS_ECC_STAT_2B))
> 
> -#define _PS_COEF_SET0_INDEX_1A	   0x68198
> -#define _PS_COEF_SET0_INDEX_2A	   0x68298
> -#define _PS_COEF_SET0_INDEX_1B	   0x68998
> -#define _PS_COEF_SET0_INDEX_2B	   0x68A98
> -#define GLK_PS_COEF_INDEX_SET(pipe, id, set)  _MMIO_PIPE(pipe,    \
> -			_ID(id, _PS_COEF_SET0_INDEX_1A,
> _PS_COEF_SET0_INDEX_2A) + (set) * 8, \
> -			_ID(id, _PS_COEF_SET0_INDEX_1B,
> _PS_COEF_SET0_INDEX_2B) + (set) * 8)
> -#define   PS_COEF_INDEX_AUTO_INC		REG_BIT(10)
> -
> -#define _PS_COEF_SET0_DATA_1A	   0x6819C
> -#define _PS_COEF_SET0_DATA_2A	   0x6829C
> -#define _PS_COEF_SET0_DATA_1B	   0x6899C
> -#define _PS_COEF_SET0_DATA_2B	   0x68A9C
> -#define GLK_PS_COEF_DATA_SET(pipe, id, set)  _MMIO_PIPE(pipe,     \
> -			_ID(id, _PS_COEF_SET0_DATA_1A,
> _PS_COEF_SET0_DATA_2A) + (set) * 8, \
> -			_ID(id, _PS_COEF_SET0_DATA_1B,
> _PS_COEF_SET0_DATA_2B) + (set) * 8)
> -
>  /* Display Internal Timeout Register */
>  #define RM_TIMEOUT		_MMIO(0x42060)
>  #define RM_TIMEOUT_REG_CAPTURE	_MMIO(0x420E0)
> @@ -2086,25 +991,6 @@
>  #define DE_PIPEA_FIFO_UNDERRUN  (1 << 0)
>  #define DE_PIPE_FIFO_UNDERRUN(pipe)  (1 << (8 * (pipe)))
> 
> -/* More Ivybridge lolz */
> -#define DE_ERR_INT_IVB			(1 << 30)
> -#define DE_GSE_IVB			(1 << 29)
> -#define DE_PCH_EVENT_IVB		(1 << 28)
> -#define DE_DP_A_HOTPLUG_IVB		(1 << 27)
> -#define DE_AUX_CHANNEL_A_IVB		(1 << 26)
> -#define DE_EDP_PSR_INT_HSW		(1 << 19)
> -#define DE_SPRITEC_FLIP_DONE_IVB	(1 << 14)
> -#define DE_PLANEC_FLIP_DONE_IVB		(1 << 13)
> -#define DE_PIPEC_VBLANK_IVB		(1 << 10)
> -#define DE_SPRITEB_FLIP_DONE_IVB	(1 << 9)
> -#define DE_PLANEB_FLIP_DONE_IVB		(1 << 8)
> -#define DE_PIPEB_VBLANK_IVB		(1 << 5)
> -#define DE_SPRITEA_FLIP_DONE_IVB	(1 << 4)
> -#define DE_PLANEA_FLIP_DONE_IVB		(1 << 3)
> -#define DE_PLANE_FLIP_DONE_IVB(plane)	(1 << (3 + 5 * (plane)))
> -#define DE_PIPEA_VBLANK_IVB		(1 << 0)
> -#define DE_PIPE_VBLANK_IVB(pipe)	(1 << ((pipe) * 5))
> -
>  #define VLV_MASTER_IER			_MMIO(0x4400c) /* Gunit
> master IER */
>  #define   MASTER_INTERRUPT_ENABLE	(1 << 31)
> 
> @@ -2144,8 +1030,6 @@
>  #define  GEN8_GT_BCS_IRQ		(1 << 1)
>  #define  GEN8_GT_RCS_IRQ		(1 << 0)
> 
> -#define XELPD_DISPLAY_ERR_FATAL_MASK	_MMIO(0x4421c)
> -
>  #define GEN8_GT_ISR(which) _MMIO(0x44300 + (0x10 * (which)))
>  #define GEN8_GT_IMR(which) _MMIO(0x44304 + (0x10 * (which)))
>  #define GEN8_GT_IIR(which) _MMIO(0x44308 + (0x10 * (which)))
> @@ -2162,91 +1046,9 @@
>  #define GEN8_VECS_IRQ_SHIFT 0
>  #define GEN8_WD_IRQ_SHIFT 16
> 
> -#define GEN8_DE_PIPE_ISR(pipe) _MMIO(0x44400 + (0x10 * (pipe)))
> -#define GEN8_DE_PIPE_IMR(pipe) _MMIO(0x44404 + (0x10 * (pipe)))
> -#define GEN8_DE_PIPE_IIR(pipe) _MMIO(0x44408 + (0x10 * (pipe)))
> -#define GEN8_DE_PIPE_IER(pipe) _MMIO(0x4440c + (0x10 * (pipe)))
> -#define  GEN8_PIPE_FIFO_UNDERRUN	REG_BIT(31)
> -#define  GEN8_PIPE_CDCLK_CRC_ERROR	REG_BIT(29)
> -#define  GEN8_PIPE_CDCLK_CRC_DONE	REG_BIT(28)
> -#define  GEN12_PIPEDMC_INTERRUPT	REG_BIT(26) /* tgl+ */
> -#define  GEN12_PIPEDMC_FAULT		REG_BIT(25) /* tgl+ */
> -#define  MTL_PIPEDMC_ATS_FAULT		REG_BIT(24) /* mtl+ */
> -#define  GEN11_PIPE_PLANE7_FAULT	REG_BIT(22) /* icl/tgl */
> -#define  GEN11_PIPE_PLANE6_FAULT	REG_BIT(21) /* icl/tgl */
> -#define  GEN11_PIPE_PLANE5_FAULT	REG_BIT(20) /* icl+ */
> -#define  GEN12_PIPE_VBLANK_UNMOD	REG_BIT(19) /* tgl+ */
> -#define  MTL_PLANE_ATS_FAULT		REG_BIT(18) /* mtl+ */
> -#define  GEN11_PIPE_PLANE7_FLIP_DONE	REG_BIT(18) /* icl/tgl */
> -#define  GEN11_PIPE_PLANE6_FLIP_DONE	REG_BIT(17) /* icl/tgl */
> -#define  GEN11_PIPE_PLANE5_FLIP_DONE	REG_BIT(16) /* icl+ */
> -#define  GEN12_DSB_2_INT		REG_BIT(15) /* tgl+ */
> -#define  GEN12_DSB_1_INT		REG_BIT(14) /* tgl+ */
> -#define  GEN12_DSB_0_INT		REG_BIT(13) /* tgl+ */
> -#define  GEN12_DSB_INT(dsb_id)		REG_BIT(13 + (dsb_id))
> -#define  GEN9_PIPE_CURSOR_FAULT		REG_BIT(11) /* skl+ */
> -#define  GEN9_PIPE_PLANE4_FAULT		REG_BIT(10) /* skl+ */
> -#define  GEN8_PIPE_CURSOR_FAULT		REG_BIT(10) /* bdw */
> -#define  GEN9_PIPE_PLANE3_FAULT		REG_BIT(9) /* skl+ */
> -#define  GEN8_PIPE_SPRITE_FAULT		REG_BIT(9) /* bdw */
> -#define  GEN9_PIPE_PLANE2_FAULT		REG_BIT(8) /* skl+ */
> -#define  GEN8_PIPE_PRIMARY_FAULT	REG_BIT(8) /* bdw */
> -#define  GEN9_PIPE_PLANE1_FAULT		REG_BIT(7) /* skl+ */
> -#define  GEN9_PIPE_PLANE4_FLIP_DONE	REG_BIT(6) /* skl+ */
> -#define  GEN9_PIPE_PLANE3_FLIP_DONE	REG_BIT(5) /* skl+ */
> -#define  GEN8_PIPE_SPRITE_FLIP_DONE	REG_BIT(5) /* bdw */
> -#define  GEN9_PIPE_PLANE2_FLIP_DONE	REG_BIT(4) /* skl+ */
> -#define  GEN8_PIPE_PRIMARY_FLIP_DONE	REG_BIT(4) /* bdw */
> -#define  GEN9_PIPE_PLANE1_FLIP_DONE	REG_BIT(3) /* skl+ */
> -#define  GEN9_PIPE_PLANE_FLIP_DONE(plane_id) \
> -	REG_BIT(((plane_id) >= PLANE_5 ? 16 - PLANE_5 : 3 - PLANE_1) +
> (plane_id)) /* skl+ */
> -#define  GEN8_PIPE_SCAN_LINE_EVENT	REG_BIT(2)
> -#define  GEN8_PIPE_VSYNC		REG_BIT(1)
> -#define  GEN8_PIPE_VBLANK		REG_BIT(0)
> -
> -#define GEN8_DE_PIPE_IRQ_REGS(pipe)
> 	I915_IRQ_REGS(GEN8_DE_PIPE_IMR(pipe), \
> -						      GEN8_DE_PIPE_IER(pipe),
> \
> -						      GEN8_DE_PIPE_IIR(pipe))
> -
>  #define _HPD_PIN_DDI(hpd_pin)	((hpd_pin) - HPD_PORT_A)
>  #define _HPD_PIN_TC(hpd_pin)	((hpd_pin) - HPD_PORT_TC1)
> 
> -#define GEN8_DE_PORT_ISR _MMIO(0x44440)
> -#define GEN8_DE_PORT_IMR _MMIO(0x44444)
> -#define GEN8_DE_PORT_IIR _MMIO(0x44448)
> -#define GEN8_DE_PORT_IER _MMIO(0x4444c)
> -#define  DSI1_NON_TE			(1 << 31)
> -#define  DSI0_NON_TE			(1 << 30)
> -#define  ICL_AUX_CHANNEL_E		(1 << 29)
> -#define  ICL_AUX_CHANNEL_F		(1 << 28)
> -#define  GEN9_AUX_CHANNEL_D		(1 << 27)
> -#define  GEN9_AUX_CHANNEL_C		(1 << 26)
> -#define  GEN9_AUX_CHANNEL_B		(1 << 25)
> -#define  DSI1_TE			(1 << 24)
> -#define  DSI0_TE			(1 << 23)
> -#define  GEN8_DE_PORT_HOTPLUG(hpd_pin)	REG_BIT(3 +
> _HPD_PIN_DDI(hpd_pin))
> -#define  BXT_DE_PORT_HOTPLUG_MASK
> 	(GEN8_DE_PORT_HOTPLUG(HPD_PORT_A) | \
> -
> GEN8_DE_PORT_HOTPLUG(HPD_PORT_B) | \
> -
> GEN8_DE_PORT_HOTPLUG(HPD_PORT_C))
> -#define  BDW_DE_PORT_HOTPLUG_MASK
> 	GEN8_DE_PORT_HOTPLUG(HPD_PORT_A)
> -#define  BXT_DE_PORT_GMBUS		(1 << 1)
> -#define  GEN8_AUX_CHANNEL_A		(1 << 0)
> -#define  TGL_DE_PORT_AUX_USBC6		REG_BIT(13)
> -#define  XELPD_DE_PORT_AUX_DDIE		REG_BIT(13)
> -#define  TGL_DE_PORT_AUX_USBC5		REG_BIT(12)
> -#define  XELPD_DE_PORT_AUX_DDID		REG_BIT(12)
> -#define  TGL_DE_PORT_AUX_USBC4		REG_BIT(11)
> -#define  TGL_DE_PORT_AUX_USBC3		REG_BIT(10)
> -#define  TGL_DE_PORT_AUX_USBC2		REG_BIT(9)
> -#define  TGL_DE_PORT_AUX_USBC1		REG_BIT(8)
> -#define  TGL_DE_PORT_AUX_DDIC		REG_BIT(2)
> -#define  TGL_DE_PORT_AUX_DDIB		REG_BIT(1)
> -#define  TGL_DE_PORT_AUX_DDIA		REG_BIT(0)
> -
> -#define GEN8_DE_PORT_IRQ_REGS
> 	I915_IRQ_REGS(GEN8_DE_PORT_IMR, \
> -						      GEN8_DE_PORT_IER, \
> -						      GEN8_DE_PORT_IIR)
> -
>  #define GEN8_DE_MISC_ISR _MMIO(0x44460)
>  #define GEN8_DE_MISC_IMR _MMIO(0x44464)
>  #define GEN8_DE_MISC_IIR _MMIO(0x44468)
> @@ -2258,10 +1060,6 @@
>  #define  XELPDP_PMDEMAND_RSP		REG_BIT(3)
>  #define  XE2LPD_DBUF_OVERLAP_DETECTED	REG_BIT(1)
> 
> -#define GEN8_DE_MISC_IRQ_REGS
> 	I915_IRQ_REGS(GEN8_DE_MISC_IMR, \
> -						      GEN8_DE_MISC_IER, \
> -						      GEN8_DE_MISC_IIR)
> -
>  #define GEN8_PCU_ISR _MMIO(0x444e0)
>  #define GEN8_PCU_IMR _MMIO(0x444e4)
>  #define GEN8_PCU_IIR _MMIO(0x444e8)
> @@ -2294,110 +1092,12 @@
>  #define   DG1_MSTR_IRQ			REG_BIT(31)
>  #define   DG1_MSTR_TILE(t)		REG_BIT(t)
> 
> -#define GEN11_DISPLAY_INT_CTL		_MMIO(0x44200)
> -#define  GEN11_DISPLAY_IRQ_ENABLE	(1 << 31)
> -#define  GEN11_AUDIO_CODEC_IRQ		(1 << 24)
> -#define  GEN11_DE_PCH_IRQ		(1 << 23)
> -#define  GEN11_DE_MISC_IRQ		(1 << 22)
> -#define  GEN11_DE_HPD_IRQ		(1 << 21)
> -#define  GEN11_DE_PORT_IRQ		(1 << 20)
> -#define  GEN11_DE_PIPE_C		(1 << 18)
> -#define  GEN11_DE_PIPE_B		(1 << 17)
> -#define  GEN11_DE_PIPE_A		(1 << 16)
> -
> -#define GEN11_DE_HPD_ISR		_MMIO(0x44470)
> -#define GEN11_DE_HPD_IMR		_MMIO(0x44474)
> -#define GEN11_DE_HPD_IIR		_MMIO(0x44478)
> -#define GEN11_DE_HPD_IER		_MMIO(0x4447c)
> -#define  GEN11_TC_HOTPLUG(hpd_pin)		REG_BIT(16 +
> _HPD_PIN_TC(hpd_pin))
> -#define  GEN11_DE_TC_HOTPLUG_MASK
> 	(GEN11_TC_HOTPLUG(HPD_PORT_TC6) | \
> -
> GEN11_TC_HOTPLUG(HPD_PORT_TC5) | \
> -
> GEN11_TC_HOTPLUG(HPD_PORT_TC4) | \
> -
> GEN11_TC_HOTPLUG(HPD_PORT_TC3) | \
> -
> GEN11_TC_HOTPLUG(HPD_PORT_TC2) | \
> -
> GEN11_TC_HOTPLUG(HPD_PORT_TC1))
> -#define  GEN11_TBT_HOTPLUG(hpd_pin)
> 	REG_BIT(_HPD_PIN_TC(hpd_pin))
> -#define  GEN11_DE_TBT_HOTPLUG_MASK
> 	(GEN11_TBT_HOTPLUG(HPD_PORT_TC6) | \
> -
> GEN11_TBT_HOTPLUG(HPD_PORT_TC5) | \
> -
> GEN11_TBT_HOTPLUG(HPD_PORT_TC4) | \
> -
> GEN11_TBT_HOTPLUG(HPD_PORT_TC3) | \
> -
> GEN11_TBT_HOTPLUG(HPD_PORT_TC2) | \
> -
> GEN11_TBT_HOTPLUG(HPD_PORT_TC1))
> -
> -#define GEN11_DE_HPD_IRQ_REGS
> 	I915_IRQ_REGS(GEN11_DE_HPD_IMR, \
> -						      GEN11_DE_HPD_IER, \
> -						      GEN11_DE_HPD_IIR)
> -
> -#define GEN11_TBT_HOTPLUG_CTL
> 	_MMIO(0x44030)
> -#define GEN11_TC_HOTPLUG_CTL
> 	_MMIO(0x44038)
> -#define  GEN11_HOTPLUG_CTL_ENABLE(hpd_pin)		(8 <<
> (_HPD_PIN_TC(hpd_pin) * 4))
> -#define  GEN11_HOTPLUG_CTL_LONG_DETECT(hpd_pin)		(2 <<
> (_HPD_PIN_TC(hpd_pin) * 4))
> -#define  GEN11_HOTPLUG_CTL_SHORT_DETECT(hpd_pin)	(1 <<
> (_HPD_PIN_TC(hpd_pin) * 4))
> -#define  GEN11_HOTPLUG_CTL_NO_DETECT(hpd_pin)		(0 <<
> (_HPD_PIN_TC(hpd_pin) * 4))
> -
> -#define PICAINTERRUPT_ISR			_MMIO(0x16FE50)
> -#define PICAINTERRUPT_IMR			_MMIO(0x16FE54)
> -#define PICAINTERRUPT_IIR			_MMIO(0x16FE58)
> -#define PICAINTERRUPT_IER			_MMIO(0x16FE5C)
> -#define  XELPDP_DP_ALT_HOTPLUG(hpd_pin)		REG_BIT(16 +
> _HPD_PIN_TC(hpd_pin))
> -#define  XELPDP_DP_ALT_HOTPLUG_MASK		REG_GENMASK(19,
> 16)
> -#define  XELPDP_AUX_TC(hpd_pin)			REG_BIT(8 +
> _HPD_PIN_TC(hpd_pin))
> -#define  XELPDP_AUX_TC_MASK			REG_GENMASK(11, 8)
> -#define  XE2LPD_AUX_DDI(hpd_pin)		REG_BIT(6 +
> _HPD_PIN_DDI(hpd_pin))
> -#define  XE2LPD_AUX_DDI_MASK			REG_GENMASK(7, 6)
> -#define  XELPDP_TBT_HOTPLUG(hpd_pin)
> 	REG_BIT(_HPD_PIN_TC(hpd_pin))
> -#define  XELPDP_TBT_HOTPLUG_MASK		REG_GENMASK(3, 0)
> -
> -#define PICAINTERRUPT_IRQ_REGS
> 	I915_IRQ_REGS(PICAINTERRUPT_IMR, \
> -
> PICAINTERRUPT_IER, \
> -
> PICAINTERRUPT_IIR)
> -
> -#define XELPDP_PORT_HOTPLUG_CTL(hpd_pin)	_MMIO(0x16F270 +
> (_HPD_PIN_TC(hpd_pin) * 0x200))
> -#define  XELPDP_TBT_HOTPLUG_ENABLE		REG_BIT(6)
> -#define  XELPDP_TBT_HPD_LONG_DETECT		REG_BIT(5)
> -#define  XELPDP_TBT_HPD_SHORT_DETECT		REG_BIT(4)
> -#define  XELPDP_DP_ALT_HOTPLUG_ENABLE		REG_BIT(2)
> -#define  XELPDP_DP_ALT_HPD_LONG_DETECT		REG_BIT(1)
> -#define  XELPDP_DP_ALT_HPD_SHORT_DETECT		REG_BIT(0)
> -
> -#define XELPDP_INITIATE_PMDEMAND_REQUEST(dword)
> 	_MMIO(0x45230 + 4 * (dword))
> -#define  XELPDP_PMDEMAND_QCLK_GV_BW_MASK
> 	REG_GENMASK(31, 16)
> -#define  XELPDP_PMDEMAND_VOLTAGE_INDEX_MASK
> 	REG_GENMASK(14, 12)
> -#define  XELPDP_PMDEMAND_QCLK_GV_INDEX_MASK
> 	REG_GENMASK(11, 8)
> -#define  XE3_PMDEMAND_PIPES_MASK
> 	REG_GENMASK(7, 4)
> -#define  XELPDP_PMDEMAND_PIPES_MASK
> 	REG_GENMASK(7, 6)
> -#define  XELPDP_PMDEMAND_DBUFS_MASK
> 	REG_GENMASK(5, 4)
> -#define  XELPDP_PMDEMAND_PHYS_MASK
> 	REG_GENMASK(2, 0)
> -
> -#define  XELPDP_PMDEMAND_REQ_ENABLE			REG_BIT(31)
> -#define  XELPDP_PMDEMAND_CDCLK_FREQ_MASK
> 	REG_GENMASK(30, 20)
> -#define  XELPDP_PMDEMAND_DDICLK_FREQ_MASK
> 	REG_GENMASK(18, 8)
> -#define  XELPDP_PMDEMAND_SCALERS_MASK
> 	REG_GENMASK(6, 4)
> -#define  XELPDP_PMDEMAND_PLLS_MASK
> 	REG_GENMASK(2, 0)
> -
> -#define GEN12_DCPR_STATUS_1
> 	_MMIO(0x46440)
> -#define  XELPDP_PMDEMAND_INFLIGHT_STATUS		REG_BIT(26)
> -
>  #define ILK_DISPLAY_CHICKEN2	_MMIO(0x42004)
>  /* Required on all Ironlake and Sandybridge according to the B-Spec. */
>  #define   ILK_ELPIN_409_SELECT	REG_BIT(25)
>  #define   ILK_DPARB_GATE	REG_BIT(22)
>  #define   ILK_VSDPFD_FULL	REG_BIT(21)
> 
> -#define FUSE_STRAP		_MMIO(0x42014)
> -#define   ILK_INTERNAL_GRAPHICS_DISABLE	REG_BIT(31)
> -#define   ILK_INTERNAL_DISPLAY_DISABLE	REG_BIT(30)
> -#define   ILK_DISPLAY_DEBUG_DISABLE	REG_BIT(29)
> -#define   IVB_PIPE_C_DISABLE		REG_BIT(28)
> -#define   ILK_HDCP_DISABLE		REG_BIT(25)
> -#define   ILK_eDP_A_DISABLE		REG_BIT(24)
> -#define   HSW_CDCLK_LIMIT		REG_BIT(24)
> -#define   ILK_DESKTOP			REG_BIT(23)
> -#define   HSW_CPU_SSC_ENABLE		REG_BIT(21)
> -
> -#define FUSE_STRAP3		_MMIO(0x42020)
> -#define   HSW_REF_CLK_SELECT		REG_BIT(1)
> -
>  #define ILK_DSPCLK_GATE_D	_MMIO(0x42020)
>  #define   ILK_VRHUNIT_CLOCK_GATE_DISABLE	REG_BIT(28)
>  #define   ILK_DPFCUNIT_CLOCK_GATE_DISABLE	REG_BIT(9)
> @@ -2422,25 +1122,6 @@
>  #define CHICKEN_PAR2_1		_MMIO(0x42090)
>  #define   KVM_CONFIG_CHANGE_NOTIFICATION_SELECT	REG_BIT(14)
> 
> -#define CHICKEN_MISC_2		_MMIO(0x42084)
> -#define   CHICKEN_MISC_DISABLE_DPT	REG_BIT(30) /* adl,dg2 */
> -#define   BMG_DARB_HALF_BLK_END_BURST	REG_BIT(27)
> -#define   KBL_ARB_FILL_SPARE_14		REG_BIT(14)
> -#define   KBL_ARB_FILL_SPARE_13		REG_BIT(13)
> -#define   GLK_CL2_PWR_DOWN		REG_BIT(12)
> -#define   GLK_CL1_PWR_DOWN		REG_BIT(11)
> -#define   GLK_CL0_PWR_DOWN		REG_BIT(10)
> -
> -#define CHICKEN_MISC_3		_MMIO(0x42088)
> -#define   DP_MST_DPT_DPTP_ALIGN_WA(trans)	REG_BIT(9 + (trans) -
> TRANSCODER_A)
> -#define   DP_MST_SHORT_HBLANK_WA(trans)		REG_BIT(5 + (trans) -
> TRANSCODER_A)
> -#define   DP_MST_FEC_BS_JITTER_WA(trans)	REG_BIT(0 + (trans) -
> TRANSCODER_A)
> -
> -#define CHICKEN_MISC_4		_MMIO(0x4208c)
> -#define   CHICKEN_FBC_STRIDE_OVERRIDE	REG_BIT(13)
> -#define   CHICKEN_FBC_STRIDE_MASK	REG_GENMASK(12, 0)
> -#define   CHICKEN_FBC_STRIDE(x)
> 	REG_FIELD_PREP(CHICKEN_FBC_STRIDE_MASK, (x))
> -
>  #define _CHICKEN_PIPESL_1_A	0x420b0
>  #define _CHICKEN_PIPESL_1_B	0x420b4
>  #define CHICKEN_PIPESL_1(pipe)	_MMIO_PIPE(pipe,
> _CHICKEN_PIPESL_1_A, _CHICKEN_PIPESL_1_B)
> @@ -2464,72 +1145,11 @@
>  #define   SKL_PLANE1_STRETCH_MAX_X1
> 	REG_FIELD_PREP(SKL_PLANE1_STRETCH_MAX_MASK, 3)
>  #define   BDW_UNMASK_VBL_TO_REGS_IN_SRD	REG_BIT(0) /* bdw */
> 
> -#define _CHICKEN_TRANS_A	0x420c0
> -#define _CHICKEN_TRANS_B	0x420c4
> -#define _CHICKEN_TRANS_C	0x420c8
> -#define _CHICKEN_TRANS_EDP	0x420cc
> -#define _CHICKEN_TRANS_D	0x420d8
> -#define _CHICKEN_TRANS(trans)	_MMIO(_PICK((trans), \
> -					    [TRANSCODER_EDP] =
> _CHICKEN_TRANS_EDP, \
> -					    [TRANSCODER_A] =
> _CHICKEN_TRANS_A, \
> -					    [TRANSCODER_B] =
> _CHICKEN_TRANS_B, \
> -					    [TRANSCODER_C] =
> _CHICKEN_TRANS_C, \
> -					    [TRANSCODER_D] =
> _CHICKEN_TRANS_D))
> -#define _MTL_CHICKEN_TRANS_A	0x604e0
> -#define _MTL_CHICKEN_TRANS_B	0x614e0
> -#define _MTL_CHICKEN_TRANS(trans)	_MMIO_TRANS((trans), \
> -						    _MTL_CHICKEN_TRANS_A,
> \
> -						    _MTL_CHICKEN_TRANS_B)
> -#define CHICKEN_TRANS(display, trans)	(DISPLAY_VER(display) >= 14 ?
> _MTL_CHICKEN_TRANS(trans) : _CHICKEN_TRANS(trans))
> -#define   PIPE_VBLANK_WITH_DELAY	REG_BIT(31) /* tgl+ */
> -#define   SKL_UNMASK_VBL_TO_PIPE_IN_SRD	REG_BIT(30) /* skl+ */
> -#define   HSW_FRAME_START_DELAY_MASK	REG_GENMASK(28, 27)
> -#define   HSW_FRAME_START_DELAY(x)
> 	REG_FIELD_PREP(HSW_FRAME_START_DELAY_MASK, x)
> -#define   VSC_DATA_SEL_SOFTWARE_CONTROL	REG_BIT(25) /* GLK
> */
> -#define   FECSTALL_DIS_DPTSTREAM_DPTTG	REG_BIT(23)
> -#define   DDI_TRAINING_OVERRIDE_ENABLE	REG_BIT(19)
> -#define   ADLP_1_BASED_X_GRANULARITY	REG_BIT(18)
> -#define   DDI_TRAINING_OVERRIDE_VALUE	REG_BIT(18)
> -#define   DDIE_TRAINING_OVERRIDE_ENABLE	REG_BIT(17) /*
> CHICKEN_TRANS_A only */
> -#define   DDIE_TRAINING_OVERRIDE_VALUE	REG_BIT(16) /*
> CHICKEN_TRANS_A only */
> -#define   PSR2_ADD_VERTICAL_LINE_COUNT	REG_BIT(15)
> -#define   DP_FEC_BS_JITTER_WA		REG_BIT(15)
> -#define   PSR2_VSC_ENABLE_PROG_HEADER	REG_BIT(12)
> -#define   DP_DSC_INSERT_SF_AT_EOL_WA	REG_BIT(4)
> -#define   HDCP_LINE_REKEY_DISABLE	REG_BIT(0)
> -
>  #define DISP_ARB_CTL	_MMIO(0x45000)
>  #define   DISP_FBC_MEMORY_WAKE		REG_BIT(31)
>  #define   DISP_TILE_SURFACE_SWIZZLING	REG_BIT(13)
>  #define   DISP_FBC_WM_DIS		REG_BIT(15)
> 
> -#define DISP_ARB_CTL2	_MMIO(0x45004)
> -#define   DISP_DATA_PARTITION_5_6	REG_BIT(6)
> -#define   DISP_IPC_ENABLE		REG_BIT(3)
> -
> -#define GEN7_MSG_CTL	_MMIO(0x45010)
> -#define  WAIT_FOR_PCH_RESET_ACK		(1 << 1)
> -#define  WAIT_FOR_PCH_FLR_ACK		(1 << 0)
> -
> -#define _BW_BUDDY0_CTL			0x45130
> -#define _BW_BUDDY1_CTL			0x45140
> -#define BW_BUDDY_CTL(x)			_MMIO(_PICK_EVEN(x, \
> -							 _BW_BUDDY0_CTL, \
> -							 _BW_BUDDY1_CTL))
> -#define   BW_BUDDY_DISABLE		REG_BIT(31)
> -#define   BW_BUDDY_TLB_REQ_TIMER_MASK	REG_GENMASK(21, 16)
> -#define   BW_BUDDY_TLB_REQ_TIMER(x)
> 	REG_FIELD_PREP(BW_BUDDY_TLB_REQ_TIMER_MASK, x)
> -
> -#define _BW_BUDDY0_PAGE_MASK		0x45134
> -#define _BW_BUDDY1_PAGE_MASK		0x45144
> -#define BW_BUDDY_PAGE_MASK(x)		_MMIO(_PICK_EVEN(x, \
> -
> _BW_BUDDY0_PAGE_MASK, \
> -
> _BW_BUDDY1_PAGE_MASK))
> -
> -#define HSW_NDE_RSTWRN_OPT	_MMIO(0x46408)
> -#define  MTL_RESET_PICA_HANDSHAKE_EN	REG_BIT(6)
> -#define  RESET_PCH_HANDSHAKE_ENABLE	REG_BIT(4)
> -
>  #define GEN8_CHICKEN_DCPR_1			_MMIO(0x46430)
>  #define   _LATENCY_REPORTING_REMOVED_PIPE_D	REG_BIT(31)
>  #define   SKL_SELECT_ALTERNATE_DC_EXIT		REG_BIT(30)
> @@ -2546,171 +1166,13 @@
>  #define   MASK_WAKEMEM				REG_BIT(13)
>  #define   DDI_CLOCK_REG_ACCESS			REG_BIT(7)
> 
> -#define GEN11_CHICKEN_DCPR_2			_MMIO(0x46434)
> -#define   DCPR_MASK_MAXLATENCY_MEMUP_CLR	REG_BIT(27)
> -#define   DCPR_MASK_LPMODE			REG_BIT(26)
> -#define   DCPR_SEND_RESP_IMM			REG_BIT(25)
> -#define   DCPR_CLEAR_MEMSTAT_DIS		REG_BIT(24)
> -
> -#define XELPD_CHICKEN_DCPR_3			_MMIO(0x46438)
> -#define   DMD_RSP_TIMEOUT_DISABLE		REG_BIT(19)
> -
> -#define SKL_DFSM			_MMIO(0x51000)
> -#define   SKL_DFSM_DISPLAY_PM_DISABLE	(1 << 27)
> -#define   SKL_DFSM_DISPLAY_HDCP_DISABLE	(1 << 25)
> -#define   SKL_DFSM_CDCLK_LIMIT_MASK	(3 << 23)
> -#define   SKL_DFSM_CDCLK_LIMIT_675	(0 << 23)
> -#define   SKL_DFSM_CDCLK_LIMIT_540	(1 << 23)
> -#define   SKL_DFSM_CDCLK_LIMIT_450	(2 << 23)
> -#define   SKL_DFSM_CDCLK_LIMIT_337_5	(3 << 23)
> -#define   ICL_DFSM_DMC_DISABLE		(1 << 23)
> -#define   SKL_DFSM_PIPE_A_DISABLE	(1 << 30)
> -#define   SKL_DFSM_PIPE_B_DISABLE	(1 << 21)
> -#define   SKL_DFSM_PIPE_C_DISABLE	(1 << 28)
> -#define   TGL_DFSM_PIPE_D_DISABLE	(1 << 22)
> -#define   GLK_DFSM_DISPLAY_DSC_DISABLE	(1 << 7)
> -#define   XE2LPD_DFSM_DBUF_OVERLAP_DISABLE	(1 << 3)
> -
> -#define XE2LPD_DE_CAP			_MMIO(0x41100)
> -#define   XE2LPD_DE_CAP_3DLUT_MASK	REG_GENMASK(31, 30)
> -#define   XE2LPD_DE_CAP_DSC_MASK	REG_GENMASK(29, 28)
> -#define   XE2LPD_DE_CAP_DSC_REMOVED	1
> -#define   XE2LPD_DE_CAP_SCALER_MASK	REG_GENMASK(27, 26)
> -#define   XE2LPD_DE_CAP_SCALER_SINGLE	1
> -
> -#define SKL_DSSM				_MMIO(0x51004)
> -#define ICL_DSSM_CDCLK_PLL_REFCLK_MASK		(7 << 29)
> -#define ICL_DSSM_CDCLK_PLL_REFCLK_24MHz		(0 << 29)
> -#define ICL_DSSM_CDCLK_PLL_REFCLK_19_2MHz	(1 << 29)
> -#define ICL_DSSM_CDCLK_PLL_REFCLK_38_4MHz	(2 << 29)
> -
>  #define GMD_ID_DISPLAY				_MMIO(0x510a0)
>  #define   GMD_ID_ARCH_MASK			REG_GENMASK(31,
> 22)
>  #define   GMD_ID_RELEASE_MASK			REG_GENMASK(21,
> 14)
>  #define   GMD_ID_STEP				REG_GENMASK(5, 0)
> 
> -/*GEN11 chicken */
> -#define _PIPEA_CHICKEN				0x70038
> -#define _PIPEB_CHICKEN				0x71038
> -#define _PIPEC_CHICKEN				0x72038
> -#define PIPE_CHICKEN(pipe)			_MMIO_PIPE(pipe,
> _PIPEA_CHICKEN,\
> -							   _PIPEB_CHICKEN)
> -#define   UNDERRUN_RECOVERY_DISABLE_ADLP	REG_BIT(30)
> -#define   UNDERRUN_RECOVERY_ENABLE_DG2		REG_BIT(30)
> -#define   PIXEL_ROUNDING_TRUNC_FB_PASSTHRU	REG_BIT(15)
> -#define   DG2_RENDER_CCSTAG_4_3_EN		REG_BIT(12)
> -#define   PER_PIXEL_ALPHA_BYPASS_EN		REG_BIT(7)
> -
>  /* PCH */
> 
> -#define PCH_DISPLAY_BASE	0xc0000u
> -
> -/* south display engine interrupt: IBX */
> -#define SDE_AUDIO_POWER_D	(1 << 27)
> -#define SDE_AUDIO_POWER_C	(1 << 26)
> -#define SDE_AUDIO_POWER_B	(1 << 25)
> -#define SDE_AUDIO_POWER_SHIFT	(25)
> -#define SDE_AUDIO_POWER_MASK	(7 << SDE_AUDIO_POWER_SHIFT)
> -#define SDE_GMBUS		(1 << 24)
> -#define SDE_AUDIO_HDCP_TRANSB	(1 << 23)
> -#define SDE_AUDIO_HDCP_TRANSA	(1 << 22)
> -#define SDE_AUDIO_HDCP_MASK	(3 << 22)
> -#define SDE_AUDIO_TRANSB	(1 << 21)
> -#define SDE_AUDIO_TRANSA	(1 << 20)
> -#define SDE_AUDIO_TRANS_MASK	(3 << 20)
> -#define SDE_POISON		(1 << 19)
> -/* 18 reserved */
> -#define SDE_FDI_RXB		(1 << 17)
> -#define SDE_FDI_RXA		(1 << 16)
> -#define SDE_FDI_MASK		(3 << 16)
> -#define SDE_AUXD		(1 << 15)
> -#define SDE_AUXC		(1 << 14)
> -#define SDE_AUXB		(1 << 13)
> -#define SDE_AUX_MASK		(7 << 13)
> -/* 12 reserved */
> -#define SDE_CRT_HOTPLUG         (1 << 11)
> -#define SDE_PORTD_HOTPLUG       (1 << 10)
> -#define SDE_PORTC_HOTPLUG       (1 << 9)
> -#define SDE_PORTB_HOTPLUG       (1 << 8)
> -#define SDE_SDVOB_HOTPLUG       (1 << 6)
> -#define SDE_HOTPLUG_MASK        (SDE_CRT_HOTPLUG | \
> -				 SDE_SDVOB_HOTPLUG |	\
> -				 SDE_PORTB_HOTPLUG |	\
> -				 SDE_PORTC_HOTPLUG |	\
> -				 SDE_PORTD_HOTPLUG)
> -#define SDE_TRANSB_CRC_DONE	(1 << 5)
> -#define SDE_TRANSB_CRC_ERR	(1 << 4)
> -#define SDE_TRANSB_FIFO_UNDER	(1 << 3)
> -#define SDE_TRANSA_CRC_DONE	(1 << 2)
> -#define SDE_TRANSA_CRC_ERR	(1 << 1)
> -#define SDE_TRANSA_FIFO_UNDER	(1 << 0)
> -#define SDE_TRANS_MASK		(0x3f)
> -
> -/* south display engine interrupt: CPT - CNP */
> -#define SDE_AUDIO_POWER_D_CPT	(1 << 31)
> -#define SDE_AUDIO_POWER_C_CPT	(1 << 30)
> -#define SDE_AUDIO_POWER_B_CPT	(1 << 29)
> -#define SDE_AUDIO_POWER_SHIFT_CPT   29
> -#define SDE_AUDIO_POWER_MASK_CPT    (7 << 29)
> -#define SDE_AUXD_CPT		(1 << 27)
> -#define SDE_AUXC_CPT		(1 << 26)
> -#define SDE_AUXB_CPT		(1 << 25)
> -#define SDE_AUX_MASK_CPT	(7 << 25)
> -#define SDE_PORTE_HOTPLUG_SPT	(1 << 25)
> -#define SDE_PORTA_HOTPLUG_SPT	(1 << 24)
> -#define SDE_PORTD_HOTPLUG_CPT	(1 << 23)
> -#define SDE_PORTC_HOTPLUG_CPT	(1 << 22)
> -#define SDE_PORTB_HOTPLUG_CPT	(1 << 21)
> -#define SDE_CRT_HOTPLUG_CPT	(1 << 19)
> -#define SDE_SDVOB_HOTPLUG_CPT	(1 << 18)
> -#define SDE_HOTPLUG_MASK_CPT	(SDE_CRT_HOTPLUG_CPT |
> 	\
> -				 SDE_SDVOB_HOTPLUG_CPT |	\
> -				 SDE_PORTD_HOTPLUG_CPT |	\
> -				 SDE_PORTC_HOTPLUG_CPT |	\
> -				 SDE_PORTB_HOTPLUG_CPT)
> -#define SDE_HOTPLUG_MASK_SPT	(SDE_PORTE_HOTPLUG_SPT |	\
> -				 SDE_PORTD_HOTPLUG_CPT |	\
> -				 SDE_PORTC_HOTPLUG_CPT |	\
> -				 SDE_PORTB_HOTPLUG_CPT |	\
> -				 SDE_PORTA_HOTPLUG_SPT)
> -#define SDE_GMBUS_CPT		(1 << 17)
> -#define SDE_ERROR_CPT		(1 << 16)
> -#define SDE_AUDIO_CP_REQ_C_CPT	(1 << 10)
> -#define SDE_AUDIO_CP_CHG_C_CPT	(1 << 9)
> -#define SDE_FDI_RXC_CPT		(1 << 8)
> -#define SDE_AUDIO_CP_REQ_B_CPT	(1 << 6)
> -#define SDE_AUDIO_CP_CHG_B_CPT	(1 << 5)
> -#define SDE_FDI_RXB_CPT		(1 << 4)
> -#define SDE_AUDIO_CP_REQ_A_CPT	(1 << 2)
> -#define SDE_AUDIO_CP_CHG_A_CPT	(1 << 1)
> -#define SDE_FDI_RXA_CPT		(1 << 0)
> -#define SDE_AUDIO_CP_REQ_CPT	(SDE_AUDIO_CP_REQ_C_CPT | \
> -				 SDE_AUDIO_CP_REQ_B_CPT | \
> -				 SDE_AUDIO_CP_REQ_A_CPT)
> -#define SDE_AUDIO_CP_CHG_CPT	(SDE_AUDIO_CP_CHG_C_CPT | \
> -				 SDE_AUDIO_CP_CHG_B_CPT | \
> -				 SDE_AUDIO_CP_CHG_A_CPT)
> -#define SDE_FDI_MASK_CPT	(SDE_FDI_RXC_CPT | \
> -				 SDE_FDI_RXB_CPT | \
> -				 SDE_FDI_RXA_CPT)
> -
> -/* south display engine interrupt: ICP/TGP/MTP */
> -#define SDE_PICAINTERRUPT		REG_BIT(31)
> -#define SDE_GMBUS_ICP			(1 << 23)
> -#define SDE_TC_HOTPLUG_ICP(hpd_pin)	REG_BIT(24 +
> _HPD_PIN_TC(hpd_pin))
> -#define SDE_TC_HOTPLUG_DG2(hpd_pin)	REG_BIT(25 +
> _HPD_PIN_TC(hpd_pin)) /* sigh */
> -#define SDE_DDI_HOTPLUG_ICP(hpd_pin)	REG_BIT(16 +
> _HPD_PIN_DDI(hpd_pin))
> -#define SDE_DDI_HOTPLUG_MASK_ICP
> 	(SDE_DDI_HOTPLUG_ICP(HPD_PORT_D) | \
> -
> SDE_DDI_HOTPLUG_ICP(HPD_PORT_C) | \
> -
> SDE_DDI_HOTPLUG_ICP(HPD_PORT_B) | \
> -
> SDE_DDI_HOTPLUG_ICP(HPD_PORT_A))
> -#define SDE_TC_HOTPLUG_MASK_ICP
> 	(SDE_TC_HOTPLUG_ICP(HPD_PORT_TC6) | \
> -
> SDE_TC_HOTPLUG_ICP(HPD_PORT_TC5) | \
> -
> SDE_TC_HOTPLUG_ICP(HPD_PORT_TC4) | \
> -
> SDE_TC_HOTPLUG_ICP(HPD_PORT_TC3) | \
> -
> SDE_TC_HOTPLUG_ICP(HPD_PORT_TC2) | \
> -
> SDE_TC_HOTPLUG_ICP(HPD_PORT_TC1))
> -
>  #define SDEISR  _MMIO(0xc4000)
>  #define SDEIMR  _MMIO(0xc4004)
>  #define SDEIIR  _MMIO(0xc4008)
> @@ -2724,288 +1186,13 @@
>  #define  SERR_INT_POISON		(1 << 31)
>  #define  SERR_INT_TRANS_FIFO_UNDERRUN(pipe)	(1 << ((pipe) * 3))
> 
> -/* digital port hotplug */
> -#define PCH_PORT_HOTPLUG		_MMIO(0xc4030)	/*
> SHOTPLUG_CTL */
> -#define  PORTA_HOTPLUG_ENABLE		(1 << 28) /* LPT:LP+ & BXT */
> -#define  BXT_DDIA_HPD_INVERT            (1 << 27)
> -#define  PORTA_HOTPLUG_STATUS_MASK	(3 << 24) /* SPT+ & BXT */
> -#define  PORTA_HOTPLUG_NO_DETECT	(0 << 24) /* SPT+ & BXT */
> -#define  PORTA_HOTPLUG_SHORT_DETECT	(1 << 24) /* SPT+ & BXT */
> -#define  PORTA_HOTPLUG_LONG_DETECT	(2 << 24) /* SPT+ & BXT */
> -#define  PORTD_HOTPLUG_ENABLE		(1 << 20)
> -#define  PORTD_PULSE_DURATION_2ms	(0 << 18) /* pre-LPT */
> -#define  PORTD_PULSE_DURATION_4_5ms	(1 << 18) /* pre-LPT */
> -#define  PORTD_PULSE_DURATION_6ms	(2 << 18) /* pre-LPT */
> -#define  PORTD_PULSE_DURATION_100ms	(3 << 18) /* pre-LPT */
> -#define  PORTD_PULSE_DURATION_MASK	(3 << 18) /* pre-LPT */
> -#define  PORTD_HOTPLUG_STATUS_MASK	(3 << 16)
> -#define  PORTD_HOTPLUG_NO_DETECT	(0 << 16)
> -#define  PORTD_HOTPLUG_SHORT_DETECT	(1 << 16)
> -#define  PORTD_HOTPLUG_LONG_DETECT	(2 << 16)
> -#define  PORTC_HOTPLUG_ENABLE		(1 << 12)
> -#define  BXT_DDIC_HPD_INVERT            (1 << 11)
> -#define  PORTC_PULSE_DURATION_2ms	(0 << 10) /* pre-LPT */
> -#define  PORTC_PULSE_DURATION_4_5ms	(1 << 10) /* pre-LPT */
> -#define  PORTC_PULSE_DURATION_6ms	(2 << 10) /* pre-LPT */
> -#define  PORTC_PULSE_DURATION_100ms	(3 << 10) /* pre-LPT */
> -#define  PORTC_PULSE_DURATION_MASK	(3 << 10) /* pre-LPT */
> -#define  PORTC_HOTPLUG_STATUS_MASK	(3 << 8)
> -#define  PORTC_HOTPLUG_NO_DETECT	(0 << 8)
> -#define  PORTC_HOTPLUG_SHORT_DETECT	(1 << 8)
> -#define  PORTC_HOTPLUG_LONG_DETECT	(2 << 8)
> -#define  PORTB_HOTPLUG_ENABLE		(1 << 4)
> -#define  BXT_DDIB_HPD_INVERT            (1 << 3)
> -#define  PORTB_PULSE_DURATION_2ms	(0 << 2) /* pre-LPT */
> -#define  PORTB_PULSE_DURATION_4_5ms	(1 << 2) /* pre-LPT */
> -#define  PORTB_PULSE_DURATION_6ms	(2 << 2) /* pre-LPT */
> -#define  PORTB_PULSE_DURATION_100ms	(3 << 2) /* pre-LPT */
> -#define  PORTB_PULSE_DURATION_MASK	(3 << 2) /* pre-LPT */
> -#define  PORTB_HOTPLUG_STATUS_MASK	(3 << 0)
> -#define  PORTB_HOTPLUG_NO_DETECT	(0 << 0)
> -#define  PORTB_HOTPLUG_SHORT_DETECT	(1 << 0)
> -#define  PORTB_HOTPLUG_LONG_DETECT	(2 << 0)
> -#define  BXT_DDI_HPD_INVERT_MASK	(BXT_DDIA_HPD_INVERT | \
> -					BXT_DDIB_HPD_INVERT | \
> -					BXT_DDIC_HPD_INVERT)
> -
> -#define PCH_PORT_HOTPLUG2		_MMIO(0xc403C)	/*
> SHOTPLUG_CTL2 SPT+ */
> -#define  PORTE_HOTPLUG_ENABLE		(1 << 4)
> -#define  PORTE_HOTPLUG_STATUS_MASK	(3 << 0)
> -#define  PORTE_HOTPLUG_NO_DETECT	(0 << 0)
> -#define  PORTE_HOTPLUG_SHORT_DETECT	(1 << 0)
> -#define  PORTE_HOTPLUG_LONG_DETECT	(2 << 0)
> -
> -/* This register is a reuse of PCH_PORT_HOTPLUG register. The
> - * functionality covered in PCH_PORT_HOTPLUG is split into
> - * SHOTPLUG_CTL_DDI and SHOTPLUG_CTL_TC.
> - */
> -#define SHOTPLUG_CTL_DDI				_MMIO(0xc4030)
> -#define   SHOTPLUG_CTL_DDI_HPD_ENABLE(hpd_pin)			(0x8
> << (_HPD_PIN_DDI(hpd_pin) * 4))
> -#define   SHOTPLUG_CTL_DDI_HPD_OUTPUT_DATA(hpd_pin)		(0x4
> << (_HPD_PIN_DDI(hpd_pin) * 4))
> -#define   SHOTPLUG_CTL_DDI_HPD_STATUS_MASK(hpd_pin)		(0x3
> << (_HPD_PIN_DDI(hpd_pin) * 4))
> -#define   SHOTPLUG_CTL_DDI_HPD_NO_DETECT(hpd_pin)		(0x0
> << (_HPD_PIN_DDI(hpd_pin) * 4))
> -#define   SHOTPLUG_CTL_DDI_HPD_SHORT_DETECT(hpd_pin)		(0x1
> << (_HPD_PIN_DDI(hpd_pin) * 4))
> -#define   SHOTPLUG_CTL_DDI_HPD_LONG_DETECT(hpd_pin)		(0x2
> << (_HPD_PIN_DDI(hpd_pin) * 4))
> -#define   SHOTPLUG_CTL_DDI_HPD_SHORT_LONG_DETECT(hpd_pin)	(0x3
> << (_HPD_PIN_DDI(hpd_pin) * 4))
> -
> -#define SHOTPLUG_CTL_TC				_MMIO(0xc4034)
> -#define   ICP_TC_HPD_ENABLE(hpd_pin)		(8 <<
> (_HPD_PIN_TC(hpd_pin) * 4))
> -#define   ICP_TC_HPD_LONG_DETECT(hpd_pin)	(2 <<
> (_HPD_PIN_TC(hpd_pin) * 4))
> -#define   ICP_TC_HPD_SHORT_DETECT(hpd_pin)	(1 <<
> (_HPD_PIN_TC(hpd_pin) * 4))
> -
> -#define SHPD_FILTER_CNT				_MMIO(0xc4038)
> -#define   SHPD_FILTER_CNT_500_ADJ		0x001D9
> -#define   SHPD_FILTER_CNT_250			0x000F8
> -
> -#define _PCH_DPLL_A              0xc6014
> -#define _PCH_DPLL_B              0xc6018
> -#define PCH_DPLL(pll) _MMIO((pll) == 0 ? _PCH_DPLL_A : _PCH_DPLL_B)
> -
> -#define _PCH_FPA0                0xc6040
> -#define _PCH_FPB0                0xc6048
> -#define PCH_FP0(pll) _MMIO((pll) == 0 ? _PCH_FPA0 : _PCH_FPB0)
> -#define  FP_CB_TUNE		(0x3 << 22)
> -
> -#define _PCH_FPA1                0xc6044
> -#define _PCH_FPB1                0xc604c
> -#define PCH_FP1(pll) _MMIO((pll) == 0 ? _PCH_FPA1 : _PCH_FPB1)
> -
>  #define PCH_DPLL_TEST           _MMIO(0xc606c)
> 
> -#define PCH_DREF_CONTROL        _MMIO(0xC6200)
> -#define  DREF_CONTROL_MASK      0x7fc3
> -#define  DREF_CPU_SOURCE_OUTPUT_DISABLE         (0 << 13)
> -#define  DREF_CPU_SOURCE_OUTPUT_DOWNSPREAD      (2 << 13)
> -#define  DREF_CPU_SOURCE_OUTPUT_NONSPREAD       (3 << 13)
> -#define  DREF_CPU_SOURCE_OUTPUT_MASK		(3 << 13)
> -#define  DREF_SSC_SOURCE_DISABLE                (0 << 11)
> -#define  DREF_SSC_SOURCE_ENABLE                 (2 << 11)
> -#define  DREF_SSC_SOURCE_MASK			(3 << 11)
> -#define  DREF_NONSPREAD_SOURCE_DISABLE          (0 << 9)
> -#define  DREF_NONSPREAD_CK505_ENABLE		(1 << 9)
> -#define  DREF_NONSPREAD_SOURCE_ENABLE           (2 << 9)
> -#define  DREF_NONSPREAD_SOURCE_MASK		(3 << 9)
> -#define  DREF_SUPERSPREAD_SOURCE_DISABLE        (0 << 7)
> -#define  DREF_SUPERSPREAD_SOURCE_ENABLE         (2 << 7)
> -#define  DREF_SUPERSPREAD_SOURCE_MASK		(3 << 7)
> -#define  DREF_SSC4_DOWNSPREAD                   (0 << 6)
> -#define  DREF_SSC4_CENTERSPREAD                 (1 << 6)
> -#define  DREF_SSC1_DISABLE                      (0 << 1)
> -#define  DREF_SSC1_ENABLE                       (1 << 1)
> -#define  DREF_SSC4_DISABLE                      (0)
> -#define  DREF_SSC4_ENABLE                       (1)
> -
> -#define PCH_RAWCLK_FREQ         _MMIO(0xc6204)
> -#define  FDL_TP1_TIMER_SHIFT    12
> -#define  FDL_TP1_TIMER_MASK     (3 << 12)
> -#define  FDL_TP2_TIMER_SHIFT    10
> -#define  FDL_TP2_TIMER_MASK     (3 << 10)
> -#define  RAWCLK_FREQ_MASK       0x3ff
> -#define  CNP_RAWCLK_DIV_MASK	(0x3ff << 16)
> -#define  CNP_RAWCLK_DIV(div)	((div) << 16)
> -#define  CNP_RAWCLK_FRAC_MASK	(0xf << 26)
> -#define  CNP_RAWCLK_DEN(den)	((den) << 26)
> -#define  ICP_RAWCLK_NUM(num)	((num) << 11)
> -
>  #define PCH_DPLL_TMR_CFG        _MMIO(0xc6208)
> 
>  #define PCH_SSC4_PARMS          _MMIO(0xc6210)
>  #define PCH_SSC4_AUX_PARMS      _MMIO(0xc6214)
> 
> -#define PCH_DPLL_SEL		_MMIO(0xc7000)
> -#define	 TRANS_DPLLB_SEL(pipe)		(1 << ((pipe) * 4))
> -#define	 TRANS_DPLLA_SEL(pipe)		0
> -#define  TRANS_DPLL_ENABLE(pipe)	(1 << ((pipe) * 4 + 3))
> -
> -/* transcoder */
> -#define _PCH_TRANS_HTOTAL_A		0xe0000
> -#define _PCH_TRANS_HTOTAL_B		0xe1000
> -#define PCH_TRANS_HTOTAL(pipe)		_MMIO_PIPE(pipe,
> _PCH_TRANS_HTOTAL_A, _PCH_TRANS_HTOTAL_B)
> -#define  TRANS_HTOTAL_SHIFT		16
> -#define  TRANS_HACTIVE_SHIFT		0
> -
> -#define _PCH_TRANS_HBLANK_A		0xe0004
> -#define _PCH_TRANS_HBLANK_B		0xe1004
> -#define PCH_TRANS_HBLANK(pipe)		_MMIO_PIPE(pipe,
> _PCH_TRANS_HBLANK_A, _PCH_TRANS_HBLANK_B)
> -#define  TRANS_HBLANK_END_SHIFT		16
> -#define  TRANS_HBLANK_START_SHIFT	0
> -
> -#define _PCH_TRANS_HSYNC_A		0xe0008
> -#define _PCH_TRANS_HSYNC_B		0xe1008
> -#define PCH_TRANS_HSYNC(pipe)		_MMIO_PIPE(pipe,
> _PCH_TRANS_HSYNC_A, _PCH_TRANS_HSYNC_B)
> -#define  TRANS_HSYNC_END_SHIFT		16
> -#define  TRANS_HSYNC_START_SHIFT	0
> -
> -#define _PCH_TRANS_VTOTAL_A		0xe000c
> -#define _PCH_TRANS_VTOTAL_B		0xe100c
> -#define PCH_TRANS_VTOTAL(pipe)		_MMIO_PIPE(pipe,
> _PCH_TRANS_VTOTAL_A, _PCH_TRANS_VTOTAL_B)
> -#define  TRANS_VTOTAL_SHIFT		16
> -#define  TRANS_VACTIVE_SHIFT		0
> -
> -#define _PCH_TRANS_VBLANK_A		0xe0010
> -#define _PCH_TRANS_VBLANK_B		0xe1010
> -#define PCH_TRANS_VBLANK(pipe)		_MMIO_PIPE(pipe,
> _PCH_TRANS_VBLANK_A, _PCH_TRANS_VBLANK_B)
> -#define  TRANS_VBLANK_END_SHIFT		16
> -#define  TRANS_VBLANK_START_SHIFT	0
> -
> -#define _PCH_TRANS_VSYNC_A		0xe0014
> -#define _PCH_TRANS_VSYNC_B		0xe1014
> -#define PCH_TRANS_VSYNC(pipe)		_MMIO_PIPE(pipe,
> _PCH_TRANS_VSYNC_A, _PCH_TRANS_VSYNC_B)
> -#define  TRANS_VSYNC_END_SHIFT		16
> -#define  TRANS_VSYNC_START_SHIFT	0
> -
> -#define _PCH_TRANS_VSYNCSHIFT_A		0xe0028
> -#define _PCH_TRANS_VSYNCSHIFT_B		0xe1028
> -#define PCH_TRANS_VSYNCSHIFT(pipe)	_MMIO_PIPE(pipe,
> _PCH_TRANS_VSYNCSHIFT_A, _PCH_TRANS_VSYNCSHIFT_B)
> -
> -#define _PCH_TRANSA_DATA_M1	0xe0030
> -#define _PCH_TRANSB_DATA_M1	0xe1030
> -#define PCH_TRANS_DATA_M1(pipe)	_MMIO_PIPE(pipe,
> _PCH_TRANSA_DATA_M1, _PCH_TRANSB_DATA_M1)
> -
> -#define _PCH_TRANSA_DATA_N1	0xe0034
> -#define _PCH_TRANSB_DATA_N1	0xe1034
> -#define PCH_TRANS_DATA_N1(pipe)	_MMIO_PIPE(pipe,
> _PCH_TRANSA_DATA_N1, _PCH_TRANSB_DATA_N1)
> -
> -#define _PCH_TRANSA_DATA_M2	0xe0038
> -#define _PCH_TRANSB_DATA_M2	0xe1038
> -#define PCH_TRANS_DATA_M2(pipe)	_MMIO_PIPE(pipe,
> _PCH_TRANSA_DATA_M2, _PCH_TRANSB_DATA_M2)
> -
> -#define _PCH_TRANSA_DATA_N2	0xe003c
> -#define _PCH_TRANSB_DATA_N2	0xe103c
> -#define PCH_TRANS_DATA_N2(pipe)	_MMIO_PIPE(pipe,
> _PCH_TRANSA_DATA_N2, _PCH_TRANSB_DATA_N2)
> -
> -#define _PCH_TRANSA_LINK_M1	0xe0040
> -#define _PCH_TRANSB_LINK_M1	0xe1040
> -#define PCH_TRANS_LINK_M1(pipe)	_MMIO_PIPE(pipe,
> _PCH_TRANSA_LINK_M1, _PCH_TRANSB_LINK_M1)
> -
> -#define _PCH_TRANSA_LINK_N1	0xe0044
> -#define _PCH_TRANSB_LINK_N1	0xe1044
> -#define PCH_TRANS_LINK_N1(pipe)	_MMIO_PIPE(pipe,
> _PCH_TRANSA_LINK_N1, _PCH_TRANSB_LINK_N1)
> -
> -#define _PCH_TRANSA_LINK_M2	0xe0048
> -#define _PCH_TRANSB_LINK_M2	0xe1048
> -#define PCH_TRANS_LINK_M2(pipe)	_MMIO_PIPE(pipe,
> _PCH_TRANSA_LINK_M2, _PCH_TRANSB_LINK_M2)
> -
> -#define _PCH_TRANSA_LINK_N2	0xe004c
> -#define _PCH_TRANSB_LINK_N2	0xe104c
> -#define PCH_TRANS_LINK_N2(pipe)	_MMIO_PIPE(pipe,
> _PCH_TRANSA_LINK_N2, _PCH_TRANSB_LINK_N2)
> -
> -/* Per-transcoder DIP controls (PCH) */
> -#define _VIDEO_DIP_CTL_A         0xe0200
> -#define _VIDEO_DIP_CTL_B         0xe1200
> -#define TVIDEO_DIP_CTL(pipe) _MMIO_PIPE(pipe, _VIDEO_DIP_CTL_A,
> _VIDEO_DIP_CTL_B)
> -
> -#define _VIDEO_DIP_DATA_A        0xe0208
> -#define _VIDEO_DIP_DATA_B        0xe1208
> -#define TVIDEO_DIP_DATA(pipe) _MMIO_PIPE(pipe, _VIDEO_DIP_DATA_A,
> _VIDEO_DIP_DATA_B)
> -
> -#define _VIDEO_DIP_GCP_A         0xe0210
> -#define _VIDEO_DIP_GCP_B         0xe1210
> -#define TVIDEO_DIP_GCP(pipe) _MMIO_PIPE(pipe, _VIDEO_DIP_GCP_A,
> _VIDEO_DIP_GCP_B)
> -#define  GCP_COLOR_INDICATION		(1 << 2)
> -#define  GCP_DEFAULT_PHASE_ENABLE	(1 << 1)
> -#define  GCP_AV_MUTE			(1 << 0)
> -
> -/* Per-transcoder DIP controls (VLV) */
> -#define _VLV_VIDEO_DIP_CTL_A		0x60200
> -#define _VLV_VIDEO_DIP_CTL_B		0x61170
> -#define _CHV_VIDEO_DIP_CTL_C		0x611f0
> -#define VLV_TVIDEO_DIP_CTL(pipe)
> 	_MMIO_BASE_PIPE3(VLV_DISPLAY_BASE, (pipe), \
> -
> _VLV_VIDEO_DIP_CTL_A, \
> -
> _VLV_VIDEO_DIP_CTL_B, \
> -
> _CHV_VIDEO_DIP_CTL_C)
> -
> -#define _VLV_VIDEO_DIP_DATA_A		0x60208
> -#define _VLV_VIDEO_DIP_DATA_B		0x61174
> -#define _CHV_VIDEO_DIP_DATA_C		0x611f4
> -#define VLV_TVIDEO_DIP_DATA(pipe)
> 	_MMIO_BASE_PIPE3(VLV_DISPLAY_BASE, (pipe), \
> -
> _VLV_VIDEO_DIP_DATA_A, \
> -
> _VLV_VIDEO_DIP_DATA_B, \
> -
> _CHV_VIDEO_DIP_DATA_C)
> -
> -#define _VLV_VIDEO_DIP_GDCP_PAYLOAD_A	0x60210
> -#define _VLV_VIDEO_DIP_GDCP_PAYLOAD_B	0x61178
> -#define _CHV_VIDEO_DIP_GDCP_PAYLOAD_C	0x611f8
> -#define VLV_TVIDEO_DIP_GCP(pipe)
> 	_MMIO_BASE_PIPE3(VLV_DISPLAY_BASE, (pipe), \
> -
> _VLV_VIDEO_DIP_GDCP_PAYLOAD_A, \
> -
> _VLV_VIDEO_DIP_GDCP_PAYLOAD_B, \
> -
> _CHV_VIDEO_DIP_GDCP_PAYLOAD_C)
> -
> -/* Haswell DIP controls */
> -#define _HSW_VIDEO_DIP_CTL_A		0x60200
> -#define _HSW_VIDEO_DIP_CTL_B		0x61200
> -#define HSW_TVIDEO_DIP_CTL(dev_priv, trans)
> 	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_CTL_A)
> -
> -#define _HSW_VIDEO_DIP_AVI_DATA_A	0x60220
> -#define _HSW_VIDEO_DIP_AVI_DATA_B	0x61220
> -#define HSW_TVIDEO_DIP_AVI_DATA(dev_priv, trans, i)
> 	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_AVI_DATA_A + (i)
> * 4)
> -
> -#define _HSW_VIDEO_DIP_VS_DATA_A	0x60260
> -#define _HSW_VIDEO_DIP_VS_DATA_B	0x61260
> -#define HSW_TVIDEO_DIP_VS_DATA(dev_priv, trans, i)
> 	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_VS_DATA_A + (i)
> * 4)
> -
> -#define _HSW_VIDEO_DIP_SPD_DATA_A	0x602A0
> -#define _HSW_VIDEO_DIP_SPD_DATA_B	0x612A0
> -#define HSW_TVIDEO_DIP_SPD_DATA(dev_priv, trans, i)
> 	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_SPD_DATA_A +
> (i) * 4)
> -
> -#define _HSW_VIDEO_DIP_GMP_DATA_A	0x602E0
> -#define _HSW_VIDEO_DIP_GMP_DATA_B	0x612E0
> -#define HSW_TVIDEO_DIP_GMP_DATA(dev_priv, trans, i)
> 	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_GMP_DATA_A +
> (i) * 4)
> -
> -#define _HSW_VIDEO_DIP_VSC_DATA_A	0x60320
> -#define _HSW_VIDEO_DIP_VSC_DATA_B	0x61320
> -#define HSW_TVIDEO_DIP_VSC_DATA(dev_priv, trans, i)
> 	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_VSC_DATA_A +
> (i) * 4)
> -
> -/*ADLP and later: */
> -#define	_ADL_VIDEO_DIP_AS_DATA_A	0x60484
> -#define _ADL_VIDEO_DIP_AS_DATA_B	0x61484
> -#define ADL_TVIDEO_DIP_AS_SDP_DATA(dev_priv, trans, i)
> 	_MMIO_TRANS2(dev_priv, trans,\
> -
> _ADL_VIDEO_DIP_AS_DATA_A + (i) * 4)
> -
> -#define _GLK_VIDEO_DIP_DRM_DATA_A	0x60440
> -#define _GLK_VIDEO_DIP_DRM_DATA_B	0x61440
> -#define GLK_TVIDEO_DIP_DRM_DATA(dev_priv, trans, i)
> 	_MMIO_TRANS2(dev_priv, trans, _GLK_VIDEO_DIP_DRM_DATA_A +
> (i) * 4)
> -
>  #define _HSW_VIDEO_DIP_AVI_ECC_A	0x60240
>  #define _HSW_VIDEO_DIP_BVI_ECC_B	0x61240
>  #define _HSW_VIDEO_DIP_VS_ECC_A		0x60280
> @@ -3017,20 +1204,12 @@
>  #define _HSW_VIDEO_DIP_VSC_ECC_A	0x60344
>  #define _HSW_VIDEO_DIP_VSC_ECC_B	0x61344
> 
> -#define _HSW_VIDEO_DIP_GCP_A		0x60210
> -#define _HSW_VIDEO_DIP_GCP_B		0x61210
> -#define HSW_TVIDEO_DIP_GCP(dev_priv, trans)
> 	_MMIO_TRANS2(dev_priv, trans, _HSW_VIDEO_DIP_GCP_A)
> -
>  /* Icelake PPS_DATA and _ECC DIP Registers.
>   * These are available for transcoders B,C and eDP.
>   * Adding the _A so as to reuse the _MMIO_TRANS2
>   * definition, with which it offsets to the right location.
>   */
> 
> -#define _ICL_VIDEO_DIP_PPS_DATA_A	0x60350
> -#define _ICL_VIDEO_DIP_PPS_DATA_B	0x61350
> -#define ICL_VIDEO_DIP_PPS_DATA(dev_priv, trans, i)
> 	_MMIO_TRANS2(dev_priv, trans, _ICL_VIDEO_DIP_PPS_DATA_A + (i) *
> 4)
> -
>  #define _ICL_VIDEO_DIP_PPS_ECC_A	0x603D4
>  #define _ICL_VIDEO_DIP_PPS_ECC_B	0x613D4
>  #define ICL_VIDEO_DIP_PPS_ECC(dev_priv, trans, i)
> 	_MMIO_TRANS2(dev_priv, trans, _ICL_VIDEO_DIP_PPS_ECC_A + (i) *
> 4)
> @@ -3040,24 +1219,6 @@
>  #define HSW_STEREO_3D_CTL(dev_priv, trans)
> 	_MMIO_PIPE2(dev_priv, trans, _HSW_STEREO_3D_CTL_A)
>  #define   S3D_ENABLE			(1 << 31)
> 
> -#define _PCH_TRANSACONF              0xf0008
> -#define _PCH_TRANSBCONF              0xf1008
> -#define PCH_TRANSCONF(pipe)	_MMIO_PIPE(pipe,
> _PCH_TRANSACONF, _PCH_TRANSBCONF)
> -#define LPT_TRANSCONF		PCH_TRANSCONF(PIPE_A) /* lpt has
> only one transcoder */
> -#define  TRANS_ENABLE			REG_BIT(31)
> -#define  TRANS_STATE_ENABLE		REG_BIT(30)
> -#define  TRANS_FRAME_START_DELAY_MASK	REG_GENMASK(28, 27) /* ibx
> */
> -#define  TRANS_FRAME_START_DELAY(x)
> 	REG_FIELD_PREP(TRANS_FRAME_START_DELAY_MASK, (x)) /* ibx: 0-3
> */
> -#define  TRANS_INTERLACE_MASK		REG_GENMASK(23, 21)
> -#define  TRANS_INTERLACE_PROGRESSIVE
> 	REG_FIELD_PREP(TRANS_INTERLACE_MASK, 0)
> -#define  TRANS_INTERLACE_LEGACY_VSYNC_IBX
> 	REG_FIELD_PREP(TRANS_INTERLACE_MASK, 2) /* ibx */
> -#define  TRANS_INTERLACE_INTERLACED
> 	REG_FIELD_PREP(TRANS_INTERLACE_MASK, 3)
> -#define  TRANS_BPC_MASK			REG_GENMASK(7, 5) /* ibx */
> -#define  TRANS_BPC_8
> 	REG_FIELD_PREP(TRANS_BPC_MASK, 0)
> -#define  TRANS_BPC_10
> 	REG_FIELD_PREP(TRANS_BPC_MASK, 1)
> -#define  TRANS_BPC_6
> 	REG_FIELD_PREP(TRANS_BPC_MASK, 2)
> -#define  TRANS_BPC_12
> 	REG_FIELD_PREP(TRANS_BPC_MASK, 3)
> -
>  #define _TRANSA_CHICKEN1	 0xf0060
>  #define _TRANSB_CHICKEN1	 0xf1060
>  #define TRANS_CHICKEN1(pipe)	_MMIO_PIPE(pipe,
> _TRANSA_CHICKEN1, _TRANSB_CHICKEN1)
> @@ -3110,88 +1271,6 @@
>  #define  CNP_PWM_CGE_GATING_DISABLE (1 << 13)
>  #define  PCH_LP_PARTITION_LEVEL_DISABLE  (1 << 12)
> 
> -#define PCH_DP_B		_MMIO(0xe4100)
> -#define PCH_DP_C		_MMIO(0xe4200)
> -#define PCH_DP_D		_MMIO(0xe4300)
> -
> -/* CPT */
> -#define _TRANS_DP_CTL_A		0xe0300
> -#define _TRANS_DP_CTL_B		0xe1300
> -#define _TRANS_DP_CTL_C		0xe2300
> -#define TRANS_DP_CTL(pipe)	_MMIO_PIPE(pipe, _TRANS_DP_CTL_A,
> _TRANS_DP_CTL_B)
> -#define  TRANS_DP_OUTPUT_ENABLE		REG_BIT(31)
> -#define  TRANS_DP_PORT_SEL_MASK		REG_GENMASK(30, 29)
> -#define  TRANS_DP_PORT_SEL_NONE
> 	REG_FIELD_PREP(TRANS_DP_PORT_SEL_MASK, 3)
> -#define  TRANS_DP_PORT_SEL(port)
> 	REG_FIELD_PREP(TRANS_DP_PORT_SEL_MASK, (port) - PORT_B)
> -#define  TRANS_DP_AUDIO_ONLY		REG_BIT(26)
> -#define  TRANS_DP_ENH_FRAMING		REG_BIT(18)
> -#define  TRANS_DP_BPC_MASK		REG_GENMASK(10, 9)
> -#define  TRANS_DP_BPC_8
> 	REG_FIELD_PREP(TRANS_DP_BPC_MASK, 0)
> -#define  TRANS_DP_BPC_10
> 	REG_FIELD_PREP(TRANS_DP_BPC_MASK, 1)
> -#define  TRANS_DP_BPC_6
> 	REG_FIELD_PREP(TRANS_DP_BPC_MASK, 2)
> -#define  TRANS_DP_BPC_12
> 	REG_FIELD_PREP(TRANS_DP_BPC_MASK, 3)
> -#define  TRANS_DP_VSYNC_ACTIVE_HIGH	REG_BIT(4)
> -#define  TRANS_DP_HSYNC_ACTIVE_HIGH	REG_BIT(3)
> -
> -#define _TRANS_DP2_CTL_A			0x600a0
> -#define _TRANS_DP2_CTL_B			0x610a0
> -#define _TRANS_DP2_CTL_C			0x620a0
> -#define _TRANS_DP2_CTL_D			0x630a0
> -#define TRANS_DP2_CTL(trans)			_MMIO_TRANS(trans,
> _TRANS_DP2_CTL_A, _TRANS_DP2_CTL_B)
> -#define  TRANS_DP2_128B132B_CHANNEL_CODING	REG_BIT(31)
> -#define  TRANS_DP2_PANEL_REPLAY_ENABLE		REG_BIT(30)
> -#define  TRANS_DP2_DEBUG_ENABLE			REG_BIT(23)
> -
> -#define _TRANS_DP2_VFREQHIGH_A			0x600a4
> -#define _TRANS_DP2_VFREQHIGH_B			0x610a4
> -#define _TRANS_DP2_VFREQHIGH_C			0x620a4
> -#define _TRANS_DP2_VFREQHIGH_D			0x630a4
> -#define TRANS_DP2_VFREQHIGH(trans)		_MMIO_TRANS(trans,
> _TRANS_DP2_VFREQHIGH_A, _TRANS_DP2_VFREQHIGH_B)
> -#define  TRANS_DP2_VFREQ_PIXEL_CLOCK_MASK	REG_GENMASK(31, 8)
> -#define  TRANS_DP2_VFREQ_PIXEL_CLOCK(clk_hz)
> 	REG_FIELD_PREP(TRANS_DP2_VFREQ_PIXEL_CLOCK_MASK, (clk_hz))
> -
> -#define _TRANS_DP2_VFREQLOW_A			0x600a8
> -#define _TRANS_DP2_VFREQLOW_B			0x610a8
> -#define _TRANS_DP2_VFREQLOW_C			0x620a8
> -#define _TRANS_DP2_VFREQLOW_D			0x630a8
> -#define TRANS_DP2_VFREQLOW(trans)		_MMIO_TRANS(trans,
> _TRANS_DP2_VFREQLOW_A, _TRANS_DP2_VFREQLOW_B)
> -
> -#define _DP_MIN_HBLANK_CTL_A			0x600ac
> -#define _DP_MIN_HBLANK_CTL_B			0x610ac
> -#define DP_MIN_HBLANK_CTL(trans)		_MMIO_TRANS(trans,
> _DP_MIN_HBLANK_CTL_A, _DP_MIN_HBLANK_CTL_B)
> -
> -/* SNB eDP training params */
> -/* SNB A-stepping */
> -#define  EDP_LINK_TRAIN_400MV_0DB_SNB_A		(0x38 << 22)
> -#define  EDP_LINK_TRAIN_400MV_6DB_SNB_A		(0x02 << 22)
> -#define  EDP_LINK_TRAIN_600MV_3_5DB_SNB_A	(0x01 << 22)
> -#define  EDP_LINK_TRAIN_800MV_0DB_SNB_A		(0x0 << 22)
> -/* SNB B-stepping */
> -#define  EDP_LINK_TRAIN_400_600MV_0DB_SNB_B	(0x0 << 22)
> -#define  EDP_LINK_TRAIN_400MV_3_5DB_SNB_B	(0x1 << 22)
> -#define  EDP_LINK_TRAIN_400_600MV_6DB_SNB_B	(0x3a << 22)
> -#define  EDP_LINK_TRAIN_600_800MV_3_5DB_SNB_B	(0x39 << 22)
> -#define  EDP_LINK_TRAIN_800_1200MV_0DB_SNB_B	(0x38 << 22)
> -#define  EDP_LINK_TRAIN_VOL_EMP_MASK_SNB	(0x3f << 22)
> -
> -/* IVB */
> -#define EDP_LINK_TRAIN_400MV_0DB_IVB		(0x24 << 22)
> -#define EDP_LINK_TRAIN_400MV_3_5DB_IVB		(0x2a << 22)
> -#define EDP_LINK_TRAIN_400MV_6DB_IVB		(0x2f << 22)
> -#define EDP_LINK_TRAIN_600MV_0DB_IVB		(0x30 << 22)
> -#define EDP_LINK_TRAIN_600MV_3_5DB_IVB		(0x36 << 22)
> -#define EDP_LINK_TRAIN_800MV_0DB_IVB		(0x38 << 22)
> -#define EDP_LINK_TRAIN_800MV_3_5DB_IVB		(0x3e << 22)
> -
> -/* legacy values */
> -#define EDP_LINK_TRAIN_500MV_0DB_IVB		(0x00 << 22)
> -#define EDP_LINK_TRAIN_1000MV_0DB_IVB		(0x20 << 22)
> -#define EDP_LINK_TRAIN_500MV_3_5DB_IVB		(0x02 << 22)
> -#define EDP_LINK_TRAIN_1000MV_3_5DB_IVB		(0x22 << 22)
> -#define EDP_LINK_TRAIN_1000MV_6DB_IVB		(0x23 << 22)
> -
> -#define  EDP_LINK_TRAIN_VOL_EMP_MASK_IVB	(0x3f << 22)
> -
>  #define  VLV_PMWGICZ				_MMIO(0x1300a4)
> 
>  #define  HSW_EDRAM_CAP				_MMIO(0x120010)
> @@ -3200,10 +1279,6 @@
>  #define    EDRAM_WAYS_IDX(cap)			(((cap) >> 5) & 0x7)
>  #define    EDRAM_SETS_IDX(cap)			(((cap) >> 8) & 0x3)
> 
> -#define VLV_CHICKEN_3
> 	_MMIO(VLV_DISPLAY_BASE + 0x7040C)
> -#define  PIXEL_OVERLAP_CNT_MASK			(3 << 30)
> -#define  PIXEL_OVERLAP_CNT_SHIFT		30
> -
>  #define GEN6_PCODE_MAILBOX			_MMIO(0x138124)
>  #define   GEN6_PCODE_READY			(1 << 31)
>  #define   GEN6_PCODE_MB_PARAM2			REG_GENMASK(23,
> 16)
> @@ -3332,103 +1407,6 @@
>   */
>  #define GEN7_SO_WRITE_OFFSET(n)		_MMIO(0x5280 + (n) * 4)
> 
> -/*
> - * HSW - ICL power wells
> - *
> - * Platforms have up to 3 power well control register sets, each set
> - * controlling up to 16 power wells via a request/status HW flag tuple:
> - * - main (HSW_PWR_WELL_CTL[1-4])
> - * - AUX  (ICL_PWR_WELL_CTL_AUX[1-4])
> - * - DDI  (ICL_PWR_WELL_CTL_DDI[1-4])
> - * Each control register set consists of up to 4 registers used by different
> - * sources that can request a power well to be enabled:
> - * - BIOS
> (HSW_PWR_WELL_CTL1/ICL_PWR_WELL_CTL_AUX1/ICL_PWR_WELL_CTL_DD
> I1)
> - * - DRIVER
> (HSW_PWR_WELL_CTL2/ICL_PWR_WELL_CTL_AUX2/ICL_PWR_WELL_CTL_DD
> I2)
> - * - KVMR   (HSW_PWR_WELL_CTL3)   (only in the main register set)
> - * - DEBUG
> (HSW_PWR_WELL_CTL4/ICL_PWR_WELL_CTL_AUX4/ICL_PWR_WELL_CTL_DD
> I4)
> - */
> -#define HSW_PWR_WELL_CTL1			_MMIO(0x45400)
> -#define HSW_PWR_WELL_CTL2			_MMIO(0x45404)
> -#define HSW_PWR_WELL_CTL3			_MMIO(0x45408)
> -#define HSW_PWR_WELL_CTL4			_MMIO(0x4540C)
> -#define   HSW_PWR_WELL_CTL_REQ(pw_idx)		(0x2 << ((pw_idx) *
> 2))
> -#define   HSW_PWR_WELL_CTL_STATE(pw_idx)	(0x1 << ((pw_idx) *
> 2))
> -
> -/* HSW/BDW power well */
> -#define   HSW_PW_CTL_IDX_GLOBAL			15
> -
> -/* SKL/BXT/GLK power wells */
> -#define   SKL_PW_CTL_IDX_PW_2			15
> -#define   SKL_PW_CTL_IDX_PW_1			14
> -#define   GLK_PW_CTL_IDX_AUX_C			10
> -#define   GLK_PW_CTL_IDX_AUX_B			9
> -#define   GLK_PW_CTL_IDX_AUX_A			8
> -#define   SKL_PW_CTL_IDX_DDI_D			4
> -#define   SKL_PW_CTL_IDX_DDI_C			3
> -#define   SKL_PW_CTL_IDX_DDI_B			2
> -#define   SKL_PW_CTL_IDX_DDI_A_E		1
> -#define   GLK_PW_CTL_IDX_DDI_A			1
> -#define   SKL_PW_CTL_IDX_MISC_IO		0
> -
> -/* ICL/TGL - power wells */
> -#define   TGL_PW_CTL_IDX_PW_5			4
> -#define   ICL_PW_CTL_IDX_PW_4			3
> -#define   ICL_PW_CTL_IDX_PW_3			2
> -#define   ICL_PW_CTL_IDX_PW_2			1
> -#define   ICL_PW_CTL_IDX_PW_1			0
> -
> -/* XE_LPD - power wells */
> -#define   XELPD_PW_CTL_IDX_PW_D			8
> -#define   XELPD_PW_CTL_IDX_PW_C			7
> -#define   XELPD_PW_CTL_IDX_PW_B			6
> -#define   XELPD_PW_CTL_IDX_PW_A			5
> -
> -#define ICL_PWR_WELL_CTL_AUX1			_MMIO(0x45440)
> -#define ICL_PWR_WELL_CTL_AUX2			_MMIO(0x45444)
> -#define ICL_PWR_WELL_CTL_AUX4			_MMIO(0x4544C)
> -#define   TGL_PW_CTL_IDX_AUX_TBT6		14
> -#define   TGL_PW_CTL_IDX_AUX_TBT5		13
> -#define   TGL_PW_CTL_IDX_AUX_TBT4		12
> -#define   ICL_PW_CTL_IDX_AUX_TBT4		11
> -#define   TGL_PW_CTL_IDX_AUX_TBT3		11
> -#define   ICL_PW_CTL_IDX_AUX_TBT3		10
> -#define   TGL_PW_CTL_IDX_AUX_TBT2		10
> -#define   ICL_PW_CTL_IDX_AUX_TBT2		9
> -#define   TGL_PW_CTL_IDX_AUX_TBT1		9
> -#define   ICL_PW_CTL_IDX_AUX_TBT1		8
> -#define   TGL_PW_CTL_IDX_AUX_TC6		8
> -#define   XELPD_PW_CTL_IDX_AUX_E			8
> -#define   TGL_PW_CTL_IDX_AUX_TC5		7
> -#define   XELPD_PW_CTL_IDX_AUX_D			7
> -#define   TGL_PW_CTL_IDX_AUX_TC4		6
> -#define   ICL_PW_CTL_IDX_AUX_F			5
> -#define   TGL_PW_CTL_IDX_AUX_TC3		5
> -#define   ICL_PW_CTL_IDX_AUX_E			4
> -#define   TGL_PW_CTL_IDX_AUX_TC2		4
> -#define   ICL_PW_CTL_IDX_AUX_D			3
> -#define   TGL_PW_CTL_IDX_AUX_TC1		3
> -#define   ICL_PW_CTL_IDX_AUX_C			2
> -#define   ICL_PW_CTL_IDX_AUX_B			1
> -#define   ICL_PW_CTL_IDX_AUX_A			0
> -
> -#define ICL_PWR_WELL_CTL_DDI1			_MMIO(0x45450)
> -#define ICL_PWR_WELL_CTL_DDI2			_MMIO(0x45454)
> -#define ICL_PWR_WELL_CTL_DDI4			_MMIO(0x4545C)
> -#define   XELPD_PW_CTL_IDX_DDI_E			8
> -#define   TGL_PW_CTL_IDX_DDI_TC6		8
> -#define   XELPD_PW_CTL_IDX_DDI_D			7
> -#define   TGL_PW_CTL_IDX_DDI_TC5		7
> -#define   TGL_PW_CTL_IDX_DDI_TC4		6
> -#define   ICL_PW_CTL_IDX_DDI_F			5
> -#define   TGL_PW_CTL_IDX_DDI_TC3		5
> -#define   ICL_PW_CTL_IDX_DDI_E			4
> -#define   TGL_PW_CTL_IDX_DDI_TC2		4
> -#define   ICL_PW_CTL_IDX_DDI_D			3
> -#define   TGL_PW_CTL_IDX_DDI_TC1		3
> -#define   ICL_PW_CTL_IDX_DDI_C			2
> -#define   ICL_PW_CTL_IDX_DDI_B			1
> -#define   ICL_PW_CTL_IDX_DDI_A			0
> -
>  /* HSW - power well misc debug registers */
>  #define HSW_PWR_WELL_CTL5			_MMIO(0x45410)
>  #define   HSW_PWR_WELL_ENABLE_SINGLE_STEP	(1 << 31)
> @@ -3445,188 +1423,6 @@ enum skl_power_gate {
>  	ICL_PG4,
>  };
> 
> -#define SKL_FUSE_STATUS				_MMIO(0x42000)
> -#define  SKL_FUSE_DOWNLOAD_STATUS		(1 << 31)
> -/*
> - * PG0 is HW controlled, so doesn't have a corresponding power well
> control knob
> - * SKL_DISP_PW1_IDX..SKL_DISP_PW2_IDX -> PG1..PG2
> - */
> -#define  SKL_PW_CTL_IDX_TO_PG(pw_idx)		\
> -	((pw_idx) - SKL_PW_CTL_IDX_PW_1 + SKL_PG1)
> -/*
> - * PG0 is HW controlled, so doesn't have a corresponding power well
> control knob
> - * ICL_DISP_PW1_IDX..ICL_DISP_PW4_IDX -> PG1..PG4
> - */
> -#define  ICL_PW_CTL_IDX_TO_PG(pw_idx)		\
> -	((pw_idx) - ICL_PW_CTL_IDX_PW_1 + SKL_PG1)
> -#define  SKL_FUSE_PG_DIST_STATUS(pg)		(1 << (27 - (pg)))
> -
> -/* Per-pipe DDI Function Control */
> -#define _TRANS_DDI_FUNC_CTL_A		0x60400
> -#define _TRANS_DDI_FUNC_CTL_B		0x61400
> -#define _TRANS_DDI_FUNC_CTL_C		0x62400
> -#define _TRANS_DDI_FUNC_CTL_D		0x63400
> -#define _TRANS_DDI_FUNC_CTL_EDP		0x6F400
> -#define _TRANS_DDI_FUNC_CTL_DSI0	0x6b400
> -#define _TRANS_DDI_FUNC_CTL_DSI1	0x6bc00
> -#define TRANS_DDI_FUNC_CTL(dev_priv, tran) _MMIO_TRANS2(dev_priv,
> tran, _TRANS_DDI_FUNC_CTL_A)
> -
> -#define  TRANS_DDI_FUNC_ENABLE		(1 << 31)
> -/* Those bits are ignored by pipe EDP since it can only connect to DDI A */
> -#define  TRANS_DDI_PORT_SHIFT		28
> -#define  TGL_TRANS_DDI_PORT_SHIFT	27
> -#define  TRANS_DDI_PORT_MASK		(7 <<
> TRANS_DDI_PORT_SHIFT)
> -#define  TGL_TRANS_DDI_PORT_MASK	(0xf <<
> TGL_TRANS_DDI_PORT_SHIFT)
> -#define  TRANS_DDI_SELECT_PORT(x)	((x) << TRANS_DDI_PORT_SHIFT)
> -#define  TGL_TRANS_DDI_SELECT_PORT(x)	(((x) + 1) <<
> TGL_TRANS_DDI_PORT_SHIFT)
> -#define  TRANS_DDI_MODE_SELECT_MASK	(7 << 24)
> -#define  TRANS_DDI_MODE_SELECT_HDMI	(0 << 24)
> -#define  TRANS_DDI_MODE_SELECT_DVI	(1 << 24)
> -#define  TRANS_DDI_MODE_SELECT_DP_SST	(2 << 24)
> -#define  TRANS_DDI_MODE_SELECT_DP_MST	(3 << 24)
> -#define  TRANS_DDI_MODE_SELECT_FDI_OR_128B132B	(4 << 24)
> -#define  TRANS_DDI_BPC_MASK		(7 << 20)
> -#define  TRANS_DDI_BPC_8		(0 << 20)
> -#define  TRANS_DDI_BPC_10		(1 << 20)
> -#define  TRANS_DDI_BPC_6		(2 << 20)
> -#define  TRANS_DDI_BPC_12		(3 << 20)
> -#define  TRANS_DDI_PORT_SYNC_MASTER_SELECT_MASK
> 	REG_GENMASK(19, 18)
> -#define  TRANS_DDI_PORT_SYNC_MASTER_SELECT(x)
> 	REG_FIELD_PREP(TRANS_DDI_PORT_SYNC_MASTER_SELECT_MASK,
> (x))
> -#define  TRANS_DDI_PVSYNC		(1 << 17)
> -#define  TRANS_DDI_PHSYNC		(1 << 16)
> -#define  TRANS_DDI_PORT_SYNC_ENABLE	REG_BIT(15)
> -#define  XE3_TRANS_DDI_HDCP_LINE_REKEY_DISABLE	REG_BIT(15)
> -#define  TRANS_DDI_EDP_INPUT_MASK	(7 << 12)
> -#define  TRANS_DDI_EDP_INPUT_A_ON	(0 << 12)
> -#define  TRANS_DDI_EDP_INPUT_A_ONOFF	(4 << 12)
> -#define  TRANS_DDI_EDP_INPUT_B_ONOFF	(5 << 12)
> -#define  TRANS_DDI_EDP_INPUT_C_ONOFF	(6 << 12)
> -#define  TRANS_DDI_EDP_INPUT_D_ONOFF	(7 << 12)
> -#define  TRANS_DDI_HDCP_LINE_REKEY_DISABLE	REG_BIT(12)
> -#define  TRANS_DDI_MST_TRANSPORT_SELECT_MASK
> 	REG_GENMASK(11, 10)
> -#define  TRANS_DDI_MST_TRANSPORT_SELECT(trans)	\
> -	REG_FIELD_PREP(TRANS_DDI_MST_TRANSPORT_SELECT_MASK,
> trans)
> -#define  TRANS_DDI_HDCP_SIGNALLING	(1 << 9)
> -#define  TRANS_DDI_DP_VC_PAYLOAD_ALLOC	(1 << 8)
> -#define  TRANS_DDI_HDMI_SCRAMBLER_CTS_ENABLE (1 << 7)
> -#define  TRANS_DDI_HDMI_SCRAMBLER_RESET_FREQ (1 << 6)
> -#define  TRANS_DDI_HDCP_SELECT		REG_BIT(5)
> -#define  TRANS_DDI_BFI_ENABLE		(1 << 4)
> -#define  TRANS_DDI_HIGH_TMDS_CHAR_RATE	(1 << 4)
> -#define  TRANS_DDI_PORT_WIDTH_MASK	REG_GENMASK(3, 1)
> -#define  TRANS_DDI_PORT_WIDTH(width)
> 	REG_FIELD_PREP(TRANS_DDI_PORT_WIDTH_MASK, (width) - 1)
> -#define  TRANS_DDI_HDMI_SCRAMBLING	(1 << 0)
> -#define  TRANS_DDI_HDMI_SCRAMBLING_MASK
> (TRANS_DDI_HDMI_SCRAMBLER_CTS_ENABLE \
> -					|
> TRANS_DDI_HDMI_SCRAMBLER_RESET_FREQ \
> -					| TRANS_DDI_HDMI_SCRAMBLING)
> -
> -#define _TRANS_DDI_FUNC_CTL2_A		0x60404
> -#define _TRANS_DDI_FUNC_CTL2_B		0x61404
> -#define _TRANS_DDI_FUNC_CTL2_C		0x62404
> -#define _TRANS_DDI_FUNC_CTL2_EDP	0x6f404
> -#define _TRANS_DDI_FUNC_CTL2_DSI0	0x6b404
> -#define _TRANS_DDI_FUNC_CTL2_DSI1	0x6bc04
> -#define TRANS_DDI_FUNC_CTL2(dev_priv, tran)
> 	_MMIO_TRANS2(dev_priv, tran, _TRANS_DDI_FUNC_CTL2_A)
> -#define  PORT_SYNC_MODE_ENABLE			REG_BIT(4)
> -#define  CMTG_SECONDARY_MODE			REG_BIT(3)
> -#define  PORT_SYNC_MODE_MASTER_SELECT_MASK	REG_GENMASK(2, 0)
> -#define  PORT_SYNC_MODE_MASTER_SELECT(x)
> 	REG_FIELD_PREP(PORT_SYNC_MODE_MASTER_SELECT_MASK, (x))
> -
> -#define TRANS_CMTG_CHICKEN		_MMIO(0x6fa90)
> -#define  DISABLE_DPT_CLK_GATING		REG_BIT(1)
> -
> -/* DisplayPort Transport Control */
> -#define _DP_TP_CTL_A			0x64040
> -#define _DP_TP_CTL_B			0x64140
> -#define _TGL_DP_TP_CTL_A		0x60540
> -#define DP_TP_CTL(port) _MMIO_PORT(port, _DP_TP_CTL_A,
> _DP_TP_CTL_B)
> -#define TGL_DP_TP_CTL(dev_priv, tran) _MMIO_TRANS2(dev_priv, (tran),
> _TGL_DP_TP_CTL_A)
> -#define   DP_TP_CTL_ENABLE			REG_BIT(31)
> -#define   DP_TP_CTL_FEC_ENABLE			REG_BIT(30)
> -#define   DP_TP_CTL_MODE_MASK			REG_BIT(27)
> -#define   DP_TP_CTL_MODE_SST
> 	REG_FIELD_PREP(DP_TP_CTL_MODE_MASK, 0)
> -#define   DP_TP_CTL_MODE_MST
> 	REG_FIELD_PREP(DP_TP_CTL_MODE_MASK, 1)
> -#define   DP_TP_CTL_FORCE_ACT			REG_BIT(25)
> -#define   DP_TP_CTL_TRAIN_PAT4_SEL_MASK		REG_GENMASK(20,
> 19)
> -#define   DP_TP_CTL_TRAIN_PAT4_SEL_TP4A
> 	REG_FIELD_PREP(DP_TP_CTL_TRAIN_PAT4_SEL_MASK, 0)
> -#define   DP_TP_CTL_TRAIN_PAT4_SEL_TP4B
> 	REG_FIELD_PREP(DP_TP_CTL_TRAIN_PAT4_SEL_MASK, 1)
> -#define   DP_TP_CTL_TRAIN_PAT4_SEL_TP4C
> 	REG_FIELD_PREP(DP_TP_CTL_TRAIN_PAT4_SEL_MASK, 2)
> -#define   DP_TP_CTL_ENHANCED_FRAME_ENABLE	REG_BIT(18)
> -#define   DP_TP_CTL_FDI_AUTOTRAIN		REG_BIT(15)
> -#define   DP_TP_CTL_LINK_TRAIN_MASK		REG_GENMASK(10, 8)
> -#define   DP_TP_CTL_LINK_TRAIN_PAT1
> 	REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 0)
> -#define   DP_TP_CTL_LINK_TRAIN_PAT2
> 	REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 1)
> -#define   DP_TP_CTL_LINK_TRAIN_PAT3
> 	REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 4)
> -#define   DP_TP_CTL_LINK_TRAIN_PAT4
> 	REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 5)
> -#define   DP_TP_CTL_LINK_TRAIN_IDLE
> 	REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 2)
> -#define   DP_TP_CTL_LINK_TRAIN_NORMAL
> 	REG_FIELD_PREP(DP_TP_CTL_LINK_TRAIN_MASK, 3)
> -#define   DP_TP_CTL_SCRAMBLE_DISABLE		REG_BIT(7)
> -
> -/* DisplayPort Transport Status */
> -#define _DP_TP_STATUS_A			0x64044
> -#define _DP_TP_STATUS_B			0x64144
> -#define _TGL_DP_TP_STATUS_A		0x60544
> -#define DP_TP_STATUS(port) _MMIO_PORT(port, _DP_TP_STATUS_A,
> _DP_TP_STATUS_B)
> -#define TGL_DP_TP_STATUS(dev_priv, tran) _MMIO_TRANS2(dev_priv,
> (tran), _TGL_DP_TP_STATUS_A)
> -#define   DP_TP_STATUS_FEC_ENABLE_LIVE		REG_BIT(28)
> -#define   DP_TP_STATUS_IDLE_DONE		REG_BIT(25)
> -#define   DP_TP_STATUS_ACT_SENT			REG_BIT(24)
> -#define   DP_TP_STATUS_MODE_STATUS_MST		REG_BIT(23)
> -#define   DP_TP_STATUS_STREAMS_ENABLED_MASK	REG_GENMASK(18,
> 16) /* 17:16 on hsw but bit 18 mbz */
> -#define   DP_TP_STATUS_AUTOTRAIN_DONE		REG_BIT(12)
> -#define   DP_TP_STATUS_PAYLOAD_MAPPING_VC2_MASK REG_GENMASK(9,
> 8)
> -#define   DP_TP_STATUS_PAYLOAD_MAPPING_VC1_MASK
> 	REG_GENMASK(5, 4)
> -#define   DP_TP_STATUS_PAYLOAD_MAPPING_VC0_MASK
> 	REG_GENMASK(1, 0)
> -
> -/* DDI Buffer Control */
> -#define _DDI_BUF_CTL_A				0x64000
> -#define _DDI_BUF_CTL_B				0x64100
> -/* Known as DDI_CTL_DE in MTL+ */
> -#define DDI_BUF_CTL(port) _MMIO_PORT(port, _DDI_BUF_CTL_A,
> _DDI_BUF_CTL_B)
> -#define  DDI_BUF_CTL_ENABLE			(1 << 31)
> -#define  XE2LPD_DDI_BUF_D2D_LINK_ENABLE		REG_BIT(29)
> -#define  XE2LPD_DDI_BUF_D2D_LINK_STATE		REG_BIT(28)
> -#define  DDI_BUF_TRANS_SELECT(n)	((n) << 24)
> -#define  DDI_BUF_EMP_MASK			(0xf << 24)
> -#define  DDI_BUF_PHY_LINK_RATE(r)		((r) << 20)
> -#define  DDI_BUF_PORT_DATA_MASK			REG_GENMASK(19,
> 18)
> -#define  DDI_BUF_PORT_DATA_10BIT
> 	REG_FIELD_PREP(DDI_BUF_PORT_DATA_MASK, 0)
> -#define  DDI_BUF_PORT_DATA_20BIT
> 	REG_FIELD_PREP(DDI_BUF_PORT_DATA_MASK, 1)
> -#define  DDI_BUF_PORT_DATA_40BIT
> 	REG_FIELD_PREP(DDI_BUF_PORT_DATA_MASK, 2)
> -#define  DDI_BUF_PORT_REVERSAL			(1 << 16)
> -#define  DDI_BUF_IS_IDLE			(1 << 7)
> -#define  DDI_BUF_CTL_TC_PHY_OWNERSHIP		REG_BIT(6)
> -#define  DDI_A_4_LANES				(1 << 4)
> -#define  DDI_PORT_WIDTH(width)			(((width) - 1) << 1)
> -#define  DDI_PORT_WIDTH_MASK			(7 << 1)
> -#define  DDI_PORT_WIDTH_SHIFT			1
> -#define  DDI_INIT_DISPLAY_DETECTED		(1 << 0)
> -
> -/* DDI Buffer Translations */
> -#define _DDI_BUF_TRANS_A		0x64E00
> -#define _DDI_BUF_TRANS_B		0x64E60
> -#define DDI_BUF_TRANS_LO(port, i)	_MMIO(_PORT(port,
> _DDI_BUF_TRANS_A, _DDI_BUF_TRANS_B) + (i) * 8)
> -#define  DDI_BUF_BALANCE_LEG_ENABLE	(1 << 31)
> -#define DDI_BUF_TRANS_HI(port, i)	_MMIO(_PORT(port,
> _DDI_BUF_TRANS_A, _DDI_BUF_TRANS_B) + (i) * 8 + 4)
> -
> -/* DDI DP Compliance Control */
> -#define _DDI_DP_COMP_CTL_A			0x605F0
> -#define _DDI_DP_COMP_CTL_B			0x615F0
> -#define DDI_DP_COMP_CTL(pipe)			_MMIO_PIPE(pipe,
> _DDI_DP_COMP_CTL_A, _DDI_DP_COMP_CTL_B)
> -#define   DDI_DP_COMP_CTL_ENABLE		(1 << 31)
> -#define   DDI_DP_COMP_CTL_D10_2			(0 << 28)
> -#define   DDI_DP_COMP_CTL_SCRAMBLED_0		(1 << 28)
> -#define   DDI_DP_COMP_CTL_PRBS7			(2 << 28)
> -#define   DDI_DP_COMP_CTL_CUSTOM80		(3 << 28)
> -#define   DDI_DP_COMP_CTL_HBR2			(4 << 28)
> -#define   DDI_DP_COMP_CTL_SCRAMBLED_1		(5 << 28)
> -#define   DDI_DP_COMP_CTL_HBR2_RESET		(0xFC << 0)
> -
> -/* DDI DP Compliance Pattern */
> -#define _DDI_DP_COMP_PAT_A			0x605F4
> -#define _DDI_DP_COMP_PAT_B			0x615F4
> -#define DDI_DP_COMP_PAT(pipe, i)		_MMIO(_PIPE(pipe,
> _DDI_DP_COMP_PAT_A, _DDI_DP_COMP_PAT_B) + (i) * 4)
> -
>  /* Sideband Interface (SBI) is programmed indirectly, via
>   * SBI_ADDR, which contains the register offset; and SBI_DATA,
>   * which contains the payload */
> @@ -3644,502 +1440,15 @@ enum skl_power_gate {
>  #define  SBI_BUSY			(0x1 << 0)
>  #define  SBI_READY			(0x0 << 0)
> 
> -/* SBI offsets */
> -#define  SBI_SSCDIVINTPHASE			0x0200
> -#define  SBI_SSCDIVINTPHASE6			0x0600
> -#define   SBI_SSCDIVINTPHASE_DIVSEL_SHIFT	1
> -#define   SBI_SSCDIVINTPHASE_DIVSEL_MASK	(0x7f << 1)
> -#define   SBI_SSCDIVINTPHASE_DIVSEL(x)		((x) << 1)
> -#define   SBI_SSCDIVINTPHASE_INCVAL_SHIFT	8
> -#define   SBI_SSCDIVINTPHASE_INCVAL_MASK	(0x7f << 8)
> -#define   SBI_SSCDIVINTPHASE_INCVAL(x)		((x) << 8)
> -#define   SBI_SSCDIVINTPHASE_DIR(x)		((x) << 15)
> -#define   SBI_SSCDIVINTPHASE_PROPAGATE		(1 << 0)
> -#define  SBI_SSCDITHPHASE			0x0204
> -#define  SBI_SSCCTL				0x020c
> -#define  SBI_SSCCTL6				0x060C
> -#define   SBI_SSCCTL_PATHALT			(1 << 3)
> -#define   SBI_SSCCTL_DISABLE			(1 << 0)
> -#define  SBI_SSCAUXDIV6				0x0610
> -#define   SBI_SSCAUXDIV_FINALDIV2SEL_SHIFT	4
> -#define   SBI_SSCAUXDIV_FINALDIV2SEL_MASK	(1 << 4)
> -#define   SBI_SSCAUXDIV_FINALDIV2SEL(x)		((x) << 4)
> -#define  SBI_DBUFF0				0x2a00
> -#define  SBI_GEN0				0x1f00
> -#define   SBI_GEN0_CFG_BUFFENABLE_DISABLE	(1 << 0)
> -
> -/* LPT PIXCLK_GATE */
> -#define PIXCLK_GATE			_MMIO(0xC6020)
> -#define  PIXCLK_GATE_UNGATE		(1 << 0)
> -#define  PIXCLK_GATE_GATE		(0 << 0)
> -
> -/* SPLL */
> -#define SPLL_CTL			_MMIO(0x46020)
> -#define  SPLL_PLL_ENABLE		(1 << 31)
> -#define  SPLL_REF_BCLK			(0 << 28)
> -#define  SPLL_REF_MUXED_SSC		(1 << 28) /* CPU SSC if fused
> enabled, PCH SSC otherwise */
> -#define  SPLL_REF_NON_SSC_HSW		(2 << 28)
> -#define  SPLL_REF_PCH_SSC_BDW		(2 << 28)
> -#define  SPLL_REF_LCPLL			(3 << 28)
> -#define  SPLL_REF_MASK			(3 << 28)
> -#define  SPLL_FREQ_810MHz		(0 << 26)
> -#define  SPLL_FREQ_1350MHz		(1 << 26)
> -#define  SPLL_FREQ_2700MHz		(2 << 26)
> -#define  SPLL_FREQ_MASK			(3 << 26)
> -
> -/* WRPLL */
> -#define _WRPLL_CTL1			0x46040
> -#define _WRPLL_CTL2			0x46060
> -#define WRPLL_CTL(pll)			_MMIO_PIPE(pll,
> _WRPLL_CTL1, _WRPLL_CTL2)
> -#define  WRPLL_PLL_ENABLE		(1 << 31)
> -#define  WRPLL_REF_BCLK			(0 << 28)
> -#define  WRPLL_REF_PCH_SSC		(1 << 28)
> -#define  WRPLL_REF_MUXED_SSC_BDW	(2 << 28) /* CPU SSC if fused
> enabled, PCH SSC otherwise */
> -#define  WRPLL_REF_SPECIAL_HSW		(2 << 28) /* muxed SSC (ULT),
> non-SSC (non-ULT) */
> -#define  WRPLL_REF_LCPLL		(3 << 28)
> -#define  WRPLL_REF_MASK			(3 << 28)
> -/* WRPLL divider programming */
> -#define  WRPLL_DIVIDER_REFERENCE(x)	((x) << 0)
> -#define  WRPLL_DIVIDER_REF_MASK		(0xff)
> -#define  WRPLL_DIVIDER_POST(x)		((x) << 8)
> -#define  WRPLL_DIVIDER_POST_MASK	(0x3f << 8)
> -#define  WRPLL_DIVIDER_POST_SHIFT	8
> -#define  WRPLL_DIVIDER_FEEDBACK(x)	((x) << 16)
> -#define  WRPLL_DIVIDER_FB_SHIFT		16
> -#define  WRPLL_DIVIDER_FB_MASK		(0xff << 16)
> -
> -/* Port clock selection */
> -#define _PORT_CLK_SEL_A			0x46100
> -#define _PORT_CLK_SEL_B			0x46104
> -#define PORT_CLK_SEL(port) _MMIO_PORT(port, _PORT_CLK_SEL_A,
> _PORT_CLK_SEL_B)
> -#define  PORT_CLK_SEL_MASK		REG_GENMASK(31, 29)
> -#define  PORT_CLK_SEL_LCPLL_2700
> 	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 0)
> -#define  PORT_CLK_SEL_LCPLL_1350
> 	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 1)
> -#define  PORT_CLK_SEL_LCPLL_810
> 	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 2)
> -#define  PORT_CLK_SEL_SPLL
> 	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 3)
> -#define  PORT_CLK_SEL_WRPLL(pll)
> 	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 4 + (pll))
> -#define  PORT_CLK_SEL_WRPLL1
> 	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 4)
> -#define  PORT_CLK_SEL_WRPLL2
> 	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 5)
> -#define  PORT_CLK_SEL_NONE
> 	REG_FIELD_PREP(PORT_CLK_SEL_MASK, 7)
> -
> -/* On ICL+ this is the same as PORT_CLK_SEL, but all bits change. */
> -#define DDI_CLK_SEL(port)		PORT_CLK_SEL(port)
> -#define  DDI_CLK_SEL_MASK		REG_GENMASK(31, 28)
> -#define  DDI_CLK_SEL_NONE
> 	REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0x0)
> -#define  DDI_CLK_SEL_MG
> 	REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0x8)
> -#define  DDI_CLK_SEL_TBT_162
> 	REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xC)
> -#define  DDI_CLK_SEL_TBT_270
> 	REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xD)
> -#define  DDI_CLK_SEL_TBT_540
> 	REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xE)
> -#define  DDI_CLK_SEL_TBT_810
> 	REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xF)
> -
> -/* Transcoder clock selection */
> -#define _TRANS_CLK_SEL_A		0x46140
> -#define _TRANS_CLK_SEL_B		0x46144
> -#define TRANS_CLK_SEL(tran) _MMIO_TRANS(tran, _TRANS_CLK_SEL_A,
> _TRANS_CLK_SEL_B)
> -/* For each transcoder, we need to select the corresponding port clock */
> -#define  TRANS_CLK_SEL_DISABLED		(0x0 << 29)
> -#define  TRANS_CLK_SEL_PORT(x)		(((x) + 1) << 29)
> -#define  TGL_TRANS_CLK_SEL_DISABLED	(0x0 << 28)
> -#define  TGL_TRANS_CLK_SEL_PORT(x)	(((x) + 1) << 28)
> -
> -
> -#define CDCLK_FREQ			_MMIO(0x46200)
> -
> -#define _TRANSA_MSA_MISC		0x60410
> -#define _TRANSB_MSA_MISC		0x61410
> -#define _TRANSC_MSA_MISC		0x62410
> -#define _TRANS_EDP_MSA_MISC		0x6f410
> -#define TRANS_MSA_MISC(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran,
> _TRANSA_MSA_MISC)
> -/* See DP_MSA_MISC_* for the bit definitions */
> -
> -#define _TRANS_A_SET_CONTEXT_LATENCY		0x6007C
> -#define _TRANS_B_SET_CONTEXT_LATENCY		0x6107C
> -#define _TRANS_C_SET_CONTEXT_LATENCY		0x6207C
> -#define _TRANS_D_SET_CONTEXT_LATENCY		0x6307C
> -#define TRANS_SET_CONTEXT_LATENCY(dev_priv, tran)
> 	_MMIO_TRANS2(dev_priv, tran, _TRANS_A_SET_CONTEXT_LATENCY)
> -#define  TRANS_SET_CONTEXT_LATENCY_MASK
> 	REG_GENMASK(15, 0)
> -#define  TRANS_SET_CONTEXT_LATENCY_VALUE(x)
> 	REG_FIELD_PREP(TRANS_SET_CONTEXT_LATENCY_MASK, (x))
> -
> -/* LCPLL Control */
> -#define LCPLL_CTL			_MMIO(0x130040)
> -#define  LCPLL_PLL_DISABLE		(1 << 31)
> -#define  LCPLL_PLL_LOCK			(1 << 30)
> -#define  LCPLL_REF_NON_SSC		(0 << 28)
> -#define  LCPLL_REF_BCLK			(2 << 28)
> -#define  LCPLL_REF_PCH_SSC		(3 << 28)
> -#define  LCPLL_REF_MASK			(3 << 28)
> -#define  LCPLL_CLK_FREQ_MASK		(3 << 26)
> -#define  LCPLL_CLK_FREQ_450		(0 << 26)
> -#define  LCPLL_CLK_FREQ_54O_BDW		(1 << 26)
> -#define  LCPLL_CLK_FREQ_337_5_BDW	(2 << 26)
> -#define  LCPLL_CLK_FREQ_675_BDW		(3 << 26)
> -#define  LCPLL_CD_CLOCK_DISABLE		(1 << 25)
> -#define  LCPLL_ROOT_CD_CLOCK_DISABLE	(1 << 24)
> -#define  LCPLL_CD2X_CLOCK_DISABLE	(1 << 23)
> -#define  LCPLL_POWER_DOWN_ALLOW		(1 << 22)
> -#define  LCPLL_CD_SOURCE_FCLK		(1 << 21)
> -#define  LCPLL_CD_SOURCE_FCLK_DONE	(1 << 19)
> -
> -/*
> - * SKL Clocks
> - */
> -/* CDCLK_CTL */
> -#define CDCLK_CTL			_MMIO(0x46000)
> -#define  CDCLK_FREQ_SEL_MASK		REG_GENMASK(27, 26)
> -#define  CDCLK_FREQ_450_432
> 	REG_FIELD_PREP(CDCLK_FREQ_SEL_MASK, 0)
> -#define  CDCLK_FREQ_540
> 	REG_FIELD_PREP(CDCLK_FREQ_SEL_MASK, 1)
> -#define  CDCLK_FREQ_337_308
> 	REG_FIELD_PREP(CDCLK_FREQ_SEL_MASK, 2)
> -#define  CDCLK_FREQ_675_617
> 	REG_FIELD_PREP(CDCLK_FREQ_SEL_MASK, 3)
> -#define  MDCLK_SOURCE_SEL_MASK		REG_GENMASK(25, 25)
> -#define  MDCLK_SOURCE_SEL_CD2XCLK
> 	REG_FIELD_PREP(MDCLK_SOURCE_SEL_MASK, 0)
> -#define  MDCLK_SOURCE_SEL_CDCLK_PLL
> 	REG_FIELD_PREP(MDCLK_SOURCE_SEL_MASK, 1)
> -#define  BXT_CDCLK_CD2X_DIV_SEL_MASK	REG_GENMASK(23, 22)
> -#define  BXT_CDCLK_CD2X_DIV_SEL_1
> 	REG_FIELD_PREP(BXT_CDCLK_CD2X_DIV_SEL_MASK, 0)
> -#define  BXT_CDCLK_CD2X_DIV_SEL_1_5
> 	REG_FIELD_PREP(BXT_CDCLK_CD2X_DIV_SEL_MASK, 1)
> -#define  BXT_CDCLK_CD2X_DIV_SEL_2
> 	REG_FIELD_PREP(BXT_CDCLK_CD2X_DIV_SEL_MASK, 2)
> -#define  BXT_CDCLK_CD2X_DIV_SEL_4
> 	REG_FIELD_PREP(BXT_CDCLK_CD2X_DIV_SEL_MASK, 3)
> -#define  BXT_CDCLK_CD2X_PIPE(pipe)	((pipe) << 20)
> -#define  CDCLK_DIVMUX_CD_OVERRIDE	(1 << 19)
> -#define  BXT_CDCLK_CD2X_PIPE_NONE	BXT_CDCLK_CD2X_PIPE(3)
> -#define  ICL_CDCLK_CD2X_PIPE(pipe)	(_PICK(pipe, 0, 2, 6) << 19)
> -#define  ICL_CDCLK_CD2X_PIPE_NONE	(7 << 19)
> -#define  TGL_CDCLK_CD2X_PIPE(pipe)	BXT_CDCLK_CD2X_PIPE(pipe)
> -#define  TGL_CDCLK_CD2X_PIPE_NONE	ICL_CDCLK_CD2X_PIPE_NONE
> -#define  BXT_CDCLK_SSA_PRECHARGE_ENABLE	(1 << 16)
> -#define  CDCLK_FREQ_DECIMAL_MASK	(0x7ff)
> -
> -/* CDCLK_SQUASH_CTL */
> -#define CDCLK_SQUASH_CTL		_MMIO(0x46008)
> -#define  CDCLK_SQUASH_ENABLE		REG_BIT(31)
> -#define  CDCLK_SQUASH_WINDOW_SIZE_MASK	REG_GENMASK(27,
> 24)
> -#define  CDCLK_SQUASH_WINDOW_SIZE(x)
> 	REG_FIELD_PREP(CDCLK_SQUASH_WINDOW_SIZE_MASK, (x))
> -#define  CDCLK_SQUASH_WAVEFORM_MASK	REG_GENMASK(15, 0)
> -#define  CDCLK_SQUASH_WAVEFORM(x)
> 	REG_FIELD_PREP(CDCLK_SQUASH_WAVEFORM_MASK, (x))
> -
> -/* LCPLL_CTL */
> -#define LCPLL1_CTL		_MMIO(0x46010)
> -#define LCPLL2_CTL		_MMIO(0x46014)
> -#define  LCPLL_PLL_ENABLE	(1 << 31)
> -
> -/* DPLL control1 */
> -#define DPLL_CTRL1		_MMIO(0x6C058)
> -#define  DPLL_CTRL1_HDMI_MODE(id)		(1 << ((id) * 6 + 5))
> -#define  DPLL_CTRL1_SSC(id)			(1 << ((id) * 6 + 4))
> -#define  DPLL_CTRL1_LINK_RATE_MASK(id)		(7 << ((id) * 6 + 1))
> -#define  DPLL_CTRL1_LINK_RATE_SHIFT(id)		((id) * 6 + 1)
> -#define  DPLL_CTRL1_LINK_RATE(linkrate, id)	((linkrate) << ((id) * 6 + 1))
> -#define  DPLL_CTRL1_OVERRIDE(id)		(1 << ((id) * 6))
> -#define  DPLL_CTRL1_LINK_RATE_2700		0
> -#define  DPLL_CTRL1_LINK_RATE_1350		1
> -#define  DPLL_CTRL1_LINK_RATE_810		2
> -#define  DPLL_CTRL1_LINK_RATE_1620		3
> -#define  DPLL_CTRL1_LINK_RATE_1080		4
> -#define  DPLL_CTRL1_LINK_RATE_2160		5
> -
> -/* DPLL control2 */
> -#define DPLL_CTRL2				_MMIO(0x6C05C)
> -#define  DPLL_CTRL2_DDI_CLK_OFF(port)		(1 << ((port) + 15))
> -#define  DPLL_CTRL2_DDI_CLK_SEL_MASK(port)	(3 << ((port) * 3 + 1))
> -#define  DPLL_CTRL2_DDI_CLK_SEL_SHIFT(port)    ((port) * 3 + 1)
> -#define  DPLL_CTRL2_DDI_CLK_SEL(clk, port)	((clk) << ((port) * 3 + 1))
> -#define  DPLL_CTRL2_DDI_SEL_OVERRIDE(port)     (1 << ((port) * 3))
> -
> -/* DPLL Status */
> -#define DPLL_STATUS	_MMIO(0x6C060)
> -#define  DPLL_LOCK(id) (1 << ((id) * 8))
> -
> -/* DPLL cfg */
> -#define _DPLL1_CFGCR1	0x6C040
> -#define _DPLL2_CFGCR1	0x6C048
> -#define _DPLL3_CFGCR1	0x6C050
> -#define DPLL_CFGCR1(id)	_MMIO_PIPE((id) - SKL_DPLL1,
> _DPLL1_CFGCR1, _DPLL2_CFGCR1)
> -#define  DPLL_CFGCR1_FREQ_ENABLE	(1 << 31)
> -#define  DPLL_CFGCR1_DCO_FRACTION_MASK	(0x7fff << 9)
> -#define  DPLL_CFGCR1_DCO_FRACTION(x)	((x) << 9)
> -#define  DPLL_CFGCR1_DCO_INTEGER_MASK	(0x1ff)
> -
> -#define _DPLL1_CFGCR2	0x6C044
> -#define _DPLL2_CFGCR2	0x6C04C
> -#define _DPLL3_CFGCR2	0x6C054
> -#define DPLL_CFGCR2(id)	_MMIO_PIPE((id) - SKL_DPLL1,
> _DPLL1_CFGCR2, _DPLL2_CFGCR2)
> -#define  DPLL_CFGCR2_QDIV_RATIO_MASK	(0xff << 8)
> -#define  DPLL_CFGCR2_QDIV_RATIO(x)	((x) << 8)
> -#define  DPLL_CFGCR2_QDIV_MODE(x)	((x) << 7)
> -#define  DPLL_CFGCR2_KDIV_MASK		(3 << 5)
> -#define  DPLL_CFGCR2_KDIV(x)		((x) << 5)
> -#define  DPLL_CFGCR2_KDIV_5 (0 << 5)
> -#define  DPLL_CFGCR2_KDIV_2 (1 << 5)
> -#define  DPLL_CFGCR2_KDIV_3 (2 << 5)
> -#define  DPLL_CFGCR2_KDIV_1 (3 << 5)
> -#define  DPLL_CFGCR2_PDIV_MASK		(7 << 2)
> -#define  DPLL_CFGCR2_PDIV(x)		((x) << 2)
> -#define  DPLL_CFGCR2_PDIV_1 (0 << 2)
> -#define  DPLL_CFGCR2_PDIV_2 (1 << 2)
> -#define  DPLL_CFGCR2_PDIV_3 (2 << 2)
> -#define  DPLL_CFGCR2_PDIV_7 (4 << 2)
> -#define  DPLL_CFGCR2_PDIV_7_INVALID	(5 << 2)
> -#define  DPLL_CFGCR2_CENTRAL_FREQ_MASK	(3)
> -
> -/* ICL Clocks */
> -#define ICL_DPCLKA_CFGCR0			_MMIO(0x164280)
> -#define  ICL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy)	(1 << _PICK(phy, 10,
> 11, 24, 4, 5))
> -#define  RKL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy)	REG_BIT((phy) + 10)
> -#define  ICL_DPCLKA_CFGCR0_TC_CLK_OFF(tc_port)	(1 << ((tc_port) <
> TC_PORT_4 ? \
> -						       (tc_port) + 12 : \
> -						       (tc_port) - TC_PORT_4 +
> 21))
> -#define  ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy)	((phy) * 2)
> -#define  ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK(phy)	(3 <<
> ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
> -#define  ICL_DPCLKA_CFGCR0_DDI_CLK_SEL(pll, phy)	((pll) <<
> ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
> -#define  RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy)	_PICK(phy, 0,
> 2, 4, 27)
> -#define  RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK(phy) \
> -	(3 << RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
> -#define  RKL_DPCLKA_CFGCR0_DDI_CLK_SEL(pll, phy) \
> -	((pll) << RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
> -
> -/*
> - * DG1 Clocks
> - * First registers controls the first A and B, while the second register
> - * controls the phy C and D. The bits on these registers are the
> - * same, but refer to different phys
> - */
> -#define _DG1_DPCLKA_CFGCR0				0x164280
> -#define _DG1_DPCLKA1_CFGCR0				0x16C280
> -#define _DG1_DPCLKA_PHY_IDX(phy)			((phy) % 2)
> -#define _DG1_DPCLKA_PLL_IDX(pll)			((pll) % 2)
> -#define DG1_DPCLKA_CFGCR0(phy)
> 	_MMIO_PHY((phy) / 2, \
> -
> _DG1_DPCLKA_CFGCR0, \
> -
> _DG1_DPCLKA1_CFGCR0)
> -#define   DG1_DPCLKA_CFGCR0_DDI_CLK_OFF(phy)
> 	REG_BIT(_DG1_DPCLKA_PHY_IDX(phy) + 10)
> -#define   DG1_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy)
> 	(_DG1_DPCLKA_PHY_IDX(phy) * 2)
> -#define   DG1_DPCLKA_CFGCR0_DDI_CLK_SEL(pll, phy)
> 	(_DG1_DPCLKA_PLL_IDX(pll) <<
> DG1_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
> -#define   DG1_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK(phy)	(0x3 <<
> DG1_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))
> -
> -/* ADLS Clocks */
> -#define _ADLS_DPCLKA_CFGCR0			0x164280
> -#define _ADLS_DPCLKA_CFGCR1			0x1642BC
> -#define ADLS_DPCLKA_CFGCR(phy)			_MMIO_PHY((phy) /
> 3, \
> -
> _ADLS_DPCLKA_CFGCR0, \
> -
> _ADLS_DPCLKA_CFGCR1)
> -#define  ADLS_DPCLKA_CFGCR_DDI_SHIFT(phy)		(((phy) % 3) *
> 2)
> -/* ADLS DPCLKA_CFGCR0 DDI mask */
> -#define  ADLS_DPCLKA_DDII_SEL_MASK
> 	REG_GENMASK(5, 4)
> -#define  ADLS_DPCLKA_DDIB_SEL_MASK
> 	REG_GENMASK(3, 2)
> -#define  ADLS_DPCLKA_DDIA_SEL_MASK
> 	REG_GENMASK(1, 0)
> -/* ADLS DPCLKA_CFGCR1 DDI mask */
> -#define  ADLS_DPCLKA_DDIK_SEL_MASK
> 	REG_GENMASK(3, 2)
> -#define  ADLS_DPCLKA_DDIJ_SEL_MASK
> 	REG_GENMASK(1, 0)
> -#define  ADLS_DPCLKA_CFGCR_DDI_CLK_SEL_MASK(phy)	_PICK((phy), \
> -
> 	ADLS_DPCLKA_DDIA_SEL_MASK, \
> -
> 	ADLS_DPCLKA_DDIB_SEL_MASK, \
> -
> 	ADLS_DPCLKA_DDII_SEL_MASK, \
> -
> 	ADLS_DPCLKA_DDIJ_SEL_MASK, \
> -
> 	ADLS_DPCLKA_DDIK_SEL_MASK)
> -
> -/* ICL PLL */
> -#define _DPLL0_ENABLE		0x46010
> -#define _DPLL1_ENABLE		0x46014
> -#define _ADLS_DPLL2_ENABLE	0x46018
> -#define _ADLS_DPLL3_ENABLE	0x46030
> -#define   PLL_ENABLE		REG_BIT(31)
> -#define   PLL_LOCK		REG_BIT(30)
> -#define   PLL_POWER_ENABLE	REG_BIT(27)
> -#define   PLL_POWER_STATE	REG_BIT(26)
> -#define ICL_DPLL_ENABLE(pll)	_MMIO(_PICK_EVEN_2RANGES(pll, 3,
> 		\
> -							_DPLL0_ENABLE,
> _DPLL1_ENABLE,	\
> -
> 	_ADLS_DPLL3_ENABLE, _ADLS_DPLL3_ENABLE))
> 
>  #define _DG2_PLL3_ENABLE	0x4601C
> 
> -#define DG2_PLL_ENABLE(pll)	_MMIO(_PICK_EVEN_2RANGES(pll, 3,
> 		\
> -							_DPLL0_ENABLE,
> _DPLL1_ENABLE,	\
> -							_DG2_PLL3_ENABLE,
> _DG2_PLL3_ENABLE))
> -
> -#define TBT_PLL_ENABLE		_MMIO(0x46020)
> -
> -#define _MG_PLL1_ENABLE		0x46030
> -#define _MG_PLL2_ENABLE		0x46034
> -#define _MG_PLL3_ENABLE		0x46038
> -#define _MG_PLL4_ENABLE		0x4603C
> -/* Bits are the same as _DPLL0_ENABLE */
> -#define MG_PLL_ENABLE(tc_port)	_MMIO_PORT((tc_port),
> _MG_PLL1_ENABLE, \
> -					   _MG_PLL2_ENABLE)
> -
> -/* DG1 PLL */
> -#define DG1_DPLL_ENABLE(pll)    _MMIO(_PICK_EVEN_2RANGES(pll, 2,
> 			\
> -							_DPLL0_ENABLE,
> _DPLL1_ENABLE,	\
> -							_MG_PLL1_ENABLE,
> _MG_PLL2_ENABLE))
> -
> -/* ADL-P Type C PLL */
> -#define PORTTC1_PLL_ENABLE	0x46038
> -#define PORTTC2_PLL_ENABLE	0x46040
> -#define ADLP_PORTTC_PLL_ENABLE(tc_port)
> 	_MMIO_PORT((tc_port), \
> -
> PORTTC1_PLL_ENABLE, \
> -
> PORTTC2_PLL_ENABLE)
> -
> -#define _ICL_DPLL0_CFGCR0		0x164000
> -#define _ICL_DPLL1_CFGCR0		0x164080
> -#define ICL_DPLL_CFGCR0(pll)		_MMIO_PLL(pll, _ICL_DPLL0_CFGCR0,
> \
> -						  _ICL_DPLL1_CFGCR0)
> -#define   DPLL_CFGCR0_HDMI_MODE		(1 << 30)
> -#define   DPLL_CFGCR0_SSC_ENABLE	(1 << 29)
> -#define   DPLL_CFGCR0_SSC_ENABLE_ICL	(1 << 25)
> -#define   DPLL_CFGCR0_LINK_RATE_MASK	(0xf << 25)
> -#define   DPLL_CFGCR0_LINK_RATE_2700	(0 << 25)
> -#define   DPLL_CFGCR0_LINK_RATE_1350	(1 << 25)
> -#define   DPLL_CFGCR0_LINK_RATE_810	(2 << 25)
> -#define   DPLL_CFGCR0_LINK_RATE_1620	(3 << 25)
> -#define   DPLL_CFGCR0_LINK_RATE_1080	(4 << 25)
> -#define   DPLL_CFGCR0_LINK_RATE_2160	(5 << 25)
> -#define   DPLL_CFGCR0_LINK_RATE_3240	(6 << 25)
> -#define   DPLL_CFGCR0_LINK_RATE_4050	(7 << 25)
> -#define   DPLL_CFGCR0_DCO_FRACTION_MASK	(0x7fff << 10)
> -#define   DPLL_CFGCR0_DCO_FRACTION_SHIFT	(10)
> -#define   DPLL_CFGCR0_DCO_FRACTION(x)	((x) << 10)
> -#define   DPLL_CFGCR0_DCO_INTEGER_MASK	(0x3ff)
> -
> -#define _ICL_DPLL0_CFGCR1		0x164004
> -#define _ICL_DPLL1_CFGCR1		0x164084
> -#define ICL_DPLL_CFGCR1(pll)		_MMIO_PLL(pll, _ICL_DPLL0_CFGCR1,
> \
> -						  _ICL_DPLL1_CFGCR1)
> -#define   DPLL_CFGCR1_QDIV_RATIO_MASK	(0xff << 10)
> -#define   DPLL_CFGCR1_QDIV_RATIO_SHIFT	(10)
> -#define   DPLL_CFGCR1_QDIV_RATIO(x)	((x) << 10)
> -#define   DPLL_CFGCR1_QDIV_MODE_SHIFT	(9)
> -#define   DPLL_CFGCR1_QDIV_MODE(x)	((x) << 9)
> -#define   DPLL_CFGCR1_KDIV_MASK		(7 << 6)
> -#define   DPLL_CFGCR1_KDIV_SHIFT		(6)
> -#define   DPLL_CFGCR1_KDIV(x)		((x) << 6)
> -#define   DPLL_CFGCR1_KDIV_1		(1 << 6)
> -#define   DPLL_CFGCR1_KDIV_2		(2 << 6)
> -#define   DPLL_CFGCR1_KDIV_3		(4 << 6)
> -#define   DPLL_CFGCR1_PDIV_MASK		(0xf << 2)
> -#define   DPLL_CFGCR1_PDIV_SHIFT		(2)
> -#define   DPLL_CFGCR1_PDIV(x)		((x) << 2)
> -#define   DPLL_CFGCR1_PDIV_2		(1 << 2)
> -#define   DPLL_CFGCR1_PDIV_3		(2 << 2)
> -#define   DPLL_CFGCR1_PDIV_5		(4 << 2)
> -#define   DPLL_CFGCR1_PDIV_7		(8 << 2)
> -#define   DPLL_CFGCR1_CENTRAL_FREQ	(3 << 0)
> -#define   DPLL_CFGCR1_CENTRAL_FREQ_8400	(3 << 0)
> -#define   TGL_DPLL_CFGCR1_CFSELOVRD_NORMAL_XTAL	(0 << 0)
> -
> -#define _TGL_DPLL0_CFGCR0		0x164284
> -#define _TGL_DPLL1_CFGCR0		0x16428C
> -#define _TGL_TBTPLL_CFGCR0		0x16429C
> -#define TGL_DPLL_CFGCR0(pll)
> 	_MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
> -					      _TGL_DPLL0_CFGCR0,
> _TGL_DPLL1_CFGCR0,	\
> -					      _TGL_TBTPLL_CFGCR0,
> _TGL_TBTPLL_CFGCR0))
> -#define RKL_DPLL_CFGCR0(pll)		_MMIO_PLL(pll,
> _TGL_DPLL0_CFGCR0, \
> -						  _TGL_DPLL1_CFGCR0)
> -
> -#define _TGL_DPLL0_DIV0					0x164B00
> -#define _TGL_DPLL1_DIV0					0x164C00
> -#define TGL_DPLL0_DIV0(pll)				_MMIO_PLL(pll,
> _TGL_DPLL0_DIV0, _TGL_DPLL1_DIV0)
> -#define   TGL_DPLL0_DIV0_AFC_STARTUP_MASK
> 	REG_GENMASK(27, 25)
> -#define   TGL_DPLL0_DIV0_AFC_STARTUP(val)
> 	REG_FIELD_PREP(TGL_DPLL0_DIV0_AFC_STARTUP_MASK, (val))
> -
> -#define _TGL_DPLL0_CFGCR1		0x164288
> -#define _TGL_DPLL1_CFGCR1		0x164290
> -#define _TGL_TBTPLL_CFGCR1		0x1642A0
> -#define TGL_DPLL_CFGCR1(pll)
> 	_MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
> -					      _TGL_DPLL0_CFGCR1,
> _TGL_DPLL1_CFGCR1,	\
> -					      _TGL_TBTPLL_CFGCR1,
> _TGL_TBTPLL_CFGCR1))
> -#define RKL_DPLL_CFGCR1(pll)		_MMIO_PLL(pll,
> _TGL_DPLL0_CFGCR1, \
> -						  _TGL_DPLL1_CFGCR1)
> -
> -#define _DG1_DPLL2_CFGCR0		0x16C284
> -#define _DG1_DPLL3_CFGCR0		0x16C28C
> -#define DG1_DPLL_CFGCR0(pll)
> 	_MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
> -					      _TGL_DPLL0_CFGCR0,
> _TGL_DPLL1_CFGCR0,	\
> -					      _DG1_DPLL2_CFGCR0,
> _DG1_DPLL3_CFGCR0))
> -
> -#define _DG1_DPLL2_CFGCR1               0x16C288
> -#define _DG1_DPLL3_CFGCR1               0x16C290
> -#define DG1_DPLL_CFGCR1(pll)            _MMIO(_PICK_EVEN_2RANGES(pll, 2,
> 		\
> -					      _TGL_DPLL0_CFGCR1,
> _TGL_DPLL1_CFGCR1,	\
> -					      _DG1_DPLL2_CFGCR1,
> _DG1_DPLL3_CFGCR1))
> -
> -/* For ADL-S DPLL4_CFGCR0/1 are used to control DPLL2 */
> -#define _ADLS_DPLL4_CFGCR0		0x164294
> -#define _ADLS_DPLL3_CFGCR0		0x1642C0
> -#define ADLS_DPLL_CFGCR0(pll)
> 	_MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
> -					      _TGL_DPLL0_CFGCR0,
> _TGL_DPLL1_CFGCR0,	\
> -					      _ADLS_DPLL4_CFGCR0,
> _ADLS_DPLL3_CFGCR0))
> -
> -#define _ADLS_DPLL4_CFGCR1		0x164298
> -#define _ADLS_DPLL3_CFGCR1		0x1642C4
> -#define ADLS_DPLL_CFGCR1(pll)
> 	_MMIO(_PICK_EVEN_2RANGES(pll, 2,		\
> -					      _TGL_DPLL0_CFGCR1,
> _TGL_DPLL1_CFGCR1,	\
> -					      _ADLS_DPLL4_CFGCR1,
> _ADLS_DPLL3_CFGCR1))
> -
> -/* BXT display engine PLL */
> -#define BXT_DE_PLL_CTL			_MMIO(0x6d000)
> -#define   BXT_DE_PLL_RATIO(x)		(x)	/* {60,65,100} *
> 19.2MHz */
> -#define   BXT_DE_PLL_RATIO_MASK		0xff
> -
> -#define BXT_DE_PLL_ENABLE		_MMIO(0x46070)
> -#define   BXT_DE_PLL_PLL_ENABLE		(1 << 31)
> -#define   BXT_DE_PLL_LOCK		(1 << 30)
> -#define   BXT_DE_PLL_FREQ_REQ		(1 << 23)
> -#define   BXT_DE_PLL_FREQ_REQ_ACK	(1 << 22)
> -#define   ICL_CDCLK_PLL_RATIO(x)	(x)
> -#define   ICL_CDCLK_PLL_RATIO_MASK	0xff
> -
> -/* GEN9 DC */
> -#define DC_STATE_EN			_MMIO(0x45504)
> -#define  DC_STATE_DISABLE		0
> -#define  DC_STATE_EN_DC3CO		REG_BIT(30)
> -#define  DC_STATE_DC3CO_STATUS		REG_BIT(29)
> -#define  HOLD_PHY_CLKREQ_PG1_LATCH	REG_BIT(21)
> -#define  HOLD_PHY_PG1_LATCH		REG_BIT(20)
> -#define  DC_STATE_EN_UPTO_DC5		(1 << 0)
> -#define  DC_STATE_EN_DC9		(1 << 3)
> -#define  DC_STATE_EN_UPTO_DC6		(2 << 0)
> -#define  DC_STATE_EN_UPTO_DC5_DC6_MASK   0x3
> -
> -#define  DC_STATE_DEBUG                  _MMIO(0x45520)
> -#define  DC_STATE_DEBUG_MASK_CORES	(1 << 0)
> -#define  DC_STATE_DEBUG_MASK_MEMORY_UP	(1 << 1)
> -
> -#define D_COMP_BDW			_MMIO(0x138144)
> -
> -/* Pipe WM_LINETIME - watermark line time */
> -#define _WM_LINETIME_A		0x45270
> -#define _WM_LINETIME_B		0x45274
> -#define WM_LINETIME(pipe) _MMIO_PIPE(pipe, _WM_LINETIME_A,
> _WM_LINETIME_B)
> -#define  HSW_LINETIME_MASK	REG_GENMASK(8, 0)
> -#define  HSW_LINETIME(x)	REG_FIELD_PREP(HSW_LINETIME_MASK, (x))
> -#define  HSW_IPS_LINETIME_MASK	REG_GENMASK(24, 16)
> -#define  HSW_IPS_LINETIME(x)
> 	REG_FIELD_PREP(HSW_IPS_LINETIME_MASK, (x))
> -
> -/* SFUSE_STRAP */
> -#define SFUSE_STRAP			_MMIO(0xc2014)
> -#define  SFUSE_STRAP_FUSE_LOCK		(1 << 13)
> -#define  SFUSE_STRAP_RAW_FREQUENCY	(1 << 8)
> -#define  SFUSE_STRAP_DISPLAY_DISABLED	(1 << 7)
> -#define  SFUSE_STRAP_CRT_DISABLED	(1 << 6)
> -#define  SFUSE_STRAP_DDIF_DETECTED	(1 << 3)
> -#define  SFUSE_STRAP_DDIB_DETECTED	(1 << 2)
> -#define  SFUSE_STRAP_DDIC_DETECTED	(1 << 1)
> -#define  SFUSE_STRAP_DDID_DETECTED	(1 << 0)
> -
> -/* Gen4+ Timestamp and Pipe Frame time stamp registers */
> -#define GEN4_TIMESTAMP		_MMIO(0x2358)
> -#define ILK_TIMESTAMP_HI	_MMIO(0x70070)
> -#define IVB_TIMESTAMP_CTR	_MMIO(0x44070)
> -
>  #define GEN9_TIMESTAMP_OVERRIDE
> 	_MMIO(0x44074)
>  #define  GEN9_TIMESTAMP_OVERRIDE_US_COUNTER_DIVIDER_SHIFT	0
>  #define  GEN9_TIMESTAMP_OVERRIDE_US_COUNTER_DIVIDER_MASK	0x3ff
>  #define
> GEN9_TIMESTAMP_OVERRIDE_US_COUNTER_DENOMINATOR_SHIFT	12
>  #define
> GEN9_TIMESTAMP_OVERRIDE_US_COUNTER_DENOMINATOR_MASK	(0xf
> << 12)
> 
> -/* g4x+, except vlv/chv! */
> -#define _PIPE_FRMTMSTMP_A		0x70048
> -#define _PIPE_FRMTMSTMP_B		0x71048
> -#define PIPE_FRMTMSTMP(pipe)		\
> -	_MMIO_PIPE(pipe, _PIPE_FRMTMSTMP_A, _PIPE_FRMTMSTMP_B)
> -
>  /* g4x+, except vlv/chv! */
>  #define _PIPE_FLIPTMSTMP_A		0x7004C
>  #define _PIPE_FLIPTMSTMP_B		0x7104C
> @@ -4152,12 +1461,6 @@ enum skl_power_gate {
>  #define PIPE_FLIPDONETIMSTMP(pipe)	\
>  	_MMIO_PIPE(pipe, _PIPE_FLIPDONETMSTMP_A,
> _PIPE_FLIPDONETMSTMP_B)
> 
> -#define _VLV_PIPE_MSA_MISC_A			0x70048
> -#define VLV_PIPE_MSA_MISC(pipe)		\
> -			_MMIO_PIPE2(dev_priv, pipe,
> _VLV_PIPE_MSA_MISC_A)
> -#define   VLV_MSA_MISC1_HW_ENABLE			REG_BIT(31)
> -#define   VLV_MSA_MISC1_SW_S3D_MASK
> 	REG_GENMASK(2, 0) /* MSA MISC1 3:1 */
> -
>  #define GGC				_MMIO(0x108040)
>  #define   GMS_MASK			REG_GENMASK(15, 8)
>  #define   GGMS_MASK			REG_GENMASK(7, 6)
> @@ -4172,45 +1475,6 @@ enum skl_power_gate {
>  #define   SGGI_DIS			REG_BIT(15)
>  #define   SGR_DIS			REG_BIT(13)
> 
> -#define _ICL_PHY_MISC_A		0x64C00
> -#define _ICL_PHY_MISC_B		0x64C04
> -#define _DG2_PHY_MISC_TC1	0x64C14 /* TC1="PHY E" but offset as if "PHY
> F" */
> -#define ICL_PHY_MISC(port)	_MMIO_PORT(port, _ICL_PHY_MISC_A,
> _ICL_PHY_MISC_B)
> -#define DG2_PHY_MISC(port)	((port) == PHY_E ?
> _MMIO(_DG2_PHY_MISC_TC1) : \
> -				 ICL_PHY_MISC(port))
> -#define  ICL_PHY_MISC_MUX_DDID			(1 << 28)
> -#define  ICL_PHY_MISC_DE_IO_COMP_PWR_DOWN	(1 << 23)
> -#define  DG2_PHY_DP_TX_ACK_MASK			REG_GENMASK(23,
> 20)
> -
> -#define PORT_TX_DFLEXDPSP(fia)			_MMIO_FIA((fia),
> 0x008A0)
> -#define   MODULAR_FIA_MASK			(1 << 4)
> -#define   TC_LIVE_STATE_TBT(idx)		(1 << ((idx) * 8 + 6))
> -#define   TC_LIVE_STATE_TC(idx)			(1 << ((idx) * 8 + 5))
> -#define   DP_LANE_ASSIGNMENT_SHIFT(idx)		((idx) * 8)
> -#define   DP_LANE_ASSIGNMENT_MASK(idx)		(0xf << ((idx) * 8))
> -#define   DP_LANE_ASSIGNMENT(idx, x)		((x) << ((idx) * 8))
> -
> -#define PORT_TX_DFLEXDPPMS(fia)			_MMIO_FIA((fia),
> 0x00890)
> -#define   DP_PHY_MODE_STATUS_COMPLETED(idx)	(1 << (idx))
> -
> -#define PORT_TX_DFLEXDPCSSS(fia)		_MMIO_FIA((fia), 0x00894)
> -#define   DP_PHY_MODE_STATUS_NOT_SAFE(idx)	(1 << (idx))
> -
> -#define PORT_TX_DFLEXPA1(fia)			_MMIO_FIA((fia),
> 0x00880)
> -#define   DP_PIN_ASSIGNMENT_SHIFT(idx)		((idx) * 4)
> -#define   DP_PIN_ASSIGNMENT_MASK(idx)		(0xf << ((idx) * 4))
> -#define   DP_PIN_ASSIGNMENT(idx, x)		((x) << ((idx) * 4))
> -
> -#define _TCSS_DDI_STATUS_1			0x161500
> -#define _TCSS_DDI_STATUS_2			0x161504
> -#define TCSS_DDI_STATUS(tc)			_MMIO(_PICK_EVEN(tc, \
> -
> _TCSS_DDI_STATUS_1, \
> -
> _TCSS_DDI_STATUS_2))
> -#define  TCSS_DDI_STATUS_PIN_ASSIGNMENT_MASK	REG_GENMASK(28,
> 25)
> -#define  TCSS_DDI_STATUS_READY			REG_BIT(2)
> -#define  TCSS_DDI_STATUS_HPD_LIVE_STATUS_TBT	REG_BIT(1)
> -#define  TCSS_DDI_STATUS_HPD_LIVE_STATUS_ALT	REG_BIT(0)
> -
>  #define PRIMARY_SPI_TRIGGER			_MMIO(0x102040)
>  #define PRIMARY_SPI_ADDRESS			_MMIO(0x102080)
>  #define PRIMARY_SPI_REGIONID			_MMIO(0x102084)
> @@ -4219,32 +1483,11 @@ enum skl_power_gate {
>  #define OROM_OFFSET				_MMIO(0x1020c0)
>  #define   OROM_OFFSET_MASK			REG_GENMASK(20,
> 16)
> 
> -#define CLKREQ_POLICY			_MMIO(0x101038)
> -#define  CLKREQ_POLICY_MEM_UP_OVRD	REG_BIT(1)
> -
> -#define CLKGATE_DIS_MISC			_MMIO(0x46534)
> -#define  CLKGATE_DIS_MISC_DMASC_GATING_DIS	REG_BIT(21)
> -
> -#define _MTL_CLKGATE_DIS_TRANS_A			0x604E8
> -#define _MTL_CLKGATE_DIS_TRANS_B			0x614E8
> -#define MTL_CLKGATE_DIS_TRANS(dev_priv, trans)
> 	_MMIO_TRANS2(dev_priv, trans, _MTL_CLKGATE_DIS_TRANS_A)
> -#define  MTL_CLKGATE_DIS_TRANS_DMASC_GATING_DIS
> 	REG_BIT(7)
> -
>  #define MTL_MEM_SS_INFO_GLOBAL			_MMIO(0x45700)
>  #define   MTL_N_OF_ENABLED_QGV_POINTS_MASK	REG_GENMASK(11, 8)
>  #define   MTL_N_OF_POPULATED_CH_MASK		REG_GENMASK(7, 4)
>  #define   MTL_DDR_TYPE_MASK			REG_GENMASK(3, 0)
> 
> -#define MTL_MEM_SS_INFO_QGV_POINT_OFFSET	0x45710
> -#define MTL_MEM_SS_INFO_QGV_POINT_LOW(point)
> 	_MMIO(MTL_MEM_SS_INFO_QGV_POINT_OFFSET + (point) * 8)
> -#define   MTL_TRCD_MASK			REG_GENMASK(31, 24)
> -#define   MTL_TRP_MASK			REG_GENMASK(23, 16)
> -#define   MTL_DCLK_MASK			REG_GENMASK(15, 0)
> -
> -#define MTL_MEM_SS_INFO_QGV_POINT_HIGH(point)
> 	_MMIO(MTL_MEM_SS_INFO_QGV_POINT_OFFSET + (point) * 8 + 4)
> -#define   MTL_TRAS_MASK			REG_GENMASK(16, 8)
> -#define   MTL_TRDPRE_MASK		REG_GENMASK(7, 0)
> -
>  #define MTL_MEDIA_GSI_BASE		0x380000
> 
>  #endif /* _I915_REG_H_ */
> diff --git a/drivers/gpu/drm/i915/intel_gvt_mmio_table.c
> b/drivers/gpu/drm/i915/intel_gvt_mmio_table.c
> index 04076316e139..0dca0b7e738c 100644
> --- a/drivers/gpu/drm/i915/intel_gvt_mmio_table.c
> +++ b/drivers/gpu/drm/i915/intel_gvt_mmio_table.c
> @@ -30,6 +30,7 @@
>  #include "i915_drv.h"
>  #include "i915_pvinfo.h"
>  #include "i915_reg.h"
> +#include "display/intel_display_regs.h"
>  #include "intel_gvt.h"
>  #include "intel_mchbar_regs.h"
> 
> diff --git a/drivers/gpu/drm/xe/display/xe_plane_initial.c
> b/drivers/gpu/drm/xe/display/xe_plane_initial.c
> index 4ca0cb571194..20dd6ed1f184 100644
> --- a/drivers/gpu/drm/xe/display/xe_plane_initial.c
> +++ b/drivers/gpu/drm/xe/display/xe_plane_initial.c
> @@ -10,10 +10,10 @@
>  #include "xe_ggtt.h"
>  #include "xe_mmio.h"
> 
> -#include "i915_reg.h"
>  #include "intel_atomic_plane.h"
>  #include "intel_crtc.h"
>  #include "intel_display.h"
> +#include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_fb.h"
>  #include "intel_fb_pin.h"
> --
> 2.39.5


^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [PATCH 1/3] drm/i915/reg: use REG_BIT and friends to define DP registers
  2025-02-12  8:07   ` Kandpal, Suraj
@ 2025-02-12  9:39     ` Jani Nikula
  2025-02-12 12:42       ` Kandpal, Suraj
  0 siblings, 1 reply; 15+ messages in thread
From: Jani Nikula @ 2025-02-12  9:39 UTC (permalink / raw)
  To: Kandpal, Suraj, intel-gfx@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org
  Cc: ville.syrjala@linux.intel.com, Deak, Imre

On Wed, 12 Feb 2025, "Kandpal, Suraj" <suraj.kandpal@intel.com> wrote:
>> diff --git a/drivers/gpu/drm/i915/i915_reg.h
>> b/drivers/gpu/drm/i915/i915_reg.h index 670cd2371f94..da658c3591f0
>> 100644
>> --- a/drivers/gpu/drm/i915/i915_reg.h
>> +++ b/drivers/gpu/drm/i915/i915_reg.h
>> @@ -1394,88 +1394,50 @@
>>  #define VLV_DP_B             _MMIO(VLV_DISPLAY_BASE + 0x64100)
>>  #define VLV_DP_C             _MMIO(VLV_DISPLAY_BASE + 0x64200)
>>  #define CHV_DP_D             _MMIO(VLV_DISPLAY_BASE + 0x64300)
>> -#define   DP_PORT_EN                 (1 << 31)
>> -#define   DP_PIPE_SEL_SHIFT          30
>> -#define   DP_PIPE_SEL_MASK           (1 << 30)
>> -#define   DP_PIPE_SEL(pipe)          ((pipe) << 30)
>> -#define   DP_PIPE_SEL_SHIFT_IVB              29
>> -#define   DP_PIPE_SEL_MASK_IVB               (3 << 29)
>> -#define   DP_PIPE_SEL_IVB(pipe)              ((pipe) << 29)
>> +#define   DP_PORT_EN                 REG_BIT(31)
>> +#define   DP_PIPE_SEL_MASK           REG_GENMASK(30, 30)
>
> Why not use REG_BIT() here REG_GENMASK for a single bit seems wrong

...because defining a MASK with BIT feels wrong to me. :)


BR,
Jani.


-- 
Jani Nikula, Intel

^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [PATCH 3/3] drm/i915: split out display register macros to a separate file
  2025-02-12  8:48   ` Kandpal, Suraj
@ 2025-02-12  9:41     ` Jani Nikula
  0 siblings, 0 replies; 15+ messages in thread
From: Jani Nikula @ 2025-02-12  9:41 UTC (permalink / raw)
  To: Kandpal, Suraj, intel-gfx@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org
  Cc: ville.syrjala@linux.intel.com, Deak, Imre

On Wed, 12 Feb 2025, "Kandpal, Suraj" <suraj.kandpal@intel.com> wrote:
>> -----Original Message-----
>> From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf Of Jani
>> Nikula
>> Sent: Friday, February 7, 2025 7:05 PM
>> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org
>> Cc: Nikula, Jani <jani.nikula@intel.com>; ville.syrjala@linux.intel.com; Deak,
>> Imre <imre.deak@intel.com>
>> Subject: [PATCH 3/3] drm/i915: split out display register macros to a
>> separate file
>>
>> This is a scripted split of the display related register macros from
>> i915_reg.h to display/intel_display_regs.h. Basically move all the
>> macros that are only used in display code (or GVT). If there are users
>> in core i915 code or soc/, or no users anywhere, keep the macros in
>> i915_reg.h. This is done in groups of macros separated by blank lines,
>> moving the comments along with the groups.
>>
>> This is obviously a very crude approach. It's not perfect. But there are
>> 4.2k lines in i915_reg.h, and its refactoring has ground to a halt. This
>> is the big hammer that splits the file to two, and enables further
>> cleanup.
>>
>
> This is a really big patch and I may have very well missed something but
> Seeing that this is majorly code movement and things like conversion of 1<<x
> To reg_bit will need to happen In a different patch or series LGTM,
> Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>

Oh, I sincerely hope you're aware of 'git show --color-moved'. Applying
the patch and looking at it with that makes it a breeze to review code
movement!

Thanks for the review.

BR,
Jani.


-- 
Jani Nikula, Intel

^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [PATCH 1/3] drm/i915/reg: use REG_BIT and friends to define DP registers
  2025-02-12  9:39     ` Jani Nikula
@ 2025-02-12 12:42       ` Kandpal, Suraj
  0 siblings, 0 replies; 15+ messages in thread
From: Kandpal, Suraj @ 2025-02-12 12:42 UTC (permalink / raw)
  To: Nikula, Jani, intel-gfx@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org
  Cc: ville.syrjala@linux.intel.com, Deak, Imre



> -----Original Message-----
> From: Nikula, Jani <jani.nikula@intel.com>
> Sent: Wednesday, February 12, 2025 3:09 PM
> To: Kandpal, Suraj <suraj.kandpal@intel.com>; intel-
> gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org
> Cc: ville.syrjala@linux.intel.com; Deak, Imre <imre.deak@intel.com>
> Subject: RE: [PATCH 1/3] drm/i915/reg: use REG_BIT and friends to define DP
> registers
> 
> On Wed, 12 Feb 2025, "Kandpal, Suraj" <suraj.kandpal@intel.com> wrote:
> >> diff --git a/drivers/gpu/drm/i915/i915_reg.h
> >> b/drivers/gpu/drm/i915/i915_reg.h index 670cd2371f94..da658c3591f0
> >> 100644
> >> --- a/drivers/gpu/drm/i915/i915_reg.h
> >> +++ b/drivers/gpu/drm/i915/i915_reg.h
> >> @@ -1394,88 +1394,50 @@
> >>  #define VLV_DP_B             _MMIO(VLV_DISPLAY_BASE + 0x64100)
> >>  #define VLV_DP_C             _MMIO(VLV_DISPLAY_BASE + 0x64200)
> >>  #define CHV_DP_D             _MMIO(VLV_DISPLAY_BASE + 0x64300)
> >> -#define   DP_PORT_EN                 (1 << 31)
> >> -#define   DP_PIPE_SEL_SHIFT          30
> >> -#define   DP_PIPE_SEL_MASK           (1 << 30)
> >> -#define   DP_PIPE_SEL(pipe)          ((pipe) << 30)
> >> -#define   DP_PIPE_SEL_SHIFT_IVB              29
> >> -#define   DP_PIPE_SEL_MASK_IVB               (3 << 29)
> >> -#define   DP_PIPE_SEL_IVB(pipe)              ((pipe) << 29)
> >> +#define   DP_PORT_EN                 REG_BIT(31)
> >> +#define   DP_PIPE_SEL_MASK           REG_GENMASK(30, 30)
> >
> > Why not use REG_BIT() here REG_GENMASK for a single bit seems wrong
> 
> ...because defining a MASK with BIT feels wrong to me. :)
> 

Well in that case LGTM,
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>

> 
> BR,
> Jani.
> 
> 
> --
> Jani Nikula, Intel

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 3/3] drm/i915: split out display register macros to a separate file
  2025-02-07 13:35 ` [PATCH 3/3] drm/i915: split out display register macros to a separate file Jani Nikula
  2025-02-12  8:48   ` Kandpal, Suraj
@ 2025-02-12 14:45   ` Ville Syrjälä
  2025-02-12 15:12     ` Ville Syrjälä
  1 sibling, 1 reply; 15+ messages in thread
From: Ville Syrjälä @ 2025-02-12 14:45 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx, intel-xe, imre.deak

On Fri, Feb 07, 2025 at 03:35:22PM +0200, Jani Nikula wrote:
>  #define _FPA0	0x6040
>  #define _FPA1	0x6044
>  #define _FPB0	0x6048
...
>  #define _PIPE_MISC2_A					0x7002C
>  #define _PIPE_MISC2_B					0x7102C
>  #define PIPE_MISC2(pipe)		_MMIO_PIPE(pipe, _PIPE_MISC2_A, _PIPE_MISC2_B)
...
>  #define _PIPEA_FLIPCOUNT_G4X	0x70044
>  #define PIPE_FLIPCOUNT_G4X(dev_priv, pipe) _MMIO_PIPE2(dev_priv, pipe, _PIPEA_FLIPCOUNT_G4X)
...
>  #define _PFA_VSCALE		0x68084
>  #define _PFB_VSCALE		0x68884
>  #define PF_VSCALE(pipe)		_MMIO_PIPE(pipe, _PFA_VSCALE, _PFB_VSCALE)
...
>  #define HSW_PWR_WELL_CTL5			_MMIO(0x45410)
>  #define   HSW_PWR_WELL_ENABLE_SINGLE_STEP	(1 << 31)

This approach seems to leave quite a lot of stuff behind.
I'm just wondering how painful it'll be to find the right spot
for those again after the fact...

-- 
Ville Syrjälä
Intel

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 3/3] drm/i915: split out display register macros to a separate file
  2025-02-12 14:45   ` Ville Syrjälä
@ 2025-02-12 15:12     ` Ville Syrjälä
  2025-02-12 16:49       ` Jani Nikula
  0 siblings, 1 reply; 15+ messages in thread
From: Ville Syrjälä @ 2025-02-12 15:12 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx, intel-xe, imre.deak

On Wed, Feb 12, 2025 at 04:45:31PM +0200, Ville Syrjälä wrote:
> On Fri, Feb 07, 2025 at 03:35:22PM +0200, Jani Nikula wrote:
> >  #define _FPA0	0x6040
> >  #define _FPA1	0x6044
> >  #define _FPB0	0x6048

These at least are only used by the display code, so the
script seems to have some issues picking up everything.

> ...
> >  #define _PIPE_MISC2_A					0x7002C
> >  #define _PIPE_MISC2_B					0x7102C
> >  #define PIPE_MISC2(pipe)		_MMIO_PIPE(pipe, _PIPE_MISC2_A, _PIPE_MISC2_B)

Those aren't used currently, so that explains why they
got left behind.

> ...
> >  #define _PIPEA_FLIPCOUNT_G4X	0x70044
> >  #define PIPE_FLIPCOUNT_G4X(dev_priv, pipe) _MMIO_PIPE2(dev_priv, pipe, _PIPEA_FLIPCOUNT_G4X)
> ...
> >  #define _PFA_VSCALE		0x68084
> >  #define _PFB_VSCALE		0x68884
> >  #define PF_VSCALE(pipe)		_MMIO_PIPE(pipe, _PFA_VSCALE, _PFB_VSCALE)
> ...
> >  #define HSW_PWR_WELL_CTL5			_MMIO(0x45410)
> >  #define   HSW_PWR_WELL_ENABLE_SINGLE_STEP	(1 << 31)

And these three seem to be used from gvt only atm.

-- 
Ville Syrjälä
Intel

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 3/3] drm/i915: split out display register macros to a separate file
  2025-02-12 15:12     ` Ville Syrjälä
@ 2025-02-12 16:49       ` Jani Nikula
  0 siblings, 0 replies; 15+ messages in thread
From: Jani Nikula @ 2025-02-12 16:49 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: intel-gfx, intel-xe, imre.deak

On Wed, 12 Feb 2025, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Feb 12, 2025 at 04:45:31PM +0200, Ville Syrjälä wrote:
>> On Fri, Feb 07, 2025 at 03:35:22PM +0200, Jani Nikula wrote:
>> >  #define _FPA0	0x6040
>> >  #define _FPA1	0x6044
>> >  #define _FPB0	0x6048
>
> These at least are only used by the display code, so the
> script seems to have some issues picking up everything.
>
>> ...
>> >  #define _PIPE_MISC2_A					0x7002C
>> >  #define _PIPE_MISC2_B					0x7102C
>> >  #define PIPE_MISC2(pipe)		_MMIO_PIPE(pipe, _PIPE_MISC2_A, _PIPE_MISC2_B)
>
> Those aren't used currently, so that explains why they
> got left behind.
>
>> ...
>> >  #define _PIPEA_FLIPCOUNT_G4X	0x70044
>> >  #define PIPE_FLIPCOUNT_G4X(dev_priv, pipe) _MMIO_PIPE2(dev_priv, pipe, _PIPEA_FLIPCOUNT_G4X)
>> ...
>> >  #define _PFA_VSCALE		0x68084
>> >  #define _PFB_VSCALE		0x68884
>> >  #define PF_VSCALE(pipe)		_MMIO_PIPE(pipe, _PFA_VSCALE, _PFB_VSCALE)
>> ...
>> >  #define HSW_PWR_WELL_CTL5			_MMIO(0x45410)
>> >  #define   HSW_PWR_WELL_ENABLE_SINGLE_STEP	(1 << 31)
>
> And these three seem to be used from gvt only atm.

Yeah, *sigh*.

I'm just weighing how much more effort I should put into a script that's
needed just once... :p

BR,
Jani.



-- 
Jani Nikula, Intel

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2025-02-12 16:49 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-07 13:35 [PATCH 0/3] drm/i915: i915_reg.h display split Jani Nikula
2025-02-07 13:35 ` [PATCH 1/3] drm/i915/reg: use REG_BIT and friends to define DP registers Jani Nikula
2025-02-12  8:07   ` Kandpal, Suraj
2025-02-12  9:39     ` Jani Nikula
2025-02-12 12:42       ` Kandpal, Suraj
2025-02-07 13:35 ` [PATCH 2/3] drm/i915/reg: Remove some extra blank lines Jani Nikula
2025-02-12  8:07   ` Kandpal, Suraj
2025-02-07 13:35 ` [PATCH 3/3] drm/i915: split out display register macros to a separate file Jani Nikula
2025-02-12  8:48   ` Kandpal, Suraj
2025-02-12  9:41     ` Jani Nikula
2025-02-12 14:45   ` Ville Syrjälä
2025-02-12 15:12     ` Ville Syrjälä
2025-02-12 16:49       ` Jani Nikula
2025-02-07 16:12 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: i915_reg.h display split Patchwork
2025-02-07 19:54 ` ✗ i915.CI.BAT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox