From: Imre Deak <imre.deak@intel.com>
To: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 0/8] Add DSC fractional bpp support
Date: Fri, 22 Sep 2023 15:45:45 +0300 [thread overview]
Message-ID: <ZQ2MeUOrx9bRtswt@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <20230913060606.1105349-1-mitulkumar.ajitkumar.golani@intel.com>
On Wed, Sep 13, 2023 at 11:35:58AM +0530, Mitul Golani wrote:
> his patch series adds support for DSC fractional compressed bpp
> for MTL+. The series starts with some fixes, followed by patches that
> lay groundwork to iterate over valid compressed bpps to select the
> 'best' compressed bpp with optimal link configuration (taken from
> upstream series: https://patchwork.freedesktop.org/series/105200/).
>
> The later patches, add changes to accommodate compressed bpp with
> fractional part, including changes to QP calculations.
> To get the 'best' compressed bpp, we iterate over the valid compressed
> bpp values, but with fractional step size 1/16, 1/8, 1/4 or 1/2 as per
> sink support.
>
> The last 2 patches add support to depict DSC sink's fractional support,
> and debugfs to enforce use of fractional bpp, while choosing an
> appropriate compressed bpp.
MST/DSC is at the moment broken, so I'd prefer merging this patchset
only after it's fixed. This would mean merging
https://lore.kernel.org/all/20230921195159.2646027-1-imre.deak@intel.com
first, followed by the DSC parts from
https://lore.kernel.org/all/20230914192659.757475-1-imre.deak@intel.com
which would also need a rebase for this patchset.
> Ankit Nautiyal (5):
> drm/display/dp: Add helper function to get DSC bpp prescision
> drm/i915/display: Store compressed bpp in U6.4 format
> drm/i915/display: Consider fractional vdsc bpp while computing m_n
> values
> drm/i915/audio : Consider fractional vdsc bpp while computing tu_data
> drm/i915/dp: Iterate over output bpp with fractional step size
>
> Swati Sharma (2):
> drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp
> drm/i915/dsc: Allow DSC only with fractional bpp when forced from
> debugfs
>
> Vandita Kulkarni (1):
> drm/i915/dsc/mtl: Add support for fractional bpp
>
> drivers/gpu/drm/display/drm_dp_helper.c | 27 ++++++
> drivers/gpu/drm/i915/display/icl_dsi.c | 11 +--
> drivers/gpu/drm/i915/display/intel_audio.c | 17 ++--
> drivers/gpu/drm/i915/display/intel_bios.c | 6 +-
> drivers/gpu/drm/i915/display/intel_cdclk.c | 6 +-
> drivers/gpu/drm/i915/display/intel_display.c | 8 +-
> drivers/gpu/drm/i915/display/intel_display.h | 2 +-
> .../drm/i915/display/intel_display_debugfs.c | 83 +++++++++++++++++++
> .../drm/i915/display/intel_display_types.h | 4 +-
> drivers/gpu/drm/i915/display/intel_dp.c | 81 +++++++++++-------
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 32 ++++---
> drivers/gpu/drm/i915/display/intel_fdi.c | 2 +-
> .../i915/display/intel_fractional_helper.h | 36 ++++++++
> .../gpu/drm/i915/display/intel_qp_tables.c | 3 -
> drivers/gpu/drm/i915/display/intel_vdsc.c | 30 +++++--
> include/drm/display/drm_dp_helper.h | 1 +
> 16 files changed, 275 insertions(+), 74 deletions(-)
> create mode 100644 drivers/gpu/drm/i915/display/intel_fractional_helper.h
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-09-22 12:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 6:05 [Intel-gfx] [PATCH 0/8] Add DSC fractional bpp support Mitul Golani
2023-09-13 6:05 ` [Intel-gfx] [PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp prescision Mitul Golani
2023-09-13 6:14 ` Kandpal, Suraj
2023-09-21 7:41 ` Jani Nikula
2023-09-22 12:05 ` Maxime Ripard
2023-09-22 14:39 ` [Intel-gfx] [1/8] " Sui Jingfeng
2023-09-13 6:06 ` [Intel-gfx] [PATCH 2/8] drm/i915/display: Store compressed bpp in U6.4 format Mitul Golani
2023-09-22 16:02 ` [Intel-gfx] [2/8] " Sui Jingfeng
2023-09-13 6:06 ` [Intel-gfx] [PATCH 3/8] drm/i915/display: Consider fractional vdsc bpp while computing m_n values Mitul Golani
2023-09-22 15:12 ` [Intel-gfx] [3/8] " Sui Jingfeng
2023-09-13 6:06 ` [Intel-gfx] [PATCH 4/8] drm/i915/audio : Consider fractional vdsc bpp while computing tu_data Mitul Golani
2023-09-13 6:06 ` [Intel-gfx] [PATCH 5/8] drm/i915/dsc/mtl: Add support for fractional bpp Mitul Golani
2023-09-13 6:06 ` [Intel-gfx] [PATCH 6/8] drm/i915/dp: Iterate over output bpp with fractional step size Mitul Golani
2023-09-13 6:06 ` [Intel-gfx] [PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp Mitul Golani
2023-09-21 8:00 ` Jani Nikula
2023-09-21 11:53 ` Sharma, Swati2
2023-09-21 12:14 ` Jani Nikula
2023-09-21 12:59 ` Sharma, Swati2
2023-09-22 12:28 ` Jani Nikula
2023-09-22 16:03 ` [Intel-gfx] [7/8] " Sui Jingfeng
2023-09-13 6:06 ` [Intel-gfx] [PATCH 8/8] drm/i915/dsc: Allow DSC only with fractional bpp when forced from debugfs Mitul Golani
2023-09-13 6:42 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add DSC fractional bpp support (rev7) Patchwork
2023-09-13 6:42 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-13 6:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-09-13 8:45 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-20 4:56 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
2023-09-22 12:45 ` Imre Deak [this message]
2023-09-27 15:22 ` [Intel-gfx] [PATCH 0/8] Add DSC fractional bpp support Imre Deak
2023-09-27 16:36 ` Sharma, Swati2
-- strict thread matches above, loose matches on Subject: below --
2023-09-29 7:13 Mitul Golani
2023-09-26 8:23 Mitul Golani
2023-09-26 12:38 ` Sui Jingfeng
2023-09-12 16:37 Mitul Golani
2023-09-11 5:05 Mitul Golani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQ2MeUOrx9bRtswt@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=mitulkumar.ajitkumar.golani@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox