Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Aditya Swarup <aditya.swarup@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
	Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [Intel-gfx] [PATCH 1/9] drm/i915/adl_s: Update PHY_MISC programming
Date: Tue, 26 Jan 2021 20:16:21 -0800	[thread overview]
Message-ID: <a5f34b7f-fb18-0ff3-5507-65d230098ae2@intel.com> (raw)
In-Reply-To: <20210127041159.136409-2-aditya.swarup@intel.com>

On 1/26/21 8:11 PM, Aditya Swarup wrote:
> From: Matt Roper <matthew.d.roper@intel.com>
> 
> ADL-S switches up which PHYs are considered a master to other PHYs;
> PHY-C is no longer a master, but PHY-D is now.
> 
> Bspec: 49291
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>

Reviewed-by: Aditya Swarup <aditya.swarup@intel.com>

Aditya

> ---
>  drivers/gpu/drm/i915/display/intel_combo_phy.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> index dd45cbafcf42..c55813c6194a 100644
> --- a/drivers/gpu/drm/i915/display/intel_combo_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> @@ -187,10 +187,16 @@ static bool has_phy_misc(struct drm_i915_private *i915, enum phy phy)
>  	 * Some platforms only expect PHY_MISC to be programmed for PHY-A and
>  	 * PHY-B and may not even have instances of the register for the
>  	 * other combo PHY's.
> +	 *
> +	 * ADL-S technically has three instances of PHY_MISC, but only requires
> +	 * that we program it for PHY A.
>  	 */
> -	if (IS_JSL_EHL(i915) ||
> -	    IS_ROCKETLAKE(i915) ||
> -	    IS_DG1(i915))
> +
> +	if (IS_ALDERLAKE_S(i915))
> +		return phy == PHY_A;
> +	else if (IS_JSL_EHL(i915) ||
> +		 IS_ROCKETLAKE(i915) ||
> +		 IS_DG1(i915))
>  		return phy < PHY_C;
>  
>  	return true;
> 

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-01-27  4:16 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27  4:11 [Intel-gfx] [PATCH 0/9] Final set of patches for ADLS enabling Aditya Swarup
2021-01-27  4:11 ` [Intel-gfx] [PATCH 1/9] drm/i915/adl_s: Update PHY_MISC programming Aditya Swarup
2021-01-27  4:16   ` Aditya Swarup [this message]
2021-01-27  4:11 ` [Intel-gfx] [PATCH 2/9] drm/i915/adl_s: MCHBAR memory info registers are moved Aditya Swarup
2021-01-27 15:07   ` Lucas De Marchi
2021-01-27 16:48     ` Souza, Jose
2021-01-28  5:54       ` Aditya Swarup
2021-01-27  4:11 ` [Intel-gfx] [PATCH 3/9] drm/i915/adl_s: Add power wells Aditya Swarup
2021-01-27  4:14   ` Aditya Swarup
2021-01-27  5:32   ` Matt Roper
2021-01-27  4:11 ` [Intel-gfx] [PATCH 4/9] drm/i915/adl_s: Re-use TGL GuC/HuC firmware Aditya Swarup
2021-01-27  4:11 ` [Intel-gfx] [PATCH 5/9] drm/i915/display: Add HAS_D12_PLANE_MINIMIZATION Aditya Swarup
2021-01-27  4:11 ` [Intel-gfx] [PATCH 6/9] drm/i915/adl_s: Load DMC Aditya Swarup
2021-01-27  4:15   ` Aditya Swarup
2021-01-27 15:15   ` Lucas De Marchi
2021-01-27  4:11 ` [Intel-gfx] [PATCH 7/9] drm/i915/adl_s: Update memory bandwidth parameters Aditya Swarup
2021-01-27  5:18   ` Matt Roper
2021-01-27  4:11 ` [Intel-gfx] [PATCH 8/9] drm/i915/adl_s: Add display WAs for ADL-S Aditya Swarup
2021-01-27  5:22   ` Matt Roper
2021-01-28  5:43     ` Aditya Swarup
2021-01-29 17:26       ` Souza, Jose
2021-01-27  4:11 ` [Intel-gfx] [PATCH 9/9] drm/i915/adl_s: Add GT and CTX " Aditya Swarup
2021-01-27  5:27   ` Matt Roper
2021-01-27  4:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Final set of patches for ADLS enabling Patchwork
2021-01-27  4:27 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-01-27  4:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-27  9:45 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2021-01-28  5:30 [Intel-gfx] [PATCH 0/9] " Aditya Swarup
2021-01-28  5:30 ` [Intel-gfx] [PATCH 1/9] drm/i915/adl_s: Update PHY_MISC programming Aditya Swarup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5f34b7f-fb18-0ff3-5507-65d230098ae2@intel.com \
    --to=aditya.swarup@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox