Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH v2] drm/i915/gsc: Only initialize GSC in tile 0
@ 2022-11-21  9:24 Alexander Usyskin
  2022-11-21  9:35 ` Winkler, Tomas
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Alexander Usyskin @ 2022-11-21  9:24 UTC (permalink / raw)
  To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
	Daniel Vetter, Tvrtko Ursulin
  Cc: Tomas Winkler, Alexander Usyskin, Vitaly Lubart, intel-gfx

From: José Roberto de Souza <jose.souza@intel.com>

For multi-tile setups the GSC operational only on the tile 0.
Skip GSC auxiliary device creation for all other tiles
in GSC device init code.
Initialize basic GSC fields and use the same path
as HECI1 (HECI_PXP) device disable.

Cc: Tomas Winkler <tomas.winkler@intel.com>
Cc: Vitaly Lubart <vitaly.lubart@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
---
V2: Move decision to skip initialization into GSC device init code.
    This initializes basic GSC fields and uses the same path
    as HECI1 (HECI_PXP) device disable.
    It is simpler and protects interrupt handler too.

 drivers/gpu/drm/i915/gt/intel_gsc.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_gsc.c b/drivers/gpu/drm/i915/gt/intel_gsc.c
index 976fdf27e790..bcc3605158db 100644
--- a/drivers/gpu/drm/i915/gt/intel_gsc.c
+++ b/drivers/gpu/drm/i915/gt/intel_gsc.c
@@ -174,6 +174,14 @@ static void gsc_init_one(struct drm_i915_private *i915, struct intel_gsc *gsc,
 	intf->irq = -1;
 	intf->id = intf_id;
 
+	/*
+	 * On the multi-tile setups the GSC is functional on the first tile only
+	 */
+	if (gsc_to_gt(gsc)->info.id != 0) {
+		drm_dbg(&i915->drm, "Not initializing gsc for remote tiles\n");
+		return;
+	}
+
 	if (intf_id == 0 && !HAS_HECI_PXP(i915))
 		return;
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-11-22 14:05 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-21  9:24 [Intel-gfx] [PATCH v2] drm/i915/gsc: Only initialize GSC in tile 0 Alexander Usyskin
2022-11-21  9:35 ` Winkler, Tomas
2022-11-21 11:55   ` Tvrtko Ursulin
2022-11-22 10:47     ` Winkler, Tomas
2022-11-21 12:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gsc: Only initialize GSC in tile 0 (rev2) Patchwork
2022-11-21 14:31 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-11-22 14:04   ` Souza, Jose

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox