Re: [Intel-wired-lan] [PATCH net-next 3/5] ice: add ability to query/set FW log level and resolution

[Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>]

On 11/29/2022 5:30 AM, Alexander Lobakin wrote:
> From: "Wilczynski, Michal" <michal.wilczynski@intel.com>
> Date: Tue, 29 Nov 2022 12:48:25 +0100
> 
>> On 11/28/2022 10:47 PM, Paul M Stillwell Jr wrote:
>>> The E8xx has the ability to change the FW log level and
>>> the granularity at which the logs get output. Enable
>>> the ability to see what the current values are and to
>>> change them.
>>>
>>> Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
> 
> [...]
> 
>>> +	/* send the cfg to FW and register for events */
>>> +	status = ice_fwlog_set(hw, &hw->fwlog_cfg);
>>> +	if (status)
>>> +		return status;
>>> +
>>> +	if (hw->fwlog_ena) {
>>> +		status = ice_fwlog_register(hw);
>>> +		if (status)
>>> +			return status;
>>> +	} else {
>>> +		status = ice_fwlog_unregister(hw);
>>> +		if (status)
>>> +			return status;
>>> +	}
>>
>> This could be simplified i.e
>>
>> if (hw->fwlog_ena) {
>> 	status = ice_fwlog_register(hw);
>> else
>>          status = ice_fwlog_unregister(hw);
>>
>> 	return status;
> 
> 	return hw->fwlog_ena ? ice_fwlog_register(hw) : ice_fwlog_unregister(hw);

Will change.

>>
>>
>>> +
>>> +	return 0;
>>> +}
> 
> [...]
> 
> Thanks,
> Olek

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan