Re: [Intel-wired-lan] [PATCH net-next 0/5] add v2 FW logging for ice driver

[Tony Nguyen <anthony.l.nguyen@intel.com>]

On 11/28/2022 1:47 PM, Paul M Stillwell Jr wrote:
> FW log support was added to the ice driver, but that version is no
> longer supported. There is a newer version of FW logging (v2) that
> adds more controls knobs to get the exact data out of the FW
> for debugging.
> 
> Additionally, instead of dumping the FW log output to syslog,
> dump it to debugfs. The FW log data is really just binary
> data that the FW log team decodes to determine what happens so the
> translation from binary to some text output just slows things down
> and results in potential dropped data. The structure for the debugfs
> entry is: /sys/kernel/debug/ice/<pci device>/fwlog
> 
> Once enabled the FW log data is received as ARQ events that the driver
> processes.
> 
> The FW logging is across all the PFs on the device, so restrict the
> commands to only PF0.
> 
> The following new device parameters are added:
> - fwlog_supported (read-only): does the FW support FW logging
> - fwlog_enabled (read/write): is FW logging currently running
> - fwlog_level (read/write): the log level enabled, valid values are
>      Each level includes the messages from the previous/lower level
> 	0 - no logging
> 	1 - error logging
> 	2 - warning logging
> 	3 - normal logging
> 	4 - verbose logging
> - fwlog_resolution (read/write): the number of log messages to included
>    in a single ARQ event. The range is 1-128 (1 means push every log
>    message, 128 means push only when the max AQ command buffer is full).
>    The suggested value is 10.
> 
> This patch series adds the following set of devlink commands:
> 
> devlink dev param set <pci dev> name fwlog_enabled value <true/false> cmode runtime
> devlink dev param set <pci dev> name fwlog_level value <0-4> cmode runtime
> devlink dev param set <pci dev> name fwlog_resolution value <1-128> cmode runtime
> 
> Paul M Stillwell Jr (5):
>    ice: remove FW logging code
>    ice: enable devlink to check FW logging status
>    ice: add ability to query/set FW log level and resolution
>    ice: disable FW logging on driver unload
>    ice: use debugfs to output FW log data
> 
>   drivers/net/ethernet/intel/ice/Makefile       |   4 +-
>   drivers/net/ethernet/intel/ice/ice.h          |  24 ++
>   .../net/ethernet/intel/ice/ice_adminq_cmd.h   | 164 ++++----
>   drivers/net/ethernet/intel/ice/ice_common.c   | 218 +---------
>   drivers/net/ethernet/intel/ice/ice_debugfs.c  | 109 +++++
>   drivers/net/ethernet/intel/ice/ice_devlink.c  | 205 ++++++++-
>   drivers/net/ethernet/intel/ice/ice_fwlog.c    | 394 ++++++++++++++++++
>   drivers/net/ethernet/intel/ice/ice_fwlog.h    |  56 +++
>   drivers/net/ethernet/intel/ice/ice_main.c     |  99 ++++-
>   drivers/net/ethernet/intel/ice/ice_type.h     |  23 +-

Please add Documentation for this

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan