Re: [Intel-wired-lan] [PATCH net-next 5/5] ice: use debugfs to output FW log data

[Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>]

On 11/29/2022 5:53 AM, Paul Menzel wrote:
> Dear Paul,
> 
> 
> Am 28.11.22 um 22:47 schrieb Paul M Stillwell Jr:
>> The FW log data can be quite large so we don't want to use syslog.
>> Instead take advantage of debugfs to write the data to.
>>
>> Also, a previous patch addded codde to disable FW logging when
> 
> added code
> 

Good catch, will fix.

>> the driver was unloaded. The code was added to
>> ice_devlink_unregister(), which didn't seem correct so move the
>> disabling of FW logging on driver unload to a better place.
> 
> It’d be great if you added examples, how to get the log from debugfs, 
> and decode(?) it.
> 

Will do

> 
> Kind regards,
> 
> Paul
> 
> 
>> Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
>> ---
>>   drivers/net/ethernet/intel/ice/Makefile       |   3 +-
>>   drivers/net/ethernet/intel/ice/ice.h          |  24 ++++
>>   .../net/ethernet/intel/ice/ice_adminq_cmd.h   |   2 +
>>   drivers/net/ethernet/intel/ice/ice_debugfs.c  | 109 ++++++++++++++++++
>>   drivers/net/ethernet/intel/ice/ice_devlink.c  |  20 ----
>>   drivers/net/ethernet/intel/ice/ice_main.c     |  98 ++++++++++++++++
>>   6 files changed, 235 insertions(+), 21 deletions(-)
>>   create mode 100644 drivers/net/ethernet/intel/ice/ice_debugfs.c
> 
> […]

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan