Re: [PATCH v2 19/34] drm/xe/vf: Extra debug on GGTT shift

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 9/24/2025 3:15 AM, Matthew Brost wrote:
> A little extra debug on GGTT shift printing the GGT shift value is

s/GGT/GGTT

and maybe consider some rewording as I'm not sure it's right

> helpful for VF post-migration recovery.
> 
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_gt_sriov_vf.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_vf.c b/drivers/gpu/drm/xe/xe_gt_sriov_vf.c
> index a96e0dd65bc1..e79ab4a2a273 100644
> --- a/drivers/gpu/drm/xe/xe_gt_sriov_vf.c
> +++ b/drivers/gpu/drm/xe/xe_gt_sriov_vf.c
> @@ -475,8 +475,11 @@ static int vf_get_ggtt_info(struct xe_gt *gt, bool recovery)
>  		primary_config->ggtt_base = start;
>  	err = config->ggtt_size ? 0 : -ENODATA;
>  
> -	if (!err && shift && recovery)
> +	if (!err && shift && recovery) {
> +		xe_gt_sriov_info(gt, "Shifting GGTT %lld -> 0x%016llx\n",
> +				 shift, config->ggtt_base);

since this is "info" level message, maybe we can make it as:

		"Shifting GGTT base by %lld to 0x%016llx\n"

>  		xe_tile_sriov_vf_fixup_ggtt_nodes(gt_to_tile(gt), shift);

and print this from within this tile based function, where we could
use tile-based printk function (instead of currently used GT-based)

> +	}
>  out:
>  	up_write(config->lock);
>  	return err;