Re: [PATCH 3/9] drm/xe/vf: Don't apply tile workarounds if VF

["Piotr Piórkowski" <piotr.piorkowski@intel.com>]

Michal Wajdeczko <michal.wajdeczko@intel.com> wrote on śro [2024-cze-19 23:45:51 +0200]:
> The VF drivers can't apply any workarounds as they don't have
> access to related registers. Since xe_wa_apply_tile_workarounds()
> function is not using RTP yet, we have to add early return.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_wa.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
> index 0b6fbbebc41e..73dd06ad50f8 100644
> --- a/drivers/gpu/drm/xe/xe_wa.c
> +++ b/drivers/gpu/drm/xe/xe_wa.c
> @@ -21,6 +21,7 @@
>  #include "xe_mmio.h"
>  #include "xe_platform_types.h"
>  #include "xe_rtp.h"
> +#include "xe_sriov.h"
>  #include "xe_step.h"
>  
>  /**
> @@ -865,6 +866,9 @@ void xe_wa_apply_tile_workarounds(struct xe_tile *tile)
>  {
>  	struct xe_gt *mmio = tile->primary_gt;
>  
> +	if (IS_SRIOV_VF(tile->xe))
> +		return;
> +
>  	if (XE_WA(mmio, 22010954014))
>  		xe_mmio_rmw32(mmio, XEHP_CLOCK_GATE_DIS, 0, SGSI_SIDECLK_DIS);
>  }

Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>

> -- 
> 2.43.0
> 

--