Re: [PATCH 8/9] drm/xe/vf: Skip engine ring enabling if VF

["Piotr Piórkowski" <piotr.piorkowski@intel.com>]

Michal Wajdeczko <michal.wajdeczko@intel.com> wrote on śro [2024-cze-19 23:45:56 +0200]:
> All engines will be correctly initialized by the PF driver.
> Moreover, VF drivers can't access related engine registers.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_hw_engine.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_hw_engine.c b/drivers/gpu/drm/xe/xe_hw_engine.c
> index 52f12009678e..78b50d3a6501 100644
> --- a/drivers/gpu/drm/xe/xe_hw_engine.c
> +++ b/drivers/gpu/drm/xe/xe_hw_engine.c
> @@ -547,7 +547,8 @@ static int hw_engine_init(struct xe_gt *gt, struct xe_hw_engine *hwe,
>  		if (hwe->class == XE_ENGINE_CLASS_OTHER)
>  			hwe->irq_handler = xe_gsc_hwe_irq_handler;
>  
> -		xe_hw_engine_enable_ring(hwe);
> +		if (!IS_SRIOV_VF(xe))
> +			xe_hw_engine_enable_ring(hwe);
>  	}
>  
>  	/* We reserve the highest BCS instance for USM */

Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>

> -- 
> 2.43.0
> 

--