Re: [PATCH 1/9] drm/xe/vf: Disable features that do not apply to VFs

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 20.06.2024 11:17, Piotr Piórkowski wrote:
> Michal Wajdeczko <michal.wajdeczko@intel.com> wrote on śro [2024-cze-19 23:45:49 +0200]:
>> We already maintain several flags that control the availability
>> of features on a given device. Disable features, like PCODE or
>> GuC PC or GSC, that do not apply to a VF device.
>>
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> ---
>>  drivers/gpu/drm/xe/xe_device.c | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
>> index 75d4c8ae9234..603e85da5748 100644
>> --- a/drivers/gpu/drm/xe/xe_device.c
>> +++ b/drivers/gpu/drm/xe/xe_device.c
>> @@ -486,6 +486,16 @@ static int wait_for_lmem_ready(struct xe_device *xe)
>>  	return 0;
>>  }
>>  
>> +static void update_device_info(struct xe_device *xe)
>> +{
>> +	/* disable features that are not available/applicable to VFs */
>> +	if (IS_SRIOV_VF(xe)) {
>> +		xe->info.has_heci_gscfi = 0;
>> +		xe->info.skip_guc_pc = 1;
>> +		xe->info.skip_pcode = 1;
>> +	}
> I have no objection to the current modifications of device_info on VF,
> but it seems to me that the setting of has_diplay to false is missing here,
> as VF does not support it.

thanks for catching this, as I missed due to my CONFIG_DRM_XE_DISPLAY=n

> 
> Thanks,
> Piotr
> 
>> +}
>> +
>>  /**
>>   * xe_device_probe_early: Device early probe
>>   * @xe: xe device instance
>> @@ -506,6 +516,8 @@ int xe_device_probe_early(struct xe_device *xe)
>>  
>>  	xe_sriov_probe_early(xe);
>>  
>> +	update_device_info(xe);
>> +
>>  	err = xe_pcode_probe_early(xe);
>>  	if (err)
>>  		return err;
> 
>> -- 
>> 2.43.0
>>
>