Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Animesh Manna <animesh.manna@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jouni.hogander@intel.com, jani.nikula@intel.com,
	jeevan.b@intel.com, Animesh Manna <animesh.manna@intel.com>
Subject: [PATCH v7 2/8] drm/i915/lobf: Add debug print for LOBF
Date: Thu,  3 Apr 2025 14:58:19 +0530	[thread overview]
Message-ID: <20250403092825.484347-3-animesh.manna@intel.com> (raw)
In-Reply-To: <20250403092825.484347-1-animesh.manna@intel.com>

Lobf is enabled part of ALPM configuration and if has_lobf
is set to true respective bit for LOBF will be set. Add debug
print while setting the bitfield of LOBF.

Signed-off-by: Animesh Manna <animesh.manna@intel.com>
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_alpm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c
index 354510bb437d..5293cbd02988 100644
--- a/drivers/gpu/drm/i915/display/intel_alpm.c
+++ b/drivers/gpu/drm/i915/display/intel_alpm.c
@@ -353,8 +353,10 @@ static void lnl_alpm_configure(struct intel_dp *intel_dp,
 			ALPM_CTL_EXTENDED_FAST_WAKE_TIME(intel_dp->alpm_parameters.fast_wake_lines);
 	}
 
-	if (crtc_state->has_lobf)
+	if (crtc_state->has_lobf) {
 		alpm_ctl |= ALPM_CTL_LOBF_ENABLE;
+		drm_dbg_kms(display->drm, "Link off between frames (LOBF) enabled\n");
+	}
 
 	alpm_ctl |= ALPM_CTL_ALPM_ENTRY_CHECK(intel_dp->alpm_parameters.check_entry_lines);
 
-- 
2.29.0


  parent reply	other threads:[~2025-04-03  9:51 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-03  9:28 [PATCH v7 0/8] LOBF enablement fix Animesh Manna
2025-04-03  9:28 ` [PATCH v7 1/8] drm/i915/lobf: Add lobf enablement in post plane update Animesh Manna
2025-04-03  9:28 ` Animesh Manna [this message]
2025-04-08  7:49   ` [PATCH v7 2/8] drm/i915/lobf: Add debug print for LOBF Hogander, Jouni
2025-04-08  7:57     ` Manna, Animesh
2025-04-08  7:58       ` Hogander, Jouni
2025-04-03  9:28 ` [PATCH v7 3/8] drm/i915/lobf: Disintegrate alpm_disable from psr_disable Animesh Manna
2025-04-08  7:51   ` Hogander, Jouni
2025-04-03  9:28 ` [PATCH v7 4/8] drm/i915/lobf: Add fixed refresh rate check in compute_config() Animesh Manna
2025-04-03  9:28 ` [PATCH v7 5/8] drm/i915/lobf: Update lobf if any change in dependent parameters Animesh Manna
2025-04-08  7:54   ` Hogander, Jouni
2025-04-08  8:01     ` Manna, Animesh
2025-04-03  9:28 ` [PATCH v7 6/8] drm/i915/lobf: Add debug interface for lobf Animesh Manna
2025-04-08  8:01   ` Hogander, Jouni
2025-04-03  9:28 ` [PATCH v7 7/8] drm/i915/lobf: Add mutex for alpm update Animesh Manna
2025-04-03  9:28 ` [PATCH v7 8/8] drm/i915/lobf: Check for sink error and disable LOBF Animesh Manna
2025-04-08  8:14   ` Hogander, Jouni
2025-04-03  9:56 ` ✓ CI.Patch_applied: success for LOBF enablement fix (rev6) Patchwork
2025-04-03  9:57 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-03  9:58 ` ✓ CI.KUnit: success " Patchwork
2025-04-03 10:14 ` ✓ CI.Build: " Patchwork
2025-04-03 10:17 ` ✓ CI.Hooks: " Patchwork
2025-04-03 10:18 ` ✗ CI.checksparse: warning " Patchwork
2025-04-03 10:38 ` ✓ Xe.CI.BAT: success " Patchwork
2025-04-03 13:32 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250403092825.484347-3-animesh.manna@intel.com \
    --to=animesh.manna@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jeevan.b@intel.com \
    --cc=jouni.hogander@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox