Re: [PATCH v7 2/8] drm/i915/lobf: Add debug print for LOBF

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Thu, 2025-04-03 at 14:58 +0530, Animesh Manna wrote:
> Lobf is enabled part of ALPM configuration and if has_lobf
> is set to true respective bit for LOBF will be set. Add debug
> print while setting the bitfield of LOBF.

I think you should add also debug print about disabling LOBF. How about
two more printouts alpm enable and alpm disable?

BR,

Jouni Högander

> 
> Signed-off-by: Animesh Manna <animesh.manna@intel.com>
> Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_alpm.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c
> b/drivers/gpu/drm/i915/display/intel_alpm.c
> index 354510bb437d..5293cbd02988 100644
> --- a/drivers/gpu/drm/i915/display/intel_alpm.c
> +++ b/drivers/gpu/drm/i915/display/intel_alpm.c
> @@ -353,8 +353,10 @@ static void lnl_alpm_configure(struct intel_dp
> *intel_dp,
>  			ALPM_CTL_EXTENDED_FAST_WAKE_TIME(intel_dp-
> >alpm_parameters.fast_wake_lines);
>  	}
>  
> -	if (crtc_state->has_lobf)
> +	if (crtc_state->has_lobf) {
>  		alpm_ctl |= ALPM_CTL_LOBF_ENABLE;
> +		drm_dbg_kms(display->drm, "Link off between frames
> (LOBF) enabled\n");
> +	}
>  
>  	alpm_ctl |= ALPM_CTL_ALPM_ENTRY_CHECK(intel_dp-
> >alpm_parameters.check_entry_lines);
>