From: Animesh Manna <animesh.manna@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jouni.hogander@intel.com, jani.nikula@intel.com,
jeevan.b@intel.com, Animesh Manna <animesh.manna@intel.com>
Subject: [PATCH v7 5/8] drm/i915/lobf: Update lobf if any change in dependent parameters
Date: Thu, 3 Apr 2025 14:58:22 +0530 [thread overview]
Message-ID: <20250403092825.484347-6-animesh.manna@intel.com> (raw)
In-Reply-To: <20250403092825.484347-1-animesh.manna@intel.com>
For every commit the dependent condition for LOBF is checked
and accordingly update has_lobf flag which will be used
to update the ALPM_CTL register during commit.
v1: Initial version.
v2: Avoid reading h/w register without has_lobf check. [Jani]
v3: Update LOBF in post plane update instead of separate function. [Jouni]
v4:
- Add lobf disable print. [Jouni]
- Simplify condition check for enabling/disabling lobf. [Jouni]
Signed-off-by: Animesh Manna <animesh.manna@intel.com>
---
drivers/gpu/drm/i915/display/intel_alpm.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c
index aae2c322baa7..7ab29c5fef38 100644
--- a/drivers/gpu/drm/i915/display/intel_alpm.c
+++ b/drivers/gpu/drm/i915/display/intel_alpm.c
@@ -360,6 +360,8 @@ static void lnl_alpm_configure(struct intel_dp *intel_dp,
if (crtc_state->has_lobf) {
alpm_ctl |= ALPM_CTL_LOBF_ENABLE;
drm_dbg_kms(display->drm, "Link off between frames (LOBF) enabled\n");
+ } else {
+ drm_dbg_kms(display->drm, "Link off between frames (LOBF) disabled\n");
}
alpm_ctl |= ALPM_CTL_ALPM_ENTRY_CHECK(intel_dp->alpm_parameters.check_entry_lines);
@@ -380,9 +382,12 @@ void intel_alpm_post_plane_update(struct intel_atomic_state *state,
struct intel_display *display = to_intel_display(state);
const struct intel_crtc_state *crtc_state =
intel_atomic_get_new_crtc_state(state, crtc);
+ const struct intel_crtc_state *old_crtc_state =
+ intel_atomic_get_old_crtc_state(state, crtc);
struct intel_encoder *encoder;
- if (!crtc_state->has_lobf && !crtc_state->has_psr)
+ if (!(crtc_state->has_lobf != old_crtc_state->has_lobf) &&
+ !crtc_state->has_psr)
return;
for_each_intel_encoder_mask(display->drm, encoder,
--
2.29.0
next prev parent reply other threads:[~2025-04-03 9:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 9:28 [PATCH v7 0/8] LOBF enablement fix Animesh Manna
2025-04-03 9:28 ` [PATCH v7 1/8] drm/i915/lobf: Add lobf enablement in post plane update Animesh Manna
2025-04-03 9:28 ` [PATCH v7 2/8] drm/i915/lobf: Add debug print for LOBF Animesh Manna
2025-04-08 7:49 ` Hogander, Jouni
2025-04-08 7:57 ` Manna, Animesh
2025-04-08 7:58 ` Hogander, Jouni
2025-04-03 9:28 ` [PATCH v7 3/8] drm/i915/lobf: Disintegrate alpm_disable from psr_disable Animesh Manna
2025-04-08 7:51 ` Hogander, Jouni
2025-04-03 9:28 ` [PATCH v7 4/8] drm/i915/lobf: Add fixed refresh rate check in compute_config() Animesh Manna
2025-04-03 9:28 ` Animesh Manna [this message]
2025-04-08 7:54 ` [PATCH v7 5/8] drm/i915/lobf: Update lobf if any change in dependent parameters Hogander, Jouni
2025-04-08 8:01 ` Manna, Animesh
2025-04-03 9:28 ` [PATCH v7 6/8] drm/i915/lobf: Add debug interface for lobf Animesh Manna
2025-04-08 8:01 ` Hogander, Jouni
2025-04-03 9:28 ` [PATCH v7 7/8] drm/i915/lobf: Add mutex for alpm update Animesh Manna
2025-04-03 9:28 ` [PATCH v7 8/8] drm/i915/lobf: Check for sink error and disable LOBF Animesh Manna
2025-04-08 8:14 ` Hogander, Jouni
2025-04-03 9:56 ` ✓ CI.Patch_applied: success for LOBF enablement fix (rev6) Patchwork
2025-04-03 9:57 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-03 9:58 ` ✓ CI.KUnit: success " Patchwork
2025-04-03 10:14 ` ✓ CI.Build: " Patchwork
2025-04-03 10:17 ` ✓ CI.Hooks: " Patchwork
2025-04-03 10:18 ` ✗ CI.checksparse: warning " Patchwork
2025-04-03 10:38 ` ✓ Xe.CI.BAT: success " Patchwork
2025-04-03 13:32 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250403092825.484347-6-animesh.manna@intel.com \
--to=animesh.manna@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jeevan.b@intel.com \
--cc=jouni.hogander@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox