From: "Michael J. Ruhl" <michael.j.ruhl@intel.com>
To: platform-driver-x86@vger.kernel.org,
intel-xe@lists.freedesktop.org, hansg@kernel.org,
ilpo.jarvinen@linux.intel.com, matthew.brost@intel.com,
rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com,
airlied@gmail.com, simona@ffwll.ch, david.e.box@linux.intel.com,
anoop.c.vijay@intel.com, badal.nilawar@intel.com,
matthew.d.roper@intel.com, james.ausmus@intel.com,
karthik.poosa@intel.com
Subject: [PATCH v10 20/20] drm/xe/vsec: Refactor platform check
Date: Fri, 18 Sep 2026 06:18:11 -0700 [thread overview]
Message-ID: <20260918131751.2408883-42-michael.j.ruhl@intel.com> (raw)
In-Reply-To: <20260918131751.2408883-22-michael.j.ruhl@intel.com>
For debugfs, residencies and pcode_info are available on the BMG and
CRI (!SRIOV_VF) platforms.
Refactor to have one code path for adding the debugfs entries.
Reviewed-by: Karthik Poosa <karthik.poosa@intel.com>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
drivers/gpu/drm/xe/xe_debugfs.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_debugfs.c b/drivers/gpu/drm/xe/xe_debugfs.c
index c56f0e4a9b90..d90fa2dc6231 100644
--- a/drivers/gpu/drm/xe/xe_debugfs.c
+++ b/drivers/gpu/drm/xe/xe_debugfs.c
@@ -761,23 +761,22 @@ void xe_debugfs_register(struct xe_device *xe)
ARRAY_SIZE(debugfs_list),
root, minor);
- if (xe->info.platform == XE_BATTLEMAGE && !IS_SRIOV_VF(xe)) {
- drm_debugfs_create_files(debugfs_residencies,
- ARRAY_SIZE(debugfs_residencies),
- root, minor);
- }
-
/*
- * Pcode version read from PMT is currently only supported on CRI and BMG platforms in PF
- * mode, as both platforms support the necessary telemetry read mechanism and have a fixed
- * PUNIT_VERSION_OFFSET.
+ * Residencies and Pcode version read from PMT is currently only supported on CRI and BMG
+ * platforms in PF mode. Both platforms support the necessary telemetry read mechanism
+ * and have a fixed offsets for the required data.
* Attempting this access on other platforms must be verified before enabling support.
*/
if (!IS_SRIOV_VF(xe) &&
- (xe->info.platform == XE_CRESCENTISLAND || xe->info.platform == XE_BATTLEMAGE))
+ (xe->info.platform == XE_CRESCENTISLAND || xe->info.platform == XE_BATTLEMAGE)) {
+ drm_debugfs_create_files(debugfs_residencies,
+ ARRAY_SIZE(debugfs_residencies),
+ root, minor);
+
drm_debugfs_create_files(pcode_info_debugfs,
ARRAY_SIZE(pcode_info_debugfs),
root, minor);
+ }
debugfs_create_file("forcewake_all", 0400, root, xe,
&forcewake_all_fops);
--
2.43.0
next prev parent reply other threads:[~2026-09-18 13:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 13:17 [PATCH v10 00/20] Crescent Island PMT support Michael J. Ruhl
2026-09-18 13:17 ` [PATCH v10 01/20] platform/x86/intel/pmt: complete pcidev to device update Michael J. Ruhl
2026-09-18 13:17 ` [PATCH v10 02/20] platform/x86/intel/pmt: refactor rmw with a return value Michael J. Ruhl
2026-09-18 13:17 ` [PATCH v10 03/20] platform/x86/intel/pmt: refactor rc " Michael J. Ruhl
2026-09-18 13:17 ` [PATCH v10 04/20] platform/x86/intel/pmt: Add register access callbacks Michael J. Ruhl
2026-09-18 13:17 ` [PATCH v10 05/20] platform/x86/intel/pmt: Do not remap when using callbacks Michael J. Ruhl
2026-09-18 13:17 ` [PATCH v10 06/20] drm/xe/vsec: Do not register BMG PMT for VF Michael J. Ruhl
2026-09-18 16:07 ` Rodrigo Vivi
2026-09-18 13:17 ` [PATCH v10 07/20] drm/xe/vsec: Correct locking order Michael J. Ruhl
2026-09-18 16:08 ` Rodrigo Vivi
2026-09-18 13:17 ` [PATCH v10 08/20] drm/xe/vsec: Use correct pm state get Michael J. Ruhl
2026-09-18 13:18 ` [PATCH v10 09/20] drm/xe/vsec: Add DOC text for VSEC Michael J. Ruhl
2026-09-18 13:18 ` [PATCH v10 10/20] drm/xe/vsec: Support possible hotplug exit Michael J. Ruhl
2026-09-18 13:29 ` sashiko-bot
2026-09-18 13:18 ` [PATCH v10 11/20] drm/xe/vsec: Refactor BattleMage PMT defines Michael J. Ruhl
2026-09-18 13:18 ` [PATCH v10 12/20] drm/xe/vsec: Update VSEC probe order Michael J. Ruhl
2026-09-18 13:18 ` [PATCH v10 13/20] drm/xe/vsec: Add base_offset to allow for more flexibilty Michael J. Ruhl
2026-09-18 13:18 ` [PATCH v10 14/20] drm/xe/vsec: Support Crescent Island PMT Michael J. Ruhl
2026-09-18 13:18 ` [PATCH v10 15/20] drm/xe/vsec: Crescent Island PMT decode Michael J. Ruhl
2026-09-18 13:18 ` [PATCH v10 16/20] drm/xe/vsec: Crescent Island PMT callbacks Michael J. Ruhl
2026-09-18 16:09 ` Rodrigo Vivi
2026-09-18 13:18 ` [PATCH v10 17/20] drm/xe/vsec: Support late bind fw information Michael J. Ruhl
2026-09-18 13:41 ` sashiko-bot
2026-09-18 13:18 ` [PATCH v10 18/20] drm/xe/vsec: Add PMT GUID internal access Michael J. Ruhl
2026-09-18 13:18 ` [PATCH v10 19/20] drm/xe/vsec: Update PMT " Michael J. Ruhl
2026-09-18 13:18 ` Michael J. Ruhl [this message]
2026-09-18 13:58 ` ✗ CI.checkpatch: warning for Crescent Island PMT support (rev12) Patchwork
2026-09-18 14:00 ` ✓ CI.KUnit: success " Patchwork
2026-09-18 15:36 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-09-18 23:14 ` ✗ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918131751.2408883-42-michael.j.ruhl@intel.com \
--to=michael.j.ruhl@intel.com \
--cc=airlied@gmail.com \
--cc=anoop.c.vijay@intel.com \
--cc=badal.nilawar@intel.com \
--cc=david.e.box@linux.intel.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=james.ausmus@intel.com \
--cc=karthik.poosa@intel.com \
--cc=matthew.brost@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox