From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "Michael J. Ruhl" <michael.j.ruhl@intel.com>
Cc: <platform-driver-x86@vger.kernel.org>,
<intel-xe@lists.freedesktop.org>, <hansg@kernel.org>,
<ilpo.jarvinen@linux.intel.com>, <matthew.brost@intel.com>,
<thomas.hellstrom@linux.intel.com>, <airlied@gmail.com>,
<simona@ffwll.ch>, <david.e.box@linux.intel.com>,
<anoop.c.vijay@intel.com>, <badal.nilawar@intel.com>,
<matthew.d.roper@intel.com>, <james.ausmus@intel.com>,
<karthik.poosa@intel.com>
Subject: Re: [PATCH v10 06/20] drm/xe/vsec: Do not register BMG PMT for VF
Date: Fri, 18 Sep 2026 12:07:37 -0400 [thread overview]
Message-ID: <aq1hyU7wKLzdLkI3@intel.com> (raw)
In-Reply-To: <20260918131751.2408883-28-michael.j.ruhl@intel.com>
On Fri, Sep 18, 2026 at 06:17:57AM -0700, Michael J. Ruhl wrote:
> BMG PMT is not supported for VF nodes.
>
> If IS_SRIOV_VF() is true, do NOT register with PMT.
>
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/xe/xe_vsec.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
> index a9baf0bfe572..481bcbcc6372 100644
> --- a/drivers/gpu/drm/xe/xe_vsec.c
> +++ b/drivers/gpu/drm/xe/xe_vsec.c
> @@ -149,6 +149,8 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse
> u32 offset;
> int ret;
>
> + xe_assert(xe, !IS_SRIOV_VF(xe));
> +
> ret = xe_guid_decode(guid, &mem_region, &offset);
> if (ret)
> return ret;
> @@ -157,9 +159,6 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse
>
> guard(mutex)(&xe->pmt.lock);
>
> - if (!xe->soc_remapper.set_telem_region)
> - return -ENODEV;
> -
> /* indicate that we are not at an appropriate power level */
> if (!xe_pm_runtime_get_if_active(xe))
> return -ENODATA;
> @@ -186,6 +185,9 @@ static enum xe_vsec get_platform_info(struct xe_device *xe)
> if (xe->info.platform > XE_BATTLEMAGE)
> return XE_VSEC_UNKNOWN;
>
> + if (IS_SRIOV_VF(xe) && (xe->info.platform == XE_BATTLEMAGE))
> + return XE_VSEC_UNKNOWN;
> +
> return vsec_platforms[xe->info.platform];
> }
>
> --
> 2.43.0
>
next prev parent reply other threads:[~2026-09-18 16:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 13:17 [PATCH v10 00/20] Crescent Island PMT support Michael J. Ruhl
2026-09-18 13:17 ` [PATCH v10 01/20] platform/x86/intel/pmt: complete pcidev to device update Michael J. Ruhl
2026-09-18 13:17 ` [PATCH v10 02/20] platform/x86/intel/pmt: refactor rmw with a return value Michael J. Ruhl
2026-09-18 13:17 ` [PATCH v10 03/20] platform/x86/intel/pmt: refactor rc " Michael J. Ruhl
2026-09-18 13:17 ` [PATCH v10 04/20] platform/x86/intel/pmt: Add register access callbacks Michael J. Ruhl
2026-09-18 13:17 ` [PATCH v10 05/20] platform/x86/intel/pmt: Do not remap when using callbacks Michael J. Ruhl
2026-09-18 13:17 ` [PATCH v10 06/20] drm/xe/vsec: Do not register BMG PMT for VF Michael J. Ruhl
2026-09-18 16:07 ` Rodrigo Vivi [this message]
2026-09-18 13:17 ` [PATCH v10 07/20] drm/xe/vsec: Correct locking order Michael J. Ruhl
2026-09-18 16:08 ` Rodrigo Vivi
2026-09-18 13:17 ` [PATCH v10 08/20] drm/xe/vsec: Use correct pm state get Michael J. Ruhl
2026-09-18 13:18 ` [PATCH v10 09/20] drm/xe/vsec: Add DOC text for VSEC Michael J. Ruhl
2026-09-18 13:18 ` [PATCH v10 10/20] drm/xe/vsec: Support possible hotplug exit Michael J. Ruhl
2026-09-18 13:29 ` sashiko-bot
2026-09-18 13:18 ` [PATCH v10 11/20] drm/xe/vsec: Refactor BattleMage PMT defines Michael J. Ruhl
2026-09-18 13:18 ` [PATCH v10 12/20] drm/xe/vsec: Update VSEC probe order Michael J. Ruhl
2026-09-18 13:18 ` [PATCH v10 13/20] drm/xe/vsec: Add base_offset to allow for more flexibilty Michael J. Ruhl
2026-09-18 13:18 ` [PATCH v10 14/20] drm/xe/vsec: Support Crescent Island PMT Michael J. Ruhl
2026-09-18 13:18 ` [PATCH v10 15/20] drm/xe/vsec: Crescent Island PMT decode Michael J. Ruhl
2026-09-18 13:18 ` [PATCH v10 16/20] drm/xe/vsec: Crescent Island PMT callbacks Michael J. Ruhl
2026-09-18 16:09 ` Rodrigo Vivi
2026-09-18 13:18 ` [PATCH v10 17/20] drm/xe/vsec: Support late bind fw information Michael J. Ruhl
2026-09-18 13:41 ` sashiko-bot
2026-09-18 13:18 ` [PATCH v10 18/20] drm/xe/vsec: Add PMT GUID internal access Michael J. Ruhl
2026-09-18 13:18 ` [PATCH v10 19/20] drm/xe/vsec: Update PMT " Michael J. Ruhl
2026-09-18 13:18 ` [PATCH v10 20/20] drm/xe/vsec: Refactor platform check Michael J. Ruhl
2026-09-18 13:58 ` ✗ CI.checkpatch: warning for Crescent Island PMT support (rev12) Patchwork
2026-09-18 14:00 ` ✓ CI.KUnit: success " Patchwork
2026-09-18 15:36 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-09-18 23:14 ` ✗ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aq1hyU7wKLzdLkI3@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=airlied@gmail.com \
--cc=anoop.c.vijay@intel.com \
--cc=badal.nilawar@intel.com \
--cc=david.e.box@linux.intel.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=james.ausmus@intel.com \
--cc=karthik.poosa@intel.com \
--cc=matthew.brost@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=michael.j.ruhl@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox