Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Suraj Kandpal <suraj.kandpal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com,
	dibin.moolakadan.subrahmanian@intel.com, animesh.manna@intel.com,
	Suraj Kandpal <suraj.kandpal@intel.com>
Subject: [PATCH 0/2] drm/i915/display: Couple of DC3co fixes
Date: Thu, 24 Sep 2026 11:27:33 +0530	[thread overview]
Message-ID: <20260924055734.2138787-1-suraj.kandpal@intel.com> (raw)

While looking at why DC3co sequences I came across some steps
that were missed or miscoded.
The first one is a plain missing register write. DC3co enabling is
double buffered on a CMTG delayed vblank and CHICKEN_DCPR_1 bit 5 picks
which CMTG that is, but we never program it. Setups running on CMTG B
end up armed off CMTG A's vblank and only work because the reset value
happens to be the one we want half the time.
The second one is us being stricter than the spec. We only allow DC3co
when pipe A drives port A or pipe B drives port B, but Bspec has no such
restriction and neither does CMTG, so an eDP panel on the other port
just loses DC3co for no reason.

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>

Suraj Kandpal (2):
  drm/i915/cmtg: Select the right CMTG vblank for DC3co
  drm/i915/display: Don't require a 1:1 pipe to port mapping for DC3co

 drivers/gpu/drm/i915/display/intel_cmtg.c          |  2 ++
 drivers/gpu/drm/i915/display/intel_display_power.c | 10 +++-------
 drivers/gpu/drm/i915/display/intel_display_regs.h  |  1 +
 3 files changed, 6 insertions(+), 7 deletions(-)

-- 
2.34.1


             reply	other threads:[~2026-09-24  5:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24  5:57 Suraj Kandpal [this message]
2026-09-24  5:57 ` [PATCH 1/2] drm/i915/cmtg: Select the right CMTG vblank for DC3co Suraj Kandpal
2026-09-25 10:52   ` Jani Nikula
2026-09-24  5:57 ` [PATCH 2/2] drm/i915/display: Don't require a 1:1 pipe to port mapping " Suraj Kandpal
2026-09-24  6:05   ` sashiko-bot
2026-09-24  6:12     ` Kandpal, Suraj
2026-09-28  7:01   ` Dibin Moolakadan Subrahmanian
2026-09-29  4:09     ` Kandpal, Suraj
2026-09-24  6:06 ` ✓ CI.KUnit: success for drm/i915/display: Couple of DC3co fixes Patchwork
2026-09-24  6:47 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-24 19:57 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260924055734.2138787-1-suraj.kandpal@intel.com \
    --to=suraj.kandpal@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=dibin.moolakadan.subrahmanian@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox