Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Suraj Kandpal <suraj.kandpal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com,
	dibin.moolakadan.subrahmanian@intel.com, animesh.manna@intel.com,
	Suraj Kandpal <suraj.kandpal@intel.com>
Subject: [PATCH 1/2] drm/i915/cmtg: Select the right CMTG vblank for DC3co
Date: Thu, 24 Sep 2026 11:27:35 +0530	[thread overview]
Message-ID: <20260924055734.2138787-2-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20260924055734.2138787-1-suraj.kandpal@intel.com>

The DC3co enable state change is double buffered on a CMTG delayed
vblank, and CHICKEN_DCPR_1 bit 5 picks which CMTG that is. We never
programmed it, so CMTG B setups ended up using CMTG A's vblank and only
worked by virtue of the reset value.

Bspec: 75253
Fixes: c588a324183b ("drm/i915/cmtg: Add trigger to enable/disable cmtg")
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_cmtg.c         | 2 ++
 drivers/gpu/drm/i915/display/intel_display_regs.h | 1 +
 2 files changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_cmtg.c b/drivers/gpu/drm/i915/display/intel_cmtg.c
index 3c0f5b2fb2e7..7db642b2c3f7 100644
--- a/drivers/gpu/drm/i915/display/intel_cmtg.c
+++ b/drivers/gpu/drm/i915/display/intel_cmtg.c
@@ -368,6 +368,8 @@ static void intel_cmtg_enable_ddi(const struct intel_crtc_state *crtc_state)
 	enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
 	u32 interrupt_mask = 0;
 
+	intel_de_rmw(display, GEN8_CHICKEN_DCPR_1, DC3CO_CMTG_VBLANK_SELECT,
+		     cpu_transcoder == TRANSCODER_B ? DC3CO_CMTG_VBLANK_SELECT : 0);
 	intel_de_rmw(display, TRANS_DDI_FUNC_CTL2(display, cpu_transcoder), 0, CMTG_SECONDARY_MODE);
 	intel_de_rmw(display, CMTG_SCANLINE_GB1(cpu_transcoder), 0, CMTG_HW_GB_ENABLE);
 	crtc->cmtg.enabled = true;
diff --git a/drivers/gpu/drm/i915/display/intel_display_regs.h b/drivers/gpu/drm/i915/display/intel_display_regs.h
index 8251ec15190b..6ac615087e0f 100644
--- a/drivers/gpu/drm/i915/display/intel_display_regs.h
+++ b/drivers/gpu/drm/i915/display/intel_display_regs.h
@@ -413,6 +413,7 @@
 #define   _LATENCY_REPORTING_REMOVED_PIPE_C	REG_BIT(25)
 #define   _LATENCY_REPORTING_REMOVED_PIPE_B	REG_BIT(24)
 #define   _LATENCY_REPORTING_REMOVED_PIPE_A	REG_BIT(23)
+#define   DC3CO_CMTG_VBLANK_SELECT		REG_BIT(5)
 #define   LATENCY_REPORTING_REMOVED(pipe)	_PICK((pipe), \
 						      _LATENCY_REPORTING_REMOVED_PIPE_A, \
 						      _LATENCY_REPORTING_REMOVED_PIPE_B, \
-- 
2.34.1


  reply	other threads:[~2026-09-24  5:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24  5:57 [PATCH 0/2] drm/i915/display: Couple of DC3co fixes Suraj Kandpal
2026-09-24  5:57 ` Suraj Kandpal [this message]
2026-09-25 10:52   ` [PATCH 1/2] drm/i915/cmtg: Select the right CMTG vblank for DC3co Jani Nikula
2026-09-24  5:57 ` [PATCH 2/2] drm/i915/display: Don't require a 1:1 pipe to port mapping " Suraj Kandpal
2026-09-24  6:05   ` sashiko-bot
2026-09-24  6:12     ` Kandpal, Suraj
2026-09-28  7:01   ` Dibin Moolakadan Subrahmanian
2026-09-29  4:09     ` Kandpal, Suraj
2026-09-24  6:06 ` ✓ CI.KUnit: success for drm/i915/display: Couple of DC3co fixes Patchwork
2026-09-24  6:47 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-24 19:57 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260924055734.2138787-2-suraj.kandpal@intel.com \
    --to=suraj.kandpal@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=dibin.moolakadan.subrahmanian@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox