Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Suraj Kandpal <suraj.kandpal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com,
	dibin.moolakadan.subrahmanian@intel.com, animesh.manna@intel.com,
	Suraj Kandpal <suraj.kandpal@intel.com>
Subject: [PATCH 2/2] drm/i915/display: Don't require a 1:1 pipe to port mapping for DC3co
Date: Thu, 24 Sep 2026 11:27:37 +0530	[thread overview]
Message-ID: <20260924055734.2138787-3-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20260924055734.2138787-1-suraj.kandpal@intel.com>

Bspec allows transcoder A and transcoder B to drive either port A or
port B with DC3co, and CMTG doesn't restrict this. Requiring
a strict 1:1 mapping on Xe3p_LPD just loses DC3co on eDP panels wired to
the other port.

Bspec: 75253
Fixes: d75ea53314db ("drm/i915/display: Add DC3CO compute and set target state in commit tail")
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_power.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index 1b60ce2dd00c..4ce941319664 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -427,18 +427,14 @@ void intel_display_power_dc3co_update(struct intel_display *display, u32 trigger
 static bool intel_dc3co_port_pipe_compatible(struct intel_dp *intel_dp,
 					     const struct intel_crtc_state *crtc_state)
 {
+	struct intel_display *display = to_intel_display(intel_dp);
 	struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
 	enum pipe pipe = to_intel_crtc(crtc_state->uapi.crtc)->pipe;
 	enum port port = dig_port->base.port;
 	int num_pipes = intel_crtc_num_joined_pipes(crtc_state);
 
-	/* Need to follow 1:1 mapping because of CMTG restriction */
-	if (DISPLAY_VER(to_intel_display(crtc_state)) == 35)
-		return num_pipes == 1 &&
-		       ((pipe == PIPE_A && port == PORT_A) ||
-			(pipe == PIPE_B && port == PORT_B));
-	else
-		return num_pipes == 1 && pipe <= PIPE_B && port <= PORT_B;
+	return DISPLAY_VER(display) == 35 && num_pipes == 1 && pipe <= PIPE_B &&
+		port <= PORT_B;
 }
 
 void intel_display_power_dc3co_compute(struct intel_atomic_state *state)
-- 
2.34.1


  parent reply	other threads:[~2026-09-24  5:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24  5:57 [PATCH 0/2] drm/i915/display: Couple of DC3co fixes Suraj Kandpal
2026-09-24  5:57 ` [PATCH 1/2] drm/i915/cmtg: Select the right CMTG vblank for DC3co Suraj Kandpal
2026-09-25 10:52   ` Jani Nikula
2026-09-24  5:57 ` Suraj Kandpal [this message]
2026-09-24  6:05   ` [PATCH 2/2] drm/i915/display: Don't require a 1:1 pipe to port mapping " sashiko-bot
2026-09-24  6:12     ` Kandpal, Suraj
2026-09-28  7:01   ` Dibin Moolakadan Subrahmanian
2026-09-29  4:09     ` Kandpal, Suraj
2026-09-24  6:06 ` ✓ CI.KUnit: success for drm/i915/display: Couple of DC3co fixes Patchwork
2026-09-24  6:47 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-24 19:57 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260924055734.2138787-3-suraj.kandpal@intel.com \
    --to=suraj.kandpal@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=dibin.moolakadan.subrahmanian@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox