Re: [PATCH v3 01/13] drm/xe/log: Add VRAM, PAT, and HWMON DRIVER_HARDWARE components

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

On 08-09-2026 04:15 pm, Dnyaneshwar Bhadane wrote:
> Register new DRIVER_HARDWARE log components for hardware I/O subsystems
> that currently lack structured error reporting:
>
>    - VRAM (ID 6): Virtual RAM access and BAR visibility errors
>    - PAT (ID 7): Page Attribute Table programming errors
>    - HWMON (ID 8): Hardware monitor registration and sensor errors
>
> All three use IO_BUS as their default SIGID since they interact with
> hardware through MMIO or PCode register paths.
>
> Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
LGTM,
Reviewed-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>

> ---
>   drivers/gpu/drm/xe/abi/xe_log_abi.h | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/abi/xe_log_abi.h b/drivers/gpu/drm/xe/abi/xe_log_abi.h
> index d6105520173e..4a60aa48fab1 100644
> --- a/drivers/gpu/drm/xe/abi/xe_log_abi.h
> +++ b/drivers/gpu/drm/xe/abi/xe_log_abi.h
> @@ -150,6 +150,9 @@ enum xe_log_location_bits {
>   	define(DRIVER_HARDWARE, 3, GT, GT_TDR, "Graphics Technology")		\
>   	define(DRIVER_HARDWARE, 4, LMTT, IO_BUS, "LMEM Translation Table")	\
>   	define(DRIVER_HARDWARE, 5, MEMIRQ, IO_BUS, "Memory Based IRQ")		\
> +	define(DRIVER_HARDWARE, 6, VRAM, IO_BUS, "Virtual RAM")			\
> +	define(DRIVER_HARDWARE, 7, PAT, IO_BUS, "Page Attribute Table")		\
> +	define(DRIVER_HARDWARE, 8, HWMON, IO_BUS, "Hardware Monitoring")	\
>   	/* */									\
>   	define(DRIVER_FEATURE, 1, PF, SW, "SR-IOV Physical Function")		\
>   	define(DRIVER_FEATURE, 2, VF, SW, "SR-IOV Virtual Function")		\