From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Cc: "Dugast, Francois" <Francois.Dugast@intel.com>,
"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>
Subject: Re: [Intel-xe] [PATCH 01/10] drm/xe/oa: Introduce OA uapi
Date: Thu, 07 Sep 2023 21:30:03 -0700 [thread overview]
Message-ID: <871qf9s2wk.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <ZPDwIn4o0s1xlxXx@intel.com>
On Thu, 31 Aug 2023 12:55:14 -0700, Vivi, Rodrigo wrote:
>
Rodrigo/Francois,
> On Tue, Aug 22, 2023 at 10:31:06AM +0200, Francois Dugast wrote:
> > Hi Ashutosh,
> >
> > On Mon, Aug 07, 2023 at 06:31:50PM -0700, Ashutosh Dixit wrote:
> > > OA uapi allows userspace to:
> > > * Read streams of performance counters written by hardware
> > > * Configure (and reconfigure) which sets of perf counters are captured as
> > > part of OA streams
> > > * Configure other properties (such as format and periodicity) of such
> > > captures.
> > > * Query associated parameters such as OA unit timestamp freq, oa_unit_id's
> > > for hw engines and OA ioctl version
> >
> > Also it would be nice to explicit somewhere what OA stands for, maybe
> > in the commit message as well.
I've added what OA stands for to the commit message of Patch 1.
https://patchwork.freedesktop.org/series/121084/#rev5
> > Please document the uapi structures, not only their members.
>
> Besides that, we need true API like documentation with examples showing
> how this is used. Please!
We are rapidly changing the OA uapi. uapi changes will be reviewed
(including UMD's) and accepted or rejected. I will add such documentation
after the uapi is close to being frozen.
Thanks.
--
Ashutosh
next prev parent reply other threads:[~2023-09-08 4:30 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 1:31 [Intel-xe] [PATCH 00/10] Add OA functionality to Xe Ashutosh Dixit
2023-08-08 1:31 ` [Intel-xe] [PATCH 01/10] drm/xe/oa: Introduce OA uapi Ashutosh Dixit
2023-08-08 22:59 ` Umesh Nerlige Ramappa
2023-08-15 19:29 ` Dixit, Ashutosh
2023-08-16 2:14 ` Umesh Nerlige Ramappa
2023-08-21 16:48 ` Dixit, Ashutosh
2023-09-01 1:07 ` Dixit, Ashutosh
2023-08-15 22:03 ` Dixit, Ashutosh
2023-08-16 1:11 ` Umesh Nerlige Ramappa
2023-08-16 1:30 ` Dixit, Ashutosh
2023-08-16 2:21 ` Umesh Nerlige Ramappa
2023-08-16 3:43 ` Dixit, Ashutosh
2023-08-16 19:58 ` Umesh Nerlige Ramappa
2023-08-16 20:38 ` Dixit, Ashutosh
2023-08-16 20:58 ` Dixit, Ashutosh
2023-08-21 4:48 ` Dixit, Ashutosh
2023-08-22 8:31 ` Francois Dugast
2023-08-31 19:55 ` Rodrigo Vivi
2023-08-31 20:12 ` Dixit, Ashutosh
2023-08-31 20:32 ` Rodrigo Vivi
2023-09-08 4:30 ` Dixit, Ashutosh [this message]
2023-08-08 1:31 ` [Intel-xe] [PATCH 02/10] drm/xe/oa: Add OA types Ashutosh Dixit
2023-08-08 1:31 ` [Intel-xe] [PATCH 03/10] drm/xe/oa: Add registers and GPU commands used by OA Ashutosh Dixit
2023-08-22 15:44 ` Umesh Nerlige Ramappa
2023-09-08 4:30 ` Dixit, Ashutosh
2023-08-08 1:31 ` [Intel-xe] [PATCH 04/10] drm/xe/oa: Module init/exit and probe/remove Ashutosh Dixit
2023-08-22 15:52 ` Umesh Nerlige Ramappa
2023-08-23 19:41 ` Umesh Nerlige Ramappa
2023-08-25 4:15 ` Dixit, Ashutosh
2023-08-08 1:31 ` [Intel-xe] [PATCH 05/10] drm/xe/oa: Add/remove config ioctl's Ashutosh Dixit
2023-08-08 1:31 ` [Intel-xe] [PATCH 06/10] drm/xe/oa: Start implementing OA stream open ioctl Ashutosh Dixit
2023-08-23 19:55 ` Umesh Nerlige Ramappa
2023-09-08 4:38 ` Dixit, Ashutosh
2023-08-08 1:31 ` [Intel-xe] [PATCH 07/10] drm/xe/oa: OA stream initialization Ashutosh Dixit
2023-08-08 1:31 ` [Intel-xe] [PATCH 08/10] drm/xe/oa: Expose OA stream fd Ashutosh Dixit
2023-08-08 1:31 ` [Intel-xe] [PATCH 09/10] drm/xe/oa: Read file_operation Ashutosh Dixit
2023-08-23 19:46 ` Umesh Nerlige Ramappa
2023-09-08 4:40 ` Dixit, Ashutosh
2023-08-08 1:31 ` [Intel-xe] [PATCH 10/10] drm/xe/oa: Implement queries Ashutosh Dixit
2023-08-22 15:55 ` Umesh Nerlige Ramappa
2023-08-08 2:04 ` [Intel-xe] ✓ CI.Patch_applied: success for Add OA functionality to Xe (rev3) Patchwork
2023-08-08 2:04 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-08-08 2:05 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-08-08 2:09 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-08-08 2:10 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-08-08 2:10 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-08-08 2:41 ` [Intel-xe] [PATCH 00/10] Add OA functionality to Xe Dixit, Ashutosh
2023-09-01 7:55 ` Lionel Landwerlin
2023-09-08 4:35 ` Dixit, Ashutosh
2023-08-08 2:45 ` [Intel-xe] ✗ CI.BAT: failure for Add OA functionality to Xe (rev3) Patchwork
2023-08-08 5:30 ` [Intel-xe] ✓ CI.Patch_applied: success for Add OA functionality to Xe (rev4) Patchwork
2023-08-08 5:30 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-08-08 5:31 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-08-08 5:35 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-08-08 5:35 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-08-08 5:36 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-08-08 6:10 ` [Intel-xe] ✗ CI.BAT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-07-21 2:28 [Intel-xe] [PATCH v2 00/10] Add OA functionality to Xe Ashutosh Dixit
2023-07-21 2:28 ` [Intel-xe] [PATCH 01/10] drm/xe/oa: Introduce OA uapi Ashutosh Dixit
2023-07-21 0:29 [Intel-xe] [PATCH 00/10] Add OA functionality to Xe Ashutosh Dixit
2023-07-21 0:29 ` [Intel-xe] [PATCH 01/10] drm/xe/oa: Introduce OA uapi Ashutosh Dixit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qf9s2wk.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=Francois.Dugast@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox