Re: [Intel-xe] [PATCH 04/10] drm/xe/oa: Module init/exit and probe/remove

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Wed, 23 Aug 2023 12:41:56 -0700, Umesh Nerlige Ramappa wrote:
>

Hi Umesh,

> On Tue, Aug 22, 2023 at 08:52:56AM -0700, Umesh Nerlige Ramappa wrote:
> > On Mon, Aug 07, 2023 at 06:31:53PM -0700, Ashutosh Dixit wrote:
> >> diff --git a/drivers/gpu/drm/xe/xe_gt_types.h b/drivers/gpu/drm/xe/xe_gt_types.h
> >> index 35b8c19fa8bf5..d6053f85dbb60 100644
> >> --- a/drivers/gpu/drm/xe/xe_gt_types.h
> >> +++ b/drivers/gpu/drm/xe/xe_gt_types.h
> >> @@ -13,6 +13,7 @@
> >> #include "xe_reg_sr_types.h"
> >> #include "xe_sa_types.h"
> >> #include "xe_uc_types.h"
> >> +#include "xe_oa.h"
> >>
> >> struct xe_exec_queue_ops;
> >> struct xe_migrate;
> >> @@ -346,6 +347,9 @@ struct xe_gt {
> >>		/** @oob: bitmap with active OOB workaroudns */
> >>		unsigned long *oob;
> >>	} wa_active;
> >> +
> >> +	/** @oa: oa perf counter subsystem per gt info */
> >> +	struct xe_oa_gt oa;
> >
> > I don't see a reference to this, so thought we could drop it. OR can you
> > point me to where this is used?
>
> yikes, not this. I wanted to comment on the xe_oa member in xe_device
> structure. The xe_oa is not used... I think.

No, both are used. xe_oa contains device level info (metric configs etc.)
and xe_oa_gt gt level info. Look at xe_oa_types.h.

There is a fair amount of code here, but to keep reviewing sane I had to
split it into multiple patches. But it maybe just easier to pull all the
patches and browse the code directly.

Likely the patches will not apply, but the latest version of this code
(rebased regularly on drm-xe-next) is maintained in the 'xe-oa' branch
here:

https://gitlab.freedesktop.org/adixit/kernel.git

So the easiest might be to just fetch this branch to browse the code.

Thanks.
--
Ashutosh