Re: [Intel-xe] [PATCH 01/10] drm/xe/oa: Introduce OA uapi

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Thu, 31 Aug 2023 12:55:14 -0700, Rodrigo Vivi wrote:
>

Hi Rodrigo,

> On Tue, Aug 22, 2023 at 10:31:06AM +0200, Francois Dugast wrote:
> > Hi Ashutosh,
> >
> > On Mon, Aug 07, 2023 at 06:31:50PM -0700, Ashutosh Dixit wrote:
> > > OA uapi allows userspace to:
> > > * Read streams of performance counters written by hardware
> > > * Configure (and reconfigure) which sets of perf counters are captured as
> > >   part of OA streams
> > > * Configure other properties (such as format and periodicity) of such
> > >   captures.
> > > * Query associated parameters such as OA unit timestamp freq, oa_unit_id's
> > >   for hw engines and OA ioctl version
> >
> > Please document the uapi structures, not only their members. Also it would
> > be nice to explicit somewhere what OA stands for, maybe in the commit
> > message as well.
>
> Besides that, we need true API like documentation with examples showing
> how this is used. Please!

Sorry, not following. What sort of "examples"? Are there similar examples
in xe_drm.h, could you please point them out so we know what to add. Or you
mean examples outside xe_drm.h, e.g. in Documentation/ e.g.?

The IGT series was also posted along with the kernel series here:

	https://patchwork.freedesktop.org/series/121082/

That has plenty of examples but probably that's not what you mean?

Thanks.
--
Ashutosh